tprouty/samba.git
11 years agoVERSION: Update version.
Karolin Seeger [Thu, 26 Jun 2008 11:24:40 +0000 (13:24 +0200)]
VERSION: Update version.

Karolin
(cherry picked from commit 3dfa6c3b34652c5b13b9f1fc299241214611a4e2)

11 years agoPart of fix for #5551. Split out the group enumeration functions to a BUILTIN and...
Jeremy Allison [Wed, 25 Jun 2008 22:23:52 +0000 (15:23 -0700)]
Part of fix for #5551. Split out the group enumeration functions to a BUILTIN and a Domain
specific version. Stops the domain groups appearing twice.
Jeremy.
(cherry picked from commit ee7af33ec6e752b1b1898b50aebc96e66ea423db)

11 years agoFinal (hopefully :-) part of fix for bug #5551. Allow passdb backend to enumerate...
Jeremy Allison [Wed, 25 Jun 2008 19:44:27 +0000 (12:44 -0700)]
Final (hopefully :-) part of fix for bug #5551. Allow passdb backend to enumerate domain groups.
Jeremy
(cherry picked from commit 269521ee08b962040afe63ea74130ba27f29e092)

11 years agoFix for bug #5551, smbd recursing back into winbindd from a winbindd call.
Jeremy Allison [Wed, 25 Jun 2008 01:04:37 +0000 (18:04 -0700)]
Fix for bug #5551, smbd recursing back into winbindd from a winbindd call.
Jeremy.
(cherry picked from commit 132a5f4a5740f8a4e3bd634af654c9761c11aa1a)

11 years agoFix bug #5555. Don't return NT_STATUS_PASSWORD_MUST_CHANGE error on machine account...
Jeremy Allison [Tue, 24 Jun 2008 23:42:30 +0000 (16:42 -0700)]
Fix bug #5555. Don't return NT_STATUS_PASSWORD_MUST_CHANGE error on machine account logon.
Jeremy.
(cherry picked from commit 2a3e2c9550acb1c55c0c55e4bfb0faaadad2f6fd)

11 years agoSorry volker, lost your original git-id due to proto.h conflicts.
Jeremy Allison [Mon, 23 Jun 2008 18:24:52 +0000 (11:24 -0700)]
Sorry volker, lost your original git-id due to proto.h conflicts.

Remove the "exists" parameter from create_msdfs_link

Jeremy, setting "exists" to True in _dfs_Add prevented the initial creation of
a new symlink for me, because the SMB_VFS_UNLINK failed. This also exists in
3.2. I only check it into 3.3 as I would like you to look at it first.

Thanks,

Volker
(cherry picked from commit 47e66814c176d597d9a3c165a7cfa6a5a2fd70be)

11 years agoCheck for sec_initial_uid() instead of uid==0 in dfs management
Volker Lendecke [Sun, 22 Jun 2008 18:27:20 +0000 (20:27 +0200)]
Check for sec_initial_uid() instead of uid==0 in dfs management
(cherry picked from commit 12d816dc997b1bfc048c5c042945a5e935abf4b4)

11 years agoReduce memory usage in form_junctions() a little bit
Volker Lendecke [Sun, 22 Jun 2008 09:28:57 +0000 (11:28 +0200)]
Reduce memory usage in form_junctions() a little bit
(cherry picked from commit 0dafec20396a0722d691ab3723eadc6124759e12)

11 years agoRemove prototype of unimplemented smbc_chown() function.
Derrell Lipman [Wed, 18 Jun 2008 15:00:46 +0000 (11:00 -0400)]
Remove prototype of unimplemented smbc_chown() function.
(cherry picked from commit 0e84e3bb800cec2b63df4692afbf9c40850b108f)

11 years agoAdd documentation for kerberos support in libsmbclient.
Andreas Schneider [Mon, 23 Jun 2008 14:29:40 +0000 (16:29 +0200)]
Add documentation for kerberos support in libsmbclient.

Signed-off-by: Andreas Schneider <anschneider@suse.de>
Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
(cherry picked from commit fa803ce183376c938f92b0f31a7d89d522fd309f)

11 years agoAdd krb5 support for the testbrowse example.
Andreas Schneider [Mon, 23 Jun 2008 09:00:20 +0000 (11:00 +0200)]
Add krb5 support for the testbrowse example.

Signed-off-by: Andreas Schneider <anschneider@suse.de>
Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
(cherry picked from commit 84b1ea39a4f27ebcf06a2bafed78396c7353df0e)

11 years agotestsuite: enable the testparm_s3 tests.
Michael Adam [Thu, 19 Jun 2008 15:19:21 +0000 (17:19 +0200)]
testsuite: enable the testparm_s3 tests.

Michael
(cherry picked from commit 0f5c13e5735990f4325f98156a7dc410276372fe)
(cherry picked from commit 784e9e6b9ce4cc043bdeba8ca396f59de51cd294)

11 years agotestsuite: add a testparm_s3 test script.
Michael Adam [Thu, 19 Jun 2008 15:14:39 +0000 (17:14 +0200)]
testsuite: add a testparm_s3 test script.

This is a first testparm/lp_load test that runs testparm on a couple
of configuration files. The main purpose for now is to test the options
that have special handlers (to check whether the handlers succeed).
In particular, all the Macro expansions that are available via
alloc_sub_basic() are tested with the include handler. This is to
catch such crashbugs as #5548 where %m expansion led to a segfault.

The tests now are very simple. Just check if testparm completes
successfully on the given config files. This can (and should) be
elaborated in the future.

Michael
(cherry picked from commit eb28146d40b8a8bc2c20b8d222abf191ea178d5a)
(cherry picked from commit eff6a48cee0fa6a320728f3bb44c3894dd3f6044)

11 years agotestsuite: update introductory comment to test_net_regsistry.sh
Michael Adam [Thu, 19 Jun 2008 11:52:49 +0000 (13:52 +0200)]
testsuite: update introductory comment to test_net_regsistry.sh

This is now used to test rpc and local access depending on
command line parameters.

Michael
(cherry picked from commit 73c17b630317b5019e5d5f2b989b8de081a73e07)
(cherry picked from commit febf046fc47dd3de3bbb6c0da5b218d73ef0487c)

11 years agoFix typo
Volker Lendecke [Thu, 19 Jun 2008 09:59:55 +0000 (11:59 +0200)]
Fix typo
(cherry picked from commit 2eef2c682c18ad37b78214c755b9dd7c8b607cb8)
(cherry picked from commit b517b0c0f20127876c63cc726afe7f902421af15)

11 years agotestsuite: give admin rights to testuser only for the "net rpc registry" test.
Michael Adam [Tue, 17 Jun 2008 21:54:15 +0000 (23:54 +0200)]
testsuite: give admin rights to testuser only for the "net rpc registry" test.

Remove the user from BUILTIN\Administrators at the end of the tests.
Note: BUILTIN\Administrators is not deletet at the end because that
functionality is not implemented.

Michael
(cherry picked from commit 1734f9305a38eff05f0147d9c7391ef34085e7b2)
(cherry picked from commit 1df339954b1dcc120195b26a6b3a08268dd0041c)

11 years agotestsuite: don't give the testuser administrative rights globally.
Michael Adam [Tue, 17 Jun 2008 21:51:23 +0000 (23:51 +0200)]
testsuite: don't give the testuser administrative rights globally.

It breaks RPC-SAMBA3-GETUSERNAME for reasons I have not quite
understood yet. Somhow loosing rights fails when the user
belogns to BUILTIN\Administrators at some point.

Michael
(cherry picked from commit 9fe99c69f35b005b66c1eacb5d999cc73f1bb521)
(cherry picked from commit cebe6225d5bc584b24c2bebf30db353653df34b0)

11 years agotests_all.sh: Do not execute $SMB4TORTURE --version if it is not available.
Karolin Seeger [Tue, 13 May 2008 12:01:52 +0000 (14:01 +0200)]
tests_all.sh: Do not execute $SMB4TORTURE --version if it is not available.

Improve error message if no SMB4TORTURE is available.

Karolin
(cherry picked from commit 443691eb2614919043406f94e9c71b49230612d5)
(cherry picked from commit 4de981e5174dffd9a21431017cfa75fc73910b48)

11 years agotestsuite: allow selection of posix_s3 subtests by env var POSIX_SUBTESTS.
Michael Adam [Tue, 6 May 2008 21:43:37 +0000 (23:43 +0200)]
testsuite: allow selection of posix_s3 subtests by env var POSIX_SUBTESTS.

This allows for calling e.g.

TESTS=posix_s3 POSIX_SUBTESTS="RPC-SAMBA3-GETUSERNAME" make test

Michael
(cherry picked from commit 7418d89b2941fff307e0980d1f71f106aed8cbce)
(cherry picked from commit 3fdce53f72242381eeda15ad6c3817a4cc88b323)

11 years agotestsuite: make structuring output of net_s3 tests stand out more.
Michael Adam [Tue, 6 May 2008 10:09:59 +0000 (12:09 +0200)]
testsuite: make structuring output of net_s3 tests stand out more.

say "RUNNING SUBTESTS ..." instead of "Running ... tests"

Michael
(cherry picked from commit 0b879817ba20861c7d0b239d7f7199b0a5ed2ca1)
(cherry picked from commit 370295aef1f8ee7cf8b5126de4629b69d1559578)

11 years agotestsuite: make diagnostic output more appropriate in tests_all.sh
Michael Adam [Tue, 6 May 2008 10:08:27 +0000 (12:08 +0200)]
testsuite: make diagnostic output more appropriate in tests_all.sh

Say "RUNNING TESTS ..." instead of "RUNNING SUBTESTS ..."

Michael
(cherry picked from commit b73821c392a23c213e4b1ad25a8a2d0c845cee3a)
(cherry picked from commit c9f82b175c2f38eeec77cab2906ef480ae558861)

11 years agotestsuite: give the testuser administrative rights in selftest.sh
Michael Adam [Fri, 4 Apr 2008 16:29:44 +0000 (18:29 +0200)]
testsuite: give the testuser administrative rights in selftest.sh

(by adding him to builtin\administrators)

Michael
(cherry picked from commit baea0615003cc2db8b27872e87064364f2deb079)
(cherry picked from commit 5d564b25e946e3a57fa251271711937e938cd22d)

11 years agotestsuite: run the net rpc registry tests from the net_s3 tests.
Michael Adam [Tue, 6 May 2008 10:01:49 +0000 (12:01 +0200)]
testsuite: run the net rpc registry tests from the net_s3 tests.

Michael
(cherry picked from commit dcf39078cf0524a7450db3f67c8e004eb42690c2)
(cherry picked from commit 3b09034bd9ad7a95d0d74302c953a5983ff4a417)

11 years agotestsuite: add the ability to test "net rpc registry" with the net_registry tests
Michael Adam [Fri, 4 Apr 2008 16:26:34 +0000 (18:26 +0200)]
testsuite: add the ability to test "net rpc registry" with the net_registry tests

by specifying a parameter "rpc" on the commandline.

Michael
(cherry picked from commit 110c26374ef3e0bdefe2e54db2b8ffd4544780ef)
(cherry picked from commit 6cdeb832bd11c0a12ce577ce10e30cc098bca729)

11 years agotestsuite: adapt informative message to say "Running _local_ registry tests".
Michael Adam [Tue, 6 May 2008 09:43:27 +0000 (11:43 +0200)]
testsuite: adapt informative message to say "Running _local_ registry tests".

The plan is to also test remote registry  with "net rpc registry".

Michael
(cherry picked from commit b5507f8a95399193099a0474fb8b8bc95ba04a48)
(cherry picked from commit 1580941cb7718eec3931893ec8ac7a2c0c62c363)

11 years agotestsuite: use domain==workgroup in wbinfo tests now that we are PDC.
Michael Adam [Tue, 6 May 2008 09:40:05 +0000 (11:40 +0200)]
testsuite: use domain==workgroup in wbinfo tests now that we are PDC.

Previously domain==netbios name was the right thing to use.

Michael
(cherry picked from commit a5fc47c2457ce370a4f6150b9f2a417dac7589bf)
(cherry picked from commit b211b576cc1287aeb2b541ae6575a3230350d044)

11 years agotests: Add a net_misc test.
Kai Blin [Fri, 2 May 2008 23:50:20 +0000 (01:50 +0200)]
tests: Add a net_misc test.
(cherry picked from commit 026d701aff2c035359894786ec22b4ed829cfb31)
(cherry picked from commit 09fe8019a7b688312892be96eacec55fd1f059e7)

11 years agoselftest: Advertise as PDC and time server during make test
Kai Blin [Mon, 5 May 2008 13:26:11 +0000 (15:26 +0200)]
selftest: Advertise as PDC and time server during make test
(cherry picked from commit 65c619b36d08ac2f24b622c71b7e05d50bdeea50)
(cherry picked from commit 1b24a06502a910909cf889916423c94aca92b1cf)

11 years agoselftest: Use TESTS env var to specify tests to run like Samba4 does.
Kai Blin [Fri, 2 May 2008 23:45:33 +0000 (01:45 +0200)]
selftest: Use TESTS env var to specify tests to run like Samba4 does.
(cherry picked from commit 6fb1fe803ccbd3af2946fcbe4586c11d394d5dc2)
(cherry picked from commit 11252c8faff0373bf16b7bc42d65dbc5cf5ec57d)

11 years agoWHATSNEW: Fix typo.
Karolin Seeger [Mon, 23 Jun 2008 11:11:11 +0000 (13:11 +0200)]
WHATSNEW: Fix typo.

Karolin
(cherry picked from commit c434b3e2131b0d5e68d00f887412372e9192a39f)

11 years agoWHATSNEW: Update changes since 3.2.0rc2.
Karolin Seeger [Mon, 23 Jun 2008 10:10:18 +0000 (12:10 +0200)]
WHATSNEW: Update changes since 3.2.0rc2.

Karolin
(cherry picked from commit 769d9434349d4c683e92cea34cb5bd177273fe40)

11 years agoSamba3 HOWTO: Remove trailing whitespaces.
Karolin Seeger [Mon, 23 Jun 2008 08:15:53 +0000 (10:15 +0200)]
Samba3 HOWTO: Remove trailing whitespaces.

Karolin
(cherry picked from commit c7a9c903acbba9c70211e6f3c25964533bbc1622)

11 years agoman pages: Correct version in man winbindd again.
Karolin Seeger [Mon, 23 Jun 2008 08:28:09 +0000 (10:28 +0200)]
man pages: Correct version in man winbindd again.

Karolin
(cherry picked from commit ef44968276bfde2fdd3370e2558fb469357414be)

11 years agoFixed publishing date info.
John H Terpstra [Wed, 28 May 2008 16:02:26 +0000 (11:02 -0500)]
Fixed publishing date info.
(cherry picked from commit b96c9d54cfd29ec87d59655839a4136977a98032)

11 years agoAdded TDB File documentation requested by some users.
John H Terpstra [Wed, 28 May 2008 16:00:49 +0000 (11:00 -0500)]
Added TDB File documentation requested by some users.
(cherry picked from commit 5035311af639336fdc51fa9829e984ff281216f9)

11 years agoClarification that hosts resolution is done by winbind only on IRIX, all other system...
John H Terpstra [Mon, 19 May 2008 18:02:08 +0000 (13:02 -0500)]
Clarification that hosts resolution is done by winbind only on IRIX, all other systems use libnss_wins.so.
(cherry picked from commit 3a8ea6be389bedbcdb5668664d862768c026f669)

11 years agoClarification that hosts resolution is done by winbind only on IRIX, all other system...
John H Terpstra [Mon, 19 May 2008 18:00:01 +0000 (13:00 -0500)]
Clarification that hosts resolution is done by winbind only on IRIX, all other systems use libnss_wins.so.
(cherry picked from commit 2a953d6ba252e5ba4e28b7fae5979e7c47fe9bd0)

11 years agoinit_shared_module -> init_samba_module
Volker Lendecke [Mon, 23 Jun 2008 05:14:46 +0000 (07:14 +0200)]
init_shared_module -> init_samba_module
(cherry picked from commit 1b12e5f9ed28ac57c06d9597a8f3c57cde01beef)

11 years agoFix a crash in _dfs_Enum
Volker Lendecke [Sun, 22 Jun 2008 11:06:35 +0000 (13:06 +0200)]
Fix a crash in _dfs_Enum
(cherry picked from commit 4a996476297963d4cb300b4d45c23e83a493c339)

11 years agoFix an uninitialized variable access in callers of parse_msdfs_symlink
Volker Lendecke [Sun, 22 Jun 2008 10:50:30 +0000 (12:50 +0200)]
Fix an uninitialized variable access in callers of parse_msdfs_symlink

At least form_junctions() does not initialize refcount, and I don't see it in
get_referred_path(). For the latters, the callers might initialize it. But even
if they did, I think parse_msdfs_symlink() should unconditionally return the
number of referrals it found. I don't think it makes sense to count them up
from somewhere else.
(cherry picked from commit d75905ad66e96d4967eb8780d3a980eccb796898)

11 years agoFix a double-closedir() in form_junctions()
Volker Lendecke [Sat, 21 Jun 2008 14:48:07 +0000 (16:48 +0200)]
Fix a double-closedir() in form_junctions()
(cherry picked from commit 394f4509bc5dd31801ef83ee9cc29c1e3a9f1078)

11 years agoAttempt to fix the darwin build
Volker Lendecke [Sat, 21 Jun 2008 14:15:02 +0000 (16:15 +0200)]
Attempt to fix the darwin build
(cherry picked from commit 9a4b5591a40e9150fdd3fc706ebb520d65eb1989)

11 years agoUse "init_shared_module" instead of "init_module" for initializing .so's
Volker Lendecke [Fri, 20 Jun 2008 12:30:02 +0000 (14:30 +0200)]
Use "init_shared_module" instead of "init_module" for initializing .so's
(cherry picked from commit eabea09243d164c03b9fdfc0d569054c03e67edf)

11 years agoFix the build on FreeBSD 4.6.2
Volker Lendecke [Thu, 19 Jun 2008 07:50:34 +0000 (09:50 +0200)]
Fix the build on FreeBSD 4.6.2
(cherry picked from commit a475dee8036156d4c8330bae97208ec546342f42)

11 years agoFix bug #5531 - fix conversion of ns units when converting from nttime to timespec.
Jeremy Allison [Fri, 20 Jun 2008 20:23:31 +0000 (13:23 -0700)]
Fix bug #5531 - fix conversion of ns units when converting from nttime to timespec.
Fix from hkurma@datadomain.com.
Jeremy.
(cherry picked from commit c8471dd5793924d482af662706deb92f3fad0bdf)

11 years agoFix bug #5533. Winbindd fails to cope correctly with a workgroup name containing...
Jeremy Allison [Fri, 20 Jun 2008 19:49:14 +0000 (12:49 -0700)]
Fix bug #5533. Winbindd fails to cope correctly with a workgroup name containing a '.'.
Jeremy.
(cherry picked from commit fae027e937c2f0078193b8cc27af6db2d7c233f5)

11 years agoFixing net help info.
John H Terpstra [Thu, 19 Jun 2008 21:11:31 +0000 (16:11 -0500)]
Fixing net help info.
(cherry picked from commit f62909d2b457f3494c9536c994a9209f8cc0c331)

11 years agoRevert "Fix a memleak in svcctl_init_keys()"
Volker Lendecke [Wed, 18 Jun 2008 14:30:37 +0000 (16:30 +0200)]
Revert "Fix a memleak in svcctl_init_keys()"

This reverts commit b1afb31f3cadd4749bf6e3eb5d8935588bf8ebfc.

This one is very strange: I need to investigate why valgrind showed it as
leaking, and why in my initial tests this did not fail.
(cherry picked from commit 24730f5981efb920811e7929a9483bd72bb0984c)

11 years agoFix Bug #5548 (segfauls in handle_include with %m macro expansion).
Michael Adam [Wed, 18 Jun 2008 12:50:53 +0000 (14:50 +0200)]
Fix Bug #5548 (segfauls in handle_include with %m macro expansion).

In alloc_sub_basic, when expanding '%m', substitute "" instead of
NULL for remote_machine when this is NULL. Else a NULL string
is returned.

Michael
(cherry picked from commit c65b456c6a145d15b7fd27a2a3440a0709fc3277)
(cherry picked from commit ffaed197d8cb261e2765b2de6cad17cac7d49672)

11 years agoFix a brown paper bag segfault in clitar
Volker Lendecke [Tue, 17 Jun 2008 19:08:56 +0000 (21:08 +0200)]
Fix a brown paper bag segfault in clitar

Thanks to "No Body is Perfect" from gmail, whoever that is :-)

Volker
(cherry picked from commit 679d8dfa390601f777bfb43c02cd921eae5edcf4)

11 years agoFix a memleak in svcctl_init_keys()
Volker Lendecke [Tue, 17 Jun 2008 14:06:42 +0000 (16:06 +0200)]
Fix a memleak in svcctl_init_keys()
(cherry picked from commit 675bb53398ba29c53d2dcf3c7122cf4770c2f938)

11 years agoFix a segfault in wbcLookupSid
Volker Lendecke [Tue, 17 Jun 2008 12:53:07 +0000 (14:53 +0200)]
Fix a segfault in wbcLookupSid

If the BAIL_ON_WBC_ERROR directly after wbcRequestResponse kicks in, *domain
and *name have not been initialized yet. So the cleanup routine in the done:
part of the routine (which did not check for domain!=NULL etc) would access
uninitialized memory.

Jerry, please check!

Thanks,

Volker
(cherry picked from commit 3d7e0cc40b1992f4555807acec4f00450e30e2de)

11 years agoFix a segfault in wbcLookupRids
Volker Lendecke [Tue, 17 Jun 2008 13:17:22 +0000 (15:17 +0200)]
Fix a segfault in wbcLookupRids

The done: part could access uninitialized memory if intermediate
BAIL_ON_WBC_ERROR fire.

Jerry, please check!

Thanks,

Volker
(cherry picked from commit 31f4c33dcc744e81be54389756378e25aa2bb75e)

11 years agoReplace a very unusual variable declaration by a more conventional one
Volker Lendecke [Tue, 17 Jun 2008 12:31:07 +0000 (14:31 +0200)]
Replace a very unusual variable declaration by a more conventional one
(cherry picked from commit b37030644e32249706d431ad93881d540f351c50)

11 years agoman pages: Move 'smbsh' man page to the examples directory.
Karolin Seeger [Tue, 17 Jun 2008 11:18:17 +0000 (13:18 +0200)]
man pages: Move 'smbsh' man page to the examples directory.

smbsh.c is located in the examples directory. It does not make sense
to install a man page without installing the tool itself.

This fixes bug #4724.

Karolin
(cherry picked from commit 797ed744b15c94fa4831d9796b40bb0ab5df55b7)
(cherry picked from commit 23981be7a009dc9e056ba2e12c5df6e3a13ab193)

11 years agoFix a memleak in wbcAuthenticateUserEx()
Volker Lendecke [Tue, 17 Jun 2008 11:00:13 +0000 (13:00 +0200)]
Fix a memleak in wbcAuthenticateUserEx()
(cherry picked from commit 72b381689af9cae83ab08532cffd0188f2da4807)

11 years agoRevert "Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails"
Volker Lendecke [Tue, 17 Jun 2008 10:14:49 +0000 (12:14 +0200)]
Revert "Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails"

This reverts commit 6bcfa82ff15531c64e0db27dcc58e5847c513aa6.
(cherry picked from commit 6f3183d0c4880dcf243239cd1ed018b9d10a4249)

11 years agoRevert "Fix a memleak caused by a crappy get_sorted_dc_list() API"
Volker Lendecke [Tue, 17 Jun 2008 10:15:05 +0000 (12:15 +0200)]
Revert "Fix a memleak caused by a crappy get_sorted_dc_list() API"

This reverts commit ba10b9c077272c521504b3a638bba73446efc61c.
(cherry picked from commit 4b3690a730895f6a19b14ee09ca0a2a131c3ba21)

11 years agoMore correct fix (hopefully :-) for any memory leaks.
Jeremy Allison [Thu, 5 Jun 2008 21:28:28 +0000 (14:28 -0700)]
More correct fix (hopefully :-) for any memory leaks.
Jerry promised to check :-). Vl also please review.
Jeremy.

Okay -- I have to admit that this is the better fix. With my fixes I got a
double-free when using security=domain. Sorry...

Volker
(cherry picked from commit 3b0d688b1b16c9054340d08986d0fa91f7fff9ad)

11 years agonet_vampire: fix samsync_process_database(). Final fix for Bug #5542.
Günther Deschner [Tue, 17 Jun 2008 09:10:37 +0000 (11:10 +0200)]
net_vampire: fix samsync_process_database(). Final fix for Bug #5542.

Turns out the password hashes are not rid encrypted in the samsync reply.

Guenther
(cherry picked from commit 55259f408b7bc356367d872a38a54174d364fd2b)

11 years agonet_vampire: fix build warning.
Günther Deschner [Tue, 17 Jun 2008 08:36:53 +0000 (10:36 +0200)]
net_vampire: fix build warning.

Guenther
(cherry picked from commit eb4232fec05cd87ea85a781b84a3fbe85f469703)
(cherry picked from commit 28b85a92160c7880253725cd247e064020f8be41)

11 years agonetapi: Fix Bug #5545 (libnetapi_init without $USER)
Günther Deschner [Tue, 17 Jun 2008 08:31:44 +0000 (10:31 +0200)]
netapi: Fix Bug #5545 (libnetapi_init without $USER)

Based on patch from Erik van Pienbroek.

Guenther
(cherry picked from commit 71f4cf773022525ba617f09c495dbff97f8eb2d5)
(cherry picked from commit 7602a4dbfb1b2ae9963f017be62c999af0c2e043)

11 years agoWHATSNEW: Updates changes since 3.2.0rc2.
Karolin Seeger [Mon, 16 Jun 2008 13:58:51 +0000 (15:58 +0200)]
WHATSNEW: Updates changes since 3.2.0rc2.

Karolin
(cherry picked from commit 83dfdfccfa9a07075912caeafde7355f4e7ce1ec)

11 years agonet: Fix several typos in comments.
Karolin Seeger [Fri, 13 Jun 2008 19:31:34 +0000 (21:31 +0200)]
net: Fix several typos in comments.

-argc -> argv (where argv is meant)
-destoyed -> destroyed
-compleation -> completion
-aquired -> acquired
-Unify spelling of some words like rpc-server -> RPC server.
-Add missing punctuation marks.

Karolin
(cherry picked from commit 7c22fc6ebaa1a83213cbb7c08bea108264f89486)

11 years agoFix a handle leak for error returns in ldb_try_load_dso
Volker Lendecke [Fri, 13 Jun 2008 14:05:31 +0000 (16:05 +0200)]
Fix a handle leak for error returns in ldb_try_load_dso

Coverity ID 464
(cherry picked from commit 496d44d2f21661c85bf07e8eb7cae6298fefd900)

11 years agoFix group parsing in libwbclient's copy_group_entry()
Volker Lendecke [Sat, 14 Jun 2008 22:14:27 +0000 (00:14 +0200)]
Fix group parsing in libwbclient's copy_group_entry()

This (also) fixes a flaw pointed out by the IBM checker. When verifying that I
found out that the parsing was not working as I would have expected it to.

Jerry, please check!
(cherry picked from commit c2c7790155ab02e1e351caf2bed192ce72913663)

11 years agoFix an uninitialized variable found by the IBM checker
Volker Lendecke [Sat, 14 Jun 2008 22:22:47 +0000 (00:22 +0200)]
Fix an uninitialized variable found by the IBM checker

BAIL_ON_PTR_ERROR jumps to done: which will access extra_data before it's
initialized.

Stefan, please check!

Volker
(cherry picked from commit b59636f78d351ed6d52c4a9fdccdb7850388526c)

11 years agoFix bug 5500 -- thanks to mathion at thorrovydeti.com for reporting
Volker Lendecke [Mon, 16 Jun 2008 11:27:16 +0000 (13:27 +0200)]
Fix bug 5500 -- thanks to mathion at thorrovydeti.com for reporting
(cherry picked from commit 996c3ce6f0dbe79b0679ae30afd873c24fe5b1eb)

11 years agoFix a crash in _winreg_QueryValue
Volker Lendecke [Fri, 13 Jun 2008 13:30:08 +0000 (15:30 +0200)]
Fix a crash in _winreg_QueryValue

Coverity ID 474, value_length and type are both unique, not ref pointers and
can thus be NULL.

Karolin, please merge this to -stable.

Thanks,

Volker
(cherry picked from commit 999533c0ccced59141d8baff5bc248d63e2a966f)

11 years agonet: Fix bug #5542 (samsync contains empty passwords).
Günther Deschner [Fri, 13 Jun 2008 10:20:01 +0000 (12:20 +0200)]
net: Fix bug #5542 (samsync contains empty passwords).

Guenther
(cherry picked from commit 1a22e975dd1255f3557c1cd873d877aa35822afc)

11 years agosamsync: add samsync_fix_delta_array()
Günther Deschner [Fri, 13 Jun 2008 09:57:09 +0000 (11:57 +0200)]
samsync: add samsync_fix_delta_array()

This code is vastly based on samba4 code.

Guenther
(cherry picked from commit 5b68be96996a710988b1fd1c176cd5dff0f2c6af)

11 years agoman pages: Fix indentation in smb.conf section about 'map readonly'.
Karolin Seeger [Thu, 12 Jun 2008 07:34:15 +0000 (09:34 +0200)]
man pages: Fix indentation in smb.conf section about 'map readonly'.
(cherry picked from commit 0f0d81a89ae2ebae7d031a3a8633c3a924ebcbae)

11 years agoman pages: Added improvements.
Christoph Zauner [Wed, 11 Jun 2008 13:15:22 +0000 (15:15 +0200)]
man pages: Added improvements.
(cherry picked from commit 7fecd548af0a21b9644bd70e22a38aaa28777aa0)

11 years agoman pages: Fix typo in smb.conf section about the 'deleteprinter command'.
Karolin Seeger [Thu, 12 Jun 2008 07:26:32 +0000 (09:26 +0200)]
man pages: Fix typo in smb.conf section about the 'deleteprinter command'.

Karolin
(cherry picked from commit 5fa77c216bc43c3558aff3373f74554efdb9210d)

11 years agoman pages: Fix typos.
Christoph Zauner [Wed, 11 Jun 2008 13:17:21 +0000 (15:17 +0200)]
man pages: Fix typos.
(cherry picked from commit 881eaa26e071a7fde9c6fc5eb42ae122d0ddd490)

11 years agoSamba3-HOWTO: Fix typos.
Christoph Zauner [Wed, 11 Jun 2008 12:49:30 +0000 (14:49 +0200)]
Samba3-HOWTO: Fix typos.
(cherry picked from commit 2391d999eb733bd8d12631478f4318608225cbb6)

11 years agoFix typos.
Christoph Zauner [Wed, 11 Jun 2008 12:05:47 +0000 (14:05 +0200)]
Fix typos.
(cherry picked from commit b2390aa738f6384016600dffb8065bd0bcda6ef1)

11 years agoAdd -brtl to the AIX linker flags
Volker Lendecke [Thu, 12 Jun 2008 10:35:28 +0000 (12:35 +0200)]
Add -brtl to the AIX linker flags

Thanks to William Jojo
(cherry picked from commit 74b195b54416d9e3eb46079a71eed31a15c7293a)

11 years agoAIX build fixes from William Jojo -- thanks
Volker Lendecke [Thu, 12 Jun 2008 10:36:15 +0000 (12:36 +0200)]
AIX build fixes from William Jojo -- thanks
(cherry picked from commit cb91a47576e820390bc62195702aaae93a2feba6)

11 years agoFix max_fd calculation in event_loop_once
Volker Lendecke [Wed, 11 Jun 2008 16:56:20 +0000 (18:56 +0200)]
Fix max_fd calculation in event_loop_once

For some bugs I really wonder how they can go undetected for so long.

Fix a bug reported by Mathias Dietz. No samba bugzilla entry, but still 100%
needed for 3-2-stable.

Volker
(cherry picked from commit 82c994dabc47bb4755c883a1f3651bb5d65cf2c5)

11 years agopam_winbind: Update cached creds during password change.
Günther Deschner [Wed, 11 Jun 2008 07:52:56 +0000 (09:52 +0200)]
pam_winbind: Update cached creds during password change.

Fix is from Bo Yang @ Novell.

Thanks!
(cherry picked from commit e4eb9d347d14de8c9ba73b07f26fe8fd4f17eab5)
(cherry picked from commit 49178f979f14ced834dda3104044bb8a84d4ebdb)

11 years agoCorrectly find a [u]int32_t replacement
Volker Lendecke [Tue, 10 Jun 2008 14:14:30 +0000 (16:14 +0200)]
Correctly find a [u]int32_t replacement
(cherry picked from commit 346375cda557a675f8f882ca2ae8edffec725a72)

11 years agoFix some scary FC9 warnings
Volker Lendecke [Tue, 10 Jun 2008 12:15:01 +0000 (14:15 +0200)]
Fix some scary FC9 warnings
(cherry picked from commit 6b0fed09ea34409d1c61bae9121bdb38d4c68d62)

11 years agoman pages: Don't refer to numbered chapter of the HOWTO collection.
Karolin Seeger [Tue, 10 Jun 2008 13:30:19 +0000 (15:30 +0200)]
man pages: Don't refer to numbered chapter of the HOWTO collection.

This fixes bug #5527.
Thanks to the Debian package maintainers for reporting!

Karolin
(cherry picked from commit b6696f4fbfc6aaffceef71c6099b8eaea58c1172)

11 years agoman pages: Fix broken smb.conf section about the 'get quota command'. release-3-2-0rc2
Karolin Seeger [Tue, 10 Jun 2008 08:54:21 +0000 (10:54 +0200)]
man pages: Fix broken smb.conf section about the 'get quota command'.

This fixes bug #5422.
Thanks to the Debian package maintainers for reporting!

Karolin
(cherry picked from commit 04e2470e2eeef34362f2893ec062ae16f74c28ed)

11 years agoWHATSNEW: Update changes since 3.2.0rc1.
Karolin Seeger [Tue, 10 Jun 2008 08:17:14 +0000 (10:17 +0200)]
WHATSNEW: Update changes since 3.2.0rc1.

Karolin
(cherry picked from commit eb99ac3618269103b434afaca13295ab5c2cc478)

11 years agoDon't reset password last set time just because the expired flag
Jim McDonough [Mon, 9 Jun 2008 15:45:39 +0000 (11:45 -0400)]
Don't reset password last set time just because the expired flag
is set to 0.  If the account wasn't expired but autolocked,
using "net user /dom <username> /active:y" would clear this,
incorrectly setting the current time as the new "password last set"
time.
(cherry picked from commit 2089c692cfe5a4f9bbed1e658c6f73c310dbff57)

11 years agoWHATSNEW: Update changes since 3.2.0rc1.
Karolin Seeger [Mon, 9 Jun 2008 14:53:45 +0000 (16:53 +0200)]
WHATSNEW: Update changes since 3.2.0rc1.

Karolin
(cherry picked from commit 1b9894622fccd044647abfe2c13c3018f72a6949)

11 years agoshrink ldbtools
Volker Lendecke [Mon, 9 Jun 2008 14:07:57 +0000 (16:07 +0200)]
shrink ldbtools

Thanks to Björn Jacke for noticing :-)
(cherry picked from commit 8faee1cee829d749835a66d219170ccfd85151d0)

11 years agoman pages: Fix synonyms.
Karolin Seeger [Mon, 9 Jun 2008 13:05:26 +0000 (15:05 +0200)]
man pages: Fix synonyms.

Karolin
(cherry picked from commit d1ae27ddbe9c30996d2c593a37e65581c3ff482c)

11 years agoman pages: Remove wrong synonym.
Karolin Seeger [Mon, 9 Jun 2008 13:03:12 +0000 (15:03 +0200)]
man pages: Remove wrong synonym.

Karolin
(cherry picked from commit 4951bc8ff1da9bfc79b9b403b420f07299266df6)

11 years agoWHATSNEW: Update changes since 3.2.0rc1.
Karolin Seeger [Mon, 9 Jun 2008 11:42:15 +0000 (13:42 +0200)]
WHATSNEW: Update changes since 3.2.0rc1.

Karolin
(cherry picked from commit ead68586fc1d3d8ac83d069a1355573026397ac6)

11 years agoFix the compile on NetBSD -- missing prototypes
Volker Lendecke [Mon, 9 Jun 2008 13:34:51 +0000 (15:34 +0200)]
Fix the compile on NetBSD -- missing prototypes
(cherry picked from commit 11236d266e3703eb3aca4b96e2ed9da76614ec12)

11 years agoFix the compile on NetBSD -- readlink and read are macros there
Volker Lendecke [Mon, 9 Jun 2008 13:33:28 +0000 (15:33 +0200)]
Fix the compile on NetBSD -- readlink and read are macros there
(cherry picked from commit 435b80a9a2e9324cc20594d922b3d8d6418c27af)

11 years agoWHATSNEW: Update changes since 3.2.0rc2.
Karolin Seeger [Mon, 9 Jun 2008 10:22:27 +0000 (12:22 +0200)]
WHATSNEW: Update changes since 3.2.0rc2.

Karolin
(cherry picked from commit 7b2150da84e51426b07e259e51dd4cbc3171ba83)

11 years agolibreplace: only include AC_USE_SYSTEM_EXTENSIONS fallback if required
Stefan Metzmacher [Mon, 9 Jun 2008 08:39:48 +0000 (10:39 +0200)]
libreplace: only include AC_USE_SYSTEM_EXTENSIONS fallback if required

This fixes ./autogen.sh with autoconf-2.62

metze
(cherry picked from commit 72bb01dda4d425528e28cd96e249595dc6c1952f)
(cherry picked from commit 85111dc2b60ca38027adf129a074641c752cb104)
(cherry picked from commit 24f0c35571b26187c13af933604fe40afed1da34)

11 years agolibreplace: fix warnings with autoconf-2.62 rename ac_ => libreplace_cv_
Stefan Metzmacher [Mon, 9 Jun 2008 08:38:09 +0000 (10:38 +0200)]
libreplace: fix warnings with autoconf-2.62 rename ac_ => libreplace_cv_

AC_CACHE_VAL() variables must contain _cv_ to be cached.

metze
(cherry picked from commit 67e43860b4973a458676b36785570bb4a66e046a)
(cherry picked from commit d786bfc48e20ed7e695a988da6ed56a573afdadc)
(cherry picked from commit c402acd63a31bace402b361760a7d73f95db3717)

11 years agoconfigure: we require autoconf 2.54
Stefan Metzmacher [Mon, 9 Jun 2008 08:43:48 +0000 (10:43 +0200)]
configure: we require autoconf 2.54

I've tested with autoconf from 2.53 to 2.62.

metze
(cherry picked from commit a268a6d251e58c27262e11fcd85b8281dfaddd8b)
(cherry picked from commit 21bbd421d4bd2c16f4d8ab94a6a9e3388be4fb82)

11 years agoconfigure: fix warnings with autoconf-2.62 rename SMB_BUILD_ => samba_cv_
Stefan Metzmacher [Mon, 9 Jun 2008 08:27:12 +0000 (10:27 +0200)]
configure: fix warnings with autoconf-2.62 rename SMB_BUILD_ => samba_cv_

AC_CACHE_VAL() variables must contain _cv_ to be cached.

metze
(cherry picked from commit 89663ab4d10586b96807c56de53fd60d2488093c)
(cherry picked from commit 74c644a2bed45d48215914da8002913254a7f54c)

11 years agoconfigure: fix warnings with autoconf-2.62 rename samba_stat_hires => samba_cv_stat_hires
Stefan Metzmacher [Mon, 9 Jun 2008 08:23:27 +0000 (10:23 +0200)]
configure: fix warnings with autoconf-2.62 rename samba_stat_hires => samba_cv_stat_hires

AC_CACHE_VAL() variables must contain _cv_ to be cached.

metze
(cherry picked from commit 426b1e36e262ae47ea62e36e1df8a76c930394bc)
(cherry picked from commit 84a8a7d9e028aa223617a8cb7aa31d5fabd7636e)