From: Tim Potter <tpot@samba.org> 
Date: Tue, 4 Nov 2003 05:49:23 +0000 (+0000)
Subject: Use a static string instead of malloced one in winbind_{off,on}() utility
X-Git-Tag: initial-v3-0-unstable~6987
X-Git-Url: http://git.samba.org/samba.git/?p=tprouty%2Fsamba.git;a=commitdiff_plain;h=7710232ba21305a1e3c9523ace82a5a419526b50

Use a static string instead of malloced one in winbind_{off,on}() utility
functions.
---

diff --git a/source/nsswitch/wb_common.c b/source/nsswitch/wb_common.c
index 793d4a30b8..40221b69fe 100644
--- a/source/nsswitch/wb_common.c
+++ b/source/nsswitch/wb_common.c
@@ -476,40 +476,19 @@ NSS_STATUS winbindd_request(int req_type,
  enable them
  ************************************************************************/
  
-/* Use putenv() instead of setenv() as not all environments have the
-   latter. */
-
-static int set_winbind_dont_env(char value)
-{
-	int len = strlen(WINBINDD_DONT_ENV) + 3; /* len("_NO_WINBINDD=1\0") */
-	char *s = malloc(len);
-	int result;
-
-	if (s == NULL)
-		return -1;
-
-	/* It's OK to use strcpy here as we have allocated the correct
-	   buffer size and no user or network data is used. */
-
-	strcpy(s, WINBINDD_DONT_ENV);
-
-	s[strlen(WINBINDD_DONT_ENV)]     = '=';
-	s[strlen(WINBINDD_DONT_ENV) + 1] = value;
-	s[strlen(WINBINDD_DONT_ENV) + 2] = '\0';
-
-	result = putenv(s);
-
-	free(s);
-	return result;
-}
+/* Use putenv() instead of setenv() in these functions as not all
+   environments have the latter. */
 
 BOOL winbind_off( void )
 {
-	return set_winbind_dont_env('1') != -1;
+	static char *s = WINBINDD_DONT_ENV "=1";
+
+	return putenv(s) != -1;
 }
 
 BOOL winbind_on( void )
 {
-	return set_winbind_dont_env('0') != -1;
-}
+	static char *s = WINBINDD_DONT_ENV "=0";
 
+	return putenv(s) != -1;
+}