- Fix a double-free (I can't say I understand the code, but it matches the other

cases and keeps valgrind quiet).

 - Add static

Andrew Bartlett

diff --git a/source/libads/krb5_setpw.c b/source/libads/krb5_setpw.c
index ac7377cd2f6f49c7158e7b34ce9db1031556c444..29bf1a427c2b89bad727e6bee5528eece87a704f 100644 (file)
--- a/source/libads/krb5_setpw.c
+++ b/source/libads/krb5_setpw.c
@@ -546,7 +546,6 @@ ADS_STATUS krb5_set_password(const char *kdc_host, const char *princ, const char
 
        krb5_free_creds(context, credsp);
        krb5_free_principal(context, creds.client);
-       krb5_free_principal(context, creds.server);
        krb5_free_principal(context, principal);
        krb5_free_context(context);
 
@@ -579,11 +578,11 @@ kerb_prompter(krb5_context ctx, void *data,
        return 0;
 }
 
-ADS_STATUS krb5_chg_password(const char *kdc_host,
-                               const char *principal,
-                               const char *oldpw, 
-                               const char *newpw, 
-                               int time_offset)
+static ADS_STATUS krb5_chg_password(const char *kdc_host,
+                                   const char *principal,
+                                   const char *oldpw, 
+                                   const char *newpw, 
+                                   int time_offset)
 {
     ADS_STATUS aret;
     krb5_error_code ret;