r14359: Try and fix Coverity #176 by making the pointer
authorJeremy Allison <jra@samba.org>
Mon, 13 Mar 2006 23:58:58 +0000 (23:58 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 16:15:26 +0000 (11:15 -0500)
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
(This used to be commit a3b8bee3ff8211d78f793877c877ccd2e15825dd)

source3/client/client.c

index 1d42fd2995a9f716a5052ef4a772bb53118f8058..886af863e470a66ff0da2870acd45ee25e9ea94a 100644 (file)
@@ -1336,15 +1336,15 @@ static struct file_list {
  Free a file_list structure.
 ****************************************************************************/
 
-static void free_file_list (struct file_list * list)
+static void free_file_list (struct file_list *list_head)
 {
-       struct file_list *tmp;
+       struct file_list *list, *next;
        
-       while (list) {
-               tmp = list;
-               DLIST_REMOVE(list, list);
-               SAFE_FREE(tmp->file_path);
-               SAFE_FREE(tmp);
+       for (list = list_head; list; list = next) {
+               next = list->next;
+               DLIST_REMOVE(list_head, list);
+               SAFE_FREE(list->file_path);
+               SAFE_FREE(list);
        }
 }