pidl/NDR::Parser: pass $ndr to ParseMemCtxPull*()
[tprouty/samba.git] / source4 / pidl / lib / Parse / Pidl / Samba4 / NDR / Parser.pm
index 8eb2f9ad1555686b0956973f1bae7a9542042f94..d6acf6bdcb2da0d085637fa52fcd9b39c237fb79 100644 (file)
@@ -9,14 +9,15 @@ package Parse::Pidl::Samba4::NDR::Parser;
 
 require Exporter;
 @ISA = qw(Exporter);
-@EXPORT_OK = qw(check_null_pointer GenerateFunctionInEnv GenerateFunctionOutEnv EnvSubstituteValue GenerateStructEnv NeededFunction NeededElement NeededType $res NeededInterface TypeFunctionName ParseElementPrint);
+@EXPORT_OK = qw(check_null_pointer NeededFunction NeededElement NeededType $res NeededInterface TypeFunctionName ParseElementPrint);
 
 use strict;
 use Parse::Pidl::Typelist qw(hasType getType mapTypeName typeHasBody);
 use Parse::Pidl::Util qw(has_property ParseExpr ParseExprExt print_uuid);
-use Parse::Pidl::CUtil qw(get_pointer_to get_value_of);
-use Parse::Pidl::NDR qw(GetPrevLevel GetNextLevel ContainsDeferred);
+use Parse::Pidl::CUtil qw(get_pointer_to get_value_of get_array_element);
+use Parse::Pidl::NDR qw(GetPrevLevel GetNextLevel ContainsDeferred is_charset_array);
 use Parse::Pidl::Samba4 qw(is_intree choose_header);
+use Parse::Pidl::Samba4::Header qw(GenerateFunctionInEnv GenerateFunctionOutEnv EnvSubstituteValue GenerateStructEnv);
 use Parse::Pidl qw(warning);
 
 use vars qw($VERSION);
@@ -41,19 +42,21 @@ sub append_prefix($$)
 {
        my ($e, $var_name) = @_;
        my $pointers = 0;
+       my $arrays = 0;
 
        foreach my $l (@{$e->{LEVELS}}) {
                if ($l->{TYPE} eq "POINTER") {
                        $pointers++;
                } elsif ($l->{TYPE} eq "ARRAY") {
+                       $arrays++;
                        if (($pointers == 0) and 
                            (not $l->{IS_FIXED}) and
                            (not $l->{IS_INLINE})) {
-                               return get_value_of($var_name); 
+                               return get_value_of($var_name);
                        }
                } elsif ($l->{TYPE} eq "DATA") {
                        if (Parse::Pidl::Typelist::scalar_is_reference($l->{DATA_TYPE})) {
-                               return get_value_of($var_name) unless ($pointers);
+                               return get_value_of($var_name) unless ($pointers or $arrays);
                        }
                }
        }
@@ -77,19 +80,6 @@ sub has_fast_array($$)
        return ($t->{NAME} eq "uint8") or ($t->{NAME} eq "string");
 }
 
-sub is_charset_array($$)
-{
-       my ($e,$l) = @_;
-
-       return 0 if ($l->{TYPE} ne "ARRAY");
-
-       my $nl = GetNextLevel($e,$l);
-
-       return 0 unless ($nl->{TYPE} eq "DATA");
-
-       return has_property($e, "charset");
-}
-
 
 ####################################
 # pidl() is our basic output routine
@@ -193,68 +183,6 @@ sub end_flags($$)
        }
 }
 
-sub GenerateStructEnv($$)
-{
-       my ($x, $v) = @_;
-       my %env;
-
-       foreach my $e (@{$x->{ELEMENTS}}) {
-               $env{$e->{NAME}} = "$v->$e->{NAME}";
-       }
-
-       $env{"this"} = $v;
-
-       return \%env;
-}
-
-sub EnvSubstituteValue($$)
-{
-       my ($env,$s) = @_;
-
-       # Substitute the value() values in the env
-       foreach my $e (@{$s->{ELEMENTS}}) {
-               next unless (defined(my $v = has_property($e, "value")));
-               
-               $env->{$e->{NAME}} = ParseExpr($v, $env, $e);
-       }
-
-       return $env;
-}
-
-sub GenerateFunctionInEnv($;$)
-{
-       my ($fn, $base) = @_;
-       my %env;
-
-       $base = "r->" unless defined($base);
-
-       foreach my $e (@{$fn->{ELEMENTS}}) {
-               if (grep (/in/, @{$e->{DIRECTION}})) {
-                       $env{$e->{NAME}} = $base."in.$e->{NAME}";
-               }
-       }
-
-       return \%env;
-}
-
-sub GenerateFunctionOutEnv($;$)
-{
-       my ($fn, $base) = @_;
-       my %env;
-
-       $base = "r->" unless defined($base);
-
-       foreach my $e (@{$fn->{ELEMENTS}}) {
-               if (grep (/out/, @{$e->{DIRECTION}})) {
-                       $env{$e->{NAME}} = $base."out.$e->{NAME}";
-               } elsif (grep (/in/, @{$e->{DIRECTION}})) {
-                       $env{$e->{NAME}} = $base."in.$e->{NAME}";
-               }
-       }
-
-       return \%env;
-}
-
 #####################################################################
 # parse the data of an array - push side
 sub ParseArrayPushHeader($$$$$$)
@@ -403,12 +331,12 @@ sub ParseArrayPullHeader($$$$$$)
        } else {
                $length = $size = ParseExprExt($l->{SIZE_IS}, $env, $e->{ORIGINAL},
                        check_null_pointer($e, $env, sub { $self->pidl(shift); },
-                                          "return ndr_pull_error(ndr, NDR_ERR_INVALID_POINTER, \"NULL Pointer for size_is()\");"),
+                                          "return ndr_pull_error($ndr, NDR_ERR_INVALID_POINTER, \"NULL Pointer for size_is()\");"),
                        check_fully_dereferenced($e, $env));
        }
 
        if ((!$l->{IS_SURROUNDING}) and $l->{IS_CONFORMANT}) {
-               $self->pidl("NDR_CHECK(ndr_pull_array_size(ndr, " . get_pointer_to($var_name) . "));");
+               $self->pidl("NDR_CHECK(ndr_pull_array_size($ndr, " . get_pointer_to($var_name) . "));");
        }
 
        if ($l->{IS_VARYING}) {
@@ -429,9 +357,9 @@ sub ParseArrayPullHeader($$$$$$)
                $self->defer_indent;
                my $size = ParseExprExt($l->{SIZE_IS}, $env, $e->{ORIGINAL},
                        check_null_pointer($e, $env, sub { $self->defer(shift); },
-                                          "return ndr_pull_error(ndr, NDR_ERR_INVALID_POINTER, \"NULL Pointer for size_is()\");"),
+                                          "return ndr_pull_error($ndr, NDR_ERR_INVALID_POINTER, \"NULL Pointer for size_is()\");"),
                        check_fully_dereferenced($e, $env));
-               $self->defer("NDR_CHECK(ndr_check_array_size(ndr, (void*)" . get_pointer_to($var_name) . ", $size));");
+               $self->defer("NDR_CHECK(ndr_check_array_size($ndr, (void*)" . get_pointer_to($var_name) . ", $size));");
                $self->defer_deindent;
                $self->defer("}");
        }
@@ -441,15 +369,15 @@ sub ParseArrayPullHeader($$$$$$)
                $self->defer_indent;
                my $length = ParseExprExt($l->{LENGTH_IS}, $env, $e->{ORIGINAL}, 
                        check_null_pointer($e, $env, sub { $self->defer(shift); },
-                                          "return ndr_pull_error(ndr, NDR_ERR_INVALID_POINTER, \"NULL Pointer for length_is()\");"),
+                                          "return ndr_pull_error($ndr, NDR_ERR_INVALID_POINTER, \"NULL Pointer for length_is()\");"),
                        check_fully_dereferenced($e, $env));
-               $self->defer("NDR_CHECK(ndr_check_array_length(ndr, (void*)" . get_pointer_to($var_name) . ", $length));");
+               $self->defer("NDR_CHECK(ndr_check_array_length($ndr, (void*)" . get_pointer_to($var_name) . ", $length));");
                $self->defer_deindent;
                $self->defer("}");
        }
 
        if (not $l->{IS_FIXED} and not is_charset_array($e, $l)) {
-               $self->AllocateArrayLevel($e,$l,$ndr,$env,$size);
+               $self->AllocateArrayLevel($e,$l,$ndr,$var_name,$size);
        }
 
        return $length;
@@ -458,7 +386,7 @@ sub ParseArrayPullHeader($$$$$$)
 sub compression_alg($$)
 {
        my ($e, $l) = @_;
-       my ($alg, $clen, $dlen) = split(/ /, $l->{COMPRESSION});
+       my ($alg, $clen, $dlen) = split(/,/, $l->{COMPRESSION});
 
        return $alg;
 }
@@ -466,7 +394,7 @@ sub compression_alg($$)
 sub compression_clen($$$)
 {
        my ($e, $l, $env) = @_;
-       my ($alg, $clen, $dlen) = split(/ /, $l->{COMPRESSION});
+       my ($alg, $clen, $dlen) = split(/,/, $l->{COMPRESSION});
 
        return ParseExpr($clen, $env, $e->{ORIGINAL});
 }
@@ -474,7 +402,7 @@ sub compression_clen($$$)
 sub compression_dlen($$$)
 {
        my ($e,$l,$env) = @_;
-       my ($alg, $clen, $dlen) = split(/ /, $l->{COMPRESSION});
+       my ($alg, $clen, $dlen) = split(/,/, $l->{COMPRESSION});
 
        return ParseExpr($dlen, $env, $e->{ORIGINAL});
 }
@@ -615,7 +543,7 @@ sub ParseElementPushLevel
                        $self->ParseElementPushLevel($e, GetNextLevel($e, $l), $subndr, $var_name, $env, 1, 1);
                        $self->ParseSubcontextPushEnd($e, $l, $ndr, $env);
                } elsif ($l->{TYPE} eq "POINTER") {
-                       $self->ParsePtrPush($e, $l, $var_name);
+                       $self->ParsePtrPush($e, $l, $ndr, $var_name);
                } elsif ($l->{TYPE} eq "ARRAY") {
                        my $length = $self->ParseArrayPushHeader($e, $l, $ndr, $var_name, $env); 
 
@@ -641,7 +569,7 @@ sub ParseElementPushLevel
                        $self->pidl("if ($var_name) {");
                        $self->indent;
                        if ($l->{POINTER_TYPE} eq "relative") {
-                               $self->pidl("NDR_CHECK(ndr_push_relative_ptr2(ndr, $var_name));");
+                               $self->pidl("NDR_CHECK(ndr_push_relative_ptr2($ndr, $var_name));");
                        }
                }
                $var_name = get_value_of($var_name);
@@ -656,7 +584,7 @@ sub ParseElementPushLevel
                my $length = ParseExpr($l->{LENGTH_IS}, $env, $e->{ORIGINAL});
                my $counter = "cntr_$e->{NAME}_$l->{LEVEL_INDEX}";
 
-               $var_name = $var_name . "[$counter]";
+               $var_name = get_array_element($var_name, $counter);
 
                if (($primitives and not $l->{IS_DEFERRED}) or ($deferred and $l->{IS_DEFERRED})) {
                        $self->pidl("for ($counter = 0; $counter < $length; $counter++) {");
@@ -719,75 +647,100 @@ sub ParseElementPush($$$$$$)
 
 #####################################################################
 # parse a pointer in a struct element or function
-sub ParsePtrPush($$$$)
+sub ParsePtrPush($$$$$)
 {
-       my ($self,$e,$l,$var_name) = @_;
+       my ($self,$e,$l,$ndr,$var_name) = @_;
 
        if ($l->{POINTER_TYPE} eq "ref") {
                $self->pidl("if ($var_name == NULL) {");
                $self->indent;
-               $self->pidl("return ndr_push_error(ndr, NDR_ERR_INVALID_POINTER, \"NULL [ref] pointer\");");
+               $self->pidl("return ndr_push_error($ndr, NDR_ERR_INVALID_POINTER, \"NULL [ref] pointer\");");
                $self->deindent;
                $self->pidl("}");
                if ($l->{LEVEL} eq "EMBEDDED") {
                        $self->pidl("NDR_CHECK(ndr_push_ref_ptr(ndr));");
                }
        } elsif ($l->{POINTER_TYPE} eq "relative") {
-               $self->pidl("NDR_CHECK(ndr_push_relative_ptr1(ndr, $var_name));");
+               $self->pidl("NDR_CHECK(ndr_push_relative_ptr1($ndr, $var_name));");
        } elsif ($l->{POINTER_TYPE} eq "unique") {
-               $self->pidl("NDR_CHECK(ndr_push_unique_ptr(ndr, $var_name));");
+               $self->pidl("NDR_CHECK(ndr_push_unique_ptr($ndr, $var_name));");
        } elsif ($l->{POINTER_TYPE} eq "full") {
-               $self->pidl("NDR_CHECK(ndr_push_full_ptr(ndr, $var_name));");
+               $self->pidl("NDR_CHECK(ndr_push_full_ptr($ndr, $var_name));");
        } else {
                die("Unhandled pointer type $l->{POINTER_TYPE}");
        }
 }
 
-sub ParseDataPrint($$$$)
+sub need_pointer_to($$$)
 {
-       my ($self, $e, $l, $var_name) = @_;
-       
-       if (not ref($l->{DATA_TYPE}) or 
-               defined($l->{DATA_TYPE}->{NAME})) {
-               my $t;
-               if (ref($l->{DATA_TYPE})) {
-                       $t = "$l->{DATA_TYPE}->{TYPE}_$l->{DATA_TYPE}->{NAME}";
-               } else {
-                       $t = $l->{DATA_TYPE};
+       my ($e, $l, $scalar_only) = @_;
+
+       my $t;
+       if (ref($l->{DATA_TYPE})) {
+               $t = "$l->{DATA_TYPE}->{TYPE}_$l->{DATA_TYPE}->{NAME}";
+       } else {
+               $t = $l->{DATA_TYPE};
+       }
+
+       if (not Parse::Pidl::Typelist::is_scalar($t)) {
+               return 1 if $scalar_only;
+       }
+
+       my $arrays = 0;
+
+       foreach my $tl (@{$e->{LEVELS}}) {
+               last if $l == $tl;
+               if ($tl->{TYPE} eq "ARRAY") {
+                       $arrays++;
                }
-               if (not Parse::Pidl::Typelist::is_scalar($t) or 
-                       Parse::Pidl::Typelist::scalar_is_reference($t)) {
+       }
+
+       if (Parse::Pidl::Typelist::scalar_is_reference($t)) {
+               return 1 unless $arrays;
+       }
+
+       return 0;
+}
+
+sub ParseDataPrint($$$$$)
+{
+       my ($self, $e, $l, $ndr, $var_name) = @_;
+
+       if (not ref($l->{DATA_TYPE}) or defined($l->{DATA_TYPE}->{NAME})) {
+
+               if (need_pointer_to($e, $l, 1)) {
                        $var_name = get_pointer_to($var_name);
                }
-               $self->pidl("ndr_print_$t(ndr, \"$e->{NAME}\", $var_name);");
+
+               $self->pidl(TypeFunctionName("ndr_print", $l->{DATA_TYPE})."($ndr, \"$e->{NAME}\", $var_name);");
        } else {
-               $self->ParseTypePrint($l->{DATA_TYPE}, $var_name);
+               $self->ParseTypePrint($l->{DATA_TYPE}, $ndr, $var_name);
        }
 }
 
 #####################################################################
 # print scalars in a structure element
-sub ParseElementPrint($$$$)
+sub ParseElementPrint($$$$$)
 {
-       my($self, $e, $var_name, $env) = @_;
+       my($self, $e, $ndr, $var_name, $env) = @_;
 
        return if (has_property($e, "noprint"));
 
        if ($e->{REPRESENTATION_TYPE} ne $e->{TYPE}) {
-               $self->pidl("ndr_print_$e->{REPRESENTATION_TYPE}(ndr, \"$e->{NAME}\", $var_name);");
+               $self->pidl("ndr_print_$e->{REPRESENTATION_TYPE}($ndr, \"$e->{NAME}\", $var_name);");
                return;
        }
 
        $var_name = append_prefix($e, $var_name);
 
        if (defined(my $value = has_property($e, "value"))) {
-               $var_name = "(ndr->flags & LIBNDR_PRINT_SET_VALUES)?" . ParseExpr($value,$env, $e->{ORIGINAL}) . ":$var_name";
+               $var_name = "($ndr->flags & LIBNDR_PRINT_SET_VALUES)?" . ParseExpr($value,$env, $e->{ORIGINAL}) . ":$var_name";
        }
 
        foreach my $l (@{$e->{LEVELS}}) {
                if ($l->{TYPE} eq "POINTER") {
-                       $self->pidl("ndr_print_ptr(ndr, \"$e->{NAME}\", $var_name);");
-                       $self->pidl("ndr->depth++;");
+                       $self->pidl("ndr_print_ptr($ndr, \"$e->{NAME}\", $var_name);");
+                       $self->pidl("$ndr->depth++;");
                        if ($l->{POINTER_TYPE} ne "ref") {
                                $self->pidl("if ($var_name) {");
                                $self->indent;
@@ -808,32 +761,31 @@ sub ParseElementPrint($$$$)
                        }
 
                        if (is_charset_array($e,$l)) {
-                               $self->pidl("ndr_print_string(ndr, \"$e->{NAME}\", $var_name);");
+                               $self->pidl("ndr_print_string($ndr, \"$e->{NAME}\", $var_name);");
                                last;
                        } elsif (has_fast_array($e, $l)) {
                                my $nl = GetNextLevel($e, $l);
-                               $self->pidl("ndr_print_array_$nl->{DATA_TYPE}(ndr, \"$e->{NAME}\", $var_name, $length);");
+                               $self->pidl("ndr_print_array_$nl->{DATA_TYPE}($ndr, \"$e->{NAME}\", $var_name, $length);");
                                last;
                        } else {
                                my $counter = "cntr_$e->{NAME}_$l->{LEVEL_INDEX}";
 
-                               $self->pidl("ndr->print(ndr, \"\%s: ARRAY(\%d)\", \"$e->{NAME}\", $length);");
-                               $self->pidl("ndr->depth++;");
+                               $self->pidl("$ndr->print($ndr, \"\%s: ARRAY(\%d)\", \"$e->{NAME}\", (int)$length);");
+                               $self->pidl("$ndr->depth++;");
                                $self->pidl("for ($counter=0;$counter<$length;$counter++) {");
                                $self->indent;
                                $self->pidl("char *idx_$l->{LEVEL_INDEX}=NULL;");
-                               $self->pidl("asprintf(&idx_$l->{LEVEL_INDEX}, \"[\%d]\", $counter);");
-                               $self->pidl("if (idx_$l->{LEVEL_INDEX}) {");
+                               $self->pidl("if (asprintf(&idx_$l->{LEVEL_INDEX}, \"[\%d]\", $counter) != -1) {");
                                $self->indent;
 
-                               $var_name = $var_name . "[$counter]";
+                               $var_name = get_array_element($var_name, $counter);
                        }
                } elsif ($l->{TYPE} eq "DATA") {
-                       $self->ParseDataPrint($e, $l, $var_name);
+                       $self->ParseDataPrint($e, $l, $ndr, $var_name);
                } elsif ($l->{TYPE} eq "SWITCH") {
                        my $switch_var = ParseExprExt($l->{SWITCH_IS}, $env, $e->{ORIGINAL}, 
                                                check_null_pointer($e, $env, sub { $self->pidl(shift); }, "return;"), check_fully_dereferenced($e, $env));
-                       $self->pidl("ndr_print_set_switch_value(ndr, " . get_pointer_to($var_name) . ", $switch_var);");
+                       $self->pidl("ndr_print_set_switch_value($ndr, " . get_pointer_to($var_name) . ", $switch_var);");
                } 
        }
 
@@ -843,7 +795,7 @@ sub ParseElementPrint($$$$)
                                $self->deindent;
                                $self->pidl("}");
                        }
-                       $self->pidl("ndr->depth--;");
+                       $self->pidl("$ndr->depth--;");
                } elsif (($l->{TYPE} eq "ARRAY")
                        and not is_charset_array($e,$l)
                        and not has_fast_array($e,$l)) {
@@ -852,7 +804,7 @@ sub ParseElementPrint($$$$)
                        $self->pidl("}");
                        $self->deindent;
                        $self->pidl("}");
-                       $self->pidl("ndr->depth--;");
+                       $self->pidl("$ndr->depth--;");
                }
        }
 }
@@ -864,7 +816,7 @@ sub ParseSwitchPull($$$$$$)
        my($self,$e,$l,$ndr,$var_name,$env) = @_;
        my $switch_var = ParseExprExt($l->{SWITCH_IS}, $env, $e->{ORIGINAL}, 
                check_null_pointer($e, $env, sub { $self->pidl(shift); },
-                                  "return ndr_pull_error(ndr, NDR_ERR_INVALID_POINTER, \"NULL Pointer for switch_is()\");"),
+                                  "return ndr_pull_error($ndr, NDR_ERR_INVALID_POINTER, \"NULL Pointer for switch_is()\");"),
                check_fully_dereferenced($e, $env));
 
        $var_name = get_pointer_to($var_name);
@@ -878,7 +830,7 @@ sub ParseSwitchPush($$$$$$)
        my($self,$e,$l,$ndr,$var_name,$env) = @_;
        my $switch_var = ParseExprExt($l->{SWITCH_IS}, $env, $e->{ORIGINAL}, 
                check_null_pointer($e, $env, sub { $self->pidl(shift); },
-                                  "return ndr_push_error(ndr, NDR_ERR_INVALID_POINTER, \"NULL Pointer for switch_is()\");"),
+                                  "return ndr_push_error($ndr, NDR_ERR_INVALID_POINTER, \"NULL Pointer for switch_is()\");"),
                check_fully_dereferenced($e, $env));
 
        $var_name = get_pointer_to($var_name);
@@ -889,12 +841,11 @@ sub ParseDataPull($$$$$$$)
 {
        my ($self,$e,$l,$ndr,$var_name,$primitives,$deferred) = @_;
 
-       if (not ref($l->{DATA_TYPE}) or 
-               defined($l->{DATA_TYPE}->{NAME})) {
+       if (not ref($l->{DATA_TYPE}) or defined($l->{DATA_TYPE}->{NAME})) {
 
                my $ndr_flags = CalcNdrFlags($l, $primitives, $deferred);
 
-               if (Parse::Pidl::Typelist::scalar_is_reference($l->{DATA_TYPE})) {
+               if (need_pointer_to($e, $l, 0)) {
                        $var_name = get_pointer_to($var_name);
                }
 
@@ -904,13 +855,13 @@ sub ParseDataPull($$$$$$$)
 
                if (my $range = has_property($e, "range")) {
                        $var_name = get_value_of($var_name);
-                       my ($low, $high) = split(/ /, $range, 2);
+                       my ($low, $high) = split(/,/, $range, 2);
                        $self->pidl("if ($var_name < $low || $var_name > $high) {");
                        $self->pidl("\treturn ndr_pull_error($ndr, NDR_ERR_RANGE, \"value out of range\");");
                        $self->pidl("}");
                }
        } else {
-               $self->ParseTypePull($l->{DATA_TYPE}, $var_name, $primitives, $deferred);
+               $self->ParseTypePull($l->{DATA_TYPE}, $ndr, $var_name, $primitives, $deferred);
        }
 }
 
@@ -919,23 +870,17 @@ sub ParseDataPush($$$$$$$)
        my ($self,$e,$l,$ndr,$var_name,$primitives,$deferred) = @_;
 
        if (not ref($l->{DATA_TYPE}) or defined($l->{DATA_TYPE}->{NAME})) {
-               my $t;
-               if (ref($l->{DATA_TYPE}) eq "HASH") {
-                       $t = "$l->{DATA_TYPE}->{TYPE}_$l->{DATA_TYPE}->{NAME}";
-               } else {
-                       $t = $l->{DATA_TYPE};
-               }
-                               
+
+               my $ndr_flags = CalcNdrFlags($l, $primitives, $deferred);
+
                # strings are passed by value rather than reference
-               if (not Parse::Pidl::Typelist::is_scalar($t) or 
-                       Parse::Pidl::Typelist::scalar_is_reference($t)) {
+               if (need_pointer_to($e, $l, 1)) {
                        $var_name = get_pointer_to($var_name);
                }
 
-               my $ndr_flags = CalcNdrFlags($l, $primitives, $deferred);
-               $self->pidl("NDR_CHECK(ndr_push_$t($ndr, $ndr_flags, $var_name));");
+               $self->pidl("NDR_CHECK(".TypeFunctionName("ndr_push", $l->{DATA_TYPE})."($ndr, $ndr_flags, $var_name));");
        } else {
-               $self->ParseTypePush($l->{DATA_TYPE}, $var_name, $primitives, $deferred);
+               $self->ParseTypePush($l->{DATA_TYPE}, $ndr, $var_name, $primitives, $deferred);
        }
 }
 
@@ -964,15 +909,17 @@ sub CalcNdrFlags($$$)
        return undef;
 }
 
-sub ParseMemCtxPullStart($$$$)
+sub ParseMemCtxPullFlags($$$$)
 {
-       my ($self, $e, $l, $ptr_name) = @_;
+       my ($self, $e, $l) = @_;
 
-       my $mem_r_ctx = "_mem_save_$e->{NAME}_$l->{LEVEL_INDEX}";
-       my $mem_c_ctx = $ptr_name;
-       my $mem_c_flags = "0";
+       return undef unless ($l->{TYPE} eq "POINTER" or $l->{TYPE} eq "ARRAY");
+
+       return undef if ($l->{TYPE} eq "ARRAY" and $l->{IS_FIXED});
+       return undef if has_fast_array($e, $l);
+       return undef if is_charset_array($e, $l);
 
-       return if ($l->{TYPE} eq "ARRAY" and $l->{IS_FIXED});
+       my $mem_flags = "0";
 
        if (($l->{TYPE} eq "POINTER") and ($l->{POINTER_TYPE} eq "ref")) {
                my $nl = GetNextLevel($e, $l);
@@ -980,38 +927,39 @@ sub ParseMemCtxPullStart($$$$)
                my $next_is_string = (($nl->{TYPE} eq "DATA") and 
                                        ($nl->{DATA_TYPE} eq "string"));
                if ($next_is_array or $next_is_string) {
-                       return;
-               } else {
-                       $mem_c_flags = "LIBNDR_FLAG_REF_ALLOC";
+                       return undef;
+               } elsif ($l->{LEVEL} eq "TOP") {
+                       $mem_flags = "LIBNDR_FLAG_REF_ALLOC";
                }
        }
 
-       $self->pidl("$mem_r_ctx = NDR_PULL_GET_MEM_CTX(ndr);");
-       $self->pidl("NDR_PULL_SET_MEM_CTX(ndr, $mem_c_ctx, $mem_c_flags);");
+       return $mem_flags;
 }
 
-sub ParseMemCtxPullEnd($$$)
+sub ParseMemCtxPullStart($$$$$)
 {
-       my ($self, $e, $l) = @_;
+       my ($self, $e, $l, $ndr, $ptr_name) = @_;
 
        my $mem_r_ctx = "_mem_save_$e->{NAME}_$l->{LEVEL_INDEX}";
-       my $mem_r_flags = "0";
+       my $mem_c_ctx = $ptr_name;
+       my $mem_c_flags = $self->ParseMemCtxPullFlags($e, $l);
 
-       return if ($l->{TYPE} eq "ARRAY" and $l->{IS_FIXED});
+       return unless defined($mem_c_flags);
 
-       if (($l->{TYPE} eq "POINTER") and ($l->{POINTER_TYPE} eq "ref")) {
-               my $nl = GetNextLevel($e, $l);
-               my $next_is_array = ($nl->{TYPE} eq "ARRAY");
-               my $next_is_string = (($nl->{TYPE} eq "DATA") and 
-                                       ($nl->{DATA_TYPE} eq "string"));
-               if ($next_is_array or $next_is_string) {
-                       return;
-               } else {
-                       $mem_r_flags = "LIBNDR_FLAG_REF_ALLOC";
-               }
-       }
+       $self->pidl("$mem_r_ctx = NDR_PULL_GET_MEM_CTX($ndr);");
+       $self->pidl("NDR_PULL_SET_MEM_CTX($ndr, $mem_c_ctx, $mem_c_flags);");
+}
+
+sub ParseMemCtxPullEnd($$$$)
+{
+       my ($self, $e, $l, $ndr) = @_;
+
+       my $mem_r_ctx = "_mem_save_$e->{NAME}_$l->{LEVEL_INDEX}";
+       my $mem_r_flags = $self->ParseMemCtxPullFlags($e, $l);
 
-       $self->pidl("NDR_PULL_SET_MEM_CTX(ndr, $mem_r_ctx, $mem_r_flags);");
+       return unless defined($mem_r_flags);
+
+       $self->pidl("NDR_PULL_SET_MEM_CTX($ndr, $mem_r_ctx, $mem_r_flags);");
 }
 
 sub CheckStringTerminator($$$$$)
@@ -1074,21 +1022,21 @@ sub ParseElementPullLevel
 
                        if ($l->{POINTER_TYPE} eq "relative") {
                                $self->pidl("uint32_t _relative_save_offset;");
-                               $self->pidl("_relative_save_offset = ndr->offset;");
-                               $self->pidl("NDR_CHECK(ndr_pull_relative_ptr2(ndr, $var_name));");
+                               $self->pidl("_relative_save_offset = $ndr->offset;");
+                               $self->pidl("NDR_CHECK(ndr_pull_relative_ptr2($ndr, $var_name));");
                        }
                }
 
-               $self->ParseMemCtxPullStart($e, $l, $var_name);
+               $self->ParseMemCtxPullStart($e, $l, $ndr, $var_name);
 
                $var_name = get_value_of($var_name);
                $self->ParseElementPullLevel($e, GetNextLevel($e,$l), $ndr, $var_name, $env, 1, 1);
 
-               $self->ParseMemCtxPullEnd($e,$l);
+               $self->ParseMemCtxPullEnd($e, $l, $ndr);
 
                if ($l->{POINTER_TYPE} ne "ref") {
                        if ($l->{POINTER_TYPE} eq "relative") {
-                               $self->pidl("ndr->offset = _relative_save_offset;");
+                               $self->pidl("$ndr->offset = _relative_save_offset;");
                        }
                        $self->deindent;
                        $self->pidl("}");
@@ -1099,9 +1047,9 @@ sub ParseElementPullLevel
                my $counter = "cntr_$e->{NAME}_$l->{LEVEL_INDEX}";
                my $array_name = $var_name;
 
-               $var_name = $var_name . "[$counter]";
+               $var_name = get_array_element($var_name, $counter);
 
-               $self->ParseMemCtxPullStart($e, $l, $array_name);
+               $self->ParseMemCtxPullStart($e, $l, $ndr, $array_name);
 
                if (($primitives and not $l->{IS_DEFERRED}) or ($deferred and $l->{IS_DEFERRED})) {
                        my $nl = GetNextLevel($e,$l);
@@ -1125,7 +1073,7 @@ sub ParseElementPullLevel
                        $self->pidl("}");
                }
 
-               $self->ParseMemCtxPullEnd($e, $l);
+               $self->ParseMemCtxPullEnd($e, $l, $ndr);
 
        } elsif ($l->{TYPE} eq "SWITCH") {
                $self->ParseElementPullLevel($e, GetNextLevel($e,$l), $ndr, $var_name, $env, $primitives, $deferred);
@@ -1180,28 +1128,28 @@ sub ParsePtrPull($$$$$)
        my $next_is_string = (($nl->{TYPE} eq "DATA") and 
                                                 ($nl->{DATA_TYPE} eq "string"));
 
-       if ($l->{POINTER_TYPE} eq "ref") {
-               if ($l->{LEVEL} eq "EMBEDDED") {
-                       $self->pidl("NDR_CHECK(ndr_pull_ref_ptr($ndr, &_ptr_$e->{NAME}));");
-               }
+       if ($l->{POINTER_TYPE} eq "ref" and $l->{LEVEL} eq "TOP") {
 
                if (!$next_is_array and !$next_is_string) {
-                       $self->pidl("if (ndr->flags & LIBNDR_FLAG_REF_ALLOC) {");
+                       $self->pidl("if ($ndr->flags & LIBNDR_FLAG_REF_ALLOC) {");
                        $self->pidl("\tNDR_PULL_ALLOC($ndr, $var_name);"); 
                        $self->pidl("}");
                }
                
                return;
+       } elsif ($l->{POINTER_TYPE} eq "ref" and $l->{LEVEL} eq "EMBEDDED") {
+               $self->pidl("NDR_CHECK(ndr_pull_ref_ptr($ndr, &_ptr_$e->{NAME}));");
        } elsif (($l->{POINTER_TYPE} eq "unique") or 
                 ($l->{POINTER_TYPE} eq "relative") or
                 ($l->{POINTER_TYPE} eq "full")) {
                $self->pidl("NDR_CHECK(ndr_pull_generic_ptr($ndr, &_ptr_$e->{NAME}));");
-               $self->pidl("if (_ptr_$e->{NAME}) {");
-               $self->indent;
        } else {
                die("Unhandled pointer type $l->{POINTER_TYPE}");
        }
 
+       $self->pidl("if (_ptr_$e->{NAME}) {");
+       $self->indent;
+
        # Don't do this for arrays, they're allocated at the actual level 
        # of the array
        unless ($next_is_array or $next_is_string) { 
@@ -1224,9 +1172,9 @@ sub ParsePtrPull($$$$$)
        $self->pidl("}");
 }
 
-sub ParseStructPushPrimitives($$$$)
+sub ParseStructPushPrimitives($$$$$)
 {
-       my ($self, $struct, $varname, $env) = @_;
+       my ($self, $struct, $ndr, $varname, $env) = @_;
 
        # see if the structure contains a conformant array. If it
        # does, then it must be the last element of the structure, and
@@ -1250,39 +1198,39 @@ sub ParseStructPushPrimitives($$$$)
                                $size = ParseExpr($e->{LEVELS}[0]->{SIZE_IS}, $env, $e->{ORIGINAL});
                        }
 
-                       $self->pidl("NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, $size));");
+                       $self->pidl("NDR_CHECK(ndr_push_uint32($ndr, NDR_SCALARS, $size));");
                } else {
-                       $self->pidl("NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, ndr_string_array_size(ndr, $varname->$e->{NAME})));");
+                       $self->pidl("NDR_CHECK(ndr_push_uint32($ndr, NDR_SCALARS, ndr_string_array_size($ndr, $varname->$e->{NAME})));");
                }
        }
 
-       $self->pidl("NDR_CHECK(ndr_push_align(ndr, $struct->{ALIGN}));");
+       $self->pidl("NDR_CHECK(ndr_push_align($ndr, $struct->{ALIGN}));");
 
        if (defined($struct->{PROPERTIES}{relative_base})) {
                # set the current offset as base for relative pointers
                # and store it based on the toplevel struct/union
-               $self->pidl("NDR_CHECK(ndr_push_setup_relative_base_offset1(ndr, $varname, ndr->offset));");
+               $self->pidl("NDR_CHECK(ndr_push_setup_relative_base_offset1($ndr, $varname, $ndr->offset));");
        }
 
-       $self->ParseElementPush($_, "ndr", $env, 1, 0) foreach (@{$struct->{ELEMENTS}});
+       $self->ParseElementPush($_, $ndr, $env, 1, 0) foreach (@{$struct->{ELEMENTS}});
 }
 
-sub ParseStructPushDeferred($$$)
+sub ParseStructPushDeferred($$$$)
 {
-       my ($self, $struct, $varname, $env) = @_;
+       my ($self, $struct, $ndr, $varname, $env) = @_;
        if (defined($struct->{PROPERTIES}{relative_base})) {
                # retrieve the current offset as base for relative pointers
                # based on the toplevel struct/union
-               $self->pidl("NDR_CHECK(ndr_push_setup_relative_base_offset2(ndr, $varname));");
+               $self->pidl("NDR_CHECK(ndr_push_setup_relative_base_offset2($ndr, $varname));");
        }
-       $self->ParseElementPush($_, "ndr", $env, 0, 1) foreach (@{$struct->{ELEMENTS}});
+       $self->ParseElementPush($_, $ndr, $env, 0, 1) foreach (@{$struct->{ELEMENTS}});
 }
 
 #####################################################################
 # parse a struct
-sub ParseStructPush($$$)
+sub ParseStructPush($$$$)
 {
-       my ($self, $struct, $varname) = @_;
+       my ($self, $struct, $ndr, $varname) = @_;
        
        return unless defined($struct->{ELEMENTS});
 
@@ -1296,13 +1244,13 @@ sub ParseStructPush($$$)
 
        $self->pidl("if (ndr_flags & NDR_SCALARS) {");
        $self->indent;
-       $self->ParseStructPushPrimitives($struct, $varname, $env);
+       $self->ParseStructPushPrimitives($struct, $ndr, $varname, $env);
        $self->deindent;
        $self->pidl("}");
 
        $self->pidl("if (ndr_flags & NDR_BUFFERS) {");
        $self->indent;
-       $self->ParseStructPushDeferred($struct, $varname, $env);
+       $self->ParseStructPushDeferred($struct, $ndr, $varname, $env);
        $self->deindent;
        $self->pidl("}");
 
@@ -1311,27 +1259,27 @@ sub ParseStructPush($$$)
 
 #####################################################################
 # generate a push function for an enum
-sub ParseEnumPush($$$)
+sub ParseEnumPush($$$$)
 {
-       my($self,$enum,$varname) = @_;
+       my($self,$enum,$ndr,$varname) = @_;
        my($type_fn) = $enum->{BASE_TYPE};
 
        $self->start_flags($enum);
-       $self->pidl("NDR_CHECK(ndr_push_$type_fn(ndr, NDR_SCALARS, $varname));");
+       $self->pidl("NDR_CHECK(ndr_push_$type_fn($ndr, NDR_SCALARS, $varname));");
        $self->end_flags($enum);
 }
 
 #####################################################################
 # generate a pull function for an enum
-sub ParseEnumPull($$$)
+sub ParseEnumPull($$$$)
 {
-       my($self,$enum,$varname) = @_;
+       my($self,$enum,$ndr,$varname) = @_;
        my($type_fn) = $enum->{BASE_TYPE};
        my($type_v_decl) = mapTypeName($type_fn);
 
        $self->pidl("$type_v_decl v;");
        $self->start_flags($enum);
-       $self->pidl("NDR_CHECK(ndr_pull_$type_fn(ndr, NDR_SCALARS, &v));");
+       $self->pidl("NDR_CHECK(ndr_pull_$type_fn($ndr, NDR_SCALARS, &v));");
        $self->pidl("*$varname = v;");
 
        $self->end_flags($enum);
@@ -1339,9 +1287,9 @@ sub ParseEnumPull($$$)
 
 #####################################################################
 # generate a print function for an enum
-sub ParseEnumPrint($$$$)
+sub ParseEnumPrint($$$$$)
 {
-       my($self,$enum,$name,$varname) = @_;
+       my($self,$enum,$ndr,$name,$varname) = @_;
 
        $self->pidl("const char *val = NULL;");
        $self->pidl("");
@@ -1363,7 +1311,7 @@ sub ParseEnumPrint($$$$)
        $self->deindent;
        $self->pidl("}");
        
-       $self->pidl("ndr_print_enum(ndr, name, \"$enum->{TYPE}\", val, $varname);");
+       $self->pidl("ndr_print_enum($ndr, name, \"$enum->{TYPE}\", val, $varname);");
 
        $self->end_flags($enum);
 }
@@ -1384,29 +1332,29 @@ $typefamily{ENUM} = {
 
 #####################################################################
 # generate a push function for a bitmap
-sub ParseBitmapPush($$$)
+sub ParseBitmapPush($$$$)
 {
-       my($self,$bitmap,$varname) = @_;
+       my($self,$bitmap,$ndr,$varname) = @_;
        my($type_fn) = $bitmap->{BASE_TYPE};
 
        $self->start_flags($bitmap);
 
-       $self->pidl("NDR_CHECK(ndr_push_$type_fn(ndr, NDR_SCALARS, $varname));");
+       $self->pidl("NDR_CHECK(ndr_push_$type_fn($ndr, NDR_SCALARS, $varname));");
 
        $self->end_flags($bitmap);
 }
 
 #####################################################################
 # generate a pull function for an bitmap
-sub ParseBitmapPull($$$)
+sub ParseBitmapPull($$$$)
 {
-       my($self,$bitmap,$varname) = @_;
+       my($self,$bitmap,$ndr,$varname) = @_;
        my $type_fn = $bitmap->{BASE_TYPE};
        my($type_decl) = mapTypeName($bitmap->{BASE_TYPE});
 
        $self->pidl("$type_decl v;");
        $self->start_flags($bitmap);
-       $self->pidl("NDR_CHECK(ndr_pull_$type_fn(ndr, NDR_SCALARS, &v));");
+       $self->pidl("NDR_CHECK(ndr_pull_$type_fn($ndr, NDR_SCALARS, &v));");
        $self->pidl("*$varname = v;");
 
        $self->end_flags($bitmap);
@@ -1414,9 +1362,9 @@ sub ParseBitmapPull($$$)
 
 #####################################################################
 # generate a print function for an bitmap
-sub ParseBitmapPrintElement($$$$$)
+sub ParseBitmapPrintElement($$$$$$)
 {
-       my($self,$e,$bitmap,$name,$varname) = @_;
+       my($self,$e,$bitmap,$ndr,$name,$varname) = @_;
        my($type_decl) = mapTypeName($bitmap->{BASE_TYPE});
        my($type_fn) = $bitmap->{BASE_TYPE};
        my($flag);
@@ -1427,26 +1375,26 @@ sub ParseBitmapPrintElement($$$$$)
                die "Bitmap: \"$name\" invalid Flag: \"$e\"";
        }
 
-       $self->pidl("ndr_print_bitmap_flag(ndr, sizeof($type_decl), \"$flag\", $flag, $varname);");
+       $self->pidl("ndr_print_bitmap_flag($ndr, sizeof($type_decl), \"$flag\", $flag, $varname);");
 }
 
 #####################################################################
 # generate a print function for an bitmap
-sub ParseBitmapPrint($$$$)
+sub ParseBitmapPrint($$$$$)
 {
-       my($self,$bitmap,$name,$varname) = @_;
+       my($self,$bitmap,$ndr,$name,$varname) = @_;
        my($type_decl) = mapTypeName($bitmap->{TYPE});
        my($type_fn) = $bitmap->{BASE_TYPE};
 
        $self->start_flags($bitmap);
 
-       $self->pidl("ndr_print_$type_fn(ndr, name, $varname);");
+       $self->pidl("ndr_print_$type_fn($ndr, name, $varname);");
 
-       $self->pidl("ndr->depth++;");
+       $self->pidl("$ndr->depth++;");
        foreach my $e (@{$bitmap->{ELEMENTS}}) {
-               $self->ParseBitmapPrintElement($e, $bitmap, $name, $varname);
+               $self->ParseBitmapPrintElement($e, $bitmap, $ndr, $name, $varname);
        }
-       $self->pidl("ndr->depth--;");
+       $self->pidl("$ndr->depth--;");
 
        $self->end_flags($bitmap);
 }
@@ -1467,9 +1415,9 @@ $typefamily{BITMAP} = {
 
 #####################################################################
 # generate a struct print function
-sub ParseStructPrint($$$$)
+sub ParseStructPrint($$$$$)
 {
-       my($self,$struct,$name,$varname) = @_;
+       my($self,$struct,$ndr,$name,$varname) = @_;
 
        return unless defined $struct->{ELEMENTS};
 
@@ -1477,15 +1425,15 @@ sub ParseStructPrint($$$$)
 
        $self->DeclareArrayVariables($_) foreach (@{$struct->{ELEMENTS}});
 
-       $self->pidl("ndr_print_struct(ndr, name, \"$name\");");
+       $self->pidl("ndr_print_struct($ndr, name, \"$name\");");
 
        $self->start_flags($struct);
 
-       $self->pidl("ndr->depth++;");
+       $self->pidl("$ndr->depth++;");
        
-       $self->ParseElementPrint($_, $env->{$_->{NAME}}, $env) 
+       $self->ParseElementPrint($_, $ndr, $env->{$_->{NAME}}, $env)
                foreach (@{$struct->{ELEMENTS}});
-       $self->pidl("ndr->depth--;");
+       $self->pidl("$ndr->depth--;");
 
        $self->end_flags($struct);
 }
@@ -1515,68 +1463,49 @@ sub DeclareArrayVariables($$)
        }
 }
 
-sub need_decl_mem_ctx($$)
-{
-       my ($e,$l) = @_;
-
-       return 0 if has_fast_array($e,$l);
-       return 0 if is_charset_array($e,$l);
-       return 1 if (($l->{TYPE} eq "ARRAY") and not $l->{IS_FIXED});
-
-       if (($l->{TYPE} eq "POINTER") and ($l->{POINTER_TYPE} eq "ref")) {
-               my $nl = GetNextLevel($e, $l);
-               my $next_is_array = ($nl->{TYPE} eq "ARRAY");
-               my $next_is_string = (($nl->{TYPE} eq "DATA") and 
-                                       ($nl->{DATA_TYPE} eq "string"));
-               return 0 if ($next_is_array or $next_is_string);
-       }
-       return 1 if ($l->{TYPE} eq "POINTER");
-
-       return 0;
-}
-
 sub DeclareMemCtxVariables($$)
 {
        my ($self,$e) = @_;
        foreach my $l (@{$e->{LEVELS}}) {
-               if (need_decl_mem_ctx($e, $l)) {
+               my $mem_flags = $self->ParseMemCtxPullFlags($e, $l);
+               if (defined($mem_flags)) {
                        $self->pidl("TALLOC_CTX *_mem_save_$e->{NAME}_$l->{LEVEL_INDEX};");
                }
        }
 }
 
-sub ParseStructPullPrimitives($$$$)
+sub ParseStructPullPrimitives($$$$$)
 {
-       my($self,$struct,$varname,$env) = @_;
+       my($self,$struct,$ndr,$varname,$env) = @_;
 
        if (defined $struct->{SURROUNDING_ELEMENT}) {
-               $self->pidl("NDR_CHECK(ndr_pull_array_size(ndr, &$varname->$struct->{SURROUNDING_ELEMENT}->{NAME}));");
+               $self->pidl("NDR_CHECK(ndr_pull_array_size($ndr, &$varname->$struct->{SURROUNDING_ELEMENT}->{NAME}));");
        }
 
-       $self->pidl("NDR_CHECK(ndr_pull_align(ndr, $struct->{ALIGN}));");
+       $self->pidl("NDR_CHECK(ndr_pull_align($ndr, $struct->{ALIGN}));");
 
        if (defined($struct->{PROPERTIES}{relative_base})) {
                # set the current offset as base for relative pointers
                # and store it based on the toplevel struct/union
-               $self->pidl("NDR_CHECK(ndr_pull_setup_relative_base_offset1(ndr, $varname, ndr->offset));");
+               $self->pidl("NDR_CHECK(ndr_pull_setup_relative_base_offset1($ndr, $varname, $ndr->offset));");
        }
 
-       $self->ParseElementPull($_, "ndr", $env, 1, 0) foreach (@{$struct->{ELEMENTS}});
+       $self->ParseElementPull($_, $ndr, $env, 1, 0) foreach (@{$struct->{ELEMENTS}});
 
        $self->add_deferred();
 }
 
-sub ParseStructPullDeferred($$$$)
+sub ParseStructPullDeferred($$$$$)
 {
-       my ($self,$struct,$varname,$env) = @_;
+       my ($self,$struct,$ndr,$varname,$env) = @_;
 
        if (defined($struct->{PROPERTIES}{relative_base})) {
                # retrieve the current offset as base for relative pointers
                # based on the toplevel struct/union
-               $self->pidl("NDR_CHECK(ndr_pull_setup_relative_base_offset2(ndr, $varname));");
+               $self->pidl("NDR_CHECK(ndr_pull_setup_relative_base_offset2($ndr, $varname));");
        }
        foreach my $e (@{$struct->{ELEMENTS}}) {
-               $self->ParseElementPull($e, "ndr", $env, 0, 1);
+               $self->ParseElementPull($e, $ndr, $env, 0, 1);
        }
 
        $self->add_deferred();
@@ -1584,9 +1513,9 @@ sub ParseStructPullDeferred($$$$)
 
 #####################################################################
 # parse a struct - pull side
-sub ParseStructPull($$$)
+sub ParseStructPull($$$$)
 {
-       my($self,$struct,$varname) = @_;
+       my($self,$struct,$ndr,$varname) = @_;
 
        return unless defined $struct->{ELEMENTS};
 
@@ -1603,12 +1532,12 @@ sub ParseStructPull($$$)
 
        $self->pidl("if (ndr_flags & NDR_SCALARS) {");
        $self->indent;
-       $self->ParseStructPullPrimitives($struct,$varname,$env);
+       $self->ParseStructPullPrimitives($struct,$ndr,$varname,$env);
        $self->deindent;
        $self->pidl("}");
        $self->pidl("if (ndr_flags & NDR_BUFFERS) {");
        $self->indent;
-       $self->ParseStructPullDeferred($struct,$varname,$env);
+       $self->ParseStructPullDeferred($struct,$ndr,$varname,$env);
        $self->deindent;
        $self->pidl("}");
 
@@ -1663,16 +1592,16 @@ sub ParseUnionNdrSize($$$)
        $self->pidl("return ndr_size_union($varname, flags, level, (ndr_push_flags_fn_t)ndr_push_$name);");
 }
 
-sub ParseUnionPushPrimitives($$$)
+sub ParseUnionPushPrimitives($$$$)
 {
-       my ($self, $e, $varname) = @_;
+       my ($self, $e, $ndr ,$varname) = @_;
 
        my $have_default = 0;
 
-       $self->pidl("int level = ndr_push_get_switch_value(ndr, $varname);");
+       $self->pidl("int level = ndr_push_get_switch_value($ndr, $varname);");
 
        if (defined($e->{SWITCH_TYPE})) {
-               $self->pidl("NDR_CHECK(ndr_push_$e->{SWITCH_TYPE}(ndr, NDR_SCALARS, level));");
+               $self->pidl("NDR_CHECK(ndr_push_$e->{SWITCH_TYPE}($ndr, NDR_SCALARS, level));");
        }
 
        $self->pidl("switch (level) {");
@@ -1681,42 +1610,42 @@ sub ParseUnionPushPrimitives($$$)
                if ($el->{CASE} eq "default") {
                        $have_default = 1;
                }
-               $self->pidl("$el->{CASE}:");
+               $self->pidl("$el->{CASE}: {");
 
                if ($el->{TYPE} ne "EMPTY") {
                        $self->indent;
                        if (defined($e->{PROPERTIES}{relative_base})) {
-                               $self->pidl("NDR_CHECK(ndr_push_align(ndr, $el->{ALIGN}));");
+                               $self->pidl("NDR_CHECK(ndr_push_align($ndr, $el->{ALIGN}));");
                                # set the current offset as base for relative pointers
                                # and store it based on the toplevel struct/union
-                               $self->pidl("NDR_CHECK(ndr_push_setup_relative_base_offset1(ndr, $varname, ndr->offset));");
+                               $self->pidl("NDR_CHECK(ndr_push_setup_relative_base_offset1($ndr, $varname, $ndr->offset));");
                        }
                        $self->DeclareArrayVariables($el);
-                       $self->ParseElementPush($el, "ndr", {$el->{NAME} => "$varname->$el->{NAME}"}, 1, 0);
+                       $self->ParseElementPush($el, $ndr, {$el->{NAME} => "$varname->$el->{NAME}"}, 1, 0);
                        $self->deindent;
                }
-               $self->pidl("break;");
+               $self->pidl("break; }");
                $self->pidl("");
        }
        if (! $have_default) {
                $self->pidl("default:");
-               $self->pidl("\treturn ndr_push_error(ndr, NDR_ERR_BAD_SWITCH, \"Bad switch value \%u\", level);");
+               $self->pidl("\treturn ndr_push_error($ndr, NDR_ERR_BAD_SWITCH, \"Bad switch value \%u\", level);");
        }
        $self->deindent;
        $self->pidl("}");
 }
 
-sub ParseUnionPushDeferred($$$)
+sub ParseUnionPushDeferred($$$$)
 {
-       my ($self,$e,$varname) = @_;
+       my ($self,$e,$ndr,$varname) = @_;
 
        my $have_default = 0;
 
-       $self->pidl("int level = ndr_push_get_switch_value(ndr, $varname);");
+       $self->pidl("int level = ndr_push_get_switch_value($ndr, $varname);");
        if (defined($e->{PROPERTIES}{relative_base})) {
                # retrieve the current offset as base for relative pointers
                # based on the toplevel struct/union
-               $self->pidl("NDR_CHECK(ndr_push_setup_relative_base_offset2(ndr, $varname));");
+               $self->pidl("NDR_CHECK(ndr_push_setup_relative_base_offset2($ndr, $varname));");
        }
        $self->pidl("switch (level) {");
        $self->indent;
@@ -1728,7 +1657,7 @@ sub ParseUnionPushDeferred($$$)
                $self->pidl("$el->{CASE}:");
                if ($el->{TYPE} ne "EMPTY") {
                        $self->indent;
-                       $self->ParseElementPush($el, "ndr", {$el->{NAME} => "$varname->$el->{NAME}"}, 0, 1);
+                       $self->ParseElementPush($el, $ndr, {$el->{NAME} => "$varname->$el->{NAME}"}, 0, 1);
                        $self->deindent;
                }
                $self->pidl("break;");
@@ -1736,7 +1665,7 @@ sub ParseUnionPushDeferred($$$)
        }
        if (! $have_default) {
                $self->pidl("default:");
-               $self->pidl("\treturn ndr_push_error(ndr, NDR_ERR_BAD_SWITCH, \"Bad switch value \%u\", level);");
+               $self->pidl("\treturn ndr_push_error($ndr, NDR_ERR_BAD_SWITCH, \"Bad switch value \%u\", level);");
        }
        $self->deindent;
        $self->pidl("}");
@@ -1744,21 +1673,21 @@ sub ParseUnionPushDeferred($$$)
 
 #####################################################################
 # parse a union - push side
-sub ParseUnionPush($$$)
+sub ParseUnionPush($$$$)
 {
-       my ($self,$e,$varname) = @_;
+       my ($self,$e,$ndr,$varname) = @_;
        my $have_default = 0;
 
        $self->start_flags($e);
 
        $self->pidl("if (ndr_flags & NDR_SCALARS) {");
        $self->indent;
-       $self->ParseUnionPushPrimitives($e, $varname);
+       $self->ParseUnionPushPrimitives($e, $ndr, $varname);
        $self->deindent;
        $self->pidl("}");
        $self->pidl("if (ndr_flags & NDR_BUFFERS) {");
        $self->indent;
-       $self->ParseUnionPushDeferred($e, $varname);
+       $self->ParseUnionPushDeferred($e, $ndr, $varname);
        $self->deindent;
        $self->pidl("}");
        $self->end_flags($e);
@@ -1766,9 +1695,9 @@ sub ParseUnionPush($$$)
 
 #####################################################################
 # print a union
-sub ParseUnionPrint($$$$)
+sub ParseUnionPrint($$$$$)
 {
-       my ($self,$e,$name,$varname) = @_;
+       my ($self,$e,$ndr,$name,$varname) = @_;
        my $have_default = 0;
 
        $self->pidl("int level;");
@@ -1778,9 +1707,9 @@ sub ParseUnionPrint($$$$)
 
        $self->start_flags($e);
 
-       $self->pidl("level = ndr_print_get_switch_value(ndr, $varname);");
+       $self->pidl("level = ndr_print_get_switch_value($ndr, $varname);");
 
-       $self->pidl("ndr_print_union(ndr, name, level, \"$name\");");
+       $self->pidl("ndr_print_union($ndr, name, level, \"$name\");");
 
        $self->pidl("switch (level) {");
        $self->indent;
@@ -1791,7 +1720,7 @@ sub ParseUnionPrint($$$$)
                $self->pidl("$el->{CASE}:");
                if ($el->{TYPE} ne "EMPTY") {
                        $self->indent;
-                       $self->ParseElementPrint($el, "$varname->$el->{NAME}", {});
+                       $self->ParseElementPrint($el, $ndr, "$varname->$el->{NAME}", {});
                        $self->deindent;
                }
                $self->pidl("break;");
@@ -1799,7 +1728,7 @@ sub ParseUnionPrint($$$$)
        }
        if (! $have_default) {
                $self->pidl("default:");
-               $self->pidl("\tndr_print_bad_level(ndr, name, level);");
+               $self->pidl("\tndr_print_bad_level($ndr, name, level);");
        }
        $self->deindent;
        $self->pidl("}");
@@ -1807,15 +1736,15 @@ sub ParseUnionPrint($$$$)
        $self->end_flags($e);
 }
 
-sub ParseUnionPullPrimitives($$$$)
+sub ParseUnionPullPrimitives($$$$$)
 {
-       my ($self,$e,$varname,$switch_type) = @_;
+       my ($self,$e,$ndr,$varname,$switch_type) = @_;
        my $have_default = 0;
 
        if (defined($switch_type)) {
-               $self->pidl("NDR_CHECK(ndr_pull_$switch_type(ndr, NDR_SCALARS, &_level));");
+               $self->pidl("NDR_CHECK(ndr_pull_$switch_type($ndr, NDR_SCALARS, &_level));");
                $self->pidl("if (_level != level) {"); 
-               $self->pidl("\treturn ndr_pull_error(ndr, NDR_ERR_BAD_SWITCH, \"Bad switch value %u for $varname\", _level);");
+               $self->pidl("\treturn ndr_pull_error($ndr, NDR_ERR_BAD_SWITCH, \"Bad switch value %u for $varname\", _level);");
                $self->pidl("}");
        }
 
@@ -1832,12 +1761,12 @@ sub ParseUnionPullPrimitives($$$$)
                        $self->DeclarePtrVariables($el);
                        $self->DeclareArrayVariables($el);
                        if (defined($e->{PROPERTIES}{relative_base})) {
-                               $self->pidl("NDR_CHECK(ndr_pull_align(ndr, $el->{ALIGN}));");
+                               $self->pidl("NDR_CHECK(ndr_pull_align($ndr, $el->{ALIGN}));");
                                # set the current offset as base for relative pointers
                                # and store it based on the toplevel struct/union
-                               $self->pidl("NDR_CHECK(ndr_pull_setup_relative_base_offset1(ndr, $varname, ndr->offset));");
+                               $self->pidl("NDR_CHECK(ndr_pull_setup_relative_base_offset1($ndr, $varname, $ndr->offset));");
                        }
-                       $self->ParseElementPull($el, "ndr", {$el->{NAME} => "$varname->$el->{NAME}"}, 1, 0);
+                       $self->ParseElementPull($el, $ndr, {$el->{NAME} => "$varname->$el->{NAME}"}, 1, 0);
                        $self->deindent;
                }
                $self->pidl("break; }");
@@ -1845,21 +1774,21 @@ sub ParseUnionPullPrimitives($$$$)
        }
        if (! $have_default) {
                $self->pidl("default:");
-               $self->pidl("\treturn ndr_pull_error(ndr, NDR_ERR_BAD_SWITCH, \"Bad switch value \%u\", level);");
+               $self->pidl("\treturn ndr_pull_error($ndr, NDR_ERR_BAD_SWITCH, \"Bad switch value \%u\", level);");
        }
        $self->deindent;
        $self->pidl("}");
 }
 
-sub ParseUnionPullDeferred($$$)
+sub ParseUnionPullDeferred($$$$)
 {
-       my ($self,$e,$varname) = @_;
+       my ($self,$e,$ndr,$varname) = @_;
        my $have_default = 0;
 
        if (defined($e->{PROPERTIES}{relative_base})) {
                # retrieve the current offset as base for relative pointers
                # based on the toplevel struct/union
-               $self->pidl("NDR_CHECK(ndr_pull_setup_relative_base_offset2(ndr, $varname));");
+               $self->pidl("NDR_CHECK(ndr_pull_setup_relative_base_offset2($ndr, $varname));");
        }
        $self->pidl("switch (level) {");
        $self->indent;
@@ -1871,7 +1800,7 @@ sub ParseUnionPullDeferred($$$)
                $self->pidl("$el->{CASE}:");
                if ($el->{TYPE} ne "EMPTY") {
                        $self->indent;
-                       $self->ParseElementPull($el, "ndr", {$el->{NAME} => "$varname->$el->{NAME}"}, 0, 1);
+                       $self->ParseElementPull($el, $ndr, {$el->{NAME} => "$varname->$el->{NAME}"}, 0, 1);
                        $self->deindent;
                }
                $self->pidl("break;");
@@ -1879,7 +1808,7 @@ sub ParseUnionPullDeferred($$$)
        }
        if (! $have_default) {
                $self->pidl("default:");
-               $self->pidl("\treturn ndr_pull_error(ndr, NDR_ERR_BAD_SWITCH, \"Bad switch value \%u\", level);");
+               $self->pidl("\treturn ndr_pull_error($ndr, NDR_ERR_BAD_SWITCH, \"Bad switch value \%u\", level);");
        }
        $self->deindent;
        $self->pidl("}");
@@ -1889,9 +1818,9 @@ sub ParseUnionPullDeferred($$$)
 
 #####################################################################
 # parse a union - pull side
-sub ParseUnionPull($$$)
+sub ParseUnionPull($$$$)
 {
-       my ($self,$e,$varname) = @_;
+       my ($self,$e,$ndr,$varname) = @_;
        my $switch_type = $e->{SWITCH_TYPE};
 
        $self->pidl("int level;");
@@ -1912,17 +1841,17 @@ sub ParseUnionPull($$$)
 
        $self->start_flags($e);
 
-       $self->pidl("level = ndr_pull_get_switch_value(ndr, $varname);");
+       $self->pidl("level = ndr_pull_get_switch_value($ndr, $varname);");
 
        $self->pidl("if (ndr_flags & NDR_SCALARS) {");
        $self->indent;
-       $self->ParseUnionPullPrimitives($e,$varname,$switch_type);
+       $self->ParseUnionPullPrimitives($e,$ndr,$varname,$switch_type);
        $self->deindent;
        $self->pidl("}");
 
        $self->pidl("if (ndr_flags & NDR_BUFFERS) {");
        $self->indent;
-       $self->ParseUnionPullDeferred($e,$varname);
+       $self->ParseUnionPullDeferred($e,$ndr,$varname);
        $self->deindent;
        $self->pidl("}");
 
@@ -1954,29 +1883,29 @@ $typefamily{UNION} = {
        
 #####################################################################
 # parse a typedef - push side
-sub ParseTypedefPush($$$)
+sub ParseTypedefPush($$$$)
 {
-       my($self,$e,$varname) = @_;
+       my($self,$e,$ndr,$varname) = @_;
 
-       $typefamily{$e->{DATA}->{TYPE}}->{PUSH_FN_BODY}->($self, $e->{DATA}, $varname);
+       $typefamily{$e->{DATA}->{TYPE}}->{PUSH_FN_BODY}->($self, $e->{DATA}, $ndr, $varname);
 }
 
 #####################################################################
 # parse a typedef - pull side
-sub ParseTypedefPull($$$)
+sub ParseTypedefPull($$$$)
 {
-       my($self,$e,$varname) = @_;
+       my($self,$e,$ndr,$varname) = @_;
 
-       $typefamily{$e->{DATA}->{TYPE}}->{PULL_FN_BODY}->($self, $e->{DATA}, $varname);
+       $typefamily{$e->{DATA}->{TYPE}}->{PULL_FN_BODY}->($self, $e->{DATA}, $ndr, $varname);
 }
 
 #####################################################################
 # parse a typedef - print side
-sub ParseTypedefPrint($$$$)
+sub ParseTypedefPrint($$$$$)
 {
-       my($self,$e,$name,$varname) = @_;
+       my($self,$e,$ndr,$name,$varname) = @_;
 
-       $typefamily{$e->{DATA}->{TYPE}}->{PRINT_FN_BODY}->($self, $e->{DATA}, $name, $varname);
+       $typefamily{$e->{DATA}->{TYPE}}->{PRINT_FN_BODY}->($self, $e->{DATA}, $ndr, $name, $varname);
 }
 
 #####################################################################
@@ -2015,12 +1944,13 @@ $typefamily{TYPEDEF} = {
 sub ParseFunctionPrint($$)
 {
        my($self, $fn) = @_;
+       my $ndr = "ndr";
 
-       $self->pidl_hdr("void ndr_print_$fn->{NAME}(struct ndr_print *ndr, const char *name, int flags, const struct $fn->{NAME} *r);");
+       $self->pidl_hdr("void ndr_print_$fn->{NAME}(struct ndr_print *$ndr, const char *name, int flags, const struct $fn->{NAME} *r);");
 
        return if has_property($fn, "noprint");
 
-       $self->pidl("_PUBLIC_ void ndr_print_$fn->{NAME}(struct ndr_print *ndr, const char *name, int flags, const struct $fn->{NAME} *r)");
+       $self->pidl("_PUBLIC_ void ndr_print_$fn->{NAME}(struct ndr_print *$ndr, const char *name, int flags, const struct $fn->{NAME} *r)");
        $self->pidl("{");
        $self->indent;
 
@@ -2028,48 +1958,48 @@ sub ParseFunctionPrint($$)
                $self->DeclareArrayVariables($e);
        }
 
-       $self->pidl("ndr_print_struct(ndr, name, \"$fn->{NAME}\");");
-       $self->pidl("ndr->depth++;");
+       $self->pidl("ndr_print_struct($ndr, name, \"$fn->{NAME}\");");
+       $self->pidl("$ndr->depth++;");
 
        $self->pidl("if (flags & NDR_SET_VALUES) {");
-       $self->pidl("\tndr->flags |= LIBNDR_PRINT_SET_VALUES;");
+       $self->pidl("\t$ndr->flags |= LIBNDR_PRINT_SET_VALUES;");
        $self->pidl("}");
 
        $self->pidl("if (flags & NDR_IN) {");
        $self->indent;
-       $self->pidl("ndr_print_struct(ndr, \"in\", \"$fn->{NAME}\");");
-       $self->pidl("ndr->depth++;");
+       $self->pidl("ndr_print_struct($ndr, \"in\", \"$fn->{NAME}\");");
+       $self->pidl("$ndr->depth++;");
 
        my $env = GenerateFunctionInEnv($fn);
 
        foreach my $e (@{$fn->{ELEMENTS}}) {
                if (grep(/in/,@{$e->{DIRECTION}})) {
-                       $self->ParseElementPrint($e, $env->{$e->{NAME}}, $env);
+                       $self->ParseElementPrint($e, $ndr, $env->{$e->{NAME}}, $env);
                }
        }
-       $self->pidl("ndr->depth--;");
+       $self->pidl("$ndr->depth--;");
        $self->deindent;
        $self->pidl("}");
        
        $self->pidl("if (flags & NDR_OUT) {");
        $self->indent;
-       $self->pidl("ndr_print_struct(ndr, \"out\", \"$fn->{NAME}\");");
-       $self->pidl("ndr->depth++;");
+       $self->pidl("ndr_print_struct($ndr, \"out\", \"$fn->{NAME}\");");
+       $self->pidl("$ndr->depth++;");
 
        $env = GenerateFunctionOutEnv($fn);
        foreach my $e (@{$fn->{ELEMENTS}}) {
                if (grep(/out/,@{$e->{DIRECTION}})) {
-                       $self->ParseElementPrint($e, $env->{$e->{NAME}}, $env);
+                       $self->ParseElementPrint($e, $ndr, $env->{$e->{NAME}}, $env);
                }
        }
        if ($fn->{RETURN_TYPE}) {
-               $self->pidl("ndr_print_$fn->{RETURN_TYPE}(ndr, \"result\", r->out.result);");
+               $self->pidl("ndr_print_$fn->{RETURN_TYPE}($ndr, \"result\", r->out.result);");
        }
-       $self->pidl("ndr->depth--;");
+       $self->pidl("$ndr->depth--;");
        $self->deindent;
        $self->pidl("}");
        
-       $self->pidl("ndr->depth--;");
+       $self->pidl("$ndr->depth--;");
        $self->deindent;
        $self->pidl("}");
        $self->pidl("");
@@ -2080,8 +2010,9 @@ sub ParseFunctionPrint($$)
 sub ParseFunctionPush($$)
 { 
        my($self, $fn) = @_;
+       my $ndr = "ndr";
 
-       $self->fn_declare("push", $fn, "enum ndr_err_code ndr_push_$fn->{NAME}(struct ndr_push *ndr, int flags, const struct $fn->{NAME} *r)") or return;
+       $self->fn_declare("push", $fn, "enum ndr_err_code ndr_push_$fn->{NAME}(struct ndr_push *$ndr, int flags, const struct $fn->{NAME} *r)") or return;
 
        return if has_property($fn, "nopush");
 
@@ -2101,7 +2032,7 @@ sub ParseFunctionPush($$)
 
        foreach my $e (@{$fn->{ELEMENTS}}) {
                if (grep(/in/,@{$e->{DIRECTION}})) {
-                       $self->ParseElementPush($e, "ndr", $env, 1, 1);
+                       $self->ParseElementPush($e, $ndr, $env, 1, 1);
                }
        }
 
@@ -2114,12 +2045,12 @@ sub ParseFunctionPush($$)
        $env = GenerateFunctionOutEnv($fn);
        foreach my $e (@{$fn->{ELEMENTS}}) {
                if (grep(/out/,@{$e->{DIRECTION}})) {
-                       $self->ParseElementPush($e, "ndr", $env, 1, 1);
+                       $self->ParseElementPush($e, $ndr, $env, 1, 1);
                }
        }
 
        if ($fn->{RETURN_TYPE}) {
-               $self->pidl("NDR_CHECK(ndr_push_$fn->{RETURN_TYPE}(ndr, NDR_SCALARS, r->out.result));");
+               $self->pidl("NDR_CHECK(ndr_push_$fn->{RETURN_TYPE}($ndr, NDR_SCALARS, r->out.result));");
        }
     
        $self->deindent;
@@ -2132,16 +2063,14 @@ sub ParseFunctionPush($$)
 
 sub AllocateArrayLevel($$$$$$)
 {
-       my ($self,$e,$l,$ndr,$env,$size) = @_;
-
-       my $var = ParseExpr($e->{NAME}, $env, $e->{ORIGINAL});
+       my ($self,$e,$l,$ndr,$var,$size) = @_;
 
        my $pl = GetPrevLevel($e, $l);
        if (defined($pl) and 
            $pl->{TYPE} eq "POINTER" and 
            $pl->{POINTER_TYPE} eq "ref"
            and not $l->{IS_ZERO_TERMINATED}) {
-               $self->pidl("if (ndr->flags & LIBNDR_FLAG_REF_ALLOC) {");
+               $self->pidl("if ($ndr->flags & LIBNDR_FLAG_REF_ALLOC) {");
                $self->pidl("\tNDR_PULL_ALLOC_N($ndr, $var, $size);");
                $self->pidl("}");
                if (grep(/in/,@{$e->{DIRECTION}}) and
@@ -2159,9 +2088,10 @@ sub AllocateArrayLevel($$$$$$)
 sub ParseFunctionPull($$)
 { 
        my($self,$fn) = @_;
+       my $ndr = "ndr";
 
        # pull function args
-       $self->fn_declare("pull", $fn, "enum ndr_err_code ndr_pull_$fn->{NAME}(struct ndr_pull *ndr, int flags, struct $fn->{NAME} *r)") or return;
+       $self->fn_declare("pull", $fn, "enum ndr_err_code ndr_pull_$fn->{NAME}(struct ndr_pull *$ndr, int flags, struct $fn->{NAME} *r)") or return;
 
        $self->pidl("{");
        $self->indent;
@@ -2198,7 +2128,7 @@ sub ParseFunctionPull($$)
 
        foreach my $e (@{$fn->{ELEMENTS}}) {
                next unless (grep(/in/, @{$e->{DIRECTION}}));
-               $self->ParseElementPull($e, "ndr", $env, 1, 1);
+               $self->ParseElementPull($e, $ndr, $env, 1, 1);
        }
 
        # allocate the "simple" out ref variables. FIXME: Shouldn't this have it's
@@ -2216,17 +2146,17 @@ sub ParseFunctionPull($$)
                if ($e->{LEVELS}[1]->{TYPE} eq "ARRAY") {
                        my $size = ParseExprExt($e->{LEVELS}[1]->{SIZE_IS}, $env, $e->{ORIGINAL},
                                check_null_pointer($e, $env, sub { $self->pidl(shift); },
-                                                  "return ndr_pull_error(ndr, NDR_ERR_INVALID_POINTER, \"NULL Pointer for size_is()\");"),
+                                                  "return ndr_pull_error($ndr, NDR_ERR_INVALID_POINTER, \"NULL Pointer for size_is()\");"),
                                check_fully_dereferenced($e, $env));
-                       $self->pidl("NDR_PULL_ALLOC_N(ndr, r->out.$e->{NAME}, $size);");
+                       $self->pidl("NDR_PULL_ALLOC_N($ndr, r->out.$e->{NAME}, $size);");
 
                        if (grep(/in/, @{$e->{DIRECTION}})) {
-                               $self->pidl("memcpy(r->out.$e->{NAME}, r->in.$e->{NAME}, $size * sizeof(*r->in.$e->{NAME}));");
+                               $self->pidl("memcpy(r->out.$e->{NAME}, r->in.$e->{NAME}, ($size) * sizeof(*r->in.$e->{NAME}));");
                        } else {
-                               $self->pidl("memset(r->out.$e->{NAME}, 0, $size * sizeof(*r->out.$e->{NAME}));");
+                               $self->pidl("memset(r->out.$e->{NAME}, 0, ($size) * sizeof(*r->out.$e->{NAME}));");
                        }
                } else {
-                       $self->pidl("NDR_PULL_ALLOC(ndr, r->out.$e->{NAME});");
+                       $self->pidl("NDR_PULL_ALLOC($ndr, r->out.$e->{NAME});");
                
                        if (grep(/in/, @{$e->{DIRECTION}})) {
                                $self->pidl("*r->out.$e->{NAME} = *r->in.$e->{NAME};");
@@ -2246,11 +2176,11 @@ sub ParseFunctionPull($$)
        $env = GenerateFunctionOutEnv($fn);
        foreach my $e (@{$fn->{ELEMENTS}}) {
                next unless grep(/out/, @{$e->{DIRECTION}});
-               $self->ParseElementPull($e, "ndr", $env, 1, 1);
+               $self->ParseElementPull($e, $ndr, $env, 1, 1);
        }
 
        if ($fn->{RETURN_TYPE}) {
-               $self->pidl("NDR_CHECK(ndr_pull_$fn->{RETURN_TYPE}(ndr, NDR_SCALARS, &r->out.result));");
+               $self->pidl("NDR_CHECK(ndr_pull_$fn->{RETURN_TYPE}($ndr, NDR_SCALARS, &r->out.result));");
        }
 
        $self->add_deferred();
@@ -2263,6 +2193,26 @@ sub ParseFunctionPull($$)
        $self->pidl("");
 }
 
+sub AuthServiceStruct($$$)
+{
+       my ($self, $ifacename, $authservice) = @_;
+       my @a = split /,/, $authservice;
+       my $authservice_count = $#a + 1;
+
+       $self->pidl("static const char * const $ifacename\_authservice_strings[] = {");
+       foreach my $ap (@a) {
+               $self->pidl("\t$ap, ");
+       }
+       $self->pidl("};");
+       $self->pidl("");
+
+       $self->pidl("static const struct ndr_interface_string_array $ifacename\_authservices = {");
+       $self->pidl("\t.count\t= $authservice_count,");
+       $self->pidl("\t.names\t= $ifacename\_authservice_strings");
+       $self->pidl("};");
+       $self->pidl("");
+}
+
 #####################################################################
 # produce a function call table
 sub FunctionTable($$)
@@ -2310,21 +2260,8 @@ sub FunctionTable($$)
                $interface->{PROPERTIES}->{authservice} = "\"host\"";
        }
 
-       my @a = split / /, $interface->{PROPERTIES}->{authservice};
-       my $authservice_count = $#a + 1;
-
-       $self->pidl("static const char * const $interface->{NAME}\_authservice_strings[] = {");
-       foreach my $ap (@a) {
-               $self->pidl("\t$ap, ");
-       }
-       $self->pidl("};");
-       $self->pidl("");
-
-       $self->pidl("static const struct ndr_interface_string_array $interface->{NAME}\_authservices = {");
-       $self->pidl("\t.count\t= $endpoint_count,");
-       $self->pidl("\t.names\t= $interface->{NAME}\_authservice_strings");
-       $self->pidl("};");
-       $self->pidl("");
+       $self->AuthServiceStruct($interface->{NAME}, 
+                                    $interface->{PROPERTIES}->{authservice});
 
        $self->pidl("\nconst struct ndr_interface_table ndr_table_$interface->{NAME} = {");
        $self->pidl("\t.name\t\t= \"$interface->{NAME}\",");
@@ -2385,7 +2322,7 @@ sub HeaderInterface($$$)
        }
 
        if (defined $interface->{PROPERTIES}->{helper}) {
-               $self->HeaderInclude(split / /, $interface->{PROPERTIES}->{helper});
+               $self->HeaderInclude(split /,/, $interface->{PROPERTIES}->{helper});
        }
 
        if (defined $interface->{PROPERTIES}->{uuid}) {
@@ -2430,81 +2367,86 @@ sub HeaderInterface($$$)
 
 }
 
-sub ParseTypePush($$$$$)
+sub ParseTypePush($$$$$$)
 {
-       my ($self,$e,$varname, $primitives, $deferred) = @_;
+       my ($self,$e, $ndr, $varname, $primitives, $deferred) = @_;
 
        # save the old relative_base_offset
-       $self->pidl("uint32_t _save_relative_base_offset = ndr_push_get_relative_base_offset(ndr);") if defined(has_property($e, "relative_base"));
-       $typefamily{$e->{TYPE}}->{PUSH_FN_BODY}->($self, $e, $varname);
+       $self->pidl("uint32_t _save_relative_base_offset = ndr_push_get_relative_base_offset($ndr);") if defined(has_property($e, "relative_base"));
+       $typefamily{$e->{TYPE}}->{PUSH_FN_BODY}->($self, $e, $ndr, $varname);
        # restore the old relative_base_offset
-       $self->pidl("ndr_push_restore_relative_base_offset(ndr, _save_relative_base_offset);") if defined(has_property($e, "relative_base"));
+       $self->pidl("ndr_push_restore_relative_base_offset($ndr, _save_relative_base_offset);") if defined(has_property($e, "relative_base"));
 }
 
 sub ParseTypePushFunction($$$)
 {
        my ($self, $e, $varname) = @_;
+       my $ndr = "ndr";
 
        my $args = $typefamily{$e->{TYPE}}->{DECL}->($e, "push", $e->{NAME}, $varname);
-       $self->fn_declare("push", $e, "enum ndr_err_code ".TypeFunctionName("ndr_push", $e)."(struct ndr_push *ndr, int ndr_flags, $args)") or return;
+
+       $self->fn_declare("push", $e, "enum ndr_err_code ".TypeFunctionName("ndr_push", $e)."(struct ndr_push *$ndr, int ndr_flags, $args)") or return;
 
        $self->pidl("{");
        $self->indent;
-       $self->ParseTypePush($e, $varname, 1, 1);
+       $self->ParseTypePush($e, $ndr, $varname, 1, 1);
        $self->pidl("return NDR_ERR_SUCCESS;");
        $self->deindent;
        $self->pidl("}");
        $self->pidl("");;
 }
 
-sub ParseTypePull($$$$$)
+sub ParseTypePull($$$$$$)
 {
-       my ($self, $e, $varname, $primitives, $deferred) = @_;
+       my ($self, $e, $ndr, $varname, $primitives, $deferred) = @_;
 
        # save the old relative_base_offset
-       $self->pidl("uint32_t _save_relative_base_offset = ndr_pull_get_relative_base_offset(ndr);") if defined(has_property($e, "relative_base"));
-       $typefamily{$e->{TYPE}}->{PULL_FN_BODY}->($self, $e, $varname);
+       $self->pidl("uint32_t _save_relative_base_offset = ndr_pull_get_relative_base_offset($ndr);") if defined(has_property($e, "relative_base"));
+       $typefamily{$e->{TYPE}}->{PULL_FN_BODY}->($self, $e, $ndr, $varname);
        # restore the old relative_base_offset
-       $self->pidl("ndr_pull_restore_relative_base_offset(ndr, _save_relative_base_offset);") if defined(has_property($e, "relative_base"));
+       $self->pidl("ndr_pull_restore_relative_base_offset($ndr, _save_relative_base_offset);") if defined(has_property($e, "relative_base"));
 }
 
 sub ParseTypePullFunction($$)
 {
        my ($self, $e, $varname) = @_;
+       my $ndr = "ndr";
 
        my $args = $typefamily{$e->{TYPE}}->{DECL}->($e, "pull", $e->{NAME}, $varname);
 
-       $self->fn_declare("pull", $e, "enum ndr_err_code ".TypeFunctionName("ndr_pull", $e)."(struct ndr_pull *ndr, int ndr_flags, $args)") or return;
+       $self->fn_declare("pull", $e, "enum ndr_err_code ".TypeFunctionName("ndr_pull", $e)."(struct ndr_pull *$ndr, int ndr_flags, $args)") or return;
 
        $self->pidl("{");
        $self->indent;
-       $self->ParseTypePull($e, $varname, 1, 1);
+       $self->ParseTypePull($e, $ndr, $varname, 1, 1);
        $self->pidl("return NDR_ERR_SUCCESS;");
        $self->deindent;
        $self->pidl("}");
        $self->pidl("");
 }
 
-sub ParseTypePrint($$$)
+sub ParseTypePrint($$$$)
 {
-       my ($self, $e, $varname) = @_;
+       my ($self, $e, $ndr, $varname) = @_;
 
-       $typefamily{$e->{TYPE}}->{PRINT_FN_BODY}->($self, $e, $e->{NAME}, $varname);
+       $typefamily{$e->{TYPE}}->{PRINT_FN_BODY}->($self, $e, $ndr, $e->{NAME}, $varname);
 }
 
 sub ParseTypePrintFunction($$$)
 {
        my ($self, $e, $varname) = @_;
+       my $ndr = "ndr";
+
        my $args = $typefamily{$e->{TYPE}}->{DECL}->($e, "print", $e->{NAME}, $varname);
 
        $self->pidl_hdr("void ".TypeFunctionName("ndr_print", $e)."(struct ndr_print *ndr, const char *name, $args);");
 
        return if (has_property($e, "noprint"));
 
-       $self->pidl("_PUBLIC_ void ".TypeFunctionName("ndr_print", $e)."(struct ndr_print *ndr, const char *name, $args)");
+       $self->pidl("_PUBLIC_ void ".TypeFunctionName("ndr_print", $e)."(struct ndr_print *$ndr, const char *name, $args)");
        $self->pidl("{");
        $self->indent;
-       $self->ParseTypePrint($e, $varname);
+       $self->ParseTypePrint($e, $ndr, $varname);
        $self->deindent;
        $self->pidl("}");
        $self->pidl("");