r23727: Explicitly pass down FLAGS2 to srvstr_get_path.
[tprouty/samba.git] / source / smbd / password.c
index b2dbde151d0ff1bc2d6f0627bb9cd54d1eb768ba..00f687dc2743352d273b2aac429f5190aee0a652 100644 (file)
 /* users from session setup */
 static char *session_userlist = NULL;
 static int len_session_userlist = 0;
+/* workgroup from session setup. */
+static char *session_workgroup = NULL;
 
 /* this holds info on user ids that are already validated for this VC */
 static user_struct *validated_users;
 static int next_vuid = VUID_OFFSET;
 static int num_validated_vuids;
 
-extern userdom_struct current_user_info;
-
-
 /****************************************************************************
  Check if a uid has been validated, and return an pointer to the user_struct
  if it has. NULL if not. vuid is biased by an offset. This allows us to
@@ -47,7 +46,31 @@ user_struct *get_valid_user_struct(uint16 vuid)
                return NULL;
 
        for (usp=validated_users;usp;usp=usp->next,count++) {
-               if (vuid == usp->vuid) {
+               if (vuid == usp->vuid && usp->server_info) {
+                       if (count > 10) {
+                               DLIST_PROMOTE(validated_users, usp);
+                       }
+                       return usp;
+               }
+       }
+
+       return NULL;
+}
+
+/****************************************************************************
+ Get the user struct of a partial NTLMSSP login
+****************************************************************************/
+
+user_struct *get_partial_auth_user_struct(uint16 vuid)
+{
+       user_struct *usp;
+       int count=0;
+
+       if (vuid == UID_FIELD_INVALID)
+               return NULL;
+
+       for (usp=validated_users;usp;usp=usp->next,count++) {
+               if (vuid == usp->vuid && !usp->server_info) {
                        if (count > 10) {
                                DLIST_PROMOTE(validated_users, usp);
                        }
@@ -69,14 +92,7 @@ void invalidate_vuid(uint16 vuid)
        if (vuser == NULL)
                return;
        
-       SAFE_FREE(vuser->homedir);
-       SAFE_FREE(vuser->unix_homedir);
-       SAFE_FREE(vuser->logon_script);
-       
        session_yield(vuser);
-       SAFE_FREE(vuser->session_keystr);
-
-       free_server_info(&vuser->server_info);
 
        data_blob_free(&vuser->session_key);
 
@@ -86,9 +102,7 @@ void invalidate_vuid(uint16 vuid)
           from the vuid 'owner' of connections */
        conn_clear_vuid_cache(vuid);
 
-       SAFE_FREE(vuser->groups);
-       delete_nt_token(&vuser->nt_user_token);
-       SAFE_FREE(vuser);
+       TALLOC_FREE(vuser);
        num_validated_vuids--;
 }
 
@@ -112,9 +126,11 @@ void invalidate_all_vuids(void)
  *  @param server_info The token returned from the authentication process. 
  *   (now 'owned' by register_vuid)
  *
- *  @param session_key The User session key for the login session (now also 'owned' by register_vuid)
+ *  @param session_key The User session key for the login session (now also
+ *  'owned' by register_vuid)
  *
- *  @param respose_blob The NT challenge-response, if available.  (May be freed after this call)
+ *  @param respose_blob The NT challenge-response, if available.  (May be
+ *  freed after this call)
  *
  *  @param smb_name The untranslated name of the user
  *
@@ -123,14 +139,15 @@ void invalidate_all_vuids(void)
  *
  */
 
-int register_vuid(auth_serversupplied_info *server_info, DATA_BLOB session_key, DATA_BLOB response_blob, const char *smb_name)
+int register_vuid(auth_serversupplied_info *server_info,
+                 DATA_BLOB session_key, DATA_BLOB response_blob,
+                 const char *smb_name)
 {
-       user_struct *vuser = NULL;
+       user_struct *vuser;
 
-       /* Ensure no vuid gets registered in share level security. */
+       /* Paranoia check. */
        if(lp_security() == SEC_SHARE) {
-               data_blob_free(&session_key);
-               return UID_FIELD_INVALID;
+               smb_panic("Tried to register uid in security=share");
        }
 
        /* Limit allowed vuids to 16bits - VUID_OFFSET. */
@@ -139,14 +156,12 @@ int register_vuid(auth_serversupplied_info *server_info, DATA_BLOB session_key,
                return UID_FIELD_INVALID;
        }
 
-       if((vuser = (user_struct *)malloc( sizeof(user_struct) )) == NULL) {
-               DEBUG(0,("Failed to malloc users struct!\n"));
+       if((vuser = TALLOC_ZERO_P(NULL, user_struct)) == NULL) {
+               DEBUG(0,("Failed to talloc users struct!\n"));
                data_blob_free(&session_key);
                return UID_FIELD_INVALID;
        }
 
-       ZERO_STRUCTP(vuser);
-
        /* Allocate a free vuid. Yes this is a linear search... :-) */
        while( get_valid_user_struct(next_vuid) != NULL ) {
                next_vuid++;
@@ -155,10 +170,32 @@ int register_vuid(auth_serversupplied_info *server_info, DATA_BLOB session_key,
                        next_vuid = VUID_OFFSET;
        }
 
-       DEBUG(10,("register_vuid: allocated vuid = %u\n", (unsigned int)next_vuid ));
+       DEBUG(10,("register_vuid: allocated vuid = %u\n",
+                 (unsigned int)next_vuid ));
 
        vuser->vuid = next_vuid;
 
+       if (!server_info) {
+               /*
+                * This happens in an unfinished NTLMSSP session setup. We
+                * need to allocate a vuid between the first and second calls
+                * to NTLMSSP.
+                */
+               next_vuid++;
+               num_validated_vuids++;
+               
+               vuser->server_info = NULL;
+               
+               DLIST_ADD(validated_users, vuser);
+               
+               return vuser->vuid;
+       }
+
+       /* use this to keep tabs on all our info from the authentication */
+       vuser->server_info = server_info;
+       /* Ensure that the server_info will dissapear with the vuser it is now attached to */
+       talloc_steal(vuser, vuser->server_info);
+
        /* the next functions should be done by a SID mapping system (SMS) as
         * the new real sam db won't have reference to unix uids or gids
         */
@@ -168,11 +205,13 @@ int register_vuid(auth_serversupplied_info *server_info, DATA_BLOB session_key,
        
        vuser->n_groups = server_info->n_groups;
        if (vuser->n_groups) {
-               if (!(vuser->groups = memdup(server_info->groups, sizeof(gid_t) * vuser->n_groups))) {
-                       DEBUG(0,("register_vuid: failed to memdup vuser->groups\n"));
+               if (!(vuser->groups = (gid_t *)talloc_memdup(vuser, server_info->groups,
+                                                            sizeof(gid_t) *
+                                                            vuser->n_groups))) {
+                       DEBUG(0,("register_vuid: failed to talloc_memdup "
+                                "vuser->groups\n"));
                        data_blob_free(&session_key);
-                       free(vuser);
-                       free_server_info(&server_info);
+                       TALLOC_FREE(vuser);
                        return UID_FIELD_INVALID;
                }
        }
@@ -181,34 +220,45 @@ int register_vuid(auth_serversupplied_info *server_info, DATA_BLOB session_key,
        fstrcpy(vuser->user.unix_name, server_info->unix_name); 
 
        /* This is a potentially untrusted username */
-       alpha_strcpy(vuser->user.smb_name, smb_name, ". _-$", sizeof(vuser->user.smb_name));
+       alpha_strcpy(vuser->user.smb_name, smb_name, ". _-$",
+                    sizeof(vuser->user.smb_name));
 
        fstrcpy(vuser->user.domain, pdb_get_domain(server_info->sam_account));
-       fstrcpy(vuser->user.full_name, pdb_get_fullname(server_info->sam_account));
+       fstrcpy(vuser->user.full_name,
+               pdb_get_fullname(server_info->sam_account));
 
        {
                /* Keep the homedir handy */
-               const char *homedir = pdb_get_homedir(server_info->sam_account);
-               const char *logon_script = pdb_get_logon_script(server_info->sam_account);
-
-               if (!IS_SAM_DEFAULT(server_info->sam_account, PDB_UNIXHOMEDIR)) {
-                       const char *unix_homedir = pdb_get_unix_homedir(server_info->sam_account);
+               const char *homedir =
+                       pdb_get_homedir(server_info->sam_account);
+               const char *logon_script =
+                       pdb_get_logon_script(server_info->sam_account);
+
+               if (!IS_SAM_DEFAULT(server_info->sam_account,
+                                   PDB_UNIXHOMEDIR)) {
+                       const char *unix_homedir =
+                               pdb_get_unix_homedir(server_info->sam_account);
                        if (unix_homedir) {
-                               vuser->unix_homedir = smb_xstrdup(unix_homedir);
+                               vuser->unix_homedir = unix_homedir;
                        }
                } else {
-                       struct passwd *passwd = getpwnam_alloc(vuser->user.unix_name);
+                       struct passwd *passwd =
+                               getpwnam_alloc(vuser, vuser->user.unix_name);
                        if (passwd) {
-                               vuser->unix_homedir = smb_xstrdup(passwd->pw_dir);
-                               passwd_free(&passwd);
+                               vuser->unix_homedir = passwd->pw_dir;
+                               /* Ensure that the unix_homedir now
+                                * belongs to vuser, so it goes away
+                                * with it, not with passwd below: */
+                               talloc_steal(vuser, vuser->unix_homedir);
+                               TALLOC_FREE(passwd);
                        }
                }
                
                if (homedir) {
-                       vuser->homedir = smb_xstrdup(homedir);
+                       vuser->homedir = homedir;
                }
                if (logon_script) {
-                       vuser->logon_script = smb_xstrdup(logon_script);
+                       vuser->logon_script = logon_script;
                }
        }
 
@@ -217,28 +267,24 @@ int register_vuid(auth_serversupplied_info *server_info, DATA_BLOB session_key,
        DEBUG(10,("register_vuid: (%u,%u) %s %s %s guest=%d\n", 
                  (unsigned int)vuser->uid, 
                  (unsigned int)vuser->gid,
-                 vuser->user.unix_name, vuser->user.smb_name, vuser->user.domain, vuser->guest ));
+                 vuser->user.unix_name, vuser->user.smb_name,
+                 vuser->user.domain, vuser->guest ));
 
-       DEBUG(3, ("User name: %s\tReal name: %s\n",vuser->user.unix_name,vuser->user.full_name));       
+       DEBUG(3, ("User name: %s\tReal name: %s\n", vuser->user.unix_name,
+                 vuser->user.full_name));      
 
        if (server_info->ptok) {
-               vuser->nt_user_token = dup_nt_token(server_info->ptok);
+               vuser->nt_user_token = dup_nt_token(vuser, server_info->ptok);
        } else {
-               DEBUG(1, ("server_info does not contain a user_token - cannot continue\n"));
-               free_server_info(&server_info);
+               DEBUG(1, ("server_info does not contain a user_token - "
+                         "cannot continue\n"));
+               TALLOC_FREE(vuser);
                data_blob_free(&session_key);
-               SAFE_FREE(vuser->homedir);
-               SAFE_FREE(vuser->unix_homedir);
-               SAFE_FREE(vuser->logon_script);
-
-               SAFE_FREE(vuser);
                return UID_FIELD_INVALID;
        }
 
-       /* use this to keep tabs on all our info from the authentication */
-       vuser->server_info = server_info;
-
-       DEBUG(3,("UNIX uid %d is UNIX user %s, and will be vuid %u\n",(int)vuser->uid,vuser->user.unix_name, vuser->vuid));
+       DEBUG(3,("UNIX uid %d is UNIX user %s, and will be vuid %u\n",
+                (int)vuser->uid,vuser->user.unix_name, vuser->vuid));
 
        next_vuid++;
        num_validated_vuids++;
@@ -246,32 +292,47 @@ int register_vuid(auth_serversupplied_info *server_info, DATA_BLOB session_key,
        DLIST_ADD(validated_users, vuser);
 
        if (!session_claim(vuser)) {
-               DEBUG(1,("Failed to claim session for vuid=%d\n", vuser->vuid));
+               DEBUG(1, ("Failed to claim session for vuid=%d\n",
+                         vuser->vuid));
                invalidate_vuid(vuser->vuid);
-               return -1;
+               return UID_FIELD_INVALID;
        }
 
        /* Register a home dir service for this user iff
+       
           (a) This is not a guest connection,
-          (b) we have a home directory defined, and
-          (c) there s not an existing static share by that name */
+          (b) we have a home directory defined 
+          (c) there s not an existing static share by that name
+          
+          If a share exists by this name (autoloaded or not) reuse it . */
+
+       vuser->homes_snum = -1;
 
-       if ( (!vuser->guest) 
-               && vuser->unix_homedir 
-               && *(vuser->unix_homedir) 
-               && (lp_servicenumber(vuser->user.unix_name) == -1) ) 
+       if ( (!vuser->guest) && vuser->unix_homedir && *(vuser->unix_homedir)) 
        {
-                       DEBUG(3, ("Adding/updating homes service for user '%s' using home directory: '%s'\n", 
-                               vuser->user.unix_name, vuser->unix_homedir));
+               int servicenumber = lp_servicenumber(vuser->user.unix_name);
 
-                       vuser->homes_snum = add_home_service(vuser->user.unix_name, 
-                               vuser->user.unix_name, vuser->unix_homedir);
-       } else {
-               vuser->homes_snum = -1;
-       }
+               if ( servicenumber == -1 ) {
+                       DEBUG(3, ("Adding homes service for user '%s' using "
+                                 "home directory: '%s'\n", 
+                               vuser->user.unix_name, vuser->unix_homedir));
+                       vuser->homes_snum =
+                               add_home_service(vuser->user.unix_name, 
+                                                vuser->user.unix_name,
+                                                vuser->unix_homedir);
+               } else {
+                       DEBUG(3, ("Using static (or previously created) "
+                                 "service for user '%s'; path = '%s'\n", 
+                                 vuser->user.unix_name,
+                                 lp_pathname(servicenumber) ));
+                       vuser->homes_snum = servicenumber;
+               }
+       } 
        
-       if (srv_is_signing_negotiated() && !vuser->guest && !srv_signing_started()) {
-               /* Try and turn on server signing on the first non-guest sessionsetup. */
+       if (srv_is_signing_negotiated() && !vuser->guest &&
+           !srv_signing_started()) {
+               /* Try and turn on server signing on the first non-guest
+                * sessionsetup. */
                srv_set_signing(vuser->session_key, response_blob);
        }
        
@@ -302,14 +363,19 @@ void add_session_user(const char *user)
        if( session_userlist && in_list(suser,session_userlist,False) )
                return;
 
-       if( !session_userlist || (strlen(suser) + strlen(session_userlist) + 2 >= len_session_userlist) ) {
+       if( !session_userlist ||
+           (strlen(suser) + strlen(session_userlist) + 2 >=
+            len_session_userlist) ) {
                char *newlist;
 
                if (len_session_userlist > 128 * PSTRING_LEN) {
-                       DEBUG(3,("add_session_user: session userlist already too large.\n"));
+                       DEBUG(3,("add_session_user: session userlist already "
+                                "too large.\n"));
                        return;
                }
-               newlist = Realloc( session_userlist, len_session_userlist + PSTRING_LEN );
+               newlist = (char *)SMB_REALLOC_KEEP_OLD_ON_ERROR(
+                       session_userlist,
+                       len_session_userlist + PSTRING_LEN );
                if( newlist == NULL ) {
                        DEBUG(1,("Unable to resize session_userlist\n"));
                        return;
@@ -325,11 +391,162 @@ void add_session_user(const char *user)
        safe_strcat(session_userlist,suser,len_session_userlist-1);
 }
 
+/****************************************************************************
+ In security=share mode we need to store the client workgroup, as that's
+  what Vista uses for the NTLMv2 calculation.
+****************************************************************************/
+
+void add_session_workgroup(const char *workgroup)
+{
+       if (session_workgroup) {
+               SAFE_FREE(session_workgroup);
+       }
+       session_workgroup = smb_xstrdup(workgroup);
+}
+
+/****************************************************************************
+ In security=share mode we need to return the client workgroup, as that's
+  what Vista uses for the NTLMv2 calculation.
+****************************************************************************/
+
+const char *get_session_workgroup(void)
+{
+       return session_workgroup;
+}
+
+/****************************************************************************
+ Check if a user is in a netgroup user list. If at first we don't succeed,
+ try lower case.
+****************************************************************************/
+
+BOOL user_in_netgroup(const char *user, const char *ngname)
+{
+#ifdef HAVE_NETGROUP
+       static char *mydomain = NULL;
+       fstring lowercase_user;
+
+       if (mydomain == NULL)
+               yp_get_default_domain(&mydomain);
+
+       if(mydomain == NULL) {
+               DEBUG(5,("Unable to get default yp domain, let's try without specifying it\n"));
+       }
+
+       DEBUG(5,("looking for user %s of domain %s in netgroup %s\n",
+               user, mydomain?mydomain:"(ANY)", ngname));
+
+       if (innetgr(ngname, NULL, user, mydomain)) {
+               DEBUG(5,("user_in_netgroup: Found\n"));
+               return (True);
+       } else {
+
+               /*
+                * Ok, innetgr is case sensitive. Try once more with lowercase
+                * just in case. Attempt to fix #703. JRA.
+                */
+
+               fstrcpy(lowercase_user, user);
+               strlower_m(lowercase_user);
+       
+               DEBUG(5,("looking for user %s of domain %s in netgroup %s\n",
+                       lowercase_user, mydomain?mydomain:"(ANY)", ngname));
+
+               if (innetgr(ngname, NULL, lowercase_user, mydomain)) {
+                       DEBUG(5,("user_in_netgroup: Found\n"));
+                       return (True);
+               }
+       }
+#endif /* HAVE_NETGROUP */
+       return False;
+}
+
+/****************************************************************************
+ Check if a user is in a user list - can check combinations of UNIX
+ and netgroup lists.
+****************************************************************************/
+
+BOOL user_in_list(const char *user,const char **list)
+{
+       if (!list || !*list)
+               return False;
+
+       DEBUG(10,("user_in_list: checking user %s in list\n", user));
+
+       while (*list) {
+
+               DEBUG(10,("user_in_list: checking user |%s| against |%s|\n",
+                         user, *list));
+
+               /*
+                * Check raw username.
+                */
+               if (strequal(user, *list))
+                       return(True);
+
+               /*
+                * Now check to see if any combination
+                * of UNIX and netgroups has been specified.
+                */
+
+               if(**list == '@') {
+                       /*
+                        * Old behaviour. Check netgroup list
+                        * followed by UNIX list.
+                        */
+                       if(user_in_netgroup(user, *list +1))
+                               return True;
+                       if(user_in_group(user, *list +1))
+                               return True;
+               } else if (**list == '+') {
+
+                       if((*(*list +1)) == '&') {
+                               /*
+                                * Search UNIX list followed by netgroup.
+                                */
+                               if(user_in_group(user, *list +2))
+                                       return True;
+                               if(user_in_netgroup(user, *list +2))
+                                       return True;
+
+                       } else {
+
+                               /*
+                                * Just search UNIX list.
+                                */
+
+                               if(user_in_group(user, *list +1))
+                                       return True;
+                       }
+
+               } else if (**list == '&') {
+
+                       if(*(*list +1) == '+') {
+                               /*
+                                * Search netgroup list followed by UNIX list.
+                                */
+                               if(user_in_netgroup(user, *list +2))
+                                       return True;
+                               if(user_in_group(user, *list +2))
+                                       return True;
+                       } else {
+                               /*
+                                * Just search netgroup list.
+                                */
+                               if(user_in_netgroup(user, *list +1))
+                                       return True;
+                       }
+               }
+    
+               list++;
+       }
+       return(False);
+}
+
 /****************************************************************************
  Check if a username is valid.
 ****************************************************************************/
 
-BOOL user_ok(const char *user,int snum, gid_t *groups, size_t n_groups)
+static BOOL user_ok(const char *user, int snum)
 {
        char **valid, **invalid;
        BOOL ret;
@@ -339,9 +556,15 @@ BOOL user_ok(const char *user,int snum, gid_t *groups, size_t n_groups)
 
        if (lp_invalid_users(snum)) {
                str_list_copy(&invalid, lp_invalid_users(snum));
-               if (invalid && str_list_substitute(invalid, "%S", lp_servicename(snum))) {
-                       if ( invalid && str_list_sub_basic(invalid, current_user_info.smb_name) ) {
-                               ret = !user_in_list(user, (const char **)invalid, groups, n_groups);
+               if (invalid &&
+                   str_list_substitute(invalid, "%S", lp_servicename(snum))) {
+
+                       /* This is used in sec=share only, so no current user
+                        * around to pass to str_list_sub_basic() */
+
+                       if ( invalid && str_list_sub_basic(invalid, "", "") ) {
+                               ret = !user_in_list(user,
+                                                   (const char **)invalid);
                        }
                }
        }
@@ -350,9 +573,14 @@ BOOL user_ok(const char *user,int snum, gid_t *groups, size_t n_groups)
 
        if (ret && lp_valid_users(snum)) {
                str_list_copy(&valid, lp_valid_users(snum));
-               if ( valid && str_list_substitute(valid, "%S", lp_servicename(snum)) ) {
-                       if ( valid && str_list_sub_basic(valid, current_user_info.smb_name) ) {
-                               ret = user_in_list(user, (const char **)valid, groups, n_groups);
+               if ( valid &&
+                    str_list_substitute(valid, "%S", lp_servicename(snum)) ) {
+
+                       /* This is used in sec=share only, so no current user
+                        * around to pass to str_list_sub_basic() */
+
+                       if ( valid && str_list_sub_basic(valid, "", "") ) {
+                               ret = user_in_list(user, (const char **)valid);
                        }
                }
        }
@@ -361,8 +589,10 @@ BOOL user_ok(const char *user,int snum, gid_t *groups, size_t n_groups)
 
        if (ret && lp_onlyuser(snum)) {
                char **user_list = str_list_make (lp_username(snum), NULL);
-               if (user_list && str_list_substitute(user_list, "%S", lp_servicename(snum))) {
-                       ret = user_in_list(user, (const char **)user_list, groups, n_groups);
+               if (user_list &&
+                   str_list_substitute(user_list, "%S",
+                                       lp_servicename(snum))) {
+                       ret = user_in_list(user, (const char **)user_list);
                }
                if (user_list) str_list_free (&user_list);
        }
@@ -382,7 +612,7 @@ static char *validate_group(char *group, DATA_BLOB password,int snum)
                setnetgrent(group);
                while (getnetgrent(&host, &user, &domain)) {
                        if (user) {
-                               if (user_ok(user, snum, NULL, 0) && 
+                               if (user_ok(user, snum) && 
                                    password_ok(user,password)) {
                                        endnetgrent();
                                        return(user);
@@ -418,12 +648,15 @@ static char *validate_group(char *group, DATA_BLOB password,int snum)
                        member = member_list;
 
                        for(i = 0; gptr->gr_mem && gptr->gr_mem[i]; i++) {
-                               size_t member_len = strlen(gptr->gr_mem[i]) + 1;
-                               if( copied_len + member_len < sizeof(pstring)) { 
+                               size_t member_len = strlen(gptr->gr_mem[i])+1;
+                               if(copied_len+member_len < sizeof(pstring)) { 
 
-                                       DEBUG(10,("validate_group: = gr_mem = %s\n", gptr->gr_mem[i]));
+                                       DEBUG(10,("validate_group: = gr_mem = "
+                                                 "%s\n", gptr->gr_mem[i]));
 
-                                       safe_strcpy(member, gptr->gr_mem[i], sizeof(pstring) - copied_len - 1);
+                                       safe_strcpy(member, gptr->gr_mem[i],
+                                                   sizeof(pstring) -
+                                                   copied_len - 1);
                                        copied_len += member_len;
                                        member += copied_len;
                                } else {
@@ -437,13 +670,14 @@ static char *validate_group(char *group, DATA_BLOB password,int snum)
                        while (*member) {
                                static fstring name;
                                fstrcpy(name,member);
-                               if (user_ok(name,snum, NULL, 0) &&
+                               if (user_ok(name,snum) &&
                                    password_ok(name,password)) {
                                        endgrent();
                                        return(&name[0]);
                                }
 
-                               DEBUG(10,("validate_group = member = %s\n", member));
+                               DEBUG(10,("validate_group = member = %s\n",
+                                         member));
 
                                member += strlen(member) + 1;
                        }
@@ -466,20 +700,22 @@ BOOL authorise_login(int snum, fstring user, DATA_BLOB password,
 {
        BOOL ok = False;
        
-#if DEBUG_PASSWORD
-       DEBUG(100,("authorise_login: checking authorisation on user=%s pass=%s\n",
-                  user,password.data));
+#ifdef DEBUG_PASSWORD
+       DEBUG(100,("authorise_login: checking authorisation on "
+                  "user=%s pass=%s\n", user,password.data));
 #endif
 
        *guest = False;
   
        /* there are several possibilities:
                1) login as the given user with given password
-               2) login as a previously registered username with the given password
+               2) login as a previously registered username with the given 
+                  password
                3) login as a session list username with the given password
                4) login as a previously validated user/password pair
                5) login as the "user =" user with given password
-               6) login as the "user =" user with no password (guest connection)
+               6) login as the "user =" user with no password 
+                  (guest connection)
                7) login as guest user with no password
 
                if the service is guest_only then steps 1 to 5 are skipped
@@ -491,9 +727,9 @@ BOOL authorise_login(int snum, fstring user, DATA_BLOB password,
                char *user_list = NULL;
 
                if ( session_userlist )
-                       user_list = strdup(session_userlist);
+                       user_list = SMB_STRDUP(session_userlist);
                else
-                       user_list = strdup("");
+                       user_list = SMB_STRDUP("");
 
                if (!user_list)
                        return(False);
@@ -502,17 +738,18 @@ BOOL authorise_login(int snum, fstring user, DATA_BLOB password,
                     auser = strtok(NULL,LIST_SEP)) {
                        fstring user2;
                        fstrcpy(user2,auser);
-                       if (!user_ok(user2,snum, NULL, 0))
+                       if (!user_ok(user2,snum))
                                continue;
                        
                        if (password_ok(user2,password)) {
                                ok = True;
                                fstrcpy(user,user2);
-                               DEBUG(3,("authorise_login: ACCEPTED: session list username (%s) \
-and given password ok\n", user));
+                               DEBUG(3,("authorise_login: ACCEPTED: session "
+                                        "list username (%s) and given "
+                                        "password ok\n", user));
                        }
                }
-               
+
                SAFE_FREE(user_list);
        }
        
@@ -531,17 +768,21 @@ and given password ok\n", user));
                                if (auser) {
                                        ok = True;
                                        fstrcpy(user,auser);
-                                       DEBUG(3,("authorise_login: ACCEPTED: group username \
-and given password ok (%s)\n", user));
+                                       DEBUG(3,("authorise_login: ACCEPTED: "
+                                                "group username and given "
+                                                "password ok (%s)\n", user));
                                }
                        } else {
                                fstring user2;
                                fstrcpy(user2,auser);
-                               if (user_ok(user2,snum, NULL, 0) && password_ok(user2,password)) {
+                               if (user_ok(user2,snum) &&
+                                   password_ok(user2,password)) {
                                        ok = True;
                                        fstrcpy(user,user2);
-                                       DEBUG(3,("authorise_login: ACCEPTED: user list username \
-and given password ok (%s)\n", user));
+                                       DEBUG(3,("authorise_login: ACCEPTED: "
+                                                "user list username and "
+                                                "given password ok (%s)\n",
+                                                user));
                                }
                        }
                }
@@ -554,15 +795,16 @@ and given password ok (%s)\n", user));
                if (Get_Pwnam(guestname)) {
                        fstrcpy(user,guestname);
                        ok = True;
-                       DEBUG(3,("authorise_login: ACCEPTED: guest account and guest ok (%s)\n",
-                                       user));
+                       DEBUG(3,("authorise_login: ACCEPTED: guest account "
+                                "and guest ok (%s)\n", user));
                } else {
-                       DEBUG(0,("authorise_login: Invalid guest account %s??\n",guestname));
+                       DEBUG(0,("authorise_login: Invalid guest account "
+                                "%s??\n",guestname));
                }
                *guest = True;
        }
 
-       if (ok && !user_ok(user, snum, NULL, 0)) {
+       if (ok && !user_ok(user, snum)) {
                DEBUG(0,("authorise_login: rejected invalid user %s\n",user));
                ok = False;
        }