smbd: some write time fixes
[tprouty/samba.git] / source / smbd / ipc.c
index 51403cd8b2c1f76869cc5d7ccc38ba78d45c54d4..6961a5caf15ac17fddf0600124325f9ed6f0e486 100644 (file)
@@ -30,7 +30,7 @@ extern int max_send;
 
 #define NERR_notsupported 50
 
-extern int smb_read_error;
+static void api_no_reply(connection_struct *conn, struct smb_request *req);
 
 /*******************************************************************
  copies parameters and data, as needed, into the smb buffer
@@ -46,7 +46,7 @@ static void copy_trans_params_and_data(char *outbuf, int align,
                                char *rparam, int param_offset, int param_len,
                                char *rdata, int data_offset, int data_len)
 {
-       char *copy_into = smb_buf(outbuf)+1;
+       char *copy_into = smb_buf(outbuf);
 
        if(param_len < 0)
                param_len = 0;
@@ -54,14 +54,24 @@ static void copy_trans_params_and_data(char *outbuf, int align,
        if(data_len < 0)
                data_len = 0;
 
-       DEBUG(5,("copy_trans_params_and_data: params[%d..%d] data[%d..%d]\n",
+       DEBUG(5,("copy_trans_params_and_data: params[%d..%d] data[%d..%d] (align %d)\n",
                        param_offset, param_offset + param_len,
-                       data_offset , data_offset  + data_len));
+                       data_offset , data_offset  + data_len,
+                       align));
+
+       *copy_into = '\0';
+
+       copy_into += 1;
 
        if (param_len)
                memcpy(copy_into, &rparam[param_offset], param_len);
 
-       copy_into += param_len + align;
+       copy_into += param_len;
+       if (align) {
+               memset(copy_into, '\0', align);
+       }
+
+       copy_into += align;
 
        if (data_len )
                memcpy(copy_into, &rdata[data_offset], data_len);
@@ -71,13 +81,11 @@ static void copy_trans_params_and_data(char *outbuf, int align,
  Send a trans reply.
  ****************************************************************************/
 
-void send_trans_reply(const char *inbuf,
-                       char *outbuf,
-                       char *rparam,
-                       int rparam_len,
-                       char *rdata,
-                       int rdata_len,
-                       BOOL buffer_too_large)
+void send_trans_reply(connection_struct *conn,
+                       struct smb_request *req,
+                     char *rparam, int rparam_len,
+                     char *rdata, int rdata_len,
+                     bool buffer_too_large)
 {
        int this_ldata,this_lparam;
        int tot_data_sent = 0;
@@ -95,29 +103,39 @@ void send_trans_reply(const char *inbuf,
 
        align = ((this_lparam)%4);
 
-       if (buffer_too_large) {
-               ERROR_BOTH(STATUS_BUFFER_OVERFLOW,ERRDOS,ERRmoredata);
-       }
+       reply_outbuf(req, 10, 1+align+this_ldata+this_lparam);
 
-       set_message(inbuf,outbuf,10,1+align+this_ldata+this_lparam,True);
-
-       copy_trans_params_and_data(outbuf, align,
+       copy_trans_params_and_data((char *)req->outbuf, align,
                                rparam, tot_param_sent, this_lparam,
                                rdata, tot_data_sent, this_ldata);
 
-       SSVAL(outbuf,smb_vwv0,lparam);
-       SSVAL(outbuf,smb_vwv1,ldata);
-       SSVAL(outbuf,smb_vwv3,this_lparam);
-       SSVAL(outbuf,smb_vwv4,smb_offset(smb_buf(outbuf)+1,outbuf));
-       SSVAL(outbuf,smb_vwv5,0);
-       SSVAL(outbuf,smb_vwv6,this_ldata);
-       SSVAL(outbuf,smb_vwv7,smb_offset(smb_buf(outbuf)+1+this_lparam+align,outbuf));
-       SSVAL(outbuf,smb_vwv8,0);
-       SSVAL(outbuf,smb_vwv9,0);
+       SSVAL(req->outbuf,smb_vwv0,lparam);
+       SSVAL(req->outbuf,smb_vwv1,ldata);
+       SSVAL(req->outbuf,smb_vwv3,this_lparam);
+       SSVAL(req->outbuf,smb_vwv4,smb_offset(smb_buf(req->outbuf)+1,
+                                             req->outbuf));
+       SSVAL(req->outbuf,smb_vwv5,0);
+       SSVAL(req->outbuf,smb_vwv6,this_ldata);
+       SSVAL(req->outbuf,smb_vwv7,smb_offset(smb_buf(req->outbuf)+1+
+                                             this_lparam+align,
+                                             req->outbuf));
+       SSVAL(req->outbuf,smb_vwv8,0);
+       SSVAL(req->outbuf,smb_vwv9,0);
+
+       if (buffer_too_large) {
+               error_packet_set((char *)req->outbuf,
+                                ERRDOS, ERRmoredata,
+                                STATUS_BUFFER_OVERFLOW,
+                                __LINE__, __FILE__);
+       }
+
+       show_msg((char *)req->outbuf);
+       if (!srv_send_smb(smbd_server_fd(),
+                       (char *)req->outbuf,
+                       IS_CONN_ENCRYPTED(conn)))
+               exit_server_cleanly("send_trans_reply: srv_send_smb failed.");
 
-       show_msg(outbuf);
-       if (!send_smb(smbd_server_fd(),outbuf))
-               exit_server_cleanly("send_trans_reply: send_smb failed.");
+       TALLOC_FREE(req->outbuf);
 
        tot_data_sent = this_ldata;
        tot_param_sent = this_lparam;
@@ -135,26 +153,39 @@ void send_trans_reply(const char *inbuf,
 
                align = (this_lparam%4);
 
-               set_message(inbuf,outbuf,10,1+this_ldata+this_lparam+align,False);
+               reply_outbuf(req, 10, 1+this_ldata+this_lparam+align);
 
-               copy_trans_params_and_data(outbuf, align,
+               copy_trans_params_and_data((char *)req->outbuf, align,
                                           rparam, tot_param_sent, this_lparam,
                                           rdata, tot_data_sent, this_ldata);
                
-               SSVAL(outbuf,smb_vwv3,this_lparam);
-               SSVAL(outbuf,smb_vwv4,smb_offset(smb_buf(outbuf)+1,outbuf));
-               SSVAL(outbuf,smb_vwv5,tot_param_sent);
-               SSVAL(outbuf,smb_vwv6,this_ldata);
-               SSVAL(outbuf,smb_vwv7,smb_offset(smb_buf(outbuf)+1+this_lparam+align,outbuf));
-               SSVAL(outbuf,smb_vwv8,tot_data_sent);
-               SSVAL(outbuf,smb_vwv9,0);
-
-               show_msg(outbuf);
-               if (!send_smb(smbd_server_fd(),outbuf))
-                       exit_server_cleanly("send_trans_reply: send_smb failed.");
+               SSVAL(req->outbuf,smb_vwv3,this_lparam);
+               SSVAL(req->outbuf,smb_vwv4,smb_offset(smb_buf(req->outbuf)+1,
+                                                     req->outbuf));
+               SSVAL(req->outbuf,smb_vwv5,tot_param_sent);
+               SSVAL(req->outbuf,smb_vwv6,this_ldata);
+               SSVAL(req->outbuf,smb_vwv7,smb_offset(smb_buf(req->outbuf)+1+
+                                                     this_lparam+align,
+                                                     req->outbuf));
+               SSVAL(req->outbuf,smb_vwv8,tot_data_sent);
+               SSVAL(req->outbuf,smb_vwv9,0);
+
+               if (buffer_too_large) {
+                       error_packet_set((char *)req->outbuf,
+                                        ERRDOS, ERRmoredata,
+                                        STATUS_BUFFER_OVERFLOW,
+                                        __LINE__, __FILE__);
+               }
+
+               show_msg((char *)req->outbuf);
+               if (!srv_send_smb(smbd_server_fd(),
+                               (char *)req->outbuf,
+                               IS_CONN_ENCRYPTED(conn)))
+                       exit_server_cleanly("send_trans_reply: srv_send_smb failed.");
 
                tot_data_sent  += this_ldata;
                tot_param_sent += this_lparam;
+               TALLOC_FREE(req->outbuf);
        }
 }
 
@@ -162,55 +193,53 @@ void send_trans_reply(const char *inbuf,
  Start the first part of an RPC reply which began with an SMBtrans request.
 ****************************************************************************/
 
-static BOOL api_rpc_trans_reply(const char *inbuf,
-                               char *outbuf,
-                               smb_np_struct *p)
+static void api_rpc_trans_reply(connection_struct *conn, struct smb_request *req, smb_np_struct *p)
 {
-       BOOL is_data_outstanding;
+       bool is_data_outstanding;
        char *rdata = (char *)SMB_MALLOC(p->max_trans_reply);
        int data_len;
 
        if(rdata == NULL) {
                DEBUG(0,("api_rpc_trans_reply: malloc fail.\n"));
-               return False;
+               reply_nterror(req, NT_STATUS_NO_MEMORY);
+               return;
        }
 
        if((data_len = read_from_pipe( p, rdata, p->max_trans_reply,
                                        &is_data_outstanding)) < 0) {
                SAFE_FREE(rdata);
-               return False;
+               api_no_reply(conn,req);
+               return;
        }
 
-       send_trans_reply(inbuf, outbuf, NULL, 0, rdata, data_len, is_data_outstanding);
-
+       send_trans_reply(conn, req, NULL, 0, rdata, data_len, is_data_outstanding);
        SAFE_FREE(rdata);
-       return True;
+       return;
 }
 
 /****************************************************************************
  WaitNamedPipeHandleState 
 ****************************************************************************/
 
-static BOOL api_WNPHS(const char *inbuf,
-                       char *outbuf,
-                       smb_np_struct *p,
-                       char *param,
-                       int param_len)
+static void api_WNPHS(connection_struct *conn, struct smb_request *req, smb_np_struct *p,
+                     char *param, int param_len)
 {
        uint16 priority;
 
-       if (!param || param_len < 2)
-               return False;
+       if (!param || param_len < 2) {
+               reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
+               return;
+       }
 
        priority = SVAL(param,0);
        DEBUG(4,("WaitNamedPipeHandleState priority %x\n", priority));
 
        if (wait_rpc_pipe_hnd_state(p, priority)) {
                /* now send the reply */
-               send_trans_reply(inbuf, outbuf, NULL, 0, NULL, 0, False);
-               return True;
+               send_trans_reply(conn, req, NULL, 0, NULL, 0, False);
+               return;
        }
-       return False;
+       api_no_reply(conn,req);
 }
 
 
@@ -218,26 +247,25 @@ static BOOL api_WNPHS(const char *inbuf,
  SetNamedPipeHandleState 
 ****************************************************************************/
 
-static BOOL api_SNPHS(const char *inbuf,
-                       char *outbuf,
-                       smb_np_struct *p,
-                       char *param,
-                       int param_len)
+static void api_SNPHS(connection_struct *conn, struct smb_request *req, smb_np_struct *p,
+                     char *param, int param_len)
 {
        uint16 id;
 
-       if (!param || param_len < 2)
-               return False;
+       if (!param || param_len < 2) {
+               reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
+               return;
+       }
 
        id = SVAL(param,0);
        DEBUG(4,("SetNamedPipeHandleState to code %x\n", id));
 
        if (set_rpc_pipe_hnd_state(p, id)) {
                /* now send the reply */
-               send_trans_reply(inbuf, outbuf, NULL, 0, NULL, 0, False);
-               return True;
+               send_trans_reply(conn, req, NULL, 0, NULL, 0, False);
+               return;
        }
-       return False;
+       api_no_reply(conn,req);
 }
 
 
@@ -245,7 +273,7 @@ static BOOL api_SNPHS(const char *inbuf,
  When no reply is generated, indicate unsupported.
  ****************************************************************************/
 
-static BOOL api_no_reply(const char *inbuf, char *outbuf, int max_rdata_len)
+static void api_no_reply(connection_struct *conn, struct smb_request *req)
 {
        char rparam[4];
 
@@ -256,29 +284,22 @@ static BOOL api_no_reply(const char *inbuf, char *outbuf, int max_rdata_len)
        DEBUG(3,("Unsupported API fd command\n"));
 
        /* now send the reply */
-       send_trans_reply(inbuf, outbuf, rparam, 4, NULL, 0, False);
+       send_trans_reply(conn, req, rparam, 4, NULL, 0, False);
 
-       return -1;
+       return;
 }
 
 /****************************************************************************
  Handle remote api calls delivered to a named pipe already opened.
  ****************************************************************************/
 
-static int api_fd_reply(connection_struct *conn,
-                       uint16 vuid,
-                       const char *inbuf,
-                       char *outbuf,
-                       uint16 *setup,
-                       char *data,
-                       char *params,
-                       int suwcnt,
-                       int tdscnt,
-                       int tpscnt,
-                       int mdrcnt,
-                       int mprcnt)
+static void api_fd_reply(connection_struct *conn, uint16 vuid,
+                        struct smb_request *req,
+                        uint16 *setup, char *data, char *params,
+                        int suwcnt, int tdscnt, int tpscnt,
+                        int mdrcnt, int mprcnt)
 {
-       BOOL reply = False;
+       bool reply = False;
        smb_np_struct *p = NULL;
        int pnum;
        int subcommand;
@@ -288,7 +309,8 @@ static int api_fd_reply(connection_struct *conn,
        /* First find out the name of this file. */
        if (suwcnt != 2) {
                DEBUG(0,("Unexpected named pipe transaction.\n"));
-               return ERROR_NT(NT_STATUS_INVALID_PARAMETER);
+               reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
+               return;
        }
 
        /* Get the file handle and hence the file name. */
@@ -304,18 +326,20 @@ static int api_fd_reply(connection_struct *conn,
                        /* Win9x does this call with a unicode pipe name, not a pnum. */
                        /* Just return success for now... */
                        DEBUG(3,("Got TRANSACT_WAITNAMEDPIPEHANDLESTATE on text pipe name\n"));
-                       send_trans_reply(inbuf, outbuf, NULL, 0, NULL, 0, False);
-                       return -1;
+                       send_trans_reply(conn, req, NULL, 0, NULL, 0, False);
+                       return;
                }
 
                DEBUG(1,("api_fd_reply: INVALID PIPE HANDLE: %x\n", pnum));
-               return ERROR_NT(NT_STATUS_INVALID_HANDLE);
+               reply_nterror(req, NT_STATUS_INVALID_HANDLE);
+               return;
        }
 
        if (vuid != p->vuid) {
                DEBUG(1, ("Got pipe request (pnum %x) using invalid VUID %d, "
                          "expected %d\n", pnum, vuid, p->vuid));
-               return ERROR_NT(NT_STATUS_INVALID_HANDLE);
+               reply_nterror(req, NT_STATUS_INVALID_HANDLE);
+               return;
        }
 
        DEBUG(3,("Got API command 0x%x on pipe \"%s\" (pnum %x)\n", subcommand, p->name, pnum));
@@ -329,45 +353,45 @@ static int api_fd_reply(connection_struct *conn,
        case TRANSACT_DCERPCCMD:
                /* dce/rpc command */
                reply = write_to_pipe(p, data, tdscnt);
-               if (reply)
-                       reply = api_rpc_trans_reply(inbuf, outbuf, p);
+               if (!reply) {
+                       api_no_reply(conn, req);
+                       return;
+               }
+               api_rpc_trans_reply(conn, req, p);
                break;
        case TRANSACT_WAITNAMEDPIPEHANDLESTATE:
                /* Wait Named Pipe Handle state */
-               reply = api_WNPHS(inbuf, outbuf, p, params, tpscnt);
+               api_WNPHS(conn, req, p, params, tpscnt);
                break;
        case TRANSACT_SETNAMEDPIPEHANDLESTATE:
                /* Set Named Pipe Handle state */
-               reply = api_SNPHS(inbuf, outbuf, p, params, tpscnt);
+               api_SNPHS(conn, req, p, params, tpscnt);
                break;
        default:
-               return ERROR_NT(NT_STATUS_INVALID_PARAMETER);
+               reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
+               return;
        }
-
-       if (!reply)
-               return api_no_reply(inbuf, outbuf, mdrcnt);
-
-       return -1;
 }
 
 /****************************************************************************
  Handle named pipe commands.
 ****************************************************************************/
 
-static int named_pipe(connection_struct *conn, uint16 vuid,
-                     const char *inbuf, char *outbuf,
-                     char *name, uint16 *setup,
-                     char *data, char *params,
-                     int suwcnt, int tdscnt,int tpscnt,
-                     int msrcnt, int mdrcnt, int mprcnt)
+static void named_pipe(connection_struct *conn, uint16 vuid,
+                      struct smb_request *req,
+                      const char *name, uint16 *setup,
+                      char *data, char *params,
+                      int suwcnt, int tdscnt,int tpscnt,
+                      int msrcnt, int mdrcnt, int mprcnt)
 {
        DEBUG(3,("named pipe command on <%s> name\n", name));
 
        if (strequal(name,"LANMAN")) {
-               return api_reply(conn, vuid, inbuf, outbuf,
-                                data, params,
-                                tdscnt, tpscnt,
-                                mdrcnt, mprcnt);
+               api_reply(conn, vuid, req,
+                         data, params,
+                         tdscnt, tpscnt,
+                         mdrcnt, mprcnt);
+               return;
        }
 
        if (strequal(name,"WKSSVC") ||
@@ -375,25 +399,30 @@ static int named_pipe(connection_struct *conn, uint16 vuid,
            strequal(name,"WINREG") ||
            strequal(name,"SAMR") ||
            strequal(name,"LSARPC")) {
+
                DEBUG(4,("named pipe command from Win95 (wow!)\n"));
-               return api_fd_reply(conn, vuid, inbuf, outbuf,
-                                   setup, data, params,
-                                   suwcnt, tdscnt, tpscnt,
-                                   mdrcnt, mprcnt);
+
+               api_fd_reply(conn, vuid, req,
+                            setup, data, params,
+                            suwcnt, tdscnt, tpscnt,
+                            mdrcnt, mprcnt);
+               return;
        }
 
        if (strlen(name) < 1) {
-               return api_fd_reply(conn, vuid, inbuf, outbuf,
-                                   setup, data,
-                                   params, suwcnt, tdscnt,
-                                   tpscnt, mdrcnt, mprcnt);
+               api_fd_reply(conn, vuid, req,
+                            setup, data,
+                            params, suwcnt, tdscnt,
+                            tpscnt, mdrcnt, mprcnt);
+               return;
        }
 
        if (setup)
                DEBUG(3,("unknown named pipe: setup 0x%X setup1=%d\n",
                         (int)setup[0],(int)setup[1]));
 
-       return 0;
+       reply_nterror(req, NT_STATUS_NOT_SUPPORTED);
+       return;
 }
 
 static void handle_trans(connection_struct *conn, struct smb_request *req,
@@ -401,19 +430,11 @@ static void handle_trans(connection_struct *conn, struct smb_request *req,
 {
        char *local_machine_name;
        int name_offset = 0;
-       char *inbuf, *outbuf;
-       int size, bufsize;
-       int outsize;
 
        DEBUG(3,("trans <%s> data=%u params=%u setup=%u\n",
                 state->name,(unsigned int)state->total_data,(unsigned int)state->total_param,
                 (unsigned int)state->setup_count));
 
-       if (!reply_prep_legacy(req, &inbuf, &outbuf, &size, &bufsize)) {
-               reply_nterror(req, NT_STATUS_NO_MEMORY);
-               return;
-       }
-
        /*
         * WinCE wierdness....
         */
@@ -436,7 +457,7 @@ static void handle_trans(connection_struct *conn, struct smb_request *req,
                reply_nterror(req, NT_STATUS_NOT_SUPPORTED);
                return;
        }
-       
+
        name_offset += strlen("\\PIPE");
 
        /* Win9x weirdness.  When talking to a unicode server Win9x
@@ -446,28 +467,20 @@ static void handle_trans(connection_struct *conn, struct smb_request *req,
                name_offset++;
 
        DEBUG(5,("calling named_pipe\n"));
-       outsize = named_pipe(conn,
-                            state->vuid,
-                            inbuf,
-                            outbuf,
-                            state->name+name_offset,
-                            state->setup,state->data,
-                            state->param,
-                            state->setup_count,state->total_data,
-                            state->total_param,
-                            state->max_setup_return,
-                            state->max_data_return,
-                            state->max_param_return);
-
-       if (outsize == 0) {
-               reply_nterror(req, NT_STATUS_NOT_SUPPORTED);
-               return;
-       }
-
-       if (state->close_on_completion)
+       named_pipe(conn, state->vuid, req,
+                  state->name+name_offset,
+                  state->setup,state->data,
+                  state->param,
+                  state->setup_count,state->total_data,
+                  state->total_param,
+                  state->max_setup_return,
+                  state->max_data_return,
+                  state->max_param_return);
+
+       if (state->close_on_completion) {
                close_cnum(conn,state->vuid);
-
-       reply_post_legacy(req, outsize);
+               req->conn = NULL;
+       }
 
        return;
 }
@@ -476,25 +489,28 @@ static void handle_trans(connection_struct *conn, struct smb_request *req,
  Reply to a SMBtrans.
  ****************************************************************************/
 
-void reply_trans(connection_struct *conn, struct smb_request *req)
+void reply_trans(struct smb_request *req)
 {
+       connection_struct *conn = req->conn;
        unsigned int dsoff;
        unsigned int dscnt;
        unsigned int psoff;
        unsigned int pscnt;
        struct trans_state *state;
        NTSTATUS result;
-       int size;
+       unsigned int size;
+       unsigned int av_size;
 
        START_PROFILE(SMBtrans);
 
-       if (SVAL(req->inbuf, smb_wct) < 10) {
+       if (req->wct < 14) {
                reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
                END_PROFILE(SMBtrans);
                return;
        }
 
        size = smb_len(req->inbuf) + 4;
+       av_size = smb_len(req->inbuf);
        dsoff = SVAL(req->inbuf, smb_dsoff);
        dscnt = SVAL(req->inbuf, smb_dscnt);
        psoff = SVAL(req->inbuf, smb_psoff);
@@ -532,12 +548,11 @@ void reply_trans(connection_struct *conn, struct smb_request *req)
        state->close_on_completion = BITSETW(req->inbuf+smb_vwv5,0);
        state->one_way = BITSETW(req->inbuf+smb_vwv5,1);
 
-       memset(state->name, '\0',sizeof(state->name));
-       srvstr_pull_buf(req->inbuf, req->flags2, state->name,
-                       smb_buf(req->inbuf), sizeof(state->name),
-                       STR_TERMINATE);
-       
-       if ((dscnt > state->total_data) || (pscnt > state->total_param))
+       srvstr_pull_buf_talloc(state, req->inbuf, req->flags2, &state->name,
+                       smb_buf(req->inbuf), STR_TERMINATE);
+
+       if ((dscnt > state->total_data) || (pscnt > state->total_param) ||
+                       !state->name)
                goto bad_param;
 
        if (state->total_data)  {
@@ -551,15 +566,20 @@ void reply_trans(connection_struct *conn, struct smb_request *req)
                        reply_nterror(req, NT_STATUS_NO_MEMORY);
                        END_PROFILE(SMBtrans);
                        return;
-               } 
+               }
                /* null-terminate the slack space */
                memset(&state->data[state->total_data], 0, 100);
-               if ((dsoff+dscnt < dsoff) || (dsoff+dscnt < dscnt))
+
+               if (dscnt > state->total_data ||
+                               dsoff+dscnt < dsoff) {
                        goto bad_param;
-               if ((smb_base(req->inbuf)+dsoff+dscnt
-                    > (char *)req->inbuf + size) ||
-                   (smb_base(req->inbuf)+dsoff+dscnt < smb_base(req->inbuf)))
+               }
+
+               if (dsoff > av_size ||
+                               dscnt > av_size ||
+                               dsoff+dscnt > av_size) {
                        goto bad_param;
+               }
 
                memcpy(state->data,smb_base(req->inbuf)+dsoff,dscnt);
        }
@@ -579,12 +599,17 @@ void reply_trans(connection_struct *conn, struct smb_request *req)
                } 
                /* null-terminate the slack space */
                memset(&state->param[state->total_param], 0, 100);
-               if ((psoff+pscnt < psoff) || (psoff+pscnt < pscnt))
+
+               if (pscnt > state->total_param ||
+                               psoff+pscnt < psoff) {
                        goto bad_param;
-               if ((smb_base(req->inbuf)+psoff+pscnt
-                    > (char *)req->inbuf + size) ||
-                   (smb_base(req->inbuf)+psoff+pscnt < smb_base(req->inbuf)))
+               }
+
+               if (psoff > av_size ||
+                               pscnt > av_size ||
+                               psoff+pscnt > av_size) {
                        goto bad_param;
+               }
 
                memcpy(state->param,smb_base(req->inbuf)+psoff,pscnt);
        }
@@ -657,17 +682,18 @@ void reply_trans(connection_struct *conn, struct smb_request *req)
  Reply to a secondary SMBtrans.
  ****************************************************************************/
 
-void reply_transs(connection_struct *conn, struct smb_request *req)
+void reply_transs(struct smb_request *req)
 {
+       connection_struct *conn = req->conn;
        unsigned int pcnt,poff,dcnt,doff,pdisp,ddisp;
        struct trans_state *state;
-       int size;
+       unsigned int av_size;
 
        START_PROFILE(SMBtranss);
 
        show_msg((char *)req->inbuf);
 
-       if (req->wct < 10) {
+       if (req->wct < 8) {
                reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
                END_PROFILE(SMBtranss);
                return;
@@ -694,7 +720,7 @@ void reply_transs(connection_struct *conn, struct smb_request *req)
        if (SVAL(req->inbuf, smb_vwv1) < state->total_data)
                state->total_data = SVAL(req->inbuf,smb_vwv1);
 
-       size = smb_len(req->inbuf) + 4;
+       av_size = smb_len(req->inbuf);
 
        pcnt = SVAL(req->inbuf, smb_spscnt);
        poff = SVAL(req->inbuf, smb_spsoff);
@@ -712,41 +738,41 @@ void reply_transs(connection_struct *conn, struct smb_request *req)
                goto bad_param;
                
        if (pcnt) {
-               if (pdisp+pcnt > state->total_param)
-                       goto bad_param;
-               if ((pdisp+pcnt < pdisp) || (pdisp+pcnt < pcnt))
-                       goto bad_param;
-               if (pdisp > state->total_param)
-                       goto bad_param;
-               if ((smb_base(req->inbuf) + poff + pcnt
-                    > (char *)req->inbuf + size) ||
-                   (smb_base(req->inbuf) + poff + pcnt
-                    < smb_base(req->inbuf)))
+               if (pdisp > state->total_param ||
+                               pcnt > state->total_param ||
+                               pdisp+pcnt > state->total_param ||
+                               pdisp+pcnt < pdisp) {
                        goto bad_param;
-               if (state->param + pdisp < state->param)
+               }
+
+               if (poff > av_size ||
+                               pcnt > av_size ||
+                               poff+pcnt > av_size ||
+                               poff+pcnt < poff) {
                        goto bad_param;
+               }
 
                memcpy(state->param+pdisp,smb_base(req->inbuf)+poff,
                       pcnt);
        }
 
        if (dcnt) {
-               if (ddisp+dcnt > state->total_data)
-                       goto bad_param;
-               if ((ddisp+dcnt < ddisp) || (ddisp+dcnt < dcnt))
-                       goto bad_param;
-               if (ddisp > state->total_data)
+               if (ddisp > state->total_data ||
+                               dcnt > state->total_data ||
+                               ddisp+dcnt > state->total_data ||
+                               ddisp+dcnt < ddisp) {
                        goto bad_param;
-               if ((smb_base(req->inbuf) + doff + dcnt
-                    > (char *)req->inbuf + size) ||
-                   (smb_base(req->inbuf) + doff + dcnt
-                    < smb_base(req->inbuf)))
-                       goto bad_param;
-               if (state->data + ddisp < state->data)
+               }
+
+               if (ddisp > av_size ||
+                               dcnt > av_size ||
+                               ddisp+dcnt > av_size ||
+                               ddisp+dcnt < ddisp) {
                        goto bad_param;
+               }
 
                memcpy(state->data+ddisp, smb_base(req->inbuf)+doff,
-                      dcnt);      
+                      dcnt);
        }
 
        if ((state->received_param < state->total_param) ||
@@ -755,10 +781,11 @@ void reply_transs(connection_struct *conn, struct smb_request *req)
                return;
        }
 
-       /* construct_reply_common has done us the favor to pre-fill the
-        * command field with SMBtranss which is wrong :-)
-        */
-       SCVAL(req->outbuf,smb_com,SMBtrans);
+        /*
+        * construct_reply_common will copy smb_com from inbuf to
+        * outbuf. SMBtranss is wrong here.
+         */
+        SCVAL(req->inbuf,smb_com,SMBtrans);
 
        handle_trans(conn, req, state);