r4088: Get medieval on our ass about malloc.... :-). Take control of all our allocation
[tprouty/samba.git] / source / printing / notify.c
index 26ef191f877a4c9d1b5b363493d196573ae61c1b..0071d3d8c0d41d8794b0abaf4cc584741cd715a1 100644 (file)
@@ -99,7 +99,7 @@ again:
                                msg->len, msg->notify.data);
 
        if (buflen != len) {
-               buf = talloc_realloc(send_ctx, buf, len);
+               buf = TALLOC_REALLOC(send_ctx, buf, len);
                if (!buf)
                        return False;
                buflen = len;
@@ -140,7 +140,7 @@ static void print_notify_send_messages_to_printer(const char *printer, unsigned
        }
        offset += 4; /* For count. */
 
-       buf = talloc(send_ctx, offset);
+       buf = TALLOC(send_ctx, offset);
        if (!buf) {
                DEBUG(0,("print_notify_send_messages: Out of memory\n"));
                talloc_destroy_pool(send_ctx);
@@ -218,7 +218,7 @@ static BOOL copy_notify2_msg( SPOOLSS_NOTIFY_MSG *to, SPOOLSS_NOTIFY_MSG *from )
        memcpy( to, from, sizeof(SPOOLSS_NOTIFY_MSG) );
        
        if ( from->len ) {
-               to->notify.data = talloc_memdup(send_ctx, from->notify.data, from->len );
+               to->notify.data = TALLOC_MEMDUP(send_ctx, from->notify.data, from->len );
                if ( !to->notify.data ) {
                        DEBUG(0,("copy_notify2_msg: talloc_memdup() of size [%d] failed!\n", from->len ));
                        return False;
@@ -243,18 +243,21 @@ static void send_spoolss_notify2_msg(SPOOLSS_NOTIFY_MSG *msg)
         * as they will just cause flickering updates in the client.
         */
 
-       if ((num_messages < 100) && (msg->type == JOB_NOTIFY_TYPE) &&
-                               (msg->field == JOB_NOTIFY_TOTAL_BYTES || msg->field == JOB_NOTIFY_TOTAL_PAGES)) {
+       if ((num_messages < 100) && (msg->type == JOB_NOTIFY_TYPE) 
+               && (msg->field == JOB_NOTIFY_TOTAL_BYTES 
+                   || msg->field == JOB_NOTIFY_TOTAL_PAGES )) 
+       {
 
-               for (tmp_ptr = notify_queue_head; tmp_ptr; tmp_ptr = tmp_ptr->next) {
+               for (tmp_ptr = notify_queue_head; tmp_ptr; tmp_ptr = tmp_ptr->next) 
+               {
                        if (tmp_ptr->msg->type == msg->type &&
                                        tmp_ptr->msg->field == msg->field &&
                                        tmp_ptr->msg->id == msg->id &&
                                        tmp_ptr->msg->flags == msg->flags &&
                                        strequal(tmp_ptr->msg->printer, msg->printer)) {
 
-                               DEBUG(5, ("send_spoolss_notify2_msg: replacing message 0x%02x/0x%02x for printer %s \
-in notify_queue\n", msg->type, msg->field, msg->printer));
+                               DEBUG(5,("send_spoolss_notify2_msg: replacing message 0x%02x/0x%02x for "
+                                        "printer %s in notify_queue\n", msg->type, msg->field, msg->printer));
 
                                tmp_ptr->msg = msg;
                                return;
@@ -264,7 +267,7 @@ in notify_queue\n", msg->type, msg->field, msg->printer));
 
        /* Store the message on the pending queue. */
 
-       pnqueue = talloc(send_ctx, sizeof(*pnqueue));
+       pnqueue = TALLOC_P(send_ctx, struct notify_queue);
        if (!pnqueue) {
                DEBUG(0,("send_spoolss_notify2_msg: Out of memory.\n"));
                return;
@@ -272,13 +275,13 @@ in notify_queue\n", msg->type, msg->field, msg->printer));
 
        /* allocate a new msg structure and copy the fields */
        
-       if ( !(pnqueue->msg = (SPOOLSS_NOTIFY_MSG*)talloc(send_ctx, sizeof(SPOOLSS_NOTIFY_MSG))) ) {
+       if ( !(pnqueue->msg = TALLOC_P(send_ctx, SPOOLSS_NOTIFY_MSG)) ) {
                DEBUG(0,("send_spoolss_notify2_msg: talloc() of size [%lu] failed!\n", 
                        (unsigned long)sizeof(SPOOLSS_NOTIFY_MSG)));
                return;
        }
        copy_notify2_msg(pnqueue->msg, msg);
-       gettimeofday(&pnqueue->tv, NULL);
+       GetTimeOfDay(&pnqueue->tv);
        pnqueue->buf = NULL;
        pnqueue->buflen = 0;
 
@@ -294,7 +297,7 @@ to notify_queue_head\n", msg->type, msg->field, msg->printer));
        num_messages++;
 }
 
-static void send_notify_field_values(const char *printer_name, uint32 type,
+static void send_notify_field_values(const char *sharename, uint32 type,
                                     uint32 field, uint32 id, uint32 value1, 
                                     uint32 value2, uint32 flags)
 {
@@ -306,13 +309,13 @@ static void send_notify_field_values(const char *printer_name, uint32 type,
        if (!create_send_ctx())
                return;
 
-       msg = (struct spoolss_notify_msg *)talloc(send_ctx, sizeof(struct spoolss_notify_msg));
+       msg = TALLOC_P(send_ctx, struct spoolss_notify_msg);
        if (!msg)
                return;
 
        ZERO_STRUCTP(msg);
 
-       fstrcpy(msg->printer, printer_name);
+       fstrcpy(msg->printer, sharename);
        msg->type = type;
        msg->field = field;
        msg->id = id;
@@ -323,7 +326,7 @@ static void send_notify_field_values(const char *printer_name, uint32 type,
        send_spoolss_notify2_msg(msg);
 }
 
-static void send_notify_field_buffer(const char *printer_name, uint32 type,
+static void send_notify_field_buffer(const char *sharename, uint32 type,
                                     uint32 field, uint32 id, uint32 len,
                                     char *buffer)
 {
@@ -335,13 +338,13 @@ static void send_notify_field_buffer(const char *printer_name, uint32 type,
        if (!create_send_ctx())
                return;
 
-       msg = (struct spoolss_notify_msg *)talloc(send_ctx, sizeof(struct spoolss_notify_msg));
+       msg = TALLOC_P(send_ctx, struct spoolss_notify_msg);
        if (!msg)
                return;
 
        ZERO_STRUCTP(msg);
 
-       fstrcpy(msg->printer, printer_name);
+       fstrcpy(msg->printer, sharename);
        msg->type = type;
        msg->field = field;
        msg->id = id;
@@ -353,140 +356,131 @@ static void send_notify_field_buffer(const char *printer_name, uint32 type,
 
 /* Send a message that the printer status has changed */
 
-void notify_printer_status_byname(const char *printer_name, uint32 status)
+void notify_printer_status_byname(const char *sharename, uint32 status)
 {
        /* Printer status stored in value1 */
 
-       send_notify_field_values(printer_name, PRINTER_NOTIFY_TYPE, 
+       send_notify_field_values(sharename, PRINTER_NOTIFY_TYPE, 
                                 PRINTER_NOTIFY_STATUS, 0, 
                                 status, 0, 0);
 }
 
 void notify_printer_status(int snum, uint32 status)
 {
-       const char *printer_name = SERVICE(snum); 
+       const char *sharename = SERVICE(snum); 
 
-       if (printer_name)
-               notify_printer_status_byname(printer_name, status);
+       if (sharename)
+               notify_printer_status_byname(sharename, status);
 }
 
-void notify_job_status_byname(const char *printer_name, uint32 jobid, uint32 status,
+void notify_job_status_byname(const char *sharename, uint32 jobid, uint32 status,
                              uint32 flags)
 {
        /* Job id stored in id field, status in value1 */
 
-       send_notify_field_values(printer_name, JOB_NOTIFY_TYPE,
+       send_notify_field_values(sharename, JOB_NOTIFY_TYPE,
                                 JOB_NOTIFY_STATUS, jobid,
                                 status, 0, flags);
 }
 
-void notify_job_status(int snum, uint32 jobid, uint32 status)
+void notify_job_status(const char *sharename, uint32 jobid, uint32 status)
 {
-       const char *printer_name = SERVICE(snum);
-
-       notify_job_status_byname(printer_name, jobid, status, 0);
+       notify_job_status_byname(sharename, jobid, status, 0);
 }
 
-void notify_job_total_bytes(int snum, uint32 jobid, uint32 size)
+void notify_job_total_bytes(const char *sharename, uint32 jobid,
+                           uint32 size)
 {
-       const char *printer_name = SERVICE(snum);
-
        /* Job id stored in id field, status in value1 */
 
-       send_notify_field_values(printer_name, JOB_NOTIFY_TYPE,
+       send_notify_field_values(sharename, JOB_NOTIFY_TYPE,
                                 JOB_NOTIFY_TOTAL_BYTES, jobid,
                                 size, 0, 0);
 }
 
-void notify_job_total_pages(int snum, uint32 jobid, uint32 pages)
+void notify_job_total_pages(const char *sharename, uint32 jobid,
+                           uint32 pages)
 {
-       const char *printer_name = SERVICE(snum);
-
        /* Job id stored in id field, status in value1 */
 
-       send_notify_field_values(printer_name, JOB_NOTIFY_TYPE,
+       send_notify_field_values(sharename, JOB_NOTIFY_TYPE,
                                 JOB_NOTIFY_TOTAL_PAGES, jobid,
                                 pages, 0, 0);
 }
 
-void notify_job_username(int snum, uint32 jobid, char *name)
+void notify_job_username(const char *sharename, uint32 jobid, char *name)
 {
-       const char *printer_name = SERVICE(snum);
-
        send_notify_field_buffer(
-               printer_name, JOB_NOTIFY_TYPE, JOB_NOTIFY_USER_NAME,
+               sharename, JOB_NOTIFY_TYPE, JOB_NOTIFY_USER_NAME,
                jobid, strlen(name) + 1, name);
 }
 
-void notify_job_name(int snum, uint32 jobid, char *name)
+void notify_job_name(const char *sharename, uint32 jobid, char *name)
 {
-       const char *printer_name = SERVICE(snum);
-
        send_notify_field_buffer(
-               printer_name, JOB_NOTIFY_TYPE, JOB_NOTIFY_DOCUMENT,
+               sharename, JOB_NOTIFY_TYPE, JOB_NOTIFY_DOCUMENT,
                jobid, strlen(name) + 1, name);
 }
 
-void notify_job_submitted(int snum, uint32 jobid, time_t submitted)
+void notify_job_submitted(const char *sharename, uint32 jobid,
+                         time_t submitted)
 {
-       const char *printer_name = SERVICE(snum);
-
        send_notify_field_buffer(
-               printer_name, JOB_NOTIFY_TYPE, JOB_NOTIFY_SUBMITTED,
+               sharename, JOB_NOTIFY_TYPE, JOB_NOTIFY_SUBMITTED,
                jobid, sizeof(submitted), (char *)&submitted);
 }
 
 void notify_printer_driver(int snum, char *driver_name)
 {
-       const char *printer_name = SERVICE(snum);
+       const char *sharename = SERVICE(snum);
 
        send_notify_field_buffer(
-               printer_name, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_DRIVER_NAME,
+               sharename, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_DRIVER_NAME,
                snum, strlen(driver_name) + 1, driver_name);
 }
 
 void notify_printer_comment(int snum, char *comment)
 {
-       const char *printer_name = SERVICE(snum);
+       const char *sharename = SERVICE(snum);
 
        send_notify_field_buffer(
-               printer_name, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_COMMENT,
+               sharename, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_COMMENT,
                snum, strlen(comment) + 1, comment);
 }
 
 void notify_printer_sharename(int snum, char *share_name)
 {
-       const char *printer_name = SERVICE(snum);
+       const char *sharename = SERVICE(snum);
 
        send_notify_field_buffer(
-               printer_name, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_SHARE_NAME,
+               sharename, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_SHARE_NAME,
                snum, strlen(share_name) + 1, share_name);
 }
 
 void notify_printer_printername(int snum, char *printername)
 {
-       const char *printer_name = SERVICE(snum);
+       const char *sharename = SERVICE(snum);
 
        send_notify_field_buffer(
-               printer_name, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_PRINTER_NAME,
+               sharename, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_PRINTER_NAME,
                snum, strlen(printername) + 1, printername);
 }
 
 void notify_printer_port(int snum, char *port_name)
 {
-       const char *printer_name = SERVICE(snum);
+       const char *sharename = SERVICE(snum);
 
        send_notify_field_buffer(
-               printer_name, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_PORT_NAME,
+               sharename, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_PORT_NAME,
                snum, strlen(port_name) + 1, port_name);
 }
 
 void notify_printer_location(int snum, char *location)
 {
-       const char *printer_name = SERVICE(snum);
+       const char *sharename = SERVICE(snum);
 
        send_notify_field_buffer(
-               printer_name, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_LOCATION,
+               sharename, PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_LOCATION,
                snum, strlen(location) + 1, location);
 }
 
@@ -541,7 +535,7 @@ BOOL print_notify_pid_list(const char *printername, TALLOC_CTX *mem_ctx, size_t
 
        num_pids = data.dsize / 8;
 
-       if ((pid_list = (pid_t *)talloc(mem_ctx, sizeof(pid_t) * num_pids)) == NULL) {
+       if ((pid_list = TALLOC_ARRAY(mem_ctx, pid_t, num_pids)) == NULL) {
                ret = False;
                goto done;
        }