r20090: Fix a class of bugs found by James Peach. Ensure
[tprouty/samba.git] / source / passdb / pdb_ldap.c
index 9abd668d6f4c5c244cac6ba9567ad3038f215d80..8ea54ead30d9bbbfd3ee84f574a381c94fd1614f 100644 (file)
@@ -6,6 +6,7 @@
    Copyright (C) Shahms King                   2001
    Copyright (C) Andrew Bartlett               2002-2003
    Copyright (C) Stefan (metze) Metzmacher     2002-2003
+   Copyright (C) Simo Sorce                    2006
     
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -30,7 +31,7 @@
 *  Clean up SSL stuff, compile on OpenLDAP 1.x, 2.x, and Netscape SDK
 *
 *  Other LDAP based login attributes: accountExpires, etc.
-*  (should be the domain of Samba proper, but the sam_password/SAM_ACCOUNT
+*  (should be the domain of Samba proper, but the sam_password/struct samu
 *  structures don't have fields for some of these attributes)
 *
 *  SSL is done, but can't get the certificate based authentication to work
 #endif
 
 
-#ifndef SAM_ACCOUNT
-#define SAM_ACCOUNT struct sam_passwd
-#endif
-
 #include "smbldap.h"
 
 /**********************************************************************
@@ -215,7 +212,7 @@ static NTSTATUS ldapsam_get_seq_num(struct pdb_methods *my_methods, time_t *seq_
                return ntstatus;
        }
 
-       if (!smbldap_has_naming_context(ldap_state->smbldap_state, lp_ldap_suffix())) {
+       if (!smbldap_has_naming_context(ldap_state->smbldap_state->ldap_struct, lp_ldap_suffix())) {
                DEBUG(3,("ldapsam_get_seq_num: DIT not configured to hold %s "
                         "as top-level namingContext\n", lp_ldap_suffix()));
                return ntstatus;
@@ -226,7 +223,10 @@ static NTSTATUS ldapsam_get_seq_num(struct pdb_methods *my_methods, time_t *seq_
        if (mem_ctx == NULL)
                return NT_STATUS_NO_MEMORY;
 
-       attrs = TALLOC_ARRAY(mem_ctx, const char *, 2);
+       if ((attrs = TALLOC_ARRAY(mem_ctx, const char *, 2)) == NULL) {
+               ntstatus = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
 
        /* if we got a syncrepl-rid (up to three digits long) we speak with a consumer */
        rid = lp_parm_int(-1, "ldapsam", "syncrepl_rid", -1);
@@ -445,67 +445,7 @@ static int ldapsam_delete_entry(struct ldapsam_privates *priv,
        return smbldap_modify(priv->smbldap_state, dn, mods);
 }
                  
-/* New Interface is being implemented here */
-
-#if 0  /* JERRY - not uesed anymore */
-
-/**********************************************************************
-Initialize SAM_ACCOUNT from an LDAP query (unix attributes only)
-*********************************************************************/
-static BOOL get_unix_attributes (struct ldapsam_privates *ldap_state, 
-                               SAM_ACCOUNT * sampass,
-                               LDAPMessage * entry,
-                               gid_t *gid)
-{
-       pstring  homedir;
-       pstring  temp;
-       char **ldap_values;
-       char **values;
-
-       if ((ldap_values = ldap_get_values (ldap_state->smbldap_state->ldap_struct, entry, "objectClass")) == NULL) {
-               DEBUG (1, ("get_unix_attributes: no objectClass! \n"));
-               return False;
-       }
-
-       for (values=ldap_values;*values;values++) {
-               if (strequal(*values, LDAP_OBJ_POSIXACCOUNT )) {
-                       break;
-               }
-       }
-       
-       if (!*values) { /*end of array, no posixAccount */
-               DEBUG(10, ("user does not have %s attributes\n", LDAP_OBJ_POSIXACCOUNT));
-               ldap_value_free(ldap_values);
-               return False;
-       }
-       ldap_value_free(ldap_values);
-
-       if ( !smbldap_get_single_pstring(ldap_state->smbldap_state->ldap_struct, entry, 
-               get_userattr_key2string(ldap_state->schema_ver, LDAP_ATTR_UNIX_HOME), homedir) ) 
-       {
-               return False;
-       }
-       
-       if ( !smbldap_get_single_pstring(ldap_state->smbldap_state->ldap_struct, entry, 
-               get_userattr_key2string(ldap_state->schema_ver, LDAP_ATTR_GIDNUMBER), temp) )
-       {
-               return False;
-       }
-       
-       *gid = (gid_t)atol(temp);
-
-       pdb_set_unix_homedir(sampass, homedir, PDB_SET);
-       
-       DEBUG(10, ("user has %s attributes\n", LDAP_OBJ_POSIXACCOUNT));
-       
-       return True;
-}
-
-#endif
-
-static time_t ldapsam_get_entry_timestamp(
-       struct ldapsam_privates *ldap_state,
-       LDAPMessage * entry)
+static time_t ldapsam_get_entry_timestamp( struct ldapsam_privates *ldap_state, LDAPMessage * entry)
 {
        pstring temp;   
        struct tm tm;
@@ -521,12 +461,12 @@ static time_t ldapsam_get_entry_timestamp(
 }
 
 /**********************************************************************
- Initialize SAM_ACCOUNT from an LDAP query.
+ Initialize struct samu from an LDAP query.
  (Based on init_sam_from_buffer in pdb_tdb.c)
 *********************************************************************/
 
 static BOOL init_sam_from_ldap(struct ldapsam_privates *ldap_state, 
-                               SAM_ACCOUNT * sampass,
+                               struct samu * sampass,
                                LDAPMessage * entry)
 {
        time_t  logon_time,
@@ -552,8 +492,8 @@ static BOOL init_sam_from_ldap(struct ldapsam_privates *ldap_state,
        uint8           smblmpwd[LM_HASH_LEN],
                        smbntpwd[NT_HASH_LEN];
        BOOL            use_samba_attrs = True;
-       uint16          acct_ctrl = 0, 
-                       logon_divs;
+       uint32          acct_ctrl = 0;
+       uint16          logon_divs;
        uint16          bad_password_count = 0, 
                        logon_count = 0;
        uint32 hours_len;
@@ -616,36 +556,12 @@ static BOOL init_sam_from_ldap(struct ldapsam_privates *ldap_state,
                                get_userattr_key2string(ldap_state->schema_ver, LDAP_ATTR_USER_SID), temp)) {
                        pdb_set_user_sid_from_string(sampass, temp, PDB_SET);
                }
-               
-               if (smbldap_get_single_pstring(ldap_state->smbldap_state->ldap_struct, entry, 
-                               get_userattr_key2string(ldap_state->schema_ver, LDAP_ATTR_PRIMARY_GROUP_SID), temp)) {
-                       pdb_set_group_sid_from_string(sampass, temp, PDB_SET);                  
-               } else {
-                       pdb_set_group_sid_from_rid(sampass, DOMAIN_GROUP_RID_USERS, PDB_DEFAULT);
-               }
        } else {
                if (smbldap_get_single_pstring(ldap_state->smbldap_state->ldap_struct, entry,
                                get_userattr_key2string(ldap_state->schema_ver, LDAP_ATTR_USER_RID), temp)) {
                        user_rid = (uint32)atol(temp);
                        pdb_set_user_sid_from_rid(sampass, user_rid, PDB_SET);
                }
-               
-               if (!smbldap_get_single_pstring(ldap_state->smbldap_state->ldap_struct, entry, 
-                               get_userattr_key2string(ldap_state->schema_ver, LDAP_ATTR_PRIMARY_GROUP_RID), temp)) {
-                       pdb_set_group_sid_from_rid(sampass, DOMAIN_GROUP_RID_USERS, PDB_DEFAULT);
-               } else {
-                       uint32 group_rid;
-                       
-                       group_rid = (uint32)atol(temp);
-                       
-                       /* for some reason, we often have 0 as a primary group RID.
-                          Make sure that we treat this just as a 'default' value */
-                          
-                       if ( group_rid > 0 )
-                               pdb_set_group_sid_from_rid(sampass, group_rid, PDB_SET);
-                       else
-                               pdb_set_group_sid_from_rid(sampass, DOMAIN_GROUP_RID_USERS, PDB_DEFAULT);
-               }
        }
 
        if (pdb_get_init_flags(sampass,PDB_USERSID) == PDB_DEFAULT) {
@@ -734,12 +650,13 @@ static BOOL init_sam_from_ldap(struct ldapsam_privates *ldap_state,
                        get_userattr_key2string(ldap_state->schema_ver, LDAP_ATTR_HOME_PATH), homedir)) 
        {
                pdb_set_homedir( sampass, 
-                       talloc_sub_basic(sampass->mem_ctx, username, lp_logon_home()),
+                       talloc_sub_basic(sampass, username, domain,
+                                        lp_logon_home()),
                        PDB_DEFAULT );
        } else {
                pstrcpy( tmpstring, homedir );
                if (expand_explicit) {
-                       standard_sub_basic( username, tmpstring,
+                       standard_sub_basic( username, domain, tmpstring,
                                            sizeof(tmpstring) );
                }
                pdb_set_homedir(sampass, tmpstring, PDB_SET);
@@ -749,12 +666,13 @@ static BOOL init_sam_from_ldap(struct ldapsam_privates *ldap_state,
                        get_userattr_key2string(ldap_state->schema_ver, LDAP_ATTR_LOGON_SCRIPT), logon_script)) 
        {
                pdb_set_logon_script( sampass, 
-                       talloc_sub_basic(sampass->mem_ctx, username, lp_logon_script()), 
+                       talloc_sub_basic(sampass, username, domain,
+                                        lp_logon_script()), 
                        PDB_DEFAULT );
        } else {
                pstrcpy( tmpstring, logon_script );
                if (expand_explicit) {
-                       standard_sub_basic( username, tmpstring,
+                       standard_sub_basic( username, domain, tmpstring,
                                            sizeof(tmpstring) );
                }
                pdb_set_logon_script(sampass, tmpstring, PDB_SET);
@@ -764,12 +682,13 @@ static BOOL init_sam_from_ldap(struct ldapsam_privates *ldap_state,
                        get_userattr_key2string(ldap_state->schema_ver, LDAP_ATTR_PROFILE_PATH), profile_path)) 
        {
                pdb_set_profile_path( sampass, 
-                       talloc_sub_basic( sampass->mem_ctx, username, lp_logon_path()),
+                       talloc_sub_basic( sampass, username, domain,
+                                         lp_logon_path()),
                        PDB_DEFAULT );
        } else {
                pstrcpy( tmpstring, profile_path );
                if (expand_explicit) {
-                       standard_sub_basic( username, tmpstring,
+                       standard_sub_basic( username, domain, tmpstring,
                                            sizeof(tmpstring) );
                }
                pdb_set_profile_path(sampass, tmpstring, PDB_SET);
@@ -817,14 +736,21 @@ static BOOL init_sam_from_ldap(struct ldapsam_privates *ldap_state,
                        pwd_len = sizeof(clear_text_pw);
                        if (pdb_nds_get_password(ldap_state->smbldap_state, user_dn, &pwd_len, clear_text_pw) == LDAP_SUCCESS) {
                                nt_lm_owf_gen(clear_text_pw, smbntpwd, smblmpwd);
-                               if (!pdb_set_lanman_passwd(sampass, smblmpwd, PDB_SET))
+                               if (!pdb_set_lanman_passwd(sampass, smblmpwd, PDB_SET)) {
+                                       SAFE_FREE(user_dn);
                                        return False;
+                               }
                                ZERO_STRUCT(smblmpwd);
-                               if (!pdb_set_nt_passwd(sampass, smbntpwd, PDB_SET))
+                               if (!pdb_set_nt_passwd(sampass, smbntpwd, PDB_SET)) {
+                                       SAFE_FREE(user_dn);
                                        return False;
+                               }
                                ZERO_STRUCT(smbntpwd);
                                use_samba_attrs = False;
                        }
+
+                       SAFE_FREE(user_dn);
+
                } else {
                        DEBUG(0, ("init_sam_from_ldap: failed to get user_dn for '%s'\n", username));
                }
@@ -860,29 +786,30 @@ static BOOL init_sam_from_ldap(struct ldapsam_privates *ldap_state,
        if (pwHistLen > 0){
                uint8 *pwhist = NULL;
                int i;
+               char history_string[MAX_PW_HISTORY_LEN*64];
 
-               /* We can only store (sizeof(pstring)-1)/64 password history entries. */
-               pwHistLen = MIN(pwHistLen, ((sizeof(temp)-1)/64));
+               pwHistLen = MIN(pwHistLen, MAX_PW_HISTORY_LEN);
 
-               if ((pwhist = SMB_MALLOC(pwHistLen * PW_HISTORY_ENTRY_LEN)) == NULL){
+               if ((pwhist = SMB_MALLOC_ARRAY(uint8, pwHistLen * PW_HISTORY_ENTRY_LEN)) == NULL){
                        DEBUG(0, ("init_sam_from_ldap: malloc failed!\n"));
                        return False;
                }
                memset(pwhist, '\0', pwHistLen * PW_HISTORY_ENTRY_LEN);
 
-               if (!smbldap_get_single_pstring (ldap_state->smbldap_state->ldap_struct, entry, 
-                       get_userattr_key2string(ldap_state->schema_ver, LDAP_ATTR_PWD_HISTORY), temp)) {
+               if (!smbldap_get_single_attribute(ldap_state->smbldap_state->ldap_struct, entry,
+                                                 get_userattr_key2string(ldap_state->schema_ver, LDAP_ATTR_PWD_HISTORY),
+                                                 history_string, sizeof(history_string))) {
                        /* leave as default - zeros */
                } else {
                        BOOL hex_failed = False;
                        for (i = 0; i < pwHistLen; i++){
                                /* Get the 16 byte salt. */
-                               if (!pdb_gethexpwd(&temp[i*64], &pwhist[i*PW_HISTORY_ENTRY_LEN])) {
+                               if (!pdb_gethexpwd(&history_string[i*64], &pwhist[i*PW_HISTORY_ENTRY_LEN])) {
                                        hex_failed = True;
                                        break;
                                }
                                /* Get the 16 byte MD5 hash of salt+passwd. */
-                               if (!pdb_gethexpwd(&temp[(i*64)+32],
+                               if (!pdb_gethexpwd(&history_string[(i*64)+32],
                                                &pwhist[(i*PW_HISTORY_ENTRY_LEN)+PW_HISTORY_SALT_LEN])) {
                                        hex_failed = True;
                                        break;
@@ -1003,14 +930,14 @@ static BOOL init_sam_from_ldap(struct ldapsam_privates *ldap_state,
 }
 
 /**********************************************************************
- Initialize the ldap db from a SAM_ACCOUNT. Called on update.
+ Initialize the ldap db from a struct samu. Called on update.
  (Based on init_buffer_from_sam in pdb_tdb.c)
 *********************************************************************/
 
 static BOOL init_ldap_from_sam (struct ldapsam_privates *ldap_state, 
                                LDAPMessage *existing,
-                               LDAPMod *** mods, SAM_ACCOUNT * sampass,
-                               BOOL (*need_update)(const SAM_ACCOUNT *,
+                               LDAPMod *** mods, struct samu * sampass,
+                               BOOL (*need_update)(const struct samu *,
                                                    enum pdb_elements))
 {
        pstring temp;
@@ -1027,24 +954,30 @@ static BOOL init_ldap_from_sam (struct ldapsam_privates *ldap_state,
         * took out adding "objectclass: sambaAccount"
         * do this on a per-mod basis
         */
-       if (need_update(sampass, PDB_USERNAME))
+       if (need_update(sampass, PDB_USERNAME)) {
                smbldap_make_mod(ldap_state->smbldap_state->ldap_struct, existing, mods, 
                              "uid", pdb_get_username(sampass));
+               if (ldap_state->is_nds_ldap) {
+                       smbldap_make_mod(ldap_state->smbldap_state->ldap_struct, existing, mods, 
+                                     "cn", pdb_get_username(sampass));
+                       smbldap_make_mod(ldap_state->smbldap_state->ldap_struct, existing, mods, 
+                                     "sn", pdb_get_username(sampass));
+               }
+       }
 
        DEBUG(2, ("init_ldap_from_sam: Setting entry for user: %s\n", pdb_get_username(sampass)));
 
        /* only update the RID if we actually need to */
        if (need_update(sampass, PDB_USERSID)) {
                fstring sid_string;
-               fstring dom_sid_string;
                const DOM_SID *user_sid = pdb_get_user_sid(sampass);
                
                switch ( ldap_state->schema_ver ) {
                        case SCHEMAVER_SAMBAACCOUNT:
                                if (!sid_peek_check_rid(&ldap_state->domain_sid, user_sid, &rid)) {
                                        DEBUG(1, ("init_ldap_from_sam: User's SID (%s) is not for this domain (%s), cannot add to LDAP!\n", 
-                                               sid_to_string(sid_string, user_sid), 
-                                               sid_to_string(dom_sid_string, &ldap_state->domain_sid)));
+                                                 sid_string_static(user_sid), 
+                                                 sid_string_static(&ldap_state->domain_sid)));
                                        return False;
                                }
                                slprintf(temp, sizeof(temp) - 1, "%i", rid);
@@ -1070,15 +1003,14 @@ static BOOL init_ldap_from_sam (struct ldapsam_privates *ldap_state,
 
        if (need_update(sampass, PDB_GROUPSID)) {
                fstring sid_string;
-               fstring dom_sid_string;
                const DOM_SID *group_sid = pdb_get_group_sid(sampass);
                
                switch ( ldap_state->schema_ver ) {
                        case SCHEMAVER_SAMBAACCOUNT:
                                if (!sid_peek_check_rid(&ldap_state->domain_sid, group_sid, &rid)) {
                                        DEBUG(1, ("init_ldap_from_sam: User's Primary Group SID (%s) is not for this domain (%s), cannot add to LDAP!\n",
-                                               sid_to_string(sid_string, group_sid),
-                                               sid_to_string(dom_sid_string, &ldap_state->domain_sid)));
+                                                 sid_string_static(group_sid),
+                                                 sid_string_static(&ldap_state->domain_sid)));
                                        return False;
                                }
 
@@ -1164,7 +1096,7 @@ static BOOL init_ldap_from_sam (struct ldapsam_privates *ldap_state,
                smbldap_make_mod(ldap_state->smbldap_state->ldap_struct, existing, mods,
                        get_userattr_key2string(ldap_state->schema_ver, LDAP_ATTR_KICKOFF_TIME), temp);
 
-       slprintf (temp, sizeof (temp) - 1, "%li", pdb_get_pass_can_change_time(sampass));
+       slprintf (temp, sizeof (temp) - 1, "%li", pdb_get_pass_can_change_time_noncalc(sampass));
        if (need_update(sampass, PDB_CANCHANGETIME))
                smbldap_make_mod(ldap_state->smbldap_state->ldap_struct, existing, mods,
                        get_userattr_key2string(ldap_state->schema_ver, LDAP_ATTR_PWD_CAN_CHANGE), temp);
@@ -1324,7 +1256,7 @@ static BOOL init_ldap_from_sam (struct ldapsam_privates *ldap_state,
  Connect to LDAP server for password enumeration.
 *********************************************************************/
 
-static NTSTATUS ldapsam_setsampwent(struct pdb_methods *my_methods, BOOL update, uint16 acb_mask)
+static NTSTATUS ldapsam_setsampwent(struct pdb_methods *my_methods, BOOL update, uint32 acb_mask)
 {
        struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
        int rc;
@@ -1392,7 +1324,7 @@ Get the next entry in the LDAP password database.
 *********************************************************************/
 
 static NTSTATUS ldapsam_getsampwent(struct pdb_methods *my_methods,
-                                   SAM_ACCOUNT *user)
+                                   struct samu *user)
 {
        NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
        struct ldapsam_privates *ldap_state =
@@ -1434,10 +1366,10 @@ static void append_attr(TALLOC_CTX *mem_ctx, const char ***attr_list,
 }
 
 /**********************************************************************
-Get SAM_ACCOUNT entry from LDAP by username.
+Get struct samu entry from LDAP by username.
 *********************************************************************/
 
-static NTSTATUS ldapsam_getsampwnam(struct pdb_methods *my_methods, SAM_ACCOUNT *user, const char *sname)
+static NTSTATUS ldapsam_getsampwnam(struct pdb_methods *my_methods, struct samu *user, const char *sname)
 {
        NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
        struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
@@ -1447,11 +1379,11 @@ static NTSTATUS ldapsam_getsampwnam(struct pdb_methods *my_methods, SAM_ACCOUNT
        const char ** attr_list;
        int rc;
        
-       attr_list = get_userattr_list( user->mem_ctx, ldap_state->schema_ver );
-       append_attr(user->mem_ctx, &attr_list,
+       attr_list = get_userattr_list( user, ldap_state->schema_ver );
+       append_attr(user, &attr_list,
                    get_userattr_key2string(ldap_state->schema_ver,
                                            LDAP_ATTR_MOD_TIMESTAMP));
-       append_attr(user->mem_ctx, &attr_list, "uidNumber");
+       append_attr(user, &attr_list, "uidNumber");
        rc = ldapsam_search_suffix_by_name(ldap_state, sname, &result,
                                           attr_list);
        TALLOC_FREE( attr_list );
@@ -1480,7 +1412,7 @@ static NTSTATUS ldapsam_getsampwnam(struct pdb_methods *my_methods, SAM_ACCOUNT
                }
                pdb_set_backend_private_data(user, result, NULL,
                                             my_methods, PDB_CHANGED);
-               talloc_autofree_ldapmsg(user->mem_ctx, result);
+               talloc_autofree_ldapmsg(user, result);
                ret = NT_STATUS_OK;
        } else {
                ldap_msgfree(result);
@@ -1536,10 +1468,10 @@ static int ldapsam_get_ldap_user_by_sid(struct ldapsam_privates *ldap_state,
 }
 
 /**********************************************************************
- Get SAM_ACCOUNT entry from LDAP by SID.
+ Get struct samu entry from LDAP by SID.
 *********************************************************************/
 
-static NTSTATUS ldapsam_getsampwsid(struct pdb_methods *my_methods, SAM_ACCOUNT * user, const DOM_SID *sid)
+static NTSTATUS ldapsam_getsampwsid(struct pdb_methods *my_methods, struct samu * user, const DOM_SID *sid)
 {
        struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
        LDAPMessage *result = NULL;
@@ -1581,29 +1513,24 @@ static NTSTATUS ldapsam_getsampwsid(struct pdb_methods *my_methods, SAM_ACCOUNT
 
        pdb_set_backend_private_data(user, result, NULL,
                                     my_methods, PDB_CHANGED);
-       talloc_autofree_ldapmsg(user->mem_ctx, result);
+       talloc_autofree_ldapmsg(user, result);
        return NT_STATUS_OK;
 }      
 
-static BOOL ldapsam_can_pwchange_exop(struct smbldap_state *ldap_state)
-{
-       return smbldap_has_extension(ldap_state, LDAP_EXOP_MODIFY_PASSWD);
-}
-
 /********************************************************************
  Do the actual modification - also change a plaintext passord if 
  it it set.
 **********************************************************************/
 
 static NTSTATUS ldapsam_modify_entry(struct pdb_methods *my_methods, 
-                                    SAM_ACCOUNT *newpwd, char *dn,
+                                    struct samu *newpwd, char *dn,
                                     LDAPMod **mods, int ldap_op, 
-                                    BOOL (*need_update)(const SAM_ACCOUNT *, enum pdb_elements))
+                                    BOOL (*need_update)(const struct samu *, enum pdb_elements))
 {
        struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
        int rc;
        
-       if (!my_methods || !newpwd || !dn) {
+       if (!newpwd || !dn) {
                return NT_STATUS_INVALID_PARAMETER;
        }
        
@@ -1612,10 +1539,16 @@ static NTSTATUS ldapsam_modify_entry(struct pdb_methods *my_methods,
                /* may be password change below however */
        } else {
                switch(ldap_op) {
-                       case LDAP_MOD_ADD: 
-                               smbldap_set_mod(&mods, LDAP_MOD_ADD, 
-                                               "objectclass", 
-                                               LDAP_OBJ_ACCOUNT);
+                       case LDAP_MOD_ADD:
+                               if (ldap_state->is_nds_ldap) {
+                                       smbldap_set_mod(&mods, LDAP_MOD_ADD, 
+                                                       "objectclass", 
+                                                       "inetOrgPerson");
+                               } else {
+                                       smbldap_set_mod(&mods, LDAP_MOD_ADD, 
+                                                       "objectclass", 
+                                                       LDAP_OBJ_ACCOUNT);
+                               }
                                rc = smbldap_add(ldap_state->smbldap_state, 
                                                 dn, mods);
                                break;
@@ -1646,7 +1579,9 @@ static NTSTATUS ldapsam_modify_entry(struct pdb_methods *my_methods,
                char *utf8_dn;
 
                if (!ldap_state->is_nds_ldap) {
-                       if (!ldapsam_can_pwchange_exop(ldap_state->smbldap_state)) {
+
+                       if (!smbldap_has_extension(ldap_state->smbldap_state->ldap_struct, 
+                                                  LDAP_EXOP_MODIFY_PASSWD)) {
                                DEBUG(2, ("ldap password change requested, but LDAP "
                                          "server does not support it -- ignoring\n"));
                                return NT_STATUS_OK;
@@ -1658,12 +1593,14 @@ static NTSTATUS ldapsam_modify_entry(struct pdb_methods *my_methods,
                }
 
                if (push_utf8_allocate(&utf8_dn, dn) == (size_t)-1) {
+                       SAFE_FREE(utf8_password);
                        return NT_STATUS_NO_MEMORY;
                }
 
                if ((ber = ber_alloc_t(LBER_USE_DER))==NULL) {
                        DEBUG(0,("ber_alloc_t returns NULL\n"));
                        SAFE_FREE(utf8_password);
+                       SAFE_FREE(utf8_dn);
                        return NT_STATUS_UNSUCCESSFUL;
                }
 
@@ -1731,7 +1668,7 @@ static NTSTATUS ldapsam_modify_entry(struct pdb_methods *my_methods,
 *********************************************************************/
 
 static NTSTATUS ldapsam_delete_sam_account(struct pdb_methods *my_methods,
-                                          SAM_ACCOUNT * sam_acct)
+                                          struct samu * sam_acct)
 {
        struct ldapsam_privates *priv =
                (struct ldapsam_privates *)my_methods->private_data;
@@ -1792,17 +1729,17 @@ static NTSTATUS ldapsam_delete_sam_account(struct pdb_methods *my_methods,
  we need LDAP modification.
 *********************************************************************/
 
-static BOOL element_is_changed(const SAM_ACCOUNT *sampass,
+static BOOL element_is_changed(const struct samu *sampass,
                               enum pdb_elements element)
 {
        return IS_SAM_CHANGED(sampass, element);
 }
 
 /**********************************************************************
- Update SAM_ACCOUNT.
+ Update struct samu.
 *********************************************************************/
 
-static NTSTATUS ldapsam_update_sam_account(struct pdb_methods *my_methods, SAM_ACCOUNT * newpwd)
+static NTSTATUS ldapsam_update_sam_account(struct pdb_methods *my_methods, struct samu * newpwd)
 {
        NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
        struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
@@ -1813,9 +1750,12 @@ static NTSTATUS ldapsam_update_sam_account(struct pdb_methods *my_methods, SAM_A
        LDAPMod **mods = NULL;
        const char **attr_list;
 
-       result = pdb_get_backend_private_data(newpwd, my_methods);
+       result = (LDAPMessage *)pdb_get_backend_private_data(newpwd, my_methods);
        if (!result) {
                attr_list = get_userattr_list(NULL, ldap_state->schema_ver);
+               if (pdb_get_username(newpwd) == NULL) {
+                       return NT_STATUS_INVALID_PARAMETER;
+               }
                rc = ldapsam_search_suffix_by_name(ldap_state, pdb_get_username(newpwd), &result, attr_list );
                TALLOC_FREE( attr_list );
                if (rc != LDAP_SUCCESS) {
@@ -1823,7 +1763,7 @@ static NTSTATUS ldapsam_update_sam_account(struct pdb_methods *my_methods, SAM_A
                }
                pdb_set_backend_private_data(newpwd, result, NULL,
                                             my_methods, PDB_CHANGED);
-               talloc_autofree_ldapmsg(newpwd->mem_ctx, result);
+               talloc_autofree_ldapmsg(newpwd, result);
        }
 
        if (ldap_count_entries(ldap_state->smbldap_state->ldap_struct, result) == 0) {
@@ -1859,6 +1799,19 @@ static NTSTATUS ldapsam_update_sam_account(struct pdb_methods *my_methods, SAM_A
        ldap_mods_free(mods,True);
        SAFE_FREE(dn);
 
+       /*
+        * We need to set the backend private data to NULL here. For example
+        * setuserinfo level 25 does a pdb_update_sam_account twice on the
+        * same one, and with the explicit delete / add logic for attribute
+        * values the second time we would use the wrong "old" value which
+        * does not exist in LDAP anymore. Thus the LDAP server would refuse
+        * the update.
+        * The existing LDAPMessage is still being auto-freed by the
+        * destructor.
+        */
+       pdb_set_backend_private_data(newpwd, NULL, NULL, my_methods,
+                                    PDB_CHANGED);
+
        if (!NT_STATUS_IS_OK(ret)) {
                return ret;
        }
@@ -1869,17 +1822,18 @@ static NTSTATUS ldapsam_update_sam_account(struct pdb_methods *my_methods, SAM_A
 }
 
 /***************************************************************************
- Renames a SAM_ACCOUNT
+ Renames a struct samu
  - The "rename user script" has full responsibility for changing everything
 ***************************************************************************/
 
 static NTSTATUS ldapsam_rename_sam_account(struct pdb_methods *my_methods,
-                                          SAM_ACCOUNT *old_acct, 
+                                          struct samu *old_acct, 
                                           const char *newname)
 {
        const char *oldname;
        int rc;
        pstring rename_script;
+       fstring oldname_lower, newname_lower;
 
        if (!old_acct) {
                DEBUG(0, ("ldapsam_rename_sam_account: old_acct was NULL!\n"));
@@ -1901,13 +1855,27 @@ static NTSTATUS ldapsam_rename_sam_account(struct pdb_methods *my_methods,
        DEBUG (3, ("ldapsam_rename_sam_account: Renaming user %s to %s.\n", 
                   oldname, newname));
 
-       pstring_sub(rename_script, "%unew", newname);
-       pstring_sub(rename_script, "%uold", oldname);
+       /* We have to allow the account name to end with a '$'.
+          Also, follow the semantics in _samr_create_user() and lower case the
+          posix name but preserve the case in passdb */
+
+       fstrcpy( oldname_lower, oldname );
+       strlower_m( oldname_lower );
+       fstrcpy( newname_lower, newname );
+       strlower_m( newname_lower );
+       string_sub2(rename_script, "%unew", newname_lower, sizeof(pstring), 
+                   True, False, True);
+       string_sub2(rename_script, "%uold", oldname_lower, sizeof(pstring), 
+                   True, False, True);
        rc = smbrun(rename_script, NULL);
 
        DEBUG(rc ? 0 : 3,("Running the command `%s' gave %d\n", 
                          rename_script, rc));
 
+       if (rc == 0) {
+               smb_nscd_flush_user_cache();
+       }
+
        if (rc)
                return NT_STATUS_UNSUCCESSFUL;
 
@@ -1919,7 +1887,7 @@ static NTSTATUS ldapsam_rename_sam_account(struct pdb_methods *my_methods,
  we need LDAP modification.
  *********************************************************************/
 
-static BOOL element_is_set_or_changed(const SAM_ACCOUNT *sampass,
+static BOOL element_is_set_or_changed(const struct samu *sampass,
                                      enum pdb_elements element)
 {
        return (IS_SAM_SET(sampass, element) ||
@@ -1927,10 +1895,10 @@ static BOOL element_is_set_or_changed(const SAM_ACCOUNT *sampass,
 }
 
 /**********************************************************************
- Add SAM_ACCOUNT to LDAP.
+ Add struct samu to LDAP.
 *********************************************************************/
 
-static NTSTATUS ldapsam_add_sam_account(struct pdb_methods *my_methods, SAM_ACCOUNT * newpwd)
+static NTSTATUS ldapsam_add_sam_account(struct pdb_methods *my_methods, struct samu * newpwd)
 {
        NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
        struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
@@ -2054,7 +2022,7 @@ static NTSTATUS ldapsam_add_sam_account(struct pdb_methods *my_methods, SAM_ACCO
                num_result = ldap_count_entries(ldap_state->smbldap_state->ldap_struct, result);
                
                if (num_result > 1) {
-                       DEBUG (0, ("ldapsam_add_sam_account: More than one user with that uid exists: bailing out!\n"));
+                       DEBUG (0, ("ldapsam_add_sam_account: More than one user with specified Sid exists: bailing out!\n"));
                        TALLOC_FREE( attr_list );
                        ldap_msgfree(result);
                        return NT_STATUS_UNSUCCESSFUL;
@@ -2194,7 +2162,7 @@ static BOOL init_group_from_ldap(struct ldapsam_privates *ldap_state,
                        get_attr_key2string( groupmap_attr_list, LDAP_ATTR_GROUP_TYPE)));
                return False;
        }
-       map->sid_name_use = (enum SID_NAME_USE)atol(temp);
+       map->sid_name_use = (enum lsa_SidType)atol(temp);
 
        if ((map->sid_name_use < SID_NAME_USER) ||
                        (map->sid_name_use > SID_NAME_UNKNOWN)) {
@@ -2334,25 +2302,6 @@ static NTSTATUS ldapsam_getgrnam(struct pdb_methods *methods, GROUP_MAP *map,
        return ldapsam_getgroup(methods, filter, map);
 }
 
-static void add_rid_to_array_unique(TALLOC_CTX *mem_ctx,
-                                   uint32 rid, uint32 **pp_rids, size_t *p_num)
-{
-       size_t i;
-
-       for (i=0; i<*p_num; i++) {
-               if ((*pp_rids)[i] == rid)
-                       return;
-       }
-       
-       *pp_rids = TALLOC_REALLOC_ARRAY(mem_ctx, *pp_rids, uint32, *p_num+1);
-
-       if (*pp_rids == NULL)
-               return;
-
-       (*pp_rids)[*p_num] = rid;
-       *p_num += 1;
-}
-
 static BOOL ldapsam_extract_rid_from_entry(LDAP *ldap_struct,
                                           LDAPMessage *entry,
                                           const DOM_SID *domain_sid,
@@ -2395,173 +2344,191 @@ static NTSTATUS ldapsam_enum_group_members(struct pdb_methods *methods,
        struct ldapsam_privates *ldap_state =
                (struct ldapsam_privates *)methods->private_data;
        struct smbldap_state *conn = ldap_state->smbldap_state;
-       pstring filter;
-       int rc, count;
-       LDAPMessage *msg = NULL;
+       const char *id_attrs[] = { "memberUid", "gidNumber", NULL };
+       const char *sid_attrs[] = { "sambaSID", NULL };
+       NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
+       LDAPMessage *result = NULL;
        LDAPMessage *entry;
+       char *filter;
        char **values = NULL;
        char **memberuid;
-       char *sid_filter = NULL;
-       char *tmp;
-       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
+       char *gidstr;
+       int rc, count;
 
        *pp_member_rids = NULL;
        *p_num_members = 0;
 
-       pstr_sprintf(filter,
-                    "(&(objectClass=sambaSamAccount)"
-                    "(sambaPrimaryGroupSid=%s))",
-                    sid_string_static(group));
-
-       {
-               const char *attrs[] = { "sambaSID", NULL };
-               rc = smbldap_search(conn, lp_ldap_user_suffix(),
-                                   LDAP_SCOPE_SUBTREE, filter, attrs, 0,
-                                   &msg);
-       }
-
-       if (rc != LDAP_SUCCESS)
+       filter = talloc_asprintf(mem_ctx,
+                                "(&(objectClass=%s)"
+                                "(objectClass=%s)"
+                                "(sambaSID=%s))",
+                                LDAP_OBJ_POSIXGROUP,
+                                LDAP_OBJ_GROUPMAP,
+                                sid_string_static(group));
+       if (filter == NULL) {
+               ret = NT_STATUS_NO_MEMORY;
                goto done;
-
-       for (entry = ldap_first_entry(conn->ldap_struct, msg);
-            entry != NULL;
-            entry = ldap_next_entry(conn->ldap_struct, entry))
-       {
-               uint32 rid;
-
-               if (!ldapsam_extract_rid_from_entry(conn->ldap_struct,
-                                                   entry,
-                                                   get_global_sam_sid(),
-                                                   &rid)) {
-                       DEBUG(2, ("Could not find sid from ldap entry\n"));
-                       continue;
-               }
-
-               add_rid_to_array_unique(mem_ctx, rid, pp_member_rids,
-                                       p_num_members);
        }
 
-       if (msg != NULL)
-               ldap_msgfree(msg);
-
-       pstr_sprintf(filter,
-                    "(&(objectClass=sambaGroupMapping)"
-                    "(objectClass=posixGroup)"
-                    "(sambaSID=%s))",
-                    sid_string_static(group));
-
-       {
-               const char *attrs[] = { "memberUid", NULL };
-               rc = smbldap_search(conn, lp_ldap_user_suffix(),
-                                   LDAP_SCOPE_SUBTREE, filter, attrs, 0,
-                                   &msg);
-       }
+       rc = smbldap_search(conn, lp_ldap_group_suffix(),
+                           LDAP_SCOPE_SUBTREE, filter, id_attrs, 0,
+                           &result);
 
        if (rc != LDAP_SUCCESS)
                goto done;
 
-       count = ldap_count_entries(conn->ldap_struct, msg);
+       talloc_autofree_ldapmsg(mem_ctx, result);
+
+       count = ldap_count_entries(conn->ldap_struct, result);
 
        if (count > 1) {
                DEBUG(1, ("Found more than one groupmap entry for %s\n",
                          sid_string_static(group)));
+               ret = NT_STATUS_INTERNAL_DB_CORRUPTION;
                goto done;
        }
 
        if (count == 0) {
-               result = NT_STATUS_OK;
+               ret = NT_STATUS_NO_SUCH_GROUP;
                goto done;
        }
 
-       entry = ldap_first_entry(conn->ldap_struct, msg);
+       entry = ldap_first_entry(conn->ldap_struct, result);
        if (entry == NULL)
                goto done;
 
-       values = ldap_get_values(conn->ldap_struct, msg, "memberUid");
-       if (values == NULL) {
-               result = NT_STATUS_OK;
+       gidstr = smbldap_talloc_single_attribute(priv2ld(ldap_state), entry, "gidNumber", mem_ctx);
+       if (!gidstr) {
+               DEBUG (0, ("ldapsam_enum_group_members: Unable to find the group's gid!\n"));
+               ret = NT_STATUS_INTERNAL_DB_CORRUPTION;
                goto done;
        }
 
-       sid_filter = SMB_STRDUP("(&(objectClass=sambaSamAccount)(|");
-       if (sid_filter == NULL) {
-               result = NT_STATUS_NO_MEMORY;
-               goto done;
-       }
+       values = ldap_get_values(conn->ldap_struct, entry, "memberUid");
+
+       if (values) {
 
-       for (memberuid = values; *memberuid != NULL; memberuid += 1) {
-               tmp = sid_filter;
-               asprintf(&sid_filter, "%s(uid=%s)", tmp, *memberuid);
-               free(tmp);
-               if (sid_filter == NULL) {
-                       result = NT_STATUS_NO_MEMORY;
+               filter = talloc_asprintf(mem_ctx, "(&(objectClass=%s)(|", LDAP_OBJ_SAMBASAMACCOUNT);
+               if (filter == NULL) {
+                       ret = NT_STATUS_NO_MEMORY;
                        goto done;
                }
-       }
 
-       tmp = sid_filter;
-       asprintf(&sid_filter, "%s))", sid_filter);
-       free(tmp);
-       if (sid_filter == NULL) {
-               result = NT_STATUS_NO_MEMORY;
-               goto done;
-       }
+               for (memberuid = values; *memberuid != NULL; memberuid += 1) {
+                       filter = talloc_asprintf_append(filter, "(uid=%s)", *memberuid);
+                       if (filter == NULL) {
+                               ret = NT_STATUS_NO_MEMORY;
+                               goto done;
+                       }
+               }
+
+               filter = talloc_asprintf_append(filter, "))");
+               if (filter == NULL) {
+                       ret = NT_STATUS_NO_MEMORY;
+                       goto done;
+               }
 
-       {
-               const char *attrs[] = { "sambaSID", NULL };
                rc = smbldap_search(conn, lp_ldap_user_suffix(),
-                                   LDAP_SCOPE_SUBTREE, sid_filter, attrs, 0,
-                                   &msg);
+                                   LDAP_SCOPE_SUBTREE, filter, sid_attrs, 0,
+                                   &result);
+
+               if (rc != LDAP_SUCCESS)
+                       goto done;
+
+               count = ldap_count_entries(conn->ldap_struct, result);
+               DEBUG(10,("ldapsam_enum_group_members: found %d accounts\n", count));
+
+               talloc_autofree_ldapmsg(mem_ctx, result);
+
+               for (entry = ldap_first_entry(conn->ldap_struct, result);
+                    entry != NULL;
+                    entry = ldap_next_entry(conn->ldap_struct, entry))
+               {
+                       char *sidstr;
+                       DOM_SID sid;
+                       uint32 rid;
+
+                       sidstr = smbldap_talloc_single_attribute(conn->ldap_struct,
+                                                                entry, "sambaSID",
+                                                                mem_ctx);
+                       if (!sidstr) {
+                               DEBUG(0, ("Severe DB error, sambaSamAccount can't miss "
+                                         "the sambaSID attribute\n"));
+                               ret = NT_STATUS_INTERNAL_DB_CORRUPTION;
+                               goto done;
+                       }
+
+                       if (!string_to_sid(&sid, sidstr))
+                               goto done;
+
+                       if (!sid_check_is_in_our_domain(&sid)) {
+                               DEBUG(0, ("Inconsistent SAM -- group member uid not "
+                                         "in our domain\n"));
+                               ret = NT_STATUS_INTERNAL_DB_CORRUPTION;
+                               goto done;
+                       }
+
+                       sid_peek_rid(&sid, &rid);
+
+                       if (!add_rid_to_array_unique(mem_ctx, rid, pp_member_rids,
+                                               p_num_members)) {
+                               ret = NT_STATUS_NO_MEMORY;
+                               goto done;
+                       }
+               }
        }
 
+       filter = talloc_asprintf(mem_ctx,
+                                "(&(objectClass=%s)"
+                                "(gidNumber=%s))",
+                                LDAP_OBJ_SAMBASAMACCOUNT,
+                                gidstr);
+
+       rc = smbldap_search(conn, lp_ldap_user_suffix(),
+                           LDAP_SCOPE_SUBTREE, filter, sid_attrs, 0,
+                           &result);
+
        if (rc != LDAP_SUCCESS)
                goto done;
 
-       for (entry = ldap_first_entry(conn->ldap_struct, msg);
+       talloc_autofree_ldapmsg(mem_ctx, result);
+
+       for (entry = ldap_first_entry(conn->ldap_struct, result);
             entry != NULL;
             entry = ldap_next_entry(conn->ldap_struct, entry))
        {
-               fstring str;
-               DOM_SID sid;
                uint32 rid;
 
-               if (!smbldap_get_single_attribute(conn->ldap_struct,
-                                                 entry, "sambaSID",
-                                                 str, sizeof(str)-1))
-                       continue;
-
-               if (!string_to_sid(&sid, str))
+               if (!ldapsam_extract_rid_from_entry(conn->ldap_struct,
+                                                   entry,
+                                                   get_global_sam_sid(),
+                                                   &rid)) {
+                       DEBUG(0, ("Severe DB error, sambaSamAccount can't miss "
+                                 "the sambaSID attribute\n"));
+                       ret = NT_STATUS_INTERNAL_DB_CORRUPTION;
                        goto done;
-
-               if (!sid_check_is_in_our_domain(&sid)) {
-                       DEBUG(1, ("Inconsistent SAM -- group member uid not "
-                                 "in our domain\n"));
-                       continue;
                }
 
-               sid_peek_rid(&sid, &rid);
-
-               add_rid_to_array_unique(mem_ctx, rid, pp_member_rids,
-                                       p_num_members);
+               if (!add_rid_to_array_unique(mem_ctx, rid, pp_member_rids,
+                                       p_num_members)) {
+                       ret = NT_STATUS_NO_MEMORY;
+                       goto done;
+               }
        }
 
-       result = NT_STATUS_OK;
+       ret = NT_STATUS_OK;
        
  done:
-       SAFE_FREE(sid_filter);
 
-       if (values != NULL)
+       if (values)
                ldap_value_free(values);
 
-       if (msg != NULL)
-               ldap_msgfree(msg);
-
-       return result;
+       return ret;
 }
 
 static NTSTATUS ldapsam_enum_group_memberships(struct pdb_methods *methods,
                                               TALLOC_CTX *mem_ctx,
-                                              SAM_ACCOUNT *user,
+                                              struct samu *user,
                                               DOM_SID **pp_sids,
                                               gid_t **pp_gids,
                                               size_t *p_num_groups)
@@ -2569,39 +2536,86 @@ static NTSTATUS ldapsam_enum_group_memberships(struct pdb_methods *methods,
        struct ldapsam_privates *ldap_state =
                (struct ldapsam_privates *)methods->private_data;
        struct smbldap_state *conn = ldap_state->smbldap_state;
-       pstring filter;
+       char *filter;
        const char *attrs[] = { "gidNumber", "sambaSID", NULL };
        char *escape_name;
-       int rc;
-       LDAPMessage *msg = NULL;
+       int rc, count;
+       LDAPMessage *result = NULL;
        LDAPMessage *entry;
-       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
+       NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
        size_t num_sids, num_gids;
-       gid_t primary_gid;
+       char *gidstr;
+       gid_t primary_gid = -1;
 
        *pp_sids = NULL;
        num_sids = 0;
 
-       if (!sid_to_gid(pdb_get_group_sid(user), &primary_gid)) {
-               DEBUG(1, ("sid_to_gid failed for user's primary group\n"));
-               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       if (pdb_get_username(user) == NULL) {
+               return NT_STATUS_INVALID_PARAMETER;
        }
 
        escape_name = escape_ldap_string_alloc(pdb_get_username(user));
-
        if (escape_name == NULL)
                return NT_STATUS_NO_MEMORY;
 
-       pstr_sprintf(filter, "(&(objectClass=posixGroup)"
-                    "(|(memberUid=%s)(gidNumber=%d)))",
-                    escape_name, primary_gid);
+       /* retrieve the users primary gid */
+       filter = talloc_asprintf(mem_ctx,
+                                "(&(objectClass=%s)(uid=%s))",
+                                LDAP_OBJ_SAMBASAMACCOUNT,
+                                escape_name);
+       if (filter == NULL) {
+               ret = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
+
+       rc = smbldap_search(conn, lp_ldap_user_suffix(),
+                           LDAP_SCOPE_SUBTREE, filter, attrs, 0, &result);
+
+       if (rc != LDAP_SUCCESS)
+               goto done;
+
+       talloc_autofree_ldapmsg(mem_ctx, result);
+
+       count = ldap_count_entries(priv2ld(ldap_state), result);
+
+       switch (count) {
+       case 0: 
+               DEBUG(1, ("User account [%s] not found!\n", pdb_get_username(user)));
+               ret = NT_STATUS_NO_SUCH_USER;
+               goto done;
+       case 1:
+               entry = ldap_first_entry(priv2ld(ldap_state), result);
+
+               gidstr = smbldap_talloc_single_attribute(priv2ld(ldap_state), entry, "gidNumber", mem_ctx);
+               if (!gidstr) {
+                       DEBUG (1, ("Unable to find the member's gid!\n"));
+                       ret = NT_STATUS_INTERNAL_DB_CORRUPTION;
+                       goto done;
+               }
+               primary_gid = strtoul(gidstr, NULL, 10);
+               break;
+       default:
+               DEBUG(1, ("found more than one accoutn with the same user name ?!\n"));
+               ret = NT_STATUS_INTERNAL_DB_CORRUPTION;
+               goto done;
+       }
+
+       filter = talloc_asprintf(mem_ctx,
+                                "(&(objectClass=%s)(|(memberUid=%s)(gidNumber=%d)))",
+                                LDAP_OBJ_POSIXGROUP, escape_name, primary_gid);
+       if (filter == NULL) {
+               ret = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
 
        rc = smbldap_search(conn, lp_ldap_group_suffix(),
-                           LDAP_SCOPE_SUBTREE, filter, attrs, 0, &msg);
+                           LDAP_SCOPE_SUBTREE, filter, attrs, 0, &result);
 
        if (rc != LDAP_SUCCESS)
                goto done;
 
+       talloc_autofree_ldapmsg(mem_ctx, result);
+
        num_gids = 0;
        *pp_gids = NULL;
 
@@ -2610,13 +2624,19 @@ static NTSTATUS ldapsam_enum_group_memberships(struct pdb_methods *methods,
 
        /* We need to add the primary group as the first gid/sid */
 
-       add_gid_to_array_unique(mem_ctx, primary_gid, pp_gids, &num_gids);
+       if (!add_gid_to_array_unique(mem_ctx, primary_gid, pp_gids, &num_gids)) {
+               ret = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
 
        /* This sid will be replaced later */
 
-       add_sid_to_array_unique(mem_ctx, &global_sid_NULL, pp_sids, &num_sids);
+       if (!add_sid_to_array_unique(mem_ctx, &global_sid_NULL, pp_sids, &num_sids)) {
+               ret = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
 
-       for (entry = ldap_first_entry(conn->ldap_struct, msg);
+       for (entry = ldap_first_entry(conn->ldap_struct, result);
             entry != NULL;
             entry = ldap_next_entry(conn->ldap_struct, entry))
        {
@@ -2646,10 +2666,16 @@ static NTSTATUS ldapsam_enum_group_memberships(struct pdb_methods *methods,
                if (gid == primary_gid) {
                        sid_copy(&(*pp_sids)[0], &sid);
                } else {
-                       add_gid_to_array_unique(mem_ctx, gid, pp_gids,
-                                               &num_gids);
-                       add_sid_to_array_unique(mem_ctx, &sid, pp_sids,
-                                               &num_sids);
+                       if (!add_gid_to_array_unique(mem_ctx, gid, pp_gids,
+                                               &num_gids)) {
+                               ret = NT_STATUS_NO_MEMORY;
+                               goto done;
+                       }
+                       if (!add_sid_to_array_unique(mem_ctx, &sid, pp_sids,
+                                               &num_sids)) {
+                               ret = NT_STATUS_NO_MEMORY;
+                               goto done;
+                       }
                }
        }
 
@@ -2661,15 +2687,12 @@ static NTSTATUS ldapsam_enum_group_memberships(struct pdb_methods *methods,
 
        *p_num_groups = num_sids;
 
-       result = NT_STATUS_OK;
+       ret = NT_STATUS_OK;
 
  done:
 
        SAFE_FREE(escape_name);
-       if (msg != NULL)
-               ldap_msgfree(msg);
-
-       return result;
+       return ret;
 }
 
 /**********************************************************************
@@ -2784,19 +2807,10 @@ static NTSTATUS ldapsam_add_group_mapping_entry(struct pdb_methods *methods,
                break;
 
        case SID_NAME_ALIAS:
-               if (!sid_check_is_in_our_domain(&map->sid)) {
-                       DEBUG(3, ("Refusing to map sid %s as an alias, not "
-                                 "in our domain\n",
-                                 sid_string_static(&map->sid)));
-                       result = NT_STATUS_INVALID_PARAMETER;
-                       goto done;
-               }
-               break;
-
-       case SID_NAME_WKN_GRP:
-               if (!sid_check_is_in_builtin(&map->sid)) {
-                       DEBUG(3, ("Refusing to map sid %s as an alias, not "
-                                 "in builtin domain\n",
+               if (!sid_check_is_in_our_domain(&map->sid) 
+                       && !sid_check_is_in_builtin(&map->sid) ) 
+               {
+                       DEBUG(3, ("Refusing to map sid %s as an alias, not in our domain\n",
                                  sid_string_static(&map->sid)));
                        result = NT_STATUS_INVALID_PARAMETER;
                        goto done;
@@ -2894,9 +2908,10 @@ static NTSTATUS ldapsam_update_group_mapping_entry(struct pdb_methods *methods,
        /* Make 100% sure that sid, gid and type are not changed by looking up
         * exactly the values we're given in LDAP. */
 
-       filter = talloc_asprintf(mem_ctx, "(&(objectClass=sambaGroupMapping)"
+       filter = talloc_asprintf(mem_ctx, "(&(objectClass=%s)"
                                 "(sambaSid=%s)(gidNumber=%u)"
                                 "(sambaGroupType=%d))",
+                                LDAP_OBJ_GROUPMAP,
                                 sid_string_static(&map->sid), map->gid,
                                 map->sid_name_use);
        if (filter == NULL) {
@@ -3113,13 +3128,12 @@ static NTSTATUS ldapsam_getsamgrent(struct pdb_methods *my_methods,
  *********************************************************************/
 
 static NTSTATUS ldapsam_enum_group_mapping(struct pdb_methods *methods,
-                                          enum SID_NAME_USE sid_name_use,
+                                          const DOM_SID *domsid, enum lsa_SidType sid_name_use,
                                           GROUP_MAP **pp_rmap,
                                           size_t *p_num_entries,
                                           BOOL unix_only)
 {
        GROUP_MAP map;
-       GROUP_MAP *mapt;
        size_t entries = 0;
 
        *p_num_entries = 0;
@@ -3144,17 +3158,14 @@ static NTSTATUS ldapsam_enum_group_mapping(struct pdb_methods *methods,
                        continue;
                }
 
-               mapt=SMB_REALLOC_ARRAY((*pp_rmap), GROUP_MAP, entries+1);
-               if (!mapt) {
+               (*pp_rmap)=SMB_REALLOC_ARRAY((*pp_rmap), GROUP_MAP, entries+1);
+               if (!(*pp_rmap)) {
                        DEBUG(0,("ldapsam_enum_group_mapping: Unable to "
                                 "enlarge group map!\n"));
-                       SAFE_FREE(*pp_rmap);
                        return NT_STATUS_UNSUCCESSFUL;
                }
-               else
-                       (*pp_rmap) = mapt;
 
-               mapt[entries] = map;
+               (*pp_rmap)[entries] = map;
 
                entries += 1;
 
@@ -3179,12 +3190,12 @@ static NTSTATUS ldapsam_modify_aliasmem(struct pdb_methods *methods,
        int count;
        LDAPMod **mods = NULL;
        int rc;
-       enum SID_NAME_USE type = SID_NAME_USE_NONE;
+       enum lsa_SidType type = SID_NAME_USE_NONE;
 
        pstring filter;
 
        if (sid_check_is_in_builtin(alias)) {
-               type = SID_NAME_WKN_GRP;
+               type = SID_NAME_ALIAS;
        }
 
        if (sid_check_is_in_our_domain(alias)) {
@@ -3291,13 +3302,13 @@ static NTSTATUS ldapsam_enum_aliasmem(struct pdb_methods *methods,
        int i;
        pstring filter;
        size_t num_members = 0;
-       enum SID_NAME_USE type = SID_NAME_USE_NONE;
+       enum lsa_SidType type = SID_NAME_USE_NONE;
 
        *pp_members = NULL;
        *p_num_members = 0;
 
        if (sid_check_is_in_builtin(alias)) {
-               type = SID_NAME_WKN_GRP;
+               type = SID_NAME_ALIAS;
        }
 
        if (sid_check_is_in_our_domain(alias)) {
@@ -3361,7 +3372,11 @@ static NTSTATUS ldapsam_enum_aliasmem(struct pdb_methods *methods,
                if (!string_to_sid(&member, values[i]))
                        continue;
 
-               add_sid_to_array(NULL, &member, pp_members, &num_members);
+               if (!add_sid_to_array(NULL, &member, pp_members, &num_members)) {
+                       ldap_value_free(values);
+                       ldap_msgfree(result);
+                       return NT_STATUS_NO_MEMORY;
+               }
        }
 
        *p_num_members = num_members;
@@ -3390,10 +3405,10 @@ static NTSTATUS ldapsam_alias_memberships(struct pdb_methods *methods,
        int i;
        int rc;
        char *filter;
-       enum SID_NAME_USE type = SID_NAME_USE_NONE;
+       enum lsa_SidType type = SID_NAME_USE_NONE;
 
        if (sid_check_is_builtin(domain_sid)) {
-               type = SID_NAME_WKN_GRP;
+               type = SID_NAME_ALIAS;
        }
 
        if (sid_check_is_domain(domain_sid)) {
@@ -3417,6 +3432,10 @@ static NTSTATUS ldapsam_alias_memberships(struct pdb_methods *methods,
 
        filter = talloc_asprintf(mem_ctx, "%s))", filter);
 
+       if (filter == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
        rc = smbldap_search(ldap_state->smbldap_state, lp_ldap_group_suffix(),
                            LDAP_SCOPE_SUBTREE, filter, attrs, 0, &result);
 
@@ -3445,10 +3464,13 @@ static NTSTATUS ldapsam_alias_memberships(struct pdb_methods *methods,
                if (!sid_peek_check_rid(domain_sid, &sid, &rid))
                        continue;
 
-               add_rid_to_array_unique(mem_ctx, rid, pp_alias_rids,
-                                       p_num_alias_rids);
-       }
-
+               if (!add_rid_to_array_unique(mem_ctx, rid, pp_alias_rids,
+                                       p_num_alias_rids)) {
+                       ldap_msgfree(result);
+                       return NT_STATUS_NO_MEMORY;
+               }
+       }
+
        ldap_msgfree(result);
        return NT_STATUS_OK;
 }
@@ -3466,8 +3488,6 @@ static NTSTATUS ldapsam_set_account_policy_in_ldap(struct pdb_methods *methods,
        struct ldapsam_privates *ldap_state =
                (struct ldapsam_privates *)methods->private_data;
 
-       const char *attrs[2];
-
        DEBUG(10,("ldapsam_set_account_policy_in_ldap\n"));
 
        if (!ldap_state->domain_dn) {
@@ -3481,9 +3501,6 @@ static NTSTATUS ldapsam_set_account_policy_in_ldap(struct pdb_methods *methods,
                return ntstatus;
        }
 
-       attrs[0] = policy_attr;
-       attrs[1] = NULL;
-
        slprintf(value_string, sizeof(value_string) - 1, "%i", value);
 
        smbldap_set_mod(&mods, LDAP_MOD_REPLACE, policy_attr, value_string);
@@ -3509,11 +3526,6 @@ static NTSTATUS ldapsam_set_account_policy_in_ldap(struct pdb_methods *methods,
 static NTSTATUS ldapsam_set_account_policy(struct pdb_methods *methods,
                                           int policy_index, uint32 value)
 {
-       if (!account_policy_migrated(False)) {
-               return (account_policy_set(policy_index, value)) ?
-                       NT_STATUS_OK : NT_STATUS_UNSUCCESSFUL;
-       }
-
        return ldapsam_set_account_policy_in_ldap(methods, policy_index,
                                                  value);
 }
@@ -3602,11 +3614,6 @@ static NTSTATUS ldapsam_get_account_policy(struct pdb_methods *methods,
 {
        NTSTATUS ntstatus = NT_STATUS_UNSUCCESSFUL;
 
-       if (!account_policy_migrated(False)) {
-               return (account_policy_get(policy_index, value))
-                       ? NT_STATUS_OK : NT_STATUS_UNSUCCESSFUL;
-       }
-
        if (cache_account_policy_get(policy_index, value)) {
                DEBUG(11,("ldapsam_get_account_policy: got valid value from "
                          "cache\n"));
@@ -3658,7 +3665,7 @@ static NTSTATUS ldapsam_lookup_rids(struct pdb_methods *methods,
                                    int num_rids,
                                    uint32 *rids,
                                    const char **names,
-                                   uint32 *attrs)
+                                   enum lsa_SidType *attrs)
 {
        struct ldapsam_privates *ldap_state =
                (struct ldapsam_privates *)methods->private_data;
@@ -3693,8 +3700,7 @@ static NTSTATUS ldapsam_lookup_rids(struct pdb_methods *methods,
 
        for (i=0; i<num_rids; i++) {
                DOM_SID sid;
-               sid_copy(&sid, domain_sid);
-               sid_append_rid(&sid, rids[i]);
+               sid_compose(&sid, domain_sid, rids[i]);
                allsids = talloc_asprintf_append(allsids, "(sambaSid=%s)",
                                                 sid_string_static(&sid));
                if (allsids == NULL) {
@@ -3709,8 +3715,8 @@ static NTSTATUS ldapsam_lookup_rids(struct pdb_methods *methods,
                const char *ldap_attrs[] = { "uid", "sambaSid", NULL };
 
                filter = talloc_asprintf(
-                       mem_ctx, ("(&(objectClass=sambaSamAccount)(|%s))"),
-                       allsids);
+                       mem_ctx, ("(&(objectClass=%s)(|%s))"),
+                       LDAP_OBJ_SAMBASAMACCOUNT, allsids);
 
                if (filter == NULL) {
                        goto done;
@@ -3778,8 +3784,8 @@ static NTSTATUS ldapsam_lookup_rids(struct pdb_methods *methods,
                                             "sambaGroupType", NULL };
 
                filter = talloc_asprintf(
-                       mem_ctx, "(&(objectClass=sambaGroupMapping)(|%s))",
-                       allsids);
+                       mem_ctx, "(&(objectClass=%s)(|%s))",
+                       LDAP_OBJ_GROUPMAP, allsids);
                if (filter == NULL) {
                        goto done;
                }
@@ -3809,7 +3815,7 @@ static NTSTATUS ldapsam_lookup_rids(struct pdb_methods *methods,
                uint32 rid;
                int rid_index;
                const char *attr;
-               enum SID_NAME_USE type;
+               enum lsa_SidType type;
                const char *dn = smbldap_talloc_dn(mem_ctx, ld, entry);
 
                attr = smbldap_talloc_single_attribute(ld, entry, "sambaGroupType",
@@ -3820,10 +3826,10 @@ static NTSTATUS ldapsam_lookup_rids(struct pdb_methods *methods,
                        continue;
                }
 
-               type = atol(attr);
+               type = (enum lsa_SidType)atol(attr);
 
                /* Consistency checks */
-               if ((is_builtin && (type != SID_NAME_WKN_GRP)) ||
+               if ((is_builtin && (type != SID_NAME_ALIAS)) ||
                    (!is_builtin && ((type != SID_NAME_ALIAS) &&
                                     (type != SID_NAME_DOM_GRP)))) {
                        DEBUG(2, ("Rejecting invalid group mapping entry %s\n", dn));
@@ -3835,13 +3841,12 @@ static NTSTATUS ldapsam_lookup_rids(struct pdb_methods *methods,
                        continue;
                }
 
-               attr = smbldap_talloc_single_attribute(ld, entry, "cn", names);
+               attr = smbldap_talloc_single_attribute(ld, entry, "displayName", names);
 
                if (attr == NULL) {
-                       DEBUG(10, ("Could not retrieve 'cn' attribute from %s\n",
+                       DEBUG(10, ("Could not retrieve 'displayName' attribute from %s\n",
                                   dn));
-                       attr = smbldap_talloc_single_attribute(
-                               ld, entry, "displayName", names);
+                       attr = smbldap_talloc_single_attribute(ld, entry, "cn", names);
                }
 
                if (attr == NULL) {
@@ -3908,11 +3913,18 @@ const char **talloc_attrs(TALLOC_CTX *mem_ctx, ...)
                num += 1;
        va_end(ap);
 
-       result = TALLOC_ARRAY(mem_ctx, const char *, num+1);
+       if ((result = TALLOC_ARRAY(mem_ctx, const char *, num+1)) == NULL) {
+               return NULL;
+       }
 
        va_start(ap, mem_ctx);
-       for (i=0; i<num; i++)
-               result[i] = talloc_strdup(mem_ctx, va_arg(ap, const char*));
+       for (i=0; i<num; i++) {
+               result[i] = talloc_strdup(result, va_arg(ap, const char*));
+               if (result[i] == NULL) {
+                       talloc_free(result);
+                       return NULL;
+               }
+       }
        va_end(ap);
 
        result[num] = NULL;
@@ -3922,7 +3934,7 @@ const char **talloc_attrs(TALLOC_CTX *mem_ctx, ...)
 struct ldap_search_state {
        struct smbldap_state *connection;
 
-       uint16 acct_flags;
+       uint32 acct_flags;
        uint16 group_type;
 
        const char *base;
@@ -3941,7 +3953,8 @@ struct ldap_search_state {
 
 static BOOL ldapsam_search_firstpage(struct pdb_search *search)
 {
-       struct ldap_search_state *state = search->private_data;
+       struct ldap_search_state *state =
+               (struct ldap_search_state *)search->private_data;
        LDAP *ld;
        int rc = LDAP_OPERATIONS_ERROR;
 
@@ -3993,7 +4006,8 @@ static BOOL ldapsam_search_firstpage(struct pdb_search *search)
 
 static BOOL ldapsam_search_nextpage(struct pdb_search *search)
 {
-       struct ldap_search_state *state = search->private_data;
+       struct ldap_search_state *state =
+               (struct ldap_search_state *)search->private_data;
        int rc;
 
        if (!state->connection->paged_results) {
@@ -4023,7 +4037,8 @@ static BOOL ldapsam_search_nextpage(struct pdb_search *search)
 static BOOL ldapsam_search_next_entry(struct pdb_search *search,
                                      struct samr_displayentry *entry)
 {
-       struct ldap_search_state *state = search->private_data;
+       struct ldap_search_state *state =
+               (struct ldap_search_state *)search->private_data;
        BOOL result;
 
  retry:
@@ -4058,7 +4073,8 @@ static BOOL ldapsam_search_next_entry(struct pdb_search *search,
 
 static void ldapsam_search_end(struct pdb_search *search)
 {
-       struct ldap_search_state *state = search->private_data;
+       struct ldap_search_state *state =
+               (struct ldap_search_state *)search->private_data;
        int rc;
 
        if (state->pagedresults_cookie == NULL)
@@ -4093,7 +4109,7 @@ static BOOL ldapuser2displayentry(struct ldap_search_state *state,
 {
        char **vals;
        DOM_SID sid;
-       uint16 acct_flags;
+       uint32 acct_flags;
 
        vals = ldap_get_values(ld, entry, "sambaAcctFlags");
        if ((vals == NULL) || (vals[0] == NULL)) {
@@ -4172,9 +4188,10 @@ static BOOL ldapuser2displayentry(struct ldap_search_state *state,
 
 static BOOL ldapsam_search_users(struct pdb_methods *methods,
                                 struct pdb_search *search,
-                                uint16 acct_flags)
+                                uint32 acct_flags)
 {
-       struct ldapsam_privates *ldap_state = methods->private_data;
+       struct ldapsam_privates *ldap_state =
+               (struct ldapsam_privates *)methods->private_data;
        struct ldap_search_state *state;
 
        state = TALLOC_P(search->mem_ctx, struct ldap_search_state);
@@ -4310,25 +4327,15 @@ static BOOL ldapgroup2displayentry(struct ldap_search_state *state,
                case SID_NAME_DOM_GRP:
                case SID_NAME_ALIAS:
 
-                       if (!sid_peek_check_rid(get_global_sam_sid(), &sid,
-                                               &result->rid)) {
+                       if (!sid_peek_check_rid(get_global_sam_sid(), &sid, &result->rid) 
+                               && !sid_peek_check_rid(&global_sid_Builtin, &sid, &result->rid)) 
+                       {
                                DEBUG(0, ("%s is not in our domain\n",
                                          sid_string_static(&sid)));
                                return False;
                        }
                        break;
        
-               case SID_NAME_WKN_GRP:
-
-                       if (!sid_peek_check_rid(&global_sid_Builtin, &sid,
-                                               &result->rid)) {
-
-                               DEBUG(0, ("%s is not in builtin sid\n",
-                                         sid_string_static(&sid)));
-                               return False;
-                       }
-                       break;
-
                default:
                        DEBUG(0,("unkown group type: %d\n", group_type));
                        return False;
@@ -4339,9 +4346,11 @@ static BOOL ldapgroup2displayentry(struct ldap_search_state *state,
 
 static BOOL ldapsam_search_grouptype(struct pdb_methods *methods,
                                     struct pdb_search *search,
-                                    enum SID_NAME_USE type)
+                                     const DOM_SID *sid,
+                                    enum lsa_SidType type)
 {
-       struct ldapsam_privates *ldap_state = methods->private_data;
+       struct ldapsam_privates *ldap_state =
+               (struct ldapsam_privates *)methods->private_data;
        struct ldap_search_state *state;
 
        state = TALLOC_P(search->mem_ctx, struct ldap_search_state);
@@ -4357,7 +4366,8 @@ static BOOL ldapsam_search_grouptype(struct pdb_methods *methods,
        state->scope = LDAP_SCOPE_SUBTREE;
        state->filter = talloc_asprintf(search->mem_ctx,
                                        "(&(objectclass=sambaGroupMapping)"
-                                       "(sambaGroupType=%d))", type);
+                                       "(sambaGroupType=%d)(sambaSID=%s*))", 
+                                       type, sid_string_static(sid));
        state->attrs = talloc_attrs(search->mem_ctx, "cn", "sambaSid",
                                    "displayName", "description",
                                    "sambaGroupType", NULL);
@@ -4382,23 +4392,14 @@ static BOOL ldapsam_search_grouptype(struct pdb_methods *methods,
 static BOOL ldapsam_search_groups(struct pdb_methods *methods,
                                  struct pdb_search *search)
 {
-       return ldapsam_search_grouptype(methods, search, SID_NAME_DOM_GRP);
+       return ldapsam_search_grouptype(methods, search, get_global_sam_sid(), SID_NAME_DOM_GRP);
 }
 
 static BOOL ldapsam_search_aliases(struct pdb_methods *methods,
                                   struct pdb_search *search,
                                   const DOM_SID *sid)
 {
-       if (sid_check_is_domain(sid))
-               return ldapsam_search_grouptype(methods, search,
-                                               SID_NAME_ALIAS);
-
-       if (sid_check_is_builtin(sid))
-               return ldapsam_search_grouptype(methods, search,
-                                               SID_NAME_WKN_GRP);
-
-       DEBUG(5, ("Don't know SID %s\n", sid_string_static(sid)));
-       return False;
+       return ldapsam_search_grouptype(methods, search, sid, SID_NAME_ALIAS);
 }
 
 static BOOL ldapsam_rid_algorithm(struct pdb_methods *methods)
@@ -4418,6 +4419,7 @@ static NTSTATUS ldapsam_get_new_rid(struct ldapsam_privates *priv,
        char *value;
        int rc;
        uint32 nextRid = 0;
+       const char *dn;
 
        TALLOC_CTX *mem_ctx;
 
@@ -4481,9 +4483,12 @@ static NTSTATUS ldapsam_get_new_rid(struct ldapsam_privates *priv,
                         talloc_asprintf(mem_ctx, "%d", nextRid));
        talloc_autofree_ldapmod(mem_ctx, mods);
 
-       rc = smbldap_modify(smbldap_state,
-                           smbldap_talloc_dn(mem_ctx, priv2ld(priv), entry),
-                           mods);
+       if ((dn = smbldap_talloc_dn(mem_ctx, priv2ld(priv), entry)) == NULL) {
+               status = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
+
+       rc = smbldap_modify(smbldap_state, dn, mods);
 
        /* ACCESS_DENIED is used as a placeholder for "the modify failed,
         * please retry" */
@@ -4499,33 +4504,40 @@ static NTSTATUS ldapsam_get_new_rid(struct ldapsam_privates *priv,
        return status;
 }
 
-static BOOL ldapsam_new_rid(struct pdb_methods *methods, uint32 *rid)
+static NTSTATUS ldapsam_new_rid_internal(struct pdb_methods *methods, uint32 *rid)
 {
        int i;
 
        for (i=0; i<10; i++) {
-               NTSTATUS result = ldapsam_get_new_rid(methods->private_data,
-                                                     rid);
+               NTSTATUS result = ldapsam_get_new_rid(
+                       (struct ldapsam_privates *)methods->private_data, rid);
                if (NT_STATUS_IS_OK(result)) {
-                       return True;
+                       return result;
                }
 
                if (!NT_STATUS_EQUAL(result, NT_STATUS_ACCESS_DENIED)) {
-                       return False;
+                       return result;
                }
 
                /* The ldap update failed (maybe a race condition), retry */
        }
 
        /* Tried 10 times, fail. */
-       return False;
+       return NT_STATUS_ACCESS_DENIED;
+}
+
+static BOOL ldapsam_new_rid(struct pdb_methods *methods, uint32 *rid)
+{
+       NTSTATUS result = ldapsam_new_rid_internal(methods, rid);
+       return NT_STATUS_IS_OK(result) ? True : False;
 }
 
 static BOOL ldapsam_sid_to_id(struct pdb_methods *methods,
                              const DOM_SID *sid,
-                             union unid_t *id, enum SID_NAME_USE *type)
+                             union unid_t *id, enum lsa_SidType *type)
 {
-       struct ldapsam_privates *priv = methods->private_data;
+       struct ldapsam_privates *priv =
+               (struct ldapsam_privates *)methods->private_data;
        char *filter;
        const char *attrs[] = { "sambaGroupType", "gidNumber", "uidNumber",
                                NULL };
@@ -4545,9 +4557,9 @@ static BOOL ldapsam_sid_to_id(struct pdb_methods *methods,
 
        filter = talloc_asprintf(mem_ctx,
                                 "(&(sambaSid=%s)"
-                                "(|(objectClass=sambaGroupMapping)"
-                                "(objectClass=sambaSamAccount)))",
-                                sid_string_static(sid));
+                                "(|(objectClass=%s)(objectClass=%s)))",
+                                sid_string_static(sid),
+                                LDAP_OBJ_GROUPMAP, LDAP_OBJ_SAMBASAMACCOUNT);
        if (filter == NULL) {
                DEBUG(5, ("talloc_asprintf failed\n"));
                goto done;
@@ -4585,7 +4597,7 @@ static BOOL ldapsam_sid_to_id(struct pdb_methods *methods,
                }
 
                id->gid = strtoul(gid_str, NULL, 10);
-               *type = strtoul(value, NULL, 10);
+               *type = (enum lsa_SidType)strtoul(value, NULL, 10);
                ret = True;
                goto done;
        }
@@ -4609,6 +4621,799 @@ static BOOL ldapsam_sid_to_id(struct pdb_methods *methods,
        return ret;
 }
 
+/*
+ * The following functions is called only if
+ * ldapsam:trusted and ldapsam:editposix are
+ * set to true
+ */
+
+/*
+ * ldapsam_create_user creates a new
+ * posixAccount and sambaSamAccount object
+ * in the ldap users subtree
+ *
+ * The uid is allocated by winbindd.
+ */
+
+static NTSTATUS ldapsam_create_user(struct pdb_methods *my_methods,
+                                   TALLOC_CTX *tmp_ctx, const char *name,
+                                   uint32 acb_info, uint32 *rid)
+{
+       struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
+       LDAPMessage *entry = NULL;
+       LDAPMessage *result = NULL;
+       uint32 num_result;
+       BOOL is_machine = False;
+       BOOL add_posix = False;
+       LDAPMod **mods = NULL;
+       struct samu *user;
+       char *filter;
+       char *username;
+       char *homedir;
+       char *gidstr;
+       char *uidstr;
+       char *shell;
+       const char *dn = NULL;
+       DOM_SID group_sid;
+       DOM_SID user_sid;
+       gid_t gid = -1;
+       uid_t uid = -1;
+       NTSTATUS ret;
+       int rc;
+       
+       if (((acb_info & ACB_NORMAL) && name[strlen(name)-1] == '$') ||
+             acb_info & ACB_WSTRUST ||
+             acb_info & ACB_SVRTRUST ||
+             acb_info & ACB_DOMTRUST) {
+               is_machine = True;
+       }
+
+       username = escape_ldap_string_alloc(name);
+       filter = talloc_asprintf(tmp_ctx, "(&(uid=%s)(objectClass=%s))",
+                                username, LDAP_OBJ_POSIXACCOUNT);
+       SAFE_FREE(username);
+
+       rc = smbldap_search_suffix(ldap_state->smbldap_state, filter, NULL, &result);
+       if (rc != LDAP_SUCCESS) {
+               DEBUG(0,("ldapsam_create_user: ldap search failed!\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+       talloc_autofree_ldapmsg(tmp_ctx, result);
+
+       num_result = ldap_count_entries(priv2ld(ldap_state), result);
+
+       if (num_result > 1) {
+               DEBUG (0, ("ldapsam_create_user: More than one user with name [%s] ?!\n", name));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+       
+       if (num_result == 1) {
+               char *tmp;
+               /* check if it is just a posix account.
+                * or if there is a sid attached to this entry
+                */
+
+               entry = ldap_first_entry(priv2ld(ldap_state), result);
+               if (!entry) {
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
+
+               tmp = smbldap_talloc_single_attribute(priv2ld(ldap_state), entry, "sambaSID", tmp_ctx);
+               if (tmp) {
+                       DEBUG (1, ("ldapsam_create_user: The user [%s] already exist!\n", name));
+                       return NT_STATUS_USER_EXISTS;
+               }
+
+               /* it is just a posix account, retrieve the dn for later use */
+               dn = smbldap_talloc_dn(tmp_ctx, priv2ld(ldap_state), entry);
+               if (!dn) {
+                       DEBUG(0,("ldapsam_create_user: Out of memory!\n"));
+                       return NT_STATUS_NO_MEMORY;
+               }
+       }
+
+       if (num_result == 0) {
+               add_posix = True;
+       }
+       
+       /* Create the basic samu structure and generate the mods for the ldap commit */
+       if (!NT_STATUS_IS_OK((ret = ldapsam_new_rid_internal(my_methods, rid)))) {
+               DEBUG(1, ("ldapsam_create_user: Could not allocate a new RID\n"));
+               return ret;
+       }
+
+       sid_compose(&user_sid, get_global_sam_sid(), *rid);
+
+       user = samu_new(tmp_ctx);
+       if (!user) {
+               DEBUG(1,("ldapsam_create_user: Unable to allocate user struct\n"));
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       if (!pdb_set_username(user, name, PDB_SET)) {
+               DEBUG(1,("ldapsam_create_user: Unable to fill user structs\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+       if (!pdb_set_domain(user, get_global_sam_name(), PDB_SET)) {
+               DEBUG(1,("ldapsam_create_user: Unable to fill user structs\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+       if (is_machine) {
+               if (acb_info & ACB_NORMAL) {
+                       if (!pdb_set_acct_ctrl(user, ACB_WSTRUST, PDB_SET)) {
+                               DEBUG(1,("ldapsam_create_user: Unable to fill user structs\n"));
+                               return NT_STATUS_UNSUCCESSFUL;
+                       }
+               } else {
+                       if (!pdb_set_acct_ctrl(user, acb_info, PDB_SET)) {
+                               DEBUG(1,("ldapsam_create_user: Unable to fill user structs\n"));
+                               return NT_STATUS_UNSUCCESSFUL;
+                       }
+               }
+       } else {
+               if (!pdb_set_acct_ctrl(user, ACB_NORMAL | ACB_DISABLED, PDB_SET)) {
+                       DEBUG(1,("ldapsam_create_user: Unable to fill user structs\n"));
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
+       }
+
+       if (!pdb_set_user_sid(user, &user_sid, PDB_SET)) {
+               DEBUG(1,("ldapsam_create_user: Unable to fill user structs\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       if (!init_ldap_from_sam(ldap_state, NULL, &mods, user, element_is_set_or_changed)) {
+               DEBUG(1,("ldapsam_create_user: Unable to fill user structs\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       if (ldap_state->schema_ver != SCHEMAVER_SAMBASAMACCOUNT) {
+               DEBUG(1,("ldapsam_create_user: Unsupported schema version\n"));
+       }
+       smbldap_set_mod(&mods, LDAP_MOD_ADD, "objectClass", LDAP_OBJ_SAMBASAMACCOUNT);
+
+       if (add_posix) {
+               DEBUG(3,("ldapsam_create_user: Creating new posix user\n"));
+
+               /* retrieve the Domain Users group gid */
+               if (!sid_compose(&group_sid, get_global_sam_sid(), DOMAIN_GROUP_RID_USERS) ||
+                   !sid_to_gid(&group_sid, &gid)) {
+                       DEBUG (0, ("ldapsam_create_user: Unable to get the Domain Users gid: bailing out!\n"));
+                       return NT_STATUS_INVALID_PRIMARY_GROUP;
+               }
+
+               /* lets allocate a new userid for this user */
+               if (!winbind_allocate_uid(&uid)) {
+                       DEBUG (0, ("ldapsam_create_user: Unable to allocate a new user id: bailing out!\n"));
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
+
+
+               if (is_machine) {
+                       /* TODO: choose a more appropriate default for machines */
+                       homedir = talloc_sub_specified(tmp_ctx, lp_template_homedir(), "SMB_workstations_home", ldap_state->domain_name, uid, gid);
+                       shell = talloc_strdup(tmp_ctx, "/bin/false");
+               } else {
+                       homedir = talloc_sub_specified(tmp_ctx, lp_template_homedir(), name, ldap_state->domain_name, uid, gid);
+                       shell = talloc_sub_specified(tmp_ctx, lp_template_shell(), name, ldap_state->domain_name, uid, gid);
+               }
+               uidstr = talloc_asprintf(tmp_ctx, "%d", uid);
+               gidstr = talloc_asprintf(tmp_ctx, "%d", gid);
+               if (is_machine) {
+                       dn = talloc_asprintf(tmp_ctx, "uid=%s,%s", name, lp_ldap_machine_suffix ());
+               } else {
+                       dn = talloc_asprintf(tmp_ctx, "uid=%s,%s", name, lp_ldap_user_suffix ());
+               }
+
+               if (!homedir || !shell || !uidstr || !gidstr || !dn) {
+                       DEBUG (0, ("ldapsam_create_user: Out of memory!\n"));
+                       return NT_STATUS_NO_MEMORY;
+               }
+
+               smbldap_set_mod(&mods, LDAP_MOD_ADD, "objectClass", LDAP_OBJ_ACCOUNT);
+               smbldap_set_mod(&mods, LDAP_MOD_ADD, "objectClass", LDAP_OBJ_POSIXACCOUNT);
+               smbldap_set_mod(&mods, LDAP_MOD_ADD, "cn", name);
+               smbldap_set_mod(&mods, LDAP_MOD_ADD, "uidNumber", uidstr);
+               smbldap_set_mod(&mods, LDAP_MOD_ADD, "gidNumber", gidstr);
+               smbldap_set_mod(&mods, LDAP_MOD_ADD, "homeDirectory", homedir);
+               smbldap_set_mod(&mods, LDAP_MOD_ADD, "loginShell", shell);
+       }
+
+       talloc_autofree_ldapmod(tmp_ctx, mods);
+
+       if (add_posix) {        
+               rc = smbldap_add(ldap_state->smbldap_state, dn, mods);
+       } else {
+               rc = smbldap_modify(ldap_state->smbldap_state, dn, mods);
+       }       
+
+       if (rc != LDAP_SUCCESS) {
+               DEBUG(0,("ldapsam_create_user: failed to create a new user [%s] (dn = %s)\n", name ,dn));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       DEBUG(2,("ldapsam_create_user: added account [%s] in the LDAP database\n", name));
+
+       flush_pwnam_cache();
+
+       return NT_STATUS_OK;
+}
+
+static NTSTATUS ldapsam_delete_user(struct pdb_methods *my_methods, TALLOC_CTX *tmp_ctx, struct samu *sam_acct)
+{
+       struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
+       LDAPMessage *result = NULL;
+       LDAPMessage *entry = NULL;
+       int num_result;
+       const char *dn;
+       char *filter;
+       int rc;
+
+       DEBUG(0,("ldapsam_delete_user: Attempt to delete user [%s]\n", pdb_get_username(sam_acct)));
+       
+       filter = talloc_asprintf(tmp_ctx,
+                                "(&(uid=%s)"
+                                "(objectClass=%s)"
+                                "(objectClass=%s))",
+                                pdb_get_username(sam_acct),
+                                LDAP_OBJ_POSIXACCOUNT,
+                                LDAP_OBJ_SAMBASAMACCOUNT);
+       if (filter == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       rc = smbldap_search_suffix(ldap_state->smbldap_state, filter, NULL, &result);
+       if (rc != LDAP_SUCCESS) {
+               DEBUG(0,("ldapsam_delete_user: user search failed!\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+       talloc_autofree_ldapmsg(tmp_ctx, result);
+
+       num_result = ldap_count_entries(priv2ld(ldap_state), result);
+
+       if (num_result == 0) {
+               DEBUG(0,("ldapsam_delete_user: user not found!\n"));
+               return NT_STATUS_NO_SUCH_USER;
+       }
+
+       if (num_result > 1) {
+               DEBUG (0, ("ldapsam_delete_user: More than one user with name [%s] ?!\n", pdb_get_username(sam_acct)));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       entry = ldap_first_entry(priv2ld(ldap_state), result);
+       if (!entry) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       /* it is just a posix account, retrieve the dn for later use */
+       dn = smbldap_talloc_dn(tmp_ctx, priv2ld(ldap_state), entry);
+       if (!dn) {
+               DEBUG(0,("ldapsam_delete_user: Out of memory!\n"));
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       rc = smbldap_delete(ldap_state->smbldap_state, dn);
+       if (rc != LDAP_SUCCESS) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       flush_pwnam_cache();
+
+       return NT_STATUS_OK;
+}
+
+/*
+ * ldapsam_create_group creates a new
+ * posixGroup and sambaGroupMapping object
+ * in the ldap groups subtree
+ *
+ * The gid is allocated by winbindd.
+ */
+
+static NTSTATUS ldapsam_create_dom_group(struct pdb_methods *my_methods,
+                                        TALLOC_CTX *tmp_ctx,
+                                        const char *name,
+                                        uint32 *rid)
+{
+       struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
+       NTSTATUS ret;
+       LDAPMessage *entry = NULL;
+       LDAPMessage *result = NULL;
+       uint32 num_result;
+       BOOL is_new_entry = False;
+       LDAPMod **mods = NULL;
+       char *filter;
+       char *groupsidstr;
+       char *groupname;
+       char *grouptype;
+       char *gidstr;
+       const char *dn = NULL;
+       DOM_SID group_sid;
+       gid_t gid = -1;
+       int rc;
+       
+       groupname = escape_ldap_string_alloc(name);
+       filter = talloc_asprintf(tmp_ctx, "(&(cn=%s)(objectClass=%s))",
+                                groupname, LDAP_OBJ_POSIXGROUP);
+       SAFE_FREE(groupname);
+
+       rc = smbldap_search_suffix(ldap_state->smbldap_state, filter, NULL, &result);
+       if (rc != LDAP_SUCCESS) {
+               DEBUG(0,("ldapsam_create_group: ldap search failed!\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+       talloc_autofree_ldapmsg(tmp_ctx, result);
+
+       num_result = ldap_count_entries(priv2ld(ldap_state), result);
+
+       if (num_result > 1) {
+               DEBUG (0, ("ldapsam_create_group: There exists more than one group with name [%s]: bailing out!\n", name));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+       
+       if (num_result == 1) {
+               char *tmp;
+               /* check if it is just a posix group.
+                * or if there is a sid attached to this entry
+                */
+
+               entry = ldap_first_entry(priv2ld(ldap_state), result);
+               if (!entry) {
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
+
+               tmp = smbldap_talloc_single_attribute(priv2ld(ldap_state), entry, "sambaSID", tmp_ctx);
+               if (tmp) {
+                       DEBUG (1, ("ldapsam_create_group: The group [%s] already exist!\n", name));
+                       return NT_STATUS_GROUP_EXISTS;
+               }
+
+               /* it is just a posix group, retrieve the gid and the dn for later use */
+               tmp = smbldap_talloc_single_attribute(priv2ld(ldap_state), entry, "gidNumber", tmp_ctx);
+               if (!tmp) {
+                       DEBUG (1, ("ldapsam_create_group: Couldn't retrieve the gidNumber for [%s]?!?!\n", name));
+                       return NT_STATUS_INTERNAL_DB_CORRUPTION;
+               }
+               
+               gid = strtoul(tmp, NULL, 10);
+
+               dn = smbldap_talloc_dn(tmp_ctx, priv2ld(ldap_state), entry);
+               if (!dn) {
+                       DEBUG(0,("ldapsam_create_group: Out of memory!\n"));
+                       return NT_STATUS_NO_MEMORY;
+               }
+       }
+
+       if (num_result == 0) {
+               DEBUG(3,("ldapsam_create_user: Creating new posix group\n"));
+
+               is_new_entry = True;
+       
+               /* lets allocate a new groupid for this group */
+               if (!winbind_allocate_gid(&gid)) {
+                       DEBUG (0, ("ldapsam_create_group: Unable to allocate a new group id: bailing out!\n"));
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
+
+               gidstr = talloc_asprintf(tmp_ctx, "%d", gid);
+               dn = talloc_asprintf(tmp_ctx, "cn=%s,%s", name, lp_ldap_group_suffix());
+
+               if (!gidstr || !dn) {
+                       DEBUG (0, ("ldapsam_create_group: Out of memory!\n"));
+                       return NT_STATUS_NO_MEMORY;
+               }
+
+               smbldap_set_mod(&mods, LDAP_MOD_ADD, "objectclass", LDAP_OBJ_POSIXGROUP);
+               smbldap_set_mod(&mods, LDAP_MOD_ADD, "cn", name);
+               smbldap_set_mod(&mods, LDAP_MOD_ADD, "gidNumber", gidstr);
+       }
+
+       if (!NT_STATUS_IS_OK((ret = ldapsam_new_rid_internal(my_methods, rid)))) {
+               DEBUG(1, ("ldapsam_create_group: Could not allocate a new RID\n"));
+               return ret;
+       }
+
+       sid_compose(&group_sid, get_global_sam_sid(), *rid);
+
+       groupsidstr = talloc_strdup(tmp_ctx, sid_string_static(&group_sid));
+       grouptype = talloc_asprintf(tmp_ctx, "%d", SID_NAME_DOM_GRP);
+
+       if (!groupsidstr || !grouptype) {
+               DEBUG(0,("ldapsam_create_group: Out of memory!\n"));
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       smbldap_set_mod(&mods, LDAP_MOD_ADD, "objectClass", LDAP_OBJ_GROUPMAP);
+       smbldap_set_mod(&mods, LDAP_MOD_ADD, "sambaSid", groupsidstr);
+       smbldap_set_mod(&mods, LDAP_MOD_ADD, "sambaGroupType", grouptype);
+       smbldap_set_mod(&mods, LDAP_MOD_ADD, "displayName", name);
+       talloc_autofree_ldapmod(tmp_ctx, mods);
+
+       if (is_new_entry) {     
+               rc = smbldap_add(ldap_state->smbldap_state, dn, mods);
+#if 0
+               if (rc == LDAP_OBJECT_CLASS_VIOLATION) {
+                       /* This call may fail with rfc2307bis schema */
+                       /* Retry adding a structural class */
+                       smbldap_set_mod(&mods, LDAP_MOD_ADD, "objectClass", "????");
+                       rc = smbldap_add(ldap_state->smbldap_state, dn, mods);
+               }
+#endif
+       } else {
+               rc = smbldap_modify(ldap_state->smbldap_state, dn, mods);
+       }       
+
+       if (rc != LDAP_SUCCESS) {
+               DEBUG(0,("ldapsam_create_group: failed to create a new group [%s] (dn = %s)\n", name ,dn));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       DEBUG(2,("ldapsam_create_group: added group [%s] in the LDAP database\n", name));
+
+       return NT_STATUS_OK;
+}
+
+static NTSTATUS ldapsam_delete_dom_group(struct pdb_methods *my_methods, TALLOC_CTX *tmp_ctx, uint32 rid)
+{
+       struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
+       LDAPMessage *result = NULL;
+       LDAPMessage *entry = NULL;
+       int num_result;
+       const char *dn;
+       char *gidstr;
+       char *filter;
+       DOM_SID group_sid;
+       int rc;
+
+       /* get the group sid */
+       sid_compose(&group_sid, get_global_sam_sid(), rid);
+
+       filter = talloc_asprintf(tmp_ctx,
+                                "(&(sambaSID=%s)"
+                                "(objectClass=%s)"
+                                "(objectClass=%s))",
+                                sid_string_static(&group_sid),
+                                LDAP_OBJ_POSIXGROUP,
+                                LDAP_OBJ_GROUPMAP);
+       if (filter == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       rc = smbldap_search_suffix(ldap_state->smbldap_state, filter, NULL, &result);
+       if (rc != LDAP_SUCCESS) {
+               DEBUG(1,("ldapsam_delete_dom_group: group search failed!\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+       talloc_autofree_ldapmsg(tmp_ctx, result);
+
+       num_result = ldap_count_entries(priv2ld(ldap_state), result);
+
+       if (num_result == 0) {
+               DEBUG(1,("ldapsam_delete_dom_group: group not found!\n"));
+               return NT_STATUS_NO_SUCH_GROUP;
+       }
+
+       if (num_result > 1) {
+               DEBUG (0, ("ldapsam_delete_dom_group: More than one group with the same SID ?!\n"));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       entry = ldap_first_entry(priv2ld(ldap_state), result);
+       if (!entry) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       /* here it is, retrieve the dn for later use */
+       dn = smbldap_talloc_dn(tmp_ctx, priv2ld(ldap_state), entry);
+       if (!dn) {
+               DEBUG(0,("ldapsam_delete_dom_group: Out of memory!\n"));
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       gidstr = smbldap_talloc_single_attribute(priv2ld(ldap_state), entry, "gidNumber", tmp_ctx);
+       if (!gidstr) {
+               DEBUG (0, ("ldapsam_delete_dom_group: Unable to find the group's gid!\n"));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       /* check no user have this group marked as primary group */
+       filter = talloc_asprintf(tmp_ctx,
+                                "(&(gidNumber=%s)"
+                                "(objectClass=%s)"
+                                "(objectClass=%s))",
+                                gidstr,
+                                LDAP_OBJ_POSIXACCOUNT,
+                                LDAP_OBJ_SAMBASAMACCOUNT);
+
+       rc = smbldap_search_suffix(ldap_state->smbldap_state, filter, NULL, &result);
+       if (rc != LDAP_SUCCESS) {
+               DEBUG(1,("ldapsam_delete_dom_group: accounts search failed!\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+       talloc_autofree_ldapmsg(tmp_ctx, result);
+
+       num_result = ldap_count_entries(priv2ld(ldap_state), result);
+
+       if (num_result != 0) {
+               DEBUG(3,("ldapsam_delete_dom_group: Can't delete group, it is a primary group for %d users\n", num_result));
+               return NT_STATUS_MEMBERS_PRIMARY_GROUP;
+       }
+
+       rc = smbldap_delete(ldap_state->smbldap_state, dn);
+       if (rc != LDAP_SUCCESS) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       return NT_STATUS_OK;
+}
+
+static NTSTATUS ldapsam_change_groupmem(struct pdb_methods *my_methods,
+                                       TALLOC_CTX *tmp_ctx,
+                                       uint32 group_rid,
+                                       uint32 member_rid,
+                                       int modop)
+{
+       struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
+       LDAPMessage *entry = NULL;
+       LDAPMessage *result = NULL;
+       uint32 num_result;
+       LDAPMod **mods = NULL;
+       char *filter;
+       char *uidstr;
+       const char *dn = NULL;
+       DOM_SID group_sid;
+       DOM_SID member_sid;
+       int rc;
+
+       switch (modop) {
+       case LDAP_MOD_ADD:
+               DEBUG(1,("ldapsam_change_groupmem: add new member(rid=%d) to a domain group(rid=%d)", member_rid, group_rid));
+               break;
+       case LDAP_MOD_DELETE:
+               DEBUG(1,("ldapsam_change_groupmem: delete member(rid=%d) from a domain group(rid=%d)", member_rid, group_rid));
+               break;
+       default:
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+       
+       /* get member sid  */
+       sid_compose(&member_sid, get_global_sam_sid(), member_rid);
+
+       /* get the group sid */
+       sid_compose(&group_sid, get_global_sam_sid(), group_rid);
+
+       filter = talloc_asprintf(tmp_ctx,
+                                "(&(sambaSID=%s)"
+                                "(objectClass=%s)"
+                                "(objectClass=%s))",
+                                sid_string_static(&member_sid),
+                                LDAP_OBJ_POSIXACCOUNT,
+                                LDAP_OBJ_SAMBASAMACCOUNT);
+       if (filter == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       /* get the member uid */
+       rc = smbldap_search_suffix(ldap_state->smbldap_state, filter, NULL, &result);
+       if (rc != LDAP_SUCCESS) {
+               DEBUG(1,("ldapsam_change_groupmem: member search failed!\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+       talloc_autofree_ldapmsg(tmp_ctx, result);
+
+       num_result = ldap_count_entries(priv2ld(ldap_state), result);
+
+       if (num_result == 0) {
+               DEBUG(1,("ldapsam_change_groupmem: member not found!\n"));
+               return NT_STATUS_NO_SUCH_MEMBER;
+       }
+
+       if (num_result > 1) {
+               DEBUG (0, ("ldapsam_change_groupmem: More than one account with the same SID ?!\n"));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       entry = ldap_first_entry(priv2ld(ldap_state), result);
+       if (!entry) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       if (modop == LDAP_MOD_DELETE) {
+               /* check if we are trying to remove the member from his primary group */
+               char *gidstr;
+               gid_t user_gid, group_gid;
+               
+               gidstr = smbldap_talloc_single_attribute(priv2ld(ldap_state), entry, "gidNumber", tmp_ctx);
+               if (!gidstr) {
+                       DEBUG (0, ("ldapsam_change_groupmem: Unable to find the member's gid!\n"));
+                       return NT_STATUS_INTERNAL_DB_CORRUPTION;
+               }
+
+               user_gid = strtoul(gidstr, NULL, 10);
+       
+               if (!sid_to_gid(&group_sid, &group_gid)) {
+                       DEBUG (0, ("ldapsam_change_groupmem: Unable to get group gid from SID!\n"));
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
+
+               if (user_gid == group_gid) {
+                       DEBUG (3, ("ldapsam_change_groupmem: can't remove user from it's own primary group!\n"));
+                       return NT_STATUS_MEMBERS_PRIMARY_GROUP;
+               }
+       }
+
+       /* here it is, retrieve the uid for later use */
+       uidstr = smbldap_talloc_single_attribute(priv2ld(ldap_state), entry, "uid", tmp_ctx);
+       if (!uidstr) {
+               DEBUG (0, ("ldapsam_change_groupmem: Unable to find the member's name!\n"));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       filter = talloc_asprintf(tmp_ctx,
+                                "(&(sambaSID=%s)"
+                                "(objectClass=%s)"
+                                "(objectClass=%s))",
+                                sid_string_static(&group_sid),
+                                LDAP_OBJ_POSIXGROUP,
+                                LDAP_OBJ_GROUPMAP);
+
+       /* get the group */
+       rc = smbldap_search_suffix(ldap_state->smbldap_state, filter, NULL, &result);
+       if (rc != LDAP_SUCCESS) {
+               DEBUG(1,("ldapsam_change_groupmem: group search failed!\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+       talloc_autofree_ldapmsg(tmp_ctx, result);
+
+       num_result = ldap_count_entries(priv2ld(ldap_state), result);
+
+       if (num_result == 0) {
+               DEBUG(1,("ldapsam_change_groupmem: group not found!\n"));
+               return NT_STATUS_NO_SUCH_GROUP;
+       }
+
+       if (num_result > 1) {
+               DEBUG (0, ("ldapsam_change_groupmem: More than one group with the same SID ?!\n"));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       entry = ldap_first_entry(priv2ld(ldap_state), result);
+       if (!entry) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       /* here it is, retrieve the dn for later use */
+       dn = smbldap_talloc_dn(tmp_ctx, priv2ld(ldap_state), entry);
+       if (!dn) {
+               DEBUG(0,("ldapsam_change_groupmem: Out of memory!\n"));
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       smbldap_set_mod(&mods, modop, "memberUid", uidstr);
+
+       talloc_autofree_ldapmod(tmp_ctx, mods);
+
+       rc = smbldap_modify(ldap_state->smbldap_state, dn, mods);
+       if (rc != LDAP_SUCCESS) {
+               if (rc == LDAP_TYPE_OR_VALUE_EXISTS && modop == LDAP_MOD_ADD) {
+                       DEBUG(1,("ldapsam_change_groupmem: member is already in group, add failed!\n"));
+                       return NT_STATUS_MEMBER_IN_GROUP;
+               }
+               if (rc == LDAP_NO_SUCH_ATTRIBUTE && modop == LDAP_MOD_DELETE) {
+                       DEBUG(1,("ldapsam_change_groupmem: member is not in group, delete failed!\n"));
+                       return NT_STATUS_MEMBER_NOT_IN_GROUP;
+               }
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+       
+       return NT_STATUS_OK;
+}
+
+static NTSTATUS ldapsam_add_groupmem(struct pdb_methods *my_methods,
+                                    TALLOC_CTX *tmp_ctx,
+                                    uint32 group_rid,
+                                    uint32 member_rid)
+{
+       return ldapsam_change_groupmem(my_methods, tmp_ctx, group_rid, member_rid, LDAP_MOD_ADD);
+}
+static NTSTATUS ldapsam_del_groupmem(struct pdb_methods *my_methods,
+                                    TALLOC_CTX *tmp_ctx,
+                                    uint32 group_rid,
+                                    uint32 member_rid)
+{
+       return ldapsam_change_groupmem(my_methods, tmp_ctx, group_rid, member_rid, LDAP_MOD_DELETE);
+}
+
+static NTSTATUS ldapsam_set_primary_group(struct pdb_methods *my_methods,
+                                         TALLOC_CTX *mem_ctx,
+                                         struct samu *sampass)
+{
+       struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
+       LDAPMessage *entry = NULL;
+       LDAPMessage *result = NULL;
+       uint32 num_result;
+       LDAPMod **mods = NULL;
+       char *filter;
+       char *gidstr;
+       const char *dn = NULL;
+       gid_t gid;
+       int rc;
+
+       DEBUG(0,("ldapsam_set_primary_group: Attempt to set primary group for user [%s]\n", pdb_get_username(sampass)));
+
+       if (!sid_to_gid(pdb_get_group_sid(sampass), &gid)) {
+               DEBUG(0,("ldapsam_set_primary_group: failed to retieve gid from user's group SID!\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+       gidstr = talloc_asprintf(mem_ctx, "%d", gid);
+       if (!gidstr) {
+               DEBUG(0,("ldapsam_set_primary_group: Out of Memory!\n"));
+               return NT_STATUS_NO_MEMORY;
+       }
+       
+       filter = talloc_asprintf(mem_ctx,
+                                "(&(uid=%s)"
+                                "(objectClass=%s)"
+                                "(objectClass=%s))",
+                                pdb_get_username(sampass),
+                                LDAP_OBJ_POSIXACCOUNT,
+                                LDAP_OBJ_SAMBASAMACCOUNT);
+       if (filter == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       rc = smbldap_search_suffix(ldap_state->smbldap_state, filter, NULL, &result);
+       if (rc != LDAP_SUCCESS) {
+               DEBUG(0,("ldapsam_set_primary_group: user search failed!\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+       talloc_autofree_ldapmsg(mem_ctx, result);
+
+       num_result = ldap_count_entries(priv2ld(ldap_state), result);
+
+       if (num_result == 0) {
+               DEBUG(0,("ldapsam_set_primary_group: user not found!\n"));
+               return NT_STATUS_NO_SUCH_USER;
+       }
+
+       if (num_result > 1) {
+               DEBUG (0, ("ldapsam_set_primary_group: More than one user with name [%s] ?!\n", pdb_get_username(sampass)));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       entry = ldap_first_entry(priv2ld(ldap_state), result);
+       if (!entry) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       /* retrieve the dn for later use */
+       dn = smbldap_talloc_dn(mem_ctx, priv2ld(ldap_state), entry);
+       if (!dn) {
+               DEBUG(0,("ldapsam_set_primary_group: Out of memory!\n"));
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       /* remove the old one, and add the new one, this way we do not risk races */
+       smbldap_make_mod(priv2ld(ldap_state), entry, &mods, "gidNumber", gidstr);
+
+       if (mods == NULL) {
+               return NT_STATUS_OK;
+       }
+
+       rc = smbldap_modify(ldap_state->smbldap_state, dn, mods);
+
+       if (rc != LDAP_SUCCESS) {
+               DEBUG(0,("ldapsam_set_primary_group: failed to modify [%s] primary group to [%s]\n",
+                        pdb_get_username(sampass), gidstr));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       flush_pwnam_cache();
+
+       return NT_STATUS_OK;
+}
+
 /**********************************************************************
  Housekeeping
  *********************************************************************/
@@ -4708,35 +5513,18 @@ NTSTATUS pdb_init_ldapsam_compat(struct pdb_methods **pdb_method, const char *lo
        struct ldapsam_privates *ldap_state;
        char *uri = talloc_strdup( NULL, location );
 
-#ifdef WITH_LDAP_SAMCONFIG
-       if (!uri) {
-               int ldap_port = lp_ldap_port();
-                       
-               /* remap default port if not using SSL (ie clear or TLS) */
-               if ( (lp_ldap_ssl() != LDAP_SSL_ON) && (ldap_port == 636) ) {
-                       ldap_port = 389;
-               }
-
-               uri = talloc_asprintf(NULL, "%s://%s:%d", lp_ldap_ssl() == LDAP_SSL_ON ? "ldaps" : "ldap", lp_ldap_server(), ldap_port);
-               if (!uri) {
-                       return NT_STATUS_NO_MEMORY;
-               }
-               location = uri;
-       }
-#endif
+       trim_char( uri, '\"', '\"' );
+       nt_status = pdb_init_ldapsam_common( pdb_method, uri );
+       if ( uri )
+               TALLOC_FREE( uri );
 
-       if (!NT_STATUS_IS_OK(nt_status = pdb_init_ldapsam_common( pdb_method, uri ))) {
+       if ( !NT_STATUS_IS_OK(nt_status) ) {
                return nt_status;
        }
 
-       /* the module itself stores a copy of the location so throw this one away */
-
-       if ( uri )
-               TALLOC_FREE( uri );
-
        (*pdb_method)->name = "ldapsam_compat";
 
-       ldap_state = (*pdb_method)->private_data;
+       ldap_state = (struct ldapsam_privates *)((*pdb_method)->private_data);
        ldap_state->schema_ver = SCHEMAVER_SAMBAACCOUNT;
 
        sid_copy(&ldap_state->domain_sid, get_global_sam_sid());
@@ -4760,8 +5548,13 @@ NTSTATUS pdb_init_ldapsam(struct pdb_methods **pdb_method, const char *location)
        DOM_SID secrets_domain_sid;
        pstring domain_sid_string;
        char *dn;
+       char *uri = talloc_strdup( NULL, location );
+
+       trim_char( uri, '\"', '\"' );
+       nt_status = pdb_init_ldapsam_common(pdb_method, uri);
+       if ( uri )
+               TALLOC_FREE( uri );
 
-       nt_status = pdb_init_ldapsam_common(pdb_method, location);
        if (!NT_STATUS_IS_OK(nt_status)) {
                return nt_status;
        }
@@ -4782,9 +5575,19 @@ NTSTATUS pdb_init_ldapsam(struct pdb_methods **pdb_method, const char *location)
                        ldapsam_enum_group_memberships;
                (*pdb_method)->lookup_rids = ldapsam_lookup_rids;
                (*pdb_method)->sid_to_id = ldapsam_sid_to_id;
+               
+               if (lp_parm_bool(-1, "ldapsam", "editposix", False)) {
+                       (*pdb_method)->create_user = ldapsam_create_user;
+                       (*pdb_method)->delete_user = ldapsam_delete_user;
+                       (*pdb_method)->create_dom_group = ldapsam_create_dom_group;
+                       (*pdb_method)->delete_dom_group = ldapsam_delete_dom_group;
+                       (*pdb_method)->add_groupmem = ldapsam_add_groupmem;
+                       (*pdb_method)->del_groupmem = ldapsam_del_groupmem;
+                       (*pdb_method)->set_unix_primary_group = ldapsam_set_primary_group;
+               }
        }
 
-       ldap_state = (*pdb_method)->private_data;
+       ldap_state = (struct ldapsam_privates *)((*pdb_method)->private_data);
        ldap_state->schema_ver = SCHEMAVER_SAMBASAMACCOUNT;
 
        /* Try to setup the Domain Name, Domain SID, algorithmic rid base */