r16241: Fix Klocwork #106 and others like it.
[tprouty/samba.git] / source / auth / auth.c
index 02c7eb6d84a6745c478907f548cc8e24a9c36211..139ba5482b748226d0f6b54acef0b1c6d0a60c51 100644 (file)
@@ -23,6 +23,8 @@
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_AUTH
 
+static_decl_auth;
+
 static struct auth_init_function_entry *backends = NULL;
 
 static struct auth_init_function_entry *auth_find_backend_entry(const char *name);
@@ -49,7 +51,7 @@ NTSTATUS smb_register_auth(int version, const char *name, auth_init_function ini
                return NT_STATUS_OBJECT_NAME_COLLISION;
        }
        
-       entry = smb_xmalloc(sizeof(struct auth_init_function_entry));
+       entry = SMB_XMALLOC_P(struct auth_init_function_entry);
        entry->name = smb_xstrdup(name);
        entry->init = init;
 
@@ -88,6 +90,8 @@ static const uint8 *get_ntlm_challenge(struct auth_context *auth_context)
                return auth_context->challenge.data;
        }
 
+       auth_context->challenge_may_be_modified = False;
+
        for (auth_method = auth_context->auth_method_list; auth_method; auth_method = auth_method->next) {
                if (auth_method->get_chal == NULL) {
                        DEBUG(5, ("auth_get_challenge: module %s did not want to specify a challenge\n", auth_method->name));
@@ -122,16 +126,17 @@ static const uint8 *get_ntlm_challenge(struct auth_context *auth_context)
        if (!challenge_set_by) {
                uchar chal[8];
                
-               generate_random_buffer(chal, sizeof(chal), False);
+               generate_random_buffer(chal, sizeof(chal));
                auth_context->challenge = data_blob_talloc(auth_context->mem_ctx, 
                                                           chal, sizeof(chal));
                
                challenge_set_by = "random";
+               auth_context->challenge_may_be_modified = True;
        } 
        
        DEBUG(5, ("auth_context challenge created by %s\n", challenge_set_by));
        DEBUG(5, ("challenge is: \n"));
-       dump_data(5, auth_context->challenge.data, auth_context->challenge.length);
+       dump_data(5, (const char *)auth_context->challenge.data, auth_context->challenge.length);
        
        SMB_ASSERT(auth_context->challenge.length == 8);
 
@@ -193,7 +198,7 @@ static BOOL check_domain_match(const char *user, const char *domain)
  *                  function auth_get_challenge().  
  *
  * @param server_info If successful, contains information about the authentication, 
- *                    including a SAM_ACCOUNT struct describing the user.
+ *                    including a struct samu struct describing the user.
  *
  * @return An NTSTATUS with NT_STATUS_OK or an appropriate error.
  *
@@ -203,9 +208,9 @@ static NTSTATUS check_ntlm_password(const struct auth_context *auth_context,
                                    const struct auth_usersupplied_info *user_info, 
                                    struct auth_serversupplied_info **server_info)
 {
-       
-       NTSTATUS nt_status = NT_STATUS_LOGON_FAILURE;
-       const char *pdb_username;
+       /* if all the modules say 'not for me' this is reasonable */
+       NTSTATUS nt_status = NT_STATUS_NO_SUCH_USER;
+       const char *unix_username;
        auth_methods *auth_method;
        TALLOC_CTX *mem_ctx;
 
@@ -213,10 +218,10 @@ static NTSTATUS check_ntlm_password(const struct auth_context *auth_context,
                return NT_STATUS_LOGON_FAILURE;
 
        DEBUG(3, ("check_ntlm_password:  Checking password for unmapped user [%s]\\[%s]@[%s] with the new password interface\n", 
-                 user_info->client_domain.str, user_info->smb_name.str, user_info->wksta_name.str));
+                 user_info->client_domain, user_info->smb_name, user_info->wksta_name));
 
        DEBUG(3, ("check_ntlm_password:  mapped user is: [%s]\\[%s]@[%s]\n", 
-                 user_info->domain.str, user_info->internal_username.str, user_info->wksta_name.str));
+                 user_info->domain, user_info->internal_username, user_info->wksta_name));
 
        if (auth_context->challenge.length != 8) {
                DEBUG(0, ("check_ntlm_password:  Invalid challenge stored for this auth context - cannot continue\n"));
@@ -228,73 +233,92 @@ static NTSTATUS check_ntlm_password(const struct auth_context *auth_context,
                                        auth_context->challenge_set_by));
 
        DEBUG(10, ("challenge is: \n"));
-       dump_data(5, auth_context->challenge.data, auth_context->challenge.length);
+       dump_data(5, (const char *)auth_context->challenge.data, auth_context->challenge.length);
 
 #ifdef DEBUG_PASSWORD
        DEBUG(100, ("user_info has passwords of length %d and %d\n", 
-                   user_info->lm_resp.length, user_info->nt_resp.length));
+                   (int)user_info->lm_resp.length, (int)user_info->nt_resp.length));
        DEBUG(100, ("lm:\n"));
-       dump_data(100, user_info->lm_resp.data, user_info->lm_resp.length);
+       dump_data(100, (const char *)user_info->lm_resp.data, user_info->lm_resp.length);
        DEBUG(100, ("nt:\n"));
-       dump_data(100, user_info->nt_resp.data, user_info->nt_resp.length);
+       dump_data(100, (const char *)user_info->nt_resp.data, user_info->nt_resp.length);
 #endif
 
        /* This needs to be sorted:  If it doesn't match, what should we do? */
-       if (!check_domain_match(user_info->smb_name.str, user_info->domain.str))
+       if (!check_domain_match(user_info->smb_name, user_info->domain))
                return NT_STATUS_LOGON_FAILURE;
 
        for (auth_method = auth_context->auth_method_list;auth_method; auth_method = auth_method->next) {
+               NTSTATUS result;
+               
                mem_ctx = talloc_init("%s authentication for user %s\\%s", auth_method->name, 
-                                           user_info->domain.str, user_info->smb_name.str);
+                                           user_info->domain, user_info->smb_name);
+
+               result = auth_method->auth(auth_context, auth_method->private_data, mem_ctx, user_info, server_info);
+
+               /* check if the module did anything */
+               if ( NT_STATUS_V(result) == NT_STATUS_V(NT_STATUS_NOT_IMPLEMENTED) ) {
+                       DEBUG(10,("check_ntlm_password: %s had nothing to say\n", auth_method->name));
+                       talloc_destroy(mem_ctx);
+                       continue;
+               }
+
+               nt_status = result;
 
-               nt_status = auth_method->auth(auth_context, auth_method->private_data, mem_ctx, user_info, server_info);
                if (NT_STATUS_IS_OK(nt_status)) {
-                       DEBUG(3, ("check_ntlm_password: %s authentication for user [%s] suceeded\n", 
-                                 auth_method->name, user_info->smb_name.str));
+                       DEBUG(3, ("check_ntlm_password: %s authentication for user [%s] succeeded\n", 
+                                 auth_method->name, user_info->smb_name));
                } else {
                        DEBUG(5, ("check_ntlm_password: %s authentication for user [%s] FAILED with error %s\n", 
-                                 auth_method->name, user_info->smb_name.str, nt_errstr(nt_status)));
+                                 auth_method->name, user_info->smb_name, nt_errstr(nt_status)));
                }
 
                talloc_destroy(mem_ctx);
 
-               if (NT_STATUS_IS_OK(nt_status))
-                       break;
+               if ( NT_STATUS_IS_OK(nt_status))
+               {
+                               break;                  
+               }
        }
 
+       /* successful authentication */
+       
        if (NT_STATUS_IS_OK(nt_status)) {
-               pdb_username = pdb_get_username((*server_info)->sam_account);
+               unix_username = (*server_info)->unix_name;
                if (!(*server_info)->guest) {
                        /* We might not be root if we are an RPC call */
                        become_root();
-                       nt_status = smb_pam_accountcheck(pdb_username);
+                       nt_status = smb_pam_accountcheck(unix_username);
                        unbecome_root();
                        
                        if (NT_STATUS_IS_OK(nt_status)) {
-                               DEBUG(5, ("check_ntlm_password:  PAM Account for user [%s] suceeded\n", 
-                                         pdb_username));
+                               DEBUG(5, ("check_ntlm_password:  PAM Account for user [%s] succeeded\n", 
+                                         unix_username));
                        } else {
                                DEBUG(3, ("check_ntlm_password:  PAM Account for user [%s] FAILED with error %s\n", 
-                                         pdb_username, nt_errstr(nt_status)));
+                                         unix_username, nt_errstr(nt_status)));
                        } 
                }
                
                if (NT_STATUS_IS_OK(nt_status)) {
                        DEBUG((*server_info)->guest ? 5 : 2, 
-                             ("check_ntlm_password:  %sauthentication for user [%s] -> [%s] -> [%s] suceeded\n", 
+                             ("check_ntlm_password:  %sauthentication for user [%s] -> [%s] -> [%s] succeeded\n", 
                               (*server_info)->guest ? "guest " : "", 
-                              user_info->smb_name.str
-                              user_info->internal_username.str
-                              pdb_username));
+                              user_info->smb_name, 
+                              user_info->internal_username, 
+                              unix_username));
                }
+               
+               return nt_status;
        }
-
-       if (!NT_STATUS_IS_OK(nt_status)) {
-               DEBUG(2, ("check_ntlm_password:  Authentication for user [%s] -> [%s] FAILED with error %s\n", 
-                         user_info->smb_name.str, user_info->internal_username.str, 
-                         nt_errstr(nt_status)));
-               ZERO_STRUCTP(server_info);
-       }
+       
+       /* failed authentication; check for guest lapping */
+       
+       DEBUG(2, ("check_ntlm_password:  Authentication for user [%s] -> [%s] FAILED with error %s\n", 
+                 user_info->smb_name, user_info->internal_username, 
+                 nt_errstr(nt_status)));
+       ZERO_STRUCTP(server_info); 
+       
        return nt_status;
 }
 
@@ -304,9 +328,20 @@ static NTSTATUS check_ntlm_password(const struct auth_context *auth_context,
 
 static void free_auth_context(struct auth_context **auth_context)
 {
-       if (*auth_context != NULL)
+       auth_methods *auth_method;
+
+       if (*auth_context) {
+               /* Free private data of context's authentication methods */
+               for (auth_method = (*auth_context)->auth_method_list; auth_method; auth_method = auth_method->next) {
+                       if (auth_method->free_private_data) {
+                               auth_method->free_private_data (&auth_method->private_data);
+                               auth_method->private_data = NULL;
+                       }
+               }
+
                talloc_destroy((*auth_context)->mem_ctx);
-       *auth_context = NULL;
+               *auth_context = NULL;
+       }
 }
 
 /***************************************************************************
@@ -319,7 +354,7 @@ static NTSTATUS make_auth_context(struct auth_context **auth_context)
 
        mem_ctx = talloc_init("authentication context");
        
-       *auth_context = talloc(mem_ctx, sizeof(**auth_context));
+       *auth_context = TALLOC_P(mem_ctx, struct auth_context);
        if (!*auth_context) {
                DEBUG(0,("make_auth_context: talloc failed!\n"));
                talloc_destroy(mem_ctx);
@@ -359,10 +394,10 @@ BOOL load_auth_module(struct auth_context *auth_context,
        if (p) {
                *p = 0;
                module_params = p+1;
-               trim_string(module_params, " ", " ");
+               trim_char(module_params, ' ', ' ');
        }
        
-       trim_string(module_name, " ", " ");
+       trim_char(module_name, ' ', ' ');
        
        entry = auth_find_backend_entry(module_name);
        
@@ -445,8 +480,13 @@ NTSTATUS make_auth_context_subsystem(struct auth_context **auth_context)
                        break;
                case SEC_USER:
                        if (lp_encrypted_passwords()) { 
-                               DEBUG(5,("Making default auth method list for security=user, encrypt passwords = yes\n"));
-                               auth_method_list = str_list_make("guest sam", NULL);
+                               if ((lp_server_role() == ROLE_DOMAIN_PDC) || (lp_server_role() == ROLE_DOMAIN_BDC)) {
+                                       DEBUG(5,("Making default auth method list for DC, security=user, encrypt passwords = yes\n"));
+                                       auth_method_list = str_list_make("guest sam winbind:trustdomain", NULL);
+                               } else {
+                                       DEBUG(5,("Making default auth method list for standalone security=user, encrypt passwords = yes\n"));
+                                       auth_method_list = str_list_make("guest sam", NULL);
+                               }
                        } else {
                                DEBUG(5,("Making default auth method list for security=user, encrypt passwords = no\n"));
                                auth_method_list = str_list_make("guest unix", NULL);
@@ -493,7 +533,7 @@ NTSTATUS make_auth_context_fixed(struct auth_context **auth_context, uchar chal[
                return nt_status;
        }
        
-       (*auth_context)->challenge = data_blob(chal, 8);
+       (*auth_context)->challenge = data_blob_talloc((*auth_context)->mem_ctx, chal, 8);
        (*auth_context)->challenge_set_by = "fixed";
        return nt_status;
 }