* make_stream_binary is now public for reuse. (Robert Collins)
authorRobert Collins <robertc@robertcollins.net>
Thu, 7 Feb 2013 07:36:46 +0000 (20:36 +1300)
committerRobert Collins <robertc@robertcollins.net>
Thu, 7 Feb 2013 07:36:46 +0000 (20:36 +1300)
* NAME was not defined in the protocol BNF. (Robert Collins)

NEWS
README
python/subunit/__init__.py

diff --git a/NEWS b/NEWS
index 93c87cc..0457607 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -8,6 +8,10 @@ NEXT (In development)
 BUG FIXES
 ~~~~~~~~~
 
+* make_stream_binary is now public for reuse. (Robert Collins)
+
+* NAME was not defined in the protocol BNF. (Robert Collins)
+
 * UnsupportedOperation is available in the Python2.6 io library, so ask
   forgiveness rather than permission for obtaining it. (Robert Collins)
 
diff --git a/README b/README
index 103a32c..e397195 100644 (file)
--- a/README
+++ b/README
@@ -163,6 +163,7 @@ tags: [-]TAG ...
 time: YYYY-MM-DD HH:MM:SSZ
 
 LABEL: UTF8*
+NAME: UTF8*
 DETAILS ::= BRACKETED | MULTIPART
 BRACKETED ::= '[' CR UTF8-lines ']' CR
 MULTIPART ::= '[ multipart' CR PART* ']' CR
index dfc5e94..f870904 100644 (file)
@@ -624,7 +624,7 @@ class TestProtocolClient(testresult.TestResult):
 
     def __init__(self, stream):
         testresult.TestResult.__init__(self)
-        stream = _make_stream_binary(stream)
+        stream = make_stream_binary(stream)
         self._stream = stream
         self._progress_fmt = _b("progress: ")
         self._bytes_eol = _b("\n")
@@ -921,7 +921,7 @@ class ExecTestCase(unittest.TestCase):
         protocol = TestProtocolServer(result)
         process = subprocess.Popen(self.script, shell=True,
             stdout=subprocess.PIPE)
-        _make_stream_binary(process.stdout)
+        make_stream_binary(process.stdout)
         output = process.communicate()[0]
         protocol.readFrom(BytesIO(output))
 
@@ -1177,11 +1177,11 @@ class ProtocolTestCase(object):
         :param forward: A stream to pass subunit input on to. If not supplied
             subunit input is not forwarded.
         """
-        stream = _make_stream_binary(stream)
+        stream = make_stream_binary(stream)
         self._stream = stream
         self._passthrough = passthrough
         if forward is not None:
-            forward = _make_stream_binary(forward)
+            forward = make_stream_binary(forward)
         self._forward = forward
 
     def __call__(self, result=None):
@@ -1277,7 +1277,7 @@ def read_test_list(path):
         f.close()
 
 
-def _make_stream_binary(stream):
+def make_stream_binary(stream):
     """Ensure that a stream will be binary safe. See _make_binary_on_windows.
     
     :return: A binary version of the same stream (some streams cannot be