sambatool sites: PEP8/flake8 improvements

We were nearly there, so lets make the jump. This involves removing
some unused variables.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>

diff --git a/python/samba/netcmd/sites.py b/python/samba/netcmd/sites.py
index 09df55ec9c5f8087251a45a608e7e4a1c2fc56c6..2d802c99b57c8e7f45accfd4afb892aa7892712f 100644 (file)
--- a/python/samba/netcmd/sites.py
+++ b/python/samba/netcmd/sites.py
@@ -16,7 +16,6 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 
-import os
 from samba import sites
 from samba.samdb import SamDB
 import samba.getopt as options
@@ -53,14 +52,16 @@ class cmd_sites_create(Command):
 
         samdb.transaction_start()
         try:
-            ok = sites.create_site(samdb, samdb.get_config_basedn(), sitename)
+            sites.create_site(samdb, samdb.get_config_basedn(), sitename)
             samdb.transaction_commit()
         except sites.SiteAlreadyExistsException, e:
             samdb.transaction_cancel()
-            raise CommandError("Error while creating site %s, error: %s" % (sitename, str(e)))
+            raise CommandError("Error while creating site %s, error: %s" %
+                               (sitename, str(e)))
 
         self.outf.write("Site %s created !\n" % sitename)
 
+
 class cmd_sites_delete(Command):
     """Delete an existing site."""
 
@@ -86,7 +87,7 @@ class cmd_sites_delete(Command):
 
         samdb.transaction_start()
         try:
-            ok = sites.delete_site(samdb, samdb.get_config_basedn(), sitename)
+            sites.delete_site(samdb, samdb.get_config_basedn(), sitename)
             samdb.transaction_commit()
         except sites.SiteException, e:
             samdb.transaction_cancel()

diff --git a/python/samba/sites.py b/python/samba/sites.py
index 76c57dd11cfe0a94ed47ce33b9983d7c14d8668d..05e5340d63d5fe661ee872e8e8889f64d020afe7 100644 (file)
--- a/python/samba/sites.py
+++ b/python/samba/sites.py
@@ -94,6 +94,7 @@ def create_site(samdb, configDn, siteName):
 
     return True
 
+
 def delete_site(samdb, configDn, siteName):
     """
     Delete a site