CVE-2016-0771: s4:librpc: python_dns and python_dcerpc_dnsp doesn't require client...

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11686
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11128

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/librpc/idl/dns.idl b/librpc/idl/dns.idl
index d247e0e67d59f9fbc7069b801cebb673eaaa2e34..1183bd122993fb4d6f0e1fa9ea606552bcc6b710 100644 (file)
--- a/librpc/idl/dns.idl
+++ b/librpc/idl/dns.idl
@@ -270,7 +270,7 @@ interface dns
         /*
           this is a convenience hook for ndrdump
        */
-       void decode_dns_name_packet(
+       [nopython] void decode_dns_name_packet(
                                    [in] dns_name_packet packet
                                   );
 }

diff --git a/librpc/idl/dnsp.idl b/librpc/idl/dnsp.idl
index 4c49001c85679bec0cd93f1f76a326b2682ff5c0..d705cfcbfa31ff4c08f40e0f18776fa89dc3cf86 100644 (file)
--- a/librpc/idl/dnsp.idl
+++ b/librpc/idl/dnsp.idl
@@ -263,11 +263,11 @@ interface dnsp
        /*
          these are convenience hooks for ndrdump
         */
-       void decode_DnssrvRpcRecord(
+       [nopython] void decode_DnssrvRpcRecord(
                [in] dnsp_DnssrvRpcRecord blob
                );
 
-       void decode_DnsProperty(
+       [nopython] void decode_DnsProperty(
                [in] dnsp_DnsProperty blob
                );
 }

diff --git a/source4/librpc/wscript_build b/source4/librpc/wscript_build
index 5100ae80464d4c6f422a3c39db05c905b6c66e56..a28669ad061fa09ace0938e3969436e339625b97 100755 (executable)
--- a/source4/librpc/wscript_build
+++ b/source4/librpc/wscript_build
@@ -153,7 +153,7 @@ bld.SAMBA_PYTHON('python_echo',
 
 bld.SAMBA_PYTHON('python_dns',
        source='../../librpc/gen_ndr/py_dns.c',
-       deps='RPC_NDR_DNS pytalloc-util pyrpc_util',
+       deps='NDR_DNS pytalloc-util pyrpc_util',
        realname='samba/dcerpc/dns.so'
        )
 
@@ -310,7 +310,7 @@ bld.SAMBA_PYTHON('python_dcerpc_drsblobs',
 
 bld.SAMBA_PYTHON('python_dcerpc_dnsp',
        source='../../librpc/gen_ndr/py_dnsp.c',
-       deps='pytalloc-util pyrpc_util NDR_SECURITY RPC_NDR_DNSP',
+       deps='pytalloc-util pyrpc_util NDR_SECURITY NDR_DNSP',
        realname='samba/dcerpc/dnsp.so'
        )