pidl/ws: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
authorAurelien Aptel <aaptel@suse.com>
Fri, 5 Feb 2016 13:29:22 +0000 (14:29 +0100)
committerStefan Metzmacher <metze@samba.org>
Mon, 20 Jun 2016 10:08:19 +0000 (12:08 +0200)
Port Wireshark commit f0b5fb7

Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
Date:   Fri Sep 26 21:31:32 2014 +0200

    PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

    Change-Id: I7f6f974732b7905f4ea4686e1a79ca6fbef78fa8
    Reviewed-on: https://code.wireshark.org/review/4319
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Signed-off-by: Aurelien Aptel <aaptel@suse.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
pidl/lib/Parse/Pidl/Wireshark/NDR.pm

index caa58c2a26a46cbbc9e845eb6f4a40f905736bc1..158564f7bfb1c5fd37735fcf6422a9c09a1b5681 100644 (file)
@@ -227,7 +227,7 @@ sub Bitmap($$$$)
        $self->deindent;
        $self->pidl_code("}\n");
 
-       $self->pidl_code("offset = dissect_ndr_$e->{BASE_TYPE}(tvb, offset, pinfo, NULL, drep, -1, &flags);");
+       $self->pidl_code("offset = dissect_ndr_$e->{BASE_TYPE}(tvb, offset, pinfo, tree, di, drep, -1, &flags);");
 
        $self->pidl_code("proto_item_append_text(item, \": \");\n");
        $self->pidl_code("if (!flags)");