s3: printing: Remove the LSEEK in printing_pread_data() and use read_file() instead.
authorJeremy Allison <jra@samba.org>
Tue, 1 May 2018 18:51:43 +0000 (11:51 -0700)
committerRalph Boehme <slow@samba.org>
Fri, 4 May 2018 20:34:24 +0000 (22:34 +0200)
Removes last-but-one user of SMB_VFS_READ.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/printing/nt_printing.c

index 6bc48ae36343307fc9efc23ecf0cde75cbfb086b..a96122a15b206b61842c43b36dbc4dabb24571aa 100644 (file)
@@ -324,17 +324,15 @@ static ssize_t printing_pread_data(files_struct *fsp,
        size_t total=0;
        off_t in_pos = *poff;
 
-       in_pos = SMB_VFS_LSEEK(fsp, in_pos, SEEK_SET);
-       if (in_pos == (off_t)-1) {
-               return -1;
-       }
        /* Don't allow integer wrap on read. */
        if (in_pos + byte_count < in_pos) {
                return -1;
        }
 
        while (total < byte_count) {
-               ssize_t ret = SMB_VFS_READ(fsp, buf + total,
+               ssize_t ret = read_file(fsp,
+                                       buf + total,
+                                       in_pos,
                                        byte_count - total);
 
                if (ret == 0) {