s3/utils: smbcacls failed to detect DIRECTORIES using SMB2 (windows only)
authorNoel Power <noel.power@suse.com>
Thu, 20 Jul 2017 12:01:50 +0000 (13:01 +0100)
committerDavid Disseldorp <ddiss@samba.org>
Thu, 20 Jul 2017 16:49:27 +0000 (18:49 +0200)
commitc57dcafb150823b00fd873046e65a966a8488fa8
tree7716a0bb04ed87be55a3056ed549812ee6dafa73
parent7313e7c10df438fdf980ff9da80637df9f8dcb89
s3/utils: smbcacls failed to detect DIRECTORIES using SMB2 (windows only)

uint16_t get_fileinfo(...) returns file attributes, this function
called

     cli_qfileinfo_basic(cli, fnum, &mode, NULL, NULL, NULL,
                     NULL, NULL, NULL);

which was failing with NT_STATUS_ACCESS_DENIED errors when fnum above
was obtained via (when using protocol > SMB). Note: This only seems to be
an issue when run against a windows server, with smbd SMB1 & SMB2 work fine.

    status = cli_ntcreate(cli, filename, 0, CREATE_ACCESS_READ,
                  0, FILE_SHARE_READ|FILE_SHARE_WRITE,
                  FILE_OPEN, 0x0, 0x0, &fnum, NULL);

The failing cli_qfileinfo_basic call above is unnecessary as we can already
obtain the required information from the cli_ntcreate call

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
source3/utils/smbcacls.c