sfrench/samba-autobuild/.git
16 years agor25598: Add missing become_root/unbecome_root around calls of add_aliases. samba-misc-tags/initial-v3-2-unstable
Michael Adam [Wed, 10 Oct 2007 08:27:56 +0000 (08:27 +0000)]
r25598: Add missing become_root/unbecome_root around calls of add_aliases.
This triggered a "cannot access LDAP when not root"-bug with
"passdb backend = ldap" and "winbind nested groups = yes".

This *might* be a step towards fixing bug #4308, since the
failure was observerd when triggered by acl code.

Michael

16 years agor25593: Add missing security_secinfo bits as seen while managing security descriptor
Günther Deschner [Tue, 9 Oct 2007 16:22:16 +0000 (16:22 +0000)]
r25593: Add missing security_secinfo bits as seen while managing security descriptor
inheritance with regedit.

Guenther

16 years agor25592: Allow to set sec_info for registry security descriptor queries.
Günther Deschner [Tue, 9 Oct 2007 13:53:40 +0000 (13:53 +0000)]
r25592: Allow to set sec_info for registry security descriptor queries.

Guenther

16 years agor25587: Fix getaddrinfo detection code. From Timur.
Jeremy Allison [Mon, 8 Oct 2007 23:11:33 +0000 (23:11 +0000)]
r25587: Fix getaddrinfo detection code. From Timur.
Jeremy.

16 years agor25584: don't run WINBIND tests untill the faked users work with a running winbindd
Stefan Metzmacher [Mon, 8 Oct 2007 20:05:46 +0000 (20:05 +0000)]
r25584: don't run WINBIND tests untill the faked users work with a running winbindd

metze

16 years agor25583: it makes no sense to run blackbox.kinit against samba3
Stefan Metzmacher [Mon, 8 Oct 2007 18:04:07 +0000 (18:04 +0000)]
r25583: it makes no sense to run blackbox.kinit against samba3

metze

16 years agor25575: Document S-1-5-12 (restriced code sid).
Günther Deschner [Mon, 8 Oct 2007 13:31:08 +0000 (13:31 +0000)]
r25575: Document S-1-5-12 (restriced code sid).

Guenther

16 years agor25573: Add my (C) as well
Simo Sorce [Mon, 8 Oct 2007 12:56:57 +0000 (12:56 +0000)]
r25573: Add my (C) as well

16 years agor25572: Fix warnings (values are always true).
Jelmer Vernooij [Mon, 8 Oct 2007 12:56:27 +0000 (12:56 +0000)]
r25572: Fix warnings (values are always true).

16 years agor25571: split up child_dispatch_table into domain, idmap and locator tables
Stefan Metzmacher [Mon, 8 Oct 2007 12:25:57 +0000 (12:25 +0000)]
r25571: split up child_dispatch_table into domain, idmap and locator tables

metze

16 years agor25570: move code of the locator child into its own file
Stefan Metzmacher [Mon, 8 Oct 2007 11:15:28 +0000 (11:15 +0000)]
r25570: move code of the locator child into its own file

metze

16 years agor25569: move more idmap stuff into winbindd_idmap.c
Stefan Metzmacher [Mon, 8 Oct 2007 11:13:36 +0000 (11:13 +0000)]
r25569: move more idmap stuff into winbindd_idmap.c

metze

16 years agor25568: move idmap related functions into their own file.
Stefan Metzmacher [Mon, 8 Oct 2007 11:11:46 +0000 (11:11 +0000)]
r25568: move idmap related functions into their own file.

the final goal is to have 3 child dispatch tables
'domain', 'idmap' and 'locator' instead of one.

metze

16 years agor25567: make do_async() non static
Stefan Metzmacher [Mon, 8 Oct 2007 10:54:33 +0000 (10:54 +0000)]
r25567: make do_async() non static

metze

16 years agor25565: Fix unintended consequence change for IPv6 noticed
Jeremy Allison [Mon, 8 Oct 2007 02:48:03 +0000 (02:48 +0000)]
r25565: Fix unintended consequence change for IPv6 noticed
by Volker. We used to return 0.0.0.0 for the text
address of an uninitialized socket - ensure we
still do so. Once uninitialized address is as
good as any other.
Jeremy.

16 years agor25564: Pass sharename to delete_share_security()
Volker Lendecke [Sun, 7 Oct 2007 17:58:48 +0000 (17:58 +0000)]
r25564: Pass sharename to delete_share_security()

16 years agor25563: Show which local-substitute subtest fails
Volker Lendecke [Sun, 7 Oct 2007 13:36:56 +0000 (13:36 +0000)]
r25563: Show which local-substitute subtest fails

16 years agor25561: Make use of [un]marshall_sec_desc
Volker Lendecke [Sun, 7 Oct 2007 12:56:43 +0000 (12:56 +0000)]
r25561: Make use of [un]marshall_sec_desc

Minor cleanup only

16 years agor25560: Merge from Jelmer. "Define HAVE_* for other gai functions to prevent problems...
Jeremy Allison [Sun, 7 Oct 2007 04:28:01 +0000 (04:28 +0000)]
r25560: Merge from Jelmer. "Define HAVE_* for other gai functions to prevent problems with libroken."
Jeremy.

16 years agor25557: merge libreplace fixes from samba4
Jelmer Vernooij [Sat, 6 Oct 2007 23:07:33 +0000 (23:07 +0000)]
r25557: merge libreplace fixes from samba4

16 years agor25538: Revert r25533
Volker Lendecke [Fri, 5 Oct 2007 22:06:24 +0000 (22:06 +0000)]
r25538: Revert r25533

16 years agor25534: Apply some const
Volker Lendecke [Fri, 5 Oct 2007 21:41:17 +0000 (21:41 +0000)]
r25534: Apply some const

Why? It moves these structs from the data into the text segment, so they
will never been copy-on-write copied. Not much, but as in German you say
"Kleinvieh macht auch Mist...."

16 years agor25533: remove a pstring
Volker Lendecke [Fri, 5 Oct 2007 21:28:54 +0000 (21:28 +0000)]
r25533: remove a pstring

16 years agor25528: Only do transactions on registry.tdb if anything changes
Volker Lendecke [Fri, 5 Oct 2007 20:42:14 +0000 (20:42 +0000)]
r25528: Only do transactions on registry.tdb if anything changes

I got annoyed by the fsync calls clobbering my harddrive when smbd started up
for debugging.

... things you do on a plane without internet

16 years agor25526: Fix usage output.
Günther Deschner [Fri, 5 Oct 2007 20:08:48 +0000 (20:08 +0000)]
r25526: Fix usage output.

Guenther

16 years agor25525: Add "net rpc registry getsd <keyname>" to display security descriptors.
Günther Deschner [Fri, 5 Oct 2007 20:07:18 +0000 (20:07 +0000)]
r25525: Add "net rpc registry getsd <keyname>" to display security descriptors.

Guenther

16 years agor25511: Fix sockaddr_in6 detection.
Jeremy Allison [Fri, 5 Oct 2007 02:03:29 +0000 (02:03 +0000)]
r25511: Fix sockaddr_in6 detection.
Jeremy.

16 years agor25510: Now we're returning the port instead of using a global,
Jeremy Allison [Fri, 5 Oct 2007 01:11:33 +0000 (01:11 +0000)]
r25510: Now we're returning the port instead of using a global,
remember to use ntohs. Hopefully will fix the build farm.
Jeremy.

16 years agor25508: Reformatting.
Jeremy Allison [Thu, 4 Oct 2007 18:23:22 +0000 (18:23 +0000)]
r25508: Reformatting.
Jeremy.

16 years agor25507: Fix definition of struct sockaddr_storage if
Jeremy Allison [Thu, 4 Oct 2007 17:35:12 +0000 (17:35 +0000)]
r25507: Fix definition of struct sockaddr_storage if
struct sockaddr_in6 is defined.
Jeremy.

16 years agor25505: Add a replacement (IPv4 only) implementation of getaddrinfo/freeaddrinfo
Jeremy Allison [Thu, 4 Oct 2007 17:20:49 +0000 (17:20 +0000)]
r25505: Add a replacement (IPv4 only) implementation of getaddrinfo/freeaddrinfo
under the 2 clause *BSD license for future use in IPv6 code. Original
code was from PostgreSQL and I've maintained their license even though
I've rewritten large parts of it (I probably should donate this back
to them).
Jeremy.

16 years agor25503: ignore failing WINBIND tests
Stefan Metzmacher [Thu, 4 Oct 2007 14:45:57 +0000 (14:45 +0000)]
r25503: ignore failing WINBIND tests

we should get the them going without ignoring error...

metze

16 years agor25502: Fix bug 5006
Volker Lendecke [Thu, 4 Oct 2007 13:13:16 +0000 (13:13 +0000)]
r25502: Fix bug 5006

Thanks to Joerg.Bernau at web.de

16 years agor25499: Fix rpc_file_list_internals
Volker Lendecke [Thu, 4 Oct 2007 00:10:54 +0000 (00:10 +0000)]
r25499: Fix rpc_file_list_internals

16 years agor25498: Remove checks that are always true.
Jelmer Vernooij [Wed, 3 Oct 2007 22:23:37 +0000 (22:23 +0000)]
r25498: Remove checks that are always true.

16 years agor25495: Fixup definitions for missing sockaddr_storage.
Jeremy Allison [Wed, 3 Oct 2007 22:01:25 +0000 (22:01 +0000)]
r25495: Fixup definitions for missing sockaddr_storage.
Jeremy.

16 years agor25494: Sanity check --with-samba4srcdir argument.
Jelmer Vernooij [Wed, 3 Oct 2007 21:14:20 +0000 (21:14 +0000)]
r25494: Sanity check --with-samba4srcdir argument.

16 years agor25493: Fix typo in Jeremy's thread-safe winbind patch:
Jim McDonough [Wed, 3 Oct 2007 20:56:29 +0000 (20:56 +0000)]
r25493: Fix typo in Jeremy's thread-safe winbind patch:
lock->unlock (would have tried to lock a mutex
at the end of a function).  Cut-n-paste error.

16 years agor25492: Start adding IPv6 compatible code to lib/util_sock.c and deal with
Jeremy Allison [Wed, 3 Oct 2007 20:43:55 +0000 (20:43 +0000)]
r25492: Start adding IPv6 compatible code to lib/util_sock.c and deal with
the ripple effects this causes. utmp has to change etc. Remove some
global varables and store address/port in the unexpected db.
Jeremy.

16 years agor25487: Try fix the build - fix socklen_t and sa_family_t.
Jeremy Allison [Wed, 3 Oct 2007 19:12:39 +0000 (19:12 +0000)]
r25487: Try fix the build - fix socklen_t and sa_family_t.
Jeremy.

16 years agor25484: Fix srvsrc_NetFileEnum listing only for one user
Volker Lendecke [Wed, 3 Oct 2007 18:37:57 +0000 (18:37 +0000)]
r25484: Fix srvsrc_NetFileEnum listing only for one user

16 years agor25482: Slightly simplify logic
Volker Lendecke [Wed, 3 Oct 2007 13:13:02 +0000 (13:13 +0000)]
r25482: Slightly simplify logic

Instead of one big if-branch for if (process_exists(..)) return if
(!process_exists(..))

16 years agor25481: Fix some typos, don't panic as non-root on net getdomainsid
Volker Lendecke [Wed, 3 Oct 2007 12:55:45 +0000 (12:55 +0000)]
r25481: Fix some typos, don't panic as non-root on net getdomainsid

Thanks to Karolin Seeger <ks@sernet.de>

16 years agor25480: Fix a segfault
Volker Lendecke [Wed, 3 Oct 2007 12:51:36 +0000 (12:51 +0000)]
r25480: Fix a segfault

16 years agor25476: Finally fix up new interface detection code :-).
Jeremy Allison [Tue, 2 Oct 2007 21:12:01 +0000 (21:12 +0000)]
r25476: Finally fix up new interface detection code :-).
Jeremy.

16 years agor25475: Fix braindead mistakes I made pointed out by Simo and
Jeremy Allison [Tue, 2 Oct 2007 20:39:41 +0000 (20:39 +0000)]
r25475: Fix braindead mistakes I made pointed out by Simo and
James (how did this compile ? :-).
Jeremy.

16 years agor25474: Try and fix the build on Mac OS X 10.4.9.
Jeremy Allison [Tue, 2 Oct 2007 20:04:14 +0000 (20:04 +0000)]
r25474: Try and fix the build on Mac OS X 10.4.9.
Shuffle sa_family_t around.
Jeremy.

16 years agor25473: Reformatting only. Prepare for new ip functions.
Jeremy Allison [Tue, 2 Oct 2007 19:50:53 +0000 (19:50 +0000)]
r25473: Reformatting only. Prepare for new ip functions.
Jeremy.

16 years agor25472: Fix the interfaces code to detect IPv6 interfaces, using the
Jeremy Allison [Tue, 2 Oct 2007 19:27:25 +0000 (19:27 +0000)]
r25472: Fix the interfaces code to detect IPv6 interfaces, using the
new standard getifaddrs() and freeifaddrs() interfaces. Currently
we only return IPv4 af_families. Needs fixing for binds to IPv6
but this has to be careful work.
Jeremy.

16 years agor25470: use --immediate like in samba4 to get more usefull output
Stefan Metzmacher [Tue, 2 Oct 2007 16:13:30 +0000 (16:13 +0000)]
r25470: use --immediate like in samba4 to get more usefull output

metze

16 years agor25455: Ensure we have inet_ntop and inet_pton available in lib/replace.
Jeremy Allison [Mon, 1 Oct 2007 23:18:26 +0000 (23:18 +0000)]
r25455: Ensure we have inet_ntop and inet_pton available in lib/replace.
Jeremy.

16 years agor25445: Fix IPV6 detection.
Jeremy Allison [Mon, 1 Oct 2007 18:30:01 +0000 (18:30 +0000)]
r25445: Fix IPV6 detection.
Jeremy.

16 years agor25441: Make wbinfo --sequence output the sequence number if --domain
Michael Adam [Mon, 1 Oct 2007 15:35:05 +0000 (15:35 +0000)]
r25441: Make wbinfo --sequence output the sequence number if --domain
is specified.

Michael

16 years agor25434: Add the option to print the debug class (DBGC_CLASS) in the debug header.
Michael Adam [Sun, 30 Sep 2007 08:07:06 +0000 (08:07 +0000)]
r25434: Add the option to print the debug class (DBGC_CLASS) in the debug header.
Control this by a new boolean smb.conf option "debug class" which is
by default set to "no" to keep the default debug header unchanged.

Michael

Note: You need to make clean for this patch.

16 years agor25432: Merge module linking changes from SAMBA_3_2 to SAMBA_3_2_0 to reduce
James Peach [Sat, 29 Sep 2007 23:54:32 +0000 (23:54 +0000)]
r25432: Merge module linking changes from SAMBA_3_2 to SAMBA_3_2_0 to reduce
spurious tree differences.

16 years agor25431: Add detection for IPv6 support.
Jeremy Allison [Sat, 29 Sep 2007 23:43:24 +0000 (23:43 +0000)]
r25431: Add detection for IPv6 support.
Jeremy.

16 years agor25429: Samba 3 doesn't need to selftest Samba4 code...
Stefan Metzmacher [Sat, 29 Sep 2007 15:17:49 +0000 (15:17 +0000)]
r25429: Samba 3 doesn't need to selftest Samba4 code...

metze

16 years agor25426: Fix another implicit cast warning.
Michael Adam [Sat, 29 Sep 2007 08:25:44 +0000 (08:25 +0000)]
r25426: Fix another implicit cast warning.

Michael

16 years agor25424: Align log level (by two) in debugging output.
Michael Adam [Sat, 29 Sep 2007 07:18:23 +0000 (07:18 +0000)]
r25424: Align log level (by two) in debugging output.

Michael

16 years agor25422: Get rid of some cast warnings.
Michael Adam [Sat, 29 Sep 2007 06:44:39 +0000 (06:44 +0000)]
r25422: Get rid of some cast warnings.

16 years agor25418: fix generation of git revision calculation
Stefan Metzmacher [Fri, 28 Sep 2007 23:39:32 +0000 (23:39 +0000)]
r25418: fix generation of git revision calculation

metze

16 years agor25417: Use DBGC_REGISTRY class.
Günther Deschner [Fri, 28 Sep 2007 23:05:52 +0000 (23:05 +0000)]
r25417: Use DBGC_REGISTRY class.

Guenther

16 years agor25416: Add registry debug class.
Günther Deschner [Fri, 28 Sep 2007 23:03:08 +0000 (23:03 +0000)]
r25416: Add registry debug class.

Guenther

16 years agor25415: Merge the 3.2-perltest branch that switches Samba 3.2 to use Samba 4's selfte...
Jelmer Vernooij [Fri, 28 Sep 2007 22:16:14 +0000 (22:16 +0000)]
r25415: Merge the 3.2-perltest branch that switches Samba 3.2 to use Samba 4's selftest code. See the mailing list for details.

16 years agor25407: Revert Longhorn join patch as it is not correct for the 3.2 tree.
Gerald Carter [Fri, 28 Sep 2007 18:15:34 +0000 (18:15 +0000)]
r25407: Revert Longhorn join patch as it is not correct for the 3.2 tree.

The translate_name() used by cli_session_setup_spnego() cann rely
Winbindd since it is needed by the join process (and hence before
Winbind can be run).

16 years agor25406: Make the Linux nss client code thread-safe.
Jeremy Allison [Fri, 28 Sep 2007 18:12:22 +0000 (18:12 +0000)]
r25406: Make the Linux nss client code thread-safe.
Fix originally inspired from code from boyang <yyyeer.bo@gmail.com>.
Jeremy.

16 years agor25405: Fix formatting as per metze's comments
Gerald Carter [Fri, 28 Sep 2007 18:09:50 +0000 (18:09 +0000)]
r25405: Fix formatting as per metze's comments

16 years agor25402: BUG 4997 (3.2 only): Fix enumration level for smbtree
Gerald Carter [Fri, 28 Sep 2007 04:08:58 +0000 (04:08 +0000)]
r25402: BUG 4997 (3.2 only): Fix enumration level for smbtree

16 years agor25401: BUG 4982: Don't delete lanman hashes on invalid logins when
Gerald Carter [Fri, 28 Sep 2007 03:56:12 +0000 (03:56 +0000)]
r25401: BUG 4982: Don't delete lanman hashes on invalid logins when
using the "lanman auth = no".  Tested by Guenter Kukkukk.

16 years agor25400: Windows 2008 (Longhorn) Interop fixes for AD specific auth2 flags,
Gerald Carter [Fri, 28 Sep 2007 03:54:42 +0000 (03:54 +0000)]
r25400: Windows 2008 (Longhorn) Interop fixes for AD specific auth2 flags,
and client fixes.  Patch from Todd Stetcher <todd.stetcher@isilon.com>.

16 years agor25399: Excise uint - > uint32 (where appropriate) or unsigned int.
Jeremy Allison [Fri, 28 Sep 2007 01:32:08 +0000 (01:32 +0000)]
r25399: Excise uint - > uint32 (where appropriate) or unsigned int.
Jeremy.

16 years agor25396: Very obvious fix from Martin Zielinski.
Günther Deschner [Fri, 28 Sep 2007 01:02:11 +0000 (01:02 +0000)]
r25396: Very obvious fix from Martin Zielinski.

Guenther

16 years agor25393: Removed unused variable
Gerald Carter [Thu, 27 Sep 2007 23:33:35 +0000 (23:33 +0000)]
r25393: Removed unused variable

16 years agor25391: Fix bug #4978 : Store DOS Attributes fails when copying folders.
Jeremy Allison [Thu, 27 Sep 2007 23:28:35 +0000 (23:28 +0000)]
r25391: Fix bug #4978 : Store DOS Attributes fails when copying folders.
Jeremy.

16 years agor25389: Fix crash bug using DFS info struct uninitialized.
Jeremy Allison [Thu, 27 Sep 2007 22:55:11 +0000 (22:55 +0000)]
r25389: Fix crash bug using DFS info struct uninitialized.
Jeremy.

16 years agor25380: Remove the groupdb:mapping parameter as discussed in the following thread:
Gerald Carter [Thu, 27 Sep 2007 20:12:40 +0000 (20:12 +0000)]
r25380: Remove the groupdb:mapping parameter as discussed in the following thread:
http://lists.samba.org/archive/samba-technical/2007-June/053747.html

16 years agor25378: Add a vim configuration example to highlight overly long lines.
Michael Adam [Thu, 27 Sep 2007 19:20:37 +0000 (19:20 +0000)]
r25378: Add a vim configuration example to highlight overly long lines.

16 years agor25370: Allow to delete registry keys recursively without deleting the final key.
Günther Deschner [Thu, 27 Sep 2007 01:26:19 +0000 (01:26 +0000)]
r25370: Allow to delete registry keys recursively without deleting the final key.

Guenther

16 years agor25362: Add "NT Authority\System" with Full Access to the default registry security
Günther Deschner [Wed, 26 Sep 2007 21:46:43 +0000 (21:46 +0000)]
r25362: Add "NT Authority\System" with Full Access to the default registry security
descriptor.

Guenther

16 years agor25355: IP address parsing did not allow for fully expanded ipv6 addresses
Steve French [Wed, 26 Sep 2007 18:36:38 +0000 (18:36 +0000)]
r25355: IP address parsing did not allow for fully expanded ipv6 addresses
(which can be 12 bytes longer than we were allowing for).

Thanks to Dr. David Holder

16 years agor25328: When using ldap sasl wrapping with gssapi it's important to receive warnings
Günther Deschner [Wed, 26 Sep 2007 01:02:52 +0000 (01:02 +0000)]
r25328: When using ldap sasl wrapping with gssapi it's important to receive warnings
for clock-skew errors.

Guenther

16 years agor25327: Normalize the path we return for 'msdfs proxy'
Volker Lendecke [Tue, 25 Sep 2007 23:26:05 +0000 (23:26 +0000)]
r25327: Normalize the path we return for 'msdfs proxy'

We now accept both \\server\tmp and \server\tmp. There are other places
where this might be necessary, but at least the functionality is a bit
easier now.

16 years agor25326: Free the context from the talloc_stackframe.
Günther Deschner [Tue, 25 Sep 2007 22:43:42 +0000 (22:43 +0000)]
r25326: Free the context from the talloc_stackframe.

Guenther

16 years agor25325: Rename some defines.
Günther Deschner [Tue, 25 Sep 2007 21:41:57 +0000 (21:41 +0000)]
r25325: Rename some defines.

Guenther

16 years agor25324: Fix "msdfs proxy"
Volker Lendecke [Tue, 25 Sep 2007 21:41:39 +0000 (21:41 +0000)]
r25324: Fix "msdfs proxy"

Jeremy, please check!

16 years agor25323: Fix the build
Volker Lendecke [Tue, 25 Sep 2007 21:32:49 +0000 (21:32 +0000)]
r25323: Fix the build

16 years agor25317: Activate raw-samba3rootdirfid
Volker Lendecke [Tue, 25 Sep 2007 16:42:53 +0000 (16:42 +0000)]
r25317: Activate raw-samba3rootdirfid

16 years agor25314: Add HKEY_CURRENT_USER to reg_hive_key().
Günther Deschner [Tue, 25 Sep 2007 04:54:20 +0000 (04:54 +0000)]
r25314: Add HKEY_CURRENT_USER to reg_hive_key().

Guenther

16 years agor25313: dd HKEY_CURRENT_USER to rpccli_winreg_Connect().
Günther Deschner [Tue, 25 Sep 2007 04:52:15 +0000 (04:52 +0000)]
r25313: dd HKEY_CURRENT_USER to rpccli_winreg_Connect().

Guenther

16 years agor25311: Patch from Heinrich Mislik <Heinrich.Mislik@univie.ac.at> to fix AIX
Volker Lendecke [Mon, 24 Sep 2007 21:43:54 +0000 (21:43 +0000)]
r25311: Patch from Heinrich Mislik <Heinrich.Mislik@univie.ac.at> to fix AIX
quotas.

Heinrich, I trust you on that, I don't even have compiled this :-)

Volker

16 years agor25309: Volker's fix for bug #4984 - samba4 torture test
Jeremy Allison [Mon, 24 Sep 2007 19:11:42 +0000 (19:11 +0000)]
r25309: Volker's fix for bug #4984 - samba4 torture test
to follow. Ensure we don't prepend "./" as a root
directory - this is an invalid pathname for unix_convert().
Jeremy.

16 years agor25294: Tidy up callers of unistr2_to_ascii() to pass sizeof(target_area) to
Michael Adam [Fri, 21 Sep 2007 14:37:35 +0000 (14:37 +0000)]
r25294: Tidy up callers of unistr2_to_ascii() to pass sizeof(target_area) to
the maxeln parameter instead of sizeof(target_area) - 1 (or even
sizeof(fstring) - 1 in some places.

I hope these were really all there were.

Michael

16 years agor25287: Eliminate a handful of red bars and overly long lines I just
Michael Adam [Fri, 21 Sep 2007 12:24:43 +0000 (12:24 +0000)]
r25287: Eliminate a handful of red bars and overly long lines I just
came across.

Michael

16 years agor25286: Fix one more caller of unistr2_to_ascii() that passed
Michael Adam [Fri, 21 Sep 2007 11:58:25 +0000 (11:58 +0000)]
r25286: Fix one more caller of unistr2_to_ascii() that passed
in -1 for maxlen.

Michael

16 years agor25285: Fix some more callers of unistr2_to_ascii to use the size of
Michael Adam [Fri, 21 Sep 2007 11:53:14 +0000 (11:53 +0000)]
r25285: Fix some more callers of unistr2_to_ascii to use the size of
destination instead of source as maxlen.

Michael

16 years agor25281: Fix a caller of unistr2_to_ascii():
Michael Adam [Fri, 21 Sep 2007 10:46:09 +0000 (10:46 +0000)]
r25281: Fix a caller of unistr2_to_ascii():
The maxlen parameter should be set to the size of the
destination, not to the size of the soruce.

Michael

16 years agor25277: Belt-and-braces approach to Volker's fix for RPC-SAMBA3-GETUSERNAME.
Jeremy Allison [Fri, 21 Sep 2007 10:32:57 +0000 (10:32 +0000)]
r25277: Belt-and-braces approach to Volker's fix for RPC-SAMBA3-GETUSERNAME.
If we promise dest is null terminated, ensure we do it even on
fast path exits.
Jeremy.

16 years agor25275: w2k3 (as PDC emulator) returns WERR_NO_SUCH_DOMAIN to netlogon_getanydcname()
Stefan Metzmacher [Fri, 21 Sep 2007 10:25:33 +0000 (10:25 +0000)]
r25275: w2k3 (as PDC emulator) returns WERR_NO_SUCH_DOMAIN to netlogon_getanydcname()
when called for it's own domain. So we should use netlogon_getdcname() which
returns WERR_OK:-)

gd: feel free to usage rpccli_netlogon_dsr_getdcname(), but please make sure
    the new WINBIND-STRUCT-GETDCNAME test is still passing.

metze

16 years agor25274: Attempt to fix RPC-SAMBA3-GETUSERNAME
Volker Lendecke [Fri, 21 Sep 2007 10:23:35 +0000 (10:23 +0000)]
r25274: Attempt to fix RPC-SAMBA3-GETUSERNAME

16 years agor25273: unistrX_to_ascii calls pull_ucs2 - ensure it's never
Jeremy Allison [Fri, 21 Sep 2007 09:58:36 +0000 (09:58 +0000)]
r25273: unistrX_to_ascii calls pull_ucs2 - ensure it's never
called with -1 (these calls were wrong anyway, target
was an fstring, not a pstring). Found by  Michael Adam <ma@sernet.de>,
now to check all other uses.
Michael - this version uses sizeof(target) not sizeof(fstring).
This way is more future proof.
Jeremy.