sfrench/samba-autobuild/.git
14 years agoWHATSNEW: Update changes. samba-3.5.0rc2
Karolin Seeger [Tue, 26 Jan 2010 13:58:45 +0000 (14:58 +0100)]
WHATSNEW: Update changes.

Karolin
(cherry picked from commit 048adb50d83a3928820e6607451d582696cd7cc7)

14 years agos3-docs: Fix version in man ldbrename.
Karolin Seeger [Tue, 26 Jan 2010 13:19:31 +0000 (14:19 +0100)]
s3-docs: Fix version in man ldbrename.

Karolin
(cherry picked from commit 77bb3f2a5596c84e99b9006d2a31a752c68ab34a)

14 years agos3: Enable use of ccache by default for libsmbclient
Volker Lendecke [Tue, 26 Jan 2010 09:51:32 +0000 (10:51 +0100)]
s3: Enable use of ccache by default for libsmbclient

Disable this by setting the environment variable LIBSMBCLIENT_NO_CCACHE, which
has the advantage over an smb.conf option to be easily settable per
application.
(cherry picked from commit 0e8552abc1b48e62aaac3cab7c13c8dea60c9f9b)

14 years agos3-libsmbclient: Add smbc_setOptionUseCCache()
Volker Lendecke [Sun, 24 Jan 2010 18:24:10 +0000 (19:24 +0100)]
s3-libsmbclient: Add smbc_setOptionUseCCache()

Can we enable this by default? This would be a change in behaviour, but this
feature is just too cool for everyone to catch up in the apps.

The patch would be
(cherry picked from commit 9698c214624678125551f2d65b95deb29ea72b64)

14 years agos3: Add --use-ccache to net
Volker Lendecke [Sun, 24 Jan 2010 17:50:48 +0000 (18:50 +0100)]
s3: Add --use-ccache to net
(cherry picked from commit af32a49c7d8803f597e184f1361e795f179b809f)

14 years agos3: add libnetapi_set_use_ccache()
Volker Lendecke [Sun, 24 Jan 2010 17:50:31 +0000 (18:50 +0100)]
s3: add libnetapi_set_use_ccache()
(cherry picked from commit b99ab82ebab598b45eb6729498c9e67b195e698d)

14 years agos3: Fix a bug in net's use of popt
Volker Lendecke [Sun, 24 Jan 2010 17:51:58 +0000 (18:51 +0100)]
s3: Fix a bug in net's use of popt

In order to add --use-ccache to net, I added another "bool opt_ccache;" to
struct net_context. popt did not like this, it took a while to figure out why.
Popt has the lines

    /* XXX Check alignment, may fail on funky platforms. */
    if (arg == NULL || (((unsigned long)arg) & (sizeof(*arg)-1)))
        return POPT_ERROR_NULLARG;

The "bool opt_ccache;" was not aligned anymore...
(cherry picked from commit 340277382518c62e23faae4af69a9c5c32b96af2)

14 years agos3: Enable -C in rpcclient
Volker Lendecke [Sun, 24 Jan 2010 16:35:04 +0000 (17:35 +0100)]
s3: Enable -C in rpcclient
(cherry picked from commit 2aca69ef0df02e655125d9db31e1f0144d21a144)

14 years agos3: Add CLI_FULL_CONNECTION_USE_CCACHE
Volker Lendecke [Sun, 24 Jan 2010 16:34:13 +0000 (17:34 +0100)]
s3: Add CLI_FULL_CONNECTION_USE_CCACHE
(cherry picked from commit 36854ea0aa260dfe23f77825e942f5b3905d396d)

14 years agos3: Use -C in smbclient
Volker Lendecke [Sun, 24 Jan 2010 16:08:56 +0000 (17:08 +0100)]
s3: Use -C in smbclient

$ bin/wbinfo --ccache-save=w2k3ad\\vl%Password
saving creds succeeded
$ bin/smbclient //192.168.42.160/tmp -Uvl -N -C -W w2k3ad
OS=[Windows Server 2003 R2 3790 Service Pack 2] Server=[Windows Server 2003 R2 5.2]
smb: \>
$ bin/wbinfo --ccache-save=w2k3ad\\vl%WrongPassword
saving creds succeeded
$ bin/smbclient //192.168.42.160/tmp -Uvl -N -C -W w2k3ad
Anonymous login successful
Domain=[W2K3AD] OS=[Windows Server 2003 R2 3790 Service Pack 2] Server=[Windows Server 2003 R2 5.2]
tree connect failed: NT_STATUS_ACCESS_DENIED
$
(cherry picked from commit 5e91f9eb10404a1df470fd87fc8c1cae5ea7b70c)

14 years agos3: Add -C (--use-ccache) to popt_common_credentials
Volker Lendecke [Sun, 24 Jan 2010 16:07:24 +0000 (17:07 +0100)]
s3: Add -C (--use-ccache) to popt_common_credentials
(cherry picked from commit 58ebc50663a299e16684aa24cfae95954d5a14f0)

14 years agos3: Add ccache use to cli_session_setup_ntlmssp
Volker Lendecke [Sun, 24 Jan 2010 15:50:46 +0000 (16:50 +0100)]
s3: Add ccache use to cli_session_setup_ntlmssp
(cherry picked from commit e06abe412f78b58f36998037637d1b3478fdc477)

14 years agos3: Add NTLMSSP_FEATURE_CCACHE
Volker Lendecke [Sun, 24 Jan 2010 15:47:24 +0000 (16:47 +0100)]
s3: Add NTLMSSP_FEATURE_CCACHE

Uses the winbind ccache to do authentication if asked to do so
(cherry picked from commit 8e96e1f49867d1260aa291b688fbb58e01ef2009)

14 years agolibwbclient: Actually implement wbcCredentialCache()
Volker Lendecke [Sun, 24 Jan 2010 15:44:15 +0000 (16:44 +0100)]
libwbclient: Actually implement wbcCredentialCache()
(cherry picked from commit 7ab798d141bf715808fa0941f19422069e65fa0e)

14 years agos3: Add the session key to the ccache_ntlm_auth response
Volker Lendecke [Sun, 24 Jan 2010 15:41:30 +0000 (16:41 +0100)]
s3: Add the session key to the ccache_ntlm_auth response
(cherry picked from commit 99f6f322ae5aa13596c5b0f1a6e600b6fec48896)

14 years agos3: Add wbinfo --ccache-save
Volker Lendecke [Sat, 9 Jan 2010 19:20:36 +0000 (20:20 +0100)]
s3: Add wbinfo --ccache-save

With this command you can give winbind your password for later use by
the automatic ntlm_auth
(cherry picked from commit 1ae7b074113497342f0b85223df270bdee0b07a0)

14 years agolib/popt: Fix typo in README.
Karolin Seeger [Mon, 25 Jan 2010 18:54:24 +0000 (19:54 +0100)]
lib/popt: Fix typo in README.

Karolin
(cherry picked from commit 463aa06442f1d6c7088c5d47f003b82e4293b70d)
(cherry picked from commit 007dbc57a954e3eea6db191b34f3be9ab3c4a9b6)

14 years agos3/docs: Fix typo.
Karolin Seeger [Mon, 25 Jan 2010 18:53:42 +0000 (19:53 +0100)]
s3/docs: Fix typo.

Karolin
(cherry picked from commit a3420bf7a52c3d9fa6cba75aa88d1f4087c0e3aa)
(cherry picked from commit 7e4dd20a6bb7ae44f2137ca9f914e09a15f00110)

14 years agoWHATSNEW: Update changes.
Karolin Seeger [Mon, 25 Jan 2010 11:51:41 +0000 (12:51 +0100)]
WHATSNEW: Update changes.

Karolin
(cherry picked from commit 05850542df7c9c6e15bbc609df59c7177d3ab996)

14 years agos3:auth: fix account unlock regression introduced with fix for bug #4347
Michael Adam [Thu, 14 Jan 2010 13:24:35 +0000 (14:24 +0100)]
s3:auth: fix account unlock regression introduced with fix for bug #4347

By an oversight, the patchset for #4347 made the unlocking of a locked
account after the lockout duration ineffective.
Thanks to Björn for finding this!

Michael
(cherry picked from commit 5eb9b66de0fd0adc59339a944f02f5fe25868568)

14 years agos3:auth: don't update the bad pw count if pw is among last 2 history entries
Michael Adam [Wed, 6 Jan 2010 16:29:04 +0000 (17:29 +0100)]
s3:auth: don't update the bad pw count if pw is among last 2 history entries

This conforms to the behaviour of Windows 2003:
http://www.microsoft.com/technet/prodtechnol/windowsserver2003/technologies/security/bpactlck.mspx

This is supposed to fixes Bug #4347 .

Michael
(cherry picked from commit fcadc524779a50ee379fb4feb02448944dc174dc)

14 years agos3:auth:check_sam_security: introduce a bool var to control pad_pw_count incrementation
Michael Adam [Wed, 6 Jan 2010 15:35:44 +0000 (16:35 +0100)]
s3:auth:check_sam_security: introduce a bool var to control pad_pw_count incrementation

This is a preparatory patch for the last part in fixing bug #4347 .

Michael
(cherry picked from commit 0d6ad513e27e83b6a460954f3120395f13f65088)

14 years agos3:passdb: store the plain nt passwords hashes in history, not salted md5
Michael Adam [Tue, 5 Jan 2010 17:28:48 +0000 (18:28 +0100)]
s3:passdb: store the plain nt passwords hashes in history, not salted md5

This is in order to be able to do challenge response with the history,
so that this can be checked when an invalid password was entered:
If the given password is wrong but in the history, then the bad password
count should not be updated...

The "lucky" bit here is that the md5 has and the nt hash (md4) both are
16 bytes long.

This is part of the fix for bug #4347 .

Michael
(cherry picked from commit d909861c64cf874b1625039b0e1eace507a29b28)

14 years agos3:smbd:password_in_history: treat entry with 0 salt as 0 + plain nt hash
Michael Adam [Tue, 5 Jan 2010 15:58:30 +0000 (16:58 +0100)]
s3:smbd:password_in_history: treat entry with 0 salt as 0 + plain nt hash

This is to introduce a new format of the password history, maintaining backwards
compatibility: The old format was 16 byte hash + 16 byte md5(salt + nt hash).
The new format is 16 zero bytes and 16 bytes nt hash.

This will allow us to respect the last X entries of the nt password history
when deciding whether to increment the bad password count.

This is part of the fix for bug #4347 .

Michael
(cherry picked from commit f260d6a48dce32208424aa9bfbf2b1e293e48045)

14 years agos3:auth:check_sam_security: improve calling and logging of pdb_update_sam_account
Michael Adam [Wed, 6 Jan 2010 12:53:10 +0000 (13:53 +0100)]
s3:auth:check_sam_security: improve calling and logging of pdb_update_sam_account

Log what went wrongl, and also call pdb_update_sam_account inside
become_root/unbecome_root: do the logging outside.

Michael
(cherry picked from commit 640dfa851a296a403e218096444b203da13ebf10)

14 years agos3:auth:check_sam_security: fix a leading tab/ws mixup
Michael Adam [Wed, 6 Jan 2010 12:40:58 +0000 (13:40 +0100)]
s3:auth:check_sam_security: fix a leading tab/ws mixup

Michael
(cherry picked from commit 093607e082657ebbf2b49dd5d615c5e6f14c8dcb)

14 years agos3:auth:check_sam_security: create (and use) a common exit point
Michael Adam [Wed, 6 Jan 2010 11:36:56 +0000 (12:36 +0100)]
s3:auth:check_sam_security: create (and use) a common exit point

for use after sam_password_ok() has been called.

Michael
(cherry picked from commit 10a847fe9d03d1fe62aa96fee251e10bea1da463)

14 years agos3:auth:check_sam_security: null out sampass after it has been stolen.
Michael Adam [Wed, 6 Jan 2010 11:32:51 +0000 (12:32 +0100)]
s3:auth:check_sam_security: null out sampass after it has been stolen.

So that a later talloc_free would not harm. I could have used
talloc_move instead of talloc steal in make_server_info_sam(),
but this would have required a change of the signature.

Michael
(cherry picked from commit 1bb4a2ca3a1e11b395b3b819e468ecac67e16d64)

14 years agos3:auth:sam_password_ok: take username, acct_ctrl and nt/lm hashes, not sampass
Michael Adam [Mon, 4 Jan 2010 17:15:24 +0000 (18:15 +0100)]
s3:auth:sam_password_ok: take username, acct_ctrl and nt/lm hashes, not sampass

This is in preparation to extending check_sam_security to also check
against the password history before updating the bad password count.
This way, sam_password_ok can more easily be reused for that purpose.

Michael
(cherry picked from commit 2925209acc8bcda487fa8f05365ea8fedb232218)

14 years agos3:auth: use data_blob_null instead of data_blob(NULL, 0) in sam_password_ok()
Michael Adam [Mon, 4 Jan 2010 14:37:24 +0000 (15:37 +0100)]
s3:auth: use data_blob_null instead of data_blob(NULL, 0) in sam_password_ok()

This way it is more explicit that there is no allocated data here
that may leak.

Michael
(cherry picked from commit c9e05e11b152401d63ae9b8b40c717d0bd3d0646)

14 years agos3:auth:sam_password_ok: fix allocation of a data blob.
Michael Adam [Wed, 30 Dec 2009 14:37:23 +0000 (15:37 +0100)]
s3:auth:sam_password_ok: fix allocation of a data blob.

data_blob(mem_ctx, 16) does not use mem_ctx as a talloc ctx but
copies 16 bytes from mem_ctx into the newly allocated data blob.
This can not have been intentional. A blank uint8_t array of
length 16 is allocated by passing NULL instead of mem_ctx.
And using data_blob_talloc(mem_ctx, NULL, 16) adds the allocated
blank 16 byte array to mem_ctx - so this is what must have been
intended.

Michael
(cherry picked from commit c3bd0b5951f09f102abaa19fb2e1f55711b975d2)

14 years agos3:auth:sam_password_ok: enhance readability (imho) by adding some pointers
Michael Adam [Wed, 30 Dec 2009 14:35:50 +0000 (15:35 +0100)]
s3:auth:sam_password_ok: enhance readability (imho) by adding some pointers

and removing bool variables and several checks.

Michael
(cherry picked from commit 761a8b8fa5b5d05d5802fecf07229de40d33c558)

14 years agos3:check_sam_security: untangle assignment from statement
Michael Adam [Wed, 30 Dec 2009 11:46:22 +0000 (12:46 +0100)]
s3:check_sam_security: untangle assignment from statement

Michael
(cherry picked from commit 232602ee2914851b0af851aa5dada3bf1c99dcff)

14 years agos3: Factor password_in_history() out of check_passwd_history()
Volker Lendecke [Mon, 14 Dec 2009 19:54:33 +0000 (20:54 +0100)]
s3: Factor password_in_history() out of check_passwd_history()
(cherry picked from commit a92102cf3044ad3be49d6f746ed3f95c49d30412)

14 years agoSimplify E_md5hash a bit
Volker Lendecke [Mon, 14 Dec 2009 18:29:36 +0000 (19:29 +0100)]
Simplify E_md5hash a bit
(cherry picked from commit 7e430f3093c5bc06d8ca1186f982fe51af8c5637)

14 years agos3: Simplify pdb_set_plaintext_passwd: pwhistory==NULL can not happen anymore
Volker Lendecke [Mon, 14 Dec 2009 18:18:09 +0000 (19:18 +0100)]
s3: Simplify pdb_set_plaintext_passwd: pwhistory==NULL can not happen anymore
(cherry picked from commit 2042f4937db80939ca3d70816d864b4d762d46fb)

14 years agos3: Simplify pdb_set_plaintext_passwd: pwHistLen==0 was checked above
Volker Lendecke [Mon, 14 Dec 2009 18:16:58 +0000 (19:16 +0100)]
s3: Simplify pdb_set_plaintext_passwd: pwHistLen==0 was checked above
(cherry picked from commit bfa814be469e5a7c22e45ff8261de749e51414b2)

14 years agos3: Add a paranoia check to pdb_set_plaintext_passwd()
Volker Lendecke [Mon, 14 Dec 2009 18:12:50 +0000 (19:12 +0100)]
s3: Add a paranoia check to pdb_set_plaintext_passwd()
(cherry picked from commit 58b2f41c14e590724e2cb45f23ff7e75d5d2e7ab)

14 years agos3: Simplify pdb_set_plaintext_passwd() by removing a redundant condition
Volker Lendecke [Mon, 14 Dec 2009 17:50:38 +0000 (18:50 +0100)]
s3: Simplify pdb_set_plaintext_passwd() by removing a redundant condition

if (current_history_len != pwHistLen) {
     if (current_history_len < pwHistLen) {
     }
}

The second "if" is a bit pointless here
(cherry picked from commit 76a9af7cac4a6d6ba00d81a946db094ecfd43817)

14 years agos3: Simplify pdb_set_plaintext_passwd: memcpy deals fine with 0 bytes
Volker Lendecke [Mon, 14 Dec 2009 17:44:38 +0000 (18:44 +0100)]
s3: Simplify pdb_set_plaintext_passwd: memcpy deals fine with 0 bytes
(cherry picked from commit 8a4463c61292872e9a294a6b026ec6d65d2219b8)

14 years agos3: Simplify pdb_set_plaintext_passwd by using talloc_zero_array
Volker Lendecke [Mon, 14 Dec 2009 17:43:03 +0000 (18:43 +0100)]
s3: Simplify pdb_set_plaintext_passwd by using talloc_zero_array
(cherry picked from commit 501dd6fe17e72d8e487a622c0e66cb5938e66731)

14 years agos3: Make use of talloc_array in pdb_set_plaintext_passwd()
Volker Lendecke [Mon, 14 Dec 2009 17:39:19 +0000 (18:39 +0100)]
s3: Make use of talloc_array in pdb_set_plaintext_passwd()
(cherry picked from commit a5a477648f301b9c435609b0c6f4d76d4229b9ae)

14 years agos3: Simplify pdb_set_plaintext_passwd() a bit
Volker Lendecke [Mon, 14 Dec 2009 17:24:04 +0000 (18:24 +0100)]
s3: Simplify pdb_set_plaintext_passwd() a bit

Remove an indentation by the early return in

+       if (pwHistLen == 0) {
+               /* Set the history length to zero. */
+               pdb_set_pw_history(sampass, NULL, 0, PDB_CHANGED);
+               return true;
+       }
(cherry picked from commit 7097be60809252c6faf0388d0019384f01a7ff42)

14 years agos3: Simplify pdb_set_plaintext_passwd() slightly
Volker Lendecke [Mon, 14 Dec 2009 17:13:28 +0000 (18:13 +0100)]
s3: Simplify pdb_set_plaintext_passwd() slightly

No functional change, this just removes an indentation level by the early
"return True;" in

+       if ((pdb_get_acct_ctrl(sampass) & ACB_NORMAL) == 0) {
+               /*
+                * No password history for non-user accounts
+                */
+               return true;
+       }

Volker
(cherry picked from commit 0630fdc5ec8440c8338c7302dc5b52849e3f50be)

14 years agos3: Fix a typo
Volker Lendecke [Mon, 14 Dec 2009 16:51:39 +0000 (17:51 +0100)]
s3: Fix a typo
(cherry picked from commit 53e9ffb3a66acfa9af2bf4c616b2b83daf723f49)

14 years agos3: Avoid a memset(, 0, ) call
Volker Lendecke [Mon, 14 Dec 2009 16:43:56 +0000 (17:43 +0100)]
s3: Avoid a memset(, 0, ) call
(cherry picked from commit 7758648556aba5242f913d6cc0f46a2d9f1cfaa9)

14 years agoWHATSNEW: Update changes since 3.5.0rc1.
Karolin Seeger [Mon, 25 Jan 2010 10:28:46 +0000 (11:28 +0100)]
WHATSNEW: Update changes since 3.5.0rc1.

Karolin
(cherry picked from commit b3f2d34b54bc06e7d1d0c47e89dc8f2dcc782890)

14 years agos3: Fix bug 7052: "DFS broken on AIX (maybe others)"
William Jojo [Thu, 21 Jan 2010 13:21:03 +0000 (14:21 +0100)]
s3: Fix bug 7052: "DFS broken on AIX (maybe others)"
(cherry picked from commit c531d00ab4444db19ff6ba4c60ebdcc8319949c6)
(cherry picked from commit f21796955e7aa2e84a1c810612f2fdee2bde611c)

14 years agos3:pdb_ldap: Fix large paged search.
Volker Lendecke [Mon, 18 May 2009 14:04:04 +0000 (16:04 +0200)]
s3:pdb_ldap: Fix large paged search.

Fix bug #6981 (Paged Search with DirX LDAP server broken).
(cherry picked from commit 0a3b576c0a4298cbe600ad8943e401e3a0639359)
(cherry picked from commit 155fb985ec1c487c457e7962417cf9e137597ff6)

14 years agos3-docs: Fix typos.
Karolin Seeger [Wed, 20 Jan 2010 12:34:50 +0000 (13:34 +0100)]
s3-docs: Fix typos.

Thanks to the Debian samba package maintainers
<pkg-samba-maint@lists.alioth.debian.org> for providing the patch!

Fix bug #7017 (Typos and spelling errors in manpages).

Karolin
(cherry picked from commit e1e6b19acff6d8ba3b70c3ab474a85de8b6f6a6c)
(cherry picked from commit eaa10cfec3c389c79ac3c43f7ec1596015a9b8e1)

14 years agos3 net/i18n: Update .po files
Kai Blin [Tue, 19 Jan 2010 13:48:12 +0000 (14:48 +0100)]
s3 net/i18n: Update .po files
(cherry picked from commit add4edcd063591839111d474543ceea847413f6f)

Part 9/9 of a fix for bug #7039 (German translation of net is not complete).
(cherry picked from commit 9effcc4426d8c11be539598cffb0485761633659)

14 years agos3 net: Fix compile warnings
Kai Blin [Tue, 19 Jan 2010 10:43:54 +0000 (11:43 +0100)]
s3 net: Fix compile warnings
(cherry picked from commit 66de52c4f4527ef43cfaf11c55616ec7602cce85)

Part 8/9 of a fix for bug #7039 (German translation of net is not complete).
(cherry picked from commit c9ffceedfd1bb8a21ade44e33eebc7e7426b1e84)

14 years agos3 net/i18n: update .po files
Kai Blin [Tue, 19 Jan 2010 09:06:26 +0000 (10:06 +0100)]
s3 net/i18n: update .po files
(cherry picked from commit 6d33bb25e1aab72bb3e12a0824a758bacba32672)

Part 7/9 of a fix for bug #7039 (German translation of net is not complete).
(cherry picked from commit 5d47fdf980ec16dd22020b15d82ae127663fcb9c)

14 years agos3 net/i18n: Use only one spelling for "Usage:"
Kai Blin [Tue, 19 Jan 2010 08:23:42 +0000 (09:23 +0100)]
s3 net/i18n: Use only one spelling for "Usage:"
(cherry picked from commit 09bc13728fc76cf784914a4066c793c297e50cff)

Part 6/9 of a fix for bug #7039 (German translation of net is not complete).
(cherry picked from commit 611df88507ca2d69f258ea804e2b4fc4ebe420e3)

14 years agos3 net: Fix compile error with WITH_DNS_UPDATES
Kai Blin [Tue, 19 Jan 2010 08:36:55 +0000 (09:36 +0100)]
s3 net: Fix compile error with WITH_DNS_UPDATES

bd3c922e2bc1a163efc1d8c9cb59578bebb79616 introduced a compile-time error
when building with WITH_DNS_UPDATES.
(cherry picked from commit 28b512f904cee5a79aefd0aca2d839dbe37e5519)

Part 5/9 of a fix for bug #7039 (German translation of net is not complete).
(cherry picked from commit a00de540e13afe4772ccc4756364f91f31cc8951)

14 years agos3/net: split up some printable stings to ease i18n
Björn Jacke [Mon, 18 Jan 2010 22:39:19 +0000 (23:39 +0100)]
s3/net: split up some printable stings to ease i18n

If we put strings like "Usage:" into separate _() macros and not the whole
"Usage:..." string we can cover much more messages by only one single
translation. The drawback is that the message in the sources looks less pretty.
(cherry picked from commit bd3c922e2bc1a163efc1d8c9cb59578bebb79616)

Part 4/9 of a fix for bug #7039 (German translation of net is not complete).
(cherry picked from commit f70106f13a2722b958f95c6d6209788d06c69a07)

14 years agoѕ3/i18n/de: fix typo
Björn Jacke [Mon, 18 Jan 2010 21:07:55 +0000 (22:07 +0100)]
ѕ3/i18n/de: fix typo
(cherry picked from commit fb7a4621134b9054f33ccb48d7d8c1e4e4960b9a)

Part 3/9 of a fix for bug #7039 (German translation of net is not complete).
(cherry picked from commit 5731d96a7a0a499cf984aa4f6bf91fbccd8d7ce2)

14 years agos3/i18n/de: improve some German translations
Björn Jacke [Mon, 18 Jan 2010 22:25:41 +0000 (23:25 +0100)]
s3/i18n/de: improve some German translations
(cherry picked from commit c3ef7a3d96763719de1df679d50fb8a00d1f7391)

Part 2/9 of a fix for bug #7039 (German translation of net is not complete).
(cherry picked from commit 45403b2dede2f52524622c189fc789868ca4c633)

14 years agonet: Add German translation, specially for the command listing
André Hentschel [Thu, 14 Jan 2010 18:49:18 +0000 (19:49 +0100)]
net: Add German translation, specially for the command listing

Signed-off-by: Kai Blin <kai@samba.org>
(cherry picked from commit 46842a68618b4c9faba25580e68a286b97f9337e)

Part 1/9 of a fix for bug #7039 (German translation of net is not complete).
(cherry picked from commit 87a729791c896af8b64451e68cc2bf9f43ce9344)

14 years agoWHATSNEW: Update release notes.
Karolin Seeger [Tue, 19 Jan 2010 11:39:49 +0000 (12:39 +0100)]
WHATSNEW: Update release notes.

Karolin
(cherry picked from commit da2bf2e1e8eb2dc686ab998ef359653e74e211d8)

14 years agos3:pdb_ldap: restore Samba 3.0.x behavior and use the first "uid" value.
Stefan Metzmacher [Tue, 5 Jan 2010 12:30:42 +0000 (13:30 +0100)]
s3:pdb_ldap: restore Samba 3.0.x behavior and use the first "uid" value.

See bug #6157 for more details.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 25806f43ddee7e2653e907eea2c6fcc075960fa1)
(cherry picked from commit ac224452b94865db346ed68dc517f84d40e6303c)
(cherry picked from commit 13fd42e84025dd0427ec8454c56f07869a3af962)

14 years agos3:smbldap: add smbldap_talloc_first_attribute()
Stefan Metzmacher [Tue, 5 Jan 2010 12:30:19 +0000 (13:30 +0100)]
s3:smbldap: add smbldap_talloc_first_attribute()

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit c992127f8a96c37940a6d298c7c6859c47f83d9b)
(cherry picked from commit 915b7552b71904baf6a452bdc1649e76d8286a14)
(cherry picked from commit 009877922e65e5872218e83fba0d0f2a230dec2e)

14 years agos3-docs: Adapt version number in man vfs_scannedonly.
Karolin Seeger [Mon, 18 Jan 2010 10:44:10 +0000 (11:44 +0100)]
s3-docs: Adapt version number in man vfs_scannedonly.

Karolin
(cherry picked from commit deb72f6fe3b027d27c7390f387ef4ae009b18106)

14 years agos3-docs: Add man page for vfs_scannedonly.
Olivier Sessink [Mon, 18 Jan 2010 10:40:33 +0000 (11:40 +0100)]
s3-docs: Add man page for vfs_scannedonly.

Fix bug #7028.
(cherry picked from commit 3fb359aa5698e393f37765ab279b5a4ba366f965)
(cherry picked from commit a26389a222a6aa0bd13a16f546cabcc16bb8329b)

14 years agos3: Fix a crash in libsmbclient used against the OpenSolaris CIFS server
Volker Lendecke [Sat, 16 Jan 2010 12:31:44 +0000 (13:31 +0100)]
s3: Fix a crash in libsmbclient used against the OpenSolaris CIFS server

A user has sent me a sniff where the OpenSolaris CIFS server returns "32" in
totalentries, but the array in ctr only contains 15 entries. Look at the right
delimiter for walking the array.

Fix bug #7046 (libsmbclient crash against OpenSolaris CIFS server).
(cherry picked from commit 33d7c3b5831a76d1c65a585ae57e51dd2eba4935)

14 years agoFix bug 7045 - Bad (non memory copying) interfaces in smbc_setXXXX calls.
Jeremy Allison [Sat, 16 Jan 2010 01:45:21 +0000 (17:45 -0800)]
Fix bug 7045 - Bad (non memory copying) interfaces in smbc_setXXXX calls.

In smbc_free_context libsmbclient just called free() on the string options
so it assumes the callers have malloced them before setting them via smbc_set
calls.

Change to correctly malloc/free string options to the library.
Protect against SMB_STRDUP of null.

Contains 2d41b1ab78639abe4ae030ff482573f464564dd7 and
f85b6ee90b88c7f7b2a92c8a5f3e2ebe59c1087b from master.

Jeremy
(cherry picked from commit e579de0c473d505c75bfeb8c583188e998666a8c)

14 years agoModification of fix for bug 6876 - Delete of an object whose parent folder does not...
Jeremy Allison [Sun, 17 Jan 2010 01:03:06 +0000 (17:03 -0800)]
Modification of fix for bug 6876 - Delete of an object whose parent folder does not have delete rights fails even if the delete right is set on the object

Suggested by Volker. Reduce the surface area of the
become_root() unbecome_root() code to reduce the chance
of errors.

Jeremy.
(cherry picked from commit 98a495f1e674b7562a3d8b5dfc958ee95d256896)
(cherry picked from commit 8c8412fa88f752797abebd940d488b1c09009d96)

14 years agoFix bug #6876 - Delete of an object whose parent folder does not have delete rights...
Jeremy Allison [Wed, 13 Jan 2010 00:04:44 +0000 (16:04 -0800)]
Fix bug #6876 - Delete of an object whose parent folder does not have delete rights fails even if the delete right is set on the object.

Final fix for the vfs_acl_xattr and vfs_acl_tdb code.
Ensure we can delete a file even if the underlying POSIX
permissions don't allow it, if the Windows permissions do.

Jeremy.
(cherry picked from commit 47c1d9b39f292772e8d8f7a737ddff6c8bdfdeae)
(cherry picked from commit eec11c0d2ba61aa2f86a100064b3a9de3f56bb7d)

14 years agoWHATSNEW: Start 3.5.0rc2 release notes.
Karolin Seeger [Fri, 15 Jan 2010 14:56:38 +0000 (15:56 +0100)]
WHATSNEW: Start 3.5.0rc2 release notes.

Karolin
(cherry picked from commit 54b98a39dcd6937203dffef3a5cd432a862737ca)

14 years agoVERSION: Raise version number up to 3.5.0rc2.
Karolin Seeger [Fri, 15 Jan 2010 14:30:06 +0000 (15:30 +0100)]
VERSION: Raise version number up to 3.5.0rc2.

Karolin
(cherry picked from commit fa12a98dfdf336a4ee2f653fa0cffb4a4b1ccfe9)

14 years agos3-libsmbclient: Fix crash bug in SMBC_parse_path().
Günther Deschner [Thu, 14 Jan 2010 18:34:26 +0000 (19:34 +0100)]
s3-libsmbclient: Fix crash bug in SMBC_parse_path().

Patch from Tim Waugh <twaugh@redhat.com>.
This resolves https://bugzilla.redhat.com/show_bug.cgi?id=552658

LIBSMBCLIENT-OPENDIR torture test checks this as well.

Guenther
(cherry picked from commit e635b0074c55e0376495abe940355aa7b04f0b70)

Fix bug #7043 (SIGSEGV in "SMBC_parse_path").
(cherry picked from commit 19c78aa6d5462a6e91f7d65d52c2f4378d80eecc)

14 years agodocs: fix xml tag in the pdbedit manpage
Michael Adam [Tue, 12 Jan 2010 11:29:14 +0000 (12:29 +0100)]
docs: fix xml tag in the pdbedit manpage

Michael
(cherry picked from commit 3b58b2ac39a91c0c9f074abf079f700c7e886841)

Signed-off-by: Michael Adam <obnox@samba.org>
Fix bug #7041.
(cherry picked from commit 73df1d5e6a6eb09df5392656bd9ad5b94a3933a2)

14 years agos3-docs: mention -K option in pdbedit manpage.
Günther Deschner [Fri, 8 Jan 2010 09:38:46 +0000 (10:38 +0100)]
s3-docs: mention -K option in pdbedit manpage.

Guenther
(cherry picked from commit 9bdd3d6c1b1aec536d87fb2e2d4e8495b3c88ee6)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 2812d7547b87d60509a30e2955acc78084ed7466)

14 years agoFix bug #7036 - net rpc getsid fails in hardened windows environments.
Jeremy Allison [Thu, 14 Jan 2010 23:39:30 +0000 (15:39 -0800)]
Fix bug #7036 - net rpc getsid fails in hardened windows environments.

Fix suggested by Dave.Daugherty@Centrify.com.
(cherry picked from commit 6653cc43233381a941cdd85550f04b087fe880ff)
(cherry picked from commit d1f67394ce70342a35fba280e533c76bc9775f9d)

14 years agos3-lanman: Allow a level2 descriptor for a level1 NetShareGetInfo
Giovanni Bajo [Mon, 11 Jan 2010 21:18:40 +0000 (22:18 +0100)]
s3-lanman: Allow a level2 descriptor for a level1 NetShareGetInfo

Windows seems to allow this

http://lists.samba.org/archive/samba-technical/2009-November/068116.html

has a dump of this.
(cherry picked from commit d75d14f8de0b1fe36028e605c9453631d9cd70bc)

Fix bug #7029 (NetShareEnum: disable sanity check for better compatibility with
Windows).
(cherry picked from commit 91a59704421d2c0a3c23cb936323fc1f9ba17dc0)

14 years agoPart 4 of bug #7028 - include scannedonly VFS module
Olivier Sessink [Thu, 14 Jan 2010 20:13:14 +0000 (12:13 -0800)]
Part 4 of bug #7028 - include scannedonly VFS module

Fix some issues with handling names ending in '/'.
(cherry picked from commit 3c42e11ff398d0307a480d49191aae3bf9869cd9)
(cherry picked from commit af2a075f2c8feaf4961c25693ec973fb7ae6d524)

14 years agoFix two uses of strncat -> strlcat. Ensure proper use of strncpy when setting socket...
Jeremy Allison [Wed, 13 Jan 2010 05:18:36 +0000 (21:18 -0800)]
Fix two uses of strncat -> strlcat. Ensure proper use of strncpy when setting socket name.

Jeremy.
(cherry picked from commit ed457e07b9bdc0acda9dc52307d8bc2118f32f06)
(cherry picked from commit dff5d81d12da94707d586ab8842c96b05fa713a1)

14 years agos3: Lift the version of the scannedonly VFS module (cherry picked from commit 2d4dda0...
Volker Lendecke [Tue, 12 Jan 2010 21:58:51 +0000 (22:58 +0100)]
s3: Lift the version of the scannedonly VFS module (cherry picked from commit 2d4dda0688d5c88fb73ae17db970afe9d0f77f6a)
(cherry picked from commit f692d27c9edc187ebdc080ff71fc5df24b607c55)

14 years agoBug #7028 part1
Olivier Sessink [Wed, 13 Jan 2010 22:53:27 +0000 (14:53 -0800)]
Bug #7028 part1

s3: Add the "scannedonly" vfs virus scanner interface module
(cherry picked from commit e04a7325766fbf35ec45bb431481b79277d89f8e)

14 years agoFix bug #7033 - SMBrmdir call always returns true, even on failure to delete a directory.
Jeremy Allison [Wed, 13 Jan 2010 22:36:37 +0000 (14:36 -0800)]
Fix bug #7033 - SMBrmdir call always returns true, even on failure to delete a directory.

There is a codepath missing to propagate back error returns from the rmdir
POSIX call inside close_directory when delete on close is set. This means doing
an rmdir on a Windows command line will always report success, even when the
directory was not deleted. This fix adds that codepath back into Samba.

(This fix contains both ce8dcbe91ba0252140a0e4f84ea4bc746259ddde and
105f876eb447e6839b9b19c2d264c4a168cf0cc9 from master).

Jeremy.
(cherry picked from commit fd04e3a2b74dbd31c7574355c73779626c10070e)

14 years agos3: Fix a winbind segfault in "trusted_domains"
Volker Lendecke [Wed, 13 Jan 2010 11:20:26 +0000 (12:20 +0100)]
s3: Fix a winbind segfault in "trusted_domains"

We have to initialize domain->backend by calling "get_cache" before doing a
query

Thanks to Christian Ambach to find this :-)
(cherry picked from commit 026b23062eeee23dffeb627800b3cb6f55d89ad6)

Fix bug #7037.
(cherry picked from commit 3b9cdab89672576ddfe6f7c2be54169fb4dd7634)

14 years agoFix bug #7034 - vfs_cap causes signal 11 (SIGSEGV) (cherry picked from commit ca84795...
SASAJIMA Toshihiro [Wed, 13 Jan 2010 05:43:23 +0000 (21:43 -0800)]
Fix bug #7034 - vfs_cap causes signal 11 (SIGSEGV) (cherry picked from commit ca847952054f5bbde1d40ad4260589b6fcc9721d)
(cherry picked from commit dbbe7c5949f2e5728577e1a1146c0b72b1b482c0)

14 years agos3: Fix a segfault in winbindd_dual_ccache_ntlm_auth()
Volker Lendecke [Sat, 9 Jan 2010 19:22:00 +0000 (20:22 +0100)]
s3: Fix a segfault in winbindd_dual_ccache_ntlm_auth()

ntlmssp_update allocates the reply_blob as a child of ntlmssp_state. This means
with ntlmss_end() it will be gone. winbindd_dual_ccache_ntlm_auth used the blob
after the ntlmssp_end().
(cherry picked from commit 43c841b6bd92e987109df81b6b8a2b85f21b0181)

Addresses bug #7027 (winbindd crash in winbindd_dual_ccache_ntlm_auth due to
freed memory reference.)
(cherry picked from commit 26faf1262fc2f0fa2d8c2874150852ac36951162)

14 years agoRe-fix bug 5202 - cannot change ACLs on writable file with "dos filemode=yes"
Jeremy Allison [Fri, 8 Jan 2010 18:17:46 +0000 (10:17 -0800)]
Re-fix bug 5202 - cannot change ACLs on writable file with "dos filemode=yes"

This bug re-occurred for 3.3.x and above.

The reason is that to change a NT ACL we now have to open the file requesting
WRITE_DAC and WRITE_OWNER access. The mapping from POSIX "w" to NT permissions
in posix_acls doesn't add these bits when "dos filemode = yes", so even though
the permission or owner change would be allowed by the POSIX ACL code, the
NTCreateX call fails with ACCESS_DENIED now we always check NT permissions
first.

Added in the mapping from "w" to WRITE_DAC and WRITE_OWNER access.

Jeremy.
(cherry picked from commit d7713d11a6dc2d66c820d7496bc45eb5fe527fbf)
(cherry picked from commit e687a20d60144af2cb459231fb6a699f2533ce9d)

14 years agos3: Lock down some srvsvc calls according to what w2k3 seems to do
Volker Lendecke [Thu, 7 Jan 2010 10:47:09 +0000 (11:47 +0100)]
s3: Lock down some srvsvc calls according to what w2k3 seems to do
(cherry picked from commit ea7d2995f383e183ef4d8a21705a343581e71f4a)

14 years agoWHATSNEW: Update changes. samba-3.5.0rc1
Karolin Seeger [Thu, 7 Jan 2010 10:01:17 +0000 (11:01 +0100)]
WHATSNEW: Update changes.

Karolin
(cherry picked from commit 22ee5d4921f28a4cba176ca629cf32f35b5956d6)

14 years agotdb: fix standalone 'make installdocs'
Stefan Metzmacher [Wed, 6 Jan 2010 13:39:43 +0000 (14:39 +0100)]
tdb: fix standalone 'make installdocs'

metze
(cherry picked from commit c01f443ebca5e0b6f65fe8b3ab031da51dce2e89)
(cherry picked from commit 6a1786aaf88bbc38eebbd489cfe582602bd034e2)

14 years agotdb: create symbol links to shared libraries see https://bugzilla.samba.org/show_bug...
Brian Lu [Thu, 17 Dec 2009 06:39:09 +0000 (14:39 +0800)]
tdb: create symbol links to shared libraries see https://bugzilla.samba.org/show_bug.cgi?id=6991 for details

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 0a3a6bb8f910df02cb429fdeacf0ab8d683e0b89)
(cherry picked from commit 3c5de3c3f8fb665a0e1e9c1982a6f98d8ae9a1ff)

14 years agotalloc: create symbol links to shared libraries see https://bugzilla.samba.org/show_b...
Brian Lu [Thu, 17 Dec 2009 06:48:59 +0000 (14:48 +0800)]
talloc: create symbol links to shared libraries see https://bugzilla.samba.org/show_bug.cgi?id=6991 for details

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit eff6022d51f578dfc48f1d66dd8ec1e860dfd7b3)
(cherry picked from commit d3e8baf29756c7af38841b290ad67eb06a474bb3)

14 years agotevent: create symbol links to shared libraries see https://bugzilla.samba.org/show_b...
Brian Lu [Thu, 17 Dec 2009 06:55:57 +0000 (14:55 +0800)]
tevent: create symbol links to shared libraries see https://bugzilla.samba.org/show_bug.cgi?id=6991 for details

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit f408d58d95f5ac10849742fdcdf7e6160196e8e0)
(cherry picked from commit b4f95b214cf7a328f2656fa81395566e9905ff6e)

14 years agotdb: Also build and install tdb manpages from standalone tdb.
Jelmer Vernooij [Sun, 20 Dec 2009 17:01:24 +0000 (18:01 +0100)]
tdb: Also build and install tdb manpages from standalone tdb.
(cherry picked from commit 0110990f01390c80b8db423ba7eed486883219de)

(Version changed to 3.5)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 2e0df7c8ee5615cb8b1ea3abe727ab59c4bf1f95)

14 years agos4: Fix result check for getaddrinfo()
Kamen Mazdrashki [Wed, 6 Jan 2010 11:40:33 +0000 (13:40 +0200)]
s4: Fix result check for getaddrinfo()

I think this completes commit 50feca550eed7828198b7c0fc5f0e5ddc863313d.
Now result should be handled correctly both for systems that
support EAI_NODATA but returns EAI_NONAME (as my Ubuntu 9.x)
and systems that doesn't support EAI_NODATA at all.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit a2044b9a61d9c8ca66067b286ad9bc01cf0490b9)
(cherry picked from commit dd35252f4dbe3dc36b35c21915bf959524dc4930)

14 years agoWHATSNEW: Update changes since 3.5.0pre2.
Karolin Seeger [Thu, 7 Jan 2010 09:24:28 +0000 (10:24 +0100)]
WHATSNEW: Update changes since 3.5.0pre2.

Karolin
(cherry picked from commit c330ae920ac86a6a9cc7fac129be62756b2da7c0)

14 years agos4-smbtorture: add test_ChangeID to RPC-SPOOLSS.
Günther Deschner [Wed, 6 Jan 2010 18:34:33 +0000 (19:34 +0100)]
s4-smbtorture: add test_ChangeID to RPC-SPOOLSS.

This tests ChangeID consistency between spoolss_GetPrinterData,
spoolss_GetPrinterDataEx and spoolss_GetPrinter (level 0).

Guenther
(cherry picked from commit 3dbe8603d967d9d1b13290ec0f0556c7323a7692)
(cherry picked from commit 066094537420c70e453462407c751c9ae863ae01)

14 years agos4-smbtorture: add test_SetPrinter to RPC-SPOOLSS.
Günther Deschner [Wed, 6 Jan 2010 18:33:39 +0000 (19:33 +0100)]
s4-smbtorture: add test_SetPrinter to RPC-SPOOLSS.

Guenther
(cherry picked from commit 7568f49134c548c470e99c51e237ad3e225d6488)
(cherry picked from commit d7375656d058cef1a47158132eb0599becb1a779)

14 years agos4-smbtorture: refactor test_GetPrinter in RPC-SPOOLSS.
Günther Deschner [Wed, 6 Jan 2010 16:51:34 +0000 (17:51 +0100)]
s4-smbtorture: refactor test_GetPrinter in RPC-SPOOLSS.

Guenther
(cherry picked from commit 0457cf915b724e3afd54ab1b5c8b96dcb5b7550a)
(cherry picked from commit d5eac5b8dccd2d940044c3d06603554740dd3ac3)

14 years agos3-net: use generated krb5.conf in 'net ads testjoin'
Günther Deschner [Wed, 16 Dec 2009 20:22:50 +0000 (21:22 +0100)]
s3-net: use generated krb5.conf in 'net ads testjoin'

Guenther
(cherry picked from commit 475d296065d57f9b38b109203b40ed0b47a2ac7e)
(cherry picked from commit f5af157fc004d210e9740491fcce84bbd1b1ebfa)

14 years agos3-docs: mention -M option and remove nonexisting -G option in pdbedit manpage.
Günther Deschner [Wed, 23 Dec 2009 09:33:13 +0000 (10:33 +0100)]
s3-docs: mention -M option and remove nonexisting -G option in pdbedit manpage.

Guenther
(cherry picked from commit 3b40ec83705f7ea61f4d4b88438493b6c197f222)
(cherry picked from commit 79f92a10a8a25c0f162b0b4707e90f9ab01b540f)

14 years agoSecond part of the fix for bug #7020 - smbd using 2G memory.
Jeremy Allison [Wed, 6 Jan 2010 21:11:00 +0000 (13:11 -0800)]
Second part of the fix for bug #7020 - smbd using 2G memory.

There was a second leak in the processing of the out_data.frag
prs_struct. It needs freeing once the current pdu has been returned
asynchronously.

Jeremy.
(cherry picked from commit d5995eec7e5fd487b57b8805095ffbc74796411a)
(cherry picked from commit 80b5f95b7d05955943c33968b4f0742581b00480)

14 years agoFix bug #7020 - smbd using 2G memory.
Jeremy Allison [Tue, 5 Jan 2010 22:34:00 +0000 (14:34 -0800)]
Fix bug #7020 - smbd using 2G memory.

When deferring an async pipe writeX and readX transfer
the outstanding request struct onto the conn struct. This
needs freeing after the packet is finally processed.

Jeremy.
(cherry picked from commit f6bd654a6c878111f0f0f4d07adb644fc3bbf224)
(cherry picked from commit b63539809d022f7012f4899a5a18a835079d6c6f)