cvs2svn Import User [Fri, 19 Mar 2004 17:51:31 +0000 (17:51 +0000)]
This commit was manufactured by cvs2svn to create tag
'release-3-0-3pre1'.
Gerald Carter [Fri, 19 Mar 2004 17:51:30 +0000 (17:51 +0000)]
syncing more changes from 3.0
cvs2svn Import User [Fri, 19 Mar 2004 17:36:58 +0000 (17:36 +0000)]
This commit was manufactured by cvs2svn to create branch
'SAMBA_3_0_RELEASE'.
Richard Sharpe [Fri, 19 Mar 2004 17:36:56 +0000 (17:36 +0000)]
Apply some more of Derrell Lipman's changes.
Gerald Carter [Fri, 19 Mar 2004 17:03:04 +0000 (17:03 +0000)]
preparing for release of 3.0.3pre1
Gerald Carter [Fri, 19 Mar 2004 17:00:53 +0000 (17:00 +0000)]
sync configure.in with 3.0
Gerald Carter [Fri, 19 Mar 2004 16:59:59 +0000 (16:59 +0000)]
add --with-libdir and --with-mandir (patch from Guenther Deschner)
Gerald Carter [Fri, 19 Mar 2004 16:25:02 +0000 (16:25 +0000)]
tightening down the release branch now -- last planned merge from 3.0
Gerald Carter [Fri, 19 Mar 2004 16:21:50 +0000 (16:21 +0000)]
cleaning up a few compiler warngings
Gerald Carter [Fri, 19 Mar 2004 15:52:16 +0000 (15:52 +0000)]
wrap cli_tdis() in check to make sure we have a valid cnum
Gerald Carter [Fri, 19 Mar 2004 14:53:55 +0000 (14:53 +0000)]
syncing with 3.0
Simo Sorce [Fri, 19 Mar 2004 14:31:09 +0000 (14:31 +0000)]
add privileges support to ldapsam too
Simo Sorce [Fri, 19 Mar 2004 11:27:14 +0000 (11:27 +0000)]
the buffer must be greater then src string len otherwise bad things happen!
Jeremy Allison [Fri, 19 Mar 2004 01:29:18 +0000 (01:29 +0000)]
Fix gcc warnings. Fix mkproto with new type.
Jeremy.
Richard Sharpe [Thu, 18 Mar 2004 22:29:54 +0000 (22:29 +0000)]
Apply Craig Barratt's fixes to allow multiple exlusion files and patterns.
Much of this was applied by hand because of the changes in the code. However,
it builds and smbclient seems to work still. The Amanda folks are testing
and it seems to work there as well.
cvs2svn Import User [Thu, 18 Mar 2004 20:05:01 +0000 (20:05 +0000)]
This commit was manufactured by cvs2svn to create branch
'SAMBA_3_0_RELEASE'.
Jim McDonough [Thu, 18 Mar 2004 20:05:00 +0000 (20:05 +0000)]
merge from 3.0...LDAP password lockout support
Gerald Carter [Thu, 18 Mar 2004 18:10:30 +0000 (18:10 +0000)]
BUG 932: ulrich@holeschak.de (Ulrich Holeschak); fix local password change using pam_smbpass
Jeremy Allison [Thu, 18 Mar 2004 17:58:47 +0000 (17:58 +0000)]
Correctness patch from fumiya@miraclelinux.com to count characters correctly,
doesn't affect what got put on the wire.
Jeremy.
Richard Sharpe [Thu, 18 Mar 2004 17:11:52 +0000 (17:11 +0000)]
Commit Derrell Lipman's changes and fixes to libsmbclient. The build but
I have not tested them beyond building. I did fix the two instances of
safe_strxxx that were introduced.
Gerald Carter [Thu, 18 Mar 2004 17:11:18 +0000 (17:11 +0000)]
removing files not present in the 3.0 tree
Gerald Carter [Thu, 18 Mar 2004 17:09:54 +0000 (17:09 +0000)]
starting to sync the cvs tree
Volker Lendecke [Thu, 18 Mar 2004 07:37:39 +0000 (07:37 +0000)]
Fix sambaUserWorkstations for network samlogons against us as DC. Strip
the \\ off the workstation.
Volker
Volker Lendecke [Thu, 18 Mar 2004 07:33:26 +0000 (07:33 +0000)]
Two little annoyances:
net rpc did not inform you if no smbd is running.
I never liked the error message (!) Success! when we established a trust.
Volker
Jeremy Allison [Thu, 18 Mar 2004 02:17:20 +0000 (02:17 +0000)]
Added a varient of Volker's patch to fix the "self-referrals as anonymous user"
problem.
Jeremy.
Jeremy Allison [Wed, 17 Mar 2004 19:23:44 +0000 (19:23 +0000)]
Remove excess logging when probing for the length of the next mb char.
Jeremy.
Gerald Carter [Wed, 17 Mar 2004 17:39:00 +0000 (17:39 +0000)]
asu/syntax/pc_netlink doesn't fill in the pipe name in the rpc_bind response so dont check for it
Gerald Carter [Wed, 17 Mar 2004 17:13:36 +0000 (17:13 +0000)]
BUG 758 -- patch from jpeach@sgi.com (James Peach); fix pdma build
Jeremy Allison [Wed, 17 Mar 2004 02:08:27 +0000 (02:08 +0000)]
Change check_path_syntax() to use the new next_mb_char_size() function
to make it generic. Remove the mb-codepage "blacklist". Alexander, please
check this fix as it reverts your blacklist changes, but I'm hoping it
fixes the problem in a more generic way for all charsets. I'm not trying
to trample on your (excellent!) work here, just make things more generic
without special cases.
Jeremy.
Jeremy Allison [Tue, 16 Mar 2004 21:59:20 +0000 (21:59 +0000)]
Add function next_mb_char_size() that returns a size_t of the number of
bytes in the mb character at a pointer. Will be useful in fixing check_path_syntax()
to not use a "blacklist". Also re-added my (C) to reply.c. I mean, really - I've
been adding code to the file for over 10 years and I recognise many of the
fuctions as mine ! :-).
Jeremy.
Gerald Carter [Tue, 16 Mar 2004 20:32:14 +0000 (20:32 +0000)]
merges from 3.0
Gerald Carter [Tue, 16 Mar 2004 19:06:30 +0000 (19:06 +0000)]
BUG 979 -- fix quota display on AIX; patch from Heinrich.Mislik@univie.ac.at (Heinrich Mislik)
Alexander Bokovoy [Tue, 16 Mar 2004 17:21:06 +0000 (17:21 +0000)]
Fix check_path_syntax() for multibyte encodings which have no '\' as second byte.
This is intermediate fix as discussed with Jeremy until we move check_path_syntax() to UCS2 internally where all
ambiguity is resolved. Please add other encodings into charcnv.c with such property.
Gerald Carter [Tue, 16 Mar 2004 17:07:18 +0000 (17:07 +0000)]
merging print change notify fix from HP appliance. Also might address some one the issues in BUG 1007
Gerald Carter [Tue, 16 Mar 2004 16:44:54 +0000 (16:44 +0000)]
BUG 1165, 1126: Fix bug with secondary groups (security = ads) and winbind use default domain = yes
Richard Sharpe [Tue, 16 Mar 2004 06:56:20 +0000 (06:56 +0000)]
Make sure we don't clobber the stack when response consists of the empty
string.
Jeremy Allison [Tue, 16 Mar 2004 00:10:34 +0000 (00:10 +0000)]
Avoid mb conversion overflow when sending an announcement.
Jeremy.
Jeremy Allison [Mon, 15 Mar 2004 21:53:59 +0000 (21:53 +0000)]
Use "unix netbios name" type unstring - 64 bytes long to manipulate netbios
names in nmbd. Allows conversion from dos codepage mb strings (ie. SJIS) to
expand to utf8 size on read.
Jeremy.
Gerald Carter [Mon, 15 Mar 2004 16:20:22 +0000 (16:20 +0000)]
removing extra comma in --with-fhs
Gerald Carter [Mon, 15 Mar 2004 16:17:51 +0000 (16:17 +0000)]
more fixes from 3.0
Gerald Carter [Mon, 15 Mar 2004 16:12:52 +0000 (16:12 +0000)]
sync small fixes from 3.0 and fix compiler warning in priv code
Gerald Carter [Mon, 15 Mar 2004 15:16:29 +0000 (15:16 +0000)]
fix byte ordering problem when storing the updating pid for the lpq cache; was causing an abort in process_exists() on solaris
Volker Lendecke [Sun, 14 Mar 2004 11:15:37 +0000 (11:15 +0000)]
Ok, one of the latest cleanups did too much... :-)
Re-add adding the local aliases to winbindd_getgroups.
Volker
Volker Lendecke [Sun, 14 Mar 2004 10:36:07 +0000 (10:36 +0000)]
Clean up a bit :-)
Volker
Volker Lendecke [Sun, 14 Mar 2004 10:28:21 +0000 (10:28 +0000)]
Fix 'getent group aliasname', this did not look in pdb.
Volker Lendecke [Sun, 14 Mar 2004 10:24:19 +0000 (10:24 +0000)]
Add and delete aliases via srv_samr_nt. For that I added a RID allocation call
to winbindd. idmap_allocate_rid wants information about whether this will be a
user or a group, I did not export this to the winbind interface.
The reason for idmap to get that info is to keep consistent with the
algorithmic convention to alloc only even rids for users and odd rids for
groups. I'm not fully convinced that this really gains us anything. Any real
good arguments?
Volker
Volker Lendecke [Sun, 14 Mar 2004 07:16:05 +0000 (07:16 +0000)]
When trying to remove a user from a group, winbind should be informed
about the user and group...
Volker
Tim Potter [Sun, 14 Mar 2004 03:47:55 +0000 (03:47 +0000)]
Merge from 3.0
Volker Lendecke [Sat, 13 Mar 2004 17:57:24 +0000 (17:57 +0000)]
Make alias membership maintainable via net rpc group add/delmem. Alias
creation and deletion still has to be done as well as a 'net alias' command.
Volker
Volker Lendecke [Sat, 13 Mar 2004 17:38:07 +0000 (17:38 +0000)]
Rest of my winbindd_passdb alias support
Volker Lendecke [Sat, 13 Mar 2004 17:35:47 +0000 (17:35 +0000)]
Add alias support to winbindd_passdb. Sorry, Simo, this does not leave too
much of your winbindd_passdb, users are currently not provided by that, only
aliases. Currently the code to maintain that stuff is not yet in, this will be
next, see my next posting to samba-technical.
Volker
Volker Lendecke [Sat, 13 Mar 2004 16:43:25 +0000 (16:43 +0000)]
Remove the prototype for alias support in winbind again. This will be
replaced by a winbindd_passdb.c checkin soon.
Volker
Volker Lendecke [Sat, 13 Mar 2004 16:30:39 +0000 (16:30 +0000)]
Add find_alias, create_alias, delete_alias, get_aliasinfo, set_aliasinfo and
enum_aliases to passdb. create and delete are not yet filled, you have to do
this with net groupmap and net idmap restore.
Volker
Jeremy Allison [Sat, 13 Mar 2004 02:47:19 +0000 (02:47 +0000)]
Ensure we don't truncate strcmps to nstring anymore...
Jeremy.
Jeremy Allison [Sat, 13 Mar 2004 02:16:26 +0000 (02:16 +0000)]
Modified fix for bugid #784. Based on a patch from moriyama@miraclelinux.com (MORIYAMA Masayuki).
Don't use nstrings to hold workgroup and netbios names. The problem with them is that MB netbios
and workgroup names in unix charset (particularly utf8) may be up to 3x bigger than the name
when represented in dos charset (ie. cp932). So go back to using fstrings for these but
translate into nstrings (ie. 16 byte length values) for transport on the wire.
Jeremy.
Jeremy Allison [Sat, 13 Mar 2004 00:28:55 +0000 (00:28 +0000)]
First part of patch from moriyama@miraclelinux.com (MORIYAMA Masayuki) to
fix up netbios names with mb strings. Includes reformat of libsmb/nmblib.c
so it's readable.
Jeremy.
Christopher R. Hertel [Fri, 12 Mar 2004 20:27:23 +0000 (20:27 +0000)]
Bug report 1079 and fix both from Bert Driehuis.
This is an odd corner case having to do with <1C> group names (DC names).
<1C> group names are called (by MS) "Internet Special Groups", which means
that Microsoft's WINS servers will attempt to handle these names in
something approximating an RFC1001/1002 compliant manner.
The problem being reported here is this: If an initial registration sent
by one of the group members is lost (network error, whatever) then
subsequent refreshes from that particular machine will also fail. This
only happens if the name is already active (because of other group
members).
In most cases, we (and MS) handle refreshes as registrations if the name
is not in the database. In this situation, we missed the corner case.
Bert's fix adds an 'else if' that catches the situation in which a refresh
for an unlisted IP of an active <1C> group name is received. The refresh
is simply handled as a registration when this happens.
[Note: Committing in HEAD. I am writing some tools to do registrations
and refreshes so that I can test this. I don't have an NT Domain
for testing so I'm going to have to fudge. This fix is small (I
cleaned up some Debug messages and comments in addition to the fix)
and if you want to test it with 3.0.x you can just copy the HEAD
version into your 3.0.x tree and recompile.]
Jeremy Allison [Fri, 12 Mar 2004 20:24:07 +0000 (20:24 +0000)]
Fix from Robert.Dahlem@gmx.net (Robert Dahlem) for bugid #1048
when mangled names are turned off.
Jeremy.
Alexander Bokovoy [Fri, 12 Mar 2004 14:28:14 +0000 (14:28 +0000)]
Fix problems with very long filenames in both smbd and smbclient.
It appears that we pass filename through resolve_wildcards() as pstring and use fstring temporary buffer there.
As result, a long filename in unix charset (UTF-8 by default) can easily expand over 255 bytes while
Windows is able to send to us such names (e.g. Japanese name of ~190 mb chars) which we unable to process through
this small fstring buffer. Tested with W2K and smbclient, Japanese and Cyrillics.
Alexander Bokovoy [Fri, 12 Mar 2004 12:58:49 +0000 (12:58 +0000)]
Fix build after Jeremy -- yet another place where convert_string() wasn't updated
Alexander Bokovoy [Fri, 12 Mar 2004 11:29:13 +0000 (11:29 +0000)]
Fix string overflow due to wrong size calculation
Jeremy Allison [Fri, 12 Mar 2004 01:43:23 +0000 (01:43 +0000)]
Allow msdfs symlink syntax to be more forgiving (it took me ages to remember
what it was :-). Allow msdfs links to now look like UNC paths : eg.
sym_link -> msdfs://server/share/path/in/share
or :
sym_link -> msdfs:\\server\share\path\in\share
Jeremy.
Jeremy Allison [Thu, 11 Mar 2004 23:02:52 +0000 (23:02 +0000)]
Fix bug introduced by Jim (touche :-) :-) - use new smbldap_get_single_pstring
call :-).
Jeremy.
Jeremy Allison [Thu, 11 Mar 2004 22:59:58 +0000 (22:59 +0000)]
Restore the contract on all convert_stringXX() interfaces. Add a "allow_bad_conv"
boolean parameter that allows broken iconv conversions to work. Gets rid of the
nasty errno checks in mangle_hash2 and check_path_syntax and allows correct
return code checking.
Jeremy.
Jim McDonough [Thu, 11 Mar 2004 18:10:08 +0000 (18:10 +0000)]
Merge from 3.0. Fix munged dial in pdb_ldap
Herb Lewis [Thu, 11 Mar 2004 15:14:48 +0000 (15:14 +0000)]
add missing #ifdef HAVE_BICONV stuff
Gerald Carter [Thu, 11 Mar 2004 14:52:35 +0000 (14:52 +0000)]
BUG 1088: patch from SATOH Fumiyasu <fumiya@miraclinux.com> -- use strchr_m() for query_host (smbclient -L)
Jeremy Allison [Thu, 11 Mar 2004 00:42:36 +0000 (00:42 +0000)]
Ensure we use check_path_syntax() to pull out DFS paths.
Jeremy
Jeremy Allison [Thu, 11 Mar 2004 00:31:50 +0000 (00:31 +0000)]
Fix processing of pathnames with embedded '\\' characters (0x5c) in CP932
character set. Because of the allowing of "broken conversions" for people
who have broken iconv libraries we can't rely on the return from convert_string()
to be valid - we must check errno instead. This is ripe for revisiting at
some stage. I prefer adding a bool parameter to all convert_string_XX varients
to specify if we will allow broken conversions or not. With "allow_broken_conversions"
set to false we could then rely on the return from convert_string rather than
checking errno.
Jeremy.
Volker Lendecke [Wed, 10 Mar 2004 17:06:13 +0000 (17:06 +0000)]
lsa_enumaccounts lists all SIDs that have been granted privileges. Simo,
you should look at this.
Change behaviour from listing all groups to listing only BUILTIN\Administrator
Volker
Volker Lendecke [Wed, 10 Mar 2004 16:40:41 +0000 (16:40 +0000)]
Remove expanding sids from smbd, this will be done in winbindd.
Volker
Volker Lendecke [Wed, 10 Mar 2004 16:32:58 +0000 (16:32 +0000)]
Apply some const
Volker Lendecke [Wed, 10 Mar 2004 16:17:46 +0000 (16:17 +0000)]
Don't pass DOM_SIDs around when pointers are enough.
Volker
Herb Lewis [Wed, 10 Mar 2004 03:09:28 +0000 (03:09 +0000)]
another type
Jeremy Allison [Wed, 10 Mar 2004 02:38:36 +0000 (02:38 +0000)]
Moving towards getting msdfs working again (this looks like it was broken
in 3.0.2a actually). We now send a correct referral back, but the client
refuses to follow it... Not sure why. Will do more tests.. Maybe unicode
character count is wrong (it looks it).
Jeremy.
Jeremy Allison [Wed, 10 Mar 2004 01:32:24 +0000 (01:32 +0000)]
Formatting reformat before I start to change anything here.
Jeremy.
Herb Lewis [Wed, 10 Mar 2004 00:52:59 +0000 (00:52 +0000)]
fix type for tag in proto file
Jeremy Allison [Tue, 9 Mar 2004 23:26:56 +0000 (23:26 +0000)]
Fix dfs referrals - don't use check_path_syntax. Also use mb char calls in
dfs code.
Jeremy.
Rafal Szczesniak [Tue, 9 Mar 2004 21:48:46 +0000 (21:48 +0000)]
Yet another '\n' termination of debug message.
rafal
Rafal Szczesniak [Tue, 9 Mar 2004 20:44:39 +0000 (20:44 +0000)]
Forgot to put some more comments.
rafal
Rafal Szczesniak [Tue, 9 Mar 2004 20:30:35 +0000 (20:30 +0000)]
1) Two new functions to trust passwords interface in passdb:
settrustpwent, gettrustpwnam
2) Implementation of another couple of these functions in tdbsam:
settrustpwent, gettrustpwnam, gettrustpwsid
3) Testing (mostly for now) usage of the interface in pdbedit
which is soon to be offline tool back again.
This is quite a new code, so many changes will be put in soon.
rafal
Rafal Szczesniak [Tue, 9 Mar 2004 18:56:28 +0000 (18:56 +0000)]
Fix to debug message lacking termination with '\n'.
rafal
Gerald Carter [Tue, 9 Mar 2004 15:29:40 +0000 (15:29 +0000)]
fix build with gcc 2.96 and --with-developer
Andrew Bartlett [Tue, 9 Mar 2004 12:37:05 +0000 (12:37 +0000)]
Commit to HEAD the updates to smb signing code that I was propsing for 3.0.
This code implements 'opportunistic signing' in our client (when the
server supports it, we will use it), and correct downgrading on both
the client and server for the 'enabled' (rather than required) signing
level.
This means that we can actually set 'server signing = yes' and not
have the world fall apart. We had a number of bugs in that code, and
it certainly looks like most of the testing was with the 'requried'
setting.
While the changes are reasonable, I'm putting this into HEAD rather
than 3.0 for the timebeing. SMB signing, like NTLMSSP, tends to have
gotchas in it :-)
(I also need to give it a workout with more than smbclient before I
move it across).
Andrew Bartlett
cvs2svn Import User [Tue, 9 Mar 2004 11:42:59 +0000 (11:42 +0000)]
This commit was manufactured by cvs2svn to create branch
'SAMBA_3_0_RELEASE'.
Andrew Bartlett [Tue, 9 Mar 2004 11:42:58 +0000 (11:42 +0000)]
Merge fixes and tests for jra's broken strstr_m() function from 3.0
STF rules! (Pity we don't use it for more stuff)
Andrew Bartlett
Jeremy Allison [Tue, 9 Mar 2004 00:17:16 +0000 (00:17 +0000)]
Added strstr_m() function. Use in all places where we might run into mb
(should fix the mb service name problem, can't remember the bugid).
Jeremy.
Jeremy Allison [Mon, 8 Mar 2004 21:54:56 +0000 (21:54 +0000)]
Fix assumption about following directory sep in check_path_syntax(). We
need to try and convert 1 byte, then 2 bytes if that fails. Fixes bug
reported by Simo.
Jeremy.
Simo Sorce [Mon, 8 Mar 2004 10:41:05 +0000 (10:41 +0000)]
Do some checks about data passed to this function
Simo Sorce [Mon, 8 Mar 2004 09:52:17 +0000 (09:52 +0000)]
2 fixes to enhance readability of source code and debug messages
1 fix for a memleak
Volker Lendecke [Sun, 7 Mar 2004 08:23:06 +0000 (08:23 +0000)]
Get us a little closer to Windows LSA semantics.
A windows DC does not reply to DCNAME\\Administrator, only to
DOMAIN\\Administrator. Fix that.
Without winbind we are wrong as domain members, we should forward the request
DOMAIN\\Username to the DC on behalf of the asking client. Winbind fixes that
nicely.
Volker
Volker Lendecke [Sun, 7 Mar 2004 08:17:09 +0000 (08:17 +0000)]
This might not be used a lot and might not survive for long, but at least it
should work as expected :-)
Fix wb_delgrpmember.
Volker
Tim Potter [Sun, 7 Mar 2004 01:14:35 +0000 (01:14 +0000)]
Fix typo.
Tim Potter [Sun, 7 Mar 2004 00:34:49 +0000 (00:34 +0000)]
Enclose use of fchown() with guards. Bugzilla #1155.
Tim Potter [Sat, 6 Mar 2004 23:52:54 +0000 (23:52 +0000)]
tdbdump doesn't need to #include <sys/mman.h>
Bugzilla #1154.
Jeremy Allison [Fri, 5 Mar 2004 22:32:43 +0000 (22:32 +0000)]
Several mb tidyups - getting ready to address the XXX_sub function.
Jeremy.
Gerald Carter [Fri, 5 Mar 2004 18:37:32 +0000 (18:37 +0000)]
BUG 488: fix the 'show client in col 1' button and corrctely enumerate active connections
Gerald Carter [Fri, 5 Mar 2004 17:39:59 +0000 (17:39 +0000)]
fix compiler warning
Jelmer Vernooij [Fri, 5 Mar 2004 17:21:45 +0000 (17:21 +0000)]
Add -O (write downloaded files to stdout), based on patch from
Bas van Sisseren <bas@dnd.utwente.nl>
Jeremy Allison [Fri, 5 Mar 2004 01:37:25 +0000 (01:37 +0000)]
all_string_sub() is broken as it doesn't handle mb chars correctly (and
so breaks when substitution '/' and '\'). It's used by unix_clean_name(),
which is used by reduce_name, which is used by check_name() (phew!).
Now that we know all filenames passed to check_name() are in a "good"
format (no double slashes, all '\\' chars translated to '/' etc.) due
to the new check_path_syntax() we can avoid calling reduce_name unless
widelinks are denied. After this check-in I can fix all_string_sub() to
handle mb chars correctly as it won't be in the direct path in the
main path handling code.
Jeremy.