20 years agoThis commit was manufactured by cvs2svn to create branch 'SAMBA_3_0'.(This used to...
cvs2svn Import User [Sun, 14 Jul 2002 22:15:21 +0000 (22:15 +0000)]
This commit was manufactured by cvs2svn to create branch 'SAMBA_3_0'.(This used to be commit b8d39651fb90ef170055735412417239a63afc5d)

20 years agothis is a trick to work around the fact that posix does not supply
Andrew Tridgell [Sun, 14 Jul 2002 22:15:20 +0000 (22:15 +0000)]
this is a trick to work around the fact that posix does not supply
a getgr*() function that lists groups without numerating all the
group members. Instead of definiing a new nss method (which might
cause problems) I added an environment variable WINBIND_GETGRLST
that tells winbind not to fill in the group members in a gergrent()
request. This can speed up group listing by a factor of 20 or more
(on my test system with 50000 groups it reduces the time from an hour
to 2 minutes)
(This used to be commit e3f73256d31ab9914daae49f41e984a534996870)

20 years agoShow the account flags in the 'verbose' listing of pdbedit.
Andrew Bartlett [Sun, 14 Jul 2002 08:38:09 +0000 (08:38 +0000)]
Show the account flags in the 'verbose' listing of pdbedit.

Andrew Bartlett
(This used to be commit b5ec92d7a2e5ba33b641267d2319d101d70a0d9a)

20 years agoApply patch from "Kai Krueger" <> to make it easier to
Andrew Bartlett [Sun, 14 Jul 2002 08:37:31 +0000 (08:37 +0000)]
Apply patch from "Kai Krueger" <> to make it easier to
determine what access masks should be applied to various SAMR calls.

Andrew Bartlett
(This used to be commit dbf28f992bcd4859a9b7d78ac1d33e4063617f94)

20 years agoFix up a botched prevoius commit.
Andrew Bartlett [Sun, 14 Jul 2002 04:51:57 +0000 (04:51 +0000)]
Fix up a botched prevoius commit.

The idea here is to allow invalid LM passwords in otherwise valid accounts.

This happens when we create an account without a password, for example.
Previously we would stop at the LM password, and not read things like the
account flags correctly.  Now we process the record, and just set the password
to NULL.

(Note, 'no password for access' is decided only on the basis of the Account
Control bits, not on the 'NULL' value of the password feild.).

Andrew Bartlett
(This used to be commit c590e0c970b5babf370924cef51530e5e215eaf2)

20 years agoremoved some meaningless const casts that were causing thousands of
Andrew Tridgell [Sun, 14 Jul 2002 04:11:21 +0000 (04:11 +0000)]
removed some meaningless const casts that were causing thousands of
warnings (literally!) for the irix compiler
(This used to be commit 35b6b46bc67104671298641e2993225bad2c9a39)

20 years agomove opt_machine_pass to keep some compilers happy
Andrew Tridgell [Sun, 14 Jul 2002 03:49:15 +0000 (03:49 +0000)]
move opt_machine_pass to keep some compilers happy
(This used to be commit 39e11ef5b1090e51c6c447c8037a43b52e04b881)

20 years agoMove nttrans.c into the NTSTATUS age.
Andrew Bartlett [Sun, 14 Jul 2002 01:23:46 +0000 (01:23 +0000)]
Move nttrans.c into the NTSTATUS age.

This could do with another eye looking over it, but it seems to work.

Andrew Bartlett
(This used to be commit e6746db60daa4a61a3ed4302e4105345984af6ac)

20 years agoadded useful 'net rpc info' command
Andrew Tridgell [Sat, 13 Jul 2002 15:14:39 +0000 (15:14 +0000)]
added useful 'net rpc info' command

this also gives a way to distinguish a 'native mode' server from a
non-native server. This call will fail for a native mode server.
(This used to be commit a7663428e05bdd41a1975d0db9be6537b7238b95)

20 years agoadded --machine-pass option to net. This allows you to authenticate as
Andrew Tridgell [Sat, 13 Jul 2002 11:42:53 +0000 (11:42 +0000)]
added --machine-pass option to net. This allows you to authenticate as
the current machine account and password. This is useful both for
diagnostics and domain leave.
(This used to be commit 73b246981fd5b27cc1d835946b89e82f5b78f332)

20 years agomake this a ZERO_STRUCTP for consitancy with the rest of Samba.
Andrew Bartlett [Sat, 13 Jul 2002 09:18:55 +0000 (09:18 +0000)]
make this a ZERO_STRUCTP for consitancy with the rest of Samba.
(This used to be commit 587a3d91b7226f4e96c4320322f62c6490a3c6ac)

20 years agoMake smbmnt a standalone program from a linker point of view. Hopefully this
Andrew Bartlett [Sat, 13 Jul 2002 09:14:40 +0000 (09:14 +0000)]
Make smbmnt a standalone program from a linker point of view.  Hopefully this
will make it easier to prove this package correct from an audit point of view.

smbumount to follow, but it uses pstrcpy() so I'll need to decide what to do
with that.

Andrew Bartlett
(This used to be commit 62c56f97248109ca80cc155974584bea9704cd50)

20 years agoI just noticed that I never added my copyright when I messed with this
Andrew Bartlett [Sat, 13 Jul 2002 09:11:20 +0000 (09:11 +0000)]
I just noticed that I never added my copyright when I messed with this
previously.  Fix that.

Andrew Bartlett
(This used to be commit c552910477f0baca4d2173c2bdf4748de3c3b8ad)

20 years agoMake smbpasswd behave like all the other backends, where a NULL or invalid
Andrew Bartlett [Sat, 13 Jul 2002 09:10:16 +0000 (09:10 +0000)]
Make smbpasswd behave like all the other backends, where a NULL or invalid
LM password isn't anything special.  All the users check the ACB nowadays,
and this allows us to correctly return flags set via usermgr.

Andrew Bartlett
(This used to be commit 89eb765d398de7654ba6bac7c51df727830c2591)

20 years agoThis makes smbcacls a bit easier to use and debug.
Andrew Bartlett [Sat, 13 Jul 2002 09:03:41 +0000 (09:03 +0000)]
This makes smbcacls a bit easier to use and debug.

Allow connection in the form of //server/share instead of just \\server\share
and show the reason for failure from cli_full_connection().

Andrew Bartlett
(This used to be commit 4687fac69d995e49a0f3701fb170d64af1ba4a47)

20 years agofix directory listing on win9x.
Andrew Tridgell [Sat, 13 Jul 2002 08:37:06 +0000 (08:37 +0000)]
fix directory listing on win9x.

it turns out this is tricky to get right for both win9x and w2k with
and without unicode. This patch seems to do the trick.
(This used to be commit 01ebe5fff2b3cb29f083afb224b1257364ac5d80)

20 years agoSome fix ups but committing so Andrew can look at the problem I have.
Richard Sharpe [Sat, 13 Jul 2002 07:18:43 +0000 (07:18 +0000)]
Some fix ups but committing so Andrew can look at the problem I have.
(This used to be commit 146ba3eb49bade732d57691d8ce181ef6608e0cb)

20 years agoFix up the include file that had problems as well.
Richard Sharpe [Sat, 13 Jul 2002 05:43:34 +0000 (05:43 +0000)]
Fix up the include file that had problems as well.
(This used to be commit 753df0b89767261420f242da21d5dfb5403c966b)

20 years agoAdd these two files I forgot.
Richard Sharpe [Sat, 13 Jul 2002 05:13:02 +0000 (05:13 +0000)]
Add these two files I forgot.
(This used to be commit 5706e6af168b14a40cb1e306c2911182260ff0d3)

20 years agoFix some multibyte problems that I forgot about.
Richard Sharpe [Sat, 13 Jul 2002 05:11:58 +0000 (05:11 +0000)]
Fix some multibyte problems that I forgot about.
(This used to be commit 481a70f4f005a778a24e2193f8e760217ee3c946)

20 years agofixed a stdin bug in XFILE that prevented 'print -' from working
Andrew Tridgell [Sat, 13 Jul 2002 04:28:01 +0000 (04:28 +0000)]
fixed a stdin bug in XFILE that prevented 'print -' from working
(This used to be commit e66e354421b8be64a1b6774bde4d187532ee7690)

20 years ago- fixed a crash bug for 'print -'
Andrew Tridgell [Sat, 13 Jul 2002 03:51:28 +0000 (03:51 +0000)]
- fixed a crash bug for 'print -'
- removed an unused variable
(This used to be commit 66af95716de470600b0db58bdf8a1f0c15dba036)

20 years agoThe changes in make_sec_desc to make us match W2K broke the marshalling/unmarshalling of
Jeremy Allison [Fri, 12 Jul 2002 21:09:24 +0000 (21:09 +0000)]
The changes in make_sec_desc to make us match W2K broke the marshalling/unmarshalling of
security descriptors. We need to calculate the maximum offset and set the offset
back after reading/writing every field in the SEC_DESC.
This was *nasty* to find....
(This used to be commit 175d43980e57c25582d8ab859f5730283e82f3b2)

20 years agoWe must ZERO_STRUCT before using the buffer in copy_unistr2.
Jeremy Allison [Fri, 12 Jul 2002 18:10:24 +0000 (18:10 +0000)]
We must ZERO_STRUCT before using the buffer in copy_unistr2.
Fixes addprinterdriverex.
(This used to be commit d3c73e59708eeb1ee4642fb31fcfc0ec2fd28070)

20 years agofix setting machine passwords in the case where a user account of the
Andrew Tridgell [Fri, 12 Jul 2002 02:28:27 +0000 (02:28 +0000)]
fix setting machine passwords in the case where a user account of the
same name as the machine name exists. (we ended up setting the users
password, not the machines password!)
(This used to be commit fe1e6233c6f0a5654bcc3ab34f65bb570efc69b1)

20 years agoCommit Tom Jansen's changes to head.
Richard Sharpe [Thu, 11 Jul 2002 23:33:00 +0000 (23:33 +0000)]
Commit Tom Jansen's changes to head.
(This used to be commit d3fdce07ab5955abd1f923127ae9eb5006aea505)

20 years agoRegenerated.
Tim Potter [Thu, 11 Jul 2002 23:18:41 +0000 (23:18 +0000)]
(This used to be commit 7ead9602ce8c30a57cb83d56fb76228945a7599f)

20 years agoUsage fixes from APPLIANCE_HEAD.
Tim Potter [Thu, 11 Jul 2002 23:11:42 +0000 (23:11 +0000)]
Usage fixes from APPLIANCE_HEAD.
(This used to be commit 952d722a3bba15b7a10b4cbabb5548f4dde682d7)

20 years agoAnother compile fix.
Tim Potter [Thu, 11 Jul 2002 23:08:51 +0000 (23:08 +0000)]
Another compile fix.
(This used to be commit ef5c9698b06c5df99ec07ee781cc54d2e348ba8a)

20 years agoCompile fix for flags field to cli_full_connection()
Tim Potter [Thu, 11 Jul 2002 22:19:31 +0000 (22:19 +0000)]
Compile fix for flags field to cli_full_connection()
(This used to be commit 802f30a1b34888823c1fc80121b3917cb6825119)

20 years agoMerge of init_domain_list() fix from APPLIANCE_HEAD.
Tim Potter [Thu, 11 Jul 2002 17:31:49 +0000 (17:31 +0000)]
Merge ... init_domain_list() fix from APPLIANCE_HEAD.
(This used to be commit 66c9cab369e38284c71572bfb3643538e253a451)

20 years agoadded copyright
Gerald Carter [Thu, 11 Jul 2002 13:27:32 +0000 (13:27 +0000)]
added copyright
(This used to be commit 0bb3d0f1ca9504d2430471558e1a0125d72ee82f)

20 years agoadded copyright
Gerald Carter [Thu, 11 Jul 2002 13:17:57 +0000 (13:17 +0000)]
added copyright
(This used to be commit dcb6d70706a0e86881588c3828ff5bd4d63d415f)

20 years agothis implements a completely new strategy for fetching group
Andrew Tridgell [Thu, 11 Jul 2002 05:28:08 +0000 (05:28 +0000)]
this implements a completely new strategy for fetching group
membership from an ADS server. We now use a 'member' query on the
group and do a separate call to convert the resulting distinguished
name to a name, rid etc. This is *much* faster for very large numbers
of groups (on a quantum test system with 10000 groups it drops the
time from an hour to about 35 seconds).

strangely enough, this actually *increases* the amount of ldap
traffic, its just that the MS LDAP server answers these queries much
(This used to be commit 5538048e4f6dd224b2990f3c6a3e99fd07065f77)

20 years agolast check in for tonight.
Gerald Carter [Thu, 11 Jul 2002 04:53:39 +0000 (04:53 +0000)]
last check in for tonight.

  * DeletePrinterDriverEx() now has the ability to delete
    driver files.  I need to do some more testing
    tro veriofy that we are in fact not deleting a file out from
    under another driver, but it looks ok so far.

  * DeletePrinterDriver() noiw deletes all versions of the
    specified driver (cversion == 0, 1, 2, 3)
(This used to be commit 17bb780e1327663fa2fcd6a3cb25dd461a29c537)

20 years agothis fixes the ads dump code
Andrew Tridgell [Thu, 11 Jul 2002 03:41:09 +0000 (03:41 +0000)]
this fixes the ads dump code

a char** isn't quite the same thing as a struct berval**  :)
(This used to be commit a92834ea9460bc49be99d6d5b0d41a817e6f0824)

20 years agoall that is left to do is to actually perform the
Gerald Carter [Thu, 11 Jul 2002 03:27:12 +0000 (03:27 +0000)]
all that is left to do is to actually perform the
file deletion now.  I have the file list.
One more commit should do it.
(This used to be commit 7207662504f585352b0ceeb99f8998ef58db7f15)

20 years agointermediate work on DeletePrinterDriverEx(). This call
Gerald Carter [Thu, 11 Jul 2002 01:54:26 +0000 (01:54 +0000)]
intermediate work on DeletePrinterDriverEx().  This call
will actually delete driver files ( not yet though I don't think).
Just wanted to get it in since Jeremy and I are both
working on nt_printing.c
(This used to be commit 3fa6c3132950c9ff1c6a532d8264ee34a6b2b0ff)

20 years agoUp the printing tdb version number to 5 as I've changed it.
Jeremy Allison [Thu, 11 Jul 2002 01:00:45 +0000 (01:00 +0000)]
Up the printing tdb version number to 5 as I've changed it.
(This used to be commit f4eff4a99edd49ab11d0fc061fdb4efe96e713f5)

20 years ago*Experimental* new large-scaling printer code. Splits printing.tdb into
Jeremy Allison [Thu, 11 Jul 2002 00:06:29 +0000 (00:06 +0000)]
*Experimental* new large-scaling printer code. Splits printing.tdb into
a separate tdb per printer, but only keeps (currently one) tdb open at
a time (although this is easily changed by changing a #define). Needs
scalability testing with large numbers of printers now....
(This used to be commit b0909cfa14fc7ef29d2b98b56d52723570da782a)

20 years agoIf we get a SID from group mapping, no need to check it's prefix.
Andrew Bartlett [Wed, 10 Jul 2002 07:26:35 +0000 (07:26 +0000)]
If we get a SID from group mapping, no need to check it's prefix.

Just set it directly.

Andrew Bartlett
(This used to be commit 202202bc475f3b8500423b1a9ccf0adc80a4dc49)

20 years agosome support functions to ease the next commit.
Simo Sorce [Tue, 9 Jul 2002 23:59:46 +0000 (23:59 +0000)]
some support functions to ease the next commit.
(This used to be commit 4be1c882be56ae0fe18bb134a1513e0e6f6965b0)

20 years ago8-byte alignment needed for beginning driver_info_level_6.
Gerald Carter [Tue, 9 Jul 2002 23:23:19 +0000 (23:23 +0000)]
8-byte alignment needed for beginning driver_info_level_6.
Verified by looking at NT4 and 2k servers.  First time
for everything I guess.
(This used to be commit f57640720e4758176116bc2e1b578cf0e867f95f)

20 years agoDocumented -I option to rpcclient.
Tim Potter [Tue, 9 Jul 2002 19:13:11 +0000 (19:13 +0000)]
Documented -I option to rpcclient.
(This used to be commit 9e64d6973b4a4015a1f0282b11654ed9716786bd)

20 years agoAdded -I option to rpcclient.
Tim Potter [Tue, 9 Jul 2002 19:11:26 +0000 (19:11 +0000)]
Added -I option to rpcclient.
(This used to be commit 2674adf1b5c54da03e8a445ec1e12d382294d1c1)

20 years agomake sure we disable referrals in all ldap searches - they are badly
Andrew Tridgell [Tue, 9 Jul 2002 15:06:51 +0000 (15:06 +0000)]
make sure we disable referrals in all ldap searches - they are badly
(This used to be commit 022073d140bae960613127a6d9422e443a8098c6)

20 years agofix declaration of global_in_nmbd
Andrew Tridgell [Tue, 9 Jul 2002 14:47:03 +0000 (14:47 +0000)]
fix declaration of global_in_nmbd
(This used to be commit 07de8418369dad1f015369e70e9303fea4130295)

20 years agothe last WINS update broke self registration when we are a WINS
Andrew Tridgell [Tue, 9 Jul 2002 14:17:26 +0000 (14:17 +0000)]
the last WINS update broke self registration when we are a WINS
server. The real problem is all the special cases we had for when we
are a wins server as opposed to when we are using a 'real' wins

This patch removes the special cases. We now accept non-broadcast
packets from ourselves and we use ourselves as a wins server when we
are one. This gets rid of the special cases and simplifies things
quite a bit.

It all seems to work, but there are bound to be problems found later.
(This used to be commit 3e843d30158d05cdfba716bac7e5c0a75ae7a79c)

20 years agoMake it clear that the debug comment is the same as the command being tested
Andrew Bartlett [Tue, 9 Jul 2002 13:12:27 +0000 (13:12 +0000)]
Make it clear that the debug comment is the same as the command being tested
for failure.

Andrew Bartlett
(This used to be commit 6e22f39df8c386781a4f51207a3ccd9c94d151f1)

20 years agofixup ADDPRINTERDRIVEREX some more. unknown uint32 for now.
Gerald Carter [Mon, 8 Jul 2002 22:01:51 +0000 (22:01 +0000)]
fixup ADDPRINTERDRIVEREX some more.  unknown uint32 for now.
(This used to be commit b0f178f452a816c6a77b0f5a77fdd8930da98cac)

20 years agoFix length in snprintf invocation to account for "dn:" in sasl gssapi bind.
Jim McDonough [Mon, 8 Jul 2002 20:46:54 +0000 (20:46 +0000)]
Fix length in snprintf invocation to account for "dn:" in sasl gssapi bind.
Also remove unused line which incremented pointer by the wrong length anyway.

Provided by Anthony Liguori (
(This used to be commit 47b7a3e0f3d101a3bcffd33db6ef4c0672b57ae0)

20 years agofix typo
Gerald Carter [Mon, 8 Jul 2002 20:30:54 +0000 (20:30 +0000)]
fix typo
(This used to be commit be926c3a1a7fc79af62dd1830c56e9503f89f9dd)

20 years agoadded parsing routines for SPOOLSS_ADDPRINTERDRIVEREX and
Gerald Carter [Mon, 8 Jul 2002 20:15:47 +0000 (20:15 +0000)]
added parsing routines for SPOOLSS_ADDPRINTERDRIVEREX and
SPOOLSS_DELETEPRINTERDRIVEREX.  Ran them through some testing.
I know I'm off by 2 x uint32's in the former RPC.
(This used to be commit 55fbfd02ba917b74fd4df7a1aa8cc8c5a91e3e07)

20 years ago* basic implementation of SPOOLSS_DELETEPRINTERDATAEX and
Gerald Carter [Mon, 8 Jul 2002 18:34:55 +0000 (18:34 +0000)]
* basic implementation of SPOOLSS_DELETEPRINTERDATAEX and
* stub funnctions for SPOOLSS_ADDPRINTERDRIVEREX and
(This used to be commit d675974d0c04a68d48d90492005056d96697c96c)

20 years agoFix for LPRng from James Henstridge
Jeremy Allison [Mon, 8 Jul 2002 18:24:59 +0000 (18:24 +0000)]
Fix for LPRng from James Henstridge
(This used to be commit 9c93f8908919a02099884d393312ef27d4a2d24e)

20 years agoKill off const warnings - add a pile of const to various places.
Andrew Bartlett [Mon, 8 Jul 2002 02:14:57 +0000 (02:14 +0000)]
Kill off const warnings - add a pile of const to various places.
(This used to be commit 1de04ec4735c19ec21cdef6e679cea17c734c5f6)

20 years agoFix const warning
Andrew Bartlett [Mon, 8 Jul 2002 01:40:35 +0000 (01:40 +0000)]
Fix const warning
(This used to be commit 3d2f0635ed060fca0fa97c97ef850e57641aef19)

20 years agoJerry: Sorry if I am stepping on toes here, but this should fix the compile on
Andrew Bartlett [Mon, 8 Jul 2002 01:06:38 +0000 (01:06 +0000)]
Jerry:  Sorry if I am stepping on toes here, but this should fix the compile on
solaris CC (void* arithmatic) and fixes the other warnings (global variable
shadows) that gcc has with this file.

Andrew Bartlett
(This used to be commit 7ac6517bec0f425f99f419f6efd2a673b4ec0f83)

20 years ago(this should have been part of the previous commit)
Andrew Bartlett [Mon, 8 Jul 2002 00:40:57 +0000 (00:40 +0000)]
(this should have been part of the previous commit)

Add a function to display 'sid types' as strings - makes rpcclient outptut
and DEBUG() logs much eaiser to understand.

Move the enum for SID types to smb.h, becouse is really isn't LSA specific any

Andrew Bartlett
(This used to be commit fc9739861104df4ddc93efab3275275307e4fbb9)

20 years agoUpdates to the 'name -> sid' code:
Andrew Bartlett [Sun, 7 Jul 2002 03:34:24 +0000 (03:34 +0000)]
Updates to the 'name -> sid' code:

Correct the 'none mapped' behaviour, (so that it matches Win2k) and  add a
function to make the SID types appear as text strings in logs/rpcclient.

Also, remove a silly case that would cause 'failure' to be 'success'.  (Might
look at this a bit more in future).

Andrew Bartlett
(This used to be commit c20d057f8821d13d3de61b319de44db23773516b)

20 years agoCopy the NT_TOKEN to the pipe, so the SAMR can use it for access control.
Andrew Bartlett [Sat, 6 Jul 2002 05:08:35 +0000 (05:08 +0000)]
Copy the NT_TOKEN to the pipe, so the SAMR can use it for access control.

Andrew Bartlett
(This used to be commit 685a205445f5505c105ea421712c4b0468bbc127)

20 years agoIncrese the maximum non-unix-account ID (becouse the Compaq Test Drive systems
Andrew Bartlett [Sat, 6 Jul 2002 04:12:40 +0000 (04:12 +0000)]
Increse the maximum non-unix-account ID (becouse the Compaq Test Drive systems
have a lot of users ;-).

Andrew Bartlett
(This used to be commit 2f164e28c349b8e20700e0e2fca204ed08228316)

20 years agoRemove C++ comments.
Tim Potter [Fri, 5 Jul 2002 04:08:32 +0000 (04:08 +0000)]
Remove C++ comments.
(This used to be commit 180374c4440765f3d08e5690967beb387ae3b54d)

20 years agoFix debug comment.
Andrew Bartlett [Fri, 5 Jul 2002 01:51:49 +0000 (01:51 +0000)]
Fix debug comment.
(This used to be commit f32980c807adf8287436be0d5a223b9b1ce399b8)

20 years agoFix from Andrew Esh for coredump...
Jeremy Allison [Thu, 4 Jul 2002 21:32:08 +0000 (21:32 +0000)]
Fix from Andrew Esh for coredump...
(This used to be commit aad40894404d000b925024e2f63977f87ecb5a6b)

20 years agofixed the geyed out registry keys. Stupid typo on my part.
Gerald Carter [Thu, 4 Jul 2002 13:18:56 +0000 (13:18 +0000)]
fixed the geyed out registry keys.  Stupid typo on my part.
Now on to plug in the printing tdbs to the registry view....

(This used to be commit 2a68e4529ad884e8c3800f9006bb1c2b18cfada4)

20 years agoMore code from "Kai Krueger" <>, this time starting to make
Andrew Bartlett [Thu, 4 Jul 2002 13:11:54 +0000 (13:11 +0000)]
More code from "Kai Krueger" <>, this time starting to make
the 'user cannot change password' button work.  Needs help from a future SAM
backend, but at least this parses the data, and returns an error.

Andrew Bartlett
(This used to be commit 0c4afe075aa018ec2be10f36fd3f0a5af2a032f1)

20 years ago* fix seg fault caused by missing DLIST_REMOVE in free_fn()
Gerald Carter [Thu, 4 Jul 2002 12:51:26 +0000 (12:51 +0000)]
* fix seg fault caused by missing DLIST_REMOVE in free_fn()

* fixed constant vaolued returned by REG_UNKNOWN_1A
(This used to be commit 3b934e6a8550a03028eed9fe65c28401f429d591)

20 years agoPatch to add security descriptors to the SAMR pipe.
Andrew Bartlett [Thu, 4 Jul 2002 08:45:45 +0000 (08:45 +0000)]
Patch to add security descriptors to the SAMR pipe.

This is not the final solution, I think this will probably changed with the
move to the new SAM subsystem, but it allows some research and gives us
somthing to start with.

It should also help with getting proper NT_TOKEN passing set-up.

Original patch by "Kai Krueger" <>, which I have modified to
pass back NTSTATUS returns in more places and to use a little more common code.

Andrew Bartlett
(This used to be commit 43b72493708e74e089989db42a003a3862c793e6)

20 years agoAlways free_conn() after all the DEBUG()s etc.
Andrew Bartlett [Thu, 4 Jul 2002 08:39:06 +0000 (08:39 +0000)]
Always free_conn() after all the DEBUG()s etc.
(This used to be commit 06529c0433bf75790aad27dd3cecf7005612c694)

20 years agoFixed incorrect debug.
Tim Potter [Thu, 4 Jul 2002 03:32:36 +0000 (03:32 +0000)]
Fixed incorrect debug.
(This used to be commit dd46ff7619129782963ec6ea727e5d731370ee7d)

20 years agofirst cut at implementing support for browsing printer and driver driver
Gerald Carter [Wed, 3 Jul 2002 19:15:26 +0000 (19:15 +0000)]
first cut at implementing support for browsing printer and driver driver
via regedt32.exe.  The regsitry.tdb is only a framework.  It is not
intended to store values, only key/subkey structure.  The data
will be retrieved from nt*tdb (for printers) creating a virtual view
of the data.

You can currently connect to a Samba box using regedt32.exe (haven't
tried regedit.exe).  Some basic keys are created in registry.tdb
for use.

There are two problems....

  * something is getting freed in the winreg code that causes heap
    corruption later on.  As long as you don't play with the winreg
    server functionality, I don't think you'll be bitten by this.

  * no access controls are currently implemented

  * I can't browse HKLM because regedt32 greys out the SYSTEM subkey.

ok so that was three....
(This used to be commit 542d3c93a998083c07b2afa91a7c927c376caf54)

20 years agoBreak up the passdb objects (to allow RPC clients to link without brining in
Andrew Bartlett [Wed, 3 Jul 2002 07:37:54 +0000 (07:37 +0000)]
Break up the passdb objects (to allow RPC clients to link without brining in
*.o) and implment new enum_dom_users code in the SAMR RPC subsystem.

Incresingly, we are using the pdb_get_{user,group}_sid() functions, in the
eventual hope that we might one day support muliple domains off a single
passdb.  To extract the RID, we use sid_peek_check_rid(), and supply an
'expected' domain SID.

The id21 -> SAM_ACCOUNT and id23 -> SAM_ACCOUNT code has been moved to
srv_samr_util.c, to ease linking in passdb users.

Compatiblity code that uses 'get_global_sam_sid()' for the 'expected' sid is in

Andrew Bartlett
(This used to be commit 5a2a6f1ba316489d118a8bdd9551b155226de94f)

20 years agoMake these functions static. These are not mentioned in the external header,
Andrew Bartlett [Wed, 3 Jul 2002 07:22:45 +0000 (07:22 +0000)]
Make these functions static.  These are not mentioned in the external header,
and appear to be functions for internal use.

Richard:  please check.

Andrew Bartlett
(This used to be commit cb61e61a113dede4a0b0f5d31d0ec89c4b6ecd65)

20 years agoAdd my copyright (which I should have added months ago...)
Andrew Bartlett [Wed, 3 Jul 2002 07:21:07 +0000 (07:21 +0000)]
Add my copyright (which I should have added months ago...)
(This used to be commit 2d7eccbeb258b4fdd14323a40f9537eb265f73e1)

20 years agoFix the spelling in the LDAP attributes
Andrew Bartlett [Wed, 3 Jul 2002 06:55:31 +0000 (06:55 +0000)]
Fix the spelling in the LDAP attributes
(This used to be commit dab26f8891a77640ce382ce1785ca5dd22d43c22)

20 years agoFix the forword prototype to be a static for this static function.
Andrew Bartlett [Wed, 3 Jul 2002 06:48:52 +0000 (06:48 +0000)]
Fix the forword prototype to be a static for this static function.
(This used to be commit bb1aa5e1d2e4f71dfaab0ade24ed15d1b5fdfc33)

20 years agoRemove invalid comment - these are all 'unix' strings now.
Andrew Bartlett [Wed, 3 Jul 2002 00:47:39 +0000 (00:47 +0000)]
Remove invalid comment - these are all 'unix' strings now.
(This used to be commit 537d33735d65c40490aab2210c1d331d940bf4f8)

20 years agoKill off codepage related stuff, now we don't use codepages any more.
Andrew Bartlett [Wed, 3 Jul 2002 00:44:39 +0000 (00:44 +0000)]
Kill off codepage related stuff, now we don't use codepages any more.

Andrew Bartlett
(This used to be commit d1ca2b9f23ce701eb6b6becafb1acd813fc8fc3a)

20 years agofix typo in unix extensions description
Gerald Carter [Tue, 2 Jul 2002 14:17:42 +0000 (14:17 +0000)]
fix typo in unix extensions description
(This used to be commit 0e10ba465daada29cf57337fbb929c480bbce488)

20 years agoAddress the string_sub problem by changing len = 0 to mean "no expand".
Jeremy Allison [Tue, 2 Jul 2002 06:34:27 +0000 (06:34 +0000)]
Address the string_sub problem by changing len = 0 to mean "no expand".
Went through and checked all string_subs I could to ensure they're being
used correctly.
(This used to be commit 17cae0d683be404be69554cd0e84117bdcc56c87)

20 years agofixed our winreg parsing to handle a diifferent form given to us by
Andrew Tridgell [Tue, 2 Jul 2002 04:22:59 +0000 (04:22 +0000)]
fixed our winreg parsing to handle a diifferent form given to us by
WinXP. This fixes setting security decsriptors from XP Professional.
(This used to be commit 80c3c68de20a686ced38356fd68f80a53e6f1626)

20 years agoMerge of constant renames from APPLIANCE_HEAD.
Tim Potter [Tue, 2 Jul 2002 04:07:32 +0000 (04:07 +0000)]
Merge of constant renames from APPLIANCE_HEAD.
(This used to be commit daf4c6a013ffa474d768055e73a1cb31ee941e80)

20 years agofixed a prototype problem in client.c
Andrew Tridgell [Tue, 2 Jul 2002 01:35:07 +0000 (01:35 +0000)]
fixed a prototype problem in client.c
(This used to be commit 922ab73c3c8f510fdbcb8b64d54b512d32c47b75)

20 years agoused to make some variables static and remove some dead
Andrew Tridgell [Mon, 1 Jul 2002 09:12:41 +0000 (09:12 +0000)]
used to make some variables static and remove some dead
(This used to be commit 91ad9041e9507d36eb3f40c23c5d4df61f139ef0)

20 years agoads_mod_ber should be static, not public
Andrew Tridgell [Mon, 1 Jul 2002 07:30:40 +0000 (07:30 +0000)]
ads_mod_ber should be static, not public
this fixes the huge number of struct berval warnings on non-ads
(This used to be commit e7f588d8156856109623b5f5a3841c5d096b1185)

20 years agofixed multi-homed re-registration of names when we are a WINS
Andrew Tridgell [Mon, 1 Jul 2002 07:19:12 +0000 (07:19 +0000)]
fixed multi-homed re-registration of names when we are a WINS
server. We were rejecting them, leaving the name unregistered!
(This used to be commit 2dc539ed33f9893cbe9e16c386994933121b71e9)

20 years agodon't start the async dns process unless we actually need it!
Andrew Tridgell [Mon, 1 Jul 2002 07:15:13 +0000 (07:15 +0000)]
don't start the async dns process unless we actually need it!
(ie. check for lp_dns_proxy())
(This used to be commit 84d3b09b8542518a4684d07e975bcc9eaa1f6b69)

20 years agobias the lookup sorting towards directly reachable IPs
Andrew Tridgell [Mon, 1 Jul 2002 05:39:32 +0000 (05:39 +0000)]
bias the lookup sorting towards directly reachable IPs
(This used to be commit 514b91827a970a0041314af341b8c66a01668e4a)

20 years agosort name query responses by how far they are from our interface
Andrew Tridgell [Mon, 1 Jul 2002 05:09:29 +0000 (05:09 +0000)]
sort name query responses by how far they are from our interface
broadcast addresses. This makes it far more likely that we will try to
talk to an interface that is routable from one of our interfaces.
(This used to be commit bc1a0506868266088ae585a7a5dcb1ac8ca3474d)

20 years agofixed a bug handling startup when the ads server is not contactable
Andrew Tridgell [Mon, 1 Jul 2002 04:47:29 +0000 (04:47 +0000)]
fixed a bug handling startup when the ads server is not contactable
(This used to be commit dbfd4e5101599bcb85600e4c5c93ce5390b9aa91)

20 years agoThe 17-bit length field in the header contains the number of
Christopher R. Hertel [Mon, 1 Jul 2002 03:42:28 +0000 (03:42 +0000)]
The 17-bit length field in the header contains the number of
bytes which follow the header, not the full packet size.

    [Yes, the length field is either 17-bits, or (per the RFCs) it is a
    16-bit length field preceeded by an 8-bit flags field of which only
    the low-order bit may be used.  If that bit is set, then add 65536 to
    the 16-bit length field.  (In other words, it's a 17-bit unsigned
    length field.)
    ...unless, of course, the transport is native TCP [port 445] in which
    case the length field *might* be 24-bits wide.]

Anyway, the change is a very minor one.  We were including the four bytes
of the header in the length count and, as a result, sending four bytes of
garbage at the end of the SESSION REQUEST packet.

Small fix in function cli_session_request().
(This used to be commit d08471688b65371eb3de73b03a8ffaee86659ba0)

20 years agoThe 17-bit length field in the header contains the number of
Christopher R. Hertel [Mon, 1 Jul 2002 03:42:04 +0000 (03:42 +0000)]
The 17-bit length field in the header contains the number of
bytes which follow the header, not the full packet size.

    [Yes, the length field is either 17-bits, or (per the RFCs) it is a
    16-bit length field preceeded by an 8-bit flags field of which only
    the low-order bit may be used.  If that bit is set, then add 65536 to
    the 16-bit length field.  (In other words, it's a 17-bit unsigned
    length field.)
    ...unless, of course, the transport is native TCP [port 445] in which
    case the length field *might* be 24-bits wide.]

Anyway, the change is a very minor one.  We were including the four bytes
of the header in the length count and, as a result, sending four bytes of
garbage at the end of the SESSION REQUEST packet.

Small fix in function cli_session_request().
(This used to be commit cd2b1357066a712efcf87ac61922ef871118e8de)

20 years agofixed a makefile syntax error that was breaking the build on some
Andrew Tridgell [Sun, 30 Jun 2002 03:47:46 +0000 (03:47 +0000)]
fixed a makefile syntax error that was breaking the build on some
(This used to be commit 4eda1801493a79a27ad49e141e6adf8c8d4db85b)

20 years agoShut down printing tdb correctly - this will be more important when I go
Jeremy Allison [Fri, 28 Jun 2002 23:11:31 +0000 (23:11 +0000)]
Shut down printing tdb correctly - this will be more important when I go
to a tdb per-queue for scalability.
(This used to be commit e808eb2758ff4ad1eed7b50a02865b87ba0c068e)

20 years agoAdded limit on SPOOLSS pipes from 2.2.x
Jeremy Allison [Fri, 28 Jun 2002 19:41:17 +0000 (19:41 +0000)]
Added limit on SPOOLSS pipes from 2.2.x
(This used to be commit b35fc30c37fa894acea3fcb7b48ee9841d1bd5e8)

20 years agoTest how many pipes we can open.
Jeremy Allison [Fri, 28 Jun 2002 19:28:58 +0000 (19:28 +0000)]
Test how many pipes we can open.
(This used to be commit 95d22f18d7a2bb06804a6a336b243face4b496a1)

20 years agoConst cleanup...should only be 2 warnings left from calling lib/util_str.c
Jim McDonough [Fri, 28 Jun 2002 19:25:11 +0000 (19:25 +0000)]
Const cleanup...should only be 2 warnings left from calling lib/util_str.c
str_list_copy().  Perhaps its proto should be fixed.
(This used to be commit b81bc2b34b620c24a148435d9913bd1a1528c983)

20 years agoSTRING was being redefined...
Jeremy Allison [Fri, 28 Jun 2002 18:17:11 +0000 (18:17 +0000)]
STRING was being redefined...
(This used to be commit f631f7e0fc7ff655d56ad17606134784f401f171)

20 years agodon't backup to a newer file
Andrew Tridgell [Fri, 28 Jun 2002 03:52:22 +0000 (03:52 +0000)]
don't backup to a newer file
(This used to be commit ae2f8aa9d0678aa0014d96fc8b1b52f42cba8349)