sfrench/samba-autobuild/.git
4 years agolibreplace: Fix the build on Solaris
Volker Lendecke [Sat, 26 Sep 2015 22:57:50 +0000 (00:57 +0200)]
libreplace: Fix the build on Solaris

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agolib: Fix server_id_db_set_exclusive
Volker Lendecke [Tue, 29 Sep 2015 18:24:10 +0000 (20:24 +0200)]
lib: Fix server_id_db_set_exclusive

For server_id_db_set_exclusive we need to store the unique id along
with the vnn:pid combo. I had tested all this just with some
smbtorture and net command tests, all of which have a unique id of
zero. When trying to exclusively register "notify-daemon" when smbd
is running, this fails because serverid_exists only tests with zero
unique id. notifyd does have a non-zero unique id, so server_id_exists
will think the existing notifyd is another non-samba process that
happened to claim notifyd's pid.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Oct  1 02:53:58 CEST 2015 on sn-devel-104

4 years agolib: Add "pid/unique" format for server_id_from_string
Volker Lendecke [Tue, 29 Sep 2015 18:16:56 +0000 (20:16 +0200)]
lib: Add "pid/unique" format for server_id_from_string

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agolib: Fix server_id_from_string
Volker Lendecke [Tue, 29 Sep 2015 18:08:48 +0000 (20:08 +0200)]
lib: Fix server_id_from_string

sscanf overwrites vars as numbers come in. So the first sscanf will
overwrite "vnn", although it can't scan the whole thing. This leads
to the string "1234" return .vnn=1234, pid=1234. Bad.

While there, save the temp variables. The SCNu32/64 thingies look
ugly, but it's actually c99.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agolib: Add server_id_str_buf_unique
Volker Lendecke [Tue, 29 Sep 2015 02:03:52 +0000 (04:03 +0200)]
lib: Add server_id_str_buf_unique

A representation including the unique id

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agolib: Remove ctdb_serverids_exist
Volker Lendecke [Tue, 29 Sep 2015 23:27:00 +0000 (01:27 +0200)]
lib: Remove ctdb_serverids_exist

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agolib: Remove serverids_exist
Volker Lendecke [Tue, 29 Sep 2015 23:14:33 +0000 (01:14 +0200)]
lib: Remove serverids_exist

The only reason for this complex monster was an overload of ctdbd.
When opening files, we unconditionally checked all share modes for
validity. This meant thousands of serverid_exists calls per second
for popular directories. This has long gone, now we only check for
validity if a conflict happens.

The only remaining caller is net serverid wipedbs, an administrative
command. If that loads ctdbd, so be it.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agolib: Use messaging_dgm_get_unique in serverid_exists
Volker Lendecke [Tue, 29 Sep 2015 23:11:08 +0000 (01:11 +0200)]
lib: Use messaging_dgm_get_unique in serverid_exists

This is a relevant change: I was experimenting with
server_id_db_set_exclusive() in "net" and got failures all over the
place. The main reason was that "net" by default does not do a
serverid_register. With messaging_dgm we have the process' unique
id available via the lockfile contents. Using open/read/close is a
bit slower than local tdb access, but this version is safe for all
processes which have done messaging_init()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agolib: Use serverid_exists in server_id_db_check_exclusive
Volker Lendecke [Tue, 29 Sep 2015 23:01:46 +0000 (01:01 +0200)]
lib: Use serverid_exists in server_id_db_check_exclusive

If there's another process around there will typically be at most
one process. So there is no real need to run the plural version of
serverid_exists.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agomessages_dgm: Add messaging_dgm_get_unique
Volker Lendecke [Tue, 29 Sep 2015 22:31:17 +0000 (00:31 +0200)]
messages_dgm: Add messaging_dgm_get_unique

To be able to read, we need to open the lockfile O_RDWR instead of O_WRONLY

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agonet: Add "serverid exists"
Volker Lendecke [Tue, 29 Sep 2015 21:39:46 +0000 (23:39 +0200)]
net: Add "serverid exists"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agonet: Fix some tiny memleaks
Volker Lendecke [Tue, 29 Sep 2015 18:42:58 +0000 (20:42 +0200)]
net: Fix some tiny memleaks

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agos3:lib:interface: break an overly long line
Michael Adam [Mon, 21 Sep 2015 23:27:48 +0000 (01:27 +0200)]
s3:lib:interface: break an overly long line

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agos4-scripting: fix minor indent issue for hresult generation.
Günther Deschner [Wed, 30 Sep 2015 06:27:04 +0000 (08:27 +0200)]
s4-scripting: fix minor indent issue for hresult generation.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agos4-scripting: fix wrong indent that caused gen_ntstatus.py to fail.
Günther Deschner [Wed, 30 Sep 2015 06:14:06 +0000 (08:14 +0200)]
s4-scripting: fix wrong indent that caused gen_ntstatus.py to fail.

Verified it now works again with:

./source4/scripting/bin/gen_ntstatus.py libcli/util/ntstatus.h MS-ERREF-2.3.1.NTSTATUS libcli/util/nterr.c

MS-ERREF-2.3.1.NTSTATUS as the copied content from
https://msdn.microsoft.com/en-us/library/cc704588.aspx.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoldb: Fix CID 1034781 Unsigned compared against 0
Volker Lendecke [Tue, 18 Aug 2015 20:25:25 +0000 (22:25 +0200)]
ldb: Fix CID 1034781 Unsigned compared against 0

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agomessages_dgm: Fix an incorrect cast
Volker Lendecke [Tue, 29 Sep 2015 22:30:49 +0000 (00:30 +0200)]
messages_dgm: Fix an incorrect cast

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Sep 30 17:36:32 CEST 2015 on sn-devel-104

4 years agomessages_dgm: No includes.h necessary
Volker Lendecke [Tue, 29 Sep 2015 22:30:28 +0000 (00:30 +0200)]
messages_dgm: No includes.h necessary

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agos4-torture: trying to make clusapi resource online/offline testing a bit more robust
Günther Deschner [Mon, 21 Sep 2015 17:17:59 +0000 (19:17 +0200)]
s4-torture: trying to make clusapi resource online/offline testing a bit more robust

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Sep 29 15:00:47 CEST 2015 on sn-devel-104

4 years agos3-rpcclient: protect against empty witness async notify messages.
Günther Deschner [Mon, 14 Sep 2015 15:12:58 +0000 (17:12 +0200)]
s3-rpcclient: protect against empty witness async notify messages.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agolibrpc: properly quote uuids so that wireshark dissectors can be built from them.
Günther Deschner [Mon, 28 Sep 2015 17:08:58 +0000 (19:08 +0200)]
librpc: properly quote uuids so that wireshark dissectors can be built from them.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoclusapi: remove security.idl dependency from IDL.
Günther Deschner [Sun, 27 Sep 2015 22:47:17 +0000 (00:47 +0200)]
clusapi: remove security.idl dependency from IDL.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agobuild:wafsamba: Set the default installation prefix for Waf 1.8
Thomas Nagy [Mon, 28 Sep 2015 19:47:16 +0000 (21:47 +0200)]
build:wafsamba: Set the default installation prefix for Waf 1.8

These changes enable the default installation prefix settings to
take effect in both Waf 1.5 and 1.8 with no additional code changes.

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agosamba-tool: add command to dump dosinfo xattr from a file
Ralph Boehme [Fri, 25 Sep 2015 23:16:50 +0000 (01:16 +0200)]
samba-tool: add command to dump dosinfo xattr from a file

Add a new command "getdosinfo" to samba-tool to dump dosinfo xattr from
a file.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Sep 29 06:00:49 CEST 2015 on sn-devel-104

4 years agoctdb-build: Use socket_wrapper only with selftest
Mathieu Parent [Thu, 24 Sep 2015 02:39:17 +0000 (04:39 +0200)]
ctdb-build: Use socket_wrapper only with selftest

Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Sat Sep 26 16:52:28 CEST 2015 on sn-devel-104

4 years agos4: torture: Fix directory test against a server that actually uses index returns.
Jeremy Allison [Thu, 24 Sep 2015 18:28:50 +0000 (11:28 -0700)]
s4: torture: Fix directory test against a server that actually uses index returns.

Who knew ? Finally found one that does this :-).

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Jim McDonough <jmcd@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Sep 25 08:21:49 CEST 2015 on sn-devel-104

4 years agonet: fix a crash with net ads keytab create
Uri Simchoni [Wed, 23 Sep 2015 11:45:47 +0000 (14:45 +0300)]
net: fix a crash with net ads keytab create

Fix a crash that happens when executing "net ads keytab create"
and the machine account in AD does not have setvice principal names
attached to it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11528

Signed-off-by: Uri Simchoni <urisimchoni@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agowitness: fix length calculation in witness_IPaddrInfoList IDL.
Günther Deschner [Thu, 24 Sep 2015 04:40:39 +0000 (06:40 +0200)]
witness: fix length calculation in witness_IPaddrInfoList IDL.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Autobuild-User(master): José A. Rivera <jarrpa@samba.org>
Autobuild-Date(master): Thu Sep 24 22:33:28 CEST 2015 on sn-devel-104

4 years agowitness: fix IP address endianess in witness_IPaddrInfo IDL.
Günther Deschner [Thu, 24 Sep 2015 04:40:19 +0000 (06:40 +0200)]
witness: fix IP address endianess in witness_IPaddrInfo IDL.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
4 years agos4-torture: add test to verify WITNESS_NOTIFY_CLIENT_MOVE message marshalling.
Günther Deschner [Thu, 24 Sep 2015 00:47:35 +0000 (02:47 +0200)]
s4-torture: add test to verify WITNESS_NOTIFY_CLIENT_MOVE message marshalling.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
4 years agosmbd: Set process name for notifyd process
Christof Schmitt [Wed, 23 Sep 2015 18:21:21 +0000 (11:21 -0700)]
smbd: Set process name for notifyd process

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Sep 24 11:02:44 CEST 2015 on sn-devel-104

4 years agosmbd: Set process name for async echo handler
Christof Schmitt [Wed, 23 Sep 2015 18:15:44 +0000 (11:15 -0700)]
smbd: Set process name for async echo handler

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agos3: Move call to prctl_set_comment to reinit_after_fork
Christof Schmitt [Wed, 23 Sep 2015 18:14:05 +0000 (11:14 -0700)]
s3: Move call to prctl_set_comment to reinit_after_fork

This save a few lines of code.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agolib: Fix prctl detection for prctl_set_comment
Christof Schmitt [Wed, 23 Sep 2015 19:28:30 +0000 (12:28 -0700)]
lib: Fix prctl detection for prctl_set_comment

Include config.h to make HAVE_PRCTL available for the precompile check.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agos4: torture: Test mkdir race condition.
Jeremy Allison [Wed, 23 Sep 2015 01:01:22 +0000 (18:01 -0700)]
s4: torture: Test mkdir race condition.

Found by Max of LoadDynamix <adx.forum@gmail.com>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11486

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Sep 24 06:13:22 CEST 2015 on sn-devel-104

4 years agos3: smbd: Fix mkdir race condition.
Jeremy Allison [Wed, 23 Sep 2015 01:02:53 +0000 (18:02 -0700)]
s3: smbd: Fix mkdir race condition.

Found by Max of LoadDynamix <adx.forum@gmail.com>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11486

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agodocs: Fix references to async smb echo handler in smb.conf manpage
Christof Schmitt [Wed, 23 Sep 2015 17:41:06 +0000 (10:41 -0700)]
docs: Fix references to async smb echo handler in smb.conf manpage

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agos4:torture: add a test for 0 byte sized streams
Ralph Boehme [Tue, 22 Sep 2015 01:15:14 +0000 (03:15 +0200)]
s4:torture: add a test for 0 byte sized streams

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Sep 22 23:46:00 CEST 2015 on sn-devel-104

4 years agos4: torture: Fix double-free on error.
Herb Lewis [Tue, 22 Sep 2015 18:39:54 +0000 (11:39 -0700)]
s4: torture: Fix double-free on error.

Signed-off-by: Herb Lewis <hlewis@panasas.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agodbwrap: Remove talloc from dbwrap_watch_record_stored()
Volker Lendecke [Sun, 20 Sep 2015 16:25:20 +0000 (18:25 +0200)]
dbwrap: Remove talloc from dbwrap_watch_record_stored()

This happens on every store to locking.tdb for example, so we should
make it cheap.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Sep 22 07:50:58 CEST 2015 on sn-devel-104

4 years agodbwrap: Convert dbwrap_record_watchers_key to not use talloc
Volker Lendecke [Sun, 20 Sep 2015 15:32:24 +0000 (17:32 +0200)]
dbwrap: Convert dbwrap_record_watchers_key to not use talloc

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agodbwrap: Simplify dbwrap_record_watchers_key()
Volker Lendecke [Sun, 20 Sep 2015 15:06:22 +0000 (17:06 +0200)]
dbwrap: Simplify dbwrap_record_watchers_key()

It took a bit for me to figure out what the rec_key parameter to
dbwrap_record_watchers_key does. I think it's simpler to parse the watcher key
in dbwrap_record_watch_recv to retrieve the watched record key than to store it

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agodbwrap: Make dbwrap_db_id return size_t
Volker Lendecke [Sun, 20 Sep 2015 14:26:06 +0000 (16:26 +0200)]
dbwrap: Make dbwrap_db_id return size_t

This will make an on-stack db-id easier

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agodbwrap: Remove talloc_reference()
Volker Lendecke [Mon, 21 Sep 2015 10:32:47 +0000 (12:32 +0200)]
dbwrap: Remove talloc_reference()

We want to know (by crashing) when we free the database with records still
around. This would be a serious violation of our data structure hierarchies.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agodbwrap: Remove unused dbwrap_hash_size()
Volker Lendecke [Sun, 20 Sep 2015 18:25:53 +0000 (20:25 +0200)]
dbwrap: Remove unused dbwrap_hash_size()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agodbwrap: Remove loadparm_context from db_open_tdb
Volker Lendecke [Mon, 21 Sep 2015 10:28:20 +0000 (12:28 +0200)]
dbwrap: Remove loadparm_context from db_open_tdb

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agobuild: improve stack protector check
Gustavo Zacarias [Fri, 11 Sep 2015 19:57:16 +0000 (16:57 -0300)]
build: improve stack protector check

Testing a toolchain for proper -fstack-protector must go beyond ensuring
the compiler and linker accept the option.
If the test C program does nothing with the stack then guards aren't
inserted and/or are optimized away giving the false impression that it
works when in fact the libc might not support it.

Update the check to a program that uses the stack, hence making a link
fail if proper support isn't available, for example in non-ssp enabled
uclibc toolchains like this:

test.c:(.text.startup+0x64): undefined reference to `__stack_chk_fail'

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <rb@sernet.de>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Sep 21 23:29:13 CEST 2015 on sn-devel-104

4 years agos4:torture:smb2:rename: Fix typo in simple_nodelete testcase.
Anubhav Rakshit [Wed, 16 Sep 2015 15:34:12 +0000 (21:04 +0530)]
s4:torture:smb2:rename: Fix typo in simple_nodelete testcase.

Signed-off-by: Anubhav Rakshit <anubhav.rakshit@gmail.com>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Mon Sep 21 04:51:11 CEST 2015 on sn-devel-104

4 years agolib/param: fix hiding of FLAG_SYNONYM values
Stefan Metzmacher [Fri, 18 Sep 2015 16:54:31 +0000 (18:54 +0200)]
lib/param: fix hiding of FLAG_SYNONYM values

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11526

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agobuild:wafsamba: Use the samba-provided CHECK_CFG method in configuration tests
Thomas Nagy [Sat, 12 Sep 2015 07:49:41 +0000 (09:49 +0200)]
build:wafsamba: Use the samba-provided CHECK_CFG method in configuration tests

This is for forward compatibility with waf 1.8. All other tests
use CHECK_CFG, but check_cfg was re-introduced for some reason.

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-doc: Fix a typo in the definition of CTDB_NODE_ADDRESS
Martin Schwenke [Wed, 9 Sep 2015 07:06:50 +0000 (17:06 +1000)]
ctdb-doc: Fix a typo in the definition of CTDB_NODE_ADDRESS

Should be an IP address not a filename.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sat Sep 19 16:39:23 CEST 2015 on sn-devel-104

4 years agoRevert "tdb: Add tdbdump -u"
Ralph Boehme [Fri, 18 Sep 2015 08:58:37 +0000 (10:58 +0200)]
Revert "tdb: Add tdbdump -u"

This reverts commit ea53e86c256bec08373dbe86e190a7f5a06eff9d.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Sep 18 14:03:12 CEST 2015 on sn-devel-104

4 years agos3: tests: smbclient test to ensure we can create and see a :foobar stream on the...
Jeremy Allison [Wed, 16 Sep 2015 23:12:15 +0000 (16:12 -0700)]
s3: tests: smbclient test to ensure we can create and see a :foobar stream on the top level directory in a share.

Regression test for:

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11522

Remember to remove the ARCHIVE attribute from the toplevel
share when done (can only be done over SMB2+).

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Sep 18 11:00:44 CEST 2015 on sn-devel-104

4 years agos3: smbd: Fix opening/creating :stream files on the root share directory.
Jeremy Allison [Wed, 16 Sep 2015 19:03:34 +0000 (12:03 -0700)]
s3: smbd: Fix opening/creating :stream files on the root share directory.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11522

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: smbd: Remove unused parameter from build_stream_path().
Jeremy Allison [Wed, 16 Sep 2015 19:42:46 +0000 (12:42 -0700)]
s3: smbd: Remove unused parameter from build_stream_path().

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: smbclient: Move cmd_setmode out of clitar.c and back into client.c
Jeremy Allison [Thu, 17 Sep 2015 22:54:40 +0000 (15:54 -0700)]
s3: smbclient: Move cmd_setmode out of clitar.c and back into client.c

setmode <file> attribute is a valid smbclient command even if libarchive
isn't on the system and tarmode isn't compiled in.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agotdb: Add tdbdump -u
Volker Lendecke [Tue, 15 Sep 2015 15:08:24 +0000 (17:08 +0200)]
tdb: Add tdbdump -u

The reverse of tdbdump

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Sep 18 03:04:35 CEST 2015 on sn-devel-104

4 years agos4:lib/messaging: use 'msg.lock' and 'msg.sock' for messaging related subdirs
Stefan Metzmacher [Wed, 16 Sep 2015 10:44:43 +0000 (12:44 +0200)]
s4:lib/messaging: use 'msg.lock' and 'msg.sock' for messaging related subdirs

In Samba 4.2, we used lock_path("msg") (with 0700) for the socket directory,
while we use lock_path("msg") (with 0755) for the lock file directory.

This generates a conflict that prevents samba, smbd, nmbd and winbindd
from starting after an upgrade.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11515

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Sep 17 09:04:59 CEST 2015 on sn-devel-104

4 years agos3:lib/messages: use 'msg.lock' and 'msg.sock' for messaging related subdirs
Stefan Metzmacher [Wed, 16 Sep 2015 10:44:43 +0000 (12:44 +0200)]
s3:lib/messages: use 'msg.lock' and 'msg.sock' for messaging related subdirs

In Samba 4.2, we used lock_path("msg") (with 0700) for the socket directory,
while we use lock_path("msg") (with 0755) for the lock file directory.

This generates a conflict that prevents samba, smbd, nmbd and winbindd
from starting after an upgrade.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11515

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agos3:lib/messages: add missing allocation check for priv_path
Stefan Metzmacher [Wed, 16 Sep 2015 10:42:48 +0000 (12:42 +0200)]
s3:lib/messages: add missing allocation check for priv_path

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11515

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agos4: tests: Fix nss_tests build on Solaris.
Tom Schulz [Wed, 16 Sep 2015 23:55:23 +0000 (16:55 -0700)]
s4: tests: Fix nss_tests build on Solaris.

Too many arguments for Solaris getpwent_r() and getgrent_r().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11508

Signed-off-by: Tom Schulz <schulz@adi.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <rb@sernet.de>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Sep 17 05:01:07 CEST 2015 on sn-devel-104

4 years agoMakefile: Add option to list all tests
Andreas Schneider [Tue, 15 Sep 2015 14:20:48 +0000 (16:20 +0200)]
Makefile: Add option to list all tests

This allows you to run 'make testlist' to get a complete list of all our
tests available. You can limit it using 'make testlist TESTS=spoolss' to
only show spoolss tests for example.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Sep 15 21:57:50 CEST 2015 on sn-devel-104

4 years agoctdb: Fix CID 1324447 Double close
Volker Lendecke [Tue, 15 Sep 2015 08:19:03 +0000 (10:19 +0200)]
ctdb: Fix CID 1324447 Double close

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue Sep 15 16:20:07 CEST 2015 on sn-devel-104

4 years agoctdb-build: Install pre-built manpages when xsltproc not available
Martin Schwenke [Fri, 11 Sep 2015 03:08:38 +0000 (13:08 +1000)]
ctdb-build: Install pre-built manpages when xsltproc not available

At the moment they are not installed at all if xsltproc is not
available.

They can still be filtered to have the paths match what was
configured.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Sep 15 11:57:44 CEST 2015 on sn-devel-104

4 years agoctdb-doc: Update out-of-date documentation for CTDB socket options
Martin Schwenke [Mon, 17 Aug 2015 11:09:06 +0000 (21:09 +1000)]
ctdb-doc: Update out-of-date documentation for CTDB socket options

These still say /tmp/ctdb.socket, which is very out-dated.  Update
with build-time location.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-scripts: Update important installed files to use build-time defaults
Martin Schwenke [Mon, 17 Aug 2015 10:47:58 +0000 (20:47 +1000)]
ctdb-scripts: Update important installed files to use build-time defaults

In this case: ctdbd_wrapper, onnode, ctdb_diagnostics, ctdb.sudoers.
Set sensible defaults from configure options.

Update documentation to match, trying to fix up anything that has been
missed before.

The onnode unit tests need a symlink to the functions file.
The simple integration tests need to set CTDB_BASE and also
need symlinks to functions/nodes.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
fixup

Signed-off-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-tools: Drop vacuum.log from ctdb_diagnostics
Martin Schwenke [Sat, 22 Aug 2015 10:14:09 +0000 (20:14 +1000)]
ctdb-tools: Drop vacuum.log from ctdb_diagnostics

This hasn't existed for a long time.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-scripts: Rename variable CTDB_ETCDIR to CTDB_SYS_ETCDIR
Martin Schwenke [Mon, 17 Aug 2015 04:12:15 +0000 (14:12 +1000)]
ctdb-scripts: Rename variable CTDB_ETCDIR to CTDB_SYS_ETCDIR

This variable points to /etc/ by default.

This distinguishes it from the different variable from wscript, which
points to /etc/ctdb/.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-scripts: CTDB_BASE must be set when including functions file
Martin Schwenke [Mon, 17 Aug 2015 04:01:40 +0000 (14:01 +1000)]
ctdb-scripts: CTDB_BASE must be set when including functions file

Also fix an unused test to set CTDB_BASE.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-scripts: Factor out possible creation of rt_tables file
Martin Schwenke [Mon, 17 Aug 2015 03:39:10 +0000 (13:39 +1000)]
ctdb-scripts: Factor out possible creation of rt_tables file

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-scripts: Move remaining state files into CTDB_SCRIPT_VARDIR
Martin Schwenke [Thu, 13 Aug 2015 05:57:52 +0000 (15:57 +1000)]
ctdb-scripts: Move remaining state files into CTDB_SCRIPT_VARDIR

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-scripts: New internal variable CTDB_SCRIPT_VARDIR
Martin Schwenke [Thu, 13 Aug 2015 05:54:20 +0000 (15:54 +1000)]
ctdb-scripts: New internal variable CTDB_SCRIPT_VARDIR

Clearly identifies where all state files from scripts should go and
allows that location to be easily changed.  This patch should not
change any behaviour (outside of eventscript unit tests, where a
clearer location is now used).

CTDB_VARDIR should no longer be overridden.  Continue to set
CTDB_DBDIR and similar to override database location in unit tests.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-scripts: Properly set CTDB_VARDIR in scripts at install time
Martin Schwenke [Thu, 13 Aug 2015 05:17:51 +0000 (15:17 +1000)]
ctdb-scripts: Properly set CTDB_VARDIR in scripts at install time

Have wscript do path substitution.

No need to export this and CTDB_ETCDIR here, but test scripts will
still need to do so.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-build: Add missing manual pages to pre-generate list for tarball
Martin Schwenke [Fri, 21 Aug 2015 11:19:55 +0000 (21:19 +1000)]
ctdb-build: Add missing manual pages to pre-generate list for tarball

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-docs: Update "ctdb reloadnodes" documentation
Martin Schwenke [Fri, 21 Aug 2015 06:07:21 +0000 (16:07 +1000)]
ctdb-docs: Update "ctdb reloadnodes" documentation

Format instructions for adding/deleting nodes with appropriate XML and
simplify wording.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-scripts: Drop internal file-level variables referencing $CTDB_VARDIR
Martin Schwenke [Mon, 10 Aug 2015 06:11:18 +0000 (16:11 +1000)]
ctdb-scripts: Drop internal file-level variables referencing $CTDB_VARDIR

Using $CTDB_VARDIR at file scope is dangerous because it doesn't
respect the configuration.  Uses of these variables are simple so just
drop the variables and use $CTDB_VARDIR inside functions where it is
safe.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-scripts: Drop file removal involving $ctdb_managed_dir
Martin Schwenke [Mon, 10 Aug 2015 06:33:42 +0000 (16:33 +1000)]
ctdb-scripts: Drop file removal involving $ctdb_managed_dir

This directory has been under $CTDB_VARDIR for a long time, so is
already removed.  The command is also potentially dangerous if
$ctdb_managed_dir is not set.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-scripts: Drop functions ctdb_checkstatus() and ctdb_setstatus()
Martin Schwenke [Mon, 10 Aug 2015 06:03:05 +0000 (16:03 +1000)]
ctdb-scripts: Drop functions ctdb_checkstatus() and ctdb_setstatus()

They're not used outside of ctdb_standard_event_helper().

As a consequence, make ctdb_standard_event_helper() do nothing.  It is
harder to remove because it is used in many places, perhaps by
external eventscripts where it has been copied from existing scripts.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-scripts: Drop 62.cnfs eventscript
Martin Schwenke [Mon, 10 Aug 2015 05:34:29 +0000 (15:34 +1000)]
ctdb-scripts: Drop 62.cnfs eventscript

To get a similar effect just do something like this:

  mmaddcallback ctdb-disable-on-quorumLoss \
    --command /usr/bin/ctdb \
    --event quorumLoss --parms "disable"

  mmaddcallback ctdb-enable-on-quorumReached \
    --command /usr/bin/ctdb \
    --event quorumReached --parms "enable"

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-scripts: New internal variable CTDB_NFS_CALLOUT_STATE_DIR
Martin Schwenke [Tue, 1 Sep 2015 23:27:58 +0000 (09:27 +1000)]
ctdb-scripts: New internal variable CTDB_NFS_CALLOUT_STATE_DIR

60.nfs sets this to a directory where the NFS callout can store state.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Sep 14 08:36:34 CEST 2015 on sn-devel-104

4 years agos3: dfs: Fix a crash when the dfs targets are disabled.
Har Gagan Sahai [Thu, 10 Sep 2015 10:34:27 +0000 (16:04 +0530)]
s3: dfs: Fix a crash when the dfs targets are disabled.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11509

Signed-off-by: Har Gagan Sahai <SHarGagan@novell.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ira Cooper <ira@wakeful.net>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Sep 11 06:39:19 CEST 2015 on sn-devel-104

4 years agobuild: use as-needed linker flag also on OpenBSD
Björn Jacke [Thu, 10 Sep 2015 19:31:03 +0000 (21:31 +0200)]
build: use as-needed linker flag also on OpenBSD

OpenBSD is unusable with binaries with many superfluous libs linked in.
samba-tool start times of 250 seconds without as-needed vs. 1.4 seconds with
as-needed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11355

Signed-off-by: Bjoern Jacke <bj@sernet.de>
Reviewed-by: Ralph Böhme <rb@sernet.de>
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Fri Sep 11 03:37:17 CEST 2015 on sn-devel-104

4 years agonss_winbind: fix hang on Solaris on big groups
Björn Jacke [Thu, 10 Sep 2015 12:35:32 +0000 (14:35 +0200)]
nss_winbind: fix hang on Solaris on big groups

The problem with large groups on Solaris in the the NSS winbind module is
Solaris wants the return value to be NSS_UNAVAIL if the buffer given is too
small for getgrnam_r.  The current code return NSS_TRYAGAIN which causes
Solaris/Illumos to loop without trying to resize the buffer.

Thanks to  Nathan Huff <nhuff@acm.org> for finding this out.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10365

Signed-off-by: Bjoern Jacke <bj@sernet.de>
Reviewed-by: Ralph Böhme <rb@sernet.de>
4 years agonss_wins: add module for FreeBSD
Björn Jacke [Thu, 10 Sep 2015 09:27:42 +0000 (11:27 +0200)]
nss_wins: add module for FreeBSD

Thanks to Timur Bakeyev <timur@FreeBSD.org> for the patch.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11493

Signed-off-by: Bjoern Jacke <bj@sernet.de>
Reviewed-by: Ralph Böhme <rb@sernet.de>
4 years agosmbXsrv_session: factor smbXsrv_session_add_channel() out of smbXsrv_session_create()
Stefan Metzmacher [Wed, 25 Jun 2014 14:09:04 +0000 (16:09 +0200)]
smbXsrv_session: factor smbXsrv_session_add_channel() out of smbXsrv_session_create()

This allows to create more than one channel.

Pair-Programmed-With: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Sep 10 21:33:47 CEST 2015 on sn-devel-104

4 years agos3:smb2_sesssetup: let smbd_smb2_reauth_generic_return() cope with channels
Stefan Metzmacher [Wed, 29 Jul 2015 15:44:37 +0000 (17:44 +0200)]
s3:smb2_sesssetup: let smbd_smb2_reauth_generic_return() cope with channels

Pair-Programmed-With: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agos3:smb2_sesssetup: let smbd_smb2_auth_generic_return() cope with channels
Michael Adam [Wed, 29 Jul 2015 15:42:55 +0000 (17:42 +0200)]
s3:smb2_sesssetup: let smbd_smb2_auth_generic_return() cope with channels

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agos3:smb2_sesssetup: change talloc hierarchy in smbd_smb2_session_setup_gensec_done
Michael Adam [Wed, 29 Jul 2015 15:07:29 +0000 (17:07 +0200)]
s3:smb2_sesssetup: change talloc hierarchy in smbd_smb2_session_setup_gensec_done

Only put session_info to the session->global context if we use it.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoreplace: Fix check for gettimeofday()
Andreas Schneider [Wed, 9 Sep 2015 11:47:42 +0000 (13:47 +0200)]
replace: Fix check for gettimeofday()

The check does not include <sys/time.h> the test might fail with a
implicit function declaration error.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Sep 10 00:36:16 CEST 2015 on sn-devel-104

4 years agonet: reformat usage text for 'net ads join'
Michael Adam [Wed, 9 Sep 2015 06:58:43 +0000 (08:58 +0200)]
net: reformat usage text for 'net ads join'

Make the items nicely aligned again and do not exceed 80 columns.
A few typos are fixed along the way.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agodocs: mention new --no-dns-updates parameter in manpage of net.
Michael Adam [Wed, 9 Sep 2015 06:40:31 +0000 (08:40 +0200)]
docs: mention new --no-dns-updates parameter in manpage of net.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agonet: add option --no-dns-updates for net ads join
Michael Adam [Wed, 9 Sep 2015 06:28:43 +0000 (08:28 +0200)]
net: add option --no-dns-updates for net ads join

If called with this option, 'net ads join' will not attempt
to perform dns updates.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agolibsmb: Fix CID 1034606 Incorrect pointer comparison
Anoop C S [Wed, 9 Sep 2015 06:37:21 +0000 (06:37 +0000)]
libsmb: Fix CID 1034606 Incorrect pointer comparison

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed Sep  9 21:33:49 CEST 2015 on sn-devel-104

4 years agolibsmb: Fix CID 1034605 Incorrect pointer comparison
Anoop C S [Wed, 9 Sep 2015 06:35:15 +0000 (06:35 +0000)]
libsmb: Fix CID 1034605 Incorrect pointer comparison

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agowinbindd: Fix CID 1273310 Remove structurally dead code
Anoop C S [Tue, 8 Sep 2015 08:21:47 +0000 (08:21 +0000)]
winbindd: Fix CID 1273310 Remove structurally dead code

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agobuild: line-break deps for 'param' subsystem
Michael Adam [Tue, 10 Jun 2014 14:48:40 +0000 (16:48 +0200)]
build: line-break deps for 'param' subsystem

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Wed Sep  9 13:12:43 CEST 2015 on sn-devel-104

4 years agobuild: fix quotation of deps for 'param' subsystem.
Michael Adam [Fri, 3 Jul 2015 10:12:44 +0000 (12:12 +0200)]
build: fix quotation of deps for 'param' subsystem.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-server: fix a possible fd leak in ctdb_tcp_listen_automatic()
Michael Adam [Tue, 8 Sep 2015 08:01:31 +0000 (10:01 +0200)]
ctdb-server: fix a possible fd leak in ctdb_tcp_listen_automatic()

sockets are created in a loop until an unused address is found.
But the unused socket fds were not closed.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb: improve a misleading help text.
Michael Adam [Mon, 7 Sep 2015 16:09:44 +0000 (18:09 +0200)]
ctdb: improve a misleading help text.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-doc: remove description of removed --syslog option from ctdbd manpage
Michael Adam [Tue, 8 Sep 2015 08:08:20 +0000 (10:08 +0200)]
ctdb-doc: remove description of removed --syslog option from ctdbd manpage

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>