sfrench/samba-autobuild/.git
4 years agobuild:wafsamba: Replace Options.is_install by bld.is_install
Thomas Nagy [Fri, 6 Nov 2015 23:57:36 +0000 (00:57 +0100)]
build:wafsamba: Replace Options.is_install by bld.is_install

Options.is_install is a deprecated module variable that is more
verbose than bld.is_install and complicates the Waf 1.8 upgrade.

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-recoverd: Factor out recovery master validation
Martin Schwenke [Tue, 27 Oct 2015 05:43:07 +0000 (16:43 +1100)]
ctdb-recoverd: Factor out recovery master validation

Starting to untangle cluster management, database recovery and public
IP allocation.  This is a non-trivial subset of the cluster management
code that runs in the recovery daemon on all nodes.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Nov 16 11:47:45 CET 2015 on sn-devel-104

4 years agoctdb-recmaster: Update capabilities before calling first election
Martin Schwenke [Tue, 27 Oct 2015 04:09:33 +0000 (15:09 +1100)]
ctdb-recmaster: Update capabilities before calling first election

Capabilities are used when computing an election result so having them
up-to-date seems like a good idea.

Also update several instances of an ambiguous comment.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Move VNN map retrieval to where it is needed
Martin Schwenke [Tue, 27 Oct 2015 03:35:09 +0000 (14:35 +1100)]
ctdb-recoverd: Move VNN map retrieval to where it is needed

The VNN map is only needed on the recovery master, so no need for all
recovery daemons to retrieve it.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Drop explicit check for recovery lock
Martin Schwenke [Tue, 27 Oct 2015 03:32:48 +0000 (14:32 +1100)]
ctdb-recoverd: Drop explicit check for recovery lock

This is already handled in update_recovery_lock(), which is called
immediately before.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Simplify using TALLOC_FREE()
Martin Schwenke [Fri, 23 Oct 2015 05:00:55 +0000 (16:00 +1100)]
ctdb-recoverd: Simplify using TALLOC_FREE()

The only non-obvious part here is dropping the setting of the nodemap
local variable to NULL.  If the following control succeeds then it is
set, otherwise return and it doesn't matter.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Clarify that recmaster is being set on the current node
Martin Schwenke [Fri, 23 Oct 2015 04:27:12 +0000 (15:27 +1100)]
ctdb-recoverd: Clarify that recmaster is being set on the current node

That is, using CTDB_CURRENT_NODE makes this more obvious.

Also fix incorrect error messages.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Do not sanity check recovery master with local daemon
Martin Schwenke [Fri, 23 Oct 2015 04:05:08 +0000 (15:05 +1100)]
ctdb-recoverd: Do not sanity check recovery master with local daemon

Each recovery daemon knows who the recmaster is and is in sync with
its local daemon.  The recovery master is running this check so do not
bother checking with its local daemon - both agree that it is the
recovery master.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Don't retrieve recovery master from local daemon
Martin Schwenke [Fri, 23 Oct 2015 04:33:01 +0000 (15:33 +1100)]
ctdb-recoverd: Don't retrieve recovery master from local daemon

The recovery daemon already knows which node is the master.  This
relies on rec->recmaster being correctly initialised and correctly set
during elections.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Explicitly set initial recovery master to unknown
Martin Schwenke [Tue, 10 Nov 2015 02:54:47 +0000 (13:54 +1100)]
ctdb-recoverd: Explicitly set initial recovery master to unknown

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Do not set recovery master during recovery
Martin Schwenke [Thu, 22 Oct 2015 10:54:58 +0000 (21:54 +1100)]
ctdb-recoverd: Do not set recovery master during recovery

Recovery should not do cluster management functions.  Setting the
recovery master should only be done via an election.

Main loop will determine if recovery master is inconsistent across the
cluster and force an election if necessary.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Have recovery daemon remember election result
Martin Schwenke [Fri, 23 Oct 2015 03:32:41 +0000 (14:32 +1100)]
ctdb-recoverd: Have recovery daemon remember election result

The recovery daemon pushes knowledge of recovery master election
progress/result to local daemon.  It then retrieves that information
again.

Instead, have the recovery daemon reliably track election
progress/result in rec->recmaster so it doesn't need to be retrieved.
Be careful to maintain consistency by only doing this when the local
daemon has been updated.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Clarify recovery master validation logic
Martin Schwenke [Wed, 21 Oct 2015 05:19:00 +0000 (16:19 +1100)]
ctdb-recoverd: Clarify recovery master validation logic

There can be no holes in the nodemap.  Even if a node has been deleted
it will take a slot in the nodemap.  The only exception is that the
nodemap shrinks if nodes are deleted from the end.  That should never
include the master because a node should be shutdown before being
deleted, and an election should already have take place.

To avoid walking off the end of the nodemap nodes array just confirm
that the master node's PNN is a valid index into the array.  No need
to walk through the nodemap.

After this, in this section of the code j is now invalid.  So use the
master's PNN to index into the nodemap.  This is safe.

In the process, clean up some log messages to avoid saying "Force
reelection".  It's just an "election".

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoWHATSNEW: Document CTDB tunable change
Martin Schwenke [Fri, 13 Nov 2015 04:23:14 +0000 (15:23 +1100)]
WHATSNEW: Document CTDB tunable change

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-daemon: Rename EventScriptTimeoutCount to MonitorTimeoutCount
Martin Schwenke [Wed, 28 Oct 2015 06:03:01 +0000 (17:03 +1100)]
ctdb-daemon: Rename EventScriptTimeoutCount to MonitorTimeoutCount

This only applies to monitor events so renaming clarifies this.

Note that this change is not backward compatible.  Users with

  CTDB_SET_EventScriptTimeoutCount=<n>

in their configuration will get failures when starting CTDB but the
cause will be clearly logged.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-daemon: Move script timeout count into monitor state
Martin Schwenke [Wed, 28 Oct 2015 05:51:59 +0000 (16:51 +1100)]
ctdb-daemon: Move script timeout count into monitor state

It is only used by the monitoring code.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-daemon: Reset script timeout count in monitor code
Martin Schwenke [Wed, 28 Oct 2015 05:42:41 +0000 (16:42 +1100)]
ctdb-daemon: Reset script timeout count in monitor code

This is the only place it is used.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-daemon: Do not bother printing script timeout count
Martin Schwenke [Wed, 28 Oct 2015 05:39:18 +0000 (16:39 +1100)]
ctdb-daemon: Do not bother printing script timeout count

It is only updated for monitor events, so it is meaningless here.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-doc: Correct documentation for tunables for script timeout
Martin Schwenke [Tue, 27 Oct 2015 04:18:25 +0000 (15:18 +1100)]
ctdb-doc: Correct documentation for tunables for script timeout

* The defaults for EventScriptTimeout and EventScriptTimeoutCount are
  wrong.

* EventScriptTimeout is the total time for all enabled scripts that
  are run for an event, not a single event script.

* EventScriptTimeoutCount only applies to monitor events.

* EventScriptUnhealthyOnTimeout is obsolete, so remove it.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-ipalloc: Don't consider runstates in the IP takeover code
Martin Schwenke [Wed, 28 Oct 2015 11:15:00 +0000 (22:15 +1100)]
ctdb-ipalloc: Don't consider runstates in the IP takeover code

Checking runstates is unnecessary now that nodes that are not RUNNING
will return no available IP addresses.  I have no idea why I didn't do
it this way originally.

Tweak the test code to cope with this.

Note that this is a backward-incompatible change.  If new and old
versions of CTDB are running together in a cluster and a new node
takes over as recovery master then old nodes will be able to host
public IP addresses before they are in RUNNING runstate.  This is
mitigated by the bias towards recovery master stability in elections.
If it is important that nodes do not host IPs until they are RUNNING
then do not restart nodes running the old version.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-ipalloc: Check for available IPs, not runstate, in takeover run
Martin Schwenke [Wed, 28 Oct 2015 11:11:33 +0000 (22:11 +1100)]
ctdb-ipalloc: Check for available IPs, not runstate, in takeover run

The available IPs list is now only non-empty for nodes that are in
RUNNING runstate.  So, to avoid running the IP allocation algorithm
when there are no available available IPs, explicitly check for
available IPs rather than checking runstates.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-ipalloc: A VNN can only host IPs if node is in RUNNING runstate
Martin Schwenke [Wed, 28 Oct 2015 09:41:08 +0000 (20:41 +1100)]
ctdb-ipalloc: A VNN can only host IPs if node is in RUNNING runstate

This will allow wonderful simplification (i.e. removal) of some of the
runstate checking in the takeover run code.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-build: Remove ctdb-common-util subsystem
Amitay Isaacs [Wed, 11 Nov 2015 05:52:30 +0000 (16:52 +1100)]
ctdb-build: Remove ctdb-common-util subsystem

Include system_util.c in ctdb-system subsystem.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Mon Nov 16 03:51:36 CET 2015 on sn-devel-104

4 years agoctdb-daemon: Remove unused ctdb_logging.[ch]
Amitay Isaacs [Wed, 11 Nov 2015 05:43:44 +0000 (16:43 +1100)]
ctdb-daemon: Remove unused ctdb_logging.[ch]

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-tool: Use new debug level API
Amitay Isaacs [Wed, 11 Nov 2015 05:40:41 +0000 (16:40 +1100)]
ctdb-tool: Use new debug level API

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-common: Use new debug level API
Amitay Isaacs [Wed, 11 Nov 2015 04:19:41 +0000 (15:19 +1100)]
ctdb-common: Use new debug level API

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-tests: Build in common/logging.c
Amitay Isaacs [Wed, 11 Nov 2015 05:33:43 +0000 (16:33 +1100)]
ctdb-tests: Build in common/logging.c

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-tests: Replace ctdb_logging.h with common/logging.h
Amitay Isaacs [Wed, 11 Nov 2015 05:00:23 +0000 (16:00 +1100)]
ctdb-tests: Replace ctdb_logging.h with common/logging.h

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-transport: Replace ctdb_logging.h with common/logging.h
Amitay Isaacs [Wed, 11 Nov 2015 04:22:52 +0000 (15:22 +1100)]
ctdb-transport: Replace ctdb_logging.h with common/logging.h

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-server: Replace ctdb_logging.h with common/logging.h
Amitay Isaacs [Wed, 11 Nov 2015 04:41:10 +0000 (15:41 +1100)]
ctdb-server: Replace ctdb_logging.h with common/logging.h

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-common: Replace ctdb_logging.h with common/logging.h
Amitay Isaacs [Wed, 11 Nov 2015 04:19:17 +0000 (15:19 +1100)]
ctdb-common: Replace ctdb_logging.h with common/logging.h

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-client: Replace ctdb_logging.h with common/logging.h
Amitay Isaacs [Wed, 11 Nov 2015 04:17:56 +0000 (15:17 +1100)]
ctdb-client: Replace ctdb_logging.h with common/logging.h

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-system: Replace ctdb_logging.h with common/logging.h
Amitay Isaacs [Wed, 11 Nov 2015 03:43:56 +0000 (14:43 +1100)]
ctdb-system: Replace ctdb_logging.h with common/logging.h

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-logging: Remove duplicate definitions
Amitay Isaacs [Wed, 11 Nov 2015 04:10:38 +0000 (15:10 +1100)]
ctdb-logging: Remove duplicate definitions

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-tests: Update test to set numeric debug levels
Amitay Isaacs [Fri, 13 Nov 2015 01:03:43 +0000 (12:03 +1100)]
ctdb-tests: Update test to set numeric debug levels

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-logging: Allow numeric specification of debug level
Amitay Isaacs [Wed, 11 Nov 2015 22:15:08 +0000 (09:15 +1100)]
ctdb-logging: Allow numeric specification of debug level

This makes the function compatible with parse_debug().

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-logging: Allow sub-string matching for debug level strings
Amitay Isaacs [Wed, 11 Nov 2015 05:17:51 +0000 (16:17 +1100)]
ctdb-logging: Allow sub-string matching for debug level strings

This allows for backward compatibility with the current code where
DEBUG_ERR corresponds to "ERR".

Fix the test that relies on "ERR" instead of "ERROR".

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-logging: Fix for loop condition
Amitay Isaacs [Wed, 11 Nov 2015 22:14:32 +0000 (09:14 +1100)]
ctdb-logging: Fix for loop condition

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-logging: Add APIs to convert debug_level to and from integer
Amitay Isaacs [Wed, 11 Nov 2015 03:45:08 +0000 (14:45 +1100)]
ctdb-logging: Add APIs to convert debug_level to and from integer

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-logging: Move debug_extra definition to server/ctdb_logging.c
Amitay Isaacs [Wed, 11 Nov 2015 03:31:41 +0000 (14:31 +1100)]
ctdb-logging: Move debug_extra definition to server/ctdb_logging.c

This variable is used for adding a prefix to log entries from various
child processes.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-daemon: Move ctdb_fork.c to server
Amitay Isaacs [Wed, 11 Nov 2015 03:26:53 +0000 (14:26 +1100)]
ctdb-daemon: Move ctdb_fork.c to server

These functions are only used in the ctdb daemon code.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-daemon: Move switch_from_server_to_client() to ctdb_daemon.c
Amitay Isaacs [Wed, 11 Nov 2015 03:18:51 +0000 (14:18 +1100)]
ctdb-daemon: Move switch_from_server_to_client() to ctdb_daemon.c

This function can only called from ctdb daemon.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoWHATSNEW: Add async SMB2 flush and new aio parameter
Christof Schmitt [Fri, 13 Nov 2015 18:47:32 +0000 (11:47 -0700)]
WHATSNEW: Add async SMB2 flush and new aio parameter

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Nov 14 00:39:17 CET 2015 on sn-devel-104

4 years agodocs: Update doc for 'strict sync' parameter for async SMB2 flush
Christof Schmitt [Fri, 13 Nov 2015 18:46:33 +0000 (11:46 -0700)]
docs: Update doc for 'strict sync' parameter for async SMB2 flush

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agos3: smbd: Change aio_pending_size static variable to a new "aio max threads" smb...
Jeremy Allison [Thu, 12 Nov 2015 21:23:30 +0000 (13:23 -0800)]
s3: smbd: Change aio_pending_size static variable to a new "aio max threads" smb.conf parameter.

Removes accessor functions as now this parameter is set
under user control in smb.conf. Default is 100.

Note that this doesn't limit the number of outstanding
aio requests, it just causes them to go onto the
pthreadpool queue.

Now we need to prioritize pthreadpool pipe replies
ahead of incoming SMB2 requests, but that's a patch
for another day.

Based on ideas from Volker.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos3: smbd: Remove checks causing fallback to sync on pread/pwrite/fsync.
Jeremy Allison [Thu, 12 Nov 2015 21:07:21 +0000 (13:07 -0800)]
s3: smbd: Remove checks causing fallback to sync on pread/pwrite/fsync.

Rely on pthreadpool queueing instead of falling back.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos3: smbd: Remove --with-aio-support. We no longer would ever prefer POSIX-RT aio...
Jeremy Allison [Thu, 12 Nov 2015 20:44:50 +0000 (12:44 -0800)]
s3: smbd: Remove --with-aio-support. We no longer would ever prefer POSIX-RT aio, use pthread_aio instead.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agodocs: correct the name of the idmap config group of parameters
Michael Adam [Fri, 13 Nov 2015 15:30:33 +0000 (16:30 +0100)]
docs: correct the name of the idmap config group of parameters

"idmap config DOMAIN : OPTION" is the pattern used.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Nov 13 19:55:33 CET 2015 on sn-devel-104

4 years agoctdb: Fix the O3 developer build
Volker Lendecke [Sat, 7 Nov 2015 19:18:32 +0000 (20:18 +0100)]
ctdb: Fix the O3 developer build

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Nov 13 12:42:22 CET 2015 on sn-devel-104

4 years agoselftest: Use strict sync = yes
Christof Schmitt [Wed, 11 Nov 2015 20:28:09 +0000 (13:28 -0700)]
selftest: Use strict sync = yes

This enables the codepaths calling fsync for FLUSH requests during
selftest.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Fri Nov 13 04:47:00 CET 2015 on sn-devel-104

4 years agosmbd: Issue fsync for SMB2 FLUSH asynchronously
Christof Schmitt [Wed, 11 Nov 2015 20:31:15 +0000 (13:31 -0700)]
smbd: Issue fsync for SMB2 FLUSH asynchronously

SMB2 FLUSH mainly calls fsync and there is already code in place to
handle fsync asynchronously, so use the asynchronous code path for SMB2
FLUSH. This avoids a SMB2 FLUSH stalling other requests processing.

Signed-off-by: Christof Schmitt <cs@samba.org>
Signed-off-by: Jeremy Allison <jra@samba.org>
4 years agos3: smbd: Remove outstanding_aio_calls from globals.
Jeremy Allison [Thu, 12 Nov 2015 17:25:41 +0000 (09:25 -0800)]
s3: smbd: Remove outstanding_aio_calls from globals.

Access via functions only.

Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Christof Schmitt <cs@samab.org>
4 years agos3: smbd: Remove aio_pending_size from globals.
Jeremy Allison [Thu, 12 Nov 2015 17:20:05 +0000 (09:20 -0800)]
s3: smbd: Remove aio_pending_size from globals.

Access via functions only.

Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Christof Schmitt <cs@samba.org>
4 years agos4-auth: Fix some debugging and crash in error cases
Günther Deschner [Thu, 24 Sep 2015 18:45:04 +0000 (20:45 +0200)]
s4-auth: Fix some debugging and crash in error cases

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Nov 13 01:43:36 CET 2015 on sn-devel-104

4 years agosmbd: Remove dead code
Volker Lendecke [Thu, 12 Nov 2015 20:09:35 +0000 (21:09 +0100)]
smbd: Remove dead code

94f0716fff has removed the dcelogin_atmost_once variable.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoctdb-recoverd: Reload remote IPs as part of takeover run
Martin Schwenke [Wed, 28 Oct 2015 09:04:41 +0000 (20:04 +1100)]
ctdb-recoverd: Reload remote IPs as part of takeover run

This is currently done before each IP takeover run, so just factor it
in.

ctdb_reload_remote_public_ips() becomes static.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu Nov 12 09:28:45 CET 2015 on sn-devel-104

4 years agoctdb-recoverd: Move ctdb_reload_remote_public_ips() to ctdb_takeover.c
Martin Schwenke [Thu, 29 Oct 2015 00:50:24 +0000 (11:50 +1100)]
ctdb-recoverd: Move ctdb_reload_remote_public_ips() to ctdb_takeover.c

This will help to untangle known and available public IP lists from
the CTDB context.

verify_remote_ip_allocation() needs a forward declaration.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Remote IP validation can't cause a takeover run
Martin Schwenke [Wed, 28 Oct 2015 09:33:29 +0000 (20:33 +1100)]
ctdb-recoverd: Remote IP validation can't cause a takeover run

Remote IP validation is only called when a takeover run is about to
happen anyway, so don't bother flagging one.  Given that a takeover
run isn't being triggered, also drop the test that checks if takeover
runs are disabled.  These are the only uses of the rec argument, so
drop it.

One possible further simplification would be to remove this function
because it doesn't accomplish anything.  However, it is worth leaving
it as a reminder that remote IP validation should be done properly at
some time in the future.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Drop culprit argument from ctdb_reload_remote_public_ips()
Martin Schwenke [Wed, 28 Oct 2015 23:42:29 +0000 (10:42 +1100)]
ctdb-recoverd: Drop culprit argument from ctdb_reload_remote_public_ips()

It is only used by the caller to print a message that includes the
culprit.  However, ctdb_reload_remote_public_ips() already prints
perfectly good messages and they include the culprit.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Trigger takeover run after rebalance timeout
Martin Schwenke [Wed, 28 Oct 2015 08:56:02 +0000 (19:56 +1100)]
ctdb-recoverd: Trigger takeover run after rebalance timeout

No need to do it immediately.  It will happen in less than a second.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Remove unnecessary assignments of need_takeover_run
Martin Schwenke [Wed, 28 Oct 2015 08:52:37 +0000 (19:52 +1100)]
ctdb-recoverd: Remove unnecessary assignments of need_takeover_run

do_takeover_run() unsets this if it succeeds.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Do not run recovery-related events around IP takeover
Martin Schwenke [Wed, 28 Oct 2015 08:47:03 +0000 (19:47 +1100)]
ctdb-recoverd: Do not run recovery-related events around IP takeover

This is not a recovery, so do not run "startrecovery and "recovered"
events.  There are other IP takeover runs where these are not run.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Drop some sanity checking in local IP verification
Martin Schwenke [Mon, 9 Nov 2015 04:32:58 +0000 (15:32 +1100)]
ctdb-recoverd: Drop some sanity checking in local IP verification

The recovery start/end times used in the checks at the top of
verify_local_ip_allocation() are set by the START_RECOVERY and
END_RECOVERY controls.  A couple of takeover runs escape the checks
because they were added later and are not surrounded by these
controls.

Recovery and IP allocation need to be untangled from each other, so
recovery-related events should not be relied on for IP allocation.
This means the solution is not to add these where they are "missing".

The concern that the checks are addressing is to avoid local IP
verification when IP addresses are in a state of flux.  Takeover runs
on non-master nodes are already disabled while a takeover run is in
progress, so local IP verification is already skipped in that case.
The other case is the master node, which will be busy with the
takeover run, rather than running main_loop().

The other issue is races.  verify_local_ip_allocation() takes a
non-zero amount of time to fetch IP addresses from the local CTDB
daemon and during this time a recovery or takeover run can start, but
a takeover run can still be triggered.  The current tests do not stop
this.

Apart from all of this, with most reasonable public IP address
configurations, an extra takeover run will be a no-op so is not a
cause for concern.

It is safe to drop these checks.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-recoverd: Simplify using TALLOC_FREE()
Martin Schwenke [Fri, 23 Oct 2015 05:03:38 +0000 (16:03 +1100)]
ctdb-recoverd: Simplify using TALLOC_FREE()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agogss: samba member server returns incorrect error code with some versions of krb5
Richard Sharpe [Wed, 11 Nov 2015 04:50:18 +0000 (20:50 -0800)]
gss: samba member server returns incorrect error code with some versions of krb5

As per Simo's comments in https://bugzilla.redhat.com/show_bug.cgi?id=1279249
we need Samba to return the correct thing to the client when gss_accept_sec_context
returns a token along with an error.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11592

Signed-off-by: Richard Sharpe <rsharpe@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Nov 12 01:44:08 CET 2015 on sn-devel-104

4 years agoctdb-build: Don't try to install unavailable prebuilt manpages
Martin Schwenke [Mon, 9 Nov 2015 23:14:56 +0000 (10:14 +1100)]
ctdb-build: Don't try to install unavailable prebuilt manpages

Commit 3ddd35142ab86de431d00f93de2fb6a2b371317d tries to
unconditionally install pre-built manpages if xsltproc is unavailable.
However, these only exist in a tarball, not in a git repo.  That can
make the installation fail.

If xsltproc does not exist then check for each pre-built manpage at
configure time.  This should cover all the possible cases.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Nov 11 06:23:48 CET 2015 on sn-devel-104

4 years agoctdb-tests: Try to connect few times before failing in comm_client_test
Amitay Isaacs [Tue, 10 Nov 2015 03:49:30 +0000 (14:49 +1100)]
ctdb-tests: Try to connect few times before failing in comm_client_test

cunit/comm_test_002.sh requires that the comm_server_test is started
before comm_client_test.  Since comm_server_test is started in background,
it's possible for comm_client_test to run before comm_server_test has
bound to the unix domain socket.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agovfs: Remove smb_traffic_analyzer
Volker Lendecke [Mon, 9 Nov 2015 09:14:26 +0000 (10:14 +0100)]
vfs: Remove smb_traffic_analyzer

Holger Hetterich told me in a personal email that he does not have
time to care about this project anymore and that he is fine to
remove it from Samba.

Why the removal? It contains homegrown crypto that would need to
be thoroughly audited and/or fixed. And if it's neither maintained
nor widely used I'd rather have it removed.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Nov 11 00:23:35 CET 2015 on sn-devel-104

4 years agosmbstatus: always initialize a messaing context
Ralph Boehme [Tue, 10 Nov 2015 16:59:09 +0000 (17:59 +0100)]
smbstatus: always initialize a messaing context

Recent changes (b542ce7db394de3023b95288b0c40c4533c02cb1) to serverid
code made serverid_exists() call messaging_dgm_get_unique() which means
we depend on a valid messaging context that initializes
global_dgm_context.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agolib: Fix CID 1338432 Unchecked return value
Volker Lendecke [Tue, 10 Nov 2015 08:56:56 +0000 (09:56 +0100)]
lib: Fix CID 1338432 Unchecked return value

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agodns_server: Fix a clang warning
Volker Lendecke [Mon, 9 Nov 2015 09:01:59 +0000 (10:01 +0100)]
dns_server: Fix a clang warning

clang complains that '\0' is converted to a NULL pointer. This seems
to work fine, so make this pointer explicitly NULL. If instead we
need a "" here, we could of course do that too.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Nov 10 10:13:18 CET 2015 on sn-devel-104

4 years agos3-build: Avoid setting CTDB specific include path
Amitay Isaacs [Sat, 7 Nov 2015 12:21:34 +0000 (23:21 +1100)]
s3-build: Avoid setting CTDB specific include path

The include paths for CTDB are set via ctdb/wscript.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Mon Nov  9 14:31:24 CET 2015 on sn-devel-104

4 years agoctdb-scripts: Add support for CTDB_DBDIR in tmpfs
Martin Schwenke [Fri, 23 Oct 2015 03:04:04 +0000 (14:04 +1100)]
ctdb-scripts: Add support for CTDB_DBDIR in tmpfs

The tmpfs is mounted and unmounted by ctdbd_wrapper.  Format is
CTDB_DBDIR=tmpfs:<tmpfs-options>.  The only default for the tmpfs is
mode=700 - to override, specify a different value in <tmpfs-options>.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Mon Nov  9 10:58:32 CET 2015 on sn-devel-104

4 years agoctdb-scripts: Improve CTDB wrapper shutdown code
Martin Schwenke [Fri, 23 Oct 2015 03:04:04 +0000 (14:04 +1100)]
ctdb-scripts: Improve CTDB wrapper shutdown code

This will make it easier to run things after CTDB is stopped.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-tests: Fix "setreclock" test
Martin Schwenke [Fri, 30 Oct 2015 02:06:24 +0000 (13:06 +1100)]
ctdb-tests: Fix "setreclock" test

1. Waiting for generation to change isn't enough.  It now changes
   early in recovery and reclock might not have been set on all nodes.
   So wait until recovery is complete before checking reclock.

2. Use onnode -p when setting reclock on all nodes.  That will cause
   it to be set quickly on all nodes, to avoid the situation where the
   recovery master is the late in the list and resets the reclock on
   earlier nodes back to the old value.  This shouldn't matter if (1)
   is done but it can't hurt.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb-tests: Fix the name of the "setreclock" test
Martin Schwenke [Mon, 9 Nov 2015 00:35:03 +0000 (11:35 +1100)]
ctdb-tests: Fix the name of the "setreclock" test

It currently claims to test "setrecmaster".

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agovfs_acl_*: Only sha256 needed
Volker Lendecke [Sun, 8 Nov 2015 10:34:40 +0000 (11:34 +0100)]
vfs_acl_*: Only sha256 needed

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agovfs_cap: Fix a warning
Volker Lendecke [Sun, 8 Nov 2015 09:43:59 +0000 (10:43 +0100)]
vfs_cap: Fix a warning

clang warns about increased alignment cast. talloc_size does align properly.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agolib: messages.h references struct iovec
Volker Lendecke [Mon, 2 Nov 2015 11:46:35 +0000 (12:46 +0100)]
lib: messages.h references struct iovec

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agolib: Move some procid functions out of util.c
Volker Lendecke [Fri, 6 Nov 2015 15:59:44 +0000 (16:59 +0100)]
lib: Move some procid functions out of util.c

Including proto.h just for pid_to_procid() is a pain...

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agolib: Increase a debuglevel
Volker Lendecke [Fri, 6 Nov 2015 14:39:45 +0000 (15:39 +0100)]
lib: Increase a debuglevel

We do this every time when a process exits. If that process has
properly cleaned up after itself, we spit out this message.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agovfs_fruit: Fix a typo
Volker Lendecke [Sun, 8 Nov 2015 09:16:04 +0000 (10:16 +0100)]
vfs_fruit: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoFix various spelling errors
Mathieu Parent [Sun, 26 Jul 2015 21:02:57 +0000 (23:02 +0200)]
Fix various spelling errors

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Nov  6 13:43:45 CET 2015 on sn-devel-104

4 years agobuild:wafsamba: Remove the print_commands code from the build scripts
Thomas Nagy [Thu, 5 Nov 2015 18:00:18 +0000 (19:00 +0100)]
build:wafsamba: Remove the print_commands code from the build scripts

Using the print_commands tool makes it easier to upgrade to Waf 1.8.

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Uri Simchoni uri@samba.org
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agobuild:wafsamba: Include the print_commands.py tool from upstream
Thomas Nagy [Thu, 5 Nov 2015 17:57:14 +0000 (18:57 +0100)]
build:wafsamba: Include the print_commands.py tool from upstream

The tool 'print_commands' is provided by default in Waf 1.8. Keeping
the old code in Samba complicates the Waf upgrade.

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Uri Simchoni uri@samba.org
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agobuild:wafsamba: Remove samba_utils.runonce
Thomas Nagy [Thu, 5 Nov 2015 01:06:42 +0000 (02:06 +0100)]
build:wafsamba: Remove samba_utils.runonce

The decorator order matters in the following:
"""
@runonce
@conf
function()
"""

First, the @conf decorator binds the function to the configuration context
and then returns the same function. The @runonce decorator then takes
the output function and replaces it by another that performs caching. This new
function remains in the current script and is never bound to the configuration
context, so caching never occurs.

The declaration would have been correct if written like this:
"""
@conf
@runonce
function()
"""

Yet the decorator @run_once does not keep the function name (__name__), so the
annotation with @conf would fail. The straightforward approach is to remove
all the incorrect @runonce occurrences.

Besides that, the function Utils.run_once is already present in the Waf library,
and is sufficient for the current needs of the Samba code (it caches only the
first argument). Therefore samba_utils.runonce can be safely replaced by
Utils.run_once, which is also present in Waf 1.8.

Note: at runtime, only SETUP_BUILD_GROUPS seems to actually use caching.

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Uri Simchoni uri@samba.org
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agobuild:wafsamba: Remove the unnecessary intltool module dependency
Thomas Nagy [Wed, 4 Nov 2015 23:41:38 +0000 (00:41 +0100)]
build:wafsamba: Remove the unnecessary intltool module dependency

The 'intltool' module is completely unnecessary for the build process,
and it does not exist in waf 1.8

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Uri Simchoni uri@samba.org
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agobuild:wafsamba: Moved samba_before_apply_obj_vars to samba_utils
Thomas Nagy [Wed, 4 Nov 2015 23:39:25 +0000 (00:39 +0100)]
build:wafsamba: Moved samba_before_apply_obj_vars to samba_utils

The function samba_before_apply_obj_vars serves to remove system paths,
it is certainly not an optimisation and has no place in that module.
By optimisation, we mean that the build process could run without it.

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Uri Simchoni uri@samba.org
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agobuild:wafsamba: Removed unnecessary and misleading variables
Thomas Nagy [Wed, 4 Nov 2015 23:34:03 +0000 (00:34 +0100)]
build:wafsamba: Removed unnecessary and misleading variables

There is no 'allow_duplicates' attribute anywhere.
The function 'check_duplicate_sources' always returns True unless it raises an exception
There is no list of source files to use
The variable 'tstart' is unused

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Uri Simchoni uri@samba.org
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoFix up some aesthetics ... ie, align things as they were intended.
Richard Sharpe [Thu, 5 Nov 2015 23:30:18 +0000 (15:30 -0800)]
Fix up some aesthetics ... ie, align things as they were intended.

Signed-off-by: Richard Sharpe <rsharpe@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Nov  6 10:36:37 CET 2015 on sn-devel-104

4 years agospec files: remove pam_smbpass
Alexander Bokovoy [Wed, 4 Nov 2015 15:58:42 +0000 (17:58 +0200)]
spec files: remove pam_smbpass

Remove remaining pam_smbpass options from RHEL spec file templates.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agosource3/wscript: remove pam_smbpass option as it was removed
Alexander Bokovoy [Wed, 4 Nov 2015 15:50:15 +0000 (17:50 +0200)]
source3/wscript: remove pam_smbpass option as it was removed

pam_smbpass module was removed in 3c00e8d76a2ef6194a8ce522c15853e5b8e9262b
but corresponding configure option wasn't removed.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agodoc: fix a typo in the smb.conf manpage, explanation of idmap config
Michael Adam [Thu, 5 Nov 2015 15:43:34 +0000 (16:43 +0100)]
doc: fix a typo in the smb.conf manpage, explanation of idmap config

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Fri Nov  6 06:26:34 CET 2015 on sn-devel-104

4 years agovfs_gpfs: Re-enable share modes
Volker Lendecke [Thu, 5 Nov 2015 12:22:33 +0000 (13:22 +0100)]
vfs_gpfs: Re-enable share modes

is_ntfs_default_stream_smb_fname returns false for a NULL stream name, so for
streamless filenames we do not set gpfs share modes without this patch.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=11243
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Nov  6 03:21:01 CET 2015 on sn-devel-104

4 years agovfs_gpfs: Fix the build with -Werror=declaration-after-statement
Volker Lendecke [Thu, 5 Nov 2015 12:35:23 +0000 (13:35 +0100)]
vfs_gpfs: Fix the build with -Werror=declaration-after-statement

Bug: https://bugzilla.samba.org/show_bug.cgi?id=11243
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agoremove many valgrind errors for base.lock test
Noel Power [Thu, 29 Oct 2015 11:11:00 +0000 (11:11 +0000)]
remove many valgrind errors for base.lock test

mostly "Conditional jump or move depends on uninitialised value" &
"Use of uninitialised value of size 8" errors, suspect this is
related to compiler padding for the struct

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Nov  6 00:16:53 CET 2015 on sn-devel-104

4 years agofix uninitialised read in process_host_announce
Noel Power [Wed, 28 Oct 2015 21:17:42 +0000 (21:17 +0000)]
fix uninitialised read in process_host_announce

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agofix writev(vector[...]) points to uninitialised bytes in call_trans2findnext
Noel Power [Wed, 28 Oct 2015 19:53:49 +0000 (19:53 +0000)]
fix writev(vector[...]) points to uninitialised bytes in call_trans2findnext

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agofix 'Invalid read of size 1' in reply_search
Noel Power [Wed, 28 Oct 2015 17:08:28 +0000 (17:08 +0000)]
fix 'Invalid read of size 1' in reply_search

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agofix writev(vector[...]) points to uninitialised bytes in call_trans2findfirst
Noel Power [Wed, 28 Oct 2015 15:42:06 +0000 (15:42 +0000)]
fix writev(vector[...]) points to uninitialised bytes in call_trans2findfirst

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>