sfrench/samba-autobuild/.git
10 years agowinbind: Print error code on connection error in ping_dc
Christof Schmitt [Fri, 24 May 2013 19:40:49 +0000 (12:40 -0700)]
winbind: Print error code on connection error in ping_dc

For debugging, it is useful to include the error code in the message.

Signed-off-by: Christof Schmitt <christof.schmitt@us.ibm.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Sat May 25 23:11:23 CEST 2013 on sn-devel-104

10 years agopidl: Recent Perl warns about "defined(@var)" constructs.
Vadim Zhukov [Sat, 25 May 2013 14:19:24 +0000 (15:19 +0100)]
pidl: Recent Perl warns about "defined(@var)" constructs.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date(master): Sat May 25 18:10:53 CEST 2013 on sn-devel-104

10 years agobuilding RPMs on RHEL fail because of a typo.
Anand Avati [Fri, 24 May 2013 19:23:06 +0000 (12:23 -0700)]
building RPMs on RHEL fail because of a typo.

Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat May 25 01:04:37 CEST 2013 on sn-devel-104

10 years agolibnet-vampire: make use of dsdb_repl_resolve_working_schema()
Stefan Metzmacher [Fri, 17 May 2013 21:18:55 +0000 (23:18 +0200)]
libnet-vampire: make use of dsdb_repl_resolve_working_schema()

Pair-Programmed-With: Matthieu Patou <mat@matws.net>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu May 23 14:18:03 CEST 2013 on sn-devel-104

10 years agodsdb-repl: merge the logic from libnet_vampire_cb_apply_schema()
Stefan Metzmacher [Fri, 17 May 2013 21:18:41 +0000 (23:18 +0200)]
dsdb-repl: merge the logic from libnet_vampire_cb_apply_schema()

This way libnet_vampire_cb_apply_schema() is able to use
dsdb_repl_resolve_working_schema().

Pair-Programmed-With: Matthieu Patou <mat@matws.net>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agodsdb-repl: split out dsdb_repl_resolve_working_schema
Stefan Metzmacher [Fri, 17 May 2013 21:02:03 +0000 (23:02 +0200)]
dsdb-repl: split out dsdb_repl_resolve_working_schema

This can be reused later in other places.

Pair-Programmed-With: Matthieu Patou <mat@matws.net>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agoselftest: Improve test coverage of DRS (bug #8680)
Matthieu Patou [Fri, 19 Apr 2013 05:03:23 +0000 (22:03 -0700)]
selftest: Improve test coverage of DRS (bug #8680)

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agodsdb-drs: when replicating schema object checks ask for removal of previous version...
Matthieu Patou [Sun, 27 Jan 2013 23:43:07 +0000 (15:43 -0800)]
dsdb-drs: when replicating schema object checks ask for removal of previous version if exists (bug #8680)

Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agolibnet-vampire: add attributes and classes from the replicated schema to the bootstra...
Matthieu Patou [Mon, 8 Oct 2012 04:46:38 +0000 (21:46 -0700)]
libnet-vampire: add attributes and classes from the replicated schema to the bootstrap schema (bug #8680)

Replicated schema might have attributes and auxilary classes  on some
critical classes (ie.  top, user, computer ) that are not in the bootstrap
schema. Without those new attributes and classes, bootstrap schema is
unable to translate those critical classes in the schema constructed
from the replicated data. Without thoses classes new schema is useless
and can't be indexed properly.

In order to overcome this problem, we put all new attributes and classes
definitions into the bootstrap schema so that foundations classes can be
translated.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Matthieu Patou <mat@matws.net>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agodsdb-schema: make deduplication of class and schema possible (bug #8680)
Matthieu Patou [Sun, 27 Jan 2013 07:42:10 +0000 (23:42 -0800)]
dsdb-schema: make deduplication of class and schema possible (bug #8680)

When a class or an attribute is replicated it might already exists in
the existing schema, so while replicating the new version of this object
we want to get rid of the old version of the object is the current
validating schema so that we don't end up having duplicates.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Matthieu Patou <mat@matws.net>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agodsdb-schema: schema_fill_possible_inferiors() should rebuild everthing
Stefan Metzmacher [Thu, 23 May 2013 06:46:31 +0000 (08:46 +0200)]
dsdb-schema: schema_fill_possible_inferiors() should rebuild everthing

commit cd7f3fd07215a7b8372b6b623faed02ae1310cb1 reverted the change
of commit c2853f55fc603d4875bb1e50a1cbf409df0421ea.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agoRevert my accidental commit.
Richard Sharpe [Thu, 23 May 2013 03:05:17 +0000 (20:05 -0700)]
Revert my accidental commit.

Signed-off-by: Richard Sharpe <rsharpe@samba.org>
Autobuild-User(master): Richard Sharpe <sharpe@samba.org>
Autobuild-Date(master): Thu May 23 06:53:17 CEST 2013 on sn-devel-104

10 years agolib/replace: Set BROKEN_STRNLEN and BROKEN_STRNDUP on all AIX
Andrew Bartlett [Wed, 22 May 2013 07:23:30 +0000 (17:23 +1000)]
lib/replace: Set BROKEN_STRNLEN and BROKEN_STRNDUP on all AIX

The background is in https://bugzilla.samba.org/show_bug.cgi?id=1097
and wider reports are at
http://stackoverflow.com/questions/2091460/strndup-call-is-currupting-stack-frames

Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May 23 03:52:10 CEST 2013 on sn-devel-104

10 years agodocs: Fix small errors in TOSHARG-Compiling
Andrew Bartlett [Tue, 21 May 2013 10:44:26 +0000 (20:44 +1000)]
docs: Fix small errors in TOSHARG-Compiling

Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agodocs: Remove TOSHARG-HighAvailability which is made obsolete by CTDB
Andrew Bartlett [Tue, 21 May 2013 10:50:30 +0000 (20:50 +1000)]
docs: Remove TOSHARG-HighAvailability which is made obsolete by CTDB

This is mostly a lament on why this is hard, and while CTDB is still
hard, this document tries to imply it is almost impossible, and makes
no mention of the solution.

Andrew Bartlett
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agodocs: Remove out of date and unmaintained Speed page from the HOWTO
Andrew Bartlett [Tue, 21 May 2013 07:49:55 +0000 (17:49 +1000)]
docs: Remove out of date and unmaintained Speed page from the HOWTO

Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoWhen message-type is drvupgrade, MSG_DEBUG should be replaced with MSG_PRINTER_DRVUPG...
Peng Haitao [Wed, 22 May 2013 21:03:13 +0000 (14:03 -0700)]
When message-type is drvupgrade, MSG_DEBUG should be replaced with MSG_PRINTER_DRVUPGRADE.

Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoWhen '--policies-reset' is success, the exit code should be 0.
Peng Haitao [Wed, 22 May 2013 21:02:29 +0000 (14:02 -0700)]
When '--policies-reset' is success, the exit code should be 0.

Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agobuild: Update md5.h detection in waf and autoconf to use sys/md5.h and -lmd
Andrew Bartlett [Tue, 21 May 2013 14:14:19 +0000 (00:14 +1000)]
build: Update md5.h detection in waf and autoconf to use sys/md5.h and -lmd

This brings the two build systems in sync, without using md5.h (which is a problem name)

Tested on FreeBSD

Andrew Bartlett

Reviewed-by: Richard Sharpe <rsharpe@samba.org>
Autobuild-User(master): Richard Sharpe <sharpe@samba.org>
Autobuild-Date(master): Wed May 22 10:06:40 CEST 2013 on sn-devel-104

10 years agoMake sure that if an smbd is exiting because of an error we let the user know.
Richard Sharpe [Sat, 11 May 2013 16:47:23 +0000 (09:47 -0700)]
Make sure that if an smbd is exiting because of an error we let the user know.

Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
10 years agos4-torture: No need to disable rpc.spoolss.win test when compiled with MIT kerberos.
Günther Deschner [Fri, 17 May 2013 09:23:22 +0000 (11:23 +0200)]
s4-torture: No need to disable rpc.spoolss.win test when compiled with MIT kerberos.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon May 20 20:35:33 CEST 2013 on sn-devel-104

10 years agoselftest: mark the spoolss add print processor tests as knownfail for now.
Günther Deschner [Fri, 1 Feb 2013 13:53:12 +0000 (14:53 +0100)]
selftest: mark the spoolss add print processor tests as knownfail for now.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agos4-torture: add simple tests for spoolss_{Add|Delete}PrintProcessor.
Günther Deschner [Fri, 1 Feb 2013 13:07:50 +0000 (14:07 +0100)]
s4-torture: add simple tests for spoolss_{Add|Delete}PrintProcessor.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agodoserr: add mapping for WERR_PRINT_PROCESSOR_ALREADY_INSTALLED.
Günther Deschner [Fri, 1 Feb 2013 13:07:07 +0000 (14:07 +0100)]
doserr: add mapping for WERR_PRINT_PROCESSOR_ALREADY_INSTALLED.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agospoolss: fill in IDL for spoolss_DeletePrintProcessor.
Günther Deschner [Fri, 1 Feb 2013 01:34:11 +0000 (02:34 +0100)]
spoolss: fill in IDL for spoolss_DeletePrintProcessor.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agos4-torture: also deal with "Microsoft XPS Document Writer v4" as default driver.
Günther Deschner [Thu, 31 Jan 2013 21:06:20 +0000 (22:06 +0100)]
s4-torture: also deal with "Microsoft XPS Document Writer v4" as default driver.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agos4-torture: add ndr test for spoolss_RpcSetJobNamedProperty.
Günther Deschner [Thu, 31 Jan 2013 13:56:17 +0000 (14:56 +0100)]
s4-torture: add ndr test for spoolss_RpcSetJobNamedProperty.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agos4-torture: add ndr test for spoolss_GetCorePrinterDrivers.
Günther Deschner [Tue, 22 Jan 2013 09:17:27 +0000 (10:17 +0100)]
s4-torture: add ndr test for spoolss_GetCorePrinterDrivers.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agos4-torture: add simple test for spoolss_RpcSendRecvBidiData.
Günther Deschner [Thu, 31 Jan 2013 19:44:54 +0000 (20:44 +0100)]
s4-torture: add simple test for spoolss_RpcSendRecvBidiData.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agos4-torture: add test for spoolss_RpcEnumJobNamedProperties.
Günther Deschner [Mon, 21 Jan 2013 21:09:22 +0000 (22:09 +0100)]
s4-torture: add test for spoolss_RpcEnumJobNamedProperties.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agospoolss: add spoolss_MonitorContainer IDL.
Günther Deschner [Sun, 24 Feb 2013 13:06:59 +0000 (14:06 +0100)]
spoolss: add spoolss_MonitorContainer IDL.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agospoolss: make RPC_PrintNamedProperty public
Günther Deschner [Thu, 24 Jan 2013 22:31:19 +0000 (23:31 +0100)]
spoolss: make RPC_PrintNamedProperty public

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agospoolss: fill in IDL for JobNamedProperty calls.
Günther Deschner [Mon, 21 Jan 2013 20:37:12 +0000 (21:37 +0100)]
spoolss: fill in IDL for JobNamedProperty calls.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agospoolss: make more container objects public for iremotewinspool.
Günther Deschner [Fri, 18 Jan 2013 23:20:42 +0000 (00:20 +0100)]
spoolss: make more container objects public for iremotewinspool.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agospoolss: add idl for spoolss_RpcSendRecvBidiData.
Günther Deschner [Fri, 18 Jan 2013 23:47:42 +0000 (00:47 +0100)]
spoolss: add idl for spoolss_RpcSendRecvBidiData.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agos4-torture: add missing NTSTATUS checks in test_AddJob().
Günther Deschner [Tue, 5 Feb 2013 15:10:34 +0000 (16:10 +0100)]
s4-torture: add missing NTSTATUS checks in test_AddJob().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agospoolss: add [ms_union] to spoolss.idl where appropriate.
Günther Deschner [Wed, 30 Jan 2013 19:05:51 +0000 (20:05 +0100)]
spoolss: add [ms_union] to spoolss.idl where appropriate.

Normally we would activate [ms_union] for the entire interface but given the
fact we use this IDL file also for custom-marshalled structures we would
generate union arm alignment also for the custom-marshalled unions where they
are inappropriate. Thus, only enable [ms_union] only for unions that are part of
the MS-RPRN IDL.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agospoolss: fix string types in spoolss_JTEXP.
Günther Deschner [Wed, 30 Jan 2013 14:55:18 +0000 (15:55 +0100)]
spoolss: fix string types in spoolss_JTEXP.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agospoolss: Fix two size elements in the devmode private spoolss_JTEXP struct.
Günther Deschner [Tue, 29 Jan 2013 20:57:58 +0000 (21:57 +0100)]
spoolss: Fix two size elements in the devmode private spoolss_JTEXP struct.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
10 years agotalloc: Fix a typo
Volker Lendecke [Mon, 20 May 2013 12:26:08 +0000 (14:26 +0200)]
talloc: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Kai Blin <kai@samba.org>
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Mon May 20 18:48:49 CEST 2013 on sn-devel-104

10 years agoldb_tdb: Warn when reindexing is done
Matthieu Patou [Wed, 2 Jan 2013 04:57:25 +0000 (20:57 -0800)]
ldb_tdb: Warn when reindexing is done

Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon May 20 15:47:33 CEST 2013 on sn-devel-104

10 years agosmbtorture: Show the list of cracknames we expect to have and the result
Matthieu Patou [Fri, 17 May 2013 15:14:29 +0000 (17:14 +0200)]
smbtorture: Show the list of cracknames we expect to have and the result

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agosmbtorture: fix a warning due to a set but unused var
Matthieu Patou [Fri, 17 May 2013 14:21:57 +0000 (07:21 -0700)]
smbtorture: fix a warning due to a set but unused var

Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agosmbtorture: fix crash when the returning a crackname with an empty name
Matthieu Patou [Fri, 17 May 2013 14:19:22 +0000 (07:19 -0700)]
smbtorture: fix crash when the returning a crackname with an empty name
when a valid one was expected

Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agoFix warning by setting the variable from GUID to const GUID
Matthieu Patou [Fri, 17 May 2013 12:26:46 +0000 (05:26 -0700)]
Fix warning by setting the variable from GUID to const GUID

Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agoFix more unused vars
Matthieu Patou [Fri, 17 May 2013 12:24:08 +0000 (05:24 -0700)]
Fix more unused vars

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agoFix a warning about a set but unused variable by actually using it
Matthieu Patou [Fri, 17 May 2013 12:22:33 +0000 (05:22 -0700)]
Fix a warning about a set but unused variable by actually using it

Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agoFix warnings about set but unused variables
Matthieu Patou [Fri, 17 May 2013 12:22:15 +0000 (05:22 -0700)]
Fix warnings about set but unused variables

Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agoFix a warning about a shadowed variable by renaming the shadowing var
Matthieu Patou [Fri, 17 May 2013 12:17:41 +0000 (05:17 -0700)]
Fix a warning about a shadowed variable by renaming the shadowing var

Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agobuildtools: Fix compilation warnings
Matthieu Patou [Fri, 17 May 2013 11:50:20 +0000 (04:50 -0700)]
buildtools: Fix compilation warnings

STATIC_%s_MODULES_PROTO is defined on the compilation command line by
-DSTATIC_<something>_MODULES_PROTO which the compiler seems to turn into
define STATIC_<something>_MODULES_PROTO 1 thus yielding a warning due to
unused var

Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agooperational: remove double loops
Matthieu Patou [Tue, 22 Jan 2013 08:09:11 +0000 (00:09 -0800)]
operational: remove double loops

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agodsdb-schema: remove looping on all schema classes for system_possible_inferrior
Matthieu Patou [Tue, 22 Jan 2013 06:27:10 +0000 (22:27 -0800)]
dsdb-schema: remove looping on all schema classes for system_possible_inferrior

The logic to populate possible inferriors and system possible inferriors
is the same so instead of looping twice we do both attributes (depending
on the type of the class) in the same loop

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agoswat: Remove swat.
Kai Blin [Fri, 17 May 2013 12:16:26 +0000 (14:16 +0200)]
swat: Remove swat.

Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Sat May 18 16:32:38 CEST 2013 on sn-devel-104

10 years agodns: Also print packet information for DBGC_DNS
Kai Blin [Fri, 18 Jan 2013 17:36:45 +0000 (18:36 +0100)]
dns: Also print packet information for DBGC_DNS

Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Sat May 18 12:48:15 CEST 2013 on sn-devel-104

10 years agolibrpc: Add NDR_PRINT_DEBUGC to ndr print to a debug class
Kai Blin [Fri, 18 Jan 2013 17:35:15 +0000 (18:35 +0100)]
librpc: Add NDR_PRINT_DEBUGC to ndr print to a debug class

Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agodebug: Add ability to dump_data per debug class
Kai Blin [Fri, 18 Jan 2013 08:44:02 +0000 (09:44 +0100)]
debug: Add ability to dump_data per debug class

Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agosmbd: Fix a ISO C90 forbids mixed declarations and code warning
Volker Lendecke [Fri, 17 May 2013 13:14:58 +0000 (15:14 +0200)]
smbd: Fix a ISO C90 forbids mixed declarations and code warning

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Matthieu Patou <mat@matws.net>
Autobuild-User(master): Matthieu Patou <mat@samba.org>
Autobuild-Date(master): Sat May 18 01:40:04 CEST 2013 on sn-devel-104

10 years agoMore generic check for OpenBSD platform
Vadim Zhukov [Fri, 17 May 2013 08:43:08 +0000 (12:43 +0400)]
More generic check for OpenBSD platform

OpenBSD versioning is different from many other
projects, and, say, 5.0 does not differ from 4.9 more than from 5.1. So the
right approach will be to check that platform name starts with "openbsd"
instead. This is also the thing OpenBSD developers do when patching other
software, so this patch is consistent with already existing practicies.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9888

Reviewed-by: Lars Müller <lars@samba.org>
Reviewed-by: Björn Jacke <bj@sernet.de>
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Fri May 17 17:58:16 CEST 2013 on sn-devel-104

10 years agodocs: mention AD prerequirements for using idmap_ad
Björn Jacke [Wed, 15 May 2013 13:52:25 +0000 (15:52 +0200)]
docs: mention AD prerequirements for using idmap_ad

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agodoc: some fixes for vfs_full_audit man page
Björn Jacke [Wed, 15 May 2013 11:34:33 +0000 (13:34 +0200)]
doc: some fixes for vfs_full_audit man page

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:dsdb python tests - set the executable flag
Matthias Dieter Wallnöfer [Fri, 17 May 2013 08:31:28 +0000 (10:31 +0200)]
s4:dsdb python tests - set the executable flag

Reviewed-by: Matthieu Patou <mat@samba.org>
Autobuild-User(master): Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date(master): Fri May 17 15:11:29 CEST 2013 on sn-devel-104

10 years agos3:lib/ctdb_conn make sure we are root before connecting to CTDB
Christian Ambach [Thu, 16 May 2013 13:07:44 +0000 (15:07 +0200)]
s3:lib/ctdb_conn make sure we are root before connecting to CTDB

CTDB socket is only reachable for root, make sure we are root when trying to connect to it

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Christian Ambach <ambi@samba.org>
Autobuild-Date(master): Fri May 17 13:16:37 CEST 2013 on sn-devel-104

10 years agolib: Add before/after hooks to async_connect
Volker Lendecke [Thu, 16 May 2013 14:11:54 +0000 (16:11 +0200)]
lib: Add before/after hooks to async_connect

This will facilitiate [un]become_root for smbd to connect safely to ctdbd.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
10 years agowaf: build vfs_aixacl2 module by default on AIX
Christian Ambach [Tue, 7 May 2013 07:08:07 +0000 (09:08 +0200)]
waf: build vfs_aixacl2 module by default on AIX

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agowaf: only use -fstack-protector when both compiler and linker support it
Christian Ambach [Tue, 7 May 2013 07:06:50 +0000 (09:06 +0200)]
waf: only use -fstack-protector when both compiler and linker support it

otherwise build with xlc on AIX fails because the compiler silently ignores the parameter
but the linker does not like it

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agodocs/rpcdaemon: some formating fixes
Björn Jacke [Thu, 16 May 2013 14:19:22 +0000 (16:19 +0200)]
docs/rpcdaemon: some formating fixes

Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri May 17 10:34:18 CEST 2013 on sn-devel-104

10 years agodrsuapi: Debug more clearly why NC is bad in updateRefs
Matthieu Patou [Sat, 12 Jan 2013 04:05:39 +0000 (20:05 -0800)]
drsuapi: Debug more clearly why NC is bad in updateRefs

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri May 17 04:17:14 CEST 2013 on sn-devel-104

10 years agonsswitch: fix some typos
Christian Ambach [Thu, 16 May 2013 13:06:49 +0000 (15:06 +0200)]
nsswitch: fix some typos

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri May 17 01:09:33 CEST 2013 on sn-devel-104

10 years agos3:lib/dbwrap add missing curly braces
Christian Ambach [Tue, 14 May 2013 19:02:15 +0000 (21:02 +0200)]
s3:lib/dbwrap add missing curly braces

violation of README.Coding

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agos3:include remove non-blank line endings
Christian Ambach [Tue, 23 Apr 2013 09:20:42 +0000 (11:20 +0200)]
s3:include remove non-blank line endings

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agoauth: Ensure auth_sam is not used on the AD DC
Andrew Bartlett [Thu, 16 May 2013 00:32:50 +0000 (10:32 +1000)]
auth: Ensure auth_sam is not used on the AD DC

Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu May 16 22:51:26 CEST 2013 on sn-devel-104

10 years agodsdb: Expand on what the error finding the ntSecurityDescriptor was in acl_read
Andrew Bartlett [Mon, 13 May 2013 02:06:14 +0000 (14:06 +1200)]
dsdb: Expand on what the error finding the ntSecurityDescriptor was in acl_read

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agoautobuild.py add ntdb to the samba-libs task, to ensure it works as an external library
Andrew Bartlett [Mon, 13 May 2013 02:05:28 +0000 (14:05 +1200)]
autobuild.py add ntdb to the samba-libs task, to ensure it works as an external library

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agorpc_server-drsuapi: Include the failing DN when unable to convert DB objects to DRS
Andrew Bartlett [Tue, 2 Apr 2013 05:10:03 +0000 (16:10 +1100)]
rpc_server-drsuapi: Include the failing DN when unable to convert DB objects to DRS

This is a very serious situation (it should not happen) so getting information on the
objects that this happens for would be very helpful.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agodsdb-schema: Print clear debug message when we find a OID in our local DB we cannot...
Andrew Bartlett [Tue, 2 Apr 2013 04:36:47 +0000 (15:36 +1100)]
dsdb-schema: Print clear debug message when we find a OID in our local DB we cannot convert

We need to work out why we are unable to make a mapping for an OID in our database, because
we should not have been able to add it without such a mapping.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agodsdb-repl: Allow the name attribute (and name-based schema lookups) to be skipped...
Andrew Bartlett [Tue, 26 Mar 2013 00:51:38 +0000 (11:51 +1100)]
dsdb-repl: Allow the name attribute (and name-based schema lookups) to be skipped in dsdb_repl_make_working_schema()

This allows us to use a schema that may only be valid for attributeID based lookups, during the schema load.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agopython-samba-tool domain classicupgrade: Use transactions when adding users/groups...
Andrew Bartlett [Sun, 14 Apr 2013 04:36:08 +0000 (14:36 +1000)]
python-samba-tool domain classicupgrade: Use transactions when adding users/groups/members

This should make things a bit faster when importing very large numbers of users
as we will not constantly rewrite the indicies on disk.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agosamba-tool dbcheck: Use dsdb.DS_GUID_DELETED_OBJECTS_CONTAINER rather than the litera...
Andrew Bartlett [Sun, 14 Apr 2013 03:32:05 +0000 (13:32 +1000)]
samba-tool dbcheck: Use dsdb.DS_GUID_DELETED_OBJECTS_CONTAINER rather than the literal value

This is better practice.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agopython-samba-tool domain classicupgrade: Correct message about re-promoting BDCs
Andrew Bartlett [Thu, 11 Apr 2013 08:13:16 +0000 (18:13 +1000)]
python-samba-tool domain classicupgrade: Correct message about re-promoting BDCs

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agopdb_ldap: Do not skip accounts without a sambaAcctFlags value
Andrew Bartlett [Thu, 11 Apr 2013 07:21:33 +0000 (17:21 +1000)]
pdb_ldap: Do not skip accounts without a sambaAcctFlags value

We allow this to mean a sambaAcctFlags value of zero in other parts of the code
and by allowing these users to show up in a search, we can read and correct them
during the classicupgrade, rather than not know they exist at all.

Most parts of the code do not look for ACB_NORMAL, which is why
these users appear to work.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agopython-samba-tool domain classicupgrade: Actually Skip domain trust accounts
Andrew Bartlett [Wed, 10 Apr 2013 23:33:16 +0000 (09:33 +1000)]
python-samba-tool domain classicupgrade: Actually Skip domain trust accounts

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agopython-samba-tool domain classicupgrade: Skip machine accounts that do not end in $
Andrew Bartlett [Wed, 10 Apr 2013 23:32:13 +0000 (09:32 +1000)]
python-samba-tool domain classicupgrade: Skip machine accounts that do not end in $

These accounts will not work anyway, as all the domain member lookup code in netlogon expects the $.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agobuild: Do not set PATH in install_with_python now we set $PYTHON
Andrew Bartlett [Wed, 8 May 2013 00:59:05 +0000 (12:59 +1200)]
build: Do not set PATH in install_with_python now we set $PYTHON

This will ensure that the scripts get rewritten to use this specific python, as it
will not be found in the path by the waf scripts.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agos3-rpc_server: Ensure we are root when starting and usiing gensec
Andrew Bartlett [Thu, 2 May 2013 04:29:21 +0000 (16:29 +1200)]
s3-rpc_server: Ensure we are root when starting and usiing gensec

This fixes bug 9465.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agogensec: Make the no-hostname status message much less scary
Andrew Bartlett [Mon, 29 Apr 2013 00:00:04 +0000 (10:00 +1000)]
gensec: Make the no-hostname status message much less scary

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agobuild: Blacklist the release-4-0-0 provision as well
Andrew Bartlett [Fri, 26 Apr 2013 06:44:00 +0000 (16:44 +1000)]
build: Blacklist the release-4-0-0 provision as well

This reduces the size of the published tarball while ensuring we test with it
during autobuild.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agodns: Fix allocation of txt_record in txt record tests
Kai Blin [Thu, 16 May 2013 10:13:22 +0000 (12:13 +0200)]
dns: Fix allocation of txt_record in txt record tests

Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-By: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu May 16 15:39:15 CEST 2013 on sn-devel-104

10 years agodns: more debug debug options in the tests
Kai Blin [Sun, 13 Jan 2013 23:56:48 +0000 (00:56 +0100)]
dns: more debug debug options in the tests

Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-By: Amitay Isaacs <amitay@gmail.com>
10 years agodns: Add support for MX queries
Kai Blin [Sun, 9 Dec 2012 19:50:05 +0000 (05:50 +1000)]
dns: Add support for MX queries

Due to an oversight, the internal DNS server supports MX record updates,
but not MX record queries. Add support for MX queries and tests.

This should fix bug #9485

Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-By: Amitay Isaacs <amitay@gmail.com>
10 years agodns: Also add a print-out for the out_packet
Kai Blin [Sun, 13 Jan 2013 23:55:37 +0000 (00:55 +0100)]
dns: Also add a print-out for the out_packet

Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-By: Amitay Isaacs <amitay@gmail.com>
10 years agodns: Use new DNS debugclass in DNS server
Kai Blin [Mon, 14 Jan 2013 00:14:29 +0000 (01:14 +0100)]
dns: Use new DNS debugclass in DNS server

Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-By: Amitay Isaacs <amitay@gmail.com>
10 years agodebug: Add debugclass for DNS server
Kai Blin [Mon, 14 Jan 2013 00:13:47 +0000 (01:13 +0100)]
debug: Add debugclass for DNS server

Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-By: Amitay Isaacs <amitay@gmail.com>
10 years agowinbind4: Fix bug 9832 -- talloc use after free
Volker Lendecke [Tue, 7 May 2013 08:17:26 +0000 (10:17 +0200)]
winbind4: Fix bug 9832 -- talloc use after free

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May 16 13:37:41 CEST 2013 on sn-devel-104

10 years agosource4/winbind/wb_samba3_cmd.c: Fix typo in comment.
Karolin Seeger [Wed, 15 May 2013 16:24:42 +0000 (18:24 +0200)]
source4/winbind/wb_samba3_cmd.c: Fix typo in comment.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May 16 07:49:24 CEST 2013 on sn-devel-104

10 years agosource4/dsdb/schema/schema_convert_to_ol.c: Fix typo in comment.
Karolin Seeger [Wed, 15 May 2013 16:23:49 +0000 (18:23 +0200)]
source4/dsdb/schema/schema_convert_to_ol.c: Fix typo in comment.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agosource4/dsdb/samdb/ldb_modules/local_password.c: Fix typo in comment.
Karolin Seeger [Wed, 15 May 2013 16:22:39 +0000 (18:22 +0200)]
source4/dsdb/samdb/ldb_modules/local_password.c: Fix typo in comment.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agosource4/auth/kerberos/kerberos-notes.txt: Fix typo.
Karolin Seeger [Wed, 15 May 2013 16:21:52 +0000 (18:21 +0200)]
source4/auth/kerberos/kerberos-notes.txt: Fix typo.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agosource4/TODO: Fix typo.
Karolin Seeger [Wed, 15 May 2013 16:20:42 +0000 (18:20 +0200)]
source4/TODO: Fix typo.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agosource3/utils/ntlm_auth.c: Fix typo in debug message.
Karolin Seeger [Wed, 15 May 2013 16:19:36 +0000 (18:19 +0200)]
source3/utils/ntlm_auth.c: Fix typo in debug message.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agosource3/modules/vfs_catia.c: Fix typo in comment.
Karolin Seeger [Wed, 15 May 2013 16:18:07 +0000 (18:18 +0200)]
source3/modules/vfs_catia.c: Fix typo in comment.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>