13 years agor23477: Build farm fix: Use int rather than MIT's krb5_int32 when setting context...
Gerald Carter [Wed, 13 Jun 2007 21:59:39 +0000 (21:59 +0000)]
r23477: Build farm fix: Use int rather than MIT's krb5_int32 when setting context flags.

13 years agor23475: Fix the prototype for sys_broken_setgroups and log *BSD group list
James Peach [Wed, 13 Jun 2007 21:42:31 +0000 (21:42 +0000)]
r23475: Fix the prototype for sys_broken_setgroups and log *BSD group list
truncation a bit more verbosely.

13 years agor23474: Here's a small patch that disables the replay cache
Gerald Carter [Wed, 13 Jun 2007 20:49:20 +0000 (20:49 +0000)]
r23474: Here's a small patch that disables the replay cache
when verifying a ticket from winbindd_pam.c.

I've found during multiple, fast, automated SSH logins (such
as from a cron script) that the replay cache in MIT's krb5
lib will occasionally fail the krb5_rd_req() as a replay attack.

There seems to be a small window during which the MIT krb5
libs could reproduce identical time stamps for ctime and cusec
in the authenticator since Unix systems only give back
milli-seconds rather than the micro-seconds needed by the
authenticator.  Checked against MIT 1.5.1.  Have not
researched how Heimdal does it.

My thinking is that if someone can spoof the KDC and TDS
services we are pretty hopeless anyways.

13 years agor23472: add missing default setting for 'winbind nss info' (merge from 3.0.26)
Gerald Carter [Wed, 13 Jun 2007 20:43:49 +0000 (20:43 +0000)]
r23472: add missing default setting for 'winbind nss info' (merge from  3.0.26)

13 years agor23471: Here's a rough patch for expanding domain group membership
Gerald Carter [Wed, 13 Jun 2007 20:40:54 +0000 (20:40 +0000)]
r23471: Here's a rough patch for expanding domain group membership
in the winbindd_getgrnam() call.  Couple of comments:

* Adds "winbind expand groups" parameter which defines the
  max depth winbindd will expand group members.  The default
  is the current behavior of one level of expansion.
* The entire getrgnam() interface should be async.  I
  haven't done that.
* Refactors the domain users hack in fill_grent_mem() into
  its own function.

13 years agor23470: Fix supplementary group list truncation for *BSD. We need to pass
James Peach [Wed, 13 Jun 2007 20:40:50 +0000 (20:40 +0000)]
r23470: Fix supplementary group list truncation for *BSD. We need to pass
the correct group list length and only truncate to NGROUPS_MAX if
it is too long.

13 years agor23469: Fix a comment
Volker Lendecke [Wed, 13 Jun 2007 19:01:41 +0000 (19:01 +0000)]
r23469: Fix a comment

13 years agor23468: Open registry.tdb with sequence number.
Michael Adam [Wed, 13 Jun 2007 13:15:16 +0000 (13:15 +0000)]
r23468: Open registry.tdb with sequence number.
Add a function to retrieve the registry db sequence number.

This is in preparation of loadparm integration of registry global
smb.conf options: this will allow to detect changes in order to trigger reload.


13 years agor23467: Next little simplification: In rename_internals it's a bit pointless to
Volker Lendecke [Wed, 13 Jun 2007 12:52:36 +0000 (12:52 +0000)]
r23467: Next little simplification: In rename_internals it's a bit pointless to
first ask for existence of a file when we do the open_file_ntcreate in
can_rename later on anyway. That also gets us the right error message in
case the file is not there automatically.

13 years agor23466: Fix RAW-NOTIFY: by using delete on close the notify is triggered deep
Volker Lendecke [Wed, 13 Jun 2007 11:32:46 +0000 (11:32 +0000)]
r23466: Fix RAW-NOTIFY: by using delete on close the notify is triggered deep
inside close_file() already.

13 years agor23465: There was this diff between reg_printing in 3_0 and 3_0_26:
Michael Adam [Wed, 13 Jun 2007 11:04:31 +0000 (11:04 +0000)]
r23465: There was this diff between reg_printing in 3_0 and 3_0_26:
before writing to secdesc_buf->sd,
3_0 checked secdesc_buf->sd while 3_0_26 checked secdesc_buf->sd_size.

This patch makes both revisions check _both_ befor writing.

Jerry / Jeremy : please check if this is correct!


13 years agor23460: Re-add whitespace to reduce diff between branches.
Michael Adam [Wed, 13 Jun 2007 10:12:33 +0000 (10:12 +0000)]
r23460: Re-add whitespace to reduce diff between branches.
Sorry for the noise...


13 years agor23459: Remove one superfluous cast.
Michael Adam [Wed, 13 Jun 2007 10:07:05 +0000 (10:07 +0000)]
r23459: Remove one superfluous cast.

13 years agor23458: Cosmetic fix in debug output.
Michael Adam [Wed, 13 Jun 2007 10:06:17 +0000 (10:06 +0000)]
r23458: Cosmetic fix in debug output.

13 years agor23457: After Jeremy's ack:
Volker Lendecke [Wed, 13 Jun 2007 09:55:13 +0000 (09:55 +0000)]
r23457: After Jeremy's ack:

The attached patch removes a little race condition for
people with real kernel oplock support, and reduces some
code paths. It changes reply_unlink to open_file_ntcreate,
set_delete_on_close and close_file.

The race condition happens if we break the oplock in
can_delete via open_file_ntcreate, we close the file,
someone else gets a batch oplock and we try to unlink.

It reduces code paths by calling SMB_VFS_UNLINK in 2 fewer

13 years agor23450: max_params_return is complete fiction when getting a changenotify
Jeremy Allison [Tue, 12 Jun 2007 19:59:38 +0000 (19:59 +0000)]
r23450: max_params_return is complete fiction when getting a changenotify
request. Ignore it. Should fix bug #4689 but more tests and
valgrinding will follow.

13 years agor23448: Doh ! Don't call winbind_child_died() *before* the
Jeremy Allison [Tue, 12 Jun 2007 19:53:51 +0000 (19:53 +0000)]
r23448: Doh ! Don't call winbind_child_died() *before* the
kill call as that sets pid = 0 ! :-).

13 years agor23447: Add kill signal to child dead path. After talking
Jeremy Allison [Tue, 12 Jun 2007 19:47:33 +0000 (19:47 +0000)]
r23447: Add kill signal to child dead path. After talking
to Jerry add to 3.0.25b.

13 years agor23446: Restore Jeremy's original formatting, just fix the comment.
Volker Lendecke [Tue, 12 Jun 2007 19:19:35 +0000 (19:19 +0000)]
r23446: Restore Jeremy's original formatting, just fix the comment.

13 years agor23445: Fix suggested by Volker. Don't call rename_open_files
Jeremy Allison [Tue, 12 Jun 2007 18:14:16 +0000 (18:14 +0000)]
r23445: Fix suggested by Volker. Don't call rename_open_files
if the name wasn't changed.

13 years agor23434: Coorect a comment.
Michael Adam [Tue, 12 Jun 2007 12:35:24 +0000 (12:35 +0000)]
r23434: Coorect a comment.

13 years agor23433: remove superfluous semicolon.
Michael Adam [Tue, 12 Jun 2007 12:01:52 +0000 (12:01 +0000)]
r23433: remove superfluous semicolon.

13 years agor23432: Remove superfluous comment.
Michael Adam [Tue, 12 Jun 2007 11:54:25 +0000 (11:54 +0000)]
r23432: Remove superfluous comment.
(A relict from regkey_open_internal days.)


13 years agor23429: Ooops, sorry.
Volker Lendecke [Tue, 12 Jun 2007 10:18:26 +0000 (10:18 +0000)]
r23429: Ooops, sorry.

Revert an accidential checkin of r23410.


13 years agor23426: Correct a comment. The default timeout is not 1min, but 30s. While
Volker Lendecke [Tue, 12 Jun 2007 08:02:32 +0000 (08:02 +0000)]
r23426: Correct a comment. The default timeout is not 1min, but 30s. While
there, do some reformatting.

Jeremy, I think we should also kill the child. It might hang in
something (an fcntl lock for example) that the next child might run into
immediately again.

13 years agor23425: Volker noticed this obvious fix for the wins server
Jeremy Allison [Tue, 12 Jun 2007 01:45:40 +0000 (01:45 +0000)]
r23425: Volker noticed this obvious fix for the wins server
code :-). Thanks Volker !

13 years agor23424: Thanks to Jerry, we finally tracked down the :
Jeremy Allison [Mon, 11 Jun 2007 22:28:27 +0000 (22:28 +0000)]
r23424: Thanks to Jerry, we finally tracked down the :
winbindd: Exceeding 200 client connections, no idle connection found"
bug #3204. This fixes it in Jerry's testing !

13 years agor23423: Use the correct structure types in the NT_ACL operations. It's not
James Peach [Mon, 11 Jun 2007 20:56:17 +0000 (20:56 +0000)]
r23423: Use the correct structure types in the NT_ACL operations. It's not
clear to my why the catia module feels it's necessary to implement
these operations, but at least they're now the right type.

13 years agor23411: We were missing displayName and that was preventing us
Simo Sorce [Mon, 11 Jun 2007 00:05:48 +0000 (00:05 +0000)]
r23411: We were missing displayName and that was preventing us
from successfully deleting an entry when "account" is
the STRUCTURAL objectclass used for users and machines.
"account" is used each time the user entry is in /etc/passwd
and we have only the samba attributes in ldap, as well
as for rfc2307(bis) standard based directories.

13 years agor23410: Merge the core of the cluster code.
Volker Lendecke [Sun, 10 Jun 2007 17:02:09 +0000 (17:02 +0000)]
r23410: Merge the core of the cluster code.

I'm 100% certain I've forgotten to merge something, but the main code
should be in. It's mainly in dbwrap_ctdb.c, ctdbd_conn.c and

There should be no changes to the non-cluster case, it does survive make
test on my laptop.

It survives some very basic tests with ctdbd enables, I did not do the
full test suite for clusters yet.



13 years agor23408: Remove a bogus comment
Volker Lendecke [Sun, 10 Jun 2007 10:18:03 +0000 (10:18 +0000)]
r23408: Remove a bogus comment

13 years agor23407: While verifying a bug I found out that for some reason
Simo Sorce [Sat, 9 Jun 2007 22:45:21 +0000 (22:45 +0000)]
r23407: While verifying a bug I found out that for some reason
the code to add a machine was different then the one used
to add a user, the old code led to the machine SID not being
built out correctly allocationg a new RID out of the passdb
but instead by using the old algorithmic method.
This may easily end up in creating duplicated SID when the
RID counter get close to the values built by the algorithmic method.


13 years agor23406: Evn if not strictly currently necessary do check for correct
Simo Sorce [Sat, 9 Jun 2007 19:29:35 +0000 (19:29 +0000)]
r23406: Evn if not strictly currently necessary do check for correct
init also in idmap_nss and idmap_passdb for coherency and to
prevent errors in future if we change the init functions to
actually do something and not just return NT_STATUS_OK

13 years agor23404: Fix wrong (and missing) action on error condition in ldap reply evaluation...
Simo Sorce [Sat, 9 Jun 2007 18:18:24 +0000 (18:18 +0000)]
r23404: Fix wrong (and missing) action on error condition in ldap reply evaluation loop
Fixes one of the segfaults in bug #4667

13 years agor23402: Got bitten by a talloc hierarchy. Make sure we alloc
Jeremy Allison [Sat, 9 Jun 2007 00:27:28 +0000 (00:27 +0000)]
r23402: Got bitten by a talloc hierarchy. Make sure we alloc
off the pipe ctx now ->names is part of the containing

13 years agor23400: Fix lsa crash bug #4683. The "names" enum struct
Jeremy Allison [Sat, 9 Jun 2007 00:13:07 +0000 (00:13 +0000)]
r23400: Fix lsa crash bug #4683. The "names" enum struct
in a lookup_sidX reply isn't optional - like the
lookup_sidX query it needs to be defined in the
All this will go away with PIDL (thank goodness....).
Jerry - I think this is a showstopper to be merged
for 3.0.25b.
I'll be watching the build farm to see if anything broke.

13 years agor23398: Support membership of >16 groups on Darwin by making sure we opt in to the
James Peach [Sat, 9 Jun 2007 00:10:26 +0000 (00:10 +0000)]
r23398: Support membership of >16 groups on Darwin by making sure we opt in to the
dynamic group resolution mechanism when switching UNIX credentials.

13 years agor23396: Make VFS callbacks static. Mark operations as OPAQUE because they
James Peach [Fri, 8 Jun 2007 23:08:41 +0000 (23:08 +0000)]
r23396: Make VFS callbacks static. Mark operations as OPAQUE because they
do not pass through.

13 years agor23393: Support BSD group semantics by making sure that the effective GID is always
James Peach [Fri, 8 Jun 2007 22:25:55 +0000 (22:25 +0000)]
r23393: Support BSD group semantics by making sure that the effective GID is always
passed as the first GID when calling setgroups(2).

13 years agor23391: Second part of the patch for Apple.
Jeremy Allison [Fri, 8 Jun 2007 19:58:32 +0000 (19:58 +0000)]
r23391: Second part of the patch for Apple.

Change the sequence :

sys_setgroups(ngroups, groups);
become_id(uid, gid);

to a function call :

set_unix_security_ctx(uid_t uid, gid_t gid, int ngroups, gid_t *groups)

James - should be safe for you to create a Darwin-specific
version of this function now.


13 years agor23390: First part of the patch to make Apple's life easier.
Jeremy Allison [Fri, 8 Jun 2007 19:52:18 +0000 (19:52 +0000)]
r23390: First part of the patch to make Apple's life easier.
Doing this in two stages to make it very easy to
review. Context switching must look like :

sys_setgroups(ngroups, groups);
become_id(uid, gid);

Re-arrange order so these three calls are always
seen together.

Next will be to turn these into a function.


13 years agor23389: Disabling ACL support on Darwin/Mac OS X for now.
Michael Adam [Fri, 8 Jun 2007 14:37:29 +0000 (14:37 +0000)]
r23389: Disabling ACL support on Darwin/Mac OS X for now.

Current configure check detects posix ACL support
but compile of modules/vfs_posixacl.c fails due
to missing defines in sys/acl.h:

It has to be investigated, if this can be fixed within
the posixacl vfs module or if we need a darwinacl module.


13 years agor23387: 1. This unifies the POSIX ACL detection code:
Michael Adam [Fri, 8 Jun 2007 12:32:13 +0000 (12:32 +0000)]
r23387: 1. This unifies the POSIX ACL detection code:
Linux, FreeBSD and other (which?) ACL implementations
are now checked in the same block instead of in three
separate blocks. This was inspired by Timur Bakeyev
in Bug #4543. Since bugzilla is currently unavailable
this patch is probably slightly different from Timurs
original patch. This should finally fix Bug #4543.

2. The default of the --with-acl-support configure
option is changed to "auto" (which is actually the
same as "yes"). So configure tries to detect acl
support by default. This had been discussed with
Metze and others.


13 years agor23380: netr_getdcname returns WERROR not NTSTATUS.
Günther Deschner [Fri, 8 Jun 2007 10:29:46 +0000 (10:29 +0000)]
r23380: netr_getdcname returns WERROR not NTSTATUS.


13 years agor23379: Whitespace cosmetics, to reduce irritating diffs...
Michael Adam [Fri, 8 Jun 2007 10:15:19 +0000 (10:15 +0000)]
r23379: Whitespace cosmetics, to reduce irritating diffs...


13 years agor23377: Patch from Bjoern Jacke <> to deal
Gerald Carter [Thu, 7 Jun 2007 13:35:39 +0000 (13:35 +0000)]
r23377: Patch from Bjoern Jacke <> to deal
with non-GNU implementations of tr in

13 years agor23376: More warnings
Volker Lendecke [Thu, 7 Jun 2007 07:53:33 +0000 (07:53 +0000)]
r23376: More warnings

13 years agor23375: Fix a 64-bit warning
Volker Lendecke [Thu, 7 Jun 2007 07:49:43 +0000 (07:49 +0000)]
r23375: Fix a 64-bit warning

13 years agor23372: Remove restriction on string length for rpcclient commands.
Jeremy Allison [Thu, 7 Jun 2007 01:13:43 +0000 (01:13 +0000)]
r23372: Remove restriction on string length for rpcclient commands.

13 years agor23371: Fix the misleading comment I added - it really *should*
Jeremy Allison [Thu, 7 Jun 2007 00:14:06 +0000 (00:14 +0000)]
r23371: Fix the misleading comment I added - it really *should*
say "locks chain and returned record", not
"and returns record"

13 years agor23370: Traverse in tdb wasn't consistently using the
Jeremy Allison [Thu, 7 Jun 2007 00:00:45 +0000 (00:00 +0000)]
r23370: Traverse in tdb wasn't consistently using the
travlocks.lock_rw for lock read/write types, it
was sometimes using it (tdb_next_lock) and
sometimes explicitly using F_WRLCK instead.
Change this to consistently use travlocks.lock_rw
I'm pretty sure about this fix (else I woudn't
be checking this in :-) but tridge and Volker
please review.

13 years agor23368: Make "winbind:rpc only" a full blown parameter. Thanks to Karolin for
Volker Lendecke [Wed, 6 Jun 2007 13:02:24 +0000 (13:02 +0000)]
r23368: Make "winbind:rpc only" a full blown parameter. Thanks to Karolin for
the patch :-)

13 years agor23367: check the "use mmap" option for ldb too
Andrew Tridgell [Wed, 6 Jun 2007 13:02:14 +0000 (13:02 +0000)]
r23367: check the "use mmap" option for ldb too

13 years agor23363: Activate rep_pread and rep_pwrite in lib/replace/replace.h.
Michael Adam [Wed, 6 Jun 2007 09:27:43 +0000 (09:27 +0000)]
r23363: Activate rep_pread and rep_pwrite in lib/replace/replace.h.
This fixes the build on a SuSE 6.1. :-)
I guess this had been merely forgotten.

But beware: The implementations of rep_pread and rep_pwrite are
not thread safe.


13 years agor23362: Respect "use mmap" in tdb_wrap_open(). Tridge, you might want to merge
Volker Lendecke [Wed, 6 Jun 2007 07:46:38 +0000 (07:46 +0000)]
r23362: Respect "use mmap" in tdb_wrap_open(). Tridge, you might want to merge
this in your tree.

13 years agor23359: Fix bug #4537, fix from
Jeremy Allison [Wed, 6 Jun 2007 00:42:10 +0000 (00:42 +0000)]
r23359: Fix bug #4537, fix from

13 years agor23358: Fix from Justin Maggard <> - ensure we don't
Jeremy Allison [Tue, 5 Jun 2007 23:35:39 +0000 (23:35 +0000)]
r23358: Fix from Justin Maggard <> - ensure we don't
expire a password if it's explicitly set as ACB_PWNOTREQ.

13 years agor23357: timespec_current() was returning the wrong ns time
Jeremy Allison [Tue, 5 Jun 2007 19:17:05 +0000 (19:17 +0000)]
r23357: timespec_current() was returning the wrong ns time
(multiplying tv_sec, not tv_usec).

13 years agor23356: We missed to add the 'c' character to the list of valid ones for
Simo Sorce [Tue, 5 Jun 2007 12:58:18 +0000 (12:58 +0000)]
r23356: We missed to add the 'c' character to the list of valid ones for
shell escaping.

I hate this kind of bugs more than how Jeremy hates off by ones :(


13 years agor23355: Fix some more build warnings.
Günther Deschner [Tue, 5 Jun 2007 10:49:05 +0000 (10:49 +0000)]
r23355: Fix some more build warnings.


13 years agor23354: Fix build warning.
Günther Deschner [Tue, 5 Jun 2007 10:23:56 +0000 (10:23 +0000)]
r23354: Fix build warning.


13 years agor23352: Don't generate stamp-h. AFAICT it is never used.
James Peach [Tue, 5 Jun 2007 06:10:09 +0000 (06:10 +0000)]
r23352: Don't generate stamp-h. AFAICT it is never used.

13 years agor23349: Fix from Steve Langasek <> to
Jeremy Allison [Tue, 5 Jun 2007 01:59:37 +0000 (01:59 +0000)]
r23349: Fix from Steve Langasek <> to
allow SIGTERM to cause nmbd to exit on awaiting
an interface to come up. Debian bug #168079

13 years agor23348: Fix connection reporting on SIGUSR2 (noticed by
Jeremy Allison [Mon, 4 Jun 2007 23:51:19 +0000 (23:51 +0000)]
r23348: Fix connection reporting on SIGUSR2 (noticed by

13 years agor23347: Fix Coverity 363. Dead code elimination.
Jeremy Allison [Mon, 4 Jun 2007 23:31:34 +0000 (23:31 +0000)]
r23347: Fix Coverity 363. Dead code elimination.

13 years agor23346: Fix offline caching with XP/Vista. It was an off-by-one
Jeremy Allison [Mon, 4 Jun 2007 22:29:23 +0000 (22:29 +0000)]
r23346: Fix offline caching with XP/Vista. It was an off-by-one
in storing the access mask. I shouldn't have made this
mistake. Damn. Fixes bug #4673.

13 years agor23345: Stop Coverity from getting confused.
Jeremy Allison [Mon, 4 Jun 2007 19:58:11 +0000 (19:58 +0000)]
r23345: Stop Coverity from getting confused.

13 years agor23344: Better error message
Volker Lendecke [Mon, 4 Jun 2007 19:50:30 +0000 (19:50 +0000)]
r23344: Better error message

13 years agor23343: Fix error return
Volker Lendecke [Mon, 4 Jun 2007 19:45:41 +0000 (19:45 +0000)]
r23343: Fix error return

13 years agor23342: Stop Coverity from getting confused.
Jeremy Allison [Mon, 4 Jun 2007 19:29:40 +0000 (19:29 +0000)]
r23342: Stop Coverity from getting confused.

13 years agor23341: pdb interfaces should be versioned. As SAMBA_3_0 and SAMBA_3_0_26
Jeremy Allison [Mon, 4 Jun 2007 19:03:33 +0000 (19:03 +0000)]
r23341: pdb interfaces should be versioned. As SAMBA_3_0 and SAMBA_3_0_26
are now identical, use the same version number (16) for both.

13 years agor23340: Fix typo in debug ouput. Found by Karolin Seeger <>.
Michael Adam [Mon, 4 Jun 2007 14:48:26 +0000 (14:48 +0000)]
r23340: Fix typo in debug ouput. Found by Karolin Seeger <>.

13 years agor23337: fix a crash bug...I wonder why only HP-UX 11.00 ans 11.11 noticed
Stefan Metzmacher [Mon, 4 Jun 2007 14:25:52 +0000 (14:25 +0000)]
r23337: fix a crash bug...I wonder why only HP-UX 11.00 ans 11.11 noticed
it via a SIGBUS...

I missed to remove the samba3 specifc code path to tdb_open_ex()
when I synced lib/tdb/ with samba4. The explicit cast in on tdb_open_ex()
dropped the compiler warning :-(


13 years agor23335: as not all source files include replace.h/config.h
Stefan Metzmacher [Mon, 4 Jun 2007 09:57:59 +0000 (09:57 +0000)]
r23335: as not all source files include replace.h/config.h
before unistd.h we need to pass -D_FILE_OFFSET_BITS=64
together with -Dpread=pread64 -Dpwrite=pwrite64


13 years agor23330: always include "winbind_client.h" as first header
Stefan Metzmacher [Mon, 4 Jun 2007 08:03:46 +0000 (08:03 +0000)]
r23330: always include "winbind_client.h" as first header
as it brings in "replace.h" this will bring in "config.h"


13 years agor23328: don't typedef ber_tag_t when it's already done by openldap
Stefan Metzmacher [Mon, 4 Jun 2007 08:01:48 +0000 (08:01 +0000)]
r23328: don't typedef ber_tag_t when it's already done by openldap
headers on HP-UX (lber_types.h defines _LBER_TYPES_H).


13 years agor23323: merged ldb changes from 3.0.26
Andrew Tridgell [Mon, 4 Jun 2007 01:51:18 +0000 (01:51 +0000)]
r23323: merged ldb changes from 3.0.26

13 years agor23321: remove unused variable (due to mad merge from Centeris patches)
Gerald Carter [Mon, 4 Jun 2007 01:33:00 +0000 (01:33 +0000)]
r23321: remove unused variable (due to mad merge from Centeris patches)

13 years agor23317: Fix the build: r23315 was a little overeager in removing the
Michael Adam [Sun, 3 Jun 2007 20:24:25 +0000 (20:24 +0000)]
r23317: Fix the build: r23315 was a little overeager in removing the
INIPARSER_OBJ from the bin/net target altogether. I re-add it
in the guise of @BUILD_INIPARSER@ (to NET_OBJ). This also
eliminates the need to have @BUILD_INIPARSER@ in the deps for
the bin/net target.
Same procedure for the pam_winbindd module.


13 years agor23316: Ouch... This would not have run in production without cluster code
Volker Lendecke [Sun, 3 Jun 2007 19:56:41 +0000 (19:56 +0000)]
r23316: Ouch... This would not have run in production without cluster code

13 years agor23315: - don't use the builtin and -liniparser together in bin/net
Stefan Metzmacher [Sun, 3 Jun 2007 16:21:40 +0000 (16:21 +0000)]
r23315: - don't use the builtin and -liniparser together in bin/net
- unify handling on @BUILD_INIPARSER@

btw: nsswitch/pam_winbind.c doesn't compile anymore on SuSE 10.2!
     I think we should build pam modules by default to notice things
     like this in the build-farm...


13 years agor23314: For some systems it's needed to inject replace.h into
Stefan Metzmacher [Sun, 3 Jun 2007 15:51:09 +0000 (15:51 +0000)]
r23314: For some systems it's needed to inject replace.h into
the iniparser source code, I do it in a way we can still have
a unmodified copy of iniparser in source/iniparser/
and have the wrapper stuff in source/iniparser_build/.

If the build-farm is happy with this I'll merge it to 3_0_26


13 years agor23313: Janitor for tridge:
Volker Lendecke [Sun, 3 Jun 2007 06:54:51 +0000 (06:54 +0000)]
r23313: Janitor for tridge:

we need to use tdb_wrap_open in both these backends to allow for
multiple opens.  This is done for notify.tdb. Otherwise we die when a
2nd share with notify is setup

13 years agor23312: As per Volker, rename the "windbind:ads" parameter "winbind:rpc only".
James Peach [Sat, 2 Jun 2007 21:12:47 +0000 (21:12 +0000)]
r23312: As per Volker, rename the "windbind:ads" parameter "winbind:rpc only".

13 years agor23309: sync lib/replace with SAMBA_4_0
Stefan Metzmacher [Sat, 2 Jun 2007 09:10:08 +0000 (09:10 +0000)]
r23309: sync lib/replace with SAMBA_4_0


13 years agor23307: move readahead stuff out of libreplace and make it samba3 specific
Stefan Metzmacher [Sat, 2 Jun 2007 08:30:42 +0000 (08:30 +0000)]
r23307: move readahead stuff out of libreplace and make it samba3 specific
as we can't replace this function in libreplace and we do
the some stuff for other function in the same way.


13 years agor23305: merge from samba4:
Stefan Metzmacher [Sat, 2 Jun 2007 08:14:27 +0000 (08:14 +0000)]
r23305: merge from samba4:

fix large file support on HP-UX 11.00 and 11.11


13 years agor23302: Refactor vfs_gpfs module, fix problems with chmod Tridge has found during...
Alexander Bokovoy [Sat, 2 Jun 2007 06:28:38 +0000 (06:28 +0000)]
r23302: Refactor vfs_gpfs module, fix problems with chmod Tridge has found during ctdb tests

13 years agor23300: AFAICT these are not needed. Jerry, can you please review and revert
James Peach [Fri, 1 Jun 2007 19:42:23 +0000 (19:42 +0000)]
r23300: AFAICT these are not needed. Jerry, can you please review and revert
if this is not correct.

13 years agor23299: Fix the build for !WITH_SENDFILE.
James Peach [Fri, 1 Jun 2007 19:34:08 +0000 (19:34 +0000)]
r23299: Fix the build for !WITH_SENDFILE.

13 years agor23297: This introduces the winbind:ads parameter which defaults to True. Setting it
Volker Lendecke [Fri, 1 Jun 2007 18:39:50 +0000 (18:39 +0000)]
r23297: This introduces the winbind:ads parameter which defaults to True. Setting it
to False makes winbind use RPC and not LDAP methods to connect to the DCs,
even when it figured out they are AD.

13 years agor23295: Apply proto_exists and bin/.dummy dependencies consistently for all
James Peach [Fri, 1 Jun 2007 16:06:40 +0000 (16:06 +0000)]
r23295: Apply proto_exists and bin/.dummy dependencies consistently for all
binaries.  Fix vfs_zfsacl build rule in SAMBA_3_0.

13 years agor23291: Undo the somewhat naive change of r23279:
Michael Adam [Fri, 1 Jun 2007 12:24:57 +0000 (12:24 +0000)]
r23291: Undo the somewhat naive change of r23279:
The clear text presentaion of the sid in the ldap expression
does work with w2k3 but not with w2k....

Thanks to Guenther for advising me of this issue.


13 years agor23290: Fix another small and stupid but severe typo.
Michael Adam [Fri, 1 Jun 2007 12:18:16 +0000 (12:18 +0000)]
r23290: Fix another small and stupid but severe typo.
Hopfully, I have finally got this right... :-)


13 years agor23287: Use talloc_move instead of talloc_steal as this is what I really
Michael Adam [Fri, 1 Jun 2007 10:10:57 +0000 (10:10 +0000)]
r23287: Use talloc_move instead of talloc_steal as this is what I really
wanted to do.


13 years agor23284: Oh what a nasty typo! This gave me some headache,
Michael Adam [Thu, 31 May 2007 23:58:56 +0000 (23:58 +0000)]
r23284: Oh what a nasty typo! This gave me some headache,
with talloc randomly failing.

Hey, shouldn't TALLOC_ARRAY _not_ return NULL when
requested to allocate an array with zero entries? :-)


13 years agor23283: Use a temporary talloc context in ads:lookup_groupmem.
Michael Adam [Thu, 31 May 2007 23:55:37 +0000 (23:55 +0000)]
r23283: Use a temporary talloc context in ads:lookup_groupmem.
And clean up unused stuff at the end.
Daringly, I use talloc_steal at some point, where it
appears natural to me.


13 years agor23279: Replace occurrence of sid_binstring inside lookup_groupmem
Michael Adam [Thu, 31 May 2007 22:02:49 +0000 (22:02 +0000)]
r23279: Replace occurrence of sid_binstring inside lookup_groupmem
by sid_string_static.

13 years agor23274: merge CloseEventlog() pidl conversion from 3.0.26 && fix a few init call...
Gerald Carter [Thu, 31 May 2007 17:59:04 +0000 (17:59 +0000)]
r23274: merge CloseEventlog() pidl conversion from 3.0.26 && fix a few init call renames for svcctl in the previous commit

13 years agor23272: Fix main event loop - reviewed by Volker.
Jeremy Allison [Thu, 31 May 2007 17:26:30 +0000 (17:26 +0000)]
r23272: Fix main event loop - reviewed by Volker.