15 years agor23155: Rename INSTALLPERMS to INSTALLPERMS_BIN to differenciate clearer from
Lars Müller [Sat, 26 May 2007 13:30:45 +0000 (13:30 +0000)]
r23155: Rename INSTALLPERMS to INSTALLPERMS_BIN to differenciate clearer from

15 years agor23154: Add INSTALLPERMS_DATA set to 0644 to install the header files with this
Lars Müller [Sat, 26 May 2007 13:24:56 +0000 (13:24 +0000)]
r23154: Add INSTALLPERMS_DATA set to 0644 to install the header files with this
permission set instead of 0755.

15 years agor23151: Re-arrange the logic so it looks identical to the
Jeremy Allison [Sat, 26 May 2007 01:26:09 +0000 (01:26 +0000)]
r23151: Re-arrange the logic so it looks identical to the
"file existed" case above. This has no functional
change but is easier to see that it's doing the
same thing.

15 years agor23150: Fix Samba3 in the build farm again. In the case where the
Jeremy Allison [Sat, 26 May 2007 01:19:51 +0000 (01:19 +0000)]
r23150: Fix Samba3 in the build farm again. In the case where the
file was being created and we go into the race condition check,
we were testing for compatible open modes, but were not breaking
oplocks in the same way as if the file existed. This meant that
we weren't going into the code path that sets fsp->oplock = FAKE_LEVEL_II_OPLOCK
if the client didn't ask for an oplock on file create. We need
to do this as internally it's what Windows does.

15 years agor23148: Fix old old bug in cli_smbwrite() (not incrementing
Jeremy Allison [Fri, 25 May 2007 23:50:35 +0000 (23:50 +0000)]
r23148: Fix old old bug in cli_smbwrite() (not incrementing
data being sent). Patch from

15 years agor23147: Patch #4566 from jacob berkman <>. Pass password data...
Jeremy Allison [Fri, 25 May 2007 22:04:03 +0000 (22:04 +0000)]
r23147: Patch #4566 from jacob berkman <>. Pass password data to krb5_prompter.

15 years agor23128: Fix typo.
Günther Deschner [Thu, 24 May 2007 23:17:24 +0000 (23:17 +0000)]
r23128: Fix typo.


15 years agor23127: Fill in some more netlogon dsgetdcname flavours (netr_DsRGetDCNameEx,
Günther Deschner [Thu, 24 May 2007 23:11:11 +0000 (23:11 +0000)]
r23127: Fill in some more netlogon dsgetdcname flavours (netr_DsRGetDCNameEx,
netr_DsRGetDCNameEx2) and add new ds request and reply flags, also add some
more WERROR codes.


15 years agor23122: Fix bug #4655. We marshall the enumdataex correctly,
Jeremy Allison [Thu, 24 May 2007 20:40:46 +0000 (20:40 +0000)]
r23122: Fix bug #4655. We marshall the enumdataex correctly,
but W2K3 doesn't follow our rules when sending data to
us. Ensure we look for the data at the correct offsets
when reading the data.
Too late for 3.0.25a - don't merge.

15 years agor23121: Fix Bug #2727 and let pam_smbpass at least link and dlopen correctly again.
Günther Deschner [Thu, 24 May 2007 20:26:07 +0000 (20:26 +0000)]
r23121: Fix Bug #2727 and let pam_smbpass at least link and dlopen correctly again.

Thanks to Bartlomiej Solarz-Niesluchowski <>.


15 years agor23117: Factor out local messaging.
Volker Lendecke [Thu, 24 May 2007 14:47:24 +0000 (14:47 +0000)]
r23117: Factor out local messaging.

This removes message_block / message_unblock. I've talked to Jeremy and
Günther, giving them my reasons why I believe they have no effect.
Neither could come up with a counter-argument, so they go :-)

15 years agor23116: Fix typo, found by Karolin Seeger
Volker Lendecke [Thu, 24 May 2007 13:49:10 +0000 (13:49 +0000)]
r23116: Fix typo, found by Karolin Seeger

15 years agor23112: Trim down the message.c API slightly: The messages_pending_for_pid is now
Volker Lendecke [Thu, 24 May 2007 11:09:37 +0000 (11:09 +0000)]
r23112: Trim down the message.c API slightly: The messages_pending_for_pid is now
replaced by MSG_FLAG_LOWPRIORITY or'ed into the msg_type. To enable this,
changed the msg_type definitions to hexadecimal.

This way we could theoretically add the MSG_FLAG_NODUPLICATES again, but I
would rather not do this, because that one is racy and can't be guaranteed at

15 years agor23109: Redo the change from r22772 I accidentially undid in r23108.
Michael Adam [Thu, 24 May 2007 09:06:15 +0000 (09:06 +0000)]
r23109: Redo the change from r22772 I accidentially undid in r23108.


15 years agor23108: Add defines of RTLD_NOW and RTLD_GLOBAL to replace.h.
Michael Adam [Thu, 24 May 2007 07:15:36 +0000 (07:15 +0000)]
r23108: Add defines of RTLD_NOW and RTLD_GLOBAL to replace.h.
Fixing build of ldb for instance on some systems without dlfcn.h.

15 years agor23107: Fix renames on file descriptors that are supposed to overwrite the
Jeremy Allison [Thu, 24 May 2007 01:57:02 +0000 (01:57 +0000)]
r23107: Fix renames on file descriptors that are supposed to overwrite the
target. Needs merging for 3.0.25a (sorry).

15 years agor23106: Use lchown for symlinks.
Jeremy Allison [Thu, 24 May 2007 00:13:24 +0000 (00:13 +0000)]
r23106: Use lchown for symlinks.

15 years agor23105: Add lchown to the vfs layer. We need this in the POSIX code.
Jeremy Allison [Wed, 23 May 2007 23:55:12 +0000 (23:55 +0000)]
r23105: Add lchown to the vfs layer. We need this in the POSIX code.

15 years agor23100: Implement the delete on close semantics I've just tested for
Jeremy Allison [Wed, 23 May 2007 21:32:10 +0000 (21:32 +0000)]
r23100: Implement the delete on close semantics I've just tested for
in Samba4 smbtorture. Fix rename on an open file handle.
Needed for 3.0.25a.

15 years agor23098: Fix the case of the #include statements so this module can be built on a
James Peach [Wed, 23 May 2007 20:48:53 +0000 (20:48 +0000)]
r23098: Fix the case of the #include statements so this module can be built on a
case-sensitive filesystem.

15 years agor23097: Add a new configure option to disable building SWAT (it is still built by
James Peach [Wed, 23 May 2007 20:46:07 +0000 (20:46 +0000)]
r23097: Add a new configure option to disable building SWAT (it is still built by

15 years agor23096: Make the lock failure message prettier.
James Peach [Wed, 23 May 2007 20:38:14 +0000 (20:38 +0000)]
r23096: Make the lock failure message prettier.

15 years agor23095: Support systems that have their PAM headers in /usr/include/pam.
James Peach [Wed, 23 May 2007 20:31:28 +0000 (20:31 +0000)]
r23095: Support systems that have their PAM headers in /usr/include/pam.

15 years agor23094: Update the iconv detection to handle cross-compiles better. If we are
James Peach [Wed, 23 May 2007 19:57:13 +0000 (19:57 +0000)]
r23094: Update the iconv detection to handle cross-compiles better. If we are
cross-compiling, we accept the first iconv library that we find (with a

15 years agor23093: Allow modules with the same name but different types.
James Peach [Wed, 23 May 2007 19:10:04 +0000 (19:10 +0000)]
r23093: Allow modules with the same name but different types.

15 years agor23091: Add rpccli_netlogon_sam_network_logon_ex, fix its parsing. This does not
Volker Lendecke [Wed, 23 May 2007 15:17:49 +0000 (15:17 +0000)]
r23091: Add rpccli_netlogon_sam_network_logon_ex, fix its parsing. This does not
use the credential chain and only works over netlogon, but it would
allow multiple outstanding auth requests for a single workstation

15 years agor23088: Fix rename for cifsfs client. This may be needed for
Jeremy Allison [Tue, 22 May 2007 23:56:47 +0000 (23:56 +0000)]
r23088: Fix rename for cifsfs client. This may be needed for

15 years agor23087: Fix POSIX setfilepathinfo to use lstat, not stat.
Jeremy Allison [Tue, 22 May 2007 22:35:13 +0000 (22:35 +0000)]
r23087: Fix POSIX setfilepathinfo to use lstat, not stat.
Still missing lchown (will add this for 3.0.26).
Don't merge for 3.0.25a - possibly 3.0.25b (if it

15 years agor23082: Ooops - that portion of the last checkin was by accident.
Michael Adam [Tue, 22 May 2007 21:17:31 +0000 (21:17 +0000)]
r23082: Ooops - that portion of the last checkin was by accident.
Before comitting that, I have to verify that it does not
break anything...


15 years agor23081: Reorder the lsa_lookup_sids functions so that the order makes more sense...
Michael Adam [Tue, 22 May 2007 21:04:56 +0000 (21:04 +0000)]
r23081: Reorder the lsa_lookup_sids functions so that the order makes more sense...

15 years agor23080: Fix bug #4637 - we hads missed some cases where
Jeremy Allison [Tue, 22 May 2007 20:20:01 +0000 (20:20 +0000)]
r23080: Fix bug #4637 - we hads missed some cases where
we were calling PRS_ALLOC_MEM with zero count.

15 years agor23078: Don't handle return code NT_STATUS_NONE_MAPPED from lookup sids
Michael Adam [Tue, 22 May 2007 15:13:32 +0000 (15:13 +0000)]
r23078: Don't handle return code NT_STATUS_NONE_MAPPED from lookup sids
as an error. (This is purely cosmetic here, issuing a success
message at the end.)

15 years agor23077: Minor cleanup
Volker Lendecke [Tue, 22 May 2007 14:31:26 +0000 (14:31 +0000)]
r23077: Minor cleanup

15 years agor23075: more duplicate code blocks from bad merge
Gerald Carter [Tue, 22 May 2007 13:55:31 +0000 (13:55 +0000)]
r23075: more duplicate code blocks from bad merge

15 years agor23074: Remove duplicate code blocks from bad merge
Gerald Carter [Tue, 22 May 2007 13:43:34 +0000 (13:43 +0000)]
r23074: Remove duplicate code blocks from bad merge

15 years agor23073: In the internal rpccli_lsa_lookup_sids_noalloc(), use a temporary
Michael Adam [Tue, 22 May 2007 13:40:01 +0000 (13:40 +0000)]
r23073: In the internal rpccli_lsa_lookup_sids_noalloc(), use a temporary
talloc context for use with the actual rpc query and response.
So the the parent context does not get flooded by the posslibly
large amount of response data (when looking up a lot of sids).

Note: It not possible, to simply use the names and domains arrays
as talloc contexts for the talloc_strdup calls, because from
rpccli_lsa_lookup_sids_all, this is called with names + offset
and domains + offset where names and domains are talloced
arraye for the complete response.

15 years agor23072: In winbindd_ads.c:lookup_groupmem, replace the bottleneck
Michael Adam [Tue, 22 May 2007 12:49:41 +0000 (12:49 +0000)]
r23072: In winbindd_ads.c:lookup_groupmem, replace the bottleneck
dn_lookup loop by a rpccli_lsa_lookupsids_all (see r23070)
call. This replaces one ldap search per member sid by one
rpc call per 1000 sids. This greatly speeds up groupmem
lookups for groups with lots of users.

Since the loop in lookup_groupmem was the only use of dn_lookup,
the function is removed.


15 years agor23070: The lsa rpc lookup sids call has a maximum number of SIDS to be
Michael Adam [Tue, 22 May 2007 11:30:35 +0000 (11:30 +0000)]
r23070: The lsa rpc lookup sids call has a maximum number of SIDS to be
looked up at one time. This limit is at 20480 for w2k3.
Our rpccli_lsa_lookup_sids function ignores this limit, so when
we give the server too long a list of SIDs, then we will get
nothing back. Since typically rpccli_lsa_lookup_sids is given
one SID  (or a small number of SIDS), this did not do harm
up to now. But since I want to use lsa_lookup_sids in a subsequent
modification to winbindd_ads.c:lookup_groupmem to get rid of
a vast number of dn_lookup calls to the server, I had to make
sure we do it correctly.

I have added a function rpccli_lsa_lookup_sids_all function
that has the same prototype but internally splits the list
of SIDs up into hunks of a (conservative, hard coded) 1000
SIDs each for a first go.

If this approach is agreed upon, the new function could replace
the original rpccli_lsa_lookup_sids function.


15 years agor23068: Fix some uninitialized variables in the solarisacl module
Volker Lendecke [Tue, 22 May 2007 10:05:56 +0000 (10:05 +0000)]
r23068: Fix some uninitialized variables in the solarisacl module

15 years agor23055: Rewrite messages.c to use auto-generated marshalling in the tdb. I'm
Volker Lendecke [Mon, 21 May 2007 22:17:13 +0000 (22:17 +0000)]
r23055: Rewrite messages.c to use auto-generated marshalling in the tdb. I'm
doing this because for the clustering the marshalling is needed in more
than one place, so I wanted a decent routine to marshall a message_rec
struct which was not there before.

Tridge, this seems about the same speed as it used to be before, the
librpc/ndr overhead in my tests was under the noise.


15 years agor23054: Move the check for the lookup_domain of S-1-22-{1,2} before the
Gerald Carter [Mon, 21 May 2007 21:33:51 +0000 (21:33 +0000)]
r23054: Move the check for the lookup_domain of S-1-22-{1,2} before the
check for IS_DC.  Otherwise we will for example fail to lookup a
sid of S-1-22-1-780 because it has no valid struct winbindd_domain*
in the list.   Thanks to Simo for the catch.

15 years agor23051: sid_to_[ug]id fixes for smbd
Simo Sorce [Mon, 21 May 2007 20:51:15 +0000 (20:51 +0000)]
r23051: sid_to_[ug]id fixes for smbd

15 years agor23048: Simo is correct in that winbind_lookup{sid,name}_async() needs
Gerald Carter [Mon, 21 May 2007 20:36:22 +0000 (20:36 +0000)]
r23048: Simo is correct in that winbind_lookup{sid,name}_async() needs
to be able to handle SIDs in the S-1-22-{1,2} domain in order
for winbindd_sid_to_uid(), et. al. to succeed.  For 3.0.25a,
we will short circuit in the sid_to_uid() family of functions
so that smbd is ok.

For 3.0.26, we need to allow winbindd to handle all types of SIDs.

15 years agor23046: Few missing merges from cleaning out the Centeris winbindd tree.
Gerald Carter [Mon, 21 May 2007 19:12:14 +0000 (19:12 +0000)]
r23046: Few missing merges from cleaning out the Centeris winbindd tree.
Nothing of major interest.  Will fix a few problems with one way trusts.

15 years agor23041: Remainder of fix for 4630: fix special case of unix_to_nt_time() for
Jim McDonough [Mon, 21 May 2007 16:01:22 +0000 (16:01 +0000)]
r23041: Remainder of fix for 4630: fix special case of unix_to_nt_time() for
TIME_T_MAX, and also display of it in http_timestring()

15 years agor23040: Activate the winbindd cache validation code in the
Michael Adam [Mon, 21 May 2007 15:58:27 +0000 (15:58 +0000)]
r23040: Activate the winbindd cache validation code in the
winbindd main function.

I have tested and somewhat extended the code, and it seems
to do a good job. I have possibly not caught all error
conditions though.


15 years agor23039: merge from SAMBA_3_0_26:
Stefan Metzmacher [Mon, 21 May 2007 13:40:27 +0000 (13:40 +0000)]
r23039: merge from SAMBA_3_0_26:

use a helper function to construct the TDB_DATA key
as strlen_m() is totally wrong here anyway


15 years agor23025: Some logic simplifications
Volker Lendecke [Sun, 20 May 2007 20:28:45 +0000 (20:28 +0000)]
r23025: Some logic simplifications

15 years agor23024: Ok, neither the duplicates_allowed nor the timeout argument to
Volker Lendecke [Sun, 20 May 2007 20:11:23 +0000 (20:11 +0000)]
r23024: Ok, neither the duplicates_allowed nor the timeout argument to
message_send_pid is used anymore. Two users of duplicates_allowed: winbind and
the printer notify system.

I don't thing this really changes semantics: duplicates_allowed is hell racy
anyway, we can't guarantee that we don't send the same message in sequence
twice, and I think the only thing we can harm with the print notify is

For winbind I talked to Günther, and he did not seem too worried.


15 years agor23023: Get rid of the only caller of message_send_pid_with_timeout(). This replaces
Volker Lendecke [Sun, 20 May 2007 19:43:49 +0000 (19:43 +0000)]
r23023: Get rid of the only caller of message_send_pid_with_timeout(). This replaces
the timeouts on the individual message send calls with an overall timeout on
all the calls.

The timeout in message_send_pid_with_timeout() did not make much sense IMO
anyway, because the tdb_fetch() for the messages_pending_for_pid was blocking
in a readlock anyway, we "just" did the timeout for the write lock.

This new code goes through the full wait for the write lock once and then
breaks out of sending the notifies instead of running into the timeout per

Jerry, please check this!



15 years agor23022: Reformatting
Volker Lendecke [Sun, 20 May 2007 17:00:18 +0000 (17:00 +0000)]
r23022: Reformatting

15 years agor23016: Remove extra & - thanks to Volker for spotting this.
Jeremy Allison [Sat, 19 May 2007 22:29:59 +0000 (22:29 +0000)]
r23016: Remove extra & - thanks to Volker for spotting this.

15 years agor23015: Make message_(de)register static to messages.c
Volker Lendecke [Sat, 19 May 2007 21:53:28 +0000 (21:53 +0000)]
r23015: Make message_(de)register static to messages.c

15 years agor23014: For all branches, ensure that if we're blocked on a POSIX
Jeremy Allison [Sat, 19 May 2007 20:57:12 +0000 (20:57 +0000)]
r23014: For all branches, ensure that if we're blocked on a POSIX
lock we know nothing about that we retry the lock every
10 seconds instead of waiting for the standard select
timeout. This is how we used to (and are supposed to)

15 years agor23010: Make the output of "smbcontrol --help" match that of "smbcontrol help".
James Peach [Sat, 19 May 2007 04:59:00 +0000 (04:59 +0000)]
r23010: Make the output of "smbcontrol --help" match that of "smbcontrol help".
Bug #3181.

15 years agor23009: Both contains a strchr_m(server,'/') few lines after replacing all / with \.
James Peach [Sat, 19 May 2007 04:23:04 +0000 (04:23 +0000)]
r23009: Both contains a strchr_m(server,'/') few lines after replacing all / with \.
This patch removes this dead code.

Patch from Pascal Terjan <> for bug #2313.

15 years agor23007: Ensure we don't allow large read over the possible
Jeremy Allison [Sat, 19 May 2007 01:27:34 +0000 (01:27 +0000)]
r23007: Ensure we don't allow large read over the possible
packet size.

15 years agor23006: Arg. Fix stupid typo in 64-bit path.
Jeremy Allison [Fri, 18 May 2007 23:56:34 +0000 (23:56 +0000)]
r23006: Arg. Fix stupid typo in 64-bit path.

15 years agor23005: If we're running on a system where time_t is 8 bytes
Jeremy Allison [Fri, 18 May 2007 23:38:56 +0000 (23:38 +0000)]
r23005: If we're running on a system where time_t is 8 bytes
we have to take care to preserve the "special" values
for Windows of 0x80000000 and 0x7FFFFFFF when casting
between time_t and uint32. Add conversion functions
(and use them).

15 years agor23001: - Fix but #4634. Type of the size parameter to getpeername was wrong.
Derrell Lipman [Fri, 18 May 2007 13:42:48 +0000 (13:42 +0000)]
r23001: - Fix but #4634.  Type of the size parameter to getpeername was wrong.

15 years agor22998: merge from SAMBA_4_0:
Stefan Metzmacher [Fri, 18 May 2007 09:50:56 +0000 (09:50 +0000)]
r22998: merge from SAMBA_4_0:

only if the output of which has a leading '/' the output is useful...


15 years agor22994: Fix HP/UX compiler flags by Don McCall. Lets see how the other HP/UX
Volker Lendecke [Fri, 18 May 2007 08:35:01 +0000 (08:35 +0000)]
r22994: Fix HP/UX compiler flags by Don McCall. Lets see how the other HP/UX
boxes like this. Thanks, Don!

15 years agor22982: Do not prompt for password on sec=none for mount.cifs (and allow guest
Steve French [Thu, 17 May 2007 22:40:48 +0000 (22:40 +0000)]
r22982: Do not prompt for password on sec=none for mount.cifs (and allow guest
option to pass to kernel code so it can know when to retry)

15 years agor22979: Revert previous checkin (which had some debug junk) and fix misc frees that
Steve French [Thu, 17 May 2007 22:28:28 +0000 (22:28 +0000)]
r22979: Revert previous checkin (which had some debug junk) and fix misc frees that
valgrind noticed

15 years agor22978: Don't use current_user to prep the security ctx in change_to_user
Gerald Carter [Thu, 17 May 2007 22:27:42 +0000 (22:27 +0000)]
r22978: Don't use current_user to prep the security ctx in change_to_user
since any SID/uid/gid translation calls will reset the struct when
popping the security ctx.  This should fix the standalone server
configuration issues reported by David Rankin (thanks for the logs).

15 years agor22977: Trim noise by removing redundant WARNING log message that
Gerald Carter [Thu, 17 May 2007 19:56:54 +0000 (19:56 +0000)]
r22977: Trim noise by removing redundant WARNING log message that
would flood at log level 2.  We know when we're using the legacy
mapping code anyways since it will log an informative msg.

15 years agor22976: whoops typo
Simo Sorce [Thu, 17 May 2007 19:26:08 +0000 (19:26 +0000)]
r22976: whoops typo

15 years agor22975: BUG 4616: Don't return a dns or forest name when replying to the
Gerald Carter [Thu, 17 May 2007 19:16:27 +0000 (19:16 +0000)]
r22975: BUG 4616: Don't return a dns or forest name when replying to the
DsDGetPrimaryRoleInfo() and configured for security = domain.

15 years agor22974: enable relro with PIE if available, this gives extra protection to the ELF...
Simo Sorce [Thu, 17 May 2007 18:20:16 +0000 (18:20 +0000)]
r22974: enable relro with PIE if available, this gives extra protection to the ELF segment

15 years agor22973: Apparently, 3.0.25 broke smb4k badly ;-)
Alexander Bokovoy [Thu, 17 May 2007 13:56:19 +0000 (13:56 +0000)]
r22973: Apparently, 3.0.25 broke smb4k badly ;-)
smb4k uses 'net rap server domain' to list servers in domain.
Previously we just ignored all arguments in net_rap_server() but now we don't
as 'net rap server name' has added an explicit check on arguments.

Allow 'net rap server domain' to aid smb4k. Any other arguments will cause help message.

15 years agor22956: Fix security=server (bug #4622). Volker's patch
Jeremy Allison [Wed, 16 May 2007 22:52:17 +0000 (22:52 +0000)]
r22956: Fix security=server (bug #4622). Volker's patch
(slightly truncated by me). Will be in 3.0.25a.

15 years agor22955: Disable dependency tracking by default.
James Peach [Wed, 16 May 2007 22:34:58 +0000 (22:34 +0000)]
r22955: Disable dependency tracking by default.

15 years agor22954: More messaging_register
Volker Lendecke [Wed, 16 May 2007 20:56:39 +0000 (20:56 +0000)]
r22954: More messaging_register

15 years agor22953: Well, this apparently has never been tested. But *this* code never saw a
Volker Lendecke [Wed, 16 May 2007 20:02:32 +0000 (20:02 +0000)]
r22953: Well, this apparently has never been tested. But *this* code never saw a
release yet .... ;-))

15 years agor22950: Fix the issue Volker reported here :
Jeremy Allison [Wed, 16 May 2007 17:17:25 +0000 (17:17 +0000)]
r22950: Fix the issue Volker reported here :

"Attempt to fix some build farm failures: On port 139 the first
successful packet gives len==0 from the server, so the = in

        if (len <= 0) {

in line 136 of clientgen.c throws a failure."

The irritating thing is that I already had it correct in
SAMBA_3_0_26 and forgot to merge the change across.

len == 0 is a valid return - I messed that up when
converting client_receive_smb() to return a length
rather than a BOOL.

Doh !


15 years agor22943: More message_register -> messaging_register
Volker Lendecke [Wed, 16 May 2007 14:45:09 +0000 (14:45 +0000)]
r22943: More message_register -> messaging_register

15 years agor22942: Some message_register -> messaging_register conversions
Volker Lendecke [Wed, 16 May 2007 14:24:06 +0000 (14:24 +0000)]
r22942: Some message_register -> messaging_register conversions

15 years agor22934: Change smbcontrol to use messaging_register instead of message_register
Volker Lendecke [Wed, 16 May 2007 13:02:53 +0000 (13:02 +0000)]
r22934: Change smbcontrol to use messaging_register instead of message_register

15 years agor22932: Use the same symbol in sizeof and cast for talloc.
Michael Adam [Wed, 16 May 2007 11:57:37 +0000 (11:57 +0000)]
r22932: Use the same symbol in sizeof and cast for talloc.

15 years agor22931: Fix logic in detection of the need to replace dlopen and friends.
Michael Adam [Wed, 16 May 2007 11:15:16 +0000 (11:15 +0000)]
r22931: Fix logic in detection of the need to replace dlopen and friends.
Originally, dlfcn.o was only added to LIBREPLACEOBJ if dlopen
was found in libdl but header dlfcn.h was not appropriate.


15 years agor22930: Next attempt to get the build farm in line.
Volker Lendecke [Wed, 16 May 2007 10:59:04 +0000 (10:59 +0000)]
r22930: Next attempt to get the build farm in line.

Jeremy, please check this and merge if appropriate.

15 years agor22929: Attempt to fix some build farm failures: On port 139 the first
Volker Lendecke [Wed, 16 May 2007 09:53:41 +0000 (09:53 +0000)]
r22929: Attempt to fix some build farm failures: On port 139 the first
successful packet gives len==0 from the server, so the = in

        if (len <= 0) {

in line 136 of clientgen.c throws a failure.

Jeremy, please fix this properly, I'm not merging this to 3_0_26 so that
you can filter it when you merge.


15 years agor22928: Use better success error code.
Günther Deschner [Wed, 16 May 2007 09:42:29 +0000 (09:42 +0000)]
r22928: Use better success error code.


15 years agor22926: Don't use <=0, use < 0 to allow keepalives to propagate up.
Jeremy Allison [Wed, 16 May 2007 01:49:33 +0000 (01:49 +0000)]
r22926: Don't use <=0, use < 0 to allow keepalives to propagate up.

15 years agor22925: Sync read_and_X with 3.0.26 code (use setup_readX_header()).
Jeremy Allison [Wed, 16 May 2007 01:36:23 +0000 (01:36 +0000)]
r22925: Sync read_and_X with 3.0.26 code (use setup_readX_header()).

15 years agor22924: Fix the build by correctly processing readX
Jeremy Allison [Wed, 16 May 2007 01:34:22 +0000 (01:34 +0000)]
r22924: Fix the build by correctly processing readX
errors in the direct read case.

15 years agor22923: Fix runaway smbd now receive_smb_raw() returns a ssize_t not a BOOL.
Jeremy Allison [Wed, 16 May 2007 01:13:25 +0000 (01:13 +0000)]
r22923: Fix runaway smbd now receive_smb_raw() returns a ssize_t not a BOOL.

15 years agor22922: Move "normal_read:" label out of ifdef guard. Fix the build.
Jeremy Allison [Wed, 16 May 2007 00:21:12 +0000 (00:21 +0000)]
r22922: Move "normal_read:" label out of ifdef guard. Fix the build.

15 years agor22920: Add in the UNIX capability for 24-bit readX, as discussed
Jeremy Allison [Wed, 16 May 2007 00:07:38 +0000 (00:07 +0000)]
r22920: Add in the UNIX capability for 24-bit readX, as discussed
with the Apple guys and Linux kernel guys. Still looking
at how to do writeX as there's no recvfile().

15 years agor22919: Fix build on Tru64.
Michael Adam [Tue, 15 May 2007 23:05:34 +0000 (23:05 +0000)]
r22919: Fix build on Tru64.

15 years agor22918: Attempt to fix the build of the tru64acl module.
Michael Adam [Tue, 15 May 2007 21:41:02 +0000 (21:41 +0000)]
r22918: Attempt to fix the build of the tru64acl module.
Where the heck did that smb_acl_permset_t come from?
I can't remember...


15 years agor22914: - Fixes bug 4599. A missing <code>if</code> statement forced subseqeuent
Derrell Lipman [Tue, 15 May 2007 19:10:29 +0000 (19:10 +0000)]
r22914: - Fixes bug 4599.  A missing <code>if</code> statement forced subseqeuent
  attempts to set attributes to fail.

- I also noticed that missing attributes were setting an invalid return string
  by getxattr(), e.g. if there was not group, the return string had "GROUP:;"
  instead of excluding the GROUP attribute entirely as it should.  The big
  problem with the way it was, is that the string could not then be passed to
  setxattr() and parsed.

15 years agor22911: Pass a messaging_context to message_send_all
Volker Lendecke [Tue, 15 May 2007 15:49:55 +0000 (15:49 +0000)]
r22911: Pass a messaging_context to message_send_all

15 years agor22910: Make message_send_pid static to messages.c
Volker Lendecke [Tue, 15 May 2007 15:41:37 +0000 (15:41 +0000)]
r22910: Make message_send_pid static to messages.c

15 years agor22908: All callers of message_init now also call messaging_init. Unify those.
Volker Lendecke [Tue, 15 May 2007 15:14:32 +0000 (15:14 +0000)]
r22908: All callers of message_init now also call messaging_init. Unify those.

15 years agor22907: Fix the build with --enable-profiling-data
Volker Lendecke [Tue, 15 May 2007 14:58:01 +0000 (14:58 +0000)]
r22907: Fix the build with --enable-profiling-data

15 years agor22906: Some more message_send_pid
Volker Lendecke [Tue, 15 May 2007 14:39:18 +0000 (14:39 +0000)]
r22906: Some more message_send_pid

15 years agor22905: cli_send_mailslot had a message_send_pid inside
Volker Lendecke [Tue, 15 May 2007 13:56:00 +0000 (13:56 +0000)]
r22905: cli_send_mailslot had a message_send_pid inside

15 years agor22904: Fix indent.
Günther Deschner [Tue, 15 May 2007 13:47:25 +0000 (13:47 +0000)]
r22904: Fix indent.


15 years agor22903: Now that we have the on-disc trustdomaincache with type flags we can better
Günther Deschner [Tue, 15 May 2007 13:46:26 +0000 (13:46 +0000)]
r22903: Now that we have the on-disc trustdomaincache with type flags we can better
decide whether it's worth to register a krb5 ticket gain handler while users
logon offline.