sfrench/samba-autobuild/.git
4 years agoswrap: Rename swrap_pcap_get_fd().
Andreas Schneider [Thu, 2 Oct 2014 05:14:44 +0000 (07:14 +0200)]
swrap: Rename swrap_pcap_get_fd().

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agoswrap: Rename swrap_marshall_packet().
Andreas Schneider [Thu, 2 Oct 2014 05:14:04 +0000 (07:14 +0200)]
swrap: Rename swrap_marshall_packet().

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agoswrap: Rename swrap_packet_init().
Andreas Schneider [Thu, 2 Oct 2014 05:13:10 +0000 (07:13 +0200)]
swrap: Rename swrap_packet_init().

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agoswrap: Rename socket_wrapper_pcap_file().
Andreas Schneider [Thu, 2 Oct 2014 05:11:49 +0000 (07:11 +0200)]
swrap: Rename socket_wrapper_pcap_file().

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agoswrap: Fix type punning warnings.
Andreas Schneider [Thu, 2 Oct 2014 05:09:33 +0000 (07:09 +0200)]
swrap: Fix type punning warnings.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agoProvide a compatible declaration of CMSG_ALIGN
Jakub Hrozek [Thu, 2 Oct 2014 05:05:35 +0000 (07:05 +0200)]
Provide a compatible declaration of CMSG_ALIGN

Some platforms (like OSX) do support some of the CMGS macros, but don't
have a CMSG_ALIGN macro of their own.

Signed-off-by: Jakub Hrozek <jakub.hrozek@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoSO_PROTOCOL is platform-dependent
Jakub Hrozek [Thu, 2 Oct 2014 05:04:15 +0000 (07:04 +0200)]
SO_PROTOCOL is platform-dependent

SO_PROTOCOL is not defined on all platforms. In particular, OSX doesn't
include it and so far I haven't found any compatible declaration.

Signed-off-by: Jakub Hrozek <jakub.hrozek@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoswrap: fix another discard const warning in swrap_bind()
Michael Adam [Thu, 2 Oct 2014 05:03:22 +0000 (07:03 +0200)]
swrap: fix another discard const warning in swrap_bind()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agoswrap: fix discard const warning in swrap_bind()
Michael Adam [Thu, 2 Oct 2014 05:02:36 +0000 (07:02 +0200)]
swrap: fix discard const warning in swrap_bind()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agoswrap: fix discard const warning in swrap_remove_stale()
Michael Adam [Thu, 2 Oct 2014 05:01:34 +0000 (07:01 +0200)]
swrap: fix discard const warning in swrap_remove_stale()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agoswrap: fix build when neither HAVE_STRUCT_IN_PKTINFO nor IP_RECVDSTADDR is defined
Michael Adam [Thu, 2 Oct 2014 05:00:44 +0000 (07:00 +0200)]
swrap: fix build when neither HAVE_STRUCT_IN_PKTINFO nor IP_RECVDSTADDR is defined

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agos3: smb2cli: query info return length check was reversed.
Jeremy Allison [Wed, 1 Oct 2014 21:20:10 +0000 (14:20 -0700)]
s3: smb2cli: query info return length check was reversed.

Make it identical to the check in libcli/smb/smb2cli_ioctl.c

https://bugzilla.samba.org/show_bug.cgi?id=10848

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: "Stefan (metze) Metzmacher" <metze@samba.org>
Reviewed-by: David Disseldorp <ddiss@suse.de>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Oct  2 04:42:26 CEST 2014 on sn-devel-104

4 years agoidmap_rfc2307: Remove unsed parameter and variable
Christof Schmitt [Wed, 17 Sep 2014 20:28:19 +0000 (13:28 -0700)]
idmap_rfc2307: Remove unsed parameter and variable

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Wed Oct  1 19:20:50 CEST 2014 on sn-devel-104

4 years agoidmap_rfc2307: Fix a crash after connection problem to DC
Christof Schmitt [Wed, 17 Sep 2014 20:23:11 +0000 (13:23 -0700)]
idmap_rfc2307: Fix a crash after connection problem to DC

When the connection to the DC has a problem, the code behind
ads_do_search_retry closes the current connection and opens a new one.
The new connection has a new struct LDAP to represent the connection. In
this case, the LDAP pointer in the idmap_rfc2307_context becomes
invalid.

Fix this problem by updating the local pointer after calling
ads_do_search_retry.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agoregedit: remove an old comment
Michael Adam [Wed, 1 Oct 2014 09:36:36 +0000 (11:36 +0200)]
regedit: remove an old comment

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed Oct  1 16:55:05 CEST 2014 on sn-devel-104

4 years agoregedit: print error msg if opening registry fails
Chris Davis [Thu, 7 Aug 2014 13:17:28 +0000 (06:17 -0700)]
regedit: print error msg if opening registry fails

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: handle pgup/pgdn/home/end keys on lists
Chris Davis [Mon, 11 Aug 2014 01:26:14 +0000 (18:26 -0700)]
regedit: handle pgup/pgdn/home/end keys on lists

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: handle del and backspace in hexeditor
Chris Davis [Sun, 10 Aug 2014 00:11:00 +0000 (17:11 -0700)]
regedit: handle del and backspace in hexeditor

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: grow hexedit buffer as the user types
Chris Davis [Sat, 9 Aug 2014 20:39:59 +0000 (13:39 -0700)]
regedit: grow hexedit buffer as the user types

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: add a button to resize hexedit buffer
Chris Davis [Sat, 9 Aug 2014 06:55:25 +0000 (23:55 -0700)]
regedit: add a button to resize hexedit buffer

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: add a number input box
Chris Davis [Sat, 9 Aug 2014 06:36:48 +0000 (23:36 -0700)]
regedit: add a number input box

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: don't expand single line text field buffer with cursor movement
Chris Davis [Sat, 9 Aug 2014 05:25:50 +0000 (22:25 -0700)]
regedit: don't expand single line text field buffer with cursor movement

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: handle DEL key in text fields
Chris Davis [Sat, 9 Aug 2014 02:58:03 +0000 (19:58 -0700)]
regedit: handle DEL key in text fields

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: adjust some variable names to make them more distinct
Chris Davis [Thu, 7 Aug 2014 03:15:38 +0000 (20:15 -0700)]
regedit: adjust some variable names to make them more distinct

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: find previous items
Chris Davis [Sun, 3 Aug 2014 00:29:31 +0000 (17:29 -0700)]
regedit: find previous items

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: search values and repeat search from cursor positions
Chris Davis [Fri, 1 Aug 2014 06:24:19 +0000 (23:24 -0700)]
regedit: search values and repeat search from cursor positions

Recovering the search position from the cursors is safer than retaining
a pointer to the last node, as the pointer will become invalid if the
user deletes the item or refreshes the cache.

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: flesh out search dialog and simplify search opts
Chris Davis [Thu, 31 Jul 2014 05:04:50 +0000 (22:04 -0700)]
regedit: flesh out search dialog and simplify search opts

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: don't use subwindows in hexedit
Chris Davis [Tue, 29 Jul 2014 06:23:32 +0000 (23:23 -0700)]
regedit: don't use subwindows in hexedit

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: use pad as a canvas for dialogs
Chris Davis [Tue, 29 Jul 2014 06:04:10 +0000 (23:04 -0700)]
regedit: use pad as a canvas for dialogs

Drawing in a pad allows the dialog to maintain the same size even when
the terminal window is shrunk to some awkwardly small size.  It also
helps avoid hacks needed to update positions of subwindows when the
panel is moved.

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: clear value list after creating new key
Chris Davis [Mon, 28 Jul 2014 00:48:05 +0000 (17:48 -0700)]
regedit: clear value list after creating new key

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: use the right function to reopen a hive
Chris Davis [Mon, 28 Jul 2014 00:39:06 +0000 (17:39 -0700)]
regedit: use the right function to reopen a hive

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: move cursor to edited value in list and report edit errors
Chris Davis [Sun, 27 Jul 2014 02:49:33 +0000 (19:49 -0700)]
regedit: move cursor to edited value in list and report edit errors

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: Introduce a new API to build the dialogs.
Chris Davis [Sat, 26 Jul 2014 06:26:27 +0000 (23:26 -0700)]
regedit: Introduce a new API to build the dialogs.

This helps make new dialogs easier to create, because it provides some
common building blocks and a consistent way to deal with user input.

Dialogs are divided into sections that stack vertically, and common
sections for typical UI things like text boxes, option lists, and
buttons are provided.

The old dialogs are rewritten to use this API.

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: improvements for hexedit
Chris Davis [Sat, 26 Jul 2014 06:16:52 +0000 (23:16 -0700)]
regedit: improvements for hexedit

This mainly enables setting the hexedit buffer after the editor is
allocated.

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: add padding to fit REG_MULTI_SZ to the text field
Chris Davis [Fri, 18 Jul 2014 20:35:14 +0000 (13:35 -0700)]
regedit: add padding to fit REG_MULTI_SZ to the text field

This fixes a bug loading REG_MULTI_SZ values into the editor dialog,
since ncurses fields don't handle newline characters.

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: simplify cleanup after loading children
Chris Davis [Tue, 8 Jul 2014 04:30:49 +0000 (21:30 -0700)]
regedit: simplify cleanup after loading children

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: add a panic handler to restore terminal
Chris Davis [Tue, 1 Jul 2014 23:00:16 +0000 (16:00 -0700)]
regedit: add a panic handler to restore terminal

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: make all hives descend from a root node
Chris Davis [Tue, 1 Jul 2014 06:19:53 +0000 (23:19 -0700)]
regedit: make all hives descend from a root node

This helps simplify cleanup, since each node's talloc context is the
parent node, and freeing the root node will destroy the entire tree
without any extra utility functions.

It also wouldn't be hard to extend this later on to support browsing
multiple registries at the same time.

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: add a refresh command to clear cache and reload current path
Chris Davis [Tue, 1 Jul 2014 06:14:20 +0000 (23:14 -0700)]
regedit: add a refresh command to clear cache and reload current path

This is needed to view changes made externally

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agoregedit: reopen key after editing or removing values
Chris Davis [Sat, 28 Jun 2014 02:33:03 +0000 (19:33 -0700)]
regedit: reopen key after editing or removing values

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: reopen parent keys when adding or removing subkeys
Chris Davis [Sat, 28 Jun 2014 01:01:36 +0000 (18:01 -0700)]
regedit: reopen parent keys when adding or removing subkeys

This clears any cache associated with the parent key,
and ensures the changes will be noticed by the UI.

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: set cursor after creating a new key
Chris Davis [Thu, 26 Jun 2014 14:51:22 +0000 (07:51 -0700)]
regedit: set cursor after creating a new key

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: set cursor to the parent node when ascending
Chris Davis [Thu, 26 Jun 2014 05:51:27 +0000 (22:51 -0700)]
regedit: set cursor to the parent node when ascending

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: don't fail loading keys if just a few are unavailable
Chris Davis [Thu, 26 Jun 2014 05:29:06 +0000 (22:29 -0700)]
regedit: don't fail loading keys if just a few are unavailable

Sometimes a key might fail to open due to access restrictions.
Only report failure if all keys failed to be opened.

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: include error description in popups
Chris Davis [Thu, 26 Jun 2014 04:55:27 +0000 (21:55 -0700)]
regedit: include error description in popups

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: notify user if there's a failure loading subkeys
Chris Davis [Thu, 26 Jun 2014 04:48:52 +0000 (21:48 -0700)]
regedit: notify user if there's a failure loading subkeys

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: handle awkward window sizes better
Chris Davis [Tue, 17 Jun 2014 00:36:16 +0000 (17:36 -0700)]
regedit: handle awkward window sizes better

This fixes some assertion failures and an infinte loop that occurs
when the terminal window is shrunk down far enough to the point
regedit can't fit everything on screen.

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: use talloc typesafety features
Chris Davis [Sat, 14 Jun 2014 21:13:10 +0000 (14:13 -0700)]
regedit: use talloc typesafety features

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: restore list cursor when window is resized
Chris Davis [Wed, 11 Jun 2014 17:40:38 +0000 (10:40 -0700)]
regedit: restore list cursor when window is resized

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: make value list display data in multiple columns
Chris Davis [Tue, 10 Jun 2014 17:35:19 +0000 (10:35 -0700)]
regedit: make value list display data in multiple columns

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: add multicolumn list widget
Chris Davis [Tue, 10 Jun 2014 01:29:56 +0000 (18:29 -0700)]
regedit: add multicolumn list widget

Widget works for lists with one or more column(s).
Column headers are optional.

As a test, the patch also modifies regedit to use the
new widget for viewing registry keys. Valuelist still
needs to be upgraded to use this.

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: add search feature.
Chris Davis [Tue, 3 Jun 2014 04:50:01 +0000 (21:50 -0700)]
regedit: add search feature.

Open up a search input with '/'. 'x' key gets the next
result.

This patch also ensures that keys are always sorted, so
that the search order matches the order the keys appear
on screen.

TODO:
+ flesh out search interface
+ find previous
+ search values

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: add a color scheme for path and context help sections
Chris Davis [Thu, 22 May 2014 22:23:52 +0000 (15:23 -0700)]
regedit: add a color scheme for path and context help sections

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: sort keys
Chris Davis [Thu, 22 May 2014 00:08:06 +0000 (17:08 -0700)]
regedit: sort keys

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: free value list subwindow
Chris Davis [Wed, 21 May 2014 22:03:50 +0000 (15:03 -0700)]
regedit: free value list subwindow

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: add borders around key and value lists, and change headings
Chris Davis [Tue, 20 May 2014 23:17:42 +0000 (16:17 -0700)]
regedit: add borders around key and value lists, and change headings

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: add padding for key labels when there's not a prefix.
Chris Davis [Tue, 20 May 2014 00:34:01 +0000 (17:34 -0700)]
regedit: add padding for key labels when there's not a prefix.

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: add white on blue color scheme
Chris Davis [Mon, 19 May 2014 18:08:09 +0000 (11:08 -0700)]
regedit: add white on blue color scheme

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoregedit: silence some warnings
Chris Davis [Tue, 5 Aug 2014 04:48:04 +0000 (21:48 -0700)]
regedit: silence some warnings

Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoloadparm//init_copymap: Add braces around if/for blocks to match coding style
Kamen Mazdrashki [Wed, 10 Sep 2014 01:16:11 +0000 (03:16 +0200)]
loadparm//init_copymap: Add braces around if/for blocks to match coding style

Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Oct  1 13:47:22 CEST 2014 on sn-devel-104

4 years agoloadparm: Allocate service->copymap in service memory context
Kamen Mazdrashki [Wed, 10 Sep 2014 01:14:42 +0000 (03:14 +0200)]
loadparm: Allocate service->copymap in service memory context

This patch adds a restriction that target service structure
must be a valid TALLOC_CTX memory context.

I have traced all call paths and at the moment this is the case,
pservice parameter layways gets allocated on TALLOC_CTX.

Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoWHATSNEW: Start release notes for Samba 4.3.0pre1.
Karolin Seeger [Wed, 1 Oct 2014 07:50:01 +0000 (09:50 +0200)]
WHATSNEW: Start release notes for Samba 4.3.0pre1.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agoVERSION: Bump version up to 4.3.0pre1.
Karolin Seeger [Wed, 1 Oct 2014 07:48:19 +0000 (09:48 +0200)]
VERSION: Bump version up to 4.3.0pre1.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agoVERSION: Re-enable git snapshots.
Karolin Seeger [Wed, 1 Oct 2014 07:47:33 +0000 (09:47 +0200)]
VERSION: Re-enable git snapshots.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agoVERSION: Bump version up to 4.2.0rc1... samba-4.2.0rc1
Karolin Seeger [Wed, 1 Oct 2014 07:46:03 +0000 (09:46 +0200)]
VERSION: Bump version up to 4.2.0rc1...

...and disable git snapshots for the 4.2.0rc1 release.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agovfs_fruit: deal with vfs_catia not being loaded
Ralph Boehme [Sat, 27 Sep 2014 06:54:57 +0000 (08:54 +0200)]
vfs_fruit: deal with vfs_catia not being loaded

Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed Oct  1 01:59:25 CEST 2014 on sn-devel-104

4 years agovfs_fruit: remove redundant assignment
Ralph Boehme [Sat, 27 Sep 2014 06:04:11 +0000 (08:04 +0200)]
vfs_fruit: remove redundant assignment

Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agovfs_fruit: fix possible uninitialized use
Ralph Boehme [Sat, 27 Sep 2014 06:03:12 +0000 (08:03 +0200)]
vfs_fruit: fix possible uninitialized use

Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agolibcli/smb: call smb2cli_validate_negotiate_info*() after each authenticated tcon
Stefan Metzmacher [Fri, 26 Sep 2014 19:17:10 +0000 (21:17 +0200)]
libcli/smb: call smb2cli_validate_negotiate_info*() after each authenticated tcon

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agolibcli/smb: add smb2cli_validate_negotiate_info*()
Stefan Metzmacher [Fri, 26 Sep 2014 19:15:00 +0000 (21:15 +0200)]
libcli/smb: add smb2cli_validate_negotiate_info*()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agolibcli/smb: list NT_STATUS_FILE_CLOSED as expected ioctl response.
Stefan Metzmacher [Tue, 30 Sep 2014 08:02:01 +0000 (10:02 +0200)]
libcli/smb: list NT_STATUS_FILE_CLOSED as expected ioctl response.

Some IOCTL requests change the behavior with new protocol versions.
E.g. FSCTL_VALIDATE_NEGOTIATE_INFO resulted in NT_STATUS_FILE_CLOSED
for old servers.

As SMB2 signing might be skipped for responses with NT_STATUS_FILE_CLOSED
we need to list it explicitly in the expected return values.

This way we'll get NT_STATUS_ACCESS_DENIED, if the server doesn't
sign the response to a signed requests.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos4:libcli/tcon: remove unused smb2_tree_connect*()
Stefan Metzmacher [Mon, 29 Sep 2014 09:19:14 +0000 (11:19 +0200)]
s4:libcli/tcon: remove unused smb2_tree_connect*()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos4:torture/smb2: remove unused variable in torture_smb2_con_sopt()
Stefan Metzmacher [Mon, 29 Sep 2014 09:17:03 +0000 (11:17 +0200)]
s4:torture/smb2: remove unused variable in torture_smb2_con_sopt()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos4:torture/smb2: use smb2cli_tcon*() in torture_smb2_tree_connect()
Stefan Metzmacher [Mon, 29 Sep 2014 09:01:32 +0000 (11:01 +0200)]
s4:torture/smb2: use smb2cli_tcon*() in torture_smb2_tree_connect()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos4:torture/smb2: use torture_smb2_tree_connect() in notify.c
Stefan Metzmacher [Mon, 29 Sep 2014 09:01:32 +0000 (11:01 +0200)]
s4:torture/smb2: use torture_smb2_tree_connect() in notify.c

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos4:torture/smb2: torture_smb2_tree_connect() creates a secondary tree connect
Stefan Metzmacher [Tue, 30 Sep 2014 10:28:13 +0000 (12:28 +0200)]
s4:torture/smb2: torture_smb2_tree_connect() creates a secondary tree connect

So don't mark smb2_tree_init() as primary.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos4:libcli/smb2: make use of smb2cli_tcon*() in connect.c
Stefan Metzmacher [Mon, 29 Sep 2014 08:50:18 +0000 (10:50 +0200)]
s4:libcli/smb2: make use of smb2cli_tcon*() in connect.c

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos3:libsmb: remove unused smb2cli.h
Stefan Metzmacher [Thu, 25 Sep 2014 01:31:55 +0000 (03:31 +0200)]
s3:libsmb: remove unused smb2cli.h

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agolibcli/smb: move smb2cli_tcon.c to the toplevel
Stefan Metzmacher [Thu, 25 Sep 2014 01:28:37 +0000 (03:28 +0200)]
libcli/smb: move smb2cli_tcon.c to the toplevel

removing use of cli_state from the code.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos3:smb2cli_tcon: use smb2 signing if possible
Stefan Metzmacher [Wed, 24 Sep 2014 23:47:44 +0000 (01:47 +0200)]
s3:smb2cli_tcon: use smb2 signing if possible

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agolibcli/smb: add smb2cli_tcon_{should_sign,is_signing_on}()
Stefan Metzmacher [Fri, 26 Sep 2014 04:29:02 +0000 (06:29 +0200)]
libcli/smb: add smb2cli_tcon_{should_sign,is_signing_on}()

This can be used to force signing for individual requests.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agolibcli/smb: add smb2cli_tcon_should_encrypt()
Stefan Metzmacher [Fri, 26 Sep 2014 04:25:53 +0000 (06:25 +0200)]
libcli/smb: add smb2cli_tcon_should_encrypt()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agolibcli/smb: add smbXcli_session_is_authenticated()
Stefan Metzmacher [Wed, 24 Sep 2014 23:46:15 +0000 (01:46 +0200)]
libcli/smb: add smbXcli_session_is_authenticated()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agolibcli/smb: support additional_flags = SMB2_HDR_FLAG_SIGNED
Stefan Metzmacher [Wed, 24 Sep 2014 23:22:29 +0000 (01:22 +0200)]
libcli/smb: support additional_flags = SMB2_HDR_FLAG_SIGNED

With SMB2_HDR_FLAG_SIGNED we make sure that we either use smb2 signing
or smb2 encryption for the request.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos3:libsmb: remove unused ';'
Stefan Metzmacher [Wed, 24 Sep 2014 23:47:02 +0000 (01:47 +0200)]
s3:libsmb: remove unused ';'

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos4:libcli/smb_composite: don't try anonymous smb signing
Stefan Metzmacher [Fri, 28 Mar 2014 12:05:49 +0000 (13:05 +0100)]
s4:libcli/smb_composite: don't try anonymous smb signing

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos3:smb2_negprot: allow really large io sizes up to allmost 16MB
Stefan Metzmacher [Fri, 26 Sep 2014 04:13:10 +0000 (06:13 +0200)]
s3:smb2_negprot: allow really large io sizes up to allmost 16MB

The default is still 8MB (as on Windows 2012 *).

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agotdb: Fix a comment
Volker Lendecke [Mon, 29 Sep 2014 09:22:09 +0000 (09:22 +0000)]
tdb: Fix a comment

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Sep 30 23:08:07 CEST 2014 on sn-devel-104

4 years agos3: lib: Signal handling - ensure smbrun and change password code save and restore...
Jeremy Allison [Tue, 23 Sep 2014 21:51:18 +0000 (14:51 -0700)]
s3: lib: Signal handling - ensure smbrun and change password code save and restore existing SIGCHLD handlers.

Bug #10831 - SIGCLD Signal handler not correctly reinstalled on old library code use - smbrun etc.

https://bugzilla.samba.org/show_bug.cgi?id=10831

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agolib: util [ctdb]: Signal handling - change CatchChild() and CatchChildLeaveStatus...
Jeremy Allison [Tue, 23 Sep 2014 21:48:35 +0000 (14:48 -0700)]
lib: util [ctdb]: Signal handling - change CatchChild() and CatchChildLeaveStatus() to return the previous handler.

Bug #10831 - SIGCLD Signal handler not correctly reinstalled on old library code use - smbrun etc.

https://bugzilla.samba.org/show_bug.cgi?id=10831

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agos3: nmbd: Ensure the main nmbd process doesn't create zombies.
Jeremy Allison [Tue, 23 Sep 2014 20:32:37 +0000 (13:32 -0700)]
s3: nmbd: Ensure the main nmbd process doesn't create zombies.

Use the same mechanism as setup for smbd and winbindd.

Fixes bug #10830 - nmbd can leave unreaped zombies.

https://bugzilla.samba.org/show_bug.cgi?id=10830

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agos3:torture: transfer 1M message with fds in LOCAL-MESSAGING-FDPASS2 test
Michael Adam [Tue, 30 Sep 2014 08:16:23 +0000 (10:16 +0200)]
s3:torture: transfer 1M message with fds in LOCAL-MESSAGING-FDPASS2 test

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Sep 30 19:01:30 CEST 2014 on sn-devel-104

4 years agos3:torture: wait in tevent-loop for child to confirm receive in FDPASS2 msg test
Michael Adam [Tue, 30 Sep 2014 08:15:33 +0000 (10:15 +0200)]
s3:torture: wait in tevent-loop for child to confirm receive in FDPASS2 msg test

This is the only way to correctly transfer bigger messages.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agos3:torture: fix a message in LOCAL-MESSAGING-FDPASS2 test
Michael Adam [Tue, 30 Sep 2014 08:13:17 +0000 (10:13 +0200)]
s3:torture: fix a message in LOCAL-MESSAGING-FDPASS2 test

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agoselftest: run LOCAL-MESSAGING-READ4
Michael Adam [Mon, 29 Sep 2014 22:30:58 +0000 (00:30 +0200)]
selftest: run LOCAL-MESSAGING-READ4

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agos3:torture: add LOCAL-MESSAGING-READ4 - send 1MB message
Michael Adam [Wed, 24 Sep 2014 22:28:14 +0000 (00:28 +0200)]
s3:torture: add LOCAL-MESSAGING-READ4 - send 1MB message

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agos3:messaging: explain why the messaging_send*() functions need a tevent-loop.
Michael Adam [Tue, 30 Sep 2014 08:01:51 +0000 (10:01 +0200)]
s3:messaging: explain why the messaging_send*() functions need a tevent-loop.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agos3:unix_msg: document closing of fds in the receive handler
Michael Adam [Tue, 30 Sep 2014 11:06:18 +0000 (13:06 +0200)]
s3:unix_msg: document closing of fds in the receive handler

Pair-Programmed-With: Volker Lendecke <vl@samba.org>

Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Volker Lendecke <vl@samba.org>
4 years agos3:unix_msg: close the fds in unix_dgram_recv_handler() after the callback has run
Michael Adam [Wed, 24 Sep 2014 22:28:48 +0000 (00:28 +0200)]
s3:unix_msg: close the fds in unix_dgram_recv_handler() after the callback has run

If the caller wants to use passed fds, he should copy them away
and set them to -1.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agos3:messaging: upon receiving fds, dup them so the caller can safely close them.
Michael Adam [Tue, 30 Sep 2014 07:48:18 +0000 (09:48 +0200)]
s3:messaging: upon receiving fds, dup them so the caller can safely close them.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>