sfrench/samba-autobuild/.git
10 years agoSpelling fixes for nss_wrapper.
Brad Hards [Sun, 21 Feb 2010 05:32:29 +0000 (16:32 +1100)]
Spelling fixes for nss_wrapper.

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
10 years agoSpelling fixes for popt API documentation.
Brad Hards [Sun, 21 Feb 2010 05:31:46 +0000 (16:31 +1100)]
Spelling fixes for popt API documentation.

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
10 years agoSpelling fixes for tevent.
Brad Hards [Sun, 21 Feb 2010 05:31:01 +0000 (16:31 +1100)]
Spelling fixes for tevent.

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
10 years agoSpelling fixes for tdb.
Brad Hards [Sun, 21 Feb 2010 05:07:43 +0000 (16:07 +1100)]
Spelling fixes for tdb.

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
10 years agos4:torture/ldap/basic.c - add some "const"
Matthias Dieter Wallnöfer [Mon, 22 Feb 2010 20:19:27 +0000 (21:19 +0100)]
s4:torture/ldap/basic.c - add some "const"

In addition I removed a "talloc_free(req)" since we never free elsewhere the
requests explicitly and do it only indirectly with freeing the "conn" object
when the testsuite terminates.

10 years agos4:netlogon enhance DsrEnumerateDomainTrusts
Simo Sorce [Sun, 21 Feb 2010 21:07:00 +0000 (16:07 -0500)]
s4:netlogon enhance DsrEnumerateDomainTrusts

Actually return trust relationships by searching the appropriate
entries in the SAM database.
Add checks and return the correct flags, type and attributes.

10 years agos4:operational LDB module - enable support for passing referrals through it
Matthias Dieter Wallnöfer [Sun, 21 Feb 2010 10:55:48 +0000 (11:55 +0100)]
s4:operational LDB module - enable support for passing referrals through it

10 years agos4:partition DSDB module - Cosmetic fixups
Matthias Dieter Wallnöfer [Sat, 20 Feb 2010 19:31:41 +0000 (20:31 +0100)]
s4:partition DSDB module - Cosmetic fixups

10 years agos4:password_hash - Fix up request message pointers
Matthias Dieter Wallnöfer [Tue, 16 Feb 2010 18:48:46 +0000 (19:48 +0100)]
s4:password_hash - Fix up request message pointers

For add requests we need the add request messages, for modify requests we need
the modify request messages.

10 years agos4:dsdb/util.c - Use LDB result constants in some more helper functions
Matthias Dieter Wallnöfer [Wed, 17 Feb 2010 17:24:03 +0000 (18:24 +0100)]
s4:dsdb/util.c - Use LDB result constants in some more helper functions

Always better to rely on the standards rather than on custom results.

10 years agos4:provision.py - try to use other addresses than "127.0.0.x" and "::1"
Matthias Dieter Wallnöfer [Sun, 21 Feb 2010 20:30:42 +0000 (21:30 +0100)]
s4:provision.py - try to use other addresses than "127.0.0.x" and "::1"

On production systems a user for sure strongly disagrees to use local IP
addresses (how should the server be accessible?). Therefore if the user didn't
specify an IP as provision option and in the "/etc/hosts" file we have at
least one not-local IP which resolves to our hostname use this or one of them.

Notice: if a host has more public IP addresses with the same name assigned the
behaviour is non-deterministic (well, okay - by the entries order it is). But
then the user is invited to specify the host IP manually.

This should address bug #5484.

10 years agos4:AD content - Implement the new password settings container
Matthias Dieter Wallnöfer [Sat, 20 Feb 2010 10:17:23 +0000 (11:17 +0100)]
s4:AD content - Implement the new password settings container

10 years agos4:AD content - adequate some revision levels to match Windows Server 2008
Matthias Dieter Wallnöfer [Sat, 20 Feb 2010 10:16:58 +0000 (11:16 +0100)]
s4:AD content - adequate some revision levels to match Windows Server 2008

10 years agos4:AD content - Add the DFSR objects which exist on Windows Server >= 2008
Matthias Dieter Wallnöfer [Sat, 20 Feb 2010 10:15:25 +0000 (11:15 +0100)]
s4:AD content - Add the DFSR objects which exist on Windows Server >= 2008

Those replace the FRS ones.

10 years agos3: Avoid calling cli_alloc_mid twice in cli_smb_req_iov_send
Volker Lendecke [Sun, 21 Feb 2010 19:39:36 +0000 (20:39 +0100)]
s3: Avoid calling cli_alloc_mid twice in cli_smb_req_iov_send

I hate macros....

10 years agocleanup
Simo Sorce [Sat, 20 Feb 2010 19:21:36 +0000 (14:21 -0500)]
cleanup

remove trailing spaces, tabs and blank lines

10 years agos3: Use the status from cli_raw_ioctl in torture_ioctl_test
Volker Lendecke [Sun, 21 Feb 2010 10:41:54 +0000 (11:41 +0100)]
s3: Use the status from cli_raw_ioctl in torture_ioctl_test

10 years agos3: Make string_to_sid survive the LOCAL-string_to_sid test
Volker Lendecke [Sat, 20 Feb 2010 20:32:07 +0000 (21:32 +0100)]
s3: Make string_to_sid survive the LOCAL-string_to_sid test

10 years agos3: Rename LOCAL-dom_sid_parse to LOCAL-string_to_sid, add some tests
Volker Lendecke [Sat, 20 Feb 2010 20:31:16 +0000 (21:31 +0100)]
s3: Rename LOCAL-dom_sid_parse to LOCAL-string_to_sid, add some tests

10 years agos3: Add printf why LOCAL-dom_sid_parse failed
Volker Lendecke [Sat, 20 Feb 2010 20:07:08 +0000 (21:07 +0100)]
s3: Add printf why LOCAL-dom_sid_parse failed

10 years agos3: Slightly simplify the logic of completion_remote_filter
Volker Lendecke [Thu, 18 Feb 2010 21:52:41 +0000 (22:52 +0100)]
s3: Slightly simplify the logic of completion_remote_filter

10 years agos3: Fix some nonempty blank lines
Volker Lendecke [Tue, 16 Feb 2010 21:07:22 +0000 (22:07 +0100)]
s3: Fix some nonempty blank lines

10 years agos3: Remove a "typedef struct"
Volker Lendecke [Mon, 15 Feb 2010 22:53:18 +0000 (23:53 +0100)]
s3: Remove a "typedef struct"

10 years agos3: Fix a typo
Volker Lendecke [Mon, 15 Feb 2010 22:52:51 +0000 (23:52 +0100)]
s3: Fix a typo

10 years agos3: Convert cli_qpathinfo_basic to use cli_trans()
Volker Lendecke [Sun, 7 Feb 2010 13:07:17 +0000 (14:07 +0100)]
s3: Convert cli_qpathinfo_basic to use cli_trans()

10 years agos3: Convert cli_raw_ioctl to use cli_smb()
Volker Lendecke [Sun, 7 Feb 2010 12:36:49 +0000 (13:36 +0100)]
s3: Convert cli_raw_ioctl to use cli_smb()

10 years agos3: Add cli_smb()
Volker Lendecke [Sun, 7 Feb 2010 12:24:41 +0000 (13:24 +0100)]
s3: Add cli_smb()

This is a sync wrapper around cli_smb_send/cli_smb_recv. This is a hack to
speed up converting libsmb/ away from cli_send_smb/cli_receive_smb. Some
routines in libsmb/ are only called in one place in smbtorture for example,
where making it async right now is not worth it. With cli_smb_send/cli_smb_recv
in place, pushing the asynchronosity out one level is "just" boilerplate code
that is easy to do should it become necessary.

10 years agolibrpc/ndr Remove unused macros
Andrew Bartlett [Sat, 20 Feb 2010 00:51:47 +0000 (11:51 +1100)]
librpc/ndr Remove unused macros

Since the change to the way we pull these OIDs from the wire, these
macros are unused.

Andrew Bartlett

10 years agos4:credentials Add hooks to extract a named Kerberos credentials cache
Andrew Bartlett [Sat, 20 Feb 2010 00:44:41 +0000 (11:44 +1100)]
s4:credentials Add hooks to extract a named Kerberos credentials cache

This allows the integration of external tools that can't be linked
into C or python, but need to authenticate as the local machine
account.

The machineaccountccache script demonstrates this, and debugging has
been improved in cli_credentials_set_secrets() by passing back and
error string.

Andrew Bartlett

10 years agos4:lsa open trusted domain also with dns name
Simo Sorce [Fri, 19 Feb 2010 23:09:48 +0000 (18:09 -0500)]
s4:lsa open trusted domain also with dns name

When searching for a trusted domain object to open, search also the DNS Name
attributes for a match. W2K8R2 uses the DNS domain if available.

10 years agoremove trailing tabs and spaces
Simo Sorce [Fri, 19 Feb 2010 22:46:42 +0000 (17:46 -0500)]
remove trailing tabs and spaces

10 years agoSecond part of fix for bug #7159 - client rpc_transport doesn't cope with bad server...
Jeremy Allison [Fri, 19 Feb 2010 22:24:17 +0000 (14:24 -0800)]
Second part of fix for bug #7159 - client rpc_transport doesn't cope with bad server data returns.

If server returns zero on a NP read. Report pipe broken.
Prevents client from looping if it thinks there should be
more data.

Jeremy.

10 years agoFirst part of fix for bug #7159 - client rpc_transport doesn't cope with bad server...
Jeremy Allison [Fri, 19 Feb 2010 22:18:51 +0000 (14:18 -0800)]
First part of fix for bug #7159 - client rpc_transport doesn't cope with bad server data returns.

Ensure that subreq is *always* talloc_free'd in the _done
function, as it has an event timeout attached. If the
read requests look longer than the cli->timeout, then
the timeout fn is called with already freed data.

Jeremy.

10 years agoreadability reformatting
Simo Sorce [Fri, 19 Feb 2010 21:56:45 +0000 (16:56 -0500)]
readability reformatting

stop this function from maiking my eyes bleed

10 years agos4:rpc_server Add a 'if_version' parameter to the bind operation.
Andrew Bartlett [Fri, 19 Feb 2010 07:02:46 +0000 (18:02 +1100)]
s4:rpc_server Add a 'if_version' parameter to the bind operation.

This allows the interface version to be forwarded to the remote server
in the RPC proxy, both in the endpoint lookup and the subsequent bind.

Andrew Bartlett

10 years agolibrpc When sending endpoint mapper requests, include the minor if_version
Andrew Bartlett [Fri, 19 Feb 2010 05:33:45 +0000 (16:33 +1100)]
librpc When sending endpoint mapper requests, include the minor if_version

The minor version (in the upper 16 bits of syntax->if_version) needs
to be pushed as the right hand side of the endpoint mapper floor (the
same floor as the interface UUID and major if_version).

Andrew Bartlett

10 years agos4-smbtorture: more work on devicemode tests.
Günther Deschner [Fri, 19 Feb 2010 14:25:42 +0000 (15:25 +0100)]
s4-smbtorture: more work on devicemode tests.

Guenther

10 years agos4-smbtorture: explain failure conditions in printer device mode tests a little more.
Günther Deschner [Fri, 19 Feb 2010 13:27:31 +0000 (14:27 +0100)]
s4-smbtorture: explain failure conditions in printer device mode tests a little more.

Guenther

10 years agos4-smbtorture: add --option=torture:spoolss_check_size=yes.
Günther Deschner [Fri, 19 Feb 2010 13:25:19 +0000 (14:25 +0100)]
s4-smbtorture: add --option=torture:spoolss_check_size=yes.

This disables the size calculation comparison by default.

Guenther

10 years agos4-smbtorture: print more comments while running SD and DM tests in RPC-SPOOLSS-PRINTER.
Günther Deschner [Fri, 19 Feb 2010 13:14:18 +0000 (14:14 +0100)]
s4-smbtorture: print more comments while running SD and DM tests in RPC-SPOOLSS-PRINTER.

Guenther

10 years agotestprogs: ignore GetJob level 3 and 4 against samba for now.
Günther Deschner [Fri, 19 Feb 2010 09:11:19 +0000 (10:11 +0100)]
testprogs: ignore GetJob level 3 and 4 against samba for now.

Guenther

10 years agolibrpc/ndr: don't overwrite the content in ndr_push_relative_ptr2_end()
Stefan Metzmacher [Fri, 19 Feb 2010 07:11:24 +0000 (08:11 +0100)]
librpc/ndr: don't overwrite the content in ndr_push_relative_ptr2_end()

metze

10 years agos4:selftest Add test for the RPC proxy
Andrew Bartlett [Fri, 19 Feb 2010 04:57:59 +0000 (15:57 +1100)]
s4:selftest Add test for the RPC proxy

10 years agos4:selftest Add infrastructure for testing against an RPC proxy
Andrew Bartlett [Fri, 19 Feb 2010 04:56:30 +0000 (15:56 +1100)]
s4:selftest Add infrastructure for testing against an RPC proxy

This also changes the 'testenv' code to use a new environment 'all'
(we may wish to make other complex tests depend on this in future),
and exports more names in more namespaces.

Andrew Bartlett

10 years agomisc.idl: Add reference to the slightly odd representation of if_version
Andrew Bartlett [Fri, 19 Feb 2010 04:55:28 +0000 (15:55 +1100)]
misc.idl:  Add reference to the slightly odd representation of if_version

I found this confusing, so explian for the next poor programmer who
has to get up to speed with this quickly.

Andrew Bartlett

10 years agos4:rpc_server Record the remote connections association group ID
Andrew Bartlett [Fri, 19 Feb 2010 04:53:31 +0000 (15:53 +1100)]
s4:rpc_server Record the remote connections association group ID

By recording the association group the remote server assigned to our
proxied RPC connection, we can ensure we use the same value when the
client wishes to use it.

This isn't stored in a private pointer, as mapiproxy will want to use
this feature too.

Andrew Bartlett

10 years agos4:winbind Make the 'no SID found' message even more detailed
Andrew Bartlett [Fri, 19 Feb 2010 00:14:15 +0000 (11:14 +1100)]
s4:winbind Make the 'no SID found' message even more detailed

Now we give the user a clue as to what may be wrong, and the file path
that we could not find the domain SID in.

Andrew Bartlett

10 years agoMore fixes for bug #7146 - Samba miss-parses authenticated RPC packets.
Jeremy Allison [Fri, 19 Feb 2010 00:12:04 +0000 (16:12 -0800)]
More fixes for bug #7146 - Samba miss-parses authenticated RPC packets.

Alignment space calculations are tricky :-).

Jeremy.

10 years agos3-spoolss: add support for _spoolss_SetPrinter level 8.
Günther Deschner [Thu, 18 Feb 2010 20:54:45 +0000 (21:54 +0100)]
s3-spoolss: add support for _spoolss_SetPrinter level 8.

Guenther

10 years agonss_wrapper: fix segfault in print_group() in the testsuite
Michael Adam [Thu, 18 Feb 2010 23:33:45 +0000 (00:33 +0100)]
nss_wrapper: fix segfault in print_group() in the testsuite

Running
'TESTS=posix_s3 POSIX_SUBTESTS="RPC-SAMR-LARGE-DC LOCAL-NSS-WRAPPER" make test'
from s3 made smbtorture4 crash on my box.

Michael

10 years agoMore fixes for bug #7146 - Samba miss-parses authenticated RPC packets.
Jeremy Allison [Thu, 18 Feb 2010 23:03:30 +0000 (15:03 -0800)]
More fixes for bug #7146 - Samba miss-parses authenticated RPC packets.

Ensure we calculate the space correctly (including the ss_padding_len)
when constructing reply packets.

Jeremy.

10 years agos4-smbtorture: add LOCAL-NSS-WRAPPER-DUPLICATES test.
Günther Deschner [Thu, 18 Feb 2010 22:23:28 +0000 (23:23 +0100)]
s4-smbtorture: add LOCAL-NSS-WRAPPER-DUPLICATES test.

Guenther

10 years agos4-smbtorture: be more verbose in LOCAL-NSS-WRAPPER.
Günther Deschner [Thu, 18 Feb 2010 22:22:52 +0000 (23:22 +0100)]
s4-smbtorture: be more verbose in LOCAL-NSS-WRAPPER.

Guenther

10 years agos3: optimize strict allocate for XFS on IRIX
Björn Jacke [Thu, 18 Feb 2010 09:01:26 +0000 (10:01 +0100)]
s3: optimize strict allocate for XFS on IRIX

10 years agotestprogs: add tests for GetJob() to spoolss test.
Günther Deschner [Thu, 18 Feb 2010 15:40:20 +0000 (16:40 +0100)]
testprogs: add tests for GetJob() to spoolss test.

Guenther

10 years agoFix bug #7155 - valgrind Conditional jump or move depends on uninitialised value...
Jeremy Allison [Thu, 18 Feb 2010 20:21:10 +0000 (12:21 -0800)]
Fix bug #7155 - valgrind Conditional jump or move depends on uninitialised value(s) error when "mangling method = hash"

The charset array allocated in init_chartest() is allocated
by MALLOC, but only some elements of it being set after allocation. Fix is to
memset to zero after allocation.

Jeremy.

10 years agoFix bug #7154 - mangling method = hash can crash storing a name not containing a '.'
Jeremy Allison [Thu, 18 Feb 2010 19:22:44 +0000 (11:22 -0800)]
Fix bug #7154 - mangling method = hash can crash storing a name not containing a '.'

Fix use of uninitialized variable. This can lead to crashes if
mangling = hash processes names with no '.'.

Jeremy.

10 years agotestprogs: add RPC_S_PROCNUM_OUT_OF_RANGE error.
Günther Deschner [Thu, 18 Feb 2010 13:48:57 +0000 (14:48 +0100)]
testprogs: add RPC_S_PROCNUM_OUT_OF_RANGE error.

Guenther

10 years agospoolss: use ndr_push_spoolss_PrinterInfo2 hand-marshalled version (moves devmode...
Günther Deschner [Sat, 13 Feb 2010 02:45:25 +0000 (03:45 +0100)]
spoolss: use ndr_push_spoolss_PrinterInfo2 hand-marshalled version (moves devmode relative pointer down to sd).

Guenther

10 years agospoolss: add spoolss_security_descriptor.
Günther Deschner [Tue, 16 Feb 2010 01:48:01 +0000 (02:48 +0100)]
spoolss: add spoolss_security_descriptor.

Guenther

10 years agos3: re-run make samba3-idl.
Günther Deschner [Tue, 9 Feb 2010 15:47:32 +0000 (16:47 +0100)]
s3: re-run make samba3-idl.

Guenther

10 years agosecurity: make two bitmaps public.
Günther Deschner [Tue, 16 Feb 2010 09:46:07 +0000 (10:46 +0100)]
security: make two bitmaps public.

Guenther

10 years agospoolss: make two bitmaps public.
Günther Deschner [Sat, 13 Feb 2010 03:27:05 +0000 (04:27 +0100)]
spoolss: make two bitmaps public.

Guenther

10 years agospoolss: make all security descriptors and devicemodes 4 byte aligned and add missing...
Stefan Metzmacher [Thu, 18 Feb 2010 14:36:08 +0000 (15:36 +0100)]
spoolss: make all security descriptors and devicemodes 4 byte aligned and add missing subcontexts.

Guenther

10 years agospoolss: set NDR_RELATIVE_REVERSE flag for various unions that have relative pointers.
Günther Deschner [Mon, 14 Dec 2009 16:22:39 +0000 (17:22 +0100)]
spoolss: set NDR_RELATIVE_REVERSE flag for various unions that have relative pointers.

Guenther

10 years agondr_spoolss_buf: use LIBNDR_FLAG_NO_NDR_SIZE in NDR_SPOOLSS_SIZE_*
Stefan Metzmacher [Thu, 18 Feb 2010 14:17:42 +0000 (15:17 +0100)]
ndr_spoolss_buf: use LIBNDR_FLAG_NO_NDR_SIZE in NDR_SPOOLSS_SIZE_*

metze

10 years agospoolss: use subcontext in NDR_SPOOLSS_PUSH_ENUM_OUT macro.
Stefan Metzmacher [Wed, 23 Dec 2009 14:52:39 +0000 (15:52 +0100)]
spoolss: use subcontext in NDR_SPOOLSS_PUSH_ENUM_OUT macro.

metze

10 years agolibndr: fix ndr_size_* calculation with relative reverse buffers
Stefan Metzmacher [Thu, 18 Feb 2010 14:13:20 +0000 (15:13 +0100)]
libndr: fix ndr_size_* calculation with relative reverse buffers

metze

10 years agolibndr: for now align reverse relative pointers to 2 bytes by default.
Stefan Metzmacher [Thu, 18 Feb 2010 12:40:44 +0000 (13:40 +0100)]
libndr: for now align reverse relative pointers to 2 bytes by default.

This is just a hack and we should let the callers use FLAG_ALIGN2
explicit in future.

metze

10 years agolibndr: implement LIBNDR_RELATIVE_REVERSE handling
Stefan Metzmacher [Wed, 17 Feb 2010 20:24:40 +0000 (21:24 +0100)]
libndr: implement LIBNDR_RELATIVE_REVERSE handling

This is based on Guenther's initial code.

metze

10 years agolibndr: store a subcontext buffer size in ndr_push_subcontext_start.
Günther Deschner [Mon, 14 Dec 2009 14:33:32 +0000 (15:33 +0100)]
libndr: store a subcontext buffer size in ndr_push_subcontext_start.

Guenther

10 years agolibndr: give an error when ndr_push_relative_ptr2_start()/_end() is used with the...
Stefan Metzmacher [Wed, 17 Feb 2010 19:27:08 +0000 (20:27 +0100)]
libndr: give an error when ndr_push_relative_ptr2_start()/_end() is used with the RELATIVE_REVERSE flag

metze

10 years agolibndr: add LIBNDR_FLAG_NO_RELATIVE_REVERSE so that relative reverse processing
Günther Deschner [Tue, 9 Feb 2010 17:27:37 +0000 (18:27 +0100)]
libndr: add LIBNDR_FLAG_NO_RELATIVE_REVERSE so that relative reverse processing
can be disabled for single structure elements.

Guenther

10 years agolibndr: add LIBNDR_FLAG_RELATIVE_REVERSE flag.
Günther Deschner [Mon, 14 Dec 2009 14:09:00 +0000 (15:09 +0100)]
libndr: add LIBNDR_FLAG_RELATIVE_REVERSE flag.

Guenther

10 years agolibndr: change subcontext buffer allocation to allocate on subcontext_start.
Günther Deschner [Wed, 16 Dec 2009 21:54:02 +0000 (22:54 +0100)]
libndr: change subcontext buffer allocation to allocate on subcontext_start.

Guenther

10 years agolibrpc/ndr: make ndr_push_relative_ptr2() static
Stefan Metzmacher [Wed, 17 Feb 2010 19:00:36 +0000 (20:00 +0100)]
librpc/ndr: make ndr_push_relative_ptr2() static

metze

10 years agolibrpc/ndr_krb5pac: use ndr_push_relative_ptr2_start()/_end()
Stefan Metzmacher [Wed, 17 Feb 2010 19:00:04 +0000 (20:00 +0100)]
librpc/ndr_krb5pac: use ndr_push_relative_ptr2_start()/_end()

metze

10 years agolibrpc/ndr_drsblobs: use ndr_push_relative_ptr2_start()/_end()
Stefan Metzmacher [Wed, 17 Feb 2010 18:59:19 +0000 (19:59 +0100)]
librpc/ndr_drsblobs: use ndr_push_relative_ptr2_start()/_end()

metze

10 years agospoolss: fix relative pointers in ndr_push_spoolss_DriverInfo101.
Günther Deschner [Thu, 11 Feb 2010 17:54:31 +0000 (18:54 +0100)]
spoolss: fix relative pointers in ndr_push_spoolss_DriverInfo101.

Guenther

10 years agos3: re-run make full_idl.
Günther Deschner [Mon, 14 Dec 2009 13:17:05 +0000 (14:17 +0100)]
s3: re-run make full_idl.

Guenther

10 years agopidl: use ndr_push_relative_ptr2_start and ndr_push_relative_ptr2_end.
Günther Deschner [Mon, 14 Dec 2009 13:09:22 +0000 (14:09 +0100)]
pidl: use ndr_push_relative_ptr2_start and ndr_push_relative_ptr2_end.

Guenther

10 years agolibndr: add ndr_push_relative_ptr2_start and ndr_push_relative_ptr2_end.
Günther Deschner [Mon, 14 Dec 2009 13:08:34 +0000 (14:08 +0100)]
libndr: add ndr_push_relative_ptr2_start and ndr_push_relative_ptr2_end.

Guenther

10 years agos3-docs: Remove trailing whitespaces and fix a typo.
Karolin Seeger [Thu, 18 Feb 2010 12:10:21 +0000 (13:10 +0100)]
s3-docs: Remove trailing whitespaces and fix a typo.

Karolin

10 years agos3:docs: add some advice for usage of strict allocate
Björn Jacke [Wed, 17 Feb 2010 22:03:32 +0000 (23:03 +0100)]
s3:docs: add some advice for usage of strict allocate

10 years agos3-spoolss: Fix _spoolss_EnumPrinters servername handling.
Günther Deschner [Thu, 18 Feb 2010 11:40:00 +0000 (12:40 +0100)]
s3-spoolss: Fix _spoolss_EnumPrinters servername handling.

Guenther

10 years agos3-selftest: fix return code for modprinter.pl -a.
Günther Deschner [Thu, 18 Feb 2010 10:20:49 +0000 (11:20 +0100)]
s3-selftest: fix return code for modprinter.pl -a.

Background is: the SetPrinter level 2 calls "addprinter command" an fails if a
share already existed (and the addprinter command returned a non-0 return code).
Removing the non-0 return code is fine, as in AddPrinter{Ex}, we have checks to
see if a share already exists before calling out the addprinter command.

Maybe one day, we need to have a "changeprinter command"...

Guenther

10 years agotsocket/bsd: fix comment in tdgram_bsd_recvfrom_handler()
Stefan Metzmacher [Wed, 17 Feb 2010 18:11:11 +0000 (19:11 +0100)]
tsocket/bsd: fix comment in tdgram_bsd_recvfrom_handler()

metze

10 years agoRevert "Got back to 16-byte padding on auth RPC. S3 clients and servers now cope...
Jeremy Allison [Thu, 18 Feb 2010 03:42:49 +0000 (19:42 -0800)]
Revert "Got back to 16-byte padding on auth RPC. S3 clients and servers now cope with this. Jeremy"

This reverts commit 38c50c7027d2a2a9a3df060b74b2a2efce4d9e6f.

As tridge requested, we need this to work with older S3
servers, not just for smbtorture4.

Jeremy.

10 years agos3-selftest: finally enable RPC-SPOOLSS-PRINTER against Samba 3.
Günther Deschner [Thu, 18 Feb 2010 01:17:01 +0000 (02:17 +0100)]
s3-selftest: finally enable RPC-SPOOLSS-PRINTER against Samba 3.

Guenther

10 years agos3-selftest: include addprinter/deleteprinter command.
Günther Deschner [Wed, 17 Feb 2010 23:48:58 +0000 (00:48 +0100)]
s3-selftest: include addprinter/deleteprinter command.

Guenther

10 years agos3-spoolss: fix return code of spoolss_DeletePrinter.
Günther Deschner [Thu, 18 Feb 2010 01:14:26 +0000 (02:14 +0100)]
s3-spoolss: fix return code of spoolss_DeletePrinter.

When the printer has been removed by the "deleteprinter command", we need to
check if it is still there and then fail, not fail if we successfully removed
it (found by RPC-SPOOLSS-PRINTER).

Guenther

10 years agos3-spoolss: in spoolss_EnumPrinters r->in.server is a *unique* pointer!
Günther Deschner [Thu, 18 Feb 2010 01:03:53 +0000 (02:03 +0100)]
s3-spoolss: in spoolss_EnumPrinters r->in.server is a *unique* pointer!

Guenther

10 years agos3-spoolss: more AddPrinter{Ex} checks.
Günther Deschner [Thu, 18 Feb 2010 00:58:56 +0000 (01:58 +0100)]
s3-spoolss: more AddPrinter{Ex} checks.

Windows will allow to add a non-shared printer that is returned by EnumPrinters.
Samba has no notion of non-shared local printers yet, so just make sure to
behave like we do elsewhere: a printer autoloaded by samba or added to samba is
shared.

Guenther

10 years agos3-spoolss: add some printer info validation for AddPrinter calls.
Günther Deschner [Tue, 14 Jul 2009 12:34:30 +0000 (14:34 +0200)]
s3-spoolss: add some printer info validation for AddPrinter calls.

Guenther

10 years agotestprogs: print SDDL string of printer security descriptors
Günther Deschner [Tue, 16 Feb 2010 15:21:02 +0000 (16:21 +0100)]
testprogs: print SDDL string of printer security descriptors

10 years agos3-modules: fix get_acl_blob in the acl_tdb VFS module.
Günther Deschner [Thu, 18 Feb 2010 01:13:07 +0000 (02:13 +0100)]
s3-modules: fix get_acl_blob in the acl_tdb VFS module.

Shuttle-reviewed by jra :)

Guenther

10 years agos4-smbtorture: skip printer info cross tests against samba 3 for now.
Günther Deschner [Thu, 18 Feb 2010 00:45:06 +0000 (01:45 +0100)]
s4-smbtorture: skip printer info cross tests against samba 3 for now.

Not even w2k8r2 passes them atm.

Guenther

10 years agos4-smbtorture: try more combinations to find printers in test_EnumPrinters_findname().
Günther Deschner [Thu, 18 Feb 2010 00:43:08 +0000 (01:43 +0100)]
s4-smbtorture: try more combinations to find printers in test_EnumPrinters_findname().

Also take a note of servers returning full UNC printer paths although we did not
set the servername.

Guenther

10 years agos4-smbtorture: simplify test_PrinterInfo_DevMode a bit.
Günther Deschner [Thu, 18 Feb 2010 00:41:46 +0000 (01:41 +0100)]
s4-smbtorture: simplify test_PrinterInfo_DevMode a bit.

Guenther

10 years agos4-smbtorture: avoid potential loop while adding a new printer in RPC-SPOOLSS-PRINTER.
Günther Deschner [Wed, 17 Feb 2010 19:45:26 +0000 (20:45 +0100)]
s4-smbtorture: avoid potential loop while adding a new printer in RPC-SPOOLSS-PRINTER.

Guenther