sfrench/samba-autobuild/.git
3 years agotests/dbcheck: Add a test for two live objects, with a dangling forward link
Garming Sam [Wed, 22 Feb 2017 04:43:21 +0000 (17:43 +1300)]
tests/dbcheck: Add a test for two live objects, with a dangling forward link

Handling backlinks appears to be rather non-deterministic, so the
forward link hangs off of the RODC replication group (which has no other
valid forward links). In other situations, it either won't delete the
memberOf, or the expected output order will vary.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12600

3 years agotests/dbcheck: Add a test for two live objects, with a dangling backlink
Garming Sam [Wed, 22 Feb 2017 02:43:34 +0000 (15:43 +1300)]
tests/dbcheck: Add a test for two live objects, with a dangling backlink

Adds dbcheck 4.5.0pre1 to the knownfail, to be removed later.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12600

3 years agos3:winbind: work around coverity false positive.
Jeremy Allison [Thu, 23 Feb 2017 17:41:03 +0000 (09:41 -0800)]
s3:winbind: work around coverity false positive.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Feb 23 23:54:48 CET 2017 on sn-devel-144

3 years agoctdb: Fix posible NULL deref in logging_init()
Andreas Schneider [Thu, 16 Feb 2017 16:38:41 +0000 (17:38 +0100)]
ctdb: Fix posible NULL deref in logging_init()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12592

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agobuild: Fix generation of CTDB manpages while creating tarball
Amitay Isaacs [Tue, 21 Feb 2017 11:33:48 +0000 (22:33 +1100)]
build: Fix generation of CTDB manpages while creating tarball

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12595

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Thu Feb 23 19:25:11 CET 2017 on sn-devel-144

3 years agoctdb-build: Add make target for generating manpages
Amitay Isaacs [Tue, 21 Feb 2017 11:44:10 +0000 (22:44 +1100)]
ctdb-build: Add make target for generating manpages

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12595

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
3 years agoctdb-build: Split dist() target to generate manpages separately
Amitay Isaacs [Tue, 21 Feb 2017 11:30:30 +0000 (22:30 +1100)]
ctdb-build: Split dist() target to generate manpages separately

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12595

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
3 years agorepl_meta_data: Clarify that replmd_private->la_list is only for DRS for replication
Andrew Bartlett [Wed, 22 Feb 2017 22:02:07 +0000 (11:02 +1300)]
repl_meta_data: Clarify that replmd_private->la_list is only for DRS for replication

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Feb 23 15:30:35 CET 2017 on sn-devel-144

3 years agosamba-tool drs replicate: Add --single-object
Andrew Bartlett [Thu, 23 Feb 2017 00:00:19 +0000 (13:00 +1300)]
samba-tool drs replicate: Add --single-object

This may help when an object has been incorrectly locally removed from the NC
or there is an urgent need to replicate a specific object (say when full
replication is inoperable).

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agopython: Move partial replication logic into drs_utils.py
Andrew Bartlett [Fri, 17 Feb 2017 05:22:19 +0000 (18:22 +1300)]
python: Move partial replication logic into drs_utils.py

This allows us to use this easily from join.py soon

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agopython: Move dnsserver helper functions into samba.dnsserver
Andrew Bartlett [Fri, 17 Feb 2017 05:21:33 +0000 (18:21 +1300)]
python: Move dnsserver helper functions into samba.dnsserver

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agocoverity: Add modeling file for Coverity scan
Andreas Schneider [Thu, 16 Feb 2017 16:31:20 +0000 (17:31 +0100)]
coverity: Add modeling file for Coverity scan

The modeling file has currently all macros for cmocka that Coverity
doesn't detect false positives. We could add torture assert macros if
needed too.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Feb 23 07:11:18 CET 2017 on sn-devel-144

3 years agos3:librpc: Fix OM_uint32 comparsion in if-clause
Andreas Schneider [Fri, 17 Feb 2017 08:49:39 +0000 (09:49 +0100)]
s3:librpc: Fix OM_uint32 comparsion in if-clause

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12592

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agos3:librpc: Make sure kt_curser and kt_entry are initialized
Andreas Schneider [Thu, 16 Feb 2017 16:42:53 +0000 (17:42 +0100)]
s3:librpc: Make sure kt_curser and kt_entry are initialized

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12592

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agopam_winbind: Return if we do not have a domain
Andreas Schneider [Fri, 17 Feb 2017 10:53:52 +0000 (11:53 +0100)]
pam_winbind: Return if we do not have a domain

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12592

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agos3:lib: Do not segfault if username is NULL
Andreas Schneider [Fri, 17 Feb 2017 09:08:17 +0000 (10:08 +0100)]
s3:lib: Do not segfault if username is NULL

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12592

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agos3:torture: Fix uint64_t comparsion in if-clause
Andreas Schneider [Fri, 17 Feb 2017 08:45:33 +0000 (09:45 +0100)]
s3:torture: Fix uint64_t comparsion in if-clause

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12592

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agos4:torture: Make sure handles are initialized
Andreas Schneider [Thu, 16 Feb 2017 16:52:41 +0000 (17:52 +0100)]
s4:torture: Make sure handles are initialized

The CHECK_STATUS macro might goto done which checks the values of the
handle so they should be initialized in this case.

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12592

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agondrdump: Fix a possible NULL pointer dereference
Andreas Schneider [Thu, 16 Feb 2017 16:34:07 +0000 (17:34 +0100)]
ndrdump: Fix a possible NULL pointer dereference

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12592

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agos3-vfs: Do not deref a NULL pointer in shadow_copy2_snapshot_to_gmt()
Andreas Schneider [Thu, 16 Feb 2017 16:15:38 +0000 (17:15 +0100)]
s3-vfs: Do not deref a NULL pointer in shadow_copy2_snapshot_to_gmt()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12592

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agos4-kcc: Do not dereference a NULL pointer
Andreas Schneider [Thu, 16 Feb 2017 16:08:50 +0000 (17:08 +0100)]
s4-kcc: Do not dereference a NULL pointer

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12592

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agos4-torture: Use the correct variable type in torture_smb2_maxfid()
Andreas Schneider [Thu, 16 Feb 2017 16:07:54 +0000 (17:07 +0100)]
s4-torture: Use the correct variable type in torture_smb2_maxfid()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12592

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agowinbind: Use EnumDomainUsers in rpc_query_user_list
Volker Lendecke [Sat, 11 Feb 2017 08:34:17 +0000 (09:34 +0100)]
winbind: Use EnumDomainUsers in rpc_query_user_list

We changed the parent->child enumusers call so that we only return the
users' RIDs. QueryDisplayInfo tends to return a lot more info which we
throw away. This also aligns the code with the other rpc enumerating
functions.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Feb 23 03:17:41 CET 2017 on sn-devel-144

3 years agofix spelling of 'unchangeable'
Edward Betts [Thu, 26 Jan 2017 21:41:12 +0000 (21:41 +0000)]
fix spelling of 'unchangeable'

Signed-off-by: Edward Betts <edward@4angle.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Wed Feb 22 12:21:51 CET 2017 on sn-devel-144

3 years agoCorrect "Openened" typos.
Chris Lamb [Fri, 17 Feb 2017 20:02:23 +0000 (09:02 +1300)]
Correct "Openened" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "allready" typos.
Chris Lamb [Fri, 17 Feb 2017 20:02:09 +0000 (09:02 +1300)]
Correct "allready" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "heirarchy" typos.
Chris Lamb [Fri, 17 Feb 2017 20:01:58 +0000 (09:01 +1300)]
Correct "heirarchy" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "incluing" typos.
Chris Lamb [Fri, 17 Feb 2017 20:01:50 +0000 (09:01 +1300)]
Correct "incluing" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "initialze" typos.
Chris Lamb [Fri, 17 Feb 2017 20:01:22 +0000 (09:01 +1300)]
Correct "initialze" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "succeded" typos.
Chris Lamb [Fri, 17 Feb 2017 20:01:10 +0000 (09:01 +1300)]
Correct "succeded" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "hexidecimal" typos.
Chris Lamb [Fri, 17 Feb 2017 20:00:52 +0000 (09:00 +1300)]
Correct "hexidecimal" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "updateing" typos.
Chris Lamb [Fri, 17 Feb 2017 20:00:39 +0000 (09:00 +1300)]
Correct "updateing" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "unavaible" typos.
Chris Lamb [Fri, 17 Feb 2017 20:00:31 +0000 (09:00 +1300)]
Correct "unavaible" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "allignment" typos.
Chris Lamb [Fri, 17 Feb 2017 20:00:26 +0000 (09:00 +1300)]
Correct "allignment" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "paramaters" typos.
Chris Lamb [Fri, 17 Feb 2017 20:00:21 +0000 (09:00 +1300)]
Correct "paramaters" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "explicity" typos.
Chris Lamb [Fri, 17 Feb 2017 20:00:16 +0000 (09:00 +1300)]
Correct "explicity" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "encyption" typos.
Chris Lamb [Fri, 17 Feb 2017 20:00:10 +0000 (09:00 +1300)]
Correct "encyption" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "relase" typos.
Chris Lamb [Fri, 17 Feb 2017 20:00:05 +0000 (09:00 +1300)]
Correct "relase" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "intialise" typos.
Chris Lamb [Fri, 17 Feb 2017 19:59:59 +0000 (08:59 +1300)]
Correct "intialise" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "cleint" typos.
Chris Lamb [Fri, 17 Feb 2017 19:59:54 +0000 (08:59 +1300)]
Correct "cleint" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "somthing" typos.
Chris Lamb [Fri, 17 Feb 2017 19:59:42 +0000 (08:59 +1300)]
Correct "somthing" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "defered" typos.
Chris Lamb [Fri, 17 Feb 2017 19:59:36 +0000 (08:59 +1300)]
Correct "defered" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "specifiy" typos.
Chris Lamb [Fri, 17 Feb 2017 19:59:19 +0000 (08:59 +1300)]
Correct "specifiy" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "notifiying" typos.
Chris Lamb [Fri, 17 Feb 2017 19:59:08 +0000 (08:59 +1300)]
Correct "notifiying" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "seperate" typos.
Chris Lamb [Fri, 17 Feb 2017 19:57:55 +0000 (08:57 +1300)]
Correct "seperate" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "follwing" typos.
Chris Lamb [Fri, 17 Feb 2017 19:56:47 +0000 (08:56 +1300)]
Correct "follwing" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "existence" typos.
Chris Lamb [Fri, 17 Feb 2017 19:56:18 +0000 (08:56 +1300)]
Correct "existence" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "formated" typos.
Chris Lamb [Fri, 17 Feb 2017 19:54:58 +0000 (08:54 +1300)]
Correct "formated" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "descriptior" typos.
Chris Lamb [Fri, 17 Feb 2017 19:54:26 +0000 (08:54 +1300)]
Correct "descriptior" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "perfom" typos.
Chris Lamb [Fri, 17 Feb 2017 19:53:39 +0000 (08:53 +1300)]
Correct "perfom" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "coult" typo.
Chris Lamb [Fri, 17 Feb 2017 19:52:38 +0000 (08:52 +1300)]
Correct "coult" typo.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "errror" typos.
Chris Lamb [Fri, 17 Feb 2017 19:52:09 +0000 (08:52 +1300)]
Correct "errror" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "successfuly" typos.
Chris Lamb [Fri, 17 Feb 2017 19:51:29 +0000 (08:51 +1300)]
Correct "successfuly" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "enought" typo.
Chris Lamb [Fri, 17 Feb 2017 19:50:45 +0000 (08:50 +1300)]
Correct "enought" typo.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "extention" typos.
Chris Lamb [Fri, 17 Feb 2017 19:50:20 +0000 (08:50 +1300)]
Correct "extention" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "Controler" typos.
Chris Lamb [Fri, 17 Feb 2017 19:49:06 +0000 (08:49 +1300)]
Correct "Controler" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "acheive" typos.
Chris Lamb [Fri, 17 Feb 2017 19:48:31 +0000 (08:48 +1300)]
Correct "acheive" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "paramter" typos.
Chris Lamb [Fri, 17 Feb 2017 19:47:55 +0000 (08:47 +1300)]
Correct "paramter" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "overriden" typos.
Chris Lamb [Fri, 17 Feb 2017 19:47:12 +0000 (08:47 +1300)]
Correct "overriden" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "occured" typos.
Chris Lamb [Fri, 17 Feb 2017 19:46:28 +0000 (08:46 +1300)]
Correct "occured" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "supressed" typo.
Chris Lamb [Fri, 17 Feb 2017 09:51:52 +0000 (22:51 +1300)]
Correct "supressed" typo.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "recived" typo.
Chris Lamb [Fri, 17 Feb 2017 09:50:54 +0000 (22:50 +1300)]
Correct "recived" typo.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "progess" typo.
Chris Lamb [Fri, 17 Feb 2017 09:50:24 +0000 (22:50 +1300)]
Correct "progess" typo.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "emty" typo.
Chris Lamb [Fri, 17 Feb 2017 09:49:57 +0000 (22:49 +1300)]
Correct "emty" typo.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoCorrect "doesnt" typos.
Chris Lamb [Fri, 17 Feb 2017 09:49:29 +0000 (22:49 +1300)]
Correct "doesnt" typos.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agovfs_streams_xattr: use fsp, not base_fsp
Ralph Boehme [Fri, 17 Feb 2017 07:10:53 +0000 (08:10 +0100)]
vfs_streams_xattr: use fsp, not base_fsp

The base_fsp's fd is always -1 as it's closed after being openend in
create_file_unixpath().

Additionally in streams_xattr_open force using of SMB_VFS_FSETXATTR() by
sticking the just created fd into the fsp (and removing it afterwards).

Bug: https://bugzilla.samba.org/show_bug.cgi?id=12591

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Feb 22 08:25:46 CET 2017 on sn-devel-144

3 years agoldbedit: Prevent the use of the reveal internals control
Garming Sam [Sun, 29 Jan 2017 22:08:07 +0000 (11:08 +1300)]
ldbedit: Prevent the use of the reveal internals control

This is almost certainly not what you want to do. Providing the output of reveal as the input of modify
will necessarily revivify all dead linked attributes (regardless of --extended-dn or not).

This is extremely unexpected behaviour, so we prevent this from happening.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12596

Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Wed Feb 22 04:23:05 CET 2017 on sn-devel-144

3 years agotalloc: fix TALLOC_VERSION_* mismatch detection
Stefan Metzmacher [Tue, 14 Feb 2017 11:33:32 +0000 (12:33 +0100)]
talloc: fix TALLOC_VERSION_* mismatch detection

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Feb 22 00:14:34 CET 2017 on sn-devel-144

3 years agoscript/autobuild.py: ignore missing test_tmpdir
Stefan Metzmacher [Tue, 21 Feb 2017 16:05:08 +0000 (17:05 +0100)]
script/autobuild.py: ignore missing test_tmpdir

It is still unknown what removes it...

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agokrb5_wrap: use our own code to calculate the ENCTYPE_ARCFOUR_HMAC key
Stefan Metzmacher [Tue, 21 Feb 2017 11:15:07 +0000 (12:15 +0100)]
krb5_wrap: use our own code to calculate the ENCTYPE_ARCFOUR_HMAC key

Our own convert_string_talloc() function handles a wider range
of unicode code points than the MIT krb5 or heimdal code.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph B√∂hme <slow@samba.org>
Autobuild-Date(master): Tue Feb 21 20:08:16 CET 2017 on sn-devel-144

3 years agos4:scripting: use generate_random_machine_password() for machine passwords
Stefan Metzmacher [Mon, 13 Feb 2017 18:37:09 +0000 (19:37 +0100)]
s4:scripting: use generate_random_machine_password() for machine passwords

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agosamba-tool:provision: use generate_random_machine_password() for machine passwords
Stefan Metzmacher [Tue, 23 Aug 2016 10:40:24 +0000 (12:40 +0200)]
samba-tool:provision: use generate_random_machine_password() for machine passwords

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agosamba-tool:domain: use generate_random_machine_password() for machine passwords
Stefan Metzmacher [Tue, 23 Aug 2016 10:37:37 +0000 (12:37 +0200)]
samba-tool:domain: use generate_random_machine_password() for machine passwords

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agosamba-tool:domain: use generate_random_machine_password() for trusted domains
Stefan Metzmacher [Tue, 23 Aug 2016 10:27:19 +0000 (12:27 +0200)]
samba-tool:domain: use generate_random_machine_password() for trusted domains

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agopyglue: add generate_random_machine_password() wrapper
Stefan Metzmacher [Tue, 23 Aug 2016 07:35:50 +0000 (09:35 +0200)]
pyglue: add generate_random_machine_password() wrapper

We use PyUnicode_FromString() (which is available from 2.6)
because we really have non-ascii strings.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agopython/samba: use an explicit .encode('utf-8') where we expect utf8 passwords
Stefan Metzmacher [Mon, 13 Feb 2017 21:34:06 +0000 (22:34 +0100)]
python/samba: use an explicit .encode('utf-8') where we expect utf8 passwords

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agopython/samba: provision_dns_add_samba.ldif expects utf-16-le passwords
Stefan Metzmacher [Thu, 16 Feb 2017 23:10:12 +0000 (00:10 +0100)]
python/samba: provision_dns_add_samba.ldif expects utf-16-le passwords

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agos4:dsdb: autogenerate a random utf16 buffer for krbtgt password resets.
Stefan Metzmacher [Mon, 13 Feb 2017 18:01:21 +0000 (19:01 +0100)]
s4:dsdb: autogenerate a random utf16 buffer for krbtgt password resets.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agos4:libnet: make use of generate_random_machine_password()
Stefan Metzmacher [Mon, 13 Feb 2017 18:35:54 +0000 (19:35 +0100)]
s4:libnet: make use of generate_random_machine_password()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
3 years agos4:libcli/raw: remove unused DEFAULT_TRUST_ACCOUNT_PASSWORD_LENGTH
Stefan Metzmacher [Tue, 23 Aug 2016 10:41:48 +0000 (12:41 +0200)]
s4:libcli/raw: remove unused DEFAULT_TRUST_ACCOUNT_PASSWORD_LENGTH

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agos3:include: remove unused DEFAULT_TRUST_ACCOUNT_PASSWORD_LENGTH
Stefan Metzmacher [Tue, 23 Aug 2016 10:41:48 +0000 (12:41 +0200)]
s3:include: remove unused DEFAULT_TRUST_ACCOUNT_PASSWORD_LENGTH

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agos3:net_rpc_trust: make use of trust_pw_new_value()
Stefan Metzmacher [Tue, 23 Aug 2016 08:42:30 +0000 (10:42 +0200)]
s3:net_rpc_trust: make use of trust_pw_new_value()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agos3:libnet_join: make use of trust_pw_new_value()
Stefan Metzmacher [Tue, 23 Aug 2016 10:09:57 +0000 (12:09 +0200)]
s3:libnet_join: make use of trust_pw_new_value()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agos3:libads: use trust_pw_new_value() for krb5 machine passwords
Stefan Metzmacher [Tue, 23 Aug 2016 08:38:58 +0000 (10:38 +0200)]
s3:libads: use trust_pw_new_value() for krb5 machine passwords

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agos3:libsmb: use trust_pw_new_value() in trust_pw_change()
Stefan Metzmacher [Tue, 23 Aug 2016 10:12:35 +0000 (12:12 +0200)]
s3:libsmb: use trust_pw_new_value() in trust_pw_change()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agos3:libsmb: add trust_pw_new_value() helper function
Stefan Metzmacher [Tue, 23 Aug 2016 10:12:35 +0000 (12:12 +0200)]
s3:libsmb: add trust_pw_new_value() helper function

This generates a new trust password based on the secure channel type
and lp_security().

NT4 really has a limit of 28 UTF16 bytes.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agos3:libsmb: let trust_pw_change() verify the new password at the end.
Stefan Metzmacher [Thu, 9 Feb 2017 21:53:52 +0000 (22:53 +0100)]
s3:libsmb: let trust_pw_change() verify the new password at the end.

We should notice problems as early as possible, it makes no
sense to keep things working for a while and later find out
the we lost our trust relationship with our domain.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agos3:libsmb: let trust_pw_change() debug more verbose information
Stefan Metzmacher [Wed, 18 Jan 2017 18:57:30 +0000 (19:57 +0100)]
s3:libsmb: let trust_pw_change() debug more verbose information

Password changes caused much trouble in the past, so we better debug
them at log level 0 and may see them also in the syslog.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agolib/util: add generate_random_machine_password() function
Stefan Metzmacher [Tue, 23 Aug 2016 07:30:05 +0000 (09:30 +0200)]
lib/util: add generate_random_machine_password() function

It generates more random password for the use as machine password,
restricted to codepoints <= 0xFFFF in order to be compatible
with MIT krb5 and Heimdal.

Note: the fallback to ascii if 'unix charset' is not 'utf8'.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agolibcli/auth: add netlogon_creds_cli_debug_string()
Stefan Metzmacher [Thu, 9 Feb 2017 20:47:52 +0000 (21:47 +0100)]
libcli/auth: add netlogon_creds_cli_debug_string()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agolibcli/auth: check E_md4hash() result in netlogon_creds_cli_ServerPasswordSet_send()
Stefan Metzmacher [Wed, 18 Jan 2017 19:02:21 +0000 (19:02 +0000)]
libcli/auth: check E_md4hash() result in netlogon_creds_cli_ServerPasswordSet_send()

We need to make sure we can convert the given string to an nthash.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agolibcli/auth: use the correct creds value against servers without LogonSamLogonEx
Stefan Metzmacher [Wed, 15 Feb 2017 07:58:20 +0000 (08:58 +0100)]
libcli/auth: use the correct creds value against servers without LogonSamLogonEx

If we use the credential chain we need to use the value from
netlogon_creds_client_authenticator() to make sure we have the current
value to encrypt in logon info.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12586

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agos3:winbindd: make sure cm_prepare_connection() only returns OK with a valid tree...
Stefan Metzmacher [Tue, 31 Jan 2017 14:19:00 +0000 (15:19 +0100)]
s3:winbindd: make sure cm_prepare_connection() only returns OK with a valid tree connect

If cm_get_ipc_credentials() returned anonymous creds and signing is required
we were returning the result of cm_get_ipc_credentials() instead of
the original error.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12588

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agolibrpc/rpc: fix regression in NT_STATUS_RPC_ENUM_VALUE_OUT_OF_RANGE error mapping
Stefan Metzmacher [Wed, 15 Feb 2017 07:07:06 +0000 (08:07 +0100)]
librpc/rpc: fix regression in NT_STATUS_RPC_ENUM_VALUE_OUT_OF_RANGE error mapping

Commit 1eef70872930fa4f9d3dedd23476b34cae638428 changed the mapping for
DCERPC_NCA_S_FAULT_INVALID_TAG from NT_STATUS_RPC_ENUM_VALUE_OUT_OF_RANGE
to NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12585

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agobuild:wafsamba: Remove ambiguous 'if x in conf.env' constructs
Thomas Nagy [Sat, 26 Mar 2016 13:35:52 +0000 (14:35 +0100)]
build:wafsamba: Remove ambiguous 'if x in conf.env' constructs

Configuration values such as HAVE_STDDEF_H can be set to 0
to indicate a test failure. Waf 1.5 has a few bugs that
prevent configuration tests from setting such values
consistently on failures.

Consequently, conditions such as 'if conf.env.VARNAME' must be
used to indicate that config test successes are expected.
Note that conf.env.VARNAME always returns an empty list (False value)
when no variable is defined so there are no risk of raising
AttributeError/KeyError exceptions.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
Autobuild-User(master): Uri Simchoni <uri@samba.org>
Autobuild-Date(master): Tue Feb 21 13:47:07 CET 2017 on sn-devel-144

3 years agoAdd missing import of sys in ms_schema.py
Andrej [Thu, 19 Jan 2017 15:24:34 +0000 (16:24 +0100)]
Add missing import of sys in ms_schema.py

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
3 years agodocs: Fix typo in man smb.conf.
Karolin Seeger [Mon, 20 Feb 2017 08:35:26 +0000 (09:35 +0100)]
docs: Fix typo in man smb.conf.

charactar -> character

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Feb 20 15:30:29 CET 2017 on sn-devel-144

3 years agoctdb: Do not leak fd handle in control_restoredb()
Andreas Schneider [Thu, 16 Feb 2017 15:55:35 +0000 (16:55 +0100)]
ctdb: Do not leak fd handle in control_restoredb()

Found by covscan.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12592

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Feb 17 18:43:16 CET 2017 on sn-devel-144

3 years agoctdb-daemon: Use sock_clean() to remove stale sockets
Amitay Isaacs [Mon, 30 Jan 2017 03:34:12 +0000 (14:34 +1100)]
ctdb-daemon: Use sock_clean() to remove stale sockets

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Feb 17 14:45:10 CET 2017 on sn-devel-144

3 years agoctdb-common: Refactor code to remove a stale socket
Amitay Isaacs [Mon, 30 Jan 2017 03:30:51 +0000 (14:30 +1100)]
ctdb-common: Refactor code to remove a stale socket

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>