sfrench/samba-autobuild/.git
8 years agolibcli-cldap: avoid the case local == remote == NULL
Matthieu Patou [Fri, 21 Oct 2011 14:11:41 +0000 (16:11 +0200)]
libcli-cldap: avoid the case local == remote == NULL

8 years agolibcli/cldap: make sure the local and remote address family matches
Stefan Metzmacher [Fri, 21 Oct 2011 07:49:30 +0000 (09:49 +0200)]
libcli/cldap: make sure the local and remote address family matches

metze

Signed-off-by: Matthieu Patou <mat@matws.net>
8 years agos4-resolv: fix resolution of SRV records pointing to A and AAAA records
Matthieu Patou [Fri, 21 Oct 2011 14:05:53 +0000 (16:05 +0200)]
s4-resolv: fix resolution of SRV records pointing to A and AAAA records

8 years agoDeprecate "acl check permissions".
Jeremy Allison [Fri, 21 Oct 2011 18:19:39 +0000 (11:19 -0700)]
Deprecate "acl check permissions".

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Oct 21 21:51:18 CEST 2011 on sn-devel-104

8 years agos3:idmap_autorid: document allocation pool
Christian Ambach [Thu, 20 Oct 2011 16:53:02 +0000 (18:53 +0200)]
s3:idmap_autorid: document allocation pool

document the need that excessive use of local users/group might
require increasing the rangesize

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Fri Oct 21 18:04:50 CEST 2011 on sn-devel-104

8 years agos3:idmap_autorid: add an allocation range to autorid
Christian Ambach [Thu, 20 Oct 2011 16:44:48 +0000 (18:44 +0200)]
s3:idmap_autorid: add an allocation range to autorid

this is needed to allocate gids for BUILTIN\Users and
BUILTIN\Administrators and for local users/group that
admins might want to create

autorid will now allocate one range for this purpose
and can so give out as many uids and gids as the
configured rangesize allows

8 years agos3:idmap_autorid: move HWM initialization into a function
Christian Ambach [Thu, 20 Oct 2011 16:39:30 +0000 (18:39 +0200)]
s3:idmap_autorid: move HWM initialization into a function

we will need some more HWM soon, so move out initialization and
optimize the logic using the new interface of dbwrap_fetch_uint32

8 years agos3:idmap_autorid: use strings as parameter for range allocator
Christian Ambach [Thu, 20 Oct 2011 16:22:19 +0000 (18:22 +0200)]
s3:idmap_autorid: use strings as parameter for range allocator

this prepares for allocation of non-domain ranges that cannot be
expressed by a SID (e.g. an allocation pool)

8 years agos3:winbindd/idmap make idmap modules loadable again
Christian Ambach [Thu, 20 Oct 2011 15:59:32 +0000 (17:59 +0200)]
s3:winbindd/idmap make idmap modules loadable again

commit 355b5e3a831415d9bef97 changed the module system to
expect 'samba_init_module' as fixed initializer function

8 years agoRevert "s3:idmap/autorid add a small alloc pool to autorid"
Christian Ambach [Wed, 19 Oct 2011 14:14:06 +0000 (16:14 +0200)]
Revert "s3:idmap/autorid add a small alloc pool to autorid"

This reverts commit 0aa558718ad7427ee8b02046da73eea1838a5a32.

just having 500 uid/gids values is not good enough for
users using local users and groups in the order of thousands

better solution which will use a complete range for allocated
uids/gids will come next.

8 years agolibcli: remove unneeded com_err.h and fix the build here.
Günther Deschner [Fri, 21 Oct 2011 12:15:54 +0000 (14:15 +0200)]
libcli: remove unneeded com_err.h and fix the build here.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Oct 21 15:52:36 CEST 2011 on sn-devel-104

8 years agos3-waf: only compile common.c in netapi examples code once.
Günther Deschner [Fri, 21 Oct 2011 09:31:57 +0000 (11:31 +0200)]
s3-waf: only compile common.c in netapi examples code once.

Guenther

8 years agos3-netapi: use NetApiBufferAllocate() for returned buffer in getdc calls.
Günther Deschner [Fri, 21 Oct 2011 09:06:14 +0000 (11:06 +0200)]
s3-netapi: use NetApiBufferAllocate() for returned buffer in getdc calls.

Guenther

8 years agos3-netapi: fix missing include in examples code.
Günther Deschner [Fri, 21 Oct 2011 09:05:37 +0000 (11:05 +0200)]
s3-netapi: fix missing include in examples code.

Guenther

8 years agolibcli/smb: move smb_seal.c to the toplevel
Stefan Metzmacher [Wed, 19 Oct 2011 11:47:39 +0000 (13:47 +0200)]
libcli/smb: move smb_seal.c to the toplevel

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Oct 21 10:22:39 CEST 2011 on sn-devel-104

8 years agos3-ntlmssp Remove references to auth_ntlmssp_context from the rpc code
Andrew Bartlett [Wed, 19 Oct 2011 07:39:27 +0000 (18:39 +1100)]
s3-ntlmssp Remove references to auth_ntlmssp_context from the rpc code

We always dereferenced auth_ntlmssp_state->gensec_security, so now we
do not bother passing around the whole auth_ntlmssp_state.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-seal Remove struct smb_srv_trans_enc_ctx
Andrew Bartlett [Wed, 19 Oct 2011 05:33:04 +0000 (16:33 +1100)]
s3-seal Remove struct smb_srv_trans_enc_ctx

This structure added no value, particularly after the move to gensec.

It was added at a time when auth_ntlmssp_state was not available in
the client.  This changed a while back (the wrapper was extended with
client calls), and the move to gensec again reinforced that we do not
need the extra complexity.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-ntlmssp Remove references to auth_ntlmssp_context from the smb sealing code
Andrew Bartlett [Wed, 19 Oct 2011 04:57:18 +0000 (15:57 +1100)]
s3-ntlmssp Remove references to auth_ntlmssp_context from the smb sealing code

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-ntlmssp Remove auth_ntlmssp_session_key()
Andrew Bartlett [Tue, 18 Oct 2011 10:55:24 +0000 (21:55 +1100)]
s3-ntlmssp Remove auth_ntlmssp_session_key()

We now just call the gensec_session_key() directly.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-ntlmssp Remove auth_ntlmssp_want_feature()
Andrew Bartlett [Tue, 18 Oct 2011 10:43:40 +0000 (21:43 +1100)]
s3-ntlmssp Remove auth_ntlmssp_want_feature()

We now just call the gensec_want_feature() directly.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-seal use gensec_[un]wrap() instead of gensec_[un]seal_packet()
Andrew Bartlett [Thu, 20 Oct 2011 09:53:40 +0000 (11:53 +0200)]
s3-seal use gensec_[un]wrap() instead of gensec_[un]seal_packet()

This should not make a difference for NTLMSSP as it still calls the
low level ntlmssp_[un]seal_packet() functions with the same input parameters.

If we convert the gss-api/krb5 based code to gensec we have to use
gensec_[un]wrap() as the wire format is different compared to
gensec_[un]seal_packet() there.

Andrew Bartlett

Split from another commit by Stefan Metzmacher <metze@samba.org>

8 years agos3-ntlmssp use gensec_{seal,unseal,sign,check}_packet
Andrew Bartlett [Tue, 18 Oct 2011 10:27:39 +0000 (21:27 +1100)]
s3-ntlmssp use gensec_{seal,unseal,sign,check}_packet

This avoids the indirection via the auth_ntlmsssp wrapper functions.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-ntlmssp Remove auth_ntlmssp_negotiated_sign() and auth_ntlmssp_negotiated_seal()
Andrew Bartlett [Tue, 18 Oct 2011 10:20:01 +0000 (21:20 +1100)]
s3-ntlmssp Remove auth_ntlmssp_negotiated_sign() and auth_ntlmssp_negotiated_seal()

We now just call the gensec_have_feature() directly.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-ntlmssp Remove auth_ntlmssp_update wrapper
Andrew Bartlett [Tue, 18 Oct 2011 10:13:16 +0000 (21:13 +1100)]
s3-ntlmssp Remove auth_ntlmssp_update wrapper

We now just call gensec_update directly.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-auth remove auth_ntlmssp_session_info()
Andrew Bartlett [Tue, 18 Oct 2011 09:58:47 +0000 (20:58 +1100)]
s3-auth remove auth_ntlmssp_session_info()

Instead, call gensec_session_info() directly.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3:smbd/seal: pass talloc_tos() auth_ntlmssp_update(), because we free a few lines...
Stefan Metzmacher [Thu, 20 Oct 2011 14:40:14 +0000 (16:40 +0200)]
s3:smbd/seal: pass talloc_tos() auth_ntlmssp_update(), because we free a few lines later

metze

8 years agos3:libsmb/smb_seal: always use SAFE_FREE(buf) in common_free_enc_buffer()
Stefan Metzmacher [Thu, 20 Oct 2011 11:46:05 +0000 (13:46 +0200)]
s3:libsmb/smb_seal: always use SAFE_FREE(buf) in common_free_enc_buffer()

There's no need to do gss-api specific stuff, the buffer is always
malloc'ed.

metze

8 years agos3:libsmb/smb_seal: use plain malloc() in common_ntlm_encrypt_buffer()
Stefan Metzmacher [Thu, 20 Oct 2011 11:44:14 +0000 (13:44 +0200)]
s3:libsmb/smb_seal: use plain malloc() in common_ntlm_encrypt_buffer()

metze

8 years agos3:libsmb/smb_seal: avoid ads_errstr() dependency and use gssapi_error_string()
Stefan Metzmacher [Thu, 20 Oct 2011 11:23:27 +0000 (13:23 +0200)]
s3:libsmb/smb_seal: avoid ads_errstr() dependency and use gssapi_error_string()

metze

8 years agos3:libsmb/smb_seal: make use of common [_]smb_[set]len_nbt() macros
Stefan Metzmacher [Thu, 20 Oct 2011 07:47:53 +0000 (09:47 +0200)]
s3:libsmb/smb_seal: make use of common [_]smb_[set]len_nbt() macros

metze

8 years agos3:include: make smb_setlen() a macro
Stefan Metzmacher [Thu, 20 Oct 2011 07:44:02 +0000 (09:44 +0200)]
s3:include: make smb_setlen() a macro

metze

8 years agolibcli/smb: add smb_setlen_[nbt|tcp] macros
Stefan Metzmacher [Thu, 20 Oct 2011 07:42:10 +0000 (09:42 +0200)]
libcli/smb: add smb_setlen_[nbt|tcp] macros

metze

8 years agolibcli/smb: move some common defines to smb_constants.h
Stefan Metzmacher [Thu, 20 Oct 2011 07:40:01 +0000 (09:40 +0200)]
libcli/smb: move some common defines to smb_constants.h

metze

8 years agobuild: compile (but do not install) netapi examples
Andrew Bartlett [Thu, 20 Oct 2011 22:02:23 +0000 (09:02 +1100)]
build: compile (but do not install) netapi examples

The only example not yet built is the GTK domain join gui.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Oct 21 01:31:55 CEST 2011 on sn-devel-104

8 years agos3:Makefile: make DSO_EXPORTS_CMD more portable (#8531)
Björn Jacke [Thu, 20 Oct 2011 19:39:38 +0000 (21:39 +0200)]
s3:Makefile: make DSO_EXPORTS_CMD more portable (#8531)

It sems like every not completely trivial sed expression should be tested with
Solaris' sed.  Its regexp engine is way more limited than the one of GNU
sed. Thanks to Michael Pelletier for finding this! This fixes bug #8531

Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Thu Oct 20 23:15:05 CEST 2011 on sn-devel-104

8 years agoRefactor to create check_parent_access() which can be called for file creation too.
Jeremy Allison [Thu, 20 Oct 2011 17:01:12 +0000 (10:01 -0700)]
Refactor to create check_parent_access() which can be called for file creation too.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Oct 20 20:29:22 CEST 2011 on sn-devel-104

8 years agoMake mkdir_internal() check the parent ACL for SEC_DIR_ADD_SUBDIR rights.
Jeremy Allison [Wed, 19 Oct 2011 23:56:00 +0000 (16:56 -0700)]
Make mkdir_internal() check the parent ACL for SEC_DIR_ADD_SUBDIR rights.

8 years agobuild: compile (but do not install) all the libsmbclient tests
Andrew Bartlett [Thu, 20 Oct 2011 09:40:58 +0000 (20:40 +1100)]
build: compile (but do not install) all the libsmbclient tests

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Oct 20 13:49:39 CEST 2011 on sn-devel-104

8 years agos3-netapi Compile (but do not install) netapi tests
Andrew Bartlett [Thu, 20 Oct 2011 02:41:30 +0000 (13:41 +1100)]
s3-netapi Compile (but do not install) netapi tests

8 years agoexamples: compile libsmbclient tests using just SAMBA_BINARY
Andrew Bartlett [Thu, 20 Oct 2011 02:40:01 +0000 (13:40 +1100)]
examples: compile libsmbclient tests using just SAMBA_BINARY

This ensures that these compile without the extra includes that SAMBA3_BINARY adds.

Andrew Bartlett

8 years agos3:libsmb/async_smb: in cli_state_notify_pending() we always disconnect
Stefan Metzmacher [Wed, 19 Oct 2011 12:26:20 +0000 (14:26 +0200)]
s3:libsmb/async_smb: in cli_state_notify_pending() we always disconnect

So we should always set state->mid = 0.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Oct 20 11:34:23 CEST 2011 on sn-devel-104

8 years agoRevert "selftest: Avoid being run over by armies of the undead"
Andrew Bartlett [Tue, 18 Oct 2011 10:30:17 +0000 (21:30 +1100)]
Revert "selftest: Avoid being run over by armies of the undead"

This reverts commit 2b47aface434000b29aa29f4ff6348cc147ae757 because
it had a typo in $SIG{CHILD} (it needed to be $SIG{CHLD}), which when
fixed simply broke the whole selftest system.

Andrew Bartlett

8 years agobuild: explain the passing of make options to waf
Andrew Tridgell [Thu, 20 Oct 2011 03:57:13 +0000 (14:57 +1100)]
build: explain the passing of make options to waf

add a comment explaining how we pass make command line options into
waf

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Oct 20 07:24:02 CEST 2011 on sn-devel-104

8 years agoldb: ldb_errstring() takes ldb_contxt as an argument
Amitay Isaacs [Tue, 18 Oct 2011 23:45:28 +0000 (10:45 +1100)]
ldb: ldb_errstring() takes ldb_contxt as an argument

Signed-off-by: Andrew Tridgell <tridge@samba.org>
8 years agos4-dns: Update serial number for zone on dns updates
Amitay Isaacs [Tue, 18 Oct 2011 04:20:14 +0000 (15:20 +1100)]
s4-dns: Update serial number for zone on dns updates

Signed-off-by: Andrew Tridgell <tridge@samba.org>
8 years agos4-selftest: Add tests for RPC dnsserver
Amitay Isaacs [Tue, 18 Oct 2011 01:44:02 +0000 (12:44 +1100)]
s4-selftest: Add tests for RPC dnsserver

Signed-off-by: Andrew Tridgell <tridge@samba.org>
8 years agosamba-tool: Added dns command for DNS management
Amitay Isaacs [Mon, 17 Oct 2011 02:15:40 +0000 (13:15 +1100)]
samba-tool: Added dns command for DNS management

Signed-off-by: Andrew Tridgell <tridge@samba.org>
8 years agos4-dns: Added DCERPC dns server for DNS management
Amitay Isaacs [Tue, 27 Sep 2011 06:53:45 +0000 (16:53 +1000)]
s4-dns: Added DCERPC dns server for DNS management

dnsserver.h - typedefs and prototypes
dnsserver.c - RPC API and implementation methods
dnsdb.c     - samdb operations
dnsdata.c   - functions to manipulate dns structures
dnsutils.c  - function for serverinfo and zoneinfo structures

Signed-off-by: Andrew Tridgell <tridge@samba.org>
8 years agos4-provision: Provision DNS records with correct rank
Amitay Isaacs [Fri, 7 Oct 2011 04:39:58 +0000 (15:39 +1100)]
s4-provision: Provision DNS records with correct rank

Signed-off-by: Andrew Tridgell <tridge@samba.org>
8 years agowerror: Added missing DNS error codes
Amitay Isaacs [Wed, 28 Sep 2011 03:15:02 +0000 (13:15 +1000)]
werror: Added missing DNS error codes

Signed-off-by: Andrew Tridgell <tridge@samba.org>
8 years agos4-dns: Added support for multiple DNS_RPC_RECORDS structures
Amitay Isaacs [Tue, 27 Sep 2011 07:10:14 +0000 (17:10 +1000)]
s4-dns: Added support for multiple DNS_RPC_RECORDS structures

Windows returns multiple DNS_RPC_RECORDS structures, but there is
no well defined structure in [MS-DNSP] doc. Added hand-written
code to parse ndr.

Pair-Programmed-With: Andrew Tridgell <tridge@samba.org>

Signed-off-by: Andrew Tridgell <tridge@samba.org>
8 years agos4-dns: Added more data types for dnsserver implementation
Amitay Isaacs [Tue, 27 Sep 2011 07:07:04 +0000 (17:07 +1000)]
s4-dns: Added more data types for dnsserver implementation

Windows uses WERROR on dnsserver pipe.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
8 years agoldb-samba: Added handler to decode dnsProperty attribute
Amitay Isaacs [Wed, 21 Sep 2011 04:56:19 +0000 (14:56 +1000)]
ldb-samba: Added handler to decode dnsProperty attribute

Signed-off-by: Andrew Tridgell <tridge@samba.org>
8 years agodnsp: Added typedefs to interpret dnsProperty attribute for dnsZone objectclass
Amitay Isaacs [Wed, 21 Sep 2011 04:55:06 +0000 (14:55 +1000)]
dnsp: Added typedefs to interpret dnsProperty attribute for dnsZone objectclass

Signed-off-by: Andrew Tridgell <tridge@samba.org>
8 years agos4-test: added test suite for common.py code
Andrew Tridgell [Thu, 20 Oct 2011 02:25:22 +0000 (13:25 +1100)]
s4-test: added test suite for common.py code

this tests the dsdb_Dn() class

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Oct 20 05:51:28 CEST 2011 on sn-devel-104

8 years agos4-dsdb: moved dsdb_Dn() into common.py
Andrew Tridgell [Thu, 20 Oct 2011 02:24:45 +0000 (13:24 +1100)]
s4-dsdb: moved dsdb_Dn() into common.py

this gives a method for dealing with binary DNs from python

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

8 years agosubunitrun: give more useful help
Andrew Tridgell [Thu, 20 Oct 2011 02:24:04 +0000 (13:24 +1100)]
subunitrun: give more useful help

give some examples and more useful description for subunitrun command

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

8 years agoFix a boatload of warnings in the examples.
Jeremy Allison [Wed, 19 Oct 2011 21:52:41 +0000 (14:52 -0700)]
Fix a boatload of warnings in the examples.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Oct 20 02:29:52 CEST 2011 on sn-devel-104

8 years agoFix error return to be NT_STATUS_NOT_A_DIRECTORY.
Jeremy Allison [Wed, 19 Oct 2011 21:25:45 +0000 (14:25 -0700)]
Fix error return to be NT_STATUS_NOT_A_DIRECTORY.

8 years agoMake use of the "dir_exists" we already have on directory open.
Jeremy Allison [Wed, 19 Oct 2011 21:23:38 +0000 (14:23 -0700)]
Make use of the "dir_exists" we already have on directory open.

8 years agodsdb: improve debug message
Andrew Tridgell [Wed, 19 Oct 2011 21:02:40 +0000 (08:02 +1100)]
dsdb: improve debug message

show the reply type in "Invalid reply type" messages

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Oct 20 00:57:05 CEST 2011 on sn-devel-104

8 years agos3-waf: make sure we always compile (not install) our libsmbclient testcode.
Günther Deschner [Wed, 19 Oct 2011 11:56:42 +0000 (13:56 +0200)]
s3-waf: make sure we always compile (not install) our libsmbclient testcode.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Oct 19 20:42:52 CEST 2011 on sn-devel-104

8 years agos3:libsmb/smb_seal: move smb_set_enclen() to smb_seal.c and make it static there
Stefan Metzmacher [Wed, 19 Oct 2011 15:37:29 +0000 (17:37 +0200)]
s3:libsmb/smb_seal: move smb_set_enclen() to smb_seal.c and make it static there

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Oct 19 19:06:35 CEST 2011 on sn-devel-104

8 years agos3:libsmb/smb_seal: s/uint16/uint16_t
Stefan Metzmacher [Wed, 19 Oct 2011 13:35:23 +0000 (15:35 +0200)]
s3:libsmb/smb_seal: s/uint16/uint16_t

metze

8 years agos3:include: move smb_seal.c prototypes to smb_crypt.h
Stefan Metzmacher [Wed, 19 Oct 2011 13:33:16 +0000 (15:33 +0200)]
s3:include: move smb_seal.c prototypes to smb_crypt.h

metze

8 years agos3:libsmb/smb_seal: make common_ntlm_[en|de]crypt_buffer static
Stefan Metzmacher [Wed, 19 Oct 2011 13:32:14 +0000 (15:32 +0200)]
s3:libsmb/smb_seal: make common_ntlm_[en|de]crypt_buffer static

metze

8 years agos4:libcli/raw: remove unused smb_len(), _smb_setlen() and _smb2_setlen() macros
Stefan Metzmacher [Wed, 19 Oct 2011 12:02:57 +0000 (14:02 +0200)]
s4:libcli/raw: remove unused smb_len(), _smb_setlen() and _smb2_setlen() macros

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Oct 19 17:15:23 CEST 2011 on sn-devel-104

8 years agos4:smb_server/smb2: make use of _smb_setlen_tcp()
Stefan Metzmacher [Wed, 19 Oct 2011 12:02:30 +0000 (14:02 +0200)]
s4:smb_server/smb2: make use of _smb_setlen_tcp()

metze

8 years agos4:smb_server/smb: make use of _smb_setlen_nbt()
Stefan Metzmacher [Wed, 19 Oct 2011 12:02:09 +0000 (14:02 +0200)]
s4:smb_server/smb: make use of _smb_setlen_nbt()

metze

8 years agos4:libcli/smb2: make use of _smb_setlen_tcp()
Stefan Metzmacher [Wed, 19 Oct 2011 12:01:29 +0000 (14:01 +0200)]
s4:libcli/smb2: make use of _smb_setlen_tcp()

metze

8 years agos4:libcli/raw: make use of _smb_setlen_nbt()
Stefan Metzmacher [Wed, 19 Oct 2011 12:01:01 +0000 (14:01 +0200)]
s4:libcli/raw: make use of _smb_setlen_nbt()

metze

8 years agos4:lib/stream: make use of smb_len_tcp()
Stefan Metzmacher [Wed, 19 Oct 2011 12:00:12 +0000 (14:00 +0200)]
s4:lib/stream: make use of smb_len_tcp()

metze

8 years agos3:include: use smb_[set]len_[nbt|tcp]() macros
Stefan Metzmacher [Wed, 19 Oct 2011 11:48:09 +0000 (13:48 +0200)]
s3:include: use smb_[set]len_[nbt|tcp]() macros

metze

8 years agolibcli/smb: add smb_[set]len_[nbt|tcp]() macros
Stefan Metzmacher [Wed, 19 Oct 2011 11:48:09 +0000 (13:48 +0200)]
libcli/smb: add smb_[set]len_[nbt|tcp]() macros

metze

8 years agos3: remove duplicate fsctl fn definitions
David Disseldorp [Tue, 18 Oct 2011 11:55:22 +0000 (13:55 +0200)]
s3: remove duplicate fsctl fn definitions

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agolibcli: Move smb2 fsctl fn defs into common code
David Disseldorp [Tue, 18 Oct 2011 11:54:33 +0000 (13:54 +0200)]
libcli: Move smb2 fsctl fn defs into common code

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3: Remove duplicate fsctl function definitions
David Disseldorp [Tue, 18 Oct 2011 10:23:26 +0000 (12:23 +0200)]
s3: Remove duplicate fsctl function definitions

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agolibcli: move ioctl function field defs to smb_constants
David Disseldorp [Tue, 18 Oct 2011 09:47:05 +0000 (11:47 +0200)]
libcli: move ioctl function field defs to smb_constants

Currently there are a lot of duplicate ioctl function field definitions
between source3 and source4.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos4-s3-upgrade rename samba-tool domain samba3upgrade --libdir to --dbdir for clarity
Andrew Bartlett [Tue, 18 Oct 2011 22:37:47 +0000 (09:37 +1100)]
s4-s3-upgrade rename samba-tool domain samba3upgrade --libdir to --dbdir for clarity

The things pointed at are not typically in a directory called lib,
so avoid confusing our administrators.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Oct 19 15:43:04 CEST 2011 on sn-devel-104

8 years agos4-s3-upgrade fix format string for secrets.tdb exception
Andrew Bartlett [Tue, 18 Oct 2011 22:31:40 +0000 (09:31 +1100)]
s4-s3-upgrade fix format string for secrets.tdb exception

8 years agos4-s3-upgrade test upgrade without a wins.dat
Andrew Bartlett [Wed, 19 Oct 2011 12:07:14 +0000 (23:07 +1100)]
s4-s3-upgrade test upgrade without a wins.dat

8 years agos4-s3-upgrade Fix samba3upgrade code to cope with a missing wins.dat
Andrew Bartlett [Tue, 18 Oct 2011 22:31:16 +0000 (09:31 +1100)]
s4-s3-upgrade Fix samba3upgrade code to cope with a missing wins.dat

8 years agos4-smb_server do not set credentials on gensec twice
Andrew Bartlett [Tue, 18 Oct 2011 21:31:48 +0000 (08:31 +1100)]
s4-smb_server do not set credentials on gensec twice

The samba_server_gensec_start() has already set the credentials
on the gensec_security context.

Andrew Bartlett

8 years agobuild: added deletion of stale .so and .o files
Andrew Tridgell [Wed, 19 Oct 2011 05:34:32 +0000 (16:34 +1100)]
build: added deletion of stale .so and .o files

when we change our build rules to move a C file, we need to remove the
old ('stale') .so and .o files from the build directory, or they may
be used as part of the new build, which means that old code will be
linked in.

This expands the list of stale files that we remove on rule changes to
include .so and .o files

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Oct 19 09:02:23 CEST 2011 on sn-devel-104

8 years agosamba.getopt: Add some basic tests.
Jelmer Vernooij [Wed, 19 Oct 2011 01:35:22 +0000 (03:35 +0200)]
samba.getopt: Add some basic tests.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Oct 19 05:04:33 CEST 2011 on sn-devel-104

8 years agosamba.getopt: Keep exception message when setting a lp option fails.
Jelmer Vernooij [Tue, 18 Oct 2011 23:30:40 +0000 (01:30 +0200)]
samba.getopt: Keep exception message when setting a lp option fails.

8 years agosamba-tool: Improve getopt.py error handling
Giampaolo Lauria [Mon, 17 Oct 2011 19:34:47 +0000 (15:34 -0400)]
samba-tool: Improve getopt.py error handling

Modified code to handle -k and --kerberos options to:
1. Throw the correct exception
2. On error, display the correct user's specified option

8 years agosamba-tool: Improve getopt.py error handling
Giampaolo Lauria [Mon, 17 Oct 2011 19:31:30 +0000 (15:31 -0400)]
samba-tool: Improve getopt.py error handling

Throw an exception when the --option value is invalid

8 years agosamba-tool: Improve getopt.py error handling
Giampaolo Lauria [Mon, 17 Oct 2011 19:28:52 +0000 (15:28 -0400)]
samba-tool: Improve getopt.py error handling

Throw an exception when --option value is not in the form "a=b"

8 years agosamba-tool: Improve getopt.py error handling
Giampaolo Lauria [Mon, 17 Oct 2011 19:22:01 +0000 (15:22 -0400)]
samba-tool: Improve getopt.py error handling

Raise exception when -d or --debuglevel value is <0

8 years agos3-docs: Add a clarification note for nss_info primary group membership calculation.
Günther Deschner [Tue, 18 Oct 2011 22:31:07 +0000 (00:31 +0200)]
s3-docs: Add a clarification note for nss_info primary group membership calculation.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Oct 19 03:10:40 CEST 2011 on sn-devel-104

8 years agos3-docs: Document Services for Unix 2.0 (sfu20) nss_info ldap schema support.
Günther Deschner [Tue, 18 Oct 2011 22:19:58 +0000 (00:19 +0200)]
s3-docs: Document Services for Unix 2.0 (sfu20) nss_info ldap schema support.

Guenther

8 years agos3: Avoid a winbind 100% cpu loop
Volker Lendecke [Tue, 18 Oct 2011 19:36:44 +0000 (21:36 +0200)]
s3: Avoid a winbind 100% cpu loop

When a DC goes down hard, winbind can end up in a 100% CPU loop. The next
(small) RPC request to the DC ends up as a trans2 request. If the connection
goes down, we end up trying to discard the request via the loop in
cli_state_notify_pending(). Because this is a trans2 request,
cli_smb_req_unset_pending will not kick in. Thus the pending array will always
remain at length 1.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Oct 19 01:39:35 CEST 2011 on sn-devel-104

8 years agovfs_netatalk should be using strstr_m, not strstr to find .AppleDouble paths.
Jeremy Allison [Tue, 18 Oct 2011 18:54:53 +0000 (11:54 -0700)]
vfs_netatalk should be using strstr_m, not strstr to find .AppleDouble paths.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct 19 00:05:45 CEST 2011 on sn-devel-104

8 years agoThe last argument to atalk_build_paths() is always false, remove it.
Jeremy Allison [Tue, 18 Oct 2011 18:24:35 +0000 (11:24 -0700)]
The last argument to atalk_build_paths() is always false, remove it.

8 years agolib/util: skip single hex digit at the end of the input sting - fix potential segfault
Michael Adam [Tue, 18 Oct 2011 16:10:00 +0000 (18:10 +0200)]
lib/util: skip single hex digit at the end of the input sting - fix potential segfault

The second of two digits was read without checking for the length of the input
string. For a non-zero-terminated input string, this might have caused a
segfault.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Oct 18 22:32:59 CEST 2011 on sn-devel-104

8 years agolib/util: fix function header comment to strhex_to_str()
Michael Adam [Tue, 18 Oct 2011 16:07:54 +0000 (18:07 +0200)]
lib/util: fix function header comment to strhex_to_str()

The description did not match the function's behaviour.

8 years agolib/util: untangle assignent from check in strhex_to_str()
Michael Adam [Tue, 18 Oct 2011 16:03:10 +0000 (18:03 +0200)]
lib/util: untangle assignent from check in strhex_to_str()

8 years agos3-util: dbwrap_tool: add fetch fuctions for hex and string
Björn Baumbach [Mon, 17 Oct 2011 14:08:38 +0000 (16:08 +0200)]
s3-util: dbwrap_tool: add fetch fuctions for hex and string

Signed-off-by: Michael Adam <obnox@samba.org>
8 years agos3-util: dbwrap_tool: add store hex function
Björn Baumbach [Mon, 17 Oct 2011 14:05:52 +0000 (16:05 +0200)]
s3-util: dbwrap_tool: add store hex function

Allows the user to store hex blobs in a tdb.

Signed-off-by: Michael Adam <obnox@samba.org>