Tim Potter [Wed, 11 Oct 2000 04:54:37 +0000 (04:54 +0000)]
Don't initialise groups twice.
Tim Potter [Wed, 11 Oct 2000 04:54:01 +0000 (04:54 +0000)]
Remove duplicate group initialisation function.
Don't initialise groups twice.
Jeremy Allison [Wed, 11 Oct 2000 03:46:14 +0000 (03:46 +0000)]
Fix to avoid calling getgrgid for no reason.
Jeremy.
Jeremy Allison [Wed, 11 Oct 2000 02:26:27 +0000 (02:26 +0000)]
Fix for growing printing.tdb by adding check on job creation.
This also updates the printing.tdb db version to 2.
Jeremy.
Jeremy Allison [Wed, 11 Oct 2000 02:04:46 +0000 (02:04 +0000)]
Remove lpq as root fix - do this in print_job_start instead
as part of print queue length processing.
Jeremy.
Jeremy Allison [Tue, 10 Oct 2000 21:52:31 +0000 (21:52 +0000)]
Fixes to periodically scan printing.tdb in idle time and occasionally
on exit. Needed to fix printing.tdb from groving to 300Mb+ if being
driven by smbclient clients that never ask for status... (effective
DOS attack :-).
Jeremy.
Jeremy Allison [Tue, 10 Oct 2000 19:09:48 +0000 (19:09 +0000)]
Fix found by Andrew to stop local/remote printers being
confused. check_printer_ok was causing SETPRINTER calls to fail.
Jeremy.
Jeremy Allison [Tue, 10 Oct 2000 18:40:03 +0000 (18:40 +0000)]
Fixed Realloc memory fragmentation problems.
Jeremy.
Jeremy Allison [Tue, 10 Oct 2000 18:34:44 +0000 (18:34 +0000)]
Fixed nasty size wrong bug spotted by the eagle eyes of
JF :-).
Jeremy.
Jeremy Allison [Tue, 10 Oct 2000 18:22:50 +0000 (18:22 +0000)]
Added debug so we can see how winbindd converts SIDS.
Jeremy.
Gerald Carter [Tue, 10 Oct 2000 13:30:02 +0000 (13:30 +0000)]
Just in case anyone thinks that Win ME is not freally just a
facelift for Win98/95
jerry
Jean-François Micouleau [Tue, 10 Oct 2000 13:08:55 +0000 (13:08 +0000)]
a netlogon enum trust query doesn't have a function_code at end.
a sam_user_info_24 doesn't have a uint16 at end
samr_create_user also creates the unix account now
samr_set_userinfo changes the password.
J.F.
Andrew Tridgell [Tue, 10 Oct 2000 06:45:09 +0000 (06:45 +0000)]
got rid of tdb_writelock() and instead lock a chain. tdb_writelock()
is conceptually flawed
Andrew Tridgell [Tue, 10 Oct 2000 06:43:26 +0000 (06:43 +0000)]
added tdb_lock_bystring() and tdb_unlock_bystring()
Andrew Tridgell [Tue, 10 Oct 2000 05:05:35 +0000 (05:05 +0000)]
don't use gets() !
John Terpstra [Mon, 9 Oct 2000 21:44:00 +0000 (21:44 +0000)]
Fixes to allow wins.c to compile to allow building of libnss_wins.so.
Jean-François Micouleau [Mon, 9 Oct 2000 14:41:19 +0000 (14:41 +0000)]
I introduced a bug in my last commits. Hopefully nobody noticed :-)
J.F.
Jeremy Allison [Mon, 9 Oct 2000 00:06:30 +0000 (00:06 +0000)]
Missing conn parameter missed in vfs rewrite.
Jeremy.
Jeremy Allison [Sun, 8 Oct 2000 21:21:27 +0000 (21:21 +0000)]
sys_popen got damaged when converted from FILE * to int fd I think.
Patrick Powell kindly pointed out the bug.
Jeremy.
Jean-François Micouleau [Sat, 7 Oct 2000 17:32:40 +0000 (17:32 +0000)]
more cleanup of samr
J.F.
Jean-François Micouleau [Sat, 7 Oct 2000 15:56:36 +0000 (15:56 +0000)]
added samr_set_user_info and info_2.
cleanup of create_user
cleanup of rid/sid mix in samr. now we only have sid.
some prs_align() missing in parse_samr.c
a small debug change in srv_pipe.c
You still can't change a user's password in this commit.
Will be availble in the next one.
J.F.
Jeremy Allison [Sat, 7 Oct 2000 01:15:07 +0000 (01:15 +0000)]
Ensure browse.dat is written and read in UNIX character set format.
Jeremy.
Jeremy Allison [Sat, 7 Oct 2000 00:48:27 +0000 (00:48 +0000)]
Integrated support for NT and OS/2 lpq parsing. Code from
Jim McDonough
Infoprint Manager Development
Linux Technology Center
IBM Boulder
Jeremy.
Jeremy Allison [Sat, 7 Oct 2000 00:26:04 +0000 (00:26 +0000)]
Fix for yp_get_default_domain from Neil Hoggarth <neil.hoggarth@physiol.ox.ac.uk>
Jeremy.
Jeremy Allison [Fri, 6 Oct 2000 23:35:55 +0000 (23:35 +0000)]
Fix for printf attribute from Mattias Gronlund <Mattias.Gronlund@sa.erisoft.se>
Added "codepage directory" patch from Peter.Polkinghorne@brunel.ac.uk
Jeremy.
Jeremy Allison [Fri, 6 Oct 2000 23:01:47 +0000 (23:01 +0000)]
Added Herb's fixes to HEAD.
Jeremy.
Jeremy Allison [Fri, 6 Oct 2000 22:37:42 +0000 (22:37 +0000)]
Fix from RFritz@lbl.gov for Linux ECONREFUSED async errors on Linux.
Jeremy.
Jeremy Allison [Fri, 6 Oct 2000 21:12:25 +0000 (21:12 +0000)]
Print socket options - patch from Dave Collier-Brown @ Sun.
Jeremy.
Jeremy Allison [Fri, 6 Oct 2000 20:34:14 +0000 (20:34 +0000)]
Fixed error return messages needed for NTTrans CreateDirectory.
This patch allows the standard W2k recursive mkdir to work against
Samba.
Jeremy.
Jeremy Allison [Fri, 6 Oct 2000 20:03:17 +0000 (20:03 +0000)]
Proto update. Also fix from John Reilly @ HP for not showing APW with W2K.
Jeremy.
Jeremy Allison [Fri, 6 Oct 2000 18:13:52 +0000 (18:13 +0000)]
Herb's warning fixes. Also the POSIX locking fix.
We now use our own vfs layer to do get/set acl calls (hurrah!).
Jeremy.
Tim Potter [Fri, 6 Oct 2000 04:36:05 +0000 (04:36 +0000)]
global_myname is actually a pstring.
Jeremy Allison [Fri, 6 Oct 2000 03:41:48 +0000 (03:41 +0000)]
Inlined many of the vfs_XXX calls as macros for speed.
Jeremy.
Jeremy Allison [Fri, 6 Oct 2000 03:21:49 +0000 (03:21 +0000)]
Restructuring of vfs layer to include a "this" pointer - can be an fsp or
a conn struct depending on the call.
We need this to have a clean NT ACL call interface.
This will break any existing VFS libraries (that's why this is pre-release
code).
Andrew gets credit for this one :-) :-).
In addition - added Herb's WITH_PROFILE changes - Herb - please examine
the changes I've made to the smbd/reply.c code you added. The original
code was very ugly and I have replaced it with a
START_PROFILE(x)/END_PROFILE(x) pair using the preprocessor.
Please check this compiles ok with the --with-profile switch.
Jeremy.
Jeremy Allison [Thu, 5 Oct 2000 22:51:57 +0000 (22:51 +0000)]
Fix for null passwords being allowed bug.
Jeremy.
Jeremy Allison [Thu, 5 Oct 2000 22:19:34 +0000 (22:19 +0000)]
Fixes from Damian at Cisco to tidy up some tdbtool issues.
Jeremy.
Jeremy Allison [Thu, 5 Oct 2000 19:04:41 +0000 (19:04 +0000)]
Vector get_nt_acl/set_nt_acl via vfs. POSIX ACL support should be added
above this layer.
Jeremy.
Jeremy Allison [Thu, 5 Oct 2000 18:50:18 +0000 (18:50 +0000)]
Herb's fixes for profiling & compiler warnings.
Jeremy.
Jean-François Micouleau [Thu, 5 Oct 2000 12:43:37 +0000 (12:43 +0000)]
someone forgot to update proto.h :-)
J.F.
Jean-François Micouleau [Thu, 5 Oct 2000 12:41:31 +0000 (12:41 +0000)]
fixing prs_unistr2(). For the special case of an empty (but existing)
string.
J.F.
Tim Potter [Thu, 5 Oct 2000 03:35:37 +0000 (03:35 +0000)]
Spelling flames. (-:
Tim Potter [Thu, 5 Oct 2000 03:28:58 +0000 (03:28 +0000)]
Added uid and gid to push_sec_ctx() debug.
Tim Potter [Thu, 5 Oct 2000 03:14:28 +0000 (03:14 +0000)]
Fixed compiler warnings.
Jeremy Allison [Wed, 4 Oct 2000 22:37:33 +0000 (22:37 +0000)]
Made re-init of stat cache explicit rather than being hidden.
Jeremy.
Jeremy Allison [Wed, 4 Oct 2000 01:03:23 +0000 (01:03 +0000)]
Adding Herb's compile warning fixes to HEAD.
Jeremy.
Jeremy Allison [Tue, 3 Oct 2000 19:15:05 +0000 (19:15 +0000)]
Fixes for the fact that UNICODE sizes are no always 2*no of chars when
in multibyte codepages. Fix from Hiroshi MIURA, Samba User Group Japan staff.
Jeremy.
Jeremy Allison [Tue, 3 Oct 2000 18:29:12 +0000 (18:29 +0000)]
Fixes from Herb - compiler warnings.
Jeremy.
Jeremy Allison [Tue, 3 Oct 2000 02:12:14 +0000 (02:12 +0000)]
utf-8 and EUC3 patch from Hiroshi Miura Samba User Group Japan staff.
mkdir high bits patch from Robert Dahlem" <Robert.Dahlem@gmx.net>.
jeremy.
Jeremy Allison [Mon, 2 Oct 2000 21:03:46 +0000 (21:03 +0000)]
Memleak fix for cache code.
Jeremy.
Jeremy Allison [Mon, 2 Oct 2000 19:28:26 +0000 (19:28 +0000)]
Added debug so if zero length messages get sent we successfully remove
them (this can happen if smbd processes are shut down at the wrong time).
Jeremy.
Jeremy Allison [Fri, 29 Sep 2000 21:15:45 +0000 (21:15 +0000)]
Missing null termination on printer changenotify message caused insure
error.
Jeremy.
Jeremy Allison [Fri, 29 Sep 2000 20:08:00 +0000 (20:08 +0000)]
utils/smbcontrol.c: Fixes from Herb for interactive use.
printing/nt_printing.c: No C++ comments please :-).
Jeremy.
Herb Lewis [Fri, 29 Sep 2000 19:50:57 +0000 (19:50 +0000)]
new man pages
Andrew Tridgell [Fri, 29 Sep 2000 04:47:18 +0000 (04:47 +0000)]
new prototypes
Andrew Tridgell [Fri, 29 Sep 2000 04:45:00 +0000 (04:45 +0000)]
added a hack to get 64 bit locking working with the broken fcntl()
call in glibc 2.1.95. This hack only gets enabled if you define
GLIBC_HACK_FCNTL64
Andrew Tridgell [Fri, 29 Sep 2000 04:43:07 +0000 (04:43 +0000)]
use the 64 bit locking interface in locktest
Andrew Tridgell [Fri, 29 Sep 2000 04:42:29 +0000 (04:42 +0000)]
fixed a harmess mixup of bitops and a boolean
Andrew Tridgell [Fri, 29 Sep 2000 04:41:52 +0000 (04:41 +0000)]
added cli_lock64() and cli_unlock64()
Jeremy Allison [Thu, 28 Sep 2000 22:17:41 +0000 (22:17 +0000)]
Missing from HEAD and 2.2 - terminal server reg config.
Jeremy.
Jeremy Allison [Thu, 28 Sep 2000 21:33:08 +0000 (21:33 +0000)]
Fix from John Reilly for forms ordering problems.
Jeremy.
Jeremy Allison [Thu, 28 Sep 2000 20:58:15 +0000 (20:58 +0000)]
Removed a line by mistake...
Jeremy.
Jeremy Allison [Thu, 28 Sep 2000 20:36:28 +0000 (20:36 +0000)]
Added comment on JF's new code. Removed ifdef in passdb/smbpass.c as this
was not correct.
Jeremy.
Jean-François Micouleau [Thu, 28 Sep 2000 17:35:03 +0000 (17:35 +0000)]
fixed samr_create_user(). we now correctly parse the query and the reply.
And we create the disabled account. That means we can create user and
trust accounts remotely !
ifdef out a return in passdb/smbpass.c. I think I didn't break any
security. Jeremy could you check if I didn't make any mistakes ???
J.F.
Tim Potter [Thu, 28 Sep 2000 00:07:19 +0000 (00:07 +0000)]
Removed annoying unecessary debug message.
Jeremy Allison [Wed, 27 Sep 2000 21:57:38 +0000 (21:57 +0000)]
Fixed stupid introduced bug found by "Jim McDonough/Boulder/IBM" <jmcd@us.ibm.com>.
Jeremy.
Jeremy Allison [Wed, 27 Sep 2000 19:09:59 +0000 (19:09 +0000)]
Restructuring of the code to remove dos_ChDir/dos_GetWd and re-vector them
through the VFS. All file access/directory access code in smbd should now
go via the vfs. Added vfs_chown/vfs_chmod calls. Still looking at vfs_get_nt_acl()
vfs_set_nt_acl() call API design.
Jeremy.
Jean-François Micouleau [Wed, 27 Sep 2000 13:02:57 +0000 (13:02 +0000)]
samr unknown 0x32 is in fact samr create user.
so renamed and tidy up of the server function.
J.F.
Jean-François Micouleau [Wed, 27 Sep 2000 11:25:16 +0000 (11:25 +0000)]
ignore smbcontrol in bin directory
J.F.
Herb Lewis [Tue, 26 Sep 2000 23:28:04 +0000 (23:28 +0000)]
fix for IRIX 6.2 compiler error
Herb Lewis [Tue, 26 Sep 2000 18:48:13 +0000 (18:48 +0000)]
fix for IRIX compiler error messages
Herb Lewis [Tue, 26 Sep 2000 14:48:52 +0000 (14:48 +0000)]
fixed IRIX compiller error message
Jean-François Micouleau [Tue, 26 Sep 2000 10:15:12 +0000 (10:15 +0000)]
broadcast printer notify message to all clients. We now have printer
notification as on NT.
Andrew, your message passing code is cool :-)
J.F.
Luke Leighton [Tue, 26 Sep 2000 05:44:42 +0000 (05:44 +0000)]
added NEGNOWAIT. sent to secure@microsoft.com
Jeremy Allison [Tue, 26 Sep 2000 00:54:18 +0000 (00:54 +0000)]
Changes from John Reilly to add a parameter "show add printer wizard" that
allows Samba to turn off the display of APW (hmmm. This should probably
be a share specific parameter, I'll fix that in another commit).
Also a few small changes to JF's code to fix compiler warnings about
missing return statements and also change '//' comments (C++) to /* .. */
comments (C).
Jeremy.
Jean-François Micouleau [Mon, 25 Sep 2000 21:05:18 +0000 (21:05 +0000)]
printer notify code.
It only sends notifies to one client. The broadcasting notify code will
code soon.
J.F.
Jeremy Allison [Thu, 21 Sep 2000 23:39:19 +0000 (23:39 +0000)]
Optimization (noticed by bloody Andrew :-) to stop directory scan ever
being done if any of the directory timestamps were changed.
Jeremy.
Jeremy Allison [Thu, 21 Sep 2000 21:44:15 +0000 (21:44 +0000)]
Adding fix from Jim Vopni <jimv@metrics.com> to ensure jobs are
closed before a printer is closed/deleted.
Jeremy.
Jeremy Allison [Wed, 20 Sep 2000 22:07:56 +0000 (22:07 +0000)]
Some code moved back from TNG - updates to LSA stuff. Not yet used but
will be needed soon.
Jeremy.
Jeremy Allison [Wed, 20 Sep 2000 19:00:21 +0000 (19:00 +0000)]
Fix to allow a timestamp of zero to cause an instantaneous changenotify
scan - then call this from renames. This allows instantaneous update for
W2k renames.
Jeremy.
Jeremy Allison [Tue, 19 Sep 2000 22:32:56 +0000 (22:32 +0000)]
param/loadparm.c: Fix based on Damian's code to stop printer scripts getting overwritten.
rpc_parse/parse_spoolss.c: Tidyup to call function for relstring arrays.
Win2000 now does "Add Printer" successfully !!!!!
Jeremy.
Tim Potter [Mon, 18 Sep 2000 01:14:21 +0000 (01:14 +0000)]
Modified test.h generator to return error if structure passed to vluke
doesn't match any known structure names.
Tim Potter [Mon, 18 Sep 2000 01:09:25 +0000 (01:09 +0000)]
Removed emacs backup file from repository.
Jean-François Micouleau [Sat, 16 Sep 2000 10:07:46 +0000 (10:07 +0000)]
in a printer_info_6, driver version is 64 bits long and there is a 32 bit
padding before.
J.F.
Jeremy Allison [Fri, 15 Sep 2000 21:20:49 +0000 (21:20 +0000)]
Fixes from JF as I didn't understand the string array sizing code correctly.
Jeremy.
Jeremy Allison [Fri, 15 Sep 2000 00:15:10 +0000 (00:15 +0000)]
Move towards getting W2k p&p to upload NT4.x drivers. Still doesn't work -
not sure why (JF - a glance at this would be appreciated). Removed code
that JF objected to with enumprinterdata. Added translations to/from
level 6 - but Win2k still not happy... hmmm...
Jeremy.
Gerald Carter [Thu, 14 Sep 2000 16:49:50 +0000 (16:49 +0000)]
Placeholder for some forthcoming documentation
jerry
Gerald Carter [Thu, 14 Sep 2000 16:47:49 +0000 (16:47 +0000)]
fixed typo
jerry
Gerald Carter [Thu, 14 Sep 2000 16:44:44 +0000 (16:44 +0000)]
Added a gew more mods by Patrick Powell (lprng guy)
jerry
Gerald Carter [Thu, 14 Sep 2000 16:40:51 +0000 (16:40 +0000)]
First draft of new printing doc describing the SPOOLSS support in the
upcoming 2.2.0 release.
Needs some other eyes to review it. :-)
jerry
Jeremy Allison [Wed, 13 Sep 2000 22:01:15 +0000 (22:01 +0000)]
Ensure old DACL and SACL are preserved if the new SD is a 'set' only.
Jeremy.
Jeremy Allison [Wed, 13 Sep 2000 18:50:38 +0000 (18:50 +0000)]
Added SIGHUP when printer deleted as well as added.
Jeremy.
Andrew Tridgell [Wed, 13 Sep 2000 07:08:09 +0000 (07:08 +0000)]
don't show equivalent enum options in swat
Andrew Tridgell [Wed, 13 Sep 2000 07:07:17 +0000 (07:07 +0000)]
first cut at smbcontrol program. It currently allows syntax like:
smbcontrol nmbd debug 7
smbcontrol smbd debug 9
smbcontrol 3278 debug 1
smbcontrol nmbd force-election
Tim Potter [Wed, 13 Sep 2000 04:42:06 +0000 (04:42 +0000)]
When creating a print job entry for the printing backend, use the Windows
username rather than the Unix username. The Windows username will then be
shown in the port monitor regardless of the Unix username used to spool the
job.
Jeremy Allison [Wed, 13 Sep 2000 02:24:35 +0000 (02:24 +0000)]
Added time check test before allowing print job.
Jeremy.
Tim Potter [Wed, 13 Sep 2000 01:18:01 +0000 (01:18 +0000)]
Added missing break statement for manage documents check in
print_access_check() function.
Tim Potter [Tue, 12 Sep 2000 23:00:01 +0000 (23:00 +0000)]
Updated manual pages to point at lists.samba.org instead of old
listproc address.
Jeremy Allison [Tue, 12 Sep 2000 22:33:41 +0000 (22:33 +0000)]
Fix for enumjobs infor level 2 which caused smbd to coredump.
Uninitialized element in struct.
Jeremy.
Jeremy Allison [Tue, 12 Sep 2000 21:45:42 +0000 (21:45 +0000)]
Fixed error return when printer is PAUSED - should be returning "Pause".
Jeremy.
Jeremy Allison [Tue, 12 Sep 2000 19:51:38 +0000 (19:51 +0000)]
With John Reilly help tracking it down - fixed a *nasty* bug when
authorising logins. If a user connected to a share as guest, then
the snum was getting flagged as "force guest", meaning that all
subsequent connections to it, even under a different vuid, would
be bounced to guest.
This explains several very hard to reproduce access denied bugs,
and as the NT client also has bugs in that it will sometimes
erroneously use guest instead of the correct vuid on an IPC$
connection lead to a *very* hard problem to find.
This fix should be propagated into all branches (TNG/Applience
take note) and I'll also make a separate patch availalble on the
samba-technical list.
Jeremy.