sfrench/samba-autobuild/.git
7 years agolib-addns: ensure that allocated buffer are pre set to 0
Matthieu Patou [Thu, 27 Sep 2012 08:22:57 +0000 (01:22 -0700)]
lib-addns: ensure that allocated buffer are pre set to 0

It avoid bugs when one of the buffer is supposed to contain a string
that is not null terminated (ie. label->label) and that we don't force
the last byte to 0.

7 years agoldap-server: sscanf result was never used to mistyped var
Matthieu Patou [Thu, 27 Sep 2012 01:32:28 +0000 (18:32 -0700)]
ldap-server: sscanf result was never used to mistyped var

7 years agoldap-server: remove warning for the ret not being used
Matthieu Patou [Thu, 27 Sep 2012 01:31:39 +0000 (18:31 -0700)]
ldap-server: remove warning for the ret not being used

7 years agos4-drs: fix the logic to allow REPL_SECRET if the account has GET_ALL_CHANGES
Matthieu Patou [Wed, 26 Sep 2012 18:49:07 +0000 (11:49 -0700)]
s4-drs: fix the logic to allow REPL_SECRET if the account has GET_ALL_CHANGES

7 years agos4-drs: EXOP_REPL_SECRETS can be called by RW DC as well
Matthieu Patou [Wed, 26 Sep 2012 18:44:58 +0000 (11:44 -0700)]
s4-drs: EXOP_REPL_SECRETS can be called by RW DC as well

7 years agodrs-getncchanges: do not set the highestUsn to 0
Matthieu Patou [Tue, 25 Sep 2012 21:02:55 +0000 (14:02 -0700)]
drs-getncchanges: do not set the highestUsn to 0

Paragraph 4.1.10.5 says that
         if err = 0 then
         msgOut.pNC := msgIn.pNC
         msgOut.usnvecFrom := msgIn.usnvecFrom
so no need to set the highestUsn to 0

7 years agokcc: return invalid parameter if the taskId is not 0
Matthieu Patou [Tue, 25 Sep 2012 20:27:04 +0000 (13:27 -0700)]
kcc: return invalid parameter if the taskId is not 0

7 years agodrs-crackname: if there is no sid do not return the domain
Matthieu Patou [Tue, 25 Sep 2012 17:51:47 +0000 (10:51 -0700)]
drs-crackname: if there is no sid do not return the domain

7 years agodevel-crackname: Print if count > 0
Matthieu Patou [Tue, 25 Sep 2012 09:00:23 +0000 (02:00 -0700)]
devel-crackname: Print if count > 0

7 years agoImplement the LIST_INFO_FOR_SERVER input format
Matthieu Patou [Tue, 25 Sep 2012 04:34:02 +0000 (21:34 -0700)]
Implement the LIST_INFO_FOR_SERVER input format

7 years agogetdcinfo: Check that the server object has a serverreference objects pointing to...
Matthieu Patou [Tue, 25 Sep 2012 06:12:25 +0000 (23:12 -0700)]
getdcinfo: Check that the server object has a serverreference objects pointing to a DC object

The problem was found by the DRSR testsuite where server objects were
created in the Site container without serverrefrence attribute
triggering error in the testsuite.

7 years agontdb: remove unused local variable.
Rusty Russell [Mon, 8 Oct 2012 00:56:43 +0000 (11:26 +1030)]
ntdb: remove unused local variable.

Reported-by: Matthieu Patou <mat@samba.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User(master): Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date(master): Mon Oct  8 04:43:37 CEST 2012 on sn-devel-104

7 years agos3: Add two tests a CLEAR_IF_FIRST crash
Volker Lendecke [Tue, 2 Oct 2012 13:44:41 +0000 (15:44 +0200)]
s3: Add two tests a CLEAR_IF_FIRST crash

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sat Oct  6 17:16:39 CEST 2012 on sn-devel-104

7 years agotdb: Make tdb robust against improper CLEAR_IF_FIRST restart tdb-1.2.11
Volker Lendecke [Tue, 2 Oct 2012 13:26:14 +0000 (15:26 +0200)]
tdb: Make tdb robust against improper CLEAR_IF_FIRST restart

When winbind is restarted, there is a potential crash in tdb. Following
situation: We are in a cluster with ctdb. A winbind child hangs
in a request to the DC. Cluster monitoring decides the node has a
problem. Cluster monitoring decides to kill ctdbd. winbind child
still hangs in a RPC request. winbind parent figures that ctdb is
dead and immediately commits suicide. winbind parent is restarted by
cluster management, overwriting gencache.tdb with CLEAR_IF_FIRST. The
CLEAR_IF_FIRST logic as implemented now will not see that a child still
has the tdb open, only the parent holds the ACTIVE_LOCK due to performance
reasons. During the CLEAR_IF_FIRST logic is done, there is a very small
window where we ftruncate(tfd, 0) the file and re-write a proper header
without a lock. When during this small window the winbind child comes
back, wanting to store something into gencache.tdb, that winbind child
will crash with a SIGBUS.

Sounds unlikely? See:

[2012/09/29 07:02:31.871607,  0] lib/util.c:1183(smb_panic)
  PANIC (pid 1814517): internal error
[2012/09/29 07:02:31.877596,  0] lib/util.c:1287(log_stack_trace)
  BACKTRACE: 35 stack frames:
   #0 winbindd(log_stack_trace+0x1a) [0x7feb7d4ca18a]
   #1 winbindd(smb_panic+0x2b) [0x7feb7d4ca25b]
   #2 winbindd(+0x1a3cc4) [0x7feb7d4bacc4]
   #3 /lib64/libc.so.6(+0x32900) [0x7feb7a929900]
   #4 /lib64/libc.so.6(memcpy+0x35) [0x7feb7a97f355]
   #5 /usr/lib64/libtdb.so.1(+0x6e76) [0x7feb7b0b0e76]
   #6 /usr/lib64/libtdb.so.1(+0x3d37) [0x7feb7b0add37]
   #7 /usr/lib64/libtdb.so.1(+0x863d) [0x7feb7b0b263d]
   #8 /usr/lib64/libtdb.so.1(+0x8700) [0x7feb7b0b2700]
   #9 /usr/lib64/libtdb.so.1(+0x2505) [0x7feb7b0ac505]
   #10 /usr/lib64/libtdb.so.1(+0x25b7) [0x7feb7b0ac5b7]
   #11 /usr/lib64/libtdb.so.1(tdb_fetch+0x13) [0x7feb7b0ac633]
   #12 winbindd(gencache_set_data_blob+0x259) [0x7feb7d4d8449]
   #13 winbindd(gencache_set+0x53) [0x7feb7d4d85b3]
   #14 winbindd(gencache_del+0x5e) [0x7feb7d4d879e]
   #15 winbindd(saf_delete+0x93) [0x7feb7d54b693]
   #16 winbindd(+0xe507e) [0x7feb7d3fc07e]
   #17 winbindd(+0xe85e5) [0x7feb7d3ff5e5]
   #18 winbindd(+0xe65be) [0x7feb7d3fd5be]
   #19 winbindd(+0xe7562) [0x7feb7d3fe562]
   #20 winbindd(init_dc_connection+0x2e) [0x7feb7d3fe5be]
   #21 winbindd(+0xe75d9) [0x7feb7d3fe5d9]
   #22 winbindd(cm_connect_netlogon+0x58) [0x7feb7d3fe658]
   #23 winbindd(_wbint_PingDc+0x61) [0x7feb7d410991]
   #24 winbindd(+0x103175) [0x7feb7d41a175]
   #25 winbindd(winbindd_dual_ndrcmd+0xb7) [0x7feb7d4107d7]
   #26 winbindd(+0xf8609) [0x7feb7d40f609]
   #27 winbindd(+0xf9075) [0x7feb7d410075]
   #28 winbindd(tevent_common_loop_immediate+0xe8) [0x7feb7d4db198]
   #29 winbindd(run_events_poll+0x3c) [0x7feb7d4d93fc]
   #30 winbindd(+0x1c2b52) [0x7feb7d4d9b52]
   #31 winbindd(_tevent_loop_once+0x90) [0x7feb7d4d9f60]
   #32 winbindd(main+0x7b3) [0x7feb7d3e7aa3]
   #33 /lib64/libc.so.6(__libc_start_main+0xfd) [0x7feb7a915cdd]
   #34 winbindd(+0xce2a9) [0x7feb7d3e52a9]

This is in a winbind child, logfiles surrounding indicate the parent
was restarted.

This patch takes all chain locks around the CLEAR_IF_FIRST introduced
tdb_new_database.

7 years agotdb: Make robust against shrinking tdbs
Rusty Russell [Sat, 6 Oct 2012 11:23:05 +0000 (13:23 +0200)]
tdb: Make robust against shrinking tdbs

When probing for a size change (eg. just before tdb_expand, tdb_check,
tdb_rescue) we call tdb_oob(tdb, tdb->map_size, 1, 1).  Unfortunately
this does nothing if the tdb has actually shrunk, which as Volker
demonstrated, can actually happen if a "longlived" parent crashes.

So move the map/update size/remap before the limit check.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoWe should never just assign an st_mode to an ace->perms field, theoretically
Jeremy Allison [Fri, 5 Oct 2012 22:51:19 +0000 (15:51 -0700)]
We should never just assign an st_mode to an ace->perms field, theoretically
they are different so should go through a mapping function. Ensure this is so.

Practically this does not matter, as for user permissions the mapping
function is an identity, and the extra bits we may add are ignored
anyway, but this makes the intent clear.

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Oct  6 03:04:14 CEST 2012 on sn-devel-104

7 years agoModify ensure_canon_entry_valid() into ensure_canon_entry_valid_on_set() - makes...
Jeremy Allison [Fri, 5 Oct 2012 22:48:07 +0000 (15:48 -0700)]
Modify ensure_canon_entry_valid() into ensure_canon_entry_valid_on_set() - makes the logic clearer.

7 years agoSimplify ensure_canon_entry_valid by splitting out the _get codepath.
Jeremy Allison [Fri, 5 Oct 2012 22:09:06 +0000 (15:09 -0700)]
Simplify ensure_canon_entry_valid by splitting out the _get codepath.

7 years agotalloc: Convert error cecking macros into fns talloc-2.0.8
Simo Sorce [Fri, 5 Oct 2012 14:32:32 +0000 (10:32 -0400)]
talloc: Convert error cecking macros into fns

This will avoid 'surprise returns' and makes the code cleare to readers.
These macros were complex enough to warrant a full function anyway not
just for readability but also for debuggability.

Thanks David for pointing out this issue.

Autobuild-User(master): Simo Sorce <idra@samba.org>
Autobuild-Date(master): Fri Oct  5 23:24:17 CEST 2012 on sn-devel-104

7 years agoAdd tests for talloc_memlimit
Simo Sorce [Sat, 22 Sep 2012 20:35:21 +0000 (16:35 -0400)]
Add tests for talloc_memlimit

Autobuild-User(master): Simo Sorce <idra@samba.org>
Autobuild-Date(master): Fri Oct  5 07:36:38 CEST 2012 on sn-devel-104

7 years agoAdd memory limiting capability to talloc
Simo Sorce [Sat, 22 Sep 2012 20:15:47 +0000 (16:15 -0400)]
Add memory limiting capability to talloc

By calling talloc_set_memlimit() we can now set a max memory limit
for a whole talloc hierarchy.
ANy attempt to allocate memory beyond the max allowed for the whole
hierarchy wil cause an allocation failure.

Stealing memory correctly accounts for used memory in the old and the new
hierarchy but exceeding the memory limit in the new parent will not cause
a failure.

7 years agoEnsure the masks don't conflict with the ACL checks.
Jeremy Allison [Thu, 4 Oct 2012 20:50:51 +0000 (13:50 -0700)]
Ensure the masks don't conflict with the ACL checks.

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Oct  5 00:36:40 CEST 2012 on sn-devel-104

7 years agoUpdate WHATSNEW.txt with removed parameters.
Jeremy Allison [Thu, 4 Oct 2012 19:03:27 +0000 (12:03 -0700)]
Update WHATSNEW.txt with removed parameters.

7 years agoRemove the parameters:
Jeremy Allison [Wed, 3 Oct 2012 23:04:18 +0000 (16:04 -0700)]
Remove the parameters:

security mask
force security mode
directory security mask
force directory security mode

and update the docs.

7 years agoRemove all uses of lp_security_mask/lp_force_security_mode/lp_dir_security_mask/lp_fo...
Jeremy Allison [Wed, 3 Oct 2012 21:49:01 +0000 (14:49 -0700)]
Remove all uses of lp_security_mask/lp_force_security_mode/lp_dir_security_mask/lp_force_dir_security_mode
and replace with the normal masks. Now these parameters can be removed.

7 years agoRevert "Add functions to programatically set the security mask and directory security...
Jeremy Allison [Wed, 3 Oct 2012 20:59:43 +0000 (13:59 -0700)]
Revert "Add functions to programatically set the security mask and directory security mask parameters."

This reverts commit 8f0ecbbbeebff0174579a78827d384067cd4cbb7.

Not now needed as part of the move to remove security mask parameters.

7 years agoRevert "When creating a new file/directory, we need to obey the create mask/directory...
Jeremy Allison [Wed, 3 Oct 2012 20:58:53 +0000 (13:58 -0700)]
Revert "When creating a new file/directory, we need to obey the create mask/directory mask parameters."

This reverts commit c251a6b0442abc13bc8be4ff8de324c1d7706a78.

Remove this as we're planning to remove the security mask,
directory security mask parameters and only use create mask/directory mask.

7 years agohtml docs: Remove link to Using Samba.
Karolin Seeger [Thu, 4 Oct 2012 09:43:20 +0000 (11:43 +0200)]
html docs: Remove link to Using Samba.

Thanks to Christian Perrier <bubulle@debian.org> for reporting!

Fix bug #7826 - HTML docs index file still points to Using Samba.

Karolin

Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Thu Oct  4 13:48:00 CEST 2012 on sn-devel-104

7 years agodocs: Remove duplicate synonym min protocol.
Karolin Seeger [Thu, 4 Oct 2012 08:00:44 +0000 (10:00 +0200)]
docs: Remove duplicate synonym min protocol.

Karolin

7 years agos3fs-smbd: Make sure the registry is set up before we init printing.
Andreas Schneider [Tue, 2 Oct 2012 13:51:08 +0000 (15:51 +0200)]
s3fs-smbd: Make sure the registry is set up before we init printing.

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Oct  4 12:06:29 CEST 2012 on sn-devel-104

7 years agowaf: Build pam_smbpass module only if enabled.
Andreas Schneider [Tue, 2 Oct 2012 12:25:40 +0000 (14:25 +0200)]
waf: Build pam_smbpass module only if enabled.

7 years agotdb: add -e option to tdbdump (and docment it).
Rusty Russell [Wed, 3 Oct 2012 23:34:23 +0000 (09:04 +0930)]
tdb: add -e option to tdbdump (and docment it).

This allows for an emergency best-effort dump.  It's a little better than
strings(1).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User(master): Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date(master): Thu Oct  4 03:16:06 CEST 2012 on sn-devel-104

7 years agotdb: tdbdump should log errors, and fail in that case.
Rusty Russell [Wed, 3 Oct 2012 23:34:23 +0000 (09:04 +0930)]
tdb: tdbdump should log errors, and fail in that case.

Dumping a corrupt database should not exit silently with 0 status!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agotdb: add tdb_rescue()
Rusty Russell [Wed, 3 Oct 2012 23:34:19 +0000 (09:04 +0930)]
tdb: add tdb_rescue()

This allows for an emergency best-effort dump.  It's a little better than
strings(1).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoCorrect fix for bug #9222 - smbd ignores the "server signing = no" setting for SMB2.
Jeremy Allison [Wed, 3 Oct 2012 19:58:00 +0000 (12:58 -0700)]
Correct fix for bug #9222 - smbd ignores the "server signing = no" setting for SMB2.

Signing cannot be disabled for SMB2 by design, so fix the documentation
instead.

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Oct  3 23:47:23 CEST 2012 on sn-devel-104

7 years agoRevert "Fix bug #9222 - smbd ignores the "server signing = no" setting for SMB2."
Jeremy Allison [Wed, 3 Oct 2012 19:50:42 +0000 (12:50 -0700)]
Revert "Fix bug #9222 - smbd ignores the "server signing = no" setting for SMB2."

This reverts commit dfd3c31a3f9eea96854b2d22574856368e86b245.

As Metze pointed out:

From MS-SMB2 section 2.2.4:

SMB2_NEGOTIATE_SIGNING_ENABLED

When set, indicates that security signatures are enabled
on the server. The server MUST set this bit, and the client MUST return
STATUS_INVALID_NETWORK_RESPONSE if the flag is missing.

I'll submit a documentation bug to fix #9222 that way.

7 years agoFix bug #9214 - Bad user supplied SMB2 credit value can cause smbd to call smb_panic.
Jeremy Allison [Wed, 3 Oct 2012 00:30:54 +0000 (17:30 -0700)]
Fix bug #9214 - Bad user supplied SMB2 credit value can cause smbd to call smb_panic.

Terminate the connection cleanly instead.

7 years agos3-docs: add delete_lost option to vfs_streams_depot.8
Björn Baumbach [Tue, 2 Oct 2012 09:37:11 +0000 (11:37 +0200)]
s3-docs: add delete_lost option to vfs_streams_depot.8

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Oct  3 18:10:14 CEST 2012 on sn-devel-104

7 years agos3-docs: Fix opening and ending tag mismatch in Samba3-HOWTO (Bug #9235)
Björn Baumbach [Tue, 2 Oct 2012 08:53:15 +0000 (10:53 +0200)]
s3-docs: Fix opening and ending tag mismatch in Samba3-HOWTO (Bug #9235)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos4: samba_backup: Fix typos.
Björn Baumbach [Wed, 19 Sep 2012 10:03:21 +0000 (12:03 +0200)]
s4: samba_backup: Fix typos.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos4:tortore/rpc/lsa: make more use of torture_assert*
Stefan Metzmacher [Mon, 1 Oct 2012 06:51:47 +0000 (08:51 +0200)]
s4:tortore/rpc/lsa: make more use of torture_assert*

Currently samba3.rpc.lsa.privileges.lsa.Privileges(s3dc)
seems to be flakey.

We may be able to find the bug with this,
or at least mark it as flapping.

metze

7 years agowintest: Give dcpromo more time
Andrew Bartlett [Tue, 2 Oct 2012 22:22:27 +0000 (08:22 +1000)]
wintest: Give dcpromo more time

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Oct  3 16:04:44 CEST 2012 on sn-devel-104

7 years agowintest: Give netdom join more time to complete
Andrew Bartlett [Tue, 2 Oct 2012 08:45:39 +0000 (18:45 +1000)]
wintest: Give netdom join more time to complete

7 years agowintest: Add config file for a second host
Andrew Bartlett [Tue, 2 Oct 2012 02:34:10 +0000 (12:34 +1000)]
wintest: Add config file for a second host

7 years agowintest: bump version to 4.1
Andrew Bartlett [Tue, 2 Oct 2012 02:33:48 +0000 (12:33 +1000)]
wintest: bump version to 4.1

7 years agonsswitch: Build nss_winbind on all supported platforms
Andrew Bartlett [Mon, 1 Oct 2012 22:12:16 +0000 (08:12 +1000)]
nsswitch: Build nss_winbind on all supported platforms

This matches what the autoconf build can do.

Andrew Bartlett

7 years agoselftest: Always build a linux-style nss_winbind for nss_wrapper
Andrew Bartlett [Wed, 3 Oct 2012 06:36:34 +0000 (16:36 +1000)]
selftest: Always build a linux-style nss_winbind for nss_wrapper

7 years agoprovision: Use logger rather than print.
Jelmer Vernooij [Wed, 3 Oct 2012 08:26:55 +0000 (10:26 +0200)]
provision: Use logger rather than print.

Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date(master): Wed Oct  3 14:24:09 CEST 2012 on sn-devel-104

7 years agos4-provision: do not skip setting the acls on sysvol
Matthieu Patou [Tue, 2 Oct 2012 21:30:25 +0000 (14:30 -0700)]
s4-provision: do not skip setting the acls on sysvol

Autobuild-User(master): Matthieu Patou <mat@samba.org>
Autobuild-Date(master): Wed Oct  3 10:26:06 CEST 2012 on sn-devel-104

7 years agoFix bug #9222 - smbd ignores the "server signing = no" setting for SMB2.
Jeremy Allison [Tue, 2 Oct 2012 21:10:21 +0000 (14:10 -0700)]
Fix bug #9222 - smbd ignores the "server signing = no" setting for SMB2.

Still sign if client request is signed, just don't negotiate it in
negprot or sessionsetup.

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Oct  3 00:59:42 CEST 2012 on sn-devel-104

7 years agoWhen creating a new file/directory, we need to obey the create mask/directory mask...
Jeremy Allison [Tue, 2 Oct 2012 17:25:14 +0000 (10:25 -0700)]
When creating a new file/directory, we need to obey the create mask/directory mask parameters.

Currently we call FSET_NT_ACL to inherit any ACLs on create. However
FSET_NT_ACL uses the security mask/directory security mask parameters
instead of the create mask/directory mask parameters.

Swap them temporarily when creating to ensure the correct masks
are applied.

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Oct  2 22:27:17 CEST 2012 on sn-devel-104

7 years agoAdd functions to programatically set the security mask and directory security mask...
Jeremy Allison [Tue, 2 Oct 2012 17:22:39 +0000 (10:22 -0700)]
Add functions to programatically set the security mask and directory security mask parameters.

7 years agoWhen setting a non-default ACL, don't forget to apply masks to SMB_ACL_USER and SMB_A...
Jeremy Allison [Tue, 2 Oct 2012 17:15:54 +0000 (10:15 -0700)]
When setting a non-default ACL, don't forget to apply masks to SMB_ACL_USER and SMB_ACL_GROUP entries.

7 years agoOnly apply masks on non-default ACL entries when setting the ACL.
Jeremy Allison [Tue, 2 Oct 2012 17:12:45 +0000 (10:12 -0700)]
Only apply masks on non-default ACL entries when setting the ACL.

7 years agoUse is_default_acl variable in canonicalise_acl().
Jeremy Allison [Tue, 2 Oct 2012 16:55:09 +0000 (09:55 -0700)]
Use is_default_acl variable in canonicalise_acl().

7 years agoReformat spacing to be even.
Jeremy Allison [Tue, 2 Oct 2012 16:21:17 +0000 (09:21 -0700)]
Reformat spacing to be even.

7 years agotdb: Fix a typo
Volker Lendecke [Tue, 2 Oct 2012 10:21:20 +0000 (12:21 +0200)]
tdb: Fix a typo

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Oct  2 19:52:16 CEST 2012 on sn-devel-104

7 years agos3-net: Fix DEBUG() location.
Günther Deschner [Mon, 1 Oct 2012 14:19:28 +0000 (16:19 +0200)]
s3-net: Fix DEBUG() location.

Guenther

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Tue Oct  2 18:06:17 CEST 2012 on sn-devel-104

7 years agos3-net: give more control how to update/register DNS entries.
Günther Deschner [Tue, 25 Sep 2012 09:09:45 +0000 (11:09 +0200)]
s3-net: give more control how to update/register DNS entries.

Guenther

7 years agos3-net: pass down a flags field to DoDNSUpdate().
Günther Deschner [Tue, 25 Sep 2012 09:08:48 +0000 (11:08 +0200)]
s3-net: pass down a flags field to DoDNSUpdate().

Guenther

7 years agos3-net: move out some prototypes to net_dns.h.
Günther Deschner [Wed, 19 Sep 2012 13:35:15 +0000 (15:35 +0200)]
s3-net: move out some prototypes to net_dns.h.

Guenther

7 years agos3-net: pass down struct net_context to the dns update calls.
Günther Deschner [Wed, 19 Sep 2012 13:31:57 +0000 (15:31 +0200)]
s3-net: pass down struct net_context to the dns update calls.

Guenther

7 years agos3-kerberos: add aes enctypes to generated krb5.conf.
Günther Deschner [Mon, 19 Dec 2011 09:52:58 +0000 (10:52 +0100)]
s3-kerberos: add aes enctypes to generated krb5.conf.

Guenther

7 years agos3-krb5: use and request AES keys in kerberos operations.
Günther Deschner [Thu, 15 Dec 2011 17:12:41 +0000 (18:12 +0100)]
s3-krb5: use and request AES keys in kerberos operations.

Guenther

7 years agoFix release script to build full set of documentation
Alexander Bokovoy [Tue, 2 Oct 2012 11:53:38 +0000 (14:53 +0300)]
Fix release script to build full set of documentation

build-docs script was not setting XML catalog properly.

In addition, some time ago pdf versions of images were introduced as
generated dependencies in our books but svg -> pdf rule was not added,
so building books never finished properly.

Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Tue Oct  2 16:21:23 CEST 2012 on sn-devel-104

7 years agolibrelease.sh: Move the GPG data to the library section.
Karolin Seeger [Tue, 2 Oct 2012 08:29:16 +0000 (10:29 +0200)]
librelease.sh: Move the GPG data to the library section.

Don't use the Library key for the samba releases.

Karolin

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 7eb1f6ff178cb04a04dcaee88f15be850d239430)

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Oct  2 14:28:10 CEST 2012 on sn-devel-104

7 years agos4-dns: fix a non handled memory out of memory
Matthieu Patou [Tue, 2 Oct 2012 04:43:11 +0000 (21:43 -0700)]
s4-dns: fix a non handled memory out of memory

Signed-off-by: Kai Blin <kai@samba.org>
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Tue Oct  2 09:43:52 CEST 2012 on sn-devel-104

7 years agoAdd samba3.samba3badnameblob test to check regressions in bug #9215.
Jeremy Allison [Fri, 28 Sep 2012 16:39:15 +0000 (09:39 -0700)]
Add samba3.samba3badnameblob test to check regressions in bug #9215.

Bad name in SMB1 openX can cause a crash in iconv inside glibc.

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Oct  1 23:29:25 CEST 2012 on sn-devel-104

7 years agos3fs-smbd: Move housekeeping to the background process.
Andreas Schneider [Thu, 27 Sep 2012 17:01:15 +0000 (19:01 +0200)]
s3fs-smbd: Move housekeeping to the background process.

If you add 200 printers using lpadmin. Then you wait for the printcap
cache to expire. As soon as this expires we notify all deamons that they
should reload the printers. This mean we need to create the default
registry keys for each printer. If you do e.g. a 'smbclient -L' during
that time you will get a lot of timeouts.

This lets the housekeeping function of the printcap cache do the task of
creating the default registry keys in background queue process. When it is done
with the task it will tell all smbd childs to reload the printers and the 200
printers appear.

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Oct  1 20:28:23 CEST 2012 on sn-devel-104

7 years agos3: vfs_streams_depot: add delete_lost option
Björn Baumbach [Thu, 27 Sep 2012 10:40:47 +0000 (12:40 +0200)]
s3: vfs_streams_depot: add delete_lost option

With this option lost stream directories will be removed
instead of renamed.

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Oct  1 18:47:30 CEST 2012 on sn-devel-104

7 years agos3: make recursive_rmdir function non-static
Björn Baumbach [Mon, 1 Oct 2012 07:55:28 +0000 (09:55 +0200)]
s3: make recursive_rmdir function non-static

7 years agos3: Fix bug 8966, Fix net rpc share allowedusers to work with 2008r2
Jeremy Allison [Mon, 1 Oct 2012 04:16:18 +0000 (06:16 +0200)]
s3: Fix bug 8966, Fix net rpc share allowedusers to work with 2008r2

The RAP NetShareEnum command was removed in 2008r2, so use the RPC
equivalent instead.

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Oct  1 07:59:34 CEST 2012 on sn-devel-104

7 years agos3: Fix libnss_winbind.so's build on Illumos/Solaris
Ira Cooper [Sun, 30 Sep 2012 19:02:13 +0000 (19:02 +0000)]
s3: Fix libnss_winbind.so's build on Illumos/Solaris

Due to not building and linking in the winbind_nss_solaris bits in addition
to the linux bits, nss was broken on Solaris.

Autobuild-User(master): Ira Cooper <ira@samba.org>
Autobuild-Date(master): Sun Sep 30 22:56:30 CEST 2012 on sn-devel-104

7 years agos4 dns: Fix return code for deleted records
Kai Blin [Sun, 30 Sep 2012 09:26:24 +0000 (11:26 +0200)]
s4 dns: Fix return code for deleted records

This fixes bug #9225. We already had a test for this scenario, but the test wasn't
correct. This patch fixes the test, and also fixes the bug.

Signed-off-by: Kai Blin <kai@samba.org>
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Sun Sep 30 13:09:14 CEST 2012 on sn-devel-104

7 years agos4 dns: Get rid of deprecated allocation result check
Kai Blin [Sun, 30 Sep 2012 08:44:03 +0000 (10:44 +0200)]
s4 dns: Get rid of deprecated allocation result check

7 years agoselftest: use an array when starting testenv with system()
Andrew Bartlett [Sat, 29 Sep 2012 10:40:13 +0000 (20:40 +1000)]
selftest: use an array when starting testenv with system()

By reduing the need for escapes and forcing the use of bash, this
seems to allow 'make testenv' to start on FreeBSD

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun Sep 30 02:30:40 CEST 2012 on sn-devel-104

7 years agos3: Fix opening a file under kernel oplocks
Volker Lendecke [Tue, 25 Sep 2012 18:37:33 +0000 (11:37 -0700)]
s3: Fix opening a file under kernel oplocks

With the prior code we assumed that we do not have kernel oplocks around
when we open a file because we handled samba-internal oplock breaks
before the open attempt.

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sat Sep 29 19:29:36 CEST 2012 on sn-devel-104

7 years agos3: Remove a SMB_ASSERT
Volker Lendecke [Thu, 13 Sep 2012 13:51:44 +0000 (15:51 +0200)]
s3: Remove a SMB_ASSERT

With the simplified logic this became unnecessary

7 years agos3: Close the now opened file descriptor in error paths
Volker Lendecke [Wed, 26 Sep 2012 20:20:57 +0000 (22:20 +0200)]
s3: Close the now opened file descriptor in error paths

7 years agos3: No code change, just re-indent
Volker Lendecke [Wed, 26 Sep 2012 17:52:14 +0000 (10:52 -0700)]
s3: No code change, just re-indent

Look at this with "git diff -b" if you don't believe me :-)

7 years agos3: Remove share mode handling before we open the file
Volker Lendecke [Thu, 13 Sep 2012 13:40:17 +0000 (15:40 +0200)]
s3: Remove share mode handling before we open the file

This is a significant behaviour change: We do not open the file under
the share mode lock anymore. This might lead to more open calls in case
of oplock breaks or sharing violations, but those are slow error paths
and as such might be not too performance sensitive. The benefit of this
patch is a significant reduction of complexity of open_file_ntcreate()

7 years agos3: Fix fcb_or_dos_open after logic change
Volker Lendecke [Thu, 13 Sep 2012 13:45:49 +0000 (15:45 +0200)]
s3: Fix fcb_or_dos_open after logic change

With the new behaviour, we call fcb_or_dos_open after open_file(). It
is open_file() that sets up the fsp so that fcb_or_dos_open can find it
in the list of fsps. Avoid finding the fsp we are just setting up.

7 years agos3: Copy share mode handling from before to after open_file
Volker Lendecke [Wed, 26 Sep 2012 17:39:42 +0000 (10:39 -0700)]
s3: Copy share mode handling from before to after open_file

This is a 1:1 copy&paste of the oplock/sharemode code that we do before
an existing file is opened. It is a prerequiste for a patch that removes
all of that handling before we open the file.

7 years agos3:libsmb: use smbXcli_conn_remote_name() in smb2_tcon_send()
Stefan Metzmacher [Fri, 28 Sep 2012 17:11:14 +0000 (19:11 +0200)]
s3:libsmb: use smbXcli_conn_remote_name() in smb2_tcon_send()

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sat Sep 29 11:52:43 CEST 2012 on sn-devel-104

7 years agos3:libsmb: make cli_echo* protocol independent
Stefan Metzmacher [Fri, 28 Sep 2012 18:00:21 +0000 (20:00 +0200)]
s3:libsmb: make cli_echo* protocol independent

metze

7 years agolibcli/smb: add smb1cli_echo*
Stefan Metzmacher [Fri, 28 Sep 2012 17:53:16 +0000 (19:53 +0200)]
libcli/smb: add smb1cli_echo*

metze

7 years agolibcli/smb: add smb2cli_echo*
Stefan Metzmacher [Fri, 28 Sep 2012 17:18:37 +0000 (19:18 +0200)]
libcli/smb: add smb2cli_echo*

metze

7 years agolibcli/smb: use an explicit TALLOC_FREE(subreq) in smb2cli_*
Stefan Metzmacher [Fri, 28 Sep 2012 17:48:26 +0000 (19:48 +0200)]
libcli/smb: use an explicit TALLOC_FREE(subreq) in smb2cli_*

metze

7 years agobuild: Remove duplicate check for struct getquota_rslt member getquota_rslt_u
Andrew Bartlett [Sat, 29 Sep 2012 04:31:28 +0000 (14:31 +1000)]
build: Remove duplicate check for struct getquota_rslt member getquota_rslt_u

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Sep 29 08:51:03 CEST 2012 on sn-devel-104

7 years agobuild: Fix quota tests, including move of sysquotas.c to the top level
Andrew Bartlett [Sat, 29 Sep 2012 04:28:57 +0000 (14:28 +1000)]
build: Fix quota tests, including move of sysquotas.c to the top level

This correctly detects quotas on FreeBSD

Andrew Bartlett

7 years agolib/replace: Add test for what flag we need for -Werror behaviour
Andrew Bartlett [Sat, 29 Sep 2012 04:36:41 +0000 (14:36 +1000)]
lib/replace: Add test for what flag we need for -Werror behaviour

7 years agos3-winbindd: Adjust error code loop logic in rpc_trusted_domains().
Günther Deschner [Fri, 28 Sep 2012 16:04:07 +0000 (18:04 +0200)]
s3-winbindd: Adjust error code loop logic in rpc_trusted_domains().

Guenther

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Sat Sep 29 00:34:04 CEST 2012 on sn-devel-104

7 years agos3-lsa: Flesh out the returned info in _lsa_EnumTrustedDomainsEx().
Günther Deschner [Fri, 28 Sep 2012 16:03:25 +0000 (18:03 +0200)]
s3-lsa: Flesh out the returned info in _lsa_EnumTrustedDomainsEx().

Guenther

7 years agos3-winbindd: Allow DNS resolution of trusted domains if DNS name is avaliable
Sumit Bose [Tue, 11 Sep 2012 11:28:35 +0000 (13:28 +0200)]
s3-winbindd: Allow DNS resolution of trusted domains if DNS name is avaliable

Signed-off-by: Günther Deschner <gd@samba.org>
7 years agovfs: check full_audit enum->str mapping on startup
David Disseldorp [Thu, 27 Sep 2012 10:34:53 +0000 (12:34 +0200)]
vfs: check full_audit enum->str mapping on startup

Signed-off-by: Jim McDonough <jmcd@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Fri Sep 28 19:28:49 CEST 2012 on sn-devel-104

7 years agovfs: add missing pwrite ops to full_audit
David Disseldorp [Thu, 27 Sep 2012 09:50:22 +0000 (11:50 +0200)]
vfs: add missing pwrite ops to full_audit

The op enum is used by audit_opname() as an index into the vfs_op_names
array, so any decrepencies cause bogus audit log entries.

Signed-off-by: Jim McDonough <jmcd@samba.org>
7 years agoWHATSNEW: Add changed parameters.
Karolin Seeger [Fri, 28 Sep 2012 10:40:14 +0000 (12:40 +0200)]
WHATSNEW: Add changed parameters.

Needs to be double-checked.

Karolin

Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Fri Sep 28 14:22:52 CEST 2012 on sn-devel-104

7 years agoWHATSNEW: Start release notes for Samba 4.0.0rc2.
Karolin Seeger [Fri, 28 Sep 2012 09:30:06 +0000 (11:30 +0200)]
WHATSNEW: Start release notes for Samba 4.0.0rc2.

To be continued...

Karolin

7 years agoSupport UPN_DNS_INFO in the PAC
Simo Sorce [Thu, 27 Sep 2012 18:12:06 +0000 (14:12 -0400)]
Support UPN_DNS_INFO in the PAC

Previously marked as UNKNOWN_12 the UPN_DNS_INFO is defined in MS-PAC

Autobuild-User(master): Simo Sorce <idra@samba.org>
Autobuild-Date(master): Fri Sep 28 01:13:44 CEST 2012 on sn-devel-104

7 years agoFix bug #9209 - Parse of invalid SMB2 create blob can cause smbd crash.
Jeremy Allison [Wed, 26 Sep 2012 23:58:58 +0000 (16:58 -0700)]
Fix bug #9209 - Parse of invalid SMB2 create blob can cause smbd crash.

Ensure we correctly protect against blobs with data_offset==0
and data_length != 0.

Jeremy.

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Sep 27 22:07:02 CEST 2012 on sn-devel-104