13 years agor25156: Update coding guiding wrt to primitive data types
Gerald Carter [Fri, 14 Sep 2007 12:06:34 +0000 (12:06 +0000)]
r25156: Update coding guiding wrt to primitive data types

13 years agor25154: move winbindd code into winbindd/
Stefan Metzmacher [Fri, 14 Sep 2007 12:03:58 +0000 (12:03 +0000)]
r25154: move winbindd code into winbindd/


13 years agor25152: fix headers used in wbinfo.c
Stefan Metzmacher [Fri, 14 Sep 2007 11:56:10 +0000 (11:56 +0000)]
r25152: fix headers used in wbinfo.c


13 years agor25150: don't recursivly call call dump_core()
Stefan Metzmacher [Fri, 14 Sep 2007 11:07:02 +0000 (11:07 +0000)]
r25150: don't recursivly call call dump_core()
as currently seen in 'make test' localy and in the farm


13 years agor25148: Adapt to coding conventions.
Günther Deschner [Fri, 14 Sep 2007 08:21:20 +0000 (08:21 +0000)]
r25148: Adapt to coding conventions.


13 years agor25146: rename winbindd_nss.h => winbind_struct_protocol.h
Stefan Metzmacher [Fri, 14 Sep 2007 08:06:03 +0000 (08:06 +0000)]
r25146: rename winbindd_nss.h => winbind_struct_protocol.h

as this header has nothing todo with winbindd nor nss
and it contains the definitions for the struct based


13 years agor25143: rename public functions from winbind_client.h
Stefan Metzmacher [Fri, 14 Sep 2007 07:07:59 +0000 (07:07 +0000)]
r25143: rename public functions from winbind_client.h

init_request => winbindd_init_request
free_response => winbindd_free_response
read_reply => winbindd_read_reply

write_sock => winbind_write_sock
read_sock => winbind_read_sock
close_sock => winbind_close_sock(void)


13 years agor25142: Panic if setting the group list fails while switching security
James Peach [Fri, 14 Sep 2007 04:17:17 +0000 (04:17 +0000)]
r25142: Panic if setting the group list fails while switching security
contexts. Patch from Tim Prouty <>.

13 years agor25141: More pstring removal.
Jeremy Allison [Fri, 14 Sep 2007 01:07:57 +0000 (01:07 +0000)]
r25141: More pstring removal.

13 years agor25140: Less red bars to hurt my eyes...
Michael Adam [Thu, 13 Sep 2007 22:41:04 +0000 (22:41 +0000)]
r25140: Less red bars to hurt my eyes...

13 years agor25139: Avoid code duplication: let regval_ctr_copyvalue() call regval_ctr_addvalue().
Michael Adam [Thu, 13 Sep 2007 22:36:10 +0000 (22:36 +0000)]
r25139: Avoid code duplication: let regval_ctr_copyvalue() call regval_ctr_addvalue().
This also corrects regval_ctr_copyvalue() in that it cannot create (invalid)
regval containers with dupliacte entries...


13 years agor25138: More pstring elimination. Add a TALLOC_CTX parameter
Jeremy Allison [Thu, 13 Sep 2007 22:08:59 +0000 (22:08 +0000)]
r25138: More pstring elimination. Add a TALLOC_CTX parameter
to unix_convert().

13 years agor25136: When tallocing a string to uppercase remember the terminating
Jeremy Allison [Thu, 13 Sep 2007 17:25:57 +0000 (17:25 +0000)]
r25136: When tallocing a string to uppercase remember the terminating
'\0' in size calculations.

13 years agor25135: Remove one END_PROFILE(SMBntcreateX) from call_nt_transact_create() which
Günther Deschner [Thu, 13 Sep 2007 16:48:46 +0000 (16:48 +0000)]
r25135: Remove one END_PROFILE(SMBntcreateX) from call_nt_transact_create() which
appears to be a leftover. Should fix the build with profiling enabled.

Jeremy, please check.


13 years agor25134: Fix Bug #4968 and make dns updates work with heimdal as well (again,
Günther Deschner [Thu, 13 Sep 2007 16:11:46 +0000 (16:11 +0000)]
r25134: Fix Bug #4968 and make dns updates work with heimdal as well (again,
gss_import_name() needs to follow the same logic as in the LDAP sasl wrapping
(see -r25133).

Tested with MIT 1.2.7, 1.3.6, 1.4.3, 1.5.1, 1.6.1 and Heimdal 0.7.2, 1.0,


13 years agor25133: Fix sasl wrapping (for ldap sign&seal).
Günther Deschner [Thu, 13 Sep 2007 15:59:46 +0000 (15:59 +0000)]
r25133: Fix sasl wrapping (for ldap sign&seal).

The gss_import_name() broke as we switched from the internal MIT OID
"gss_nt_krb5_principal" to "GSS_KRB5_NT_PRINCIPAL_NAME" and didn't switch from
passing the krb5_principal (or better: a pointer to that, see MIT's "*HORRIBLE*
bug") to pass the string principal directly.

Jerry, Jeremy, neither I could figure out the need of passing in a
krb5_principal at all nor could I reproduce the crash you were seeing.

I sucessfully tested the code (now importing a string) with MIT 1.2.7, 1.3.6,
1.4.3, 1.5.1, 1.6.1 and Heimdal 0.7.2, 1.0, 1.0.1.


13 years agor25130: make use only of base types which are provided by libreplace
Stefan Metzmacher [Thu, 13 Sep 2007 14:14:02 +0000 (14:14 +0000)]
r25130: make use only of base types which are provided by libreplace
in winbind client and nss/pam stuff


13 years agor25128: _XOPEN_SOURCE_EXTENDED and socklen_t are always provided by libreplace
Stefan Metzmacher [Thu, 13 Sep 2007 12:54:53 +0000 (12:54 +0000)]
r25128: _XOPEN_SOURCE_EXTENDED and socklen_t are always provided by libreplace


13 years agor25127: Add to the repo.
Simo Sorce [Thu, 13 Sep 2007 12:51:00 +0000 (12:51 +0000)]
r25127: Add to the repo.
This script is useful for migrating OpenLDAP schema files to FDS/RHDS
lidf schema files.

License kindly updated to GPLv3+ at our request.


13 years agor25125: create prototypes for 'bool ' functions
Stefan Metzmacher [Thu, 13 Sep 2007 12:25:28 +0000 (12:25 +0000)]
r25125: create prototypes for 'bool ' functions


13 years agor25121: Remove pstring limits from much of our string handling function.
Jeremy Allison [Thu, 13 Sep 2007 01:10:01 +0000 (01:10 +0000)]
r25121: Remove pstring limits from much of our string handling function.
Still a few left (mainly the substitute ones).

13 years agor25120: One more warning.
Jeremy Allison [Thu, 13 Sep 2007 00:31:02 +0000 (00:31 +0000)]
r25120: One more warning.

13 years agor25119: Fix a couple of warnings.
Jeremy Allison [Thu, 13 Sep 2007 00:29:25 +0000 (00:29 +0000)]
r25119: Fix a couple of warnings.

13 years agor25118: More pstring elimination.
Jeremy Allison [Wed, 12 Sep 2007 23:50:21 +0000 (23:50 +0000)]
r25118: More pstring elimination.

13 years agor25117: The mega-patch Jerry was waiting for. Remove all pstrings from
Jeremy Allison [Wed, 12 Sep 2007 21:48:20 +0000 (21:48 +0000)]
r25117: The mega-patch Jerry was waiting for. Remove all pstrings from
the main server code paths. We should now be able to cope with
paths up to PATH_MAX length now.
Final job will be to add the TALLOC_CTX * parameter to
unix_convert to make it explicit (for Volker).

13 years agor25116: Fix talloc_asprintf_append to do the right thing with
Jeremy Allison [Wed, 12 Sep 2007 21:41:36 +0000 (21:41 +0000)]
r25116: Fix talloc_asprintf_append to do the right thing with
truncated strings.

13 years agor25111: Move to talloced pathnames on most code paths.
Jeremy Allison [Tue, 11 Sep 2007 23:57:59 +0000 (23:57 +0000)]
r25111: Move to talloced pathnames on most code paths.
There are now ony 17 pstrings left in reply.c,
and these will be easy to remove (and I'll be
doing that shortly). Had to fix an interesting
bug in pull_ucs2_base_talloc() when a source
string is not null terminated :-).

13 years agor25109: Remove obsolete argument from ads_guess_service_principal().
Günther Deschner [Tue, 11 Sep 2007 23:35:17 +0000 (23:35 +0000)]
r25109: Remove obsolete argument from ads_guess_service_principal().


13 years agor25108: Make ifdef labyrinth in sasl code a bit more readable.
Günther Deschner [Tue, 11 Sep 2007 23:21:50 +0000 (23:21 +0000)]
r25108: Make ifdef labyrinth in sasl code a bit more readable.


13 years agor25107: Fix const warning caused by the way I reformatted this
Simo Sorce [Tue, 11 Sep 2007 23:04:14 +0000 (23:04 +0000)]
r25107: Fix const warning caused by the way I reformatted this

13 years agor25104: Fix extra lines added by mistake.
Jeremy Allison [Tue, 11 Sep 2007 21:52:44 +0000 (21:52 +0000)]
r25104: Fix extra lines added by mistake.

13 years agor25103: Ensure we don't return unwritten memory (valgrind caught).
Jeremy Allison [Tue, 11 Sep 2007 19:27:34 +0000 (19:27 +0000)]
r25103: Ensure we don't return unwritten memory (valgrind caught).

13 years agor25102: Rewrite msdfs code to use talloced filenames. Passes make test
Jeremy Allison [Tue, 11 Sep 2007 18:31:29 +0000 (18:31 +0000)]
r25102: Rewrite msdfs code to use talloced filenames. Passes make test
and make valgrindtest. Final step will be to change srvstr_get_path()
to return talloced memory in the major codepaths.

13 years agor25099: Commit fix for CVE-2007-4138 from 3.0.26 release.
Gerald Carter [Tue, 11 Sep 2007 18:08:07 +0000 (18:08 +0000)]
r25099: Commit fix for CVE-2007-4138 from 3.0.26 release.

13 years agor25092: Add support for storing trusted domain passwords in LDAP for
Michael Adam [Tue, 11 Sep 2007 16:50:32 +0000 (16:50 +0000)]
r25092: Add support for storing trusted domain passwords in LDAP for
passdb backend = ldapsam.

Along with reproducing the functionality of the secrets.tdb
code, I have prepared the handling of the previous trust password
(in case we are contacting a dc which does not yet know of a recent
password change). This information has still to be propagated
to the outside, but this requires a change of the api and also
a change of the secrets.tdb code.


13 years agor25091: Start adding support for storing trusted domain passwords in LDAP
Michael Adam [Tue, 11 Sep 2007 16:38:31 +0000 (16:38 +0000)]
r25091: Start adding support for storing trusted domain passwords in LDAP
(for passdb backen = ldapsam). At a first step, add the hooks,
calling the secrets_ functions.


13 years agor25090: Fix a syntax error just introduced into the LDAP schema.
Michael Adam [Tue, 11 Sep 2007 16:30:38 +0000 (16:30 +0000)]
r25090: Fix a syntax error just introduced into the LDAP schema.


13 years agor25088: Change the objectclass sambaTrustedDomainPassword to
Michael Adam [Tue, 11 Sep 2007 16:25:47 +0000 (16:25 +0000)]
r25088: Change the objectclass sambaTrustedDomainPassword to
have the current and possibly the previous trust password
stored as clear text passwords. (Previous use of NTPassword
was a mistake - this is a hash value.)


13 years agor25087: Reformatting: Get rid of an abundance of leading tabs...
Michael Adam [Tue, 11 Sep 2007 16:18:14 +0000 (16:18 +0000)]
r25087: Reformatting: Get rid of an abundance of leading tabs...

13 years agor25086: Fix interdomain trusts (this povides the fix expected in r22709):
Michael Adam [Tue, 11 Sep 2007 16:15:36 +0000 (16:15 +0000)]
r25086: Fix interdomain trusts (this povides the fix expected in r22709):

Fix winbindd on a Samba DC talking to a trusted domain DC by
making it use the trusted domain password...


I hope this does not brake any other setup.

13 years agor25080: Once we decrypted the packet but have timing problems (closkew, tkt not yet or
Günther Deschner [Tue, 11 Sep 2007 14:56:43 +0000 (14:56 +0000)]
r25080: Once we decrypted the packet but have timing problems (closkew, tkt not yet or
no longer valid) there is no point to bother the keytab routines.


13 years agor25074: as all requests in the winbindd child are sync, we can use talloc_tos()
Stefan Metzmacher [Tue, 11 Sep 2007 10:21:34 +0000 (10:21 +0000)]
r25074: as all requests in the winbindd child are sync, we can use talloc_tos()


13 years agor25068: Older samba3 DCs will return DCERPC_FAULT_OP_RNG_ERROR for every opcode on the
Günther Deschner [Mon, 10 Sep 2007 23:12:27 +0000 (23:12 +0000)]
r25068: Older samba3 DCs will return DCERPC_FAULT_OP_RNG_ERROR for every opcode on the
LSARPC_DS pipe, continue with no_lsarpc_ds mode here as well to get
domain->initialized set to True. This avoids permanent scanning of Samba3 DCs
in winbindd. Thanks Michael, for pointing this out.


13 years agor25064: We use BOOL/True/False not bool/true/false
Simo Sorce [Mon, 10 Sep 2007 19:19:59 +0000 (19:19 +0000)]
r25064: We use BOOL/True/False not bool/true/false

13 years agor25063: Fix segfault in smbldp_set_creds when we want to use anonymous, the
Simo Sorce [Mon, 10 Sep 2007 19:14:22 +0000 (19:14 +0000)]
r25063: Fix segfault in smbldp_set_creds when we want to use anonymous, the
code was not passing in the "anon" flag correctly and was passing
NULL pointers.

13 years agor25062: Reformat, remove trailing spaces and fit lines into 80 columns
Simo Sorce [Mon, 10 Sep 2007 19:04:57 +0000 (19:04 +0000)]
r25062: Reformat, remove trailing spaces and fit lines into 80 columns

13 years agor25061: Pro-actively shut up Coverity :-)
Volker Lendecke [Mon, 10 Sep 2007 17:49:51 +0000 (17:49 +0000)]
r25061: Pro-actively shut up Coverity :-)

13 years agor25060: Fix formatting, remove trailing spaces and cut lines longer than 80 chars
Simo Sorce [Mon, 10 Sep 2007 16:56:51 +0000 (16:56 +0000)]
r25060: Fix formatting, remove trailing spaces and cut lines longer than 80 chars

13 years agor25059: Apply to 3.2 as well
Simo Sorce [Mon, 10 Sep 2007 16:21:55 +0000 (16:21 +0000)]
r25059: Apply to 3.2 as well

13 years agor25057: Add a schema file ready to be used in Fedora/RedHat Directory Server
Simo Sorce [Mon, 10 Sep 2007 15:14:39 +0000 (15:14 +0000)]
r25057: Add a schema file ready to be used in Fedora/RedHat Directory Server

13 years agor25055: Add file_id_string_tos
Volker Lendecke [Mon, 10 Sep 2007 10:56:07 +0000 (10:56 +0000)]
r25055: Add file_id_string_tos

This removes file_id_string_static and file_id_string_static2

13 years agor25049: Set new, more secure defaults for Samba 3.2.
Andrew Bartlett [Mon, 10 Sep 2007 02:14:18 +0000 (02:14 +0000)]
r25049: Set new, more secure defaults for Samba 3.2.

Andrew Bartlett

13 years agor25040: Add "net sam rights"
Volker Lendecke [Sat, 8 Sep 2007 20:30:51 +0000 (20:30 +0000)]
r25040: Add "net sam rights"

Not strictly in the SAM, but close enough. This command acts directly on
the local tdb, no running smbd required

This also changes the root-only check to a warning

13 years agor25036: Fix a become/unbecome_root() pair
Volker Lendecke [Sat, 8 Sep 2007 17:08:59 +0000 (17:08 +0000)]
r25036: Fix a become/unbecome_root() pair

13 years agor25032: Contact an off site DC if non is available on site.
Lars Müller [Sat, 8 Sep 2007 14:56:11 +0000 (14:56 +0000)]
r25032: Contact an off site DC if non is available on site.

13 years agor25030: ip_srv_nonsite and count_nonsite are initialized in get_kdc_list() in any
Lars Müller [Sat, 8 Sep 2007 13:53:08 +0000 (13:53 +0000)]
r25030: ip_srv_nonsite and count_nonsite are initialized in get_kdc_list() in any

13 years agor25025: Remove an unused function
Volker Lendecke [Sat, 8 Sep 2007 10:30:11 +0000 (10:30 +0000)]
r25025: Remove an unused function

13 years agor25024: Fix a whole bunch of Coverity bugs
Volker Lendecke [Sat, 8 Sep 2007 09:15:08 +0000 (09:15 +0000)]
r25024: Fix a whole bunch of Coverity bugs

The callers of get_domain_group_from_sid() with some justification
expected map->gid to be initialized when get_domain_group_from_sid
returned True.

13 years agor25023: Coverity #455. Not actually a bug, but this clarifies
Jeremy Allison [Sat, 8 Sep 2007 05:35:10 +0000 (05:35 +0000)]
r25023: Coverity #455. Not actually a bug, but this clarifies
the code a lot.

13 years agor25022: Fix coverity #395. Resource leak on error.
Jeremy Allison [Sat, 8 Sep 2007 05:18:08 +0000 (05:18 +0000)]
r25022: Fix coverity #395. Resource leak on error.

13 years agor25021: Fix coverity #435. Use of -1.
Jeremy Allison [Sat, 8 Sep 2007 05:12:17 +0000 (05:12 +0000)]
r25021: Fix coverity #435. Use of -1.

13 years agor25020: Fix coverity #374, possible null deref.
Jeremy Allison [Sat, 8 Sep 2007 04:57:17 +0000 (04:57 +0000)]
r25020: Fix coverity #374, possible null deref.

13 years agor25019: Fix coverity bug #105, run #332. Use of uninitialized variable.
Jeremy Allison [Sat, 8 Sep 2007 04:45:59 +0000 (04:45 +0000)]
r25019: Fix coverity bug #105, run #332. Use of uninitialized variable.

13 years agor25011: We don't use mangle_map any more.
Jeremy Allison [Fri, 7 Sep 2007 22:54:43 +0000 (22:54 +0000)]
r25011: We don't use mangle_map any more.

13 years agor25009: Large patch discussed with Volker. Move unix_convert to a talloc-based
Jeremy Allison [Fri, 7 Sep 2007 20:57:01 +0000 (20:57 +0000)]
r25009: Large patch discussed with Volker. Move unix_convert to a talloc-based
interface. More development will come on top of this. Remove the
"mangled map" parameter.

13 years agor25002: Refactor out code duplication created by the previous
Michael Adam [Fri, 7 Sep 2007 15:45:39 +0000 (15:45 +0000)]
r25002: Refactor out code duplication created by the previous
unification of r24998.


13 years agor24999: Use the new regval_compose() function in regval_ctr_addvalue().
Michael Adam [Fri, 7 Sep 2007 14:54:30 +0000 (14:54 +0000)]
r24999: Use the new regval_compose() function in regval_ctr_addvalue().


13 years agor24998: Add a function regval_compose() to compose a REGISTRY_VALUE from
Michael Adam [Fri, 7 Sep 2007 14:41:49 +0000 (14:41 +0000)]
r24998: Add a function regval_compose() to compose a REGISTRY_VALUE from
input data. Use this function in a first step to refactor
the canonicalization code of smbconf_store_values().


13 years agor24996: Eliminate more trailing spaces...
Michael Adam [Fri, 7 Sep 2007 13:54:56 +0000 (13:54 +0000)]
r24996: Eliminate more trailing spaces...

13 years agor24993: Apply some const
Volker Lendecke [Fri, 7 Sep 2007 12:13:16 +0000 (12:13 +0000)]
r24993: Apply some const

13 years agor24991: Kill all those lots of trailing whitespaces from secrets.c.
Michael Adam [Fri, 7 Sep 2007 09:14:44 +0000 (09:14 +0000)]
r24991: Kill all those lots of trailing whitespaces from secrets.c.
These red bars in vi really hurt my eyes... :-o


13 years agor24990: Kill an incredible amount of trailing whitespaces...
Michael Adam [Fri, 7 Sep 2007 08:54:48 +0000 (08:54 +0000)]
r24990: Kill an incredible amount of trailing whitespaces...
Further reformat get_trust_pw to conform to coding rules.


13 years agor24981: - Use the formal syntax for calling functions through pointers. I've wanted
Derrell Lipman [Thu, 6 Sep 2007 13:21:31 +0000 (13:21 +0000)]
r24981: - Use the formal syntax for calling functions through pointers.  I've wanted
  to make this change for ages, but now with the issue of "open" requiring it,
  this is the time to just do all of them.


13 years agor24978: move domain_init_recv() near the functions that uses it
Stefan Metzmacher [Thu, 6 Sep 2007 11:08:44 +0000 (11:08 +0000)]
r24978: move domain_init_recv() near the functions that uses it


13 years agor24977: Ensure negative caching for name2sid, sid2name and rids2names
Rafal Szczesniak [Thu, 6 Sep 2007 11:07:58 +0000 (11:07 +0000)]
r24977: Ensure negative caching for name2sid, sid2name and rids2names


13 years agor24974: catch SIGINT and SIGQUIT like SIGTERM
Stefan Metzmacher [Thu, 6 Sep 2007 10:51:17 +0000 (10:51 +0000)]
r24974: catch SIGINT and SIGQUIT like SIGTERM


13 years agor24970: Polish some comments and add my (C).
Michael Adam [Wed, 5 Sep 2007 16:01:27 +0000 (16:01 +0000)]
r24970: Polish some comments and add my (C).


13 years agor24969: Fwd port "open" patch
Simo Sorce [Wed, 5 Sep 2007 12:53:56 +0000 (12:53 +0000)]
r24969: Fwd port "open" patch

13 years agor24955: Reformat some object lists in to minimize the diff.
Michael Adam [Tue, 4 Sep 2007 14:54:00 +0000 (14:54 +0000)]
r24955: Reformat some object lists in to minimize the diff.

13 years agor24954: Fix the build without krb5.
Günther Deschner [Tue, 4 Sep 2007 14:32:28 +0000 (14:32 +0000)]
r24954: Fix the build without krb5.


13 years agor24952: Set the kdc locator env vars. This makes the krb5 locator plugin fully
Günther Deschner [Tue, 4 Sep 2007 14:06:33 +0000 (14:06 +0000)]
r24952: Set the kdc locator env vars. This makes the krb5 locator plugin fully
operational (from within winbindd and outside).


13 years agor24951: Warn if "os level" > 255
Volker Lendecke [Tue, 4 Sep 2007 13:21:24 +0000 (13:21 +0000)]
r24951: Warn if "os level" > 255

Thanks to Karolin Seeger <>

13 years agor24949: Remove some static buffers
Volker Lendecke [Tue, 4 Sep 2007 10:15:04 +0000 (10:15 +0000)]
r24949: Remove some static buffers

13 years agor24943: Some stackframes
Volker Lendecke [Tue, 4 Sep 2007 05:39:06 +0000 (05:39 +0000)]
r24943: Some stackframes

13 years agor24920: Reformatting.
Günther Deschner [Mon, 3 Sep 2007 12:23:45 +0000 (12:23 +0000)]
r24920: Reformatting.


13 years agor24903: One more tick in #if 0 code
Volker Lendecke [Sun, 2 Sep 2007 17:50:05 +0000 (17:50 +0000)]
r24903: One more tick in #if 0 code

13 years agor24902: DEBUG might use talloc_tos() itself...
Volker Lendecke [Sun, 2 Sep 2007 17:48:01 +0000 (17:48 +0000)]
r24902: DEBUG might use talloc_tos() itself...

13 years agor24879: Activate the winbindd cache-validation message handler.
Michael Adam [Sun, 2 Sep 2007 00:32:57 +0000 (00:32 +0000)]
r24879: Activate the winbindd cache-validation message handler.
Now the winbindd cache can be checked at runtime by
calling "smbcontrol winbindd validate-cache".

For the execution of the validation code, I fork a child
and in the child restore the default SIGCHLD handler in
order for the fork/waitpid mechanism of tdb_validate to work.


13 years agor24877: Don't panic in tdb validation code when the fork or waitpid fails.
Michael Adam [Sun, 2 Sep 2007 00:23:02 +0000 (00:23 +0000)]
r24877: Don't panic in tdb validation code when the fork or waitpid fails.
Return error instead.


13 years agor24864: - Correct failure of libsmbclient against a version of Windows found on a NAS
Derrell Lipman [Sat, 1 Sep 2007 18:34:50 +0000 (18:34 +0000)]
r24864: - Correct failure of libsmbclient against a version of Windows found on a NAS
  device.  The device resets a NBT connection on port 139 when it receives a
  NetBIOS keepalive request.  That request should be supported when NetBIOS is
  in use; Windows is behaving badly.

  libsmbclient needs a way to determine if a connection is still alive, and
  was using a NetBIOS keepalive request if port 139 was in use (on the
  assumption that it was probably NBT), and getpeername() when port 139 was
  not being used (assuming naked transport).

  This patch simplifies the code by exclusively using getpeername() to check
  whether a connection is still alive.  The NetBIOS keepalive request is
  optional anyway (with preference being given to using TCP mechanisms for the
  same purpose), so this should be both simpler and more reliable.


13 years agor24853: Rename function as Jerry asked.
Rafal Szczesniak [Fri, 31 Aug 2007 21:25:53 +0000 (21:25 +0000)]
r24853: Rename function as Jerry asked.


13 years agor24848: Make tdb_validate() take an open tdb handle instead of a file name.
Michael Adam [Fri, 31 Aug 2007 16:30:40 +0000 (16:30 +0000)]
r24848: Make tdb_validate() take an open tdb handle instead of a file name.
A new wrapper tdb_validate_open() takes a filename an opens and closes
the tdb before and after calling tdb_validate() respectively.

winbindd_validata_cache_nobackup() now dynamically calls one of
the above functions depending on whether the cache tdb has already
been opened or not.


13 years agor24847: Change standard failure return code of tdb_validate from "-1" to "1".
Michael Adam [Fri, 31 Aug 2007 15:51:05 +0000 (15:51 +0000)]
r24847: Change standard failure return code of tdb_validate from "-1" to "1".
(This is more safely used with casts from int to uint8, e.g.)


13 years agor24845: Fix a segfault in smbcontrol when called with parameters but no extra args.
Michael Adam [Fri, 31 Aug 2007 15:34:26 +0000 (15:34 +0000)]
r24845: Fix a segfault in smbcontrol when called with parameters but no extra args.


13 years agor24843: Add a "validate-cache" control message to winbindd.
Michael Adam [Fri, 31 Aug 2007 15:24:43 +0000 (15:24 +0000)]
r24843: Add a "validate-cache" control message to winbindd.
So there is a new subcommand "smbcontrol winbindd validate-cache" now.

This change provides the infrastructure:
The function currently returns "true" unconditionally.
The call of a real cache validation function will be incorporated
in subsequent changes.


13 years agor24842: Fix build warning.
Günther Deschner [Fri, 31 Aug 2007 15:01:50 +0000 (15:01 +0000)]
r24842: Fix build warning.


13 years agor24841: The locator has no dependencies to ldap libs anymore. Also fix the build.
Günther Deschner [Fri, 31 Aug 2007 14:58:26 +0000 (14:58 +0000)]
r24841: The locator has no dependencies to ldap libs anymore. Also fix the build.


13 years agor24838: Now for real: build the locator, if we can.
Günther Deschner [Fri, 31 Aug 2007 13:51:02 +0000 (13:51 +0000)]
r24838: Now for real: build the locator, if we can.


13 years agor24836: Initialize some uninitialized variables.
Michael Adam [Fri, 31 Aug 2007 13:39:51 +0000 (13:39 +0000)]
r24836: Initialize some uninitialized variables.
This prevents a segfault when get_kdc_ip_string() is called
with sitename == NULL.


13 years agor24833: Move locator to nsswitch (does not belong to libads anymore).
Günther Deschner [Fri, 31 Aug 2007 12:21:18 +0000 (12:21 +0000)]
r24833: Move locator to nsswitch (does not belong to libads anymore).