From: Robin Hack <hack.robin@gmail.com>
Date: Tue, 26 Apr 2016 11:02:01 +0000 (+0200)
Subject: talloc/testsuite: Fix CID 1291641 - Logically dead code
X-Git-Tag: talloc-2.1.7~124
X-Git-Url: http://git.samba.org/samba.git/?p=sfrench%2Fsamba-autobuild%2F.git;a=commitdiff_plain;h=b9ffb9322b987409693e4faa277b5e3f46ad8b22

talloc/testsuite: Fix CID 1291641 - Logically dead code

Add check for snprintf return code.

Signed-off-by: Robin Hack <hack.robin@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/lib/talloc/testsuite.c b/lib/talloc/testsuite.c
index 34410b81c3f..5eab839f51d 100644
--- a/lib/talloc/testsuite.c
+++ b/lib/talloc/testsuite.c
@@ -1795,11 +1795,11 @@ static bool test_pthread_talloc_passing(void)
 	 * They will use their own toplevel contexts.
 	 */
 	for (i = 0; i < NUM_THREADS; i++) {
-		(void)snprintf(str_array[i],
-				20,
-				"thread:%d",
-				i);
-		if (str_array[i] == NULL) {
+		ret = snprintf(str_array[i],
+			       20,
+			       "thread:%d",
+			       i);
+		if (ret < 0) {
 			printf("snprintf %d failed\n", i);
 			return false;
 		}