From: Timur I. Bakeyev <timur@iXsystems.com>
Date: Mon, 11 Jun 2018 20:38:00 +0000 (+0800)
Subject: Fix UDP DNS queries in addns
X-Git-Tag: tevent-0.9.37~384
X-Git-Url: http://git.samba.org/samba.git/?p=sfrench%2Fsamba-autobuild%2F.git;a=commitdiff_plain;h=83cd68c8ae7e4febbfbabd11172f7a2e2eef4368

Fix UDP DNS queries in addns

The addns code tries to use common approach for TCP and UDP queries,
calling connect() for both types of sockets. In case of UDP that
requires to use send() instead of sendto().

Signed-off-by: Timur I. Bakeyev <timur@iXsystems.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jun 13 03:51:04 CEST 2018 on sn-devel-144
---

diff --git a/lib/addns/dnssock.c b/lib/addns/dnssock.c
index ec42b7ca689..30b8fa2eaf4 100644
--- a/lib/addns/dnssock.c
+++ b/lib/addns/dnssock.c
@@ -221,9 +221,7 @@ static DNS_ERROR dns_send_udp(struct dns_connection *conn,
 	ssize_t ret;
 
 	do {
-		ret = sendto(conn->s, buf->data, buf->offset, 0,
-		     (struct sockaddr *)&conn->RecvAddr,
-		     sizeof(conn->RecvAddr));
+		ret = send(conn->s, buf->data, buf->offset, 0);
 	} while ((ret == -1) && (errno == EINTR));
 
 	if (ret != buf->offset) {