From: Jeremy Allison <jra@samba.org>
Date: Wed, 10 Nov 2004 19:34:50 +0000 (+0000)
Subject: r3663: Fix too tight checking of incoming secondary trans2 requests.
X-Git-Tag: samba-misc-tags/initial-v3-0-unstable~5620
X-Git-Url: http://git.samba.org/samba.git/?p=sfrench%2Fsamba-autobuild%2F.git;a=commitdiff_plain;h=44132c39ecbf055b897b1aa7bfca4eb1731badbf

r3663: Fix too tight checking of incoming secondary trans2 requests.
Found by Stefan Esser <s.esser@e-matters.de>.
Jeremy.
---

diff --git a/source/smbd/trans2.c b/source/smbd/trans2.c
index 4c0d5731eb8..ca2c8a060dc 100644
--- a/source/smbd/trans2.c
+++ b/source/smbd/trans2.c
@@ -4161,7 +4161,7 @@ int reply_trans2(connection_struct *conn,
 				goto bad_param;
 			
 			if (num_params) {
-				if (param_disp + num_params >= total_params)
+				if (param_disp + num_params > total_params)
 					goto bad_param;
 				if ((param_disp + num_params < param_disp) ||
 						(param_disp + num_params < num_params))
@@ -4177,7 +4177,7 @@ int reply_trans2(connection_struct *conn,
 				memcpy( &params[param_disp], smb_base(inbuf) + param_off, num_params);
 			}
 			if (num_data) {
-				if (data_disp + num_data >= total_data)
+				if (data_disp + num_data > total_data)
 					goto bad_param;
 				if ((data_disp + num_data < data_disp) ||
 						(data_disp + num_data < num_data))