From: Slava Semushin <php-coder@altlinux.ru>
Date: Sat, 6 Jun 2009 14:53:38 +0000 (+0700)
Subject: testsuite/nsswitch/get{gr,pw}ent_r.c(dump_{gr,pw}ent): fixed wrong condition.
X-Git-Tag: tdb-1.1.5~232
X-Git-Url: http://git.samba.org/samba.git/?p=sfrench%2Fsamba-autobuild%2F.git;a=commitdiff_plain;h=3f5403220f2e3c0df4e436f908b97fe8cafd6616

testsuite/nsswitch/get{gr,pw}ent_r.c(dump_{gr,pw}ent): fixed wrong condition.

When fopen() fails it return NULL, so condition where return value
less than zero never evaluated to truth.

Found by cppcheck.
---

diff --git a/testsuite/nsswitch/getgrent_r.c b/testsuite/nsswitch/getgrent_r.c
index 3eac8aa218d..4f1f0ce8f5e 100644
--- a/testsuite/nsswitch/getgrent_r.c
+++ b/testsuite/nsswitch/getgrent_r.c
@@ -21,7 +21,7 @@ void dump_grent(char *id)
 
     sprintf(fname, "/tmp/getgrent_r-%s.out-%d", id, getpid());
 
-    if ((fptr = fopen(fname, "w")) < 0) {
+    if ((fptr = fopen(fname, "w")) == NULL) {
         fprintf(stderr, "ERROR: could not open file %s: %s\n", fname,
                 sys_errlist[errno]);
         return;
diff --git a/testsuite/nsswitch/getpwent_r.c b/testsuite/nsswitch/getpwent_r.c
index 2ba7ea96f1e..5e774911de7 100644
--- a/testsuite/nsswitch/getpwent_r.c
+++ b/testsuite/nsswitch/getpwent_r.c
@@ -21,7 +21,7 @@ void dump_pwent(char *id)
 
     sprintf(fname, "/tmp/getpwent_r-%s.out-%d", id, getpid());
 
-    if ((fptr = fopen(fname, "w")) < 0) {
+    if ((fptr = fopen(fname, "w")) == 0) {
         fprintf(stderr, "ERROR: could not open file %s: %s\n", fname,
                 sys_errlist[errno]);
         return;