From: Martin Schwenke <martin@meltin.net>
Date: Mon, 23 Mar 2015 08:37:35 +0000 (+1100)
Subject: ctdb-scripts: Optimise update_tickles()
X-Git-Tag: tevent-0.9.31~440
X-Git-Url: http://git.samba.org/samba.git/?p=sfrench%2Fsamba-autobuild%2F.git;a=commitdiff_plain;h=30c56a0c801dfb64085013a87ddedb1cd76b42a9

ctdb-scripts: Optimise update_tickles()

Use addtickle and deltickle with stdin.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
---

diff --git a/ctdb/config/functions b/ctdb/config/functions
index a29daf58f6e..d5443f5767a 100755
--- a/ctdb/config/functions
+++ b/ctdb/config/functions
@@ -1276,16 +1276,12 @@ update_tickles ()
 	sort >"$_my_tickles"
 
 	# Add tickles for connections that we haven't already got tickles for
-	comm -23 "$_my_connections" "$_my_tickles" |
-	while read _src _dst ; do
-		$CTDB addtickle "$_src" "$_dst"
-	done
+	comm -23 "$_my_connections" "$_my_tickles" | \
+		$CTDB addtickle
 
 	# Remove tickles for connections that are no longer there
-	comm -13 "$_my_connections" "$_my_tickles" |
-	while read _src _dst ; do
-		$CTDB deltickle "$_src" "$_dst"
-	done
+	comm -13 "$_my_connections" "$_my_tickles" | \
+		$CTDB deltickle
 
 	rm -f "$_my_connections" "$_my_tickles"