ldb_tdb: Remove unnecessary call to tdb_get_seqnum
authorGarming Sam <garming@catalyst.net.nz>
Wed, 7 Mar 2018 00:27:20 +0000 (13:27 +1300)
committerAndreas Schneider <asn@cryptomilk.org>
Thu, 8 Mar 2018 13:14:37 +0000 (14:14 +0100)
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Mar  8 14:14:37 CET 2018 on sn-devel-144

lib/ldb/ldb_tdb/ldb_tdb.c

index 4f1c241e96aecb1bc7bc184ba861967e9e3ab568..9c8c77155c4885812c527dd435f29ce7e63cf35c 100644 (file)
@@ -1799,11 +1799,12 @@ static const char * ltdb_tdb_name(struct ltdb_private *ltdb)
 
 static bool ltdb_tdb_changed(struct ltdb_private *ltdb)
 {
-       bool ret = (tdb_get_seqnum(ltdb->tdb) != ltdb->tdb_seqnum);
+       int seq = tdb_get_seqnum(ltdb->tdb);
+       bool has_changed = (seq != ltdb->tdb_seqnum);
 
-       ltdb->tdb_seqnum = tdb_get_seqnum(ltdb->tdb);
+       ltdb->tdb_seqnum = seq;
 
-       return ret;
+       return has_changed;
 }
 
 static const struct kv_db_ops key_value_ops = {