s3:winbind: Fix bug 6793 -- segfault in winbindd_pam_auth
authorVolker Lendecke <vl@samba.org>
Wed, 14 Oct 2009 18:14:57 +0000 (11:14 -0700)
committerJeremy Allison <jra@samba.org>
Wed, 14 Oct 2009 18:14:57 +0000 (11:14 -0700)
source3/winbindd/winbindd_pam.c

index edbaa55e9b75aeea48a2e2233d4402d3cbbd2cf2..6d27512193aeda5dfa8ebec55fc93cb07942f0a7 100644 (file)
@@ -797,8 +797,8 @@ NTSTATUS append_auth_data(struct winbindd_cli_state *state,
 void winbindd_pam_auth(struct winbindd_cli_state *state)
 {
        struct winbindd_domain *domain;
-       fstring name_domain, name_user;
-       char *mapped_user = NULL;
+       fstring name_domain, name_user, mapped_user;
+       char *mapped = NULL;
        NTSTATUS result;
        NTSTATUS name_map_status = NT_STATUS_UNSUCCESSFUL;
 
@@ -822,15 +822,14 @@ void winbindd_pam_auth(struct winbindd_cli_state *state)
 
        name_map_status = normalize_name_unmap(state->mem_ctx,
                                               state->request->data.auth.user,
-                                              &mapped_user);
+                                              &mapped);
 
        /* If the name normalization didnt' actually do anything,
           just use the original name */
 
-       if (!NT_STATUS_IS_OK(name_map_status) &&
-           !NT_STATUS_EQUAL(name_map_status, NT_STATUS_FILE_RENAMED))
-       {
-               mapped_user = state->request->data.auth.user;
+       if (NT_STATUS_IS_OK(name_map_status)
+           ||NT_STATUS_EQUAL(name_map_status, NT_STATUS_FILE_RENAMED)) {
+               fstrcpy(mapped_user, mapped);
        }
 
        if (!canonicalize_username(mapped_user, name_domain, name_user)) {