s4:utils Explian fix for testparm -v

The problem here was that we take an address of a bool, and then (via
a void*) cast it to a int *, so put this in a comment.

Andrew Bartlett

diff --git a/source4/utils/testparm.c b/source4/utils/testparm.c
index d9cbac6536675843037db4d4bae89367cd55ba46..a71470a3a84b546c02bdc14f284f0566fa4ea30a 100644 (file)
--- a/source4/utils/testparm.c
+++ b/source4/utils/testparm.c
@@ -173,7 +173,6 @@ static int do_share_checks(struct loadparm_context *lp_ctx, const char *cname, c
 
  int main(int argc, const char *argv[])
 {
-       static bool silent_mode = false;
        int ret = 0;
        poptContext pc;
 /*
@@ -184,7 +183,12 @@ static int do_share_checks(struct loadparm_context *lp_ctx, const char *cname, c
        static char *parameter_name = NULL;
        static const char *cname;
        static const char *caddr;
-       static int show_defaults = false;
+       static int silent_mode = false;
+       static int show_defaults = false;  /* This must be an 'int',
+                                           * as we take it as we pass
+                                           * it's address as an int
+                                           * pointer  */
+.c
        struct loadparm_context *lp_ctx;
 
        struct poptOption long_options[] = {