lib/crypto: Detect CommonCrypto and use it if available

CommonCrypto/CommonDigest is available on Mac and there is function in
the libc for MD5 calculation. MD5Final is a C define of CC_MD5_Final.
Under some circumstance we have the symbol defined twice in samba
binaries on Snow Leopard at least.

By detecting CommonCrypto/CommonDigest we end up always using the system
version if available.

diff --git a/lib/crypto/md5.h b/lib/crypto/md5.h
index bcdf50c0008669a47650ceef58d725c8b35a0bde..388cdf83f093c3dd91cedcb234ca75be388cd6a3 100644 (file)
--- a/lib/crypto/md5.h
+++ b/lib/crypto/md5.h
@@ -9,6 +9,16 @@
 #ifdef HAVE_BSD_MD5_H
 /* Try to avoid clashes with BSD MD5 implementation */
 #include <bsd/md5.h>
+#else
+/* Try to use CommonCrypto on Mac as otherwise we can get MD5Final twice */
+#ifdef HAVE_COMMONCRYPTO_COMMONDIGEST_H
+#include <CommonCrypto/CommonDigest.h>
+
+#define MD5Init(c)                                     CC_MD5_Init(c)
+#define MD5Update(c,d,l)                       CC_MD5_Update(c,d,l)
+#define MD5Final(m, c)                         CC_MD5_Final((unsigned char *)m,c)
+#define MD5Context CC_MD5state_st
+
 #else
 typedef struct MD5Context {
        uint32_t buf[4];
@@ -22,6 +32,8 @@ void MD5Init(MD5_CTX *context);
 void MD5Update(MD5_CTX *context, const uint8_t *buf,
               size_t len);
 void MD5Final(uint8_t digest[MD5_DIGEST_LENGTH], MD5_CTX *context);
+#endif /* HAVE_COMMONCRYPTO_COMMONDIGEST_H */
+
 #endif /* HAVE_BSD_MD5_H */
 
 #endif /* !MD5_H */

diff --git a/lib/crypto/wscript_build b/lib/crypto/wscript_build
index f50269879b541ce2171a2da4cf8c70b8ed9fa2d4..849bf1664e4f071e04fe716c42e5c255c9ae88c3 100644 (file)
--- a/lib/crypto/wscript_build
+++ b/lib/crypto/wscript_build
@@ -4,7 +4,7 @@ extra_source = ''
 extra_deps = ''
 if bld.CONFIG_SET('HAVE_BSD_MD5_H'):
        extra_deps += ' bsd'
-else:
+elif not bld.CONFIG_SET('HAVE_COMMONCRYPTO_COMMONDIGEST_H'):
        extra_source += ' md5.c'
 
 bld.SAMBA_SUBSYSTEM('LIBCRYPTO',

diff --git a/lib/crypto/wscript_configure b/lib/crypto/wscript_configure
index 77d21e97955efa5535d9839388d6b3fed48db327..5fc00fb22cb81b3966822b68fc04ed1febad8804 100644 (file)
--- a/lib/crypto/wscript_configure
+++ b/lib/crypto/wscript_configure
@@ -1,2 +1,4 @@
 conf.CHECK_FUNCS_IN('MD5Init', 'bsd', headers='bsd/md5.h',
     checklibc=True)
+conf.CHECK_FUNCS_IN('CC_MD5_Init', '', headers='CommonCrypto/CommonDigest.h',
+    checklibc=True)

diff --git a/source3/Makefile.in b/source3/Makefile.in
index 5fcf8598e3d2736cd9f7c9df22d7b9a1c0c7c3c5..acd47b74670aef35ef4bfbe158669e86867f100c 100644 (file)
--- a/source3/Makefile.in
+++ b/source3/Makefile.in
@@ -422,7 +422,7 @@ UTIL_OBJ = ../lib/util/rbtree.o ../lib/util/signal.o ../lib/util/time.o \
                   ../lib/util/blocking.o ../lib/util/rfc1738.o \
                   ../lib/util/select.o ../lib/util/util_pw.o ../lib/util/server_id.o
 
-CRYPTO_OBJ = ../lib/crypto/crc32.o ../lib/crypto/md5.o \
+CRYPTO_OBJ = ../lib/crypto/crc32.o @CRYPTO_MD5_OBJ@ \
                         ../lib/crypto/hmacmd5.o ../lib/crypto/arcfour.o \
                         ../lib/crypto/md4.o \
                         ../lib/crypto/sha256.o ../lib/crypto/hmacsha256.o \

diff --git a/source3/configure.in b/source3/configure.in
index 3736dcbedb50f3b5a4e52d1d47c57a8ac1b4adff..e0fe79c9d0e681892526746c6a0316885d3eb836 100644 (file)
--- a/source3/configure.in
+++ b/source3/configure.in
@@ -750,12 +750,19 @@ AC_CHECK_HEADERS(xfs/libxfs.h)
 AC_CHECK_HEADERS(netgroup.h)
 AC_CHECK_HEADERS(linux/falloc.h)
 AC_CHECK_HEADERS(sys/uuid.h)
+AC_CHECK_HEADERS(CommonCrypto/CommonDigest.h)
 
 AC_CHECK_HEADERS(rpcsvc/yp_prot.h,,,[[
 #if HAVE_RPC_RPC_H
 #include <rpc/rpc.h>
 #endif
 ]])
+CRYPTO_MD5_OBJ=
+if test "x$ac_cv_header_CommonCrypto_CommonDigest_h" != "xyes"
+then
+       CRYPTO_MD5_OBJ="../lib/crypto/md5.o"
+fi
+AC_SUBST(CRYPTO_MD5_OBJ)
 
 ## These fail to compile on IRIX so just check for their presence
 AC_CHECK_HEADERS(sys/mode.h,,,)