ctdb-tests: Check an unchecked return value
authorMartin Schwenke <martin@meltin.net>
Wed, 11 Oct 2017 08:16:25 +0000 (19:16 +1100)
committerMartin Schwenke <martins@samba.org>
Mon, 16 Oct 2017 07:27:17 +0000 (09:27 +0200)
This can't fail but check it for completeness... just in case Coverity
decides to notice it.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Mon Oct 16 09:27:17 CEST 2017 on sn-devel-144

ctdb/tests/src/fake_ctdbd.c

index b0a251af9be3f3fd1b6bc4725eacb5f173f6d34c..af56e08d8944f46c3b5b6d6751d28d5a5e6398a0 100644 (file)
@@ -1966,11 +1966,17 @@ static void control_reload_nodes_file(TALLOC_CTX *mem_ctx,
                }
 
                if (nodemap->node[i].flags & NODE_FLAGS_DELETED) {
+                       int ret;
+
                        node = &node_map->node[i];
 
                        node->flags |= NODE_FLAGS_DELETED;
-                       ctdb_sock_addr_from_string("0.0.0.0", &node->addr,
-                                                  false);
+                       ret = ctdb_sock_addr_from_string("0.0.0.0", &node->addr,
+                                                        false);
+                       if (ret != 0) {
+                               /* Can't happen, but Coverity... */
+                               goto fail;
+                       }
 
                        continue;
                }