Revert "smbd: remove unused change_to_root_user() from brl_timeout_fn()"
authorRalph Boehme <slow@samba.org>
Thu, 27 Dec 2018 10:36:43 +0000 (11:36 +0100)
committerStefan Metzmacher <metze@samba.org>
Fri, 11 Jan 2019 22:11:15 +0000 (23:11 +0100)
This reverts commit c310647e560abc2343ef2ff0ab15daab0fba2650.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
source3/smbd/blocking.c

index 095c9edeacc0b80415ea5c8e956e41beb8ff39b6..c281aae619de4416d5f72d2c3659a4dd84b7dcc2 100644 (file)
@@ -47,6 +47,9 @@ void brl_timeout_fn(struct tevent_context *event_ctx,
                TALLOC_FREE(sconn->smb1.locks.brl_timeout);
        }
 
+       change_to_root_user();  /* TODO: Possibly run all timed events as
+                                * root */
+
        process_blocking_lock_queue(sconn);
 }