Add python tests for samba.gpo module

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

diff --git a/python/samba/tests/gpo.py b/python/samba/tests/gpo.py
new file mode 100644 (file)
index 0000000..bdcbcc6
--- /dev/null
+++ b/python/samba/tests/gpo.py
@@ -0,0 +1,70 @@
+# Unix SMB/CIFS implementation. Tests for smb manipulation
+# Copyright (C) David Mulder <dmulder@suse.com> 2018
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+import os
+from samba import gpo, tests
+from samba.param import LoadParm
+
+poldir = r'\\addom.samba.example.com\sysvol\addom.samba.example.com\Policies'
+dspath = 'CN=Policies,CN=System,DC=addom,DC=samba,DC=example,DC=com'
+gpt_data = '[General]\nVersion=%d'
+
+class GPOTests(tests.TestCase):
+    def setUp(self):
+        super(GPOTests, self).setUp()
+        self.server = os.environ["SERVER"]
+        self.lp = LoadParm()
+        self.lp.load_default()
+        self.creds = self.insta_creds(template=self.get_credentials())
+
+    def tearDown(self):
+        super(GPOTests, self).tearDown()
+
+    def test_gpo_list(self):
+        global poldir, dspath
+        ads = gpo.ADS_STRUCT(self.server, self.lp, self.creds)
+        if ads.connect():
+            gpos = ads.get_gpo_list(self.creds.get_username())
+        guid = '{31B2F340-016D-11D2-945F-00C04FB984F9}'
+        names = ['Local Policy', guid]
+        file_sys_paths = [None, '%s\\%s' % (poldir, guid)]
+        ds_paths = [None, 'CN=%s,%s' % (guid, dspath)]
+        for i in range(0, len(gpos)):
+            assert gpos[i].name == names[i], \
+              'The gpo name did not match expected name %s' % gpos[i].name
+            assert gpos[i].file_sys_path == file_sys_paths[i], \
+              'file_sys_path did not match expected %s' % gpos[i].file_sys_path
+            assert gpos[i].ds_path == ds_paths[i], \
+              'ds_path did not match expected %s' % gpos[i].ds_path
+
+    def test_gpt_version(self):
+        global gpt_data
+        local_path = self.lp.get("path", "sysvol")
+        policies = 'addom.samba.example.com/Policies'
+        guid = '{31B2F340-016D-11D2-945F-00C04FB984F9}'
+        gpo_path = os.path.join(local_path, policies, guid)
+        old_vers = gpo.gpo_get_sysvol_gpt_version(gpo_path)[1]
+
+        with open(os.path.join(gpo_path, 'GPT.INI'), 'w') as gpt:
+            gpt.write(gpt_data % 42)
+        assert gpo.gpo_get_sysvol_gpt_version(gpo_path)[1] == 42, \
+          'gpo_get_sysvol_gpt_version() did not return the expected version'
+
+        with open(os.path.join(gpo_path, 'GPT.INI'), 'w') as gpt:
+            gpt.write(gpt_data % old_vers)
+        assert gpo.gpo_get_sysvol_gpt_version(gpo_path)[1] == old_vers, \
+          'gpo_get_sysvol_gpt_version() did not return the expected version'
+

diff --git a/source4/selftest/tests.py b/source4/selftest/tests.py
index 345ed8c07d79caed15b174cccb55f0a5e39d2fcd..12064f331fb5b4f9e9acc3dda8f80ab05f281758 100755 (executable)
--- a/source4/selftest/tests.py
+++ b/source4/selftest/tests.py
@@ -618,6 +618,7 @@ planpythontestsuite("ad_dc:local", "samba.tests.samba_tool.dnscmd")
 planpythontestsuite("ad_dc_ntvfs:local", "samba.tests.dcerpc.rpcecho")
 
 planoldpythontestsuite("nt4_dc", "samba.tests.netbios", extra_args=['-U"$USERNAME%$PASSWORD"'], py3_compatible=True)
+planoldpythontestsuite("ad_dc:local", "samba.tests.gpo", extra_args=['-U"$USERNAME%$PASSWORD"'], py3_compatible=True)
 
 planoldpythontestsuite("ad_dc_ntvfs:local", "samba.tests.dcerpc.registry", extra_args=['-U"$USERNAME%$PASSWORD"'])
 planoldpythontestsuite("ad_dc_ntvfs", "samba.tests.dcerpc.dnsserver", extra_args=['-U"$USERNAME%$PASSWORD"'])