waf:lib/replace fix iconv checks on HP/UX

we need to copy away the list of LDFLAGS
to be tried before modifying it instead of
just creating a new reference and then continuing
with a modified list while it should have been
reset back to the original value

Bug: https://bugzilla.samba.org/show_bug.cgi?id=9911

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Feb 13 02:01:03 CET 2014 on sn-devel-104

diff --git a/lib/replace/wscript b/lib/replace/wscript
index ab95018402131774f8dc15926b3721bb9ce98b8e..cabf91fd5a8bbcd3648c9c915937d31d93cab7ec 100644 (file)
--- a/lib/replace/wscript
+++ b/lib/replace/wscript
@@ -398,7 +398,7 @@ removeea setea
         else:
             # Some hosts need lib iconv for linking with lib intl
             # So we try with flags just in case it helps.
         else:
             # Some hosts need lib iconv for linking with lib intl
             # So we try with flags just in case it helps.

-            oldflags = conf.env['EXTRA_LDFLAGS'];
+            oldflags = list(conf.env['EXTRA_LDFLAGS']);

             conf.env['EXTRA_LDFLAGS'].extend(["-liconv"])
             conf.CHECK_FUNCS_IN('dgettext gettext bindtextdomain textdomain bind_textdomain_codeset',
                                 'intl', checklibc=False, headers='libintl.h')
             conf.env['EXTRA_LDFLAGS'].extend(["-liconv"])
             conf.CHECK_FUNCS_IN('dgettext gettext bindtextdomain textdomain bind_textdomain_codeset',
                                 'intl', checklibc=False, headers='libintl.h')