git.samba.org
/
sfrench
/
samba-autobuild
/
.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5d720e5
)
r1428: Remove *completly bogus* memset. (No doubt my bug, too...).
author
Andrew Bartlett
<abartlet@samba.org>
Sat, 10 Jul 2004 03:26:43 +0000
(
03:26
+0000)
committer
Gerald (Jerry) Carter
<jerry@samba.org>
Wed, 10 Oct 2007 15:52:11 +0000
(10:52 -0500)
This memset could well have clobbered bits of the stack, because
session_key changed from
char session_key[16];
to
DATA_BLOB session_key
Andrew Bartlett
source/libsmb/clikrb5.c
patch
|
blob
|
history
diff --git
a/source/libsmb/clikrb5.c
b/source/libsmb/clikrb5.c
index b9a3dda494424e9eb64a4b8352676e4fa1181e21..5fcde4654add633112f7af778ba1d23dab73428a 100644
(file)
--- a/
source/libsmb/clikrb5.c
+++ b/
source/libsmb/clikrb5.c
@@
-442,8
+442,6
@@
failed:
krb5_error_code err;
BOOL ret = False;
- memset(session_key, 0, 16);
-
if (remote)
err = krb5_auth_con_getremotesubkey(context, auth_context, &skey);
else