s3:net registry check: do not silently replace separators

Signed-off-by: Michael Adam <obnox@samba.org>

diff --git a/source3/utils/net_registry_check.c b/source3/utils/net_registry_check.c
index 2511f534e6fb0b8bfacc63d7be45fefa4b7181c4..0ae2c962d34ddf558c658763f5f9ee419c5d4796 100644 (file)
--- a/source3/utils/net_registry_check.c
+++ b/source3/utils/net_registry_check.c
@@ -709,13 +709,14 @@ static bool normalize_path_internal(char* path, char sep) {
 static bool normalize_path(char* path, char sep) {
        static const char* SEPS = "\\/";
        char* firstsep = strpbrk(path, SEPS);
+       bool wrong_sep = (firstsep && (*firstsep != sep));
 
        assert (strchr(SEPS, sep));
 
-       if (firstsep && (*firstsep != sep)) {
+       if (wrong_sep) {
                string_replace(path, *firstsep, sep);
        }
-       return normalize_path_internal(path, sep);
+       return normalize_path_internal(path, sep) || wrong_sep;
 }
 
 static int check_tdb_action(struct db_record *rec, void *check_ctx)