r12946: fix a segfault in nmbd when 'wins support = yes' caused by double free
authorGerald Carter <jerry@samba.org>
Sun, 15 Jan 2006 12:30:36 +0000 (12:30 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 16:06:08 +0000 (11:06 -0500)
(This used to be commit c11372f4ec49634e2ae2e6b9ddf4d2b72976f9c5)

source3/nmbd/nmbd_namelistdb.c

index 894b8776134023aa91046eb7959affff6c1b8699..baaf5dbd5489f2bdfa70ff61fc7dd77a3b1bae0b 100644 (file)
@@ -82,9 +82,11 @@ void remove_name_from_namelist(struct subnet_record *subrec,
 {
        if (subrec == wins_server_subnet) {
                remove_name_from_wins_namelist(namerec);
-       } else {
-               subrec->namelist_changed = True;
-       }
+               return;
+       } 
+
+       subrec->namelist_changed = True;
+
        DLIST_REMOVE(subrec->namelist, namerec);
        SAFE_FREE(namerec->data.ip);
        ZERO_STRUCTP(namerec);