s3: Move #define VALGRIND to config.h

This fixes the valgrind overrun in the tdb jenkins hash

diff --git a/source3/configure.in b/source3/configure.in
index 630c8541ee4b0169218d5bacd169ae0fb81ca733..2db1b39cab7969031fc94ba3220256f1b659fa1f 100644 (file)
--- a/source3/configure.in
+++ b/source3/configure.in
@@ -759,6 +759,13 @@ CPPFLAGS="$old_CPPFLAGS"
 # subdirectory of headers.
 AC_CHECK_HEADERS(valgrind.h valgrind/valgrind.h valgrind/memcheck.h)
 
+if test x"$enable_developer" = x"yes" ; then
+   if test x"$ac_cv_header_valgrind_h" = xyes -o \
+           x"$ac_cv_header_valgrind_valgrind_h" = xyes ; then
+      AC_DEFINE(VALGRIND,1,[Whether we have valgrind headers])
+   fi
+fi
+
 #
 # HPUX has a bug in that including shadow.h causes a re-definition of MAXINT.
 # This causes configure to fail to detect it. Check for shadow separately on HPUX.

diff --git a/source3/include/includes.h b/source3/include/includes.h
index a17e014ca91c3d1f7b3ed3d1941982b2dffdc7c4..11066e25ad27a07b1150e15f75741bfe4922066a 100644 (file)
--- a/source3/include/includes.h
+++ b/source3/include/includes.h
@@ -251,16 +251,6 @@ typedef int ber_int_t;
 #include <valgrind.h>
 #endif
 
-/* If we have --enable-developer and the valgrind header is present,
- * then we're OK to use it.  Set a macro so this logic can be done only
- * once. */
-#if defined(DEVELOPER)
-#if (HAVE_VALGRIND_H || HAVE_VALGRIND_VALGRIND_H)
-#define VALGRIND
-#endif
-#endif
-
-
 /* we support ADS if we want it and have krb5 and ldap libs */
 #if defined(WITH_ADS) && defined(HAVE_KRB5) && defined(HAVE_LDAP)
 #define HAVE_ADS