s3:smbd: add comment about returning STATUS_BUFFER_OVERFLOW in pipe_read_andx_done()
authorStefan Metzmacher <metze@samba.org>
Wed, 28 Apr 2010 12:36:10 +0000 (14:36 +0200)
committerStefan Metzmacher <metze@samba.org>
Wed, 28 Apr 2010 13:46:23 +0000 (15:46 +0200)
metze

source3/smbd/pipes.c

index 9bc3fdfdf6d46ae3797b219c8a7c4da90236ad25..aff5f5349596c49269e0216d7d60406a41a56c5d 100644 (file)
@@ -449,7 +449,21 @@ static void pipe_read_andx_done(struct tevent_req *subreq)
        state->outbuf = NULL;
 
        srv_set_message((char *)req->outbuf, 12, nread, False);
-  
+
+#if 0
+       /*
+        * we should return STATUS_BUFFER_OVERFLOW if there's
+        * out standing data.
+        *
+        * But we can't enable it yet, as it has bad interactions
+        * with fixup_chain_error_packet() in chain_reply().
+        */
+       if (is_data_outstanding) {
+               error_packet_set((char *)req->outbuf, ERRDOS, ERRmoredata,
+                                STATUS_BUFFER_OVERFLOW, __LINE__, __FILE__);
+       }
+#endif
+
        SSVAL(req->outbuf,smb_vwv5,nread);
        SSVAL(req->outbuf,smb_vwv6,
              req_wct_ofs(req)